IRC log for #koha, 2020-06-10

← Previous day | Today | Next day → | Search | Index

All times shown according to UTC.

Time Nick Message
00:00 khall joined #koha
00:19 khall joined #koha
00:22 khall joined #koha
00:26 lukeG1 joined #koha
00:43 morrism joined #koha
00:51 inlibro joined #koha
01:09 khall joined #koha
01:45 khall joined #koha
01:51 inlibro joined #koha
02:14 morrism joined #koha
02:51 inlibro joined #koha
02:58 cait joined #koha
03:16 indradg joined #koha
03:43 Gary joined #koha
03:43 Gary ANyone active right now?
03:44 I have a fresh install on debian, currenlty pushing through the onboarding and keep getting stuck at the 'Create a patron category' page when it asks for 'please only choose one enrollment period'
03:51 inlibro joined #koha
03:56 Gary Hello @inlibro
04:07 lavamind joined #koha
04:31 kivilahtio_ joined #koha
04:51 inlibro joined #koha
05:05 chris joined #koha
05:52 inlibro joined #koha
06:13 did joined #koha
06:34 cait joined #koha
06:42 reiveune joined #koha
06:43 reiveune hello
06:44 alex_a joined #koha
06:45 alex_a Bonjour
06:45 wahanui niihau, alex_a
06:52 inlibro joined #koha
07:01 cait1 joined #koha
07:13 cait joined #koha
07:20 kohaputti joined #koha
07:27 davidnind joined #koha
07:30 andreashm joined #koha
07:39 andreashm joined #koha
07:52 inlibro joined #koha
07:56 andreashm joined #koha
07:56 andreashm joined #koha
07:57 andreashm joined #koha
07:58 andreashm joined #koha
07:59 andreashm joined #koha
07:59 andreashm joined #koha
08:14 kohaputti joined #koha
08:20 andreashm joined #koha
08:52 inlibro joined #koha
09:10 andreashm joined #koha
09:27 Joubu ashimema, tcohen: please have a look at bug 25538
09:27 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=25538 major, P5 - low, ---, jonathan.druart, Needs Signoff , www/search_utf8.t is failing randomly
09:51 morrism joined #koha
09:52 inlibro joined #koha
09:59 khall joined #koha
10:00 did hi,
10:01 can Koha run  WITHOUT zebra installed at all?
10:02 kohaputti did, yup, with elasticsearch, and I guess it works even if you don't have elasticsearch but lots of things are then non-functional
10:03 it probably works the same way if you have selected zebra as the searchengine but don't have it running, not totally sure.
10:05 did kohaputti: thanks, yes with ES but without zebra, seems to me at least zebraqueue is never purged but it's populated by bug 16248
10:05 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=16248 normal, P5 - low, ---, tomascohen, CLOSED FIXED, ModZebra doesn't update zebraqueue if ES is enabled
10:05 khall_ joined #koha
10:07 Joubu kidclamp: can you have a look at bug 25701 please?
10:07 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=25701 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Facets display in random order
10:10 kidclamp looking
10:23 davidnind Joubu: your patch for 25701 works for me, let me know if you want it signed off.
10:24 Joubu davidnind: yes please :)
10:26 davidnind done!
10:27 Joubu thx
10:30 khall joined #koha
10:32 ashimema Thanks for picking off bug 25701 Joubu.. that was likely to end up on my list but after the accessibility work I'm in the middle of.. really happy to see that one done
10:32 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=25701 normal, P5 - low, ---, jonathan.druart, Signed Off , Facets display in random order
10:32 ashimema looking at bug 25538 now
10:32 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=25538 major, P5 - low, ---, jonathan.druart, Needs Signoff , www/search_utf8.t is failing randomly
10:40 ashimema -i seems sane to me
10:44 kohaputti joined #koha
10:46 Joubu UI question - https://snipboard.io/TNvaDf.jpg => What's the "(1)" in the item list?
10:46 how can you have more than 1 there?
10:50 ashimema mm.. seems a little odd to me
10:52 kidclamp make another with same callnumber
10:52 same availability. same home/holding, same location, same collection, same callnumber
10:52 inlibro joined #koha
10:54 davidnind On master for me it shows as one line with 4 in brackets - doesn't show the [CN_XX], so maybe a system preference?
10:54 Joubu kidclamp: https://snipboard.io/Cslw8V.jpg - there are 2 CN_1
10:56 kidclamp https://snipboard.io/5dham4.jpg
10:56 ashimema regarding bug 25538 we actually already optionally allow setting a login shell.. should be instead be using that for running the tests?
10:56 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=25538 major, P5 - low, ---, jonathan.druart, Needs Signoff , www/search_utf8.t is failing randomly
10:56 ashimema as opposed to hard coding -i
10:57 kidclamp Joubu: see my link above
10:57 ashimema literally.. the line above your change
10:57 --login == -i in my reading
10:57 andreash_ joined #koha
10:58 Joubu ashimema: I don't understand. If you remove the -i you cannot `kshell` correctly
10:58 kidclamp: ok but... why not me??
10:58 :D
10:58 kidclamp you are looking at unavailable items, not the same code :-)
10:59 I am not defending how we do thing there, it is confusing
10:59 Joubu they are not "grouped" if on loan
10:59 but there is code to display "X Lost"
10:59 and only for onloan items...
11:00 tcohen morning
11:09 ashimema as in Joubu, you can run kshell as `kshell -l` to get a login shell
11:10 what I'm saying is your patch forces it.. so either you should remove the option as part of that (as it's no longer an option.. it's enabled by default)
11:10 Joubu Should not the default behaviour of kshell be to give you a login shell?
11:10 ashimema pass
11:10 marcelr joined #koha
11:10 marcelr hi #koha
11:10 ashimema I've not delved deep enough yet ;)
11:10 still digging..
11:11 marcelr looking for gold ?
11:11 ashimema that was more a comment on the patch as is.. I would FQA it as it stands because it breaks the --login/-l option of the script
11:12 thus I would expect the option to be removed or reversed so you can request a non-login shell if you really want to.
11:12 tcohen.. any thoughts on why kshell gives a non-login shell by default?
11:13 tcohen can you define non-login shell?
11:13 Joubu indeed
11:13 what is supposed to to koha-shell without -l? To crash if not cmd passed?
11:14 no*
11:14 ashimema i.e without --login or -i ;)
11:14 * ashimema tries to remember robins irc nick
11:14 marcelr eythian
11:14 ashimema eythian ^
11:14 that's the one..
11:14 had a mental block
11:15 eythian hi
11:16 ashimema harking back to when you wrote koha-shell.. any hints as to why you didn't set --login/-i on the call to sudo by default?
11:16 and instead allowed it via an option
11:16 eythian cripes.
11:16 um.
11:16 ashimema haha..
11:16 yeah.. brain dredging.. sorry ;)
11:16 Joubu wants to default to -i (to help some tests pass)...
11:16 eythian My guess at the moment would be that if you use it in scripts to run commands, which is common, a login shell is less useful in some fashion.
11:17 ashimema which I'm OK with.. but I'm not close enough as to why you wouldn't want to in the first place
11:17 Joubu it should default to login if no cmd passed
11:17 eythian I seem to recall the the default was chosen to align with something else, but I can't remember what.
11:18 Joubu: that's reasonable, so long as you also then have an option to turn it off (for example if you're piping commands into koha-shell.)
11:18 oleonard Hi all
11:19 Joubu yep
11:19 eythian I think it was do align with 'su' perhaps.
11:19 ashimema aha.. piping.. that makes allot of sense :)
11:20 Joubu ashimema: I am attaching a follow-up
11:20 ashimema or.. where ever it is we're currently calling it prior to running all the tests at the moment we should just add the -l option there and not change koha-shell itself ?
11:20 thanks Joubu
11:21 hope I wasn't sounding too picky ;)
11:21 Joubu nope, good catch!
11:22 tcohen ah, we changed it into using sudo
11:26 Dyrcona joined #koha
11:30 Joubu tcohen: any ideas about what's missing on bug 22522?
11:30 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=22522 critical, P1 - high, ---, ere.maijala, Pushed to master , API authentication breaks with updated Mojolicious version
11:30 oleonard ashimema I'm glad to see you raise the issue of the "maincontent" class in the OPAC, it was something I noticed was inconsistent in my Bootstrap 4 work.
11:39 tcohen Joubu trying to read it
11:40 is that already pushed to 19.11.x?
11:40 I mean, should I check the 19.11.x branch?
11:40 Joubu yes
11:41 checkout, prove and enjoy the failures
11:41 you may need to cherry-pick the commit I am talking about in the last comment
11:41 ashimema pleasure oleonard.. I'm slowly working my way through them
11:44 koha-jenkins Project Koha_Master_U18 build #816: ABORTED in 44 min: https://jenkins.koha-community[…]a_Master_U18/816/
11:50 tcohen shouldn't we fix the problem with koha-shell on the call in KTD?
11:51 Joubu in the alias you mean?
11:51 before it was possible to `sudo koha-shell kohadev`, now it's broken
11:51 I think we should restore the behaviour
11:52 TimothyAlexis joined #koha
11:52 TimothyAlexis Hello :)
11:53 inlibro joined #koha
11:53 davidnind left #koha
11:54 TimothyAlexis I want to tell everyone that I apologize for the times where I have been affected by stress and if it has extended to anyone else. I also want to thank everyone here for the helpfulness and compassion. Thank you. :)
11:56 Thank you magnuse, oleonard, joubu, ashimema, tuxayo, lukeG1, dcook and cait for your humble guidance on every occasion.
11:56 oleonard 👍️
12:01 ashimema Wonderful to hear TimothyAlexis :)
12:02 khall joined #koha
12:07 andreashm joined #koha
12:12 TimothyAlexis Looking at this: https://bugs.koha-community.or[…]_bug.cgi?id=20573 I'm thinking, is the e-mail sent with misc/cronjobs/membership_expiry.pl ?
12:12 huginn Bug 20573: minor, P5 - low, ---, koha-bugs, NEW , Patron receives membership expiry notice but 'will expire soon' alert doesn't show for staff at checkout
12:13 TimothyAlexis There is also a setting MembershipExpiryDaysNotice
12:14 If the e-mail is sent at a scheduled time and the actual expiration is triggered at a specific time during that date, then there could be a difference.
12:14 Joubu TimothyAlexis: the cronjob script enqueues it in the message_queue table
12:16 TimothyAlexis We have added a button where patrons can renew their membership when logging in. But it happens that the e-mail is sent before it's actually triggered in the system.
12:19 khall joined #koha
12:23 kohaputti joined #koha
12:40 morrism joined #koha
12:43 andreashm joined #koha
12:46 Marie-Luce joined #koha
12:52 Brian_H joined #koha
12:53 inlibro joined #koha
13:02 koha-jenkins Yippee, build fixed!
13:02 wahanui Congratulations!
13:02 koha-jenkins Project Koha_Master_U18 build #817: FIXED in 1 hr 17 min: https://jenkins.koha-community[…]a_Master_U18/817/
13:03 khall joined #koha
13:12 khall joined #koha
13:18 TimothyAlexis If the cronjob runs every 15 minutes then the message will be sent at latest 00:15, while it's set at a different time (same as patron creation I'd suppose). Is this how it's happening?
13:20 kohaputti TimothyAlexis, the cron is which one?
13:21 there is first a cron which puts the message in the queue for sending and then process_message_queue.pl send those when its run
13:24 oleonard Anyone know why we're not already including Gettext.js in the OPAC? jajm?
13:26 jajm oleonard, because it's not used anywhere in opac ? (i don't know, i'm just making a guess)
13:27 oleonard Okay jajm I wanted to be sure I wasn't missing something
13:28 koha-jenkins Project Koha_19.11_D10 build #13: STILL FAILING in 4 min 49 sec: https://jenkins.koha-community[…]oha_19.11_D10/13/
13:32 khall joined #koha
13:34 oleonard jajm is it a goal to eliminate the use of the _() function altogether? (single underscore)
13:43 jajm oleonard-away, yes, i think it would be better if all js translations were using Gettext.js
13:53 inlibro joined #koha
13:58 JBoyer joined #koha
13:58 AndrewFH joined #koha
14:27 ashimema did we ever decide is results-grouped is actually used still?
14:36 kohaputti tcohen, ah, the zebra index is stored in Koha source code for unit tests at t/db_dependent/data/marc21/zebr​aexport/biblio/exported_records that's why it gave the error
14:36 maybe I could just mock the whole search function before it goes to any of the zebra stuff
14:38 that would test the code I want to test Koha::Biblio::components, although misses then testing whether the zebra index has the new search field required for it to work
14:39 khall_ joined #koha
14:43 oleonard ashimema: Let me know if you find the answer :D
14:47 ashimema lol
14:49 khall joined #koha
14:53 inlibro joined #koha
14:58 khall joined #koha
14:58 tcohen jajm any advise on Turn Koha into a Mojo app testing?
14:58 it is my next assigned thing, make it happen
15:05 jajm tcohen, my advise would be to start by checking that basic features work (cataloguing, search, checkout/checkin), read the code, understand how the whole thing work, and then test a few specific things like uploading a file, exporting a MARC file and verifying its encoding
15:05 ashimema we are sooooo inconsistent in our use of templates
15:06 tcohen s/in our.*//
15:06 jajm tcohen, and also verify that the patches do not break anything when you use standard apache+starman
15:06 ashimema lol
15:07 oleonard ashimema: ?
15:07 ashimema you want examples.. lol
15:08 memberentry.. why do we use two templates for it.. one for 'edit' or 'add' and an additional one for 'submitted'
15:08 I would have imagined we would either use one template for all three stages of the form.. or a distinct template for each
15:09 the clubs tab is another interesting case.. it's uses ajax to embed a whole template into a page.. rather than using it as an include like everywhere else..
15:10 I'm working through these 'maincontent' issues.. that's what I'm looking at lots of templates
15:10 other interesting inconsistency is how we nest divs.. in lots of cases what I think of as the main content is nested within a div with a suitable id matching the pages use..
15:11 Joubu "413 developers"
15:11 ashimema in other cases we don't both with the additional div and just stick the content directly inside the 'row-fluid'
15:11 indeed.
15:11 I'd love to work through and clean them all up...
15:12 or perhaps have a 'model template' we recommended as the starting point for all pages
15:13 jajm ashimema, a model template would be great, i always pick a random template as a starting point when creating a new page
15:13 ashimema me too
15:14 and I've never really thought about how inconsistent we are until now..
15:14 as part of a set of accessibility tasks I'm working through I'm basically having to look at every template in the OPAC.. it's tedious
15:15 I'm dreading the header level issues I've got to work through
15:15 oleonard ashimema I wish we could combine our efforts somehow but I don't think it would be standard procedures... I had to touch every OPAC template for Bug 20168
15:15 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=20168 enhancement, P5 - low, ---, oleonard, Needs Signoff , Update of the OPAC bootstrap template to bootstrap v4
15:18 oleonard ashimema: I can work to incorporate your changes into my branch of course
15:18 ashimema these are sooo going to conflict like mad
15:18 no worries
15:19 I think this is going to end up as a huge number fo tiny patches spread across lots of bugs.. I'm ready and prepared for the rebase hell.. honestly as I need to backport these to a 19.11 for the customer in question it'll be good to do the initial work pre your bug and then adapt it to your bug as part of rebasing
15:20 I'm very keen to jump on 20168 btw.. it'll be great to have that.
15:21 oleonard ashimema: Yes, I understand your position with regard to your customer, that's why I want to be very proactive in adapting my work to yours rather vice versa
15:24 lisettelatah joined #koha
15:25 ashimema is it just me or does the imageviewer template markup look a little funky?
15:26 they don't seem to add up to 12 for all rows to me
15:26 I thought that was a requirement in bootstrap
15:31 oleonard I see that the page heading is in a .span9 div with no corresponding .span3. That's intentional to keep the heading contained within the same space as the large image in cases where the title is especially long
15:32 That is, it shouldn't extend over the right-hand column with the thumbnails (just a design decision)
15:32 ashimema oh, ok. :)
15:33 funky by design the
15:33 n
15:33 * ashimema tries to work out where maincontent should sit
15:34 ashimema probably in alongside the span9 of that div then.. rather than introducing another dib
15:35 oleonard I would say so. I think the only gotcha with regard to adding IDs or classes to Bootstrap grid <div>s is that we don't want to be introducing additional style to that <div> which could break the grid layout
15:35 ashimema indeed
15:41 ooh.. what is idref?
15:44 wizzycray hi, anybody seen something like a double up on a result page, but one of the biblionumbers doesn't exist anywhere in the database? This happens even after a reindex?
15:44 i... i am stumped.
15:46 caroline zebra or elastic?
15:46 wizzycray zebra
15:46 caroline With zebra I've seen it a lot if I reindex without -r
15:47 wizzycray hrm
15:50 khall joined #koha
15:51 andreashm joined #koha
15:51 wizzycray that's an interesting observation because this one was done sliced
15:52 * oleonard waves to wizzycray
15:52 wizzycray and i may be wrong in the 2 minutes I looked at the sliced rebuild script
15:52 ashimema er...
15:52 wizzycray but it doesn't look like it passes a -r (though I could be wrong)
15:52 er?
15:52 wahanui er is as you said c
15:52 ashimema oleonard.. did you already try adding a 'skip to main content' functionality?
15:52 oleonard ashimema I have never tried
15:53 ashimema interesting...
15:53 inlibro joined #koha
15:54 ashimema just found lines 2-13 in bootstrap/js/script.js
15:54 they're rather similar to what I'm adding
15:54 wizzycray hi @oleonard
15:54 oh bugger i've gone slack >.<
15:54 * ashimema wonders two things.. whether he should move his code to script.js instead of global.js and whether he should be closer matching
15:54 wizzycray hi oleonard
15:54 wahanui hi oleopard
15:55 eythian hi oleopard
15:55 oleonard Haha... yeah... That was intended to make the experience on mobile better by doing the same kind of thing, jumping past all the nav stuff...
15:55 Obviously that ended up being a little half-baked
15:58 wizzycray caroline++
15:58 * ashimema hasn't actually tried it on mobile for ages..
15:58 wizzycray that was a good thought and something I can check on
15:58 caroline oh? did it work?
15:58 ashimema ?
16:00 bug 22807 is now ready to test.. wouldn't mind a bit of your expertise in making the actual 'skip to main content' button look a bit nicer oleonard.. for some reason the styling of the alluded me
16:00 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=22807 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Accessibility: Add 'Skip to Main Content' link
16:01 oleonard Cool
16:02 morrism joined #koha
16:12 khall joined #koha
16:29 oleonard kidclamp++
16:48 did joined #koha
16:49 did joined #koha
16:49 did joined #koha
16:50 did joined #koha
16:50 did joined #koha
16:51 did joined #koha
16:51 cait left #koha
16:51 did joined #koha
16:52 did joined #koha
16:52 khall joined #koha
16:52 did joined #koha
16:53 did joined #koha
16:53 did joined #koha
16:53 inlibro joined #koha
16:54 did joined #koha
16:54 did joined #koha
16:55 did joined #koha
16:55 did joined #koha
16:55 ashimema Is a cait here?
16:56 did joined #koha
16:56 did joined #koha
16:57 did joined #koha
16:57 did joined #koha
16:58 did joined #koha
16:58 did joined #koha
16:59 did joined #koha
16:59 did joined #koha
17:00 did joined #koha
17:00 did joined #koha
17:01 did joined #koha
17:01 did joined #koha
17:02 did joined #koha
17:02 did joined #koha
17:03 did joined #koha
17:03 did joined #koha
17:04 did joined #koha
17:04 did joined #koha
17:05 did joined #koha
17:05 did joined #koha
17:06 did joined #koha
17:06 did joined #koha
17:07 did joined #koha
17:07 did joined #koha
17:08 did joined #koha
17:08 did joined #koha
17:09 did joined #koha
17:09 did joined #koha
17:10 did joined #koha
17:10 did joined #koha
17:11 did joined #koha
17:11 did joined #koha
17:12 did joined #koha
17:12 did joined #koha
17:13 did joined #koha
17:13 did joined #koha
17:14 did joined #koha
17:14 did joined #koha
17:15 did joined #koha
17:15 did joined #koha
17:16 did joined #koha
17:16 did joined #koha
17:17 khall_ joined #koha
17:17 did joined #koha
17:17 did joined #koha
17:18 did joined #koha
17:18 did joined #koha
17:19 did joined #koha
17:19 did joined #koha
17:20 did joined #koha
17:20 did joined #koha
17:21 did joined #koha
17:21 did joined #koha
17:22 did joined #koha
17:22 did joined #koha
17:23 did joined #koha
17:23 did joined #koha
17:24 did joined #koha
17:24 did joined #koha
17:24 oleonard Someone please check on did
17:25 did joined #koha
17:25 did joined #koha
17:26 did joined #koha
17:26 did joined #koha
17:27 reiveune bye
17:27 reiveune left #koha
17:27 did joined #koha
17:27 did joined #koha
17:28 did joined #koha
17:28 did joined #koha
17:29 did joined #koha
17:29 did joined #koha
17:30 did joined #koha
17:30 cait1 joined #koha
17:30 did joined #koha
17:31 did joined #koha
17:31 did joined #koha
17:32 did joined #koha
17:32 did joined #koha
17:33 did joined #koha
17:33 did joined #koha
17:34 did joined #koha
17:34 did joined #koha
17:35 kohaputti anyone else come across such issue with the test only working on the first time after running reset_all: https://bugs.koha-community.or[…].cgi?id=11175#c64 ?
17:35 huginn Bug 11175: enhancement, P5 - low, ---, joonas.kylmala, In Discussion , Show the parent record's component parts in the detailed views
17:35 did joined #koha
17:35 did joined #koha
17:36 kohaputti wondering if it could be related to those issues Joubu described where the tests stop working after ~30 runs
17:36 did joined #koha
17:36 did joined #koha
17:37 did joined #koha
17:37 did joined #koha
17:38 did joined #koha
17:39 did joined #koha
17:39 did joined #koha
17:40 did joined #koha
17:40 did joined #koha
17:41 did joined #koha
17:41 did joined #koha
17:42 did joined #koha
17:42 did joined #koha
17:43 did joined #koha
17:43 did joined #koha
17:44 did joined #koha
17:44 did joined #koha
17:45 did joined #koha
17:45 did joined #koha
17:46 did joined #koha
17:46 did joined #koha
17:47 did joined #koha
17:47 did joined #koha
17:47 khall joined #koha
17:48 did joined #koha
17:48 caroline who is did?
17:48 did joined #koha
17:49 did joined #koha
17:49 did joined #koha
17:50 did joined #koha
17:50 oleonard Didier Gautheron at biblibre
17:50 did joined #koha
17:51 did joined #koha
17:51 did joined #koha
17:52 did joined #koha
17:52 did joined #koha
17:53 did joined #koha
17:53 did joined #koha
17:54 did joined #koha
17:54 inlibro joined #koha
17:54 did joined #koha
17:55 did joined #koha
17:55 did joined #koha
17:56 did joined #koha
17:56 did joined #koha
17:57 did joined #koha
17:57 did joined #koha
17:58 did joined #koha
17:58 did joined #koha
17:58 caroline juste sent them an email... we'll see... *shrugs*
17:59 did joined #koha
17:59 did joined #koha
18:00 did joined #koha
18:00 did joined #koha
18:01 did joined #koha
18:01 did joined #koha
18:02 did joined #koha
18:02 did joined #koha
18:03 did joined #koha
18:03 did joined #koha
18:04 did joined #koha
18:04 did joined #koha
18:05 did joined #koha
18:05 did joined #koha
18:06 did joined #koha
18:06 did joined #koha
18:07 did joined #koha
18:07 did joined #koha
18:08 did joined #koha
18:08 did joined #koha
18:09 did joined #koha
18:09 did joined #koha
18:10 did joined #koha
18:10 did joined #koha
18:11 did joined #koha
18:11 did joined #koha
18:12 did joined #koha
18:12 oleonard ashimema still around?
18:12 did joined #koha
18:13 did joined #koha
18:13 did joined #koha
18:14 did joined #koha
18:14 did joined #koha
18:15 did joined #koha
18:15 did joined #koha
18:16 did joined #koha
18:16 did joined #koha
18:17 did joined #koha
18:17 did joined #koha
18:18 did joined #koha
18:18 did joined #koha
18:19 did joined #koha
18:19 did joined #koha
18:20 did joined #koha
18:20 did joined #koha
18:21 did joined #koha
18:21 did joined #koha
18:22 did joined #koha
18:22 did joined #koha
18:23 did joined #koha
18:23 did joined #koha
18:24 did joined #koha
18:24 did joined #koha
18:25 did joined #koha
18:40 did left #koha
18:50 ashimema Hi
18:51 oleonard
18:51 wahanui oleonard is seeing some buggy stuff though
18:51 oleonard Yes wahanui that is perpetually true isn't it?
18:51 ashimema Lol
18:52 oleonard ashimema: I like the "skip" link on this page: https://webaim.org
18:52 What would you think about stealing that?
18:53 ashimema They're nice
18:53 I pretty much aimed to steal that.. just using some of bootstraps existing classes.. hence the sr- tags
18:54 More than happy if we can get it closer to that
18:54 inlibro joined #koha
18:55 oleonard Cool.
19:19 khall joined #koha
19:21 AndrewFH joined #koha
19:21 khall joined #koha
19:23 khall_ joined #koha
19:34 khall joined #koha
19:40 kathryn joined #koha
19:51 indradg joined #koha
19:54 inlibro joined #koha
19:56 andreashm joined #koha
19:59 andreashm joined #koha
19:59 * oleonard wonders why we have empty <label> tags on the OPAC search results page
20:00 cait1 that doesn't sound right
20:00 ?
20:17 hayley joined #koha
20:20 khall joined #koha
20:44 alexbuckley joined #koha
20:54 inlibro joined #koha
21:19 tosca joined #koha
21:41 aleisha_ joined #koha
21:47 aleisha joined #koha
21:52 tosca joined #koha
21:54 inlibro joined #koha
21:56 khall joined #koha
22:12 aleisha_ joined #koha
22:20 caroline cait1: still around?
22:26 cait1 kind of :)
22:55 inlibro joined #koha
22:56 AndrewFH joined #koha
23:05 * dcook waves
23:18 oleonard Hi dcook
23:18 dcook Hola, oleonard!
23:19 I just sent out an email that might be of interest to you
23:20 Are you familiar with the WRAPPER directive in Template::Toolkit?
23:21 oleonard No I hadn't noticed it before
23:24 Off the top of my head I think we aren't as consistent as we'd need to be to use WRAPPER, and I don't know if that's out of necessity or not
23:25 I do know that my Bootstrap 4 work included a fair number of grid markup differences for different pages' particular needs
23:39 hayleymapley_ joined #koha
23:55 inlibro joined #koha

← Previous day | Today | Next day → | Search | Index

koha1