![https://i.chzbgr.com/completes[…]Cf1xOCZPJ9FQ2.jpg](https://i.chzbgr.com/completestore/12/9/5/8dUvGazUDECf1xOCZPJ9FQ2.jpg){kind=link}
← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:52 | jcamins_away | wajasu: example on the bug |
| 01:43 | wajasu | thx |
| 02:29 | jacamins_away: when adding an authority GEOGRAHPIC NAME record, my 551 $a field is locked. Is there any syspref other than BiblioAddsAuthories = allow that I can set? | |
| 02:31 | jcamins_away: when adding an authority GEOGRAHPIC NAME record, my 551 $a field is locked. Is there any syspref other than BiblioAddsAuthories = allow that I can set? | |
| 03:15 | mib_w61es6 joined #koha | |
| 03:16 | idreambooks joined #koha | |
| 03:17 | idreambooks | hello. anybody online? |
| 04:27 | trea joined #koha | |
| 04:34 | wajasu | ya |
| 04:36 | trea left #koha | |
| 04:48 | mtompset joined #koha | |
| 04:48 | mtompset | Greetings, #koha. |
| 06:10 | cait joined #koha | |
| 06:12 | mtompset | Greetings, cait. |
| 06:12 | cait | morning mtompset |
| 06:17 | adnc_ joined #koha | |
| 06:27 | druthb joined #koha | |
| 06:52 | adnc_ left #koha | |
| 08:13 | mtompset | Hmmm... someone needs to update the subject line. |
| 08:13 | I mean topic. | |
| 08:14 | cait | yeah, but I can't |
| 08:14 | rangi or wizzyrea maybe | |
| 08:14 | ibeardslee joined #koha | |
| 08:22 | * mtompset | is trying figure out best solution to bug 8742 he just posted. |
| 08:22 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8742 trivial, P5 - low, ---, gmcharlt, NEW , Example uses perl 5.8 in Makefile.PL |
| 08:24 | mtompset | I figure a grep of @INC is a good start. |
| 08:24 | But I need a fallback if the grep fails. | |
| 08:25 | finding a good explanation of @array in a logical test isn't available? | |
| 08:26 | Ah well, I'll use it and let someone tell me it is the wrong way to do it. | |
| 08:41 | There... something submitted. | |
| 08:41 | bug 8742 | |
| 08:41 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8742 trivial, P5 - low, ---, mtompset, Needs Signoff , Example uses perl 5.8 in Makefile.PL |
| 08:41 | mtompset | Funny thing is, with packages, this output fix will reduce in visibility. |
| 09:41 | mbalmer joined #koha | |
| 10:17 | Oak joined #koha | |
| 10:31 | mib_5eyxci joined #koha | |
| 10:31 | mib_5eyxci | Hello Sir |
| 10:31 | hello are u there? | |
| 11:31 | jcamins_away | wajasu: are you sure you can't type 551$a? The lock icon just indicates that it is authority controlled. |
| 11:37 | jcamins | mtj++ |
| 11:42 | Oak | guys, any idea about this error when database upgrade from 3.6.4 to 3.6.8: |
| 11:42 | updatedatabase.pl: DBD::mysql::db do failed: Duplicate key name 'items_location' at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 4710. | |
| 11:42 | pdatedatabase.pl: DBD::mysql::db do failed: Duplicate key name 'items_ccode' at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 4711. | |
| 11:42 | cait | HM |
| 11:42 | can you find the updatedatabase part that is cuasing this and paste it? | |
| 11:43 | I am surrounded by green beans right now | |
| 11:44 | Oak | :) okay |
| 11:46 | paste? | |
| 11:46 | wahanui | well, paste is found at http://paste.koha-community.org |
| 11:46 | pastebot | "Oak" at 127.0.0.1 pasted "$DBversion = "3.06.07.001"; if" (7 lines) at http://paste.koha-community.org/159 |
| 11:49 | jcamins | Oak: you can ignore that. |
| 11:49 | cait | green beans cleaned - but jcamins was faster :) |
| 11:49 | jcamins++ | |
| 11:50 | Oak | okay cool :) |
| 11:50 | http://tinypic.com/r/sfjioj/6 | |
| 11:50 | jcamins | Nothing to worry about. :) |
| 11:50 | Oak | cool then. thank you! |
| 11:51 | jcamins++ | |
| 11:51 | cait++ | |
| 11:54 | jcamins | Oooooh... I *like* bug 8304. |
| 11:54 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8304 enhancement, P5 - low, ---, matthias.meusburger, Needs Signoff , composed authorities Rameau management |
| 11:55 | jcamins | Just think of the possibilities. |
| 11:56 | Also, merge is broken as of 3.8.0. | |
| 11:57 | I don't know why. | |
| 11:57 | Oak | jcamins, one more thing, echo $PERL5LIB says /usr/share/koha/lib/, and here is /etc/koha/sites/aridkoha/koha-conf.xml. I do PERL5LIB=/usr/share/koha/lib/ and KOHA_CONF=/etc/koha/sites/aridkoha/koha-conf.xml. and when i run /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -a -b -z -v as root I get: |
| 11:57 | Can't locate C4/Context.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 6. | |
| 11:57 | BEGIN failed--compilation aborted at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 6. | |
| 11:57 | i isntalled oldstable, 3.6.8 using Debian package... | |
| 11:57 | jcamins | That's easy to solve, but before I tell you the solution, aren't you using packages? |
| 11:57 | cait | ew |
| 11:58 | about the broken merge | |
| 11:58 | Oak | i did jcamins |
| 11:58 | jcamins | Use `sudo koha-rebuild-zebra aridkoha` |
| 11:58 | cait | but die you run Makefile or did you use the koha-common commands to create your instance? |
| 11:58 | jcamins | Don't run rebuild_zebra directly. |
| 11:59 | And for future reference, you need to put 'export' before the variable name. | |
| 11:59 | Oak | okay, i ran that earlier, problem with it is that it says nothing (which is okay I guess), but i also don't get any search results in OPAc and in staff client |
| 11:59 | jcamins | So, `export PERL5LIB...` and `export KOHA_CONF...` |
| 12:00 | Oak: in that case, run koha-rebuild-zebra -f -v aridkoha | |
| 12:00 | Oak | oh cool now it is doing stuff!!! |
| 12:00 | jcamins++ | |
| 12:02 | great. now search works! | |
| 12:02 | * Oak | goes to check fo rmanual of rebuild_zebra to find what -f does |
| 12:02 | jcamins | It's the equivalent of -r |
| 12:02 | It's a full rebuild. | |
| 12:03 | cait: the failed merge can result in data loss. | |
| 12:03 | However, only in very specific situations. | |
| 12:03 | cait | double ew |
| 12:03 | jcamins | major or critical? |
| 12:03 | cait | major |
| 12:03 | that's the higher one? | |
| 12:03 | jcamins | critical is higher. |
| 12:03 | cait | then critical |
| 12:03 | data loss even makes blocker valid | |
| 12:03 | Oak | okay got it. |
| 12:04 | now i have my notebook in my lap, and i'll note these things down NOW, so I won't ask these embarrassing questions again. | |
| 12:04 | jcamins | You know, with bug 8304, merge becomes an attractive feature for me. |
| 12:04 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8304 enhancement, P5 - low, ---, matthias.meusburger, Needs Signoff , composed authorities Rameau management |
| 12:07 | cait | sorry, I can't follow |
| 12:07 | can you sum up what the bug does? | |
| 12:07 | jcamins | Well, two things. |
| 12:08 | One: it doesn't change headings that don't match anymore. | |
| 12:08 | I guess in a follow-up I should make that switchable. | |
| 12:09 | Two: it allows us to use multiple authorities in one subject (i.e. free-floating subdivisions). | |
| 12:11 | cait | ? |
| 12:11 | ok, I still can't follow :) | |
| 12:12 | Oak++ | |
| 12:12 | jcamins: why does that make merge not needed? | |
| 12:12 | jcamins | What? |
| 12:12 | Merge is still needed. | |
| 12:13 | cait | ah |
| 12:13 | thought you said you liked it even better or something | |
| 12:13 | but now I can't find it in the logs | |
| 12:14 | jcamins | Yes, I like merge even better post-8304. |
| 12:14 | cait | hm |
| 12:14 | hope you have testing plans on those bugs :) | |
| 12:14 | our subject structure with rswk is a lot simpler than loc | |
| 12:14 | jcamins | 8304 isn't my bug. |
| 12:15 | cait | meant the other bugs i am supposed to test :) and the bug fix |
| 12:15 | jcamins | paul_p asked me to confirm that it doesn't change MARC21 at all. |
| 12:24 | Hm. Unfortunately, it does. | |
| 12:28 | cait | :( |
| 12:28 | why is it failed qa? | |
| 12:28 | jcamins | I'm writing that up now. |
| 12:32 | * jcamins | finished writing it up. |
| 12:32 | jcamins | I wanted to make sure I posted the rebased patch, since I had spent a while reconciling changes. |
| 12:35 | Oak | jcamins+ |
| 12:35 | oho | |
| 12:35 | jcamins++ | |
| 12:35 | cait++ | |
| 12:43 | wajasu | jcamins: yes 551a has a lock icon in it. and i can't type in it |
| 12:43 | cait | jcamins++ indeed :) |
| 12:44 | jcamins | wajasu: that's odd, because the authority editor does not have any locking functionality. |
| 12:44 | To confirm, you *are* in the authority editor, right? | |
| 12:45 | wajasu | my breadcrumbs: Home › Authorities › Adding authority Geographic Name |
| 12:45 | jcamins | Okay, that sounds right. |
| 12:45 | wajasu | caching of javascript or something? |
| 12:46 | jcamins | Maybe. I'm trying to replicate. |
| 12:47 | * jcamins | manages. |
| 12:47 | jcamins | Now that is *weird*. |
| 12:48 | Oh, I just signed off on a bug that did some work here. | |
| 12:48 | Reconciling things. | |
| 12:48 | Patch coming momentarily. | |
| 12:49 | wajasu | i'm going to have to leave. but will check later today. |
| 12:52 | jcamins | I was too busy looking at the 0xx and 1xx tabs, apparently. |
| 12:59 | @later tell wajasu The patch on bug 8744 fixes the problem. | |
| 12:59 | huginn | jcamins: The operation succeeded. |
| 13:20 | Oak joined #koha | |
| 13:25 | Oak joined #koha | |
| 13:48 | tcohen joined #koha | |
| 13:48 | matts joined #koha | |
| 14:14 | mtompset joined #koha | |
| 14:14 | mtompset | Greetings, #koha. |
| 14:23 | tcohen | hi mtompset |
| 14:24 | jcamins, i cannot reproduce bug 8743 in our 3.8.x setup, do I need to use DOM for authorities to test it? | |
| 14:24 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8743 critical, P3, ---, jcamins, Needs Signoff , ZOOM error when merging authority change to biblios |
| 14:24 | jcamins | tcohen: I don't think so. |
| 14:25 | I ran into the problem with both GRS-1 and DOM. | |
| 14:27 | And once I ran into it, I had the problem as far back as 3.7.something. | |
| 14:27 | But not in 3.6.x. | |
| 14:28 | tcohen | so, having dontmerge set to Do, editing the 100$a of an authority linked to a biblio, it should raise an error |
| 14:28 | jcamins | Right. |
| 14:39 | tcohen | i cannot reproduce jcamins sorry, leaving to have lunch! |
| 14:40 | jcamins | tcohen: no problem. I imagine Doug will be willing to test. |
| 14:40 | tcohen | ok! |
| 14:42 | cait | hm not daniel? |
| 14:44 | * jcamins | doesn't know who Daniel is, but if he's having the problem too, he'd probably be willing to sign off, too. |
| 15:04 | Oak | can i help with this bug cait ? |
| 15:04 | to sign off... | |
| 15:04 | i mean you'd know if i should or should not | |
| 15:08 | cait | Oak: better ask jcamins - authorities are a bit complicated but he often does great test plans :) |
| 15:09 | Oak | okie |
| 15:10 | jcamins | Oak: you're on 3.6.8, which doesn't have this bug. |
| 15:11 | Oak | ah. okay. i was just checking http://catalogue.test6.biblibr[…]koha/opac-main.pl |
| 15:12 | jcamins | Oh, if you're using a sandbox, you may be able to replicate the bug by linking a bib heading to an authority, setting dontmerge to "Do," and trying to edit the authority. |
| 15:15 | Oak | don't know about how to link bib heading to authorities... that's why asked katrin :) this one's 440 a is already linked ot an authority i guess: http://catalogue.test6.biblibr[…]pl?biblionumber=2 |
| 15:15 | never used authorities myself | |
| 15:16 | jcamins | Oak: that's not linked. $v is the volume number. |
| 15:24 | Oak | what does that 'Link' field does in there: http://tinypic.com/r/e6ez4w/6 |
| 15:25 | jcamins | Link is not used at all anymore. |
| 15:25 | Oak | okay. |
| 15:25 | jcamins | When I said "link," I meant in the cataloging module. |
| 15:27 | Oak: http://manual.koha-community.o[…]ging.html#catbibs <-- scroll down to where it says "Sometimes fields may not be editable due to the value in your BiblioAddsAuthorities system preference" | |
| 15:27 | Oak | okay on it |
| 15:27 | jcamins | That shows how to link authorities. |
| 15:27 | (but don't take what it says too seriously, the authority plugin works without BiblioAddsAuthorities too) | |
| 15:31 | cait | I can't load the unimarc sample database :( |
| 16:08 | jcamins | bug 8523 |
| 16:08 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8523 enhancement, P5 - low, ---, jcamins, Needs Signoff , Authority hierarchies only support UNIMARC |
| 16:14 | Oak | this one also is above me :) |
| 16:14 | someday... | |
| 16:14 | jcamins | :) |
| 16:19 | Oak | by "you may be able to replicate the bug by linking a bib heading to an authority" you meant << by linking a bib field to an authority >> ? |
| 16:19 | jcamins | Right. |
| 16:20 | Oak | and by "and trying to edit the authority." you meant << edit the authority record at the backend >> or << edit the authority... change, say, personal name to some other name >> ? |
| 16:22 | wait | |
| 16:22 | jcamins | Change the authority from "Smith, John" to "Smith, James. |
| 16:22 | wahanui | jcamins: that doesn't look right |
| 16:22 | wahanui joined #koha | |
| 16:22 | jcamins | (for example) |
| 16:22 | Oak | okay got it. |
| 16:23 | but when i search for something like, "nicole" or some other name in the popped up window it says no result found... | |
| 16:23 | let me check | |
| 16:26 | jcamins | There probably aren't any authorities. |
| 16:26 | Oak | hmm |
| 16:27 | then when i click 'Create New' button an pop-up windows opens with things that don't make much sense to me. and so there i gave up. | |
| 16:27 | jcamins | You'd have to create an authority record. |
| 16:27 | Oak | :) |
| 16:28 | two records actually? | |
| 16:28 | set one, then edit and choose another...? | |
| 16:28 | to reproduce the bug | |
| 16:28 | jcamins | No. |
| 16:28 | Just one. | |
| 16:28 | You create an authority. | |
| 16:29 | Link a field in a bib to that authority. | |
| 16:29 | Then you edit the authority. | |
| 16:29 | Oak | ah okay |
| 16:29 | let me try that | |
| 16:30 | cait | Oak++ :) |
| 16:30 | Oak | okay authority added with name Smith, John |
| 16:30 | cait | jcamins++ |
| 16:31 | Oak: remember it needs to be indexed before you can use it :) | |
| 16:31 | Oak | hmm. yes i read something about ask your administrator to run some command... let me see |
| 16:35 | okay without the indexed thing cait said, I just went and edited the authority, from 'Smith, John' to 'Smith, Johnny'. No error! | |
| 16:36 | i had already set dontmerge to "Do" before creating the authority and editing it though | |
| 16:38 | jcamins | Oak: tcohen wasn't able to recreate the problem either. |
| 16:38 | You followed the test plan properly. :) | |
| 16:38 | Oak | hmm |
| 16:38 | okay good :) | |
| 16:40 | and the bib record is also showing 'Smith, Johnny' now that i searched for it and viewed it again. | |
| 16:41 | jcamins | We'll wait for Doug to check his e-mail and test it. |
| 16:41 | Oak | cool. |
| 17:44 | mbalmer joined #koha | |
| 17:47 | mbalmer | evening |
| 17:47 | so, is software written in e.g. C accepted in the Koha source tree? | |
| 17:48 | jcamins | mbalmer: only if it is core to Koha. |
| 17:48 | cait | there is a contribs repo too |
| 17:48 | for other things | |
| 17:49 | mbalmer | what does that mean (core to Koha)? |
| 17:50 | Brooke joined #koha | |
| 17:50 | Brooke | o/ |
| 17:50 | jcamins | mbalmer: it is something that represents basic functionality in the area of circulation, cataloging, acquisitions, serials, or OPAC. |
| 17:51 | Also, of course, there would have to be an *incredibly* compelling reason why we needed to add code in a different language. | |
| 17:51 | (that list of modules not guaranteed to be complete) | |
| 17:52 | mbalmer | examples coulx be a SIP2 server in C, a Lua binding do Koha etc. Would any of these qualify? Or system tools e.g. to make a locally attached printer accessible over the network on port 9100. |
| 17:52 | s/coulx/could/ | |
| 17:53 | jcamins | If there were a reason why the SIP2 server in Perl couldn't be fixed to do whatever was needed, perhaps. |
| 17:54 | I'm not sure about the Lua binding, because I don't know what that entails. | |
| 17:54 | System tools would belong in contribs. | |
| 17:54 | Also, why don't you use CUPS or LPD? | |
| 17:54 | mbalmer | for obvious reasons. |
| 17:55 | perl does not support IPv6, iirc. | |
| 17:56 | jcamins | I'd say probably the best thing to do with the SIP2 server would be to keep it separate either way, so that Evergreen (for example) could use it. |
| 17:59 | mveron joined #koha | |
| 17:59 | Brooke | howdy mveron :) |
| 18:00 | mveron | Hi Brooke :-) |
| 18:02 | mbalmer | sali marc |
| 18:02 | mveron | sali marc :-) |
| 18:52 | mbalmer joined #koha | |
| 19:23 | cait | bug 7455 |
| 19:23 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7455 normal, P4, ---, fridolyn.somers, Signed Off , Authority subfields are cloned in the wrong field |
| 19:34 | rambutan joined #koha | |
| 19:38 | mbalmer | jcamins, we (my company) made a decision. we will not opensource our Koha related software that is written C. |
| 19:38 | jcamins | mbalmer: well, that answers the question about whether it belongs in Koha. |
| 19:39 | mbalmer | I did not expect a smarter reply... |
| 19:47 | rangi | perl does not support ipv6? |
| 19:48 | jcamins | It does, but who cares? |
| 19:48 | rangi | i was just boggling, you can't really take any of the rest of the argument seriously after a statement like that |
| 19:49 | ah well, that solves that conundrum then | |
| 19:49 | jcamins | That clearly wasn't the deciding factor, since Google "perl ipv6" explains how to use IPv6 in Perl, so I focused on writing epic (and I mean EPIC) unit tests. |
| 19:49 | rangi | yep |
| 19:50 | sounds to me like a reason looking for an excuse | |
| 19:50 | jcamins | Alas, the unit tests are for Evergreen and not Koha, at the moment. |
| 19:51 | 80.3% statement coverage on the EG QueryParser! :D | |
| 19:51 | And... five bugs fixed. | |
| 19:51 | rangi | cool |
| 20:08 | wajasu | i'm tsting 8211 now |
| 20:09 | jcamins | Yay! |
| 20:09 | wajasu++ | |
| 20:11 | kathryn joined #koha | |
| 20:11 | cait | good morning kathryn :) |
| 20:12 | kathryn | hi cait! it's beautiful morning |
| 20:12 | rambutan | ? |
| 20:12 | cccccccccccccccccc | |
| 20:12 | ? | |
| 20:12 | cait | it was a nice day here too |
| 20:12 | rangi | why is rambutan dancing on his keyboard? |
| 20:12 | rambutan | yea, got some gobbleygook in there |
| 20:12 | jcamins | rambutan: cat? |
| 20:12 | rambutan | no, I'm actually at work for a sec |
| 20:21 | rambutan left #koha | |
| 20:31 | wajasu | jcamins: pre 8211 patch. BiblioAddsAuthorities =don't allow. I have the authority heirarchy saved as in 8211 comment. I am adding biblio/items by doing z3950 search (Subject Heading:United States) and i saved no problem. i am testing that your search doesn't work first. so i want to be sure i am configured correctly. |
| 20:32 | must i use the advanced search screen? or can i use the generaal staff search for things like: su-br:Arizona | |
| 20:32 | jcamins | wajasu: you can just use the simple search and enter su-br:Arizona |
| 20:32 | wajasu | ok |
| 20:33 | jcamins | It won't work. |
| 20:33 | wajasu | what won't work. |
| 20:34 | jcamins | The search. |
| 20:34 | wahanui | the search is for the patrons not the librarians |
| 20:34 | wajasu | ok. good to know. then use the opac |
| 20:34 | jcamins | Without the patch, I honestly have no idea what it's going to do. |
| 20:34 | wajasu | ok. i'll let you know then. |
| 20:34 | jcamins | Probably look for the literal string "su-br:Arizona" :) |
| 20:35 | wajasu | once i add the half dozen records, do all i have to do is "rebuild-zebra" and things should be linked? or use a linker? |
| 20:36 | jcamins | You'll need to either use the linker, or use the authority plugin in cataloguing. |
| 20:36 | I'd recommend using the authority plugin 'cause it'll be faster. | |
| 20:36 | wajasu | gotcha |
| 20:37 | you know. by the way when i use that auth plugin, when i click cancel, nothing happens. (windows stays open) | |
| 20:38 | jcamins | Hm. I should fix that. |
| 20:38 | wajasu | if you patch that, i'll test it later as well. |
| 20:39 | jcamins | First I have to fix the patch for bug 8523. |
| 20:39 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8523 enhancement, P5 - low, ---, jcamins, Needs Signoff , Authority hierarchies only support UNIMARC |
| 20:39 | wajasu | no hurry. i'll work on 8726 after 8211 |
| 20:40 | jcamins | Well, this is... hmph. |
| 20:40 | cait: I have good news, and I have bad news. | |
| 20:40 | The good news: Konstanz is showing up. | |
| 20:40 | The bad news: it's showing up twice. | |
| 20:43 | cait | lol |
| 20:49 | jcamins | This is really weird. |
| 20:50 | cait | i am sorry |
| 20:51 | but I catalogued it correctly? | |
| 20:51 | jcamins | I'm experimenting now. |
| 20:51 | It looks right to me, but... | |
| 20:52 | cait | it doesn't work. |
| 20:53 | rangi | https://i.chzbgr.com/completes[…]Cf1xOCZPJ9FQ2.jpg |
| 20:53 | that will fix it | |
| 20:53 | jcamins | lol |
| 20:55 | Okay. It's an issue with the link to Baden-Wurtemberg. | |
| 20:56 | No link = happy system. | |
| 20:56 | Link = unhappy system. | |
| 20:56 | But why? | |
| 20:56 | I see no difference between this and what I have. | |
| 20:57 | cait | the minus? |
| 20:58 | thelink from konstanz to baden-württemberg? or up-to-down? | |
| 20:58 | jcamins | The link from Konstanz up to Baden-Wurttemberg. |
| 20:59 | The link in the other direction makes no difference at all. | |
| 20:59 | (I mean, other than in the display) | |
| 21:01 | cait | funny |
| 21:01 | well.. not really | |
| 21:01 | but... | |
| 21:15 | wajasu | jcamins: started to apply 8211. git am -i -u -3 ~/Downloads/Bug-8211-Add-exploded-search-options.patch and got ==> fatal: sha1 information is lacking or useless (C4/Search.pm) |
| 21:15 | jcamins | wajasu: I will rebase and reattache. |
| 21:15 | wajasu | thx |
| 21:16 | jcamins | wajasu: and to confirm, you applied all the dependencies first? |
| 21:18 | wajasu | oh. 7818. let me do that |
| 21:19 | wait. that shows in my git log. | |
| 21:20 | jcamins | Also bug 8209. |
| 21:20 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8209 enhancement, P5 - low, ---, jcamins, Passed QA , "Did you mean?" suggestions based on authorities |
| 21:22 | wajasu | so that should have been in the dependsOn? |
| 21:22 | jcamins | Oh. |
| 21:22 | No. | |
| 21:22 | Sorry. | |
| 21:22 | Bug 8726 requires it. | |
| 21:22 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8726 enhancement, P5 - low, ---, jcamins, Needs Signoff , Did you mean? plugin for broader/narrower/related terms |
| 21:23 | * jcamins | is distracted by bug 8523 still. ;) |
| 21:23 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8523 enhancement, P5 - low, ---, jcamins, Needs Signoff , Authority hierarchies only support UNIMARC |
| 21:23 | jcamins | Okay, updated it. |
| 21:23 | wajasu | ok. |
| 21:34 | |Lupin| joined #koha | |
| 21:34 | |Lupin| | hello there ! |
| 21:35 | rangi | |Lupin|: !!!! hello! |
| 21:35 | cait | hello! |
| 21:35 | nice to see you! | |
| 21:35 | * jcamins | bangs his head on the desk. |
| 21:35 | |Lupin| | hey cait ! nice to see you too ! |
| 21:35 | cait | and ignore jcamins - I broke his feature |
| 21:36 | jcamins | I got Konstanz to show up, and Furstenberg is missing. |
| 21:36 | cait | jcamins: you are getting closer... it will be all ok |
| 21:36 | * cait | hands jcamins a cookie and puts a pillow on the desk |
| 21:36 | |Lupin| | hello rangi ! changed nick ? :) |
| 21:36 | cait | you can't break your head over this, you are our only candidate for rm |
| 21:37 | |Lupin| | just a quick question: does anyone here know something about perl's sourcefilters, please ? |
| 21:37 | I'm wondering how to see a script after the filters have been applied... | |
| 21:38 | wajasu | jcamins: i pulled a fresh master and tried the new 8211 -> sha1 information is lacking or useless (t/db_dependent/Search.t) |
| 21:38 | jcamins | Oh. |
| 21:38 | Right. | |
| 21:38 | I forgot to mark the dependency on the Search.t bug. | |
| 21:39 | bug 8649 | |
| 21:39 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Signed Off , C4::Search needs a unit test |
| 21:39 | jcamins | I'll mark the dependency now. |
| 21:39 | Marked. | |
| 21:39 | cait | |Lupin|: sorry, i don't |
| 21:40 | jcamins | Sorry about that. |
| 21:40 | |Lupin| | cait: np :) |
| 21:40 | jcamins | I feel like it was so long ago that it *must* have been pushed. |
| 21:41 | wajasu | not in my git log |
| 21:41 | jcamins | No, it wasn't. |
| 21:41 | Definitely wasn't. | |
| 21:41 | I just feel like it was. ;) | |
| 21:41 | wajasu | i wonder if you should specify 8744 as well, so when QA goes to add heirarchical geonames that can. |
| 21:41 | jcamins | Good call. |
| 21:42 | Done. :) | |
| 21:42 | wajasu | i see em. trying again. |
| 21:43 | jcamins | I bet you're going to get the same error on account of the patches not having been signed off when I branched. |
| 21:44 | wajasu | hmm. we'll see. |
| 21:45 | 8649 has 5 patches. oh well. | |
| 21:47 | jcamins | Just apply them all, then apply 8211. |
| 21:47 | wajasu | ok |
| 21:50 | jcamins | Fixed it! |
| 21:50 | There is only one problem: | |
| 21:50 | push @{$branch->{children}}, $nextBranch unless grep {$_->{authid} == $nextAuthid and $_ = $nextBranch} @{$branch->{children}}; | |
| 21:51 | rangi: could you please tell me how to make that line not the most horrible thing everevereverever? | |
| 21:52 | rangi | well for a start don't make it one line |
| 21:52 | jcamins | Maybe I can use a map instead. |
| 21:52 | It used to be a much shorter line. | |
| 21:52 | rangi | laziness in typing is never an excuse for writing obfusticated code |
| 21:53 | jcamins | It used to be push array, value; |
| 21:53 | * jcamins | liked that. |
| 21:53 | jcamins | It was brief. |
| 21:53 | cait | heh |
| 21:53 | cjh | jcamins: move the unless out of the line |
| 21:53 | jcamins | To the point. |
| 21:53 | * gmcharlt | doesn't mind the construct, but does think that sort of thing needs a comment to explain the intent |
| 21:53 | jcamins | Clear. |
| 21:53 | cait | make it nicer again? |
| 21:53 | jcamins | Okay, so far everyone has missed the real problem with it, I think. |
| 21:53 | You should be out with pitchforks! | |
| 21:53 | rangi | no one can see the real problem cos its a code barf |
| 21:53 | jcamins | " and $_ = $nextBranch" |
| 21:54 | rangi | yep |
| 21:54 | jcamins | The grep is kind of okay. |
| 21:54 | rangi | grep is fine unless in that is horrible |
| 21:54 | like cjh said, move it out | |
| 21:54 | pastebot | "gmcharlt" at 127.0.0.1 pasted "how I like to format stacks of maps and greps" (4 lines) at http://paste.koha-community.org/161 |
| 21:55 | jcamins | Ooh, I could put a map following a grep? |
| 21:55 | That would be more... no, it wouldn't, never mind. | |
| 21:55 | cjh | you can easily make it `unless(grep stuff){\n push stuff\n } |
| 21:55 | gmcharlt | yep - you can stack them as much as you want (at least until whoever has to read the code starts throwing things at you) |
| 21:55 | cjh | heh |
| 21:55 | jcamins | gmcharlt: but I'd still end up with the same horrid half-test, half-assignment thing. |
| 21:56 | gmcharlt | yeah - use greps only for testing, maps for mapping |
| 21:56 | jcamins | What if I turned the grep into an if, put a map in the "found" branch and the push in the not found branch? |
| 21:56 | wajasu | if you can comment it in english, then the intent is expressed. then later, someone like me can write a test. |
| 21:57 | cjh | gmcharlt++ |
| 21:57 | gmcharlt | although thinking about the "unless grep" construct -- you're mixing somethign that produces a list with something that looks for a (scalarish) boolean value |
| 21:57 | rangi | yeah |
| 21:57 | gmcharlt | so I suppose one way to make ones intent clear is to do |
| 21:57 | rangi | unless grep just feels wrong |
| 21:57 | gmcharlt | ... unless scalar( grep { ... } ...); |
| 21:58 | jcamins | wajasu: describing what I want to do in English is easy: "Replace the stub currently in children with a fully-realized branch, or add the fully-realized branch if there's no stub." |
| 21:59 | Then my knowledge of Perl refuses to tell me how to A) find out if there's a stub or B) replace said stub. | |
| 21:59 | What is the idiomatic way to check if an item exists in an array? | |
| 22:00 | * rangi | is trying to help the pasifika koha users group install koha over in another window |
| 22:00 | rangi | so not paying much attention |
| 22:01 | jcamins | for? |
| 22:02 | rangi | if you want to do it more than once |
| 22:02 | map it to create a hash, then exists | |
| 22:02 | gmcharlt | jcamins: List::MoreUtil any, perhaps |
| 22:02 | rangi | if once, iterating |
| 22:03 | both methods iterate, but the map makes the iteration prettier, and once its mapped you can do as many exists as you want | |
| 22:03 | gmcharlt | both of rangi's ideas will work too |
| 22:04 | jcamins | Yeah, I think iterating is the way to go. The order of elements is significant, and we only have to check once per recursion. |
| 22:04 | gmcharlt | but List::MoreUtil::any *might* be faster since it's a C routine, at least if you only need to check the existance once |
| 22:06 | * jcamins | thinks perhaps going with a for loop that he can definitely understand is probably superior in this case. |
| 22:08 | jcamins | Ha! |
| 22:09 | It works! | |
| 22:09 | cait: new squashed patch? | |
| 22:09 | Or do you want another follow-up? | |
| 22:09 | cait | hm yeah |
| 22:09 | let me sqash it all | |
| 22:09 | later | |
| 22:11 | jcamins | Okay. |
| 22:11 | Attached. | |
| 22:11 | cait | i will only take a quick look and continue tesitng tomorrow |
| 22:11 | getting late here | |
| 22:11 | jcamins | You should see how beautiful it is, though. All four levels showing up. :) |
| 22:11 | cait | I hope for you they do this time ;) |
| 22:12 | gmcharlt | |Lupin|: there's probably no general way -- source filters (among other things) are used for decrypting obfuscated source code; so if there was an easy way to do what you want without having to dig into the guts of the interpreter, source encryption modules would be useless |
| 22:12 | (not, of course, that I'm a fan of encrypting source code!) | |
| 22:15 | jcamins | wajasu: were you able to apply the patch? |
| 22:15 | cait | 4 levels!!! |
| 22:16 | rangi | well that was a lot harder than having a usable internet connection that can hold up audio would have been |
| 22:16 | |Lupin| | gmcharlt: yeah I think encryption is what the authors had in mind... I got help on "perl actually. The script was first uu-encoded and then Compressed... |
| 22:17 | wajasu | jcamins: nope. everything but 8211. sha1 information is lacking or useless (t/db_dependent/Search.t) |
| 22:17 | jcamins | wajasu: okay, I will try a new branch. |
| 22:17 | wajasu | thx |
| 22:19 | jcamins | wajasu: okay, tried again. |
| 22:19 | See if this one will apply. | |
| 22:20 | wajasu | is see it. tries again. |
| 22:27 | jcamins: it applied. testing now. | |
| 22:28 | * jcamins | breathes a sigh of relief. |
| 22:28 | * wajasu | the suspense is killing me |
| 22:29 | jcamins | wajasu: you're going to be disappointed once you test it. You're not going to have enough data for it to be particularly useful. |
| 22:30 | * jcamins | optimistically hopes it works. |
| 22:43 | cait | night all :) |
| 23:00 | wajasu | jcamins: somewhat working. but lets verify my config. i added the three authorities as per 8211 comment #2. does the rlin# in subtag 9 need to match the authority record# ? |
| 23:01 | search number #3 and #4 worked. | |
| 23:01 | comment #3 | |
| 23:01 | jcamins | wajasu: no, shouldn't be necessary. |
| 23:02 | wajasu | search #2 (su-br: gave me united states, arizona, and phoenix |
| 23:03 | jcamins | The records that come up when you search "su:Phoenix" don't come up when you just search "su:United States" or "su:Arizona" right? |
| 23:05 | wajasu | su:Arizona returned the Arizona and the Phoenix |
| 23:05 | jcamins | Okay, that means that the record for Phoenix has a subject you want to remove. |
| 23:06 | wajasu | Su:Phoenix just gave me Phonenix. |
| 23:06 | jcamins | Right. |
| 23:06 | wajasu | ok let me check |
| 23:06 | jcamins | I had this problem too. |
| 23:06 | * jcamins | originally had a record with the subjects "Phoenix" and "Arizona--Cities." |
| 23:06 | jcamins | I should have mentioned this restriction. |
| 23:07 | wajasu | it s a book, 100 best restaurants in the Valley of the Sun, and had a restaurant arizona in subject. let me reomve it |
| 23:07 | jcamins | (that it's hard to test if more than one term appears in a record) |
| 23:08 | wajasu | it was in 650 a topical term |
| 23:09 | jcamins | Yep. |
| 23:09 | That'll do it. | |
| 23:10 | wajasu | that did it. after i rebuild-zebra. Hooray !!!! |
| 23:10 | jcamins | Yay! |
| 23:10 | And don't forget the unit tests. | |
| 23:10 | |Lupin| | time for sleeping |
| 23:10 | goodbye all ! | |
| 23:10 | wajasu | did you right some for this bug specificially, or just run em all. |
| 23:11 | jcamins | Search.t has tests specifically for that bug, but I like running them all. |
| 23:11 | wajasu | ok. |
| 23:11 | jcamins | (any that failed in the past for you will still fail, of course) |
| 23:11 | wajasu | right. |
| 23:12 | jcamins | Myshkin (our cat) likes running all the tests too. |
| 23:30 | wajasu | jcamins: just a heads up. when i do a rebuild-zebra -a -b -r i get -> zebraidx(25864) [warn] Unknown register type: |
| 23:31 | jcamins | wajasu: yeah, there's a patch for that. |
| 23:31 | Nothing to do with this. | |
| 23:31 | cait has been complaining of it for about a month. | |
| 23:33 | papa joined #koha | |
| 23:33 | wajasu | i am doing prove/t prove t/db_dependent prove/xt |
| 23:44 | waiting on db_dependent. | |
| 23:52 | pastebot | "wajasu" at 127.0.0.1 pasted "result of my prove t/db_dependent after 8211 patch test" (379 lines) at http://paste.koha-community.org/163 |
| 23:54 | jcamins | Yup, those were all failing before. |
| 23:55 | wajasu | t and xt were all succcessful. |
| 23:55 | i'm doing format-patch -s master now | |
| 23:56 | after commit --amend |
← Previous day | Today | Next day → | Search | Index