← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
Time | Nick | Message |
---|---|---|
01:08 | Irma joined #koha | |
01:39 | dcook joined #koha | |
01:39 | dcook | allo #koha |
01:40 | rangi | hey dcook |
01:41 | dcook | Have a good weekend? |
01:42 | rangi | yeah not bad at all |
01:45 | dcook | I've been looking a bit more at the "blib" directory in my local git, and I'm wondering a bit about its purpose and the status of the files it contains. I figured it was used so that I could Koha as a dev install |
01:45 | But the files look like they're quite up to date, while my current branch is 3.8.0 O_o | |
01:46 | rangi | its used by any install |
01:46 | (except packages of course) | |
01:46 | when you run make | |
01:46 | it makes all the files and puts them in blib | |
01:46 | then make install copies them | |
01:46 | dcook | Hmm |
01:47 | rangi | don't commit the blib dir :) |
01:47 | dcook | Fair enough :p |
01:48 | Why would the files currently in there be 3.9 though? | |
01:49 | jcamins | dcook: because you didn't rerun make. |
01:49 | dcook | That's my thought too, but I ran make the first time when 3.8.0 first came out |
01:49 | Does updatedatabase re-run make? :S | |
01:50 | jcamins | No. |
01:53 | dcook | So how does a dev install use blib...? The files in there are much more recent than the ones I have checked out and which run when I go to the dev site |
01:53 | jcamins | It doesn't. |
01:56 | dcook | Perfect. Thanks for the info. |
02:05 | BobB joined #koha | |
03:15 | brylie joined #koha | |
03:47 | mtj | rangi: about? |
03:48 | is there are json output of -> http://bugs.koha-community.org[…]bin/bug_counts.pl ? | |
03:48 | i think i remember you showed me one, some time ago....? | |
03:51 | tcohen joined #koha | |
03:51 | tcohen | hi #koha |
03:52 | 1am here | |
03:57 | brylie joined #koha | |
04:04 | cait joined #koha | |
04:12 | tcohen joined #koha | |
04:14 | cait | good morning #koha |
04:15 | mtj | morning cait |
04:15 | cait | morning mtj :) |
04:23 | mtompset joined #koha | |
04:23 | mtompset | Greetings, #koha |
04:24 | cait | hi mtompset |
04:24 | mtompset | Greetings, cait |
04:24 | I'm finally going to get back to looking at koha bugs today. | |
04:24 | cait | hm I should do taht too |
04:25 | mtompset | I think I dealt with my backup scripts task well enough so far. :) |
04:26 | I'll finally get to deal with that email message that I left unread in my koha lists folder. | |
04:26 | related to bug 7368 | |
04:26 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7368 trivial, P5 - low, ---, m.de.rooy, ASSIGNED , General staff client typo omnibus |
04:27 | cait | oh |
04:28 | mtj | rangi: np, i got it sorted... :) |
04:29 | mtompset | can't hurt to triple check. But that's good to know. |
04:37 | brylie joined #koha | |
04:41 | * mtompset | frowns, "I don't understand git." |
04:41 | mtompset | I don't want to clone master, I want to clone 3.6.x |
04:45 | mtj | mtompset: clone master, then make a new branch 3.6.x |
04:45 | change to branch 3.6.x, then 'git reset --hard v3.6.6' | |
04:45 | wahanui | mtj: that doesn't look right |
04:45 | wahanui joined #koha | |
04:46 | mtj | i do this often, myself... |
04:48 | mtompset | Because I'd like to have 3 clones: master, 3.8.x, and 3.6.x, so I don't have to figure out more git commands when working on things that need fixing in all three, but don't necessarily need the same fixes. |
04:48 | mtj | sure, thats exactly what i have too :) |
04:48 | cait | you can checkout the tag too |
04:48 | git branch -b yourname v03.06.03 or something | |
04:49 | if you need a specific version | |
04:49 | mtompset | Yes, but when you lose track of branches, it becomes a pain. |
04:49 | If you have three repos for the three versions, there's no confusion. | |
04:50 | mtj | well, i guess.... ? i never lose track of well-named branches |
04:51 | of course , if you need a koha 3.8 and a koha3.6 to *compare* , you need 2 repos... | |
04:51 | (you cant have a repo set to 2 different commits at the same time) | |
04:52 | so, you would need 2 repos - for that debugging situation | |
04:52 | mtompset | And that solves my forgetfulness problem too. :) |
04:55 | mtj | 'compare' here, means compare the run-time behavior of 2 systems |
04:55 | not compare, as in git-diff | |
04:56 | * cait | nods |
04:56 | mtj | ... if you want to compare (giff-diff) 2 branches, you want to use *1* repo, not 2 repos |
05:01 | mtompset | Yes, but if you make a fix, you should at least try to run it. |
05:01 | So multi-repos makes more sense. | |
05:12 | can you rename the directory the git repo is in without breaking git? | |
05:13 | cait | yes |
05:13 | I think so | |
05:16 | mtj | yes, absolutely |
05:17 | mtompset: there's nothing stopping you from 'running' a fix, using a single repo? | |
05:18 | testing a fix on many Koha branches, is easier on a single repo | |
05:19 | mtompset | depends on the state of the surrounding code between versions. |
05:20 | Sometimes things get added between versions which makes a patch not applicable across branches. | |
05:21 | mtj | sure, but you are still going to have exactly the same problem applying your problematic patch using many repos |
05:21 | ... so whats your point? | |
05:22 | mtompset | do a diff between repo directories, and make the changes myself. |
05:23 | mtj | hmm, thats precisely what an scm is designed for |
05:24 | mtompset | don't trust them. :P |
05:24 | mtj | ok, good luck, then.... |
05:24 | cait | mtompset: why notmake a patch file? |
05:25 | mtompset | the scenario is a problematic patch across versions. |
05:25 | cait | I think that would perhaps work a bit better than manually moving patches around. or you could have a central repo you push your changes to |
05:26 | mtompset | that I want to test too. |
05:26 | No sense submitting a busted patch. :) | |
05:28 | Okay, so mtj, how would you do a patch on 3.6.X that doesn't apply properly to 3.8.X, but the bug still exists in 3.8.X? | |
05:30 | mtj | thats a nice tricky situation :) |
05:30 | id apply the patch to my 3.8 koha | |
05:30 | test that the patch works | |
05:31 | if it does, apply the patch to my 3.6 koha | |
05:31 | (and after i apply the patch - fix the conflicts, of course) | |
05:32 | and , if the patch was written against master, then apply/test it to master 1st | |
05:32 | mtompset | next question in my git education... how to apply a patch? |
05:33 | mtj | mtompset: does that logic make sense to you? |
05:34 | mtompset | I'll re-iterate what you said in my words, and hopefully they are the same. |
05:34 | Make the patch in the version you found the error in. | |
05:35 | Take the patch and attempt to apply it to another version. | |
05:35 | If it applies, great... test it... everyone should be happy. | |
05:35 | If it doesn't apply nicely, make the necessary tweaks... test it... generate version'd patch. | |
05:36 | mtj | depends.. do you want to submit the bug to kc.org - or go for a quick-fix? |
05:36 | mtompset | Why would I be only think of myself in the short term? |
05:36 | That's not long term efficient for me. | |
05:37 | Always attempt to bug report it and provide a patch to k-c.org | |
05:37 | mtj | why? , its quicker, less short-term effort, and its an emergency |
05:38 | mtompset | The bugs I fix aren't emergencies. |
05:39 | mtj | depends, if its a critical production bug - always fix the bug 1st, submit a fix to kc.org later... |
05:39 | huginn | 04Bug http://bugs.koha-community.org[…]show_bug.cgi?id=1 major, P2, ---, chris, CLOSED FIXED, Missing uploadedmarc table definition |
05:40 | * mtompset | laughs. |
05:41 | mtompset | Yes, I do too, but the time difference between the two is very small. |
05:42 | But since 3.6.7 came out, I doubt we'll have anything of significance once we upgrade. | |
05:43 | So, since I think I got the general gist of that... back to my next question: how to apply a git patch? | |
05:43 | mtj | $ git am -s ./0001-Bug-6466-hung-socket-read-causes-SIP-tests-to-fail.patch |
05:44 | you can google all that stuff... | |
05:44 | mtompset | Okay. |
05:57 | cait | mtj: if it's a critical bug - we need the patch even more :) |
05:57 | * mtompset | is reading up on git merge. |
05:57 | cait | mtompset: I never merge :P |
05:58 | mtompset | It's an easy way to copy files between branches. |
05:58 | if you've only added files. | |
06:04 | mtj | git cherry-pick , is a nice way to do that too (what i use) |
06:04 | cait | yes, I use that too |
06:04 | mtj | cherry-pick a commit(s) from another branch |
06:04 | cait | but was not sure it's the right advice :) |
06:06 | mbalmer joined #koha | |
06:06 | cait | morning |
06:20 | mtompset | Greetings, mbalmer |
06:21 | dcook_away | git cherry-pick can also be used with tags, if you find that to be a handy way of identifying a commit |
06:21 | After a great introduction to git from rangi and jcamins, I found the best way to learn about git was to experiment and test out different scenarios. As a result, I'm certainly a convert to developing in git. | |
06:22 | cait | :) git++ |
06:23 | dcook_away | :D |
06:24 | ala_3v0 joined #koha | |
06:27 | ala_3v0 | can anyone help on the installation of koha on debian squeeze |
06:27 | julian_m joined #koha | |
06:28 | julian_m | hello |
06:28 | wahanui | salut, julian_m |
06:29 | ala_3v0 | I've followed an online tutorial but have difficulties at the end when launching browser |
06:31 | mtj | ala_3v0: always look on the koha wiki, for the latest install information |
06:32 | ala_3v0 | mtj - thanks |
06:33 | mtj | or in your koha directory -> http://git.koha-community.org/[…];f=INSTALL.debian |
06:33 | http://wiki.koha-community.org[…]gory:Installation | |
06:34 | http://wiki.koha-community.org[…]on_Debian_Squeeze | |
06:34 | etc... | |
06:34 | ala_3v0 | mtj: I have a message on browser that states system maintenance when launching http://localhost:80 |
06:35 | mtj | try http://localhost:8080 first... |
06:37 | ala_3v0 | I've un-installed the debian but thanks anyway |
06:39 | mtj | ala_3v0: you should have asked your question here *before* un-installing the debian ;) |
06:40 | ala_3v0 joined #koha | |
06:41 | mbalmer | morning, kohaistas! |
06:44 | ala_3v0 | Hi, mbalmer. |
06:45 | laurence joined #koha | |
06:47 | ala_3v0 | If I backup or dump a koha sql from a debian and restore it on ubuntu, can the koha system be fully functional? |
06:49 | BobB_ joined #koha | |
06:50 | mtj | ala_3v0: if you are lucky, yes |
06:51 | mtompset | I don't see why not. |
06:51 | from a mysqldump that is. | |
06:52 | ala_3v0 | yes from mysqldump |
06:52 | mtj | depends.... different mysql versions between systems - could be a problem... |
06:53 | mtompset | a mysqldump should be generic enough to transfer. |
06:53 | especially if ala_3v0 only dumped the koha database (whatever it is called) | |
06:56 | ala_3v0 | Is there any koha live cd on debian squeeze around as I can only find koha live cd on ubuntu |
06:58 | mtj | mtompset: they 'should be' yes, but my experience has been otherwise |
07:01 | ala_3v0 | when books have been inputed into koha on the cataloging section, how long does it take to be able to be searched and found in OPAC? |
07:02 | mtompset | really, mtj? |
07:02 | what koha live cd for ubuntu? | |
07:03 | That version of koha may be out of date. | |
07:03 | ala_3v0 | There is a Koha 3.8 live on ubuntu |
07:03 | mtompset | Really? Cool. |
07:04 | I did not know this. | |
07:04 | url, please. | |
07:04 | ala_3v0 | check linux halwa |
07:05 | mtj | ala_3v0: no koha live-cds are officially supported, yet |
07:06 | live-cds many work, or not.... use them at your own risk | |
07:06 | ala_3v0 | I have downloaded a copy, not sure where from |
07:06 | mtompset | That much is true: not officially supported. |
07:07 | dcook_away | 'night #koha |
07:08 | mtj | ... and people here on #koha-irc wont be able to help you much, if you have problems with your live-cd |
07:08 | * mtompset | nods. |
07:08 | mtompset | which install to use? |
07:08 | wahanui | If you're developing, you should use git. If you're not developing on a deb-based system, you should use packages. If you're not developing on a different flavour of Linux, you should use the tarball. |
07:09 | ala_3v0 | what is koha-common then? |
07:09 | mtompset | that is packages. |
07:09 | packages? | |
07:09 | wahanui | rumour has it packages is at http://wiki.koha-community.org/wiki/Debian |
07:10 | mtompset | http://wiki.koha-community.org[…]on_Debian_Squeeze |
07:10 | That was the URL I was thinking about. | |
07:10 | I have not tried it, but these instructions should work under Ubuntu as well. | |
07:11 | http://wiki.koha-community.org[…]ki/Koha_on_Ubuntu | |
07:11 | These instructions will guide you to do a tarball install. | |
07:12 | asaurat joined #koha | |
07:18 | kf joined #koha | |
07:19 | ala_3v0 | thanks all... night... #koha-irc |
07:19 | paul_p joined #koha | |
07:19 | kf | morning #koha, morning paul_p |
07:19 | paul_p | good morning #koha & kf |
07:20 | last week before holidays for me ;-) | |
07:20 | kf | :) |
07:20 | lots to do I bet | |
07:20 | how many weeks will you be gone? | |
07:21 | paul_p | kf = fortunately, most if not all our customers are on vacation already, so lot of things to do, but not the usual one |
07:21 | 3 weeks | |
07:21 | kf | ah ok |
07:21 | and not pushing at all during this time? | |
07:25 | mtompset | Someone is counting down. :) |
07:33 | laurence1 joined #koha | |
07:34 | julian_m joined #koha | |
07:35 | bartsimpson joined #koha | |
07:35 | bartsimpson | @rangi hello, it's Bart, I'm just about to start trying some unit testing so i'll message you if i need help :) |
07:35 | huginn | bartsimpson: downloading the Perl source |
07:37 | rangi | yay! thats cool bartsimpson |
07:37 | kf | hi bartsimpson :) you don't need an @ - just say rangi: |
07:37 | rangi | i meant to say, if you can remember how to do a commit and then format-patch you can attach the tests you did on thursday |
07:37 | to bug 5327 | |
07:37 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=5327 major, P3, ---, paul.poulain, ASSIGNED , Unit tests required for all C4 modules |
07:38 | rangi | git add t/ItemType.t |
07:38 | git commit | |
07:38 | Then | |
07:38 | git format-patch origin/master | |
07:40 | bartsimpson | oh thanks kf :) and allright i'll maybe put a add a few lines of test first then try to commit it |
07:40 | rangi | excellent :) |
07:44 | laurence joined #koha | |
08:01 | bartsimpson | rangi: Hello, whats the code to run a unit test? eg I'm currently trying to run Itemtype.t |
08:01 | rangi | perl t/ItemType.t |
08:02 | or prove t/ItemType.t | |
08:03 | bartsimpson | hmmm |
08:03 | one sec | |
08:04 | oh I was already in the t layer :) so the t/ at the start was wrong, thanks | |
08:04 | rangi | ahh yep |
08:07 | mtompset | kohails? |
08:08 | kf | yes |
08:08 | our official tag | |
08:08 | for twittter - ils is integrated library system | |
08:09 | mtompset | oh right... my brain didn't parse koha ils... I was thinking ko hails. |
08:12 | mbalmer | let's see... |
08:14 | bartsimpson | rangi: I've gone through the steps to submit you wrote previously ^ but am wondering what I need to do now |
08:15 | gaetan_B joined #koha | |
08:15 | tweetbot` | .. |
08:15 | ..#arcapos" | |
08:15 | mbalmer | funny, that works, indeed ;) |
08:16 | didn't know we track tweets in this channel | |
08:16 | rangi | bartsimpson: ahh now you need to go to http://bugs.koha-community.org[…]w_bug.cgi?id=5327 |
08:16 | huginn | 04Bug 5327: major, P3, ---, paul.poulain, ASSIGNED , Unit tests required for all C4 modules |
08:17 | rangi | and click add attachment and upload the file |
08:17 | paul_p joined #koha | |
08:18 | rangi | mbalmer: http://irc.koha-community.org/[…]2-07-11#i_1019931 |
08:19 | short memory :) | |
08:19 | mbalmer | hehe, I obviously changed my mind. |
08:19 | and short memory, too | |
08:19 | but if you think of it, it is indeed a bit dubious to post in a public channel what has been posted in a different public channel | |
08:24 | bartsimpson | rangi: so do i just upload the Itemtype.t file itself from the /t directory? |
08:25 | kf | mbalmer: I don't think so, once it's public, it's public |
08:25 | rangi | bartsimpson: ahh nope, you have to do the git commit stuff, and git format-patch from earlier |
08:27 | bartsimpson | rangi: right, yeah i did do that git commiting, but I'm not sure where to find that file to upload? sorry if that seems silly :) |
08:27 | rangi | ahh |
08:27 | when you do the git format-patch | |
08:27 | its should make one on the dir you are in it will be 0001-somethingsomething.patch | |
08:28 | bartsimpson | oh right that |
08:28 | wahanui | right that is, like, what I was thinking :D |
08:29 | mtompset | That's why I like to personally add '-o ~' on the end, so I know the patch file is always in my home directory. |
08:35 | bartsimpson | rangi: cool i'm fairly certain that worked ;) :) I'm going to try start some work on the Matcher.t file you suggested on thursday |
08:38 | rangi | excellent :) |
08:38 | yep that patch looks good :) | |
08:44 | stuartyeates joined #koha | |
08:49 | bartsimpson | rangi: Hey, Im unsure of where to get a data table for the Matcher.t file... Any suggestions? |
08:49 | rangi | lemme look |
08:50 | http://schema.koha-community.o[…]arc_matchers.html <-- does that help ? | |
09:00 | m23 joined #koha | |
09:00 | bartsimpson | ummm |
09:01 | m23 | Hello, can i report problem with http://translate.koha-community.org here? |
09:02 | kf | m23: yes you can, but a bit better is the translate mailing list :) |
09:03 | m23 | ok, thanks |
09:04 | bartsimpson | rangi: nah I'm still confused about that, semi-relatedly im getting this error "unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 360" when i perl the matcher thing |
09:05 | * mtj | thought mbalmer was blocking his stupid tweetbot... |
09:06 | rangi | bartsimpson: you can do this |
09:06 | kf | !tweetbot botsnack cookie? |
09:06 | rangi | export KOHA_CONF=/etc/koha/sites/yoursitename/koha-conf.xml |
09:06 | kf | tweetbot botsnack cookies |
09:06 | mtj: your bot has a bug :( | |
09:08 | mtj | whats the bug? |
09:09 | kf | it refuses my cookies |
09:11 | mtj | kf, aaah - that feature is the 'enterprise' edition of tweetbot |
09:13 | kf | oh |
09:13 | *sniff* | |
09:14 | pastebot | "rangi" at 127.0.0.1 pasted "some mock data" (6 lines) at http://paste.koha-community.org/66 |
09:16 | laurence1 joined #koha | |
09:18 | mveron joined #koha | |
09:18 | mveron | hi #koha |
09:27 | rangi | bartsimpson: gonna crash out soon, but drop me an email if you are still stuck and ill try to help out |
09:31 | bartsimpson | rangi: yea i've gtg to, ill talk to you later :) |
09:31 | rangi: thanks for all the help | |
10:21 | Joubu joined #koha | |
10:21 | Joubu | Hi #koha |
10:23 | Someone could say me how can I call a subscription closed ? terminated ? ended ? I want to add a new boolean field subscription.closed. But I don't know if it is the most adapted term | |
10:36 | kf | hm |
10:36 | Joubu: perhaps try in half an hour or so? | |
10:36 | I think America is not awake yet maybe | |
10:38 | Joubu | kf: ok thanks :) |
10:38 | kf | and I Like the idea :) |
10:38 | perhaps we could have even more status? we migrated a library and they had differentiated between | |
10:39 | hm. serial has a new name, serial subscription ended (serial died), subscription was ended by the library | |
10:39 | (saving money) | |
10:39 | something like that | |
10:42 | * magnuse | waves |
10:45 | kf | hi magnuse :) |
10:49 | magnuse | hiya kf |
10:53 | mtompset | Greetings, kf magnuse Joubu |
10:54 | * kf | sends cookies |
10:59 | mtompset | Thanks. |
11:01 | On a positive note, I cloned master three times. Now to set one to 3.6.x and the other to 3.8.x | |
11:02 | scrolling back to see what mtj said. | |
11:18 | jwagner joined #koha | |
11:23 | mtompset | Greetings, jwagner |
11:25 | jwagner | hi mtompset |
11:32 | asaurat joined #koha | |
11:34 | * mveron | is back from lunch |
11:34 | mveron | Hi everybody |
11:36 | laurence joined #koha | |
11:54 | mtompset | Greetings, mveron |
11:54 | Greetings asaurat laurence | |
11:54 | mveron | Hi mtompset |
11:55 | asaurat | hi! |
11:56 | mveron | hi asaurat |
12:05 | talljoy joined #koha | |
12:10 | McCloud joined #koha | |
12:13 | * mtompset | is happy to have 3 different git clones: 3.6.x, 3.8.x, and master. YAY! |
12:15 | mtompset | jcamins_away: Are you still away? I have updated check_deps.sh |
12:16 | I was going to check my changes against my three new git directories. :) | |
12:20 | tcohen joined #koha | |
12:24 | mtompset | Greetings, tcohen |
12:24 | tcohen | hi mtompset |
12:24 | i was thinking of talking to you | |
12:25 | * mtompset | runs away. :) |
12:25 | tcohen | but I'll let my new bug will talk for itself |
12:25 | mtompset | Which bug? |
12:25 | tcohen | I need to finish our -> 3.8 upgrade right now |
12:25 | but will beback soon! | |
12:26 | mtompset | I'm about to run the script I wrote for 3.8.x :) |
12:26 | tcohen | :-D |
12:26 | mtompset | I finally have a 3.6.x, 3.8.x, and a master git |
12:27 | I can run the script without having to do git commands in between. :) | |
12:28 | McCloud | Anyone know why apt-get upgrade would "keep koha-common back" when ran? |
12:29 | mtompset | Oh, and I did get a -b -r version of koha_perl_deps.pl done too... |
12:29 | Just some of the things I hope to get up to bugzilla in the next couple days. | |
12:30 | drojf | McCloud: not sure why that is but apt-get dist-upgrade will probably work |
12:31 | tcohen | mtompset++ |
12:35 | McCloud | Yep, that worked! |
12:43 | drojf1 joined #koha | |
12:43 | kf | hi drojf |
12:43 | drojf | hi kf |
12:47 | NateC joined #koha | |
12:48 | mveron | hi drojf |
12:48 | drojf | hi mveron |
12:53 | ago43 joined #koha | |
12:54 | mtompset | It would seem that I found one library that wasn't in the ubuntu.packages for 3.6.x -- libgd-gd2-perl |
12:55 | kf | hm |
12:55 | wonder for what that is used | |
12:59 | chris_n joined #koha | |
12:59 | mtompset | C4::Images, tools/picture-upload.pl, tools/upload-cover-image.pl |
13:00 | asaurat1 joined #koha | |
13:01 | mtompset | And ubuntu 12.04 does not have Template::Plugin::HtmlToText |
13:01 | So, using the debian.k-c.org repo is necessary. | |
13:02 | oleonard joined #koha | |
13:02 | mtompset | And there are thirteen libraries not listed in the ubuntu.packages for 3.8.x |
13:03 | libsysguy joined #koha | |
13:04 | nengard joined #koha | |
13:04 | edveal joined #koha | |
13:04 | nengard | Good morning #koha |
13:04 | I'm training a new Koha library in PA | |
13:04 | say Hello! | |
13:04 | oleonard | Hi PA! |
13:04 | mtompset | Greetings, folks in PA! :) |
13:05 | mib_rb4y83 joined #koha | |
13:05 | laurence joined #koha | |
13:06 | nengard | Quiet in here |
13:06 | * mtj | waves to peepz in PA |
13:06 | nengard | talk to you all later!! :) |
13:06 | mtj | heya nicole : |
13:07 | kf | Hello :) |
13:08 | mtompset | Oh my! lots more missing in master. |
13:13 | * McCloud[A] | is now away - Reason : Auto-Away after 30 minutes |
13:14 | asaurat1 left #koha | |
13:14 | asaurat joined #koha | |
13:15 | mveron | drojf ++ |
13:15 | drojf | :) |
13:15 | kf | drojf++ :) |
13:16 | mtompset | What's the +'s for? |
13:16 | oleonard | @karma drojf |
13:16 | huginn | oleonard: Karma for "drojf" has been increased 19 times and decreased 1 time for a total karma of 18. |
13:17 | mveron | mtompset: Bug 8518 |
13:17 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8518 minor, P5 - low, ---, veron, Needs Signoff , Self checkout does not display debt amount if syspref AllowFineOverride is set to allow |
13:18 | kf | mtompset: increasing karma - in this case for signing off a patch :) |
13:18 | and for a cool new domain name ;) | |
13:19 | laurence joined #koha | |
13:20 | mtompset | marcelr++ |
13:20 | drojf | thanks to mveron's bug i now know the koha self checkout ;) |
13:20 | asaurat1 joined #koha | |
13:20 | kf | yep |
13:21 | testing is a great way to learn more about Koha's features | |
13:21 | *hint hint* | |
13:21 | mveron | ^^^^^^ |
13:21 | drojf | heh mveron got my point for the dashboard because he changed it to signed off :P |
13:22 | mveron | Sorry, drojf, I did not mean it! |
13:22 | drojf | yeah right! |
13:22 | :D | |
13:22 | mveron | You can get my next one, I will give you a hint... |
13:22 | drojf | lol |
13:23 | hmm if the count goes by that i guess you can change the status of a bug a few times to get more points | |
13:24 | and cheat your way to the top ;) | |
13:26 | asaurat joined #koha | |
13:29 | drojf | is that number of 115 needed signoffs hardcoded? sometimes it feels that way. |
13:32 | mgeist joined #koha | |
13:33 | jcamins | drojf: hehe. No, but that does seem to be the patch equilibrium. |
13:35 | Joubu | Could someone (a native english speaker by preference ) tell me how I should name a new boolean field in subscription for a closed/terminated/ended subscription ? Currently I choose "closed", but I don't know if it is the most adapted term. |
13:37 | jcamins | Joubu: I'd probably use "closed" here, too. |
13:37 | asaurat1 joined #koha | |
13:37 | asaurat1 joined #koha | |
13:37 | mveron joined #koha | |
13:38 | Joubu | jcamins: ok, thank you for the confirmation :) |
13:43 | Shane-s joined #koha | |
13:48 | tcohen | bug 8519 |
13:48 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8519 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Make koha-index-daemon run on startup |
13:48 | Shane-s | questions 952$o has no descriptions if it is arbitrary (user can fill it in) or system generated. I am using MarcEdit and I have an 852$h from follet that is a call number is 952$o the right field to use? |
13:50 | maximep joined #koha | |
13:52 | talljoy | Shane-s: yes it is |
13:52 | 952$o is the call number for the item record. | |
13:58 | mtompset | jcamins... I'll email you the latest version of check_deps.sh shortly. |
13:58 | jcamins | Take your time. I probably won't be doing anything with it today. |
13:58 | mtompset | Now you can have you --noupdate. |
13:59 | ^you^your^ (second one) | |
13:59 | and --full | |
13:59 | shortly in this case means later this week. :) | |
14:00 | I want to try to get some patches up before going to bed close to on time. | |
14:00 | But I just discovered some more tweaks I need to make to the documentation. ARG! | |
14:10 | SJeffery joined #koha | |
14:13 | kf left #koha | |
14:30 | Shane-s | okay before I go importing 7655 records, lets say I find I missed a few fields is there a quick and easy way to drop the records in Koha or the MySQL DB? |
14:30 | * wizzyrea | waves sleepily |
14:30 | wizzyrea | at 9:30 oy. |
14:33 | gmcharlt | Shane-s: bibliographic and item records? if so, one option is to pass the -d switch to bulkmarcimport.pl, which will make it delete all bibs and items prior to performing the record load |
14:34 | Shane-s | gmcharlt: yes, but say after it has imported the records and we are testing the data imports and I find I missed or improperly located a record, so the system has bad data |
14:35 | jcamins | Shane-s: you can always do a 'DELETE FROM biblio' but there is no situation I can think of in which that would be anything other than a bad idea. |
14:35 | gmcharlt | right; when it comes time to reload the records, -d would clear out the previous bib/item record set |
14:37 | Shane-s | thanks, I am trying to get this as perfect as I can, but it was just me testing my non-production system. This will all be going into the production system, and I had missed call number, and I need to modify the barcode field as follet pre-prends a T to many barcodes. I didn't find other issues, but who knows come school opening when my Librarian is in |
14:39 | jcamins | Shane-s: a useful saying in this situation: "the perfect is the enemy of the good." |
14:50 | mtompset | I so hate "triggers for mandb". It's so slow! |
14:52 | Shane-s | anyone good with regex that marcedit might use, I want to get subfield $p and if it begins with a "T" remove that. I am thinking ^T*, but I don't know how to make it spit back out just the rest less the T |
14:52 | maybe just a find and replace on $pT would be better | |
14:52 | jcamins | s/^T\(.*)$/\1/ |
14:56 | Shane-s: that was a response to you, not the cat. | |
14:56 | ;) | |
14:56 | JesseM joined #koha | |
15:02 | * wizzyrea | giggles at jcamins, waves hi to myshkin |
15:02 | mgeist | Hrm, that does look like something a cat would type. |
15:05 | jcamins | mgeist: I have a remarkably smart cat. |
15:05 | wizzyrea | ^^ myshkin is a cat genius. |
15:06 | jcamins | And he's been particularly rambunctious of late. Not only has he been bored for the last two weeks, Shari's away this weekend, and he is not amused. |
15:06 | edveal left #koha | |
15:06 | mgeist | laser point imo! |
15:06 | drojf | cats can be bored? |
15:06 | jcamins | drojf: so it would seem. |
15:09 | mgeist: I probably should get one of those and use it to tire out Myshkin. | |
15:10 | Shane-s | jcamins: Thanks...struggling with it in MarcEdit |
15:10 | mgeist | jcamins just be sure not to point it at airplanes |
15:10 | Shane-s | on windows |
15:10 | jcamins | Shane-s: I use neither, so I can't really advise. |
15:11 | mtompset | jcamins: Just to point out the apt-file index isn't there for the k-c.org repos yet. ;) |
15:12 | jcamins | mtompset: I have no control over those repos. |
15:12 | I left a message for eythian. | |
15:12 | edveal joined #koha | |
15:12 | mtompset | I was just trying to wean my machines dependency on your repo to k-c.orgs :) |
15:12 | asaurat1 left #koha | |
15:13 | mtompset | apt-file indexes would have been nice. :) |
15:13 | jcamins | Oh, yes, that would be good, because I took my apt repo down temporarily. |
15:14 | mtompset | Not to mention your apt isn't in the ubuntu installation instructions. :P |
15:14 | jcamins | That too. |
15:16 | SJeffery joined #koha | |
15:17 | mtompset | How do I tell what I have installed, and where it is from? |
15:18 | jcamins | apt-cache policy |
15:19 | I don't know exactly how to use it, but it has something to do with apt-cache policy. | |
15:19 | mtompset | okay thanks for the pointer at least. |
15:21 | trea joined #koha | |
15:21 | oleonard | The "[off] |
15:21 | ..always makes it seem like tweetbot` is gossiping | |
15:23 | jcamins | Heh. |
15:25 | Shane-s | question in MarcEdit some field begin with \\ others don't anyone know if that matters for MARC? |
15:25 | jcamins | Yes. |
15:25 | Those are indicators. | |
15:25 | Shane-s | so the \\ is needed? |
15:25 | jcamins | Yes. |
15:25 | They are indicators. | |
15:26 | Shane-s | okay...how to append that...as marc edit just swap $h from 852 to 952 $o, but it put it in like =952 $o001.9ASI |
15:27 | jcamins | I have no idea, sorry. |
15:27 | As I said, I use neither MarcEdit nor Windows. | |
15:27 | Shane-s | has an indicator box, I guess I add \\ ill find out :P |
15:29 | that worked | |
15:30 | can I have mutliple line of =952 \\ with different subfields per line? | |
15:30 | jcamins | If you want multiple items. |
15:30 | One 952 line per item. | |
15:30 | mtompset | If my librarian colleague was awake and online, I'd get him to help you, Shane-s. |
15:31 | jcamins | I can't tell if that is what you are looking for. |
15:31 | mtompset | I wrote scripts to modify it myself. :) |
15:31 | jcamins: apt-cache dump | grep "File:" | sed -e 's#\t##g;s#[[:space:]]##g' | sort -u | |
15:32 | at least that let's me know what I'm dependent on. | |
15:32 | I think I removed dependency on you. :) | |
15:32 | Shane-s | hmm wonder if it has an ability to merge it all to one line |
15:32 | jcamins | I suspect there was probably an easier way, but that works. :) |
15:32 | Shane-s | doh nm there is an "add to esiting field" option |
15:37 | wizzyrea | quick, say something defamatory! |
15:38 | oleonard | Blargle blargle blargle! |
15:38 | mtompset | Debian is terrible? |
15:38 | jcamins | 's mother was a hamster! |
15:39 | mtompset | Out of curiousity, why? |
15:39 | oleonard | No logbot, no logs |
15:39 | mtompset | BTW, jcamins wins hands down, I think for the defamatory. |
15:39 | AH! | |
15:40 | eythian joined #koha | |
15:40 | logbot joined #koha | |
15:41 | * oleonard | whistles innocently |
15:41 | mtompset | Greetings, eythian. I'll try not to mention how much I'd like index files so apt-file can work for debian.koha-community.org ;) |
15:41 | eythian | mtompset: I have no idea how that would even work, to be honest :) |
15:42 | mtompset | I think we are supposed to ask about the hamsters. ;) |
15:42 | eythian | well, rather, I have no idea how I'd do that.. |
15:42 | heh | |
15:43 | jcamins | eythian: it's easy. |
15:43 | eythian: did you get my @later from huginn? | |
15:43 | eythian | jcamins: I did |
15:43 | just looking into it now | |
15:44 | jcamins | Didn't it have instructions? |
15:44 | Or did I say "ask me for instructions"? :) | |
15:45 | eythian | No, it has instructions, I'm just curious about what the impact would be: I'm not sure about the options that that file can take, so looking that up. |
15:45 | jcamins | Ah. |
15:47 | mtompset | impact? |
15:48 | My beautiful baby script can run nicely and list things to include for ubuntu related files, and detect what should be added to the repo too. :) | |
15:48 | eythian | jcamins: seems sane, aside from making things a bit slower, but that's not a big deal. |
15:49 | jcamins | eythian: yeah, that was my conclusion. |
15:50 | mtompset | Going to bed... late again. :( At least it isn't past midnight, yet. |
15:51 | Good night, $koha./ | |
15:51 | #kohas | |
15:51 | #koha | |
15:51 | I'll get it right eventually. :) | |
15:54 | Joubu | good bye ++ |
15:56 | oleonard | Are the patches on Bug 8391 complementary or competitive? |
15:56 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8391 normal, P5 - low, ---, kyle.m.hall, Signed Off , Cannot view reading record through staff client |
15:56 | oleonard | Oh, khall just signed off |
16:00 | Morthland joined #koha | |
16:01 | eythian | jcamins: can't find a way to make the contents regenerate, it might only take effect as new packages get added. |
16:02 | jcamins | eythian: you use reprepro, right? |
16:02 | eythian | yeah |
16:02 | jcamins | reprepro -b /home/jcamins/repos/apt/koha rerunnotifiers |
16:03 | Morthland | Hey, I'm trying to figure out how to configure the authorities browser |
16:03 | eythian | jcamins: that returns immediately |
16:04 | jcamins | Morthland: the browser is UNIMARC-only. |
16:05 | eythian: really? That took a while on mine, and generated the indexes. | |
16:05 | Morthland | I mean to refer to the browser associated with the opacbrowser system preference. |
16:05 | jcamins | Yes. |
16:05 | That is UNIMARC only. | |
16:06 | Morthland | That is not my issue. |
16:06 | Our library is cataloged LCC | |
16:06 | and it is building a list by LCC | |
16:07 | but by the end of the list, it searches : Dewey-classification: BS2 | |
16:07 | for example | |
16:07 | jcamins | Morthland: it only supports UNIMARC, which you are not using, and Dewey, which you are also not using. |
16:07 | melia joined #koha | |
16:07 | Morthland | Oh. Thanks. |
16:10 | I get this error on the tag cloud: C4::Output version 3.02 required--this is only version 3.08.01.002 at /usr/share/koha/opac/cgi-bin/opac/opac-tags.pl line 41. BEGIN failed--compilation aborted at /usr/share/koha/opac/cgi-bin/opac/opac-tags.pl line 41. | |
16:11 | jcamins | Morthland: that was fixed in 3.8.3. |
16:12 | Morthland | Allright. |
16:12 | Thanks! | |
16:15 | eythian | jcamins: yep, definitely doesn't work |
16:16 | can't really look into it right now though, have some time-sensitive stuff to get done | |
16:16 | jcamins | eythian: odd. That's how I did it. |
16:16 | Wait, sorry: reprepro -b /home/jcamins/repos/apt/koha export | |
16:17 | eythian | ah, that does it. |
16:18 | only takes a few seconds, too | |
16:18 | jcamins | You may have it running on a faster system than I do. |
16:19 | eythian | possibly :) |
16:19 | anyway, uploaded | |
16:19 | jcamins | eythian++ |
16:19 | mtompset will be happy. | |
16:19 | eythian | @later tell mtompset apt-file will possibly work now |
16:19 | huginn | eythian: The operation succeeded. |
16:19 | jcamins | And it'll help when I build 3.6.8. |
16:20 | eythian | to be honest, so will I, it'll mean I can remove that change to list-deps to handle the non-debian stuff |
16:20 | jcamins | Yay! |
16:25 | cait joined #koha | |
16:25 | * tcohen | has now 38 koha setups upgraded to 3.8 @ Universidad Nacional de Córdoba |
16:26 | cait | congrats :) |
16:26 | tcohen | wiiiiiiiiii |
16:26 | :-D | |
16:26 | oleonard | Nice work tcohen |
16:26 | cait | and hi all :) |
16:26 | oleonard | We're live on 3.8.3 as of today |
16:27 | tcohen | that's great oleonard |
16:27 | khall joined #koha | |
16:27 | oleonard | The only glitch we've found so far has been Bug 8522 |
16:27 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8522 normal, P5 - low, ---, oleonard, ASSIGNED , Markup errors cause problems with customized CSS |
16:28 | tcohen | I find it a bit resource-consuming than our old 3.0.x setup |
16:31 | mbalmer joined #koha | |
16:32 | tcohen | oleonard, r u working on that? |
16:32 | oleonard | Patch sent. |
16:33 | Ha, the CSS example in my patch didn't come through because it was prefexed with # | |
16:40 | wizzyrea | oh yea i was going to ask how it was going today oleonard |
16:40 | and you answered my question :) | |
16:40 | glad it's going ok | |
16:42 | SJeffery joined #koha | |
16:43 | SJeffery | Are there any plans to make the 78x fields a standard display field? I have not found anything in the tracker. |
16:44 | mtompset joined #koha | |
16:44 | mtompset | tcohen: you there? |
16:44 | drojf | mtompset: having nightmares? |
16:44 | sleep kohaing? | |
16:45 | jcamins | SJeffery: 780 and 785 are already displayed. |
16:45 | mtompset | Nope... I just wanted to get my patch up for a bug. |
16:45 | bug 8478 | |
16:45 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8478 enhancement, P5 - low, ---, tomascohen, NEW , Update Ubuntu related files |
16:45 | mtompset | Submitted a 3.8.X and master patch. |
16:46 | Since tcohen said he was thinking of tweaking install instructions, so I wanted to make sure he could use the latest version I had. | |
16:46 | jcamins | At least in the OPAC. |
16:47 | SJeffery | Hmm, weird, how did I miss that? Must be a Monday. |
16:48 | jcamins | SJeffery: it does seem to be, doesn't it? |
16:50 | talljoy joined #koha | |
16:53 | mtompset | Woo hoo! jcamins we have index! |
16:54 | jcamins | mtompset: yep. |
16:54 | mtompset | going to do a test run of check_deps.sh |
16:54 | the missing file should become empty. :) | |
16:55 | drojf | mveron++ |
16:55 | mveron | drojf ++ |
16:56 | talljoy1 joined #koha | |
16:56 | * mveron | ...needs dinner |
16:56 | * oleonard | ...needs lunch |
16:57 | * SJeffery | ...needs breakfast |
16:58 | * drojf | needs icecream |
16:58 | drojf | mveron: what's in the dishwasher tonight? :) |
16:58 | * cait | needs dinner and icecream |
17:00 | * mtompset | jumps with joy. |
17:01 | mtompset | It works! It works! Woo hoo! |
17:01 | Unfortunately, that means I need to redo the patch I just submitted. ARG! | |
17:01 | But that's not a now problem. | |
17:02 | * mtompset | waves bye. |
17:06 | Shane-s | okay just remembered, but forgot how/where, I changed the Zebra Index delay. Where/how do I do that again? I think it was like 4 hours, I want it to be every hour |
17:06 | jcamins | crontab -e |
17:06 | Shane-s: why every hour? | |
17:06 | Most places do five minutes or so. | |
17:07 | Shane-s | we maybe add 5-10 book and I want there to appear ASAP |
17:07 | oh yeah 5 works | |
17:08 | i thought it was longer then that by default through, I remember waiting a long time for my imported books to appear before I modified that. | |
17:08 | jcamins | 10 minutes by default. |
17:08 | Shane-s | oh really...I'll go eat lunch |
17:08 | See if they are in there | |
17:08 | I swore it was forever on my 3.6 test system | |
17:09 | I made it ever minute on that thing | |
17:09 | jcamins: thanks, I will check it out after my pop-tart and soda :) | |
17:26 | JoeLib001 joined #koha | |
17:27 | * mveron | is back from dinner. .. |
17:27 | kyleh joined #koha | |
17:27 | tcohen | mtompset: Bug 8519 |
17:27 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8519 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Make koha-index-daemon run on startup |
17:28 | tcohen | maybe my patch will have to wait, so you dontneed to wait fr it |
17:29 | khall joined #koha | |
17:31 | Shane-s | okay so my import put them in the reservoir... not sure how I make them active |
17:34 | jcamins | Go to "manage MARC import" and choose "import." |
17:34 | libsysguy joined #koha | |
17:35 | Shane-s | tree for that? |
17:35 | jcamins | Tools->Manage MARC import. |
17:35 | Right by "Stage MARC for import," which you used to import the records. | |
17:37 | libsysguy joined #koha | |
17:37 | Shane-s | Manage staged MARC records ? All I see other then the import one |
17:37 | 3.8 if it matters | |
17:37 | jcamins | Shane-s: how did you import your records? |
17:38 | Shane-s | with the Stage MARC for Import using the browse button |
17:38 | jcamins | Yes, so you go through the process. |
17:38 | Then you click "Manage staged MARC records" on the Tools screen. | |
17:39 | Then you view the batch you staged, and import it. | |
17:39 | documentation? | |
17:39 | wahanui | i think documentation is at http://koha-community.org/documentation/ |
17:39 | jcamins | ^^ if you look at the chapter on tools, there should be screenshots |
17:39 | Shane-s | I just have a "clean" button I don't remebering that from 3.6 |
17:39 | jcamins | Don't click that. |
17:39 | It's always been there. | |
17:39 | Click on the link to view the batch. | |
17:40 | Shane-s | oh I couldn't tell it was a link....lcd issue |
17:40 | the angle made it black | |
17:41 | got it now thanks! | |
17:41 | jcamins | You're welcome. |
17:42 | drojf | jcamins: when i use export database, i get a file with filesize 0. any idea why that may be the case? i can confirm that bug 8437 makes me see the file with plack, but it's 0 both with and without plack |
17:42 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8437 major, P2, ---, jcamins, Needs Signoff , Plack and database backup |
17:43 | jcamins | drojf: the patch doesn't work? :P |
17:43 | drojf | heh. since it must have worked for others (the non plack version) i doubt that |
17:44 | jcamins | I meant for 8437. |
17:44 | There should be a message in the log if there was any sort of problem. | |
17:47 | drojf | oh. yes there is. [Mon Jul 30 19:39:05 2012] [error] [client 192.168.1.11] [Mon Jul 30 19:39:05 2012] export.pl: A suspicious attempt was made to download the db at 'backupd.sql.gz' by someone at 192.168.1.11, referer: http://192.168.1.238:8080/cgi-[…]a/tools/export.pl |
17:47 | wolf joined #koha | |
17:47 | cait | oh |
17:48 | fast wolf | |
17:48 | drojf | heh |
17:48 | cait | drojf: that looks like you are a villain |
17:48 | drojf | :( |
17:48 | jcamins | drojf: did you configure backupdir in your koha-conf.xml? |
17:49 | drojf | yes, i would not see a file to download otherwise i guess? |
17:49 | jcamins | True. |
17:50 | I'll just confirm that the patch works for me. | |
17:51 | drojf | i should go back one patch. i think i did not try it without the plack patch, i just assumed that would work and confirmed it did not work with plack |
17:54 | i have the same just with bug 8268 | |
17:54 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8268 critical, P2, ---, jcamins, Passed QA , Koha should offer way to backup entire db |
17:54 | libsysguy joined #koha | |
17:54 | jcamins | Hm. |
17:54 | ogg joined #koha | |
17:55 | drojf | hm but the file is not owned by my koha user |
17:55 | jcamins | So as far as you can tell, it's broken on master? |
17:55 | ogg left #koha | |
17:55 | jcamins | That didn't take long. |
17:57 | bbw joined #koha | |
17:59 | drojf | jcamins: there is only a "signed followup" attached to bug 8268 and everything else is obsoleted. maybe i'm missing something? |
17:59 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8268 critical, P2, ---, jcamins, Passed QA , Koha should offer way to backup entire db |
18:00 | jcamins | drojf: the feature is already in master. |
18:00 | drojf | ah. i did not know that |
18:01 | jcamins | Has been for a while. |
18:01 | And it worked initially. | |
18:01 | drojf | hm maybe i broke something myself, at least it is not workin for me atm |
18:01 | jcamins | I'm testing it, and I'm having issues, too. |
18:02 | tcohen | koha-index is broken for multiple-site single koha user setup! |
18:02 | jcamins | tcohen: yes, that's why I wrote my daemon. |
18:02 | tcohen | :'-( |
18:03 | jcamins | tcohen: https://github.com/jcamins/tamilcontribs |
18:03 | That's an old version, though. | |
18:03 | tcohen | i'll hook it so it uses mktemp to create a new dir |
18:03 | will check your code after that | |
18:04 | drojf | annoying music from one floor up, i better go shopping |
18:07 | drojf joined #koha | |
18:08 | jcamins | drojf: found the problem. |
18:10 | drojf | jcamins: what is it? |
18:10 | wahanui | rumour has it it is not |
18:10 | drojf | lol |
18:11 | jcamins | drojf: a misbehaving regular expression. |
18:12 | I just attached a patch that fixes it to bug 8268. | |
18:12 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8268 critical, P2, ---, jcamins, Passed QA , Koha should offer way to backup entire db |
18:12 | drojf | bad regexp, no cookie |
18:12 | jcamins | Waiting for signoff. :) |
18:13 | drojf | cool, i'll test it when i'm back |
18:18 | oleonard | What's with this error? http://screencast.com/t/h5V5fi2pce |
18:21 | cait | uh |
18:21 | it looks similar than the "checkout in the past" one | |
18:21 | similar to? | |
18:22 | oleonard | Similar to... I think it's the same. But I didn't submit a date with it |
18:22 | Just a regular scan | |
18:26 | cait | hm |
18:27 | and there is a valid circ rule? | |
18:27 | perhaps it asks ... for something? | |
18:27 | I have no idea really :) | |
18:29 | chris_n` joined #koha | |
18:36 | oleonard | Interesting... turns out it has an item type for which I specified a loan period in hours |
18:37 | That can't be the whole problem though or no one could be doing hourly loans | |
18:40 | * cait | nods |
18:41 | oleonard | variable "today" evaluating as "2012-07-30T14:38:00" variable "duedate" evaluating as "2012-07-30T10:00:00" |
18:43 | cait | ok, now you lost me :) |
18:45 | oleonard | C4/Circulation.pm compares $today (current date and time) with $duedate and finds that $duedate falls before $today, hence the error |
18:45 | ...but why is $duedate coming through as ~4hrs ago? | |
18:46 | Loan period for the item type is set to 2 hours | |
18:46 | cait | sounds like a new serious bug :( |
18:47 | jcamins | oleonard: is duedate set with javascript? |
18:47 | oleonard | I think this shows we all need to be sure to have at least 1 circ rule for an hourly loan when testing. |
18:47 | cait | that too |
18:48 | oleonard | jcamins: I was just going to try to find out where duedate comes from, because nothing is getting passed to CanBookBeIssued() in this instance |
18:50 | On the other hand, neither does $duedate appear to be coming through with another item type either | |
18:51 | circulation.pl does not contain a form field for duedate, just duedatespec | |
18:57 | rambutan joined #koha | |
18:59 | oleonard | rambutan: http://www.screencast.com/t/sHYnUPpU |
18:59 | drojf | jcamins: Applying: Bug 8268: improve error checking / error: patch failed: tools/export.pl:345 7 error: tools/export.pl: patch does not apply |
18:59 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8268 critical, P2, ---, jcamins, Needs Signoff , Koha should offer way to backup entire db |
19:00 | bbw_ joined #koha | |
19:02 | Shane-s | so in the labels we have barcode, how do I get the number to print, or is that part of the barcode? Basically I want book data, [||| || |||| |], 12367 |
19:03 | would 952p issue the number is the code word for barcode generates the scanner code? | |
19:04 | oleonard | Can anyone reproduce the error I'm seeing with an hourly loan? |
19:04 | I've stepped back through a few random commits over the last two months and get the same error, so it wasn't something recent | |
19:05 | ...assuming it's not an error in my configuration. | |
19:05 | cait | i can try, but it might take a while |
19:09 | wizzyrea | oleonard what's the error? |
19:09 | Shane-s | okay I have a ton of errors in my log, 15,910 lines, there is not much detail just cataloging , action ADD then object is basically incremental. 1,1;2,2;3,3 where can I find a more detailed event? |
19:10 | oleonard | wizzyrea: This error when checking out something with an hourly loan rule http://screencast.com/t/h5V5fi2pce |
19:10 | Koha thinks it's an invalid date because the duedate Koha calculates is actually 4 hours ago rather than 2 hours from now | |
19:10 | wizzyrea | server time messed up maybe? |
19:10 | oleonard | Nope |
19:10 | jcamins | Shane-s: that's what's recorded in action logs. There isn't any more detail. It tells you what the record looked like prior to the change, I believe. |
19:11 | cait | oleonard: just a circ rule for 4 hours? |
19:11 | or 2? | |
19:11 | wahanui | 2 is pretty awesome |
19:11 | wizzyrea | mysql server time off? |
19:11 | oleonard | circ rule is for 2 hours |
19:11 | jcamins | 3? |
19:11 | 4? | |
19:11 | wahanui | 4 is the attribute in bib1.att for title |
19:11 | jcamins | Hehe. |
19:11 | oleonard | How would I check the mysql server time? |
19:12 | Shane-s | okay, well I went there because adding a book to the label creator errored, I guess I will search again without cataloging |
19:12 | cait | hm i think it would be the same as the server time |
19:12 | with date? | |
19:12 | wizzyrea | wouldn't have to be |
19:12 | cait | oh ok |
19:12 | wizzyrea | I don't think. |
19:13 | can you do a select now(); from the command line | |
19:13 | jcamins | Shane-s: oh, you're looking for error logs? |
19:13 | wizzyrea | from the mysql command line |
19:13 | I mean | |
19:13 | jcamins | Apache saves those. |
19:13 | wizzyrea | or possibly even from the mysql reports |
19:13 | cait | oh good idea |
19:13 | Shane-s | okay, log is emtpy outside of cataloging...so how can I track down why the label "Add Item" search is failing when I find a book, check the box, and click the add item button and I get the yellow error box |
19:13 | oleonard | mysql gives the correct time |
19:13 | wizzyrea | k, sorry just checking the obvious things :) |
19:13 | cait | configuring rules now :) |
19:14 | jcamins | logs? |
19:14 | wahanui | it has been said that logs is http://irc.koha-community.org/irclog/koha/ |
19:14 | jcamins | No. |
19:14 | Server logs? | |
19:14 | Apache logs? | |
19:14 | wahanui | Apache logs are only showing chobbs's import job |
19:14 | jcamins | Error log? |
19:14 | Shane-s | jcamins: not sure if that is where I should look or not |
19:14 | wizzyrea | so the rule is for 2 hours in the future, but the date assigned is 4 hours in the pst |
19:14 | past* | |
19:14 | jcamins | Well, it'll be at /var/log/apache2/koha-error.log, most likely. |
19:15 | * cait | catalogs |
19:15 | jcamins | Or something like that. |
19:15 | wizzyrea | oleonard: can you screencap your rule? |
19:16 | cait | oleonard: it happens for me too |
19:16 | my rule is: default default 2 hours | |
19:16 | oleonard | http://screencast.com/t/YlybbvQxMGpT |
19:16 | cait | in a fresh sample base |
19:16 | with all english sample data, only added the rule and record and an item | |
19:16 | Shane-s | jcamins: hmm...checked the error.log it just has 3 lines from the apache restart on Sunday |
19:17 | oleonard | Actually the due date isn't 4 hours in the past, it's exactly 10AM today. |
19:17 | every time | |
19:17 | wizzyrea | whoa |
19:17 | Shane-s | nothing for today...no koha-error.log, I will run updatedb |
19:17 | cait | whoa? |
19:17 | wizzyrea | exactly 10am sounds like a math problem. |
19:17 | jcamins | Shane-s: what error did you get? |
19:17 | wizzyrea | what about a 3 hour loan? |
19:17 | jcamins | updatedatabase will have nothing to do with it. |
19:18 | oleonard | Math is hard!</barbie_voice> |
19:18 | cait | wizzyrea: I will check |
19:18 | there are some wanrs in the logs | |
19:18 | [Mon Jul 30 21:16:14 2012] [error] [client 127.0.0.1] [Mon Jul 30 21:16:14 2012] circulation.pl: Reference found where even-sized list expected at /home/katrin/kohaclone/circ/circulation.pl line 97., referer: http://localhost:8080/cgi-bin/[…]borrowernumber=19 | |
19:18 | [Mon Jul 30 21:16:14 2012] [error] [client 127.0.0.1] [Mon Jul 30 21:16:14 2012] circulation.pl: Use of uninitialized value $findborrower in substitution (s///) at /home/katrin/kohaclone/circ/circulation.pl line 101., referer: http://localhost:8080/cgi-bin/[…]borrowernumber=19 | |
19:18 | wizzyrea | is there something about multiples of 2 hours? |
19:18 | Shane-s | jcamins: one second I have to go back into the label maker |
19:18 | jcamins | Shane-s: I should point out that I have never used the label tool, and probably never will |
19:19 | cait | wow |
19:19 | 5 works | |
19:19 | Shane-s | jcamins: WARNING: An error was encountered and item(s) not added to batch 1. |
19:19 | wizzyrea | see that "reference found where even-sized list expected |
19:19 | oleonard | Not for me cait. duedate: 2012-07-30T10:00:00 with a 5-hour loan period |
19:19 | cait | crazy |
19:19 | perhaps it's something to do with the time? | |
19:19 | Shane-s | I have to re-make all my barcodes, only 1 out of 3 label types we have work |
19:19 | oleonard | Oh wait, no |
19:19 | cait | 5 hours for me is tomorrow already |
19:20 | 07/31/2012 00:00 < looks wrong? | |
19:20 | what should it be? | |
19:20 | Shane-s | jcamins: that error isn't clueing me in as to a Koha, DB, Apache, or other issue |
19:20 | * oleonard | can't edit a circ rule |
19:20 | jcamins | Shane-s: are you able to add those same items to the other types of labels? |
19:20 | wizzyrea | well, it would have to be 00:20 for a rightful 5 hours |
19:20 | rambutan | oleonard: used to eat them frequently in Thailand |
19:21 | oleonard | rambutan: That's where I took that photo |
19:21 | Shane-s | jcamins: I can try..one sec. |
19:21 | rambutan | hummm |
19:21 | jcamins | Shane-s: however, if you got that error message, it has to do with the data you are giving to Koha. |
19:21 | oleonard | ...now I can't even save a new circ rule |
19:21 | jcamins | Any error further back would have resulted in a much more dramatic error. |
19:22 | * oleonard | grumbles |
19:22 | wizzyrea | O.O |
19:22 | Shane-s | jcamins: nope, when you do a batch, you have to add item before the label/profile/layout options...so I am stuck |
19:22 | cait | oleonard: hm that works for me :( |
19:23 | wizzyrea | oleonard: got anything in your logs? |
19:23 | * oleonard | has a mixed-up db from bug testing |
19:23 | jcamins | Shane-s: but 1 of the three types of labels work? |
19:25 | Shane-s | jcamins: nope...just tried typing the barcode in, I know it is 0061184 as I looked it, typed it in the box, hit add item, and it errors. So I can not even try a label |
19:25 | cait | oleonard: mine is brand new and I can reproduce |
19:25 | oleonard: I don't think it's you | |
19:25 | it might have something to do with crossing dates? | |
19:25 | Shane-s | I just have the template/layouts/profiles Koha's install put in there, but no way to see if they work, should I make my own? |
19:26 | oleonard | Oh, no, it's not my db after all. |
19:26 | jcamins | Shane-s: if you can't use the defaults, you won't be able to get a custom one working. |
19:26 | I have no further advice, sorry. | |
19:26 | As I said, I don't use the label tool. | |
19:26 | cait | I have it with 1 and 2 hours circ rules now |
19:28 | Shane-S joined #koha | |
19:28 | wizzyrea | well I can't get it to do anything but the default rule |
19:29 | oleonard | wizzyrea: Are you not able to add a rule? |
19:29 | wizzyrea | I can add a rule |
19:29 | but it's always picking the All:All default rule, i.e. it's circing for one day | |
19:29 | as per my default rule | |
19:29 | if I do say, All:Reference, and try to circ a reference book | |
19:29 | it still does one day | |
19:29 | let me double check that | |
19:30 | oleonard | DBD::mysql::st execute failed: Unknown column 'overduefinescap' in 'field list' at /home/oleonard/kohaclone/admin/smart-rules.pl line 133. |
19:31 | I guess I missed a db update? | |
19:31 | wizzyrea | [Mon Jul 30 04:51:29 2012] [error] [client 192.168.1.137] [Mon Jul 30 04:51:29 2012] smart-rules.pl: Use of uninitialized value in string ne at /home/liz/kohaclone/admin/smart-rules.pl line 388., referer: http://koha-staff.lan.nekls.or[…]rules.pl?branch=* |
19:31 | Shane-S | okay I am f'ed at this point...if I enter 61184 and click add item, no error, but it doesn't add the item. If I type 0061184 it errors, and still doesn't add the item....How else can I get barcodes for all our books? |
19:31 | wizzyrea | what is the actual barcode on the itme? |
19:31 | item/ | |
19:32 | Shane-S | in Koha 0061184, on its old label 61184 |
19:33 | wizzyrea | it's not a bug, mine does it just fine |
19:33 | is there a space on the end of the barcode possibly? | |
19:33 | or on the front? | |
19:33 | Shane-S | no I am typing it by hand |
19:33 | wizzyrea | no i mean, in your data. |
19:33 | Shane-S | or you mean in the DB? |
19:34 | nothing ok the Koha Catalog screen with the item type and details, let me try direct in MySQL | |
19:35 | wizzyrea | oleonard: mine sets it for 10am too |
19:36 | finally got my rules ironed out | |
19:36 | but it didn't get mad about the due date in the past | |
19:36 | * oleonard | too, db updated |
19:36 | oleonard | wizzyrea: You mean when you specified a due date? |
19:36 | wizzyrea | no, when I checked it out |
19:36 | I didn't specify, it didn't complain | |
19:37 | cait | so we confirm it's a bug? |
19:37 | wizzyrea | it just set the due date in the past |
19:37 | yes, I think we can definitely call it an evil bug | |
19:37 | oleonard | Is that controlled by a syspref? |
19:37 | * wizzyrea | guesses so |
19:37 | cait | hm? |
19:37 | wizzyrea | but not sure which |
19:37 | cait | the hourly? |
19:37 | or the due date in the past? | |
19:37 | * cait | is confused |
19:37 | cait | bit tired too |
19:37 | oleonard | Whether to allow you to set a due date in the past |
19:37 | cait | no |
19:38 | not a syspref | |
19:38 | it just is | |
19:38 | * wizzyrea | switches it to US date format |
19:38 | wizzyrea | maybe that's why |
19:38 | oleonard | From what wizzyrea? |
19:38 | cait | but is used to work... and we didn't set one in the past... so this is all very weird |
19:38 | wizzyrea | from dd/mm/yyyy |
19:39 | to mm/dd/yyyy | |
19:39 | cait | hm |
19:39 | happens for every frmat for me | |
19:39 | wizzyrea | well mine is mad about fines too just a sec |
19:40 | which is probably another bug - | |
19:40 | i'm over the limit and it doesn't prompt for a proper due date | |
19:40 | oleonard | Yeah, date format doesn't change the outcome for me (with no fines) |
19:41 | wizzyrea | no, date format doesn't change it, and it still doesn't prompt me for a proper due date. |
19:41 | 7/30/2012 10:00 | |
19:42 | cait | it doesn't happen when the hours push me after midnight |
19:42 | so it happens with 1 and 2 hours for me right now | |
19:42 | wizzyrea | does it stick at 00:00 |
19:42 | or does it compute properly | |
19:42 | and it's whole hours not partial hours | |
19:43 | cait | when past midnight it was 0:00 |
19:43 | whih seems wrong | |
19:43 | but i haven't tested hourly in the past | |
19:43 | wizzyrea | so if you check something out at 12:20 and it should be 2 hours, it is due at 1500? |
19:43 | cait | I am not totally sure what it should do :( |
19:43 | Shane-S | wizzyrea: no spacing in MYSQL it is 0061184 |
19:43 | wizzyrea | ping libsysguy |
19:43 | cait | hm no it should be 15:20 I think |
19:43 | wizzyrea | right, that's hat I thought |
19:43 | so it's wrong past midnight | |
19:43 | too | |
19:43 | jcamins | wizzyrea: no, it should be due at 14:20. |
19:44 | cait | ok, so we agree :) |
19:44 | jcamins | I'm helping! |
19:44 | cait | hehe |
19:44 | wizzyrea | hehe |
19:44 | * cait | hands jcamins a cookie |
19:44 | * Shane-S | ponders if restarting the server might fix it |
19:44 | jcamins | Shane-S: no. |
19:44 | wizzyrea | um, if anything I'd clear your cache and cookies |
19:45 | jcamins | ^^ that'd be more likely to help. |
19:45 | wizzyrea | and re-login |
19:45 | Shane-S | okay be back.... |
19:45 | wizzyrea | you may have hit refresh or back and bonked your session. |
19:45 | wow, that sounds dirty. | |
19:45 | * wizzyrea | waits for the kiwis to see that. |
19:45 | wizzyrea | they will laugh a lot. |
19:46 | cait | heh |
19:47 | libsysguy joined #koha | |
19:47 | cait | libsysguy: be careful - we are testing hourly |
19:47 | wizzyrea | and it seems QUITE borked. |
19:47 | cait | yep |
19:47 | wizzyrea | hours greater than 1 uh, yea no work. |
19:47 | well did we test 1? | |
19:48 | cait | i did |
19:48 | wizzyrea | did it work? |
19:48 | cait | I get the owen screenshot |
19:48 | Shane-S joined #koha | |
19:48 | wizzyrea | 10am? |
19:48 | cait | will recheck |
19:48 | wizzyrea | HAHAHAHAHAHAHA |
19:48 | oleonard | Smart guy |
19:48 | libsysguy joined #koha | |
19:48 | cait | 0:00 |
19:49 | wizzyrea | weird. |
19:49 | Shane-S | wizzyrea, jcamins : same thing... even a working barcode number 55553 in the text area box, click Add Item button, no error but nothing happens, try 0061184 and it errors... |
19:49 | cait | I get the wird confirmation |
19:49 | and then it sets 0:00 today - which is in the past | |
19:49 | so it's overdue immediately | |
19:49 | Shane-S | could it be the biblio import? My install is from the packages if that matters |
19:49 | wizzyrea | oh there was a thing |
19:50 | where it was setting due dates at 00:00 instead of 23:59 | |
19:50 | maybe that's what we're seeing | |
19:50 | I think there's a patch for it | |
19:50 | but not sure it's gotten through qa yet? | |
19:51 | cait | not sure |
19:51 | circ is not my expert area :( | |
19:52 | wizzyrea | yea let me look |
19:53 | mveron | Good night #koha |
19:53 | wizzyrea | bug 8165 |
19:53 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8165 blocker, P1 - high, ---, kyle.m.hall, RESOLVED DUPLICATE, due date of 00:00 instead of 23:59 |
19:54 | oleonard | 8182 |
19:54 | Bug 8182 | |
19:54 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8182 major, P1 - high, ---, gmcharlt, Pushed to Stable , Problem with overdue fine calculations after upgrade |
19:56 | Shane-S | wizzyrea: maybe I have a deeper issue, if you enter a barcdode in the textarea of label creator "New Batch" what does it do, because in Internet Explorer add item(s) opens the search box |
19:57 | wizzyrea | oh, IE |
19:57 | did you try firefox? | |
19:58 | jcamins | Shane-S: oh, you're using IE? I should've asked. |
19:58 | Chances are good it Just Won't Work. | |
20:05 | Shane-S | jcamins: no FireFox but wanted to try IE to ensure FFX wasn't the issue |
20:05 | wizzyrea | can you give us a screen capture of your process, like a mini movie |
20:05 | jcamins | Ah. Well, nothing will ever work in IE if it doesn't in FF. |
20:05 | Shane-S | FireFox clears the number when I hit "Add Item(s)" |
20:06 | wizzyrea | well here, I will show you what it looks like on mine |
20:06 | Shane-S | I didn't know if I am supposed to hit Add Item(s) or if its an ajax type smart text area |
20:07 | wizzyrea | http://screencast.com/t/xNrmo2WFrn |
20:07 | you click add items | |
20:08 | and that is master. | |
20:08 | not any particular version | |
20:08 | Shane-S | I don't have all those buttons...I will see if I can do that |
20:08 | wizzyrea | if you don't have anything in your queue, I think there is only add items |
20:08 | oleonard | As far as I can tell, the loan period is being calculated correctly at least up until we get into the Koha::Calendar section of CalcDateDue |
20:08 | wizzyrea | well and there's drama in calendar too |
20:09 | * oleonard | hasn't been following that drama |
20:09 | wizzyrea | bug 8110 |
20:09 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8110 blocker, P1 - high, ---, kyle.m.hall, Signed Off , Fines accruing on closed days |
20:09 | wizzyrea | bug 8418 |
20:09 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8418 critical, P5 - low, ---, koha-bugs, Patch doesn't apply , Koha::Calendar is_holiday ignores all user data |
20:10 | * Shane-S | is installing Jing |
20:10 | jcamins | libsysguy was looking at Koha::Calendar, trying to figure out wth its problem was, I think. |
20:10 | wizzyrea | bug 6398 |
20:10 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=6398 normal, P5 - low, ---, dpavlin, ASSIGNED , Holidays cause date due to be improperly calculated |
20:10 | * libsysguy | perks up |
20:10 | wizzyrea | oh NOW you perk up |
20:10 | ;) | |
20:10 | libsysguy | sorry you have to say |
20:10 | libsysguy? | |
20:10 | wahanui | well, libsysguy is Koha's hottest developer or partying with swedes on his deck or koha's youngest developer |
20:11 | libsysguy | and yes I am re-working all of hourly loans |
20:11 | wizzyrea | all of it? yikes. |
20:11 | libsysguy | but it is a cluster**** |
20:11 | wizzyrea | hah. |
20:11 | oy. | |
20:11 | * oleonard | accuses libsysguy of hard-coding a 10AM due date in hourly loans |
20:11 | libsysguy | well I told jcamins…but it was storing all of the effing weekdays in an array |
20:11 | * libsysguy | ducks |
20:12 | libsysguy | then pushing that array to the db |
20:12 | bug 8133 is what started my quest | |
20:12 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8133 enhancement, P5 - low, ---, elliott, ASSIGNED , hourly loans doesn't know when library closed |
20:13 | libsysguy | now im just pissed at the whole Koha::Calendar file |
20:13 | * libsysguy | is bitter |
20:13 | * oleonard | picks this as a good time to disappear |
20:13 | kathryn joined #koha | |
20:13 | libsysguy | heh |
20:13 | * oleonard | waves goodbye |
20:13 | libsysguy | later oleonard |
20:13 | * libsysguy | gets off soap box |
20:18 | Shane-S | wizzyrea: if it helps.. http://screencast.com/t/oISDk6bPEx |
20:18 | wizzyrea | it always helps ;) |
20:18 | perhaps because you are logged in as the super super librarian | |
20:18 | log in as a user that is not the DB user | |
20:18 | Shane-S | really...that causes issue? |
20:18 | wizzyrea | yes |
20:18 | it | |
20:19 | keeps the batches based on branch | |
20:19 | and the superlibrarian has no branch set | |
20:19 | Shane-S | oh |
20:19 | wizzyrea | and never has a branch set. |
20:19 | and never will. | |
20:19 | Shane-S | okay I will make a user tonight when I remote in |
20:19 | wizzyrea | you can do that right now |
20:19 | create a patron | |
20:19 | Shane-S | I will but they are kicking me out |
20:19 | wizzyrea | ah |
20:19 | Shane-S | custodians want to lock up |
20:19 | wizzyrea | i see |
20:19 | but yea | |
20:19 | that should fix your issue | |
20:20 | Shane-S | okay, thanks! never thought of that |
20:20 | wizzyrea | see, a simple picture |
20:20 | :) | |
20:20 | jing is awesome ;) | |
20:20 | Shane-S | yeah pretty painless too :P |
20:20 | wizzyrea | really, you don't want to "do stuff" with the db user |
20:20 | Shane-S | okay probably be back on tomorrow |
20:20 | wizzyrea | you use it for db updates and that's it |
20:20 | create a superlibrarian? | |
20:20 | i thought wahanui had something in his brain about this | |
20:21 | cait left #koha | |
20:21 | Shane-S | I was just trying to get it done, I didn't feel I needed an account. The librrarian will though |
20:21 | wizzyrea | you do, definitely, need an account. |
20:21 | and it's no deal to have one | |
20:21 | Shane-S | thanks for the help as always have a good day/night |
20:21 | wizzyrea | later :) |
20:38 | jcamins | Remind me why making the XSLT sysprefs into text fields was a good idea? |
20:38 | libsysguy | it wasn't |
20:38 | reminder succeeded | |
20:38 | :) | |
20:38 | jcamins | Ah. |
20:43 | libsysguy | on a scale of 1 − 10, 10 being the most important thing in Koha, how important is it to differentiate between what type of holiday your closure is. Ex: Weekly, Yearly, etc... |
20:49 | rangi | 1 |
20:49 | It's pure a ui thing | |
20:50 | libsysguy | ok awesome…i can make it happen without that stuff easily |
20:50 | I have to jump through hoops to make it pretty and color coded | |
20:50 | rangi | Koha::Holiday |
20:51 | libsysguy | is that where you want it? |
20:51 | rangi | Then we can retire c4::calendar |
20:51 | libsysguy | I was just putting it in Koha::Calendar |
20:51 | rangi | Hmm I like that it's just getters |
20:51 | libsysguy | I was porting over the stuff from C4::Calendar to Koha::Calendar |
20:51 | rangi | Yeah i wouldn't |
20:51 | libsysguy | okay |
20:52 | I have been calling holidays closures | |
20:52 | since it doesn't really have to be a holiday to be closed | |
20:52 | rangi | Check the bugs list Colin had a great comment about it |
20:52 | libsysguy | the hourly bug? |
20:52 | rangi | Bug 7351 |
20:52 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7351 enhancement, P3, ---, christophe.croullebois, Needs Signoff , ability to edit a range of holidays |
20:53 | rangi | Last comment there |
20:53 | libsysguy | haha that is exactly what I was doing |
20:53 | poop | |
20:54 | rangi | Basically we don't want to pollute koha::calendar |
20:54 | It's solid and well tested now | |
20:54 | Ie unit tested | |
20:54 | libsysguy | ok Koha::Closure.pm it is |
20:55 | rangi | So a new module where we write tests first would stop us just creating new mess :-) |
20:55 | libsysguy | hehe |
20:55 | where are the unit test for Koha::Calendar? | |
20:56 | jcamins | Koha_Calendar.t... somewhere? |
20:57 | rangi | t/Calendar.t |
20:57 | wizzyrea | (unless it's db_dependent_ |
20:57 | or do we not write db dependent ones anymore | |
20:57 | rangi | It's not :-) |
20:57 | jcamins | wizzyrea: we do, though we're trying to stop. |
20:57 | rangi | Check it out it's cool |
20:57 | libsysguy | heh that can't be it |
20:58 | rangi | Yes it is |
20:58 | libsysguy | 0_0 |
20:58 | use_ok('C4::Calendar') | |
20:58 | rangi | Then later |
20:58 | libsysguy | is all that is in there |
20:58 | rangi | Hmm u on master? |
20:58 | libsysguy | as of last week |
20:59 | rangi | Look at it in 3.8.x |
20:59 | Or latest master | |
20:59 | Has 21 tests | |
20:59 | And even does neat mock thingd | |
21:00 | libsysguy | where the hell is all that in mine |
21:00 | rangi | Also peep the patch from Bart on bug 5327 |
21:00 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=5327 major, P3, ---, paul.poulain, Needs Signoff , Unit tests required for all C4 modules |
21:00 | rangi | Old master? |
21:00 | libsysguy | ill update |
21:01 | rangi | That patch shows u how to mock a db connection |
21:03 | I will buy u 5 beers in Reno | |
21:03 | libsysguy | haha |
21:03 | rangi | If you do unit tests |
21:03 | libsysguy | unit tests it is |
21:04 | ahh there they all are | |
21:04 | eythian | libsysguy: he didn't mention that they'll be cheap beers ;) |
21:04 | jcamins | eythian: after the fourth, he won't be able to tell that the fifth is cheap, too. ;) |
21:05 | libsysguy | heh |
21:05 | eythian | good point well made :) |
21:05 | libsysguy | beer is beer |
21:05 | eythian | libsysguy: heathen |
21:05 | libsysguy | fine I am still in college |
21:05 | for the next 2 weels | |
21:05 | weeks | |
21:05 | im allowed to drink cheap beer till then :p | |
21:05 | gmcharlt | heh |
21:06 | eythian | College is a fountain of knowledge, and the students go there to drink, eh? :) |
21:06 | jcamins | eythian: trying to come to a deeper understanding of the difference between cheap and non-cheap beer? |
21:06 | libsysguy | we are learning how to properly control ourselves under the influence |
21:06 | jcamins | Interestingly, almost all my college friends have turned into beer snobs. |
21:06 | eythian | jcamins: it's a natural progression, I think. |
21:06 | libsysguy | haha |
21:07 | i have found my taste have gotten darker with age | |
21:07 | gmcharlt | @quote add <eythian> College is a fountain of knowledge, and the students go there to drink, eh? :) |
21:07 | huginn | gmcharlt: The operation succeeded. Quote #212 added. |
21:09 | * gmcharlt | is still dealing with the consequences of that fact that my first beer (years ago) was a Guiness |
21:09 | gmcharlt | not, perhaps, the best introduction |
21:17 | rangi | Heh |
21:19 | larryb joined #koha | |
21:19 | larryb left #koha | |
21:20 | bbw_ joined #koha | |
21:23 | jcamins | Bug 8525 is ready for sign off if someone wants to play with some eye candy. |
21:23 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8525 enhancement, P5 - low, ---, jcamins, Needs Signoff , Highlight matches on details page |
21:29 | libsysguy | rangi, for writing unit tests without doing work first, do I create the file and stubs? |
21:31 | jcamins | libsysguy: you write the tests first, with the first one being use_ok(). Then, you work your way through writing Koha::Closure, making it pass each successive test. |
21:31 | rangi | I write the test then write the file and sub to pass it |
21:31 | What he said | |
21:31 | libsysguy | ahh ok |
21:31 | jcamins | Oh, and make sure it is object-oriented. |
21:31 | libsysguy | is there any other way |
21:31 | jcamins | (Koha::Closure not the test) |
21:32 | NO! | |
21:32 | libsysguy | heh |
21:32 | jcamins | :) |
21:34 | wizzyrea | it's like, omg, making a plan. |
21:34 | rangi | What was that patch u did recently |
21:35 | jcamins | Me? |
21:35 | wahanui | you are A-Grade developper on Koha willing to rewrite it from top to bottom. Good Luck jcamins |
21:35 | * wizzyrea | giggles |
21:35 | rangi | Yup |
21:35 | Might help to look at | |
21:35 | jcamins | Bug 8209. |
21:35 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8209 enhancement, P5 - low, ---, jcamins, Needs Signoff , "Did you mean?" suggestions based on authorities |
21:35 | rangi | Yeah |
21:35 | Kickarse | |
21:36 | jcamins | Though actually my development process for that was a little harder because I had two tests. |
21:37 | rangi | And DBD::Mock is ur friend |
21:37 | Bug 5327 again | |
21:37 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=5327 major, P3, ---, paul.poulain, Needs Signoff , Unit tests required for all C4 modules |
21:37 | jcamins | Also, I didn't know about DBD::Mock yet when I wrote that, so I was at a huuuuge disadvantage. |
21:37 | rangi | U don't even need tables in the db to test |
21:38 | jcamins | Ooh, tests needing sign off? |
21:38 | :D :D :D :D :D :D :D :D :D :D :D :D :D :D :D (etc.) | |
21:38 | rangi | Needs a follow-up |
21:38 | For the new dependency | |
21:38 | I didn't want to make Bart do that | |
21:39 | But the test is good | |
21:39 | * jcamins | will provide one. |
21:39 | rangi | Yay |
21:39 | Community++ | |
21:39 | Right off to treasury I go | |
21:44 | jcamins | DBD::sqlite2? |
21:44 | Ah, koc. | |
21:49 | wizzyrea | gl at treasury |
21:55 | edveal left #koha | |
21:59 | trea left #koha | |
22:00 | bbw left #koha | |
22:13 | rambutan left #koha | |
22:35 | maximep left #koha | |
23:19 | papa joined #koha | |
23:31 | JesseM left #koha |
← Previous day | Today | Next day → | Search | Index