IRC log for #koha, 2024-01-11

← Previous day | Today | Next day → | Search | Index

All times shown according to UTC.

Time Nick Message
00:10 oleonard joined #koha
03:30 aleisha joined #koha
03:31 aleisha hello everyone, happy new year!
07:04 lmstrand joined #koha
07:21 magnuse \o/
07:37 reiveune joined #koha
07:45 lukeg joined #koha
07:49 cait joined #koha
07:52 lds joined #koha
07:54 cait1 joined #koha
07:55 marcelr joined #koha
07:55 marcelr o/
08:03 cait joined #koha
08:08 marcelr @later tell ashimema could you add a qa stamp on the trivial bug 35389 ?
08:08 huginn` marcelr: The operation succeeded.
08:16 ashimema We have people using rotating collections that also use that report
08:17 But I get the thought process.. just thinking if there's any way to bind on something without needing to yasp
08:20 marcelr there is no new syspref here?
08:21 the point is that this report is only relevant for stock rotation
08:21 at least for now
08:22 Joubu there is no mention of the syspref in this report
08:22 ashimema No, I'm saying it's not only stock rotation
08:22 We have customers using it generally
08:23 marcelr In which case does it make sense then?
08:23 ashimema Rotating collections at least
08:23 marcelr It seems not possible without stock rotation
08:24 it is confusing to show it always when you cannot have data on it
08:24 ashimema I'm fine with hiding it.. just saying it shouldn't be explicitly bound to sr
08:24 As it's not explicitly bound to sr
08:24 marcelr yeah but it is now
08:25 ashimema Did someone change that then recently
08:25 Because I wasnt
08:25 It
08:25 marcelr yeah you added it
08:25 ashimema I added it year ago, and it did not rely on sr only
08:25 Years
08:25 marcelr but it is in reality
08:25 there is no other use
08:26 just show me how to create data without sr
08:29 ashimema Turning on laptop now
08:29 marcelr i did spend some hour on the topic back in nov/dec
08:29 hours
08:30 ashimema it may well have been broken then
08:31 but it certainly was useful for people without SR
08:31 though people keep breaking SR recently too so it doesn't surprise me if that's not working as intended anymore either
08:31 transfers is yet another area where I worked hard to move things to Koha:: and lost the will to continue for lack of support and time
08:32 transfers is generally a bloody mess
08:32 marcelr yes we have too many of those areas
08:32 ashimema yup
08:32 marcelr but i looked for ways to get data without sr
08:32 and i do not know them
08:33 ashimema vague memory was rotating collections then a reserve clashing
08:34 you'd fulfil the reserve transfer first, then use the report to spot why a rotating collection is missing
08:34 mwah.. hide it.. I'll restore it when a customer complains
08:35 marcelr it should be without stock rotation
08:35 ashimema so long as when that happens I can get it through qa fast if that happens
08:35 marcelr it is just one line
08:35 ashimema i know
08:35 * ashimema is tired already today
08:35 marcelr o no
08:37 where is my brain reset button?
08:37 ashimema lol
08:39 marcelr bug 35536 and bug 35548 are still open for testing fans
08:39 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35536 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Improve removal of Koha plugins in unit tests
08:39 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35548 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Move KitchenSink test on its own and control table creation
08:39 marcelr tiny rebase
08:40 ashimema ho.. I thought that first one had made it through already.. sorry, it dropped off my radar
08:41 * ashimema has been working on the transfers tree again the last few days.. I'd love to see bug 35100 move on a bit
08:41 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35100 normal, P5 - low, ---, martin.renvoize, Signed Off , Items assigned to StockRotation do not advance if a reserve is triggered before the initial transfer
08:41 Joubu @later tell tcohen disabled docker_4, bring is back on once the disk space problem is fixed.
08:41 huginn` Joubu: The operation succeeded.
08:42 marcelr ashimema: will have a try on that one tomorrow
08:42 krimsonkharne[m] good morning #koha
08:43 Joubu @later tell tcohen s/bring is/bring it
08:43 huginn` Joubu: The operation succeeded.
08:43 ashimema it didn't end up with the best description or test plan unfortunately.. I should really have revisited that after all the work it ended up entailing
08:43 cait I planned on an RM day, but I have network issues - I hope it can be fixed soon
08:43 ashimema but thanks.. I'll try to improve the description today 🙂
08:44 marcelr i am not really in stock rotation stuff, but will take dive ;)
08:44 ashimema it's more general transfers fixes than SR in the end
08:45 cait bad timing
08:45 ashimema what I really want to do is get rid of ModItemTransfer
08:50 marcelr Joubu i got stuck on bug 35341 in the flatpickr stuff; could you have a look on how to proceed there ?
08:50 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35341 major, P5 - low, ---, m.de.rooy, Failed QA , Circulation rule dates are being overwritten
08:50 marcelr i need to remove the duplicated cross signs for removing a date
08:50 Joubu Biblio.CanBook(biblio_object_id)
08:50 can a biblio book a biblio?
08:51 marcelr hmm
08:51 ashimema a biblio be be booked
08:51 Joubu marcelr: I've done that already, somewhere
08:51 ashimema you 'can book a biblio'
08:51 cait is_bookable?
08:51 I see waht you mean Joubu
08:51 Patron.CanBook
08:52 marcelr Joubu any idea where somewhere is more specific? i have grepped for flatpickr at the time
08:52 cait Biblio.CanBeBooked
08:52 and shouldn't it be snake case anyway?
08:52 ashimema Biblio.CanArticleRequest
08:52 Joubu why is this a TT plugin? We are supposed to have the biblio object... $biblio->can_be_booked or something
08:52 that's confusing
08:52 anyway
08:52 :q!
08:52 :D
08:52 ashimema if we're arguing over semantics.. can a biblio request an article 😜
08:52 cait yeah that's confusing too :)
08:52 agreed
08:52 but overall... why do we have all these not in snake case?
08:53 marcelr not anyone loves snakes?
08:53 cait it's in the coding guidelines even somehwere
08:53 ashimema template plugins have always been this case as far as I'm aware
08:53 cait for the Koha namespace
08:53 ashimema I just followed the existing pattern
08:53 Joubu to keep consistency under 50%
08:54 ashimema as for why it's a template plugin
08:54 I think it's becuase we're still not always consistently passing the biblio object back in all controllers
08:54 and it's use in an include
08:54 from memory the is_bookable method does exist on the biblio object already
08:54 too
08:54 which is consistent
08:54 anyway
08:55 create a bug for it and I'll write a patch
08:55 I'm in bookings mode again imminently anyway
08:55 Joubu Biblio.BookingsCount
08:56 we should stop using TT plugins for everything...
08:56 ashimema happy to
08:57 Joubu so, trying to see the "bookings" link on a detail page
08:57 it's displayed if
08:57 Biblio.BookingsCount
08:58 this is calling $biblio->bookable_items->count
08:58 it's searching { bookable => 1 }
08:58 so now, how do I set bookable on an item? :D
08:58 marcelr Joubu comment22 on 35341 is about the fact that we call onReady too often which is the cause of double crosses; did you see it ?
08:59 Joubu marcelr: I will have a look after this "bookings" patch
08:59 marcelr ok thx
09:00 ashimema items tab from a biblio
09:00 there's a 'Bookable' option under the 'Priority' heading
09:00 update it there
09:00 it also needs tying in to general item edit
09:01 but asking for feedback on mapping didn't get much response at the time and Nick was happy with that being a follow-up once we had more idea how it should work on that front
09:01 which bug are you reviewing Joubu?
09:05 Joubu 35469
09:05 bug 35469
09:05 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35469 normal, P5 - low, ---, martin.renvoize, Signed Off , Cannot create bookings without circulation permissions
09:05 Joubu this is really confusing
09:06 ashimema thanks for looking
09:09 Joubu ashimema: I cannot set a date for "Period" in the modal
09:09 cait you need to double lcick
09:09 i reported that
09:09 ashimema interesting
09:09 Joubu I pick a date, it fills in flatpickr input, but when I focus out it empties the input
09:09 cait click again
09:10 it's super annoying
09:10 ashimema pick two dates
09:10 Joubu ho, double click on the date
09:10 ashimema it's a period
09:10 not a single date
09:10 Joubu ha, a period
09:10 sorry indde
09:10 cait ?
09:10 How is it a period?
09:10 we onyl have a single date field?
09:10 ashimema your booking the item for a period of time
09:10 Joubu https://snipboard.io/9rs0CK.jpg
09:10 cait i only ever booked them for one day because I didn't realize
09:11 we shoudl show the end date on the form
09:11 ok
09:11 maybe a hint
09:11 it's the first use of this in the Koha GUI
09:11 ashimema for a bookings system.. this it pretty much the norm
09:11 but I can happily add a hint
09:11 cait yeah, and I have booked things before, but I realyl didn't realize
09:11 and I know caroline or someone else was asking about it to
09:12 Joubu there is no "ok" message when a booking is placed from the modal, is that expected?
09:12 ashimema I'm baffled
09:12 cait as we don't have that element yet in Koha, it woudl just help to give a hint I think
09:12 ashimema hmm
09:12 there used to be
09:12 cait is it hidden maybe?
09:12 I see the little green line on the screenshot
09:12 ashimema meeting time.. I'll try to keep up and take notes of feedback
09:13 this was pushed as 'experimental' with the promise of quick follow-ups
09:13 so I'll do said follow-ups now it's getting wider audience
09:23 lds joined #koha
09:39 ashimema talking semantics.. ::Data and ::Datas as Koha class names.. or '::Datum' and '::Data' for plural/singular fun
09:40 cait joined #koha
09:40 ashimema '::Datas' felt off reading this patch.. but honestly I can't really come up with anything better/clearer and 'Data/Datum' though strictly more correct in English could be rather confusing when looking at two classes
09:43 paulderscheid[m] hi #koha
09:44 I use Data for plural and Datum for singular everywhere. It's technically correct.. the best kind of correct.
09:45 ashimema that was my thought.. but I'm also aware it's not consistent with our other classes for no-english native speakers
09:53 marcelr i would go for the simple Data/Datas; although not the best language
09:53 paulderscheid[m] That's true but I think you have to make the cut at some point.
09:53 marcelr we already have things like that
09:53 ashimema hehe
09:53 marcelr also Info and Infos etc
09:54 ashimema yeah.. I wouldn't fail it for it.. but if there were a simple synonym that were nice I'd prefer it.. i just can't think of one 😜
09:54 marcelr Datum is dutch for Date
09:54 paulderscheid[m] In german as well./
09:55 ashimema lol
09:55 paulderscheid[m] But from context you can deduce it I guess.
09:55 marcelr yeah but when i see Datas i know right away that they mean plural of Data
09:55 paulderscheid[m] For example something like this is obvious: data.map((datum) => console.log(datum));
09:56 ashimema on the plugin front.. bug 35603 is nice 😜
09:56 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35603 enhancement, P5 - low, ---, kyle, Signed Off , Add plugin feature to allow plugins to warn if any external library modules needed are missing
09:56 paulderscheid[m] Come to think of it this is mainly where I use it
09:56 Plugins are coming along!
09:56 I like plugins :D
09:57 marcelr ashimema++
09:57 i knew that Datas came from somewhere :) lol
09:58 paulderscheid[m] Nice and simple ashimema++
09:59 I really like both of you coding styles btw
09:59 Recently read one of your modules marcelr and thought: I like almost everything about this module :D
10:00 marcelr nice to hear paulderscheid[m]
10:00 ashimema I like that it's generally a friendly place to debate things here and that people are generally open to discussion and debate 🙂
10:00 paulderscheid[m] That's awesome as well
10:00 ashimema I'm certainly not a great coder by any measure in my own opinion.. loads to always learn
10:00 marcelr koha++
10:01 ashimema: the number of bugs shows that we all need a few steps to a higher level :)
10:01 paulderscheid[m] That's a sharp observation ;D
10:02 ashimema we have a huge huge amount of legacy and debt too.. any project that's been going this long and in such an organic growth will have that
10:02 paulderscheid[m] true
10:02 marcelr technical debt is really an issue here
10:02 ashimema It's so easy to shoot yourself in the foot in Koha
10:02 paulderscheid[m] It really shows where C4 and Koha namespaces make an unholy abomination in 22.11
10:02 ashimema it's very hard to reduce it ☹️
10:03 paulderscheid[m] Some modules use both namespaces
10:03 Joubu not hard, but hard to get focus on it..
10:03 ashimema and it's not just the technical issue.. it's all about funding and planning and time
10:03 paulderscheid[m] for the same thing
10:03 ashimema yeah.. it's not the technical so much as the focus
10:04 paulderscheid[m] I think it will be much better when C4 is deprecated
10:04 marcelr funding for architecture is always hard
10:04 ashimema right.. out of one meeting now.. I have an hour until the next
10:04 so I think I'm going to dig into the bookings feedback
10:04 we get funding for it here..
10:04 well.. I say that.. I fight to allocate time to it
10:05 problem is.. as a community we don't line up on it
10:05 people get different timed slots on it and they very rarely line up
10:05 the SO + QA process.. whilst important.. is challenging to the max when it comes to refactoring
10:06 just as important though 😧
10:06 if not more so
10:06 paulderscheid[m] truth
10:22 Joubu marcelr: re flatpickr - did you notice the JS error in the console? "Error: Invalid date provided: defined"
10:23 marcelr: ok nevermind, got it. Several wrong things here ;)
10:26 marcelr feeling a solution in the air :)
10:45 easy patch to test: bug 34999
10:45 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=34999 minor, P5 - low, ---, m.de.rooy, Needs Signoff , REST API: Public routes should respect OPACMaintenance
10:54 marcelr bbl
11:17 oleonard o/
11:23 Joubu ashimema: you should QA bug 33639. It's fixing a lot of obvious mistakes from the original patchset.
11:23 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33639 normal, P5 - low, ---, lucas, Signed Off , Adding item to item group from 'Add item' screen doesn't work
11:23 ashimema ok, will take a look
11:26 khall joined #koha
11:48 mavhc[m] joined #koha
12:14 kidclamp Joubu: see bug 34360
12:14 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=34360 major, P5 - low, ---, koha-bugs, Needs Signoff , [WARN] DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique column 'biblionumber' on a resultset containing one-to-many joins will return duplicate results
12:16 lds joined #koha
12:37 marcelr joined #koha
12:37 marcelr o/
12:40 kidclamp hi marcelr
12:43 marcelr hi kidclamp
12:47 cait thi smoment when you are about to check jenkins health...
12:47 hm interesting
12:47 t_db_dependent_selenium_regressions_t.Display circulation table correctly
12:49 marcelr Joubu: I cannot reproduce this JS error in the console opening and saving empty dates in several date formats?
12:52 cait MatthewBlenkinsop++ erm tests are green now
12:52 marcelr https://github.com/flatpickr/f[…]pickr/issues/1182
12:53 fixed in 2018 ?
12:57 mavhc[m] Is there any documentation about how to use the Subscription History for Serials? Can't find anything
13:02 cait what are you looking for?
13:03 like what do you want to do or what is the problem?
13:03 mavhc[m] trying to add an existing collection of magazines. Unsure what to put in the Received issues box
13:03 cait I'd put a summary
13:04 if you ahven't checked the "manual history" checkbox in a subscription Koha will fill that info in for each issue received
13:04 butif you have a lot of past issues, that might not be very helpful/readable
13:04 it just creates a list
13:04 but if you put something else, like a short summary of yor existing holdings, that won't break things
13:05 mavhc[m] thanks
13:07 lds joined #koha
13:10 marcelr MatthewBlenkinsop[m]: please have another look at 35341; do you see any js errors ?
13:33 cait hm is it me, or issomething odd about the table backgrounds on the elasticearch page? (and tabs?)
13:33 I think so, the active tab is "invisible"
13:34 https://www.kit.edu/kit/pi_202[…]eksmanagement.php - first German university live on Koha (press release)
13:35 khall joined #koha
13:35 cait interesting, it's my new screen
13:36 I think the user before me had some strange settings :) all good now
13:49 MatthewBlenkinsop[m] <marcelr> "Matthew Blenkinsop: please..." <- Will try and have a look this afternoon 👍️
13:51 marcelr great !
13:57 KIT on Koha, nice cait
13:59 khall_ joined #koha
13:59 Dyrcona joined #koha
14:05 caroline joined #koha
14:11 cait marcelr: big step :) but they got a great team
14:18 oleonard cait: Is KIT really the first German university library on Koha?
14:23 cait we have some universities of applied sciences
14:23 that are already using Koha
14:24 but that's not quite the same at elast in German
14:27 Dyrcona joined #koha
14:32 oleonard I guess I don't understand updating translations anymore... just not working
14:32 cait I had some trouble too, but it did work for me
14:32 the important bit is to make sure that you have a clean state
14:33 in yor repo
14:33 no file etc.
14:33 then ktd will take care of po files and the gulp:update should work
14:34 Joubu oleonard: what's the error?
14:35 `cd misc/translator/po && git reset --hard origin/master` then try again the gulp command. If it still does not work, double check the permissions/owner of misc/translator/po (and subdirs, including .git)
14:36 There is also: https://gitlab.com/koha-commun[…]/#common-problems
14:36 as well as https://gitlab.com/koha-commun[…]translation-files
14:37 oleonard I get this error from gulp po:update: "Error: ENOENT: no such file or directory, open '/tmp/koha-ppGcBL/Koha-marc-UNIMARC.pot'"
14:37 Joubu git fetch origin before the reset --hard and it should work
14:38 `cd misc/translator/po && git fetch origin && git reset --hard origin/master`
14:39 oleonard Yes the reset did the trick
14:40 Joubu whenever you are playing with the translations file, ktd startup will refuse to erase uncommited changes, so you will lack behind the repo
14:44 added it to the README: https://gitlab.com/koha-commun[…]en-tmpkoha-xxxpot
14:47 marcelr: yes, still getting the error. We are passing "None defined" to parseDate.
14:47 make sure you have "None defined" in "Hard due date"
14:47 marcelr yes i had
14:47 note the change in the second patch !
14:48 for itm_text
14:48 see an earlier comment
14:48 it feels like we dont have the same flatpickr version or so
14:49 but i am rebuilding now
14:50 Joubu you are splitting on " "
14:50 "None defined", so you pass "defined"
14:50 this is really bad, "None defined" can be translated
14:51 marcelr yes, this needs attention (not my invention, just coping with it)
14:52 Joubu 1509                             input_values = itm_text.split(' ');
14:52 1510                             var fp = document.querySelector("#hardduedate")._flatpickr;
14:52 1511                             if (is_valid_date(input_values[1])) {
14:52 this is the version I have, you are still passing "defined"
14:52 marcelr ok
14:52 Joubu t
14:52 marcelr but i dont see parseDate crashing
14:52 Joubu the date must be in a separate element
14:53 marcelr i am returning to it with a fresh container
14:53 Joubu it is actually not crashing (and that's the problem), it is only outputting with console.warn
14:53 marcelr yes i mean the same
14:53 Joubu ;)
14:53 marcelr no logs
14:53 no warns
14:54 Joubu FF?
14:54 marcelr yes
14:57 cait marcelr: github seems happier now, we moved from unverified to Partially verified and verified...
14:59 marcelr cait++
15:00 lukeg joined #koha
15:00 cait it seems the old ones are ok now too
15:00 gitlab was easier to persuade
15:01 I am off tomorrow - but hopefully more pushes happening Monday - given we didn't break things too badly with this one ,)
15:01 bye all
15:01 caroline have a nice weekend!
15:01 oleonard cait++
15:03 marcelr MatthewBlenkinsop[m]: i am very curious if you can reproduce the js error that Joubu has too
15:03 Joubu marcelr: what do you pass to parseDate?
15:03 ashimema our api permissions are such a mess
15:04 Joubu s/api//
15:04 marcelr None defined
15:05 all fresh dev container same story still
15:07 wait i do see it now
15:07 lol
15:07 new glasses :)
15:07 along with downloadable font: Glyph bbox was incorrect
15:08 ok MatthewBlenkinsop[m] dont test yet, i will change the patch still
15:08 Joubu marcelr: we need to use an hidden input
15:08 and remove this silly split
15:09 marcelr i will have a fresh look at it now :)
15:09 ashimema view_borrower_infos_from_any_libraries is backwards ☹️
15:09 Joubu backwards?
15:10 ashimema api wise.. we're in effect saying that's the default
15:14 we need bug 29509
15:14 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=29509 normal, P5 - low, ---, martin.renvoize, In Discussion , GET /patrons* routes permissions excessive
15:14 oleonard now the translation install step seems to be failing :(
15:22 Joubu oleonard: which languages? seeing something in the console?
15:23 oleonard I'm doing "perl misc/translator/translate install fr-FR" and it runs without error but the fr-FR template isn't changed
15:30 Joubu testing a string in messages?
15:30 if so you need to restart memcached (JS translation strings are cached)
15:30 messages-js
15:31 oleonard It's in _() not __() so it shouldn't be in messages-js should it?
15:32 (anyway I see it in fr-FR-staff-prog.po)
15:32 Joubu if it's staff-prog you shouldn't need to restart memcached
15:33 do you see the filepath and line number in the po corresponding to where you are looking at?
15:35 oleonard the po file shows the line number of the start of the <script> block instead of the actual line, but yes.
15:40 Joubu oleonard: I have added a new string to intranet-main, gulp po:update --lang fr-FR, translated it, run install fr-FR, and I do see the translated string
15:41 trying with _("") no
15:41 now
15:42 same with console.log(_("yet another string")); in intranet-main, it's working for me
15:55 oleonard Now I'm getting "Error: ENOENT" again.
15:55 I'm going to put this aside for another day. Thanks for your help Joubu
16:04 reiveune bye
16:04 reiveune left #koha
16:32 paulderscheid[m] Just for the lulz: webkit browsers don't support dashes in the date constructor :D '2024/01/01' is fine '2024-01-01' is NOT O.o
16:36 oleonard whut
16:44 cait joined #koha
16:46 paulderscheid[m] try it :D
16:48 bag joined #koha
16:50 bag any QA’ers out there that would have a chance to QA this bug?  https://bugs.koha-community.or[…]_bug.cgi?id=33363
16:50 huginn` 04Bug 33363: enhancement, P5 - low, ---, kyle, Signed Off , More specific permissions for purchase suggestions
16:50 bag thanks in advance :)
17:19 caroline Does anyone have an example of a CSV profile for MARC exports written in TT?
17:19 The page where you create a new CSV profile says "You can use Template Toolkit tags too. See the help page for more information." and I'm trying to provide the "more information"... but I don't know much TT
17:25 Ok I found https://bugs.koha-community.or[…]ment.cgi?id=35052 I will copy that information
17:26 I can't say I understand much though... hashref, arrayref...
17:33 ashimema on it bag
17:34 bag sweet! ashimema++
17:37 * cait waves
17:44 magnuse bag: hi
17:44 bag HI!
17:44 magnuse :-)
18:07 dpk joined #koha
18:39 Dyrcona joined #koha
20:29 caroline If anyone who knows TT is around, I'd like to have this section reviewed https://gitlab.com/koha-commun[…]1a8681a_2735_2807
20:30 I don't know much TT and mostly copied the examples that were in bug 12404, and tried to exmplain to the best of my comprehension
20:30 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=12404 enhancement, P5 - low, ---, jonathan.druart+koha, CLOSED FIXED, CSV profiles improvements (concatenations, substrings, conditions...)
20:41 at0microuton joined #koha
20:44 bag lukeg you about?  see what caroline is asking about?
21:26 lukeg joined #koha

← Previous day | Today | Next day → | Search | Index

koha1