IRC log for #koha, 2023-04-25

← Previous day | Today | Next day → | Search | Index

All times shown according to UTC.

Time Nick Message
00:34 cait joined #koha
06:03 magnuse__ joined #koha
06:04 magnuse__ \o/
06:04 fridolin joined #koha
06:11 fridolin hi
06:11 Bug 33603 oups forgot there are control fields ;)
06:11 huginn 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33603 major, P5 - low, ---, fridolin.somers, Needs Signoff , misc/maintenance/search_fo​r_data_inconsistencies.pl fails if biblio.biblionumber on control field
06:47 reiveune joined #koha
06:48 reiveune hello
07:00 thibaud_g joined #koha
07:04 cait joined #koha
07:04 cait left #koha
07:15 ashimema Morning
07:19 magnuse bonjour ashimema
07:25 tundunf joined #koha
07:25 tundunf morning everyone :)
07:25 Does anyone know if there's anything that can be done to clear a 503 error?
07:32 Joubu try restarting the services in the correct order
07:33 memcached, apache2, koha-common
07:34 fridolin1 joined #koha
07:36 tundunf thank you!
07:48 ashimema Where are you getting 503 tundunf?  I can take a look once back from the school run
07:50 alex_ joined #koha
08:02 tundunf when we try logging in from libstaff.uwl.ac.uk and when users try to log in at library.uwl.ac.uk
08:05 ashimema Oh, on the SSO link?
08:05 That looks like it's not Koha side but you're IT departments end to me
08:06 I just tried from mobile, not back yet.  Will check the logs our end when I'm back
08:07 tundunf I see, thanks for checking!
08:09 perplexedtheta Morning Tundun, its Jake from PTFS-E
08:10 ashimema Lol, everyone is on it here this morning
08:10 See slack jake
08:10 perplexedtheta Just to follow up from Martin to say that it looks like an issue with your entire IDP system: https://idp.uwl.ac.uk - I'd recommend checking with your IT teams to see if they are aware of any issues.
08:10 If you still have issues after the IDP comes back online, feel free to message me via Slack or email me directly, and I can look with urgency. Thanks!
08:25 ashimema did the strings appear yet cait?
08:25 I sent some chasers
08:27 tundunf Thanks Jake! I've raised this with our IT and I'll let you know
08:31 ashimema 🙂
08:56 anyone fancy testing bug 33504
08:56 huginn 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33504 major, P5 - low, ---, martin.renvoize, Needs Signoff , ILS-DI does not record renewer_id for renewals
08:56 ashimema it's a symptom fix rather than resolving the cause.. but it's the best I can come up with for now
09:07 fridolin1 left #koha
10:38 oleonard Hi all
10:44 magnuse hi oleonard
10:49 ashimema: on 33504 you say "View the circulation history for the item" - which view are you talking about? i can't seem to get a modal on either /cgi-bin/koha/circ/bookcount.​pl?&biblionumber=272&itm=597 or /cgi-bin/koha/catalogue/issu​ehistory.pl?biblionumber=272
10:53 ashimema members/readingrec.pl
10:54 sorry.. in a call.. but will try to reply in more detail once I'm out
10:54 magnuse ah, no worries, i see it now!
11:12 cait joined #koha
11:12 cait hi #koha
11:14 oleonard o/
11:14 cait hi oleonard
11:14 more breadcrumby things?
11:15 oleonard Trying to fix the loose ends
11:45 alex_ joined #koha
12:20 tcohen hola #koha o/
12:40 Joubu tcohen: did you report the permissoin problem with svc/config/syspref?
12:41 tcohen I didn't
12:41 Joubu any good ideas to fix it?
12:42 (apart from reengineering everything)
12:43 tcohen move to nodejs and use server-side rendering :-P
12:49 so no good ideas
12:49 I'm not sure how to inject those for rendering
12:51 Joubu Does it mean we need a kind of 'config' endpoint for each vue module? (what you suggested to me last week IIRC)
12:52 Dyrcona joined #koha
12:55 Joubu /api/v1/config/erm that would require the basic ERM permissions, and return the list of sysprefs + specific permissions?
12:55 tcohen, PedroAmorim[m]?
12:56 tcohen it should return some structure telling what the user can do
12:56 not leaking sysprefs IMHO
12:57 the endpoints will error when attempted to be used anyway
12:57 Joubu even if we control the sysprefs we are sending to the client?
12:57 like "ERMModule" and "ERMProviders"
12:57 tcohen you will eventually need a way to tell about those we cannot send the consumer
12:57 Joubu do you agree with /api/v1/config/erm?
12:58 tcohen I'd like to hear from ashimema
12:58 * ashimema is quietly watching..
12:58 ashimema what's the discussion.. i don't have the context
12:58 tcohen but I would agree, depending on the returned data structure
12:58 Joubu ashimema: see bug 33606 comment0
12:58 huginn 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33606 major, P5 - low, ---, jonathan.druart+koha, NEW , Access to ERM requires parameters => 'manage_sysprefs'
12:59 ashimema okies.. reading
12:59 Joubu before we were passing the sysprefs from erm.tt, serializing the syspref's values, and retrieving them in the vue app
13:00 that was useful to mock the sysprefs and test the UI (from cypress tests, using 'intercept')
13:03 ashimema Doh!
13:03 I totally missed that during QA
13:03 ffs.
13:03 Joubu @later tell fridolin Are you reading Katrin's QA team emails?
13:03 huginn Joubu: The operation succeeded.
13:03 Joubu yep, same for me... that's bad
13:03 ashimema I've felt for ages our sysprefs are a bit open
13:03 all or nothing
13:04 so I agree with splitting them out into more granular sets
13:05 Joubu how that?
13:05 ashimema though I also feel 'get_preference' should likely be different to set_preference perms wise
13:06 Joubu yes and no, we don't want to expose some of the prefs
13:06 ashimema indeed
13:06 Joubu I suggested (pm) to tcohen last week to allow some of those, explicitely
13:06 and I think he disagreed ("we should not expose the prefs")
13:07 so now the suggestion is to have a 'config' endpoint
13:07 (but I would prefer something easier to implement)
13:07 ashimema C4::Service is a bit simplistic in it's perms design
13:07 tcohen I'm not sure how full-fledged Vue/Angular apps work on this regard
13:08 but it feels like we haven't thought about it, and the only way to keep the 'current way'
13:08 ashimema there's no trivial answer is there ☹️
13:08 tcohen is server-side rendering
13:08 i.e. roll back to the erm.tt trick to inject
13:08 Joubu that's bad for tests
13:09 tcohen I need to read a bit about how client-side Angular/Vue apps are engineered
13:09 because they certainly solved this
13:10 Joubu do we really want to deal with all node modules warnings/errors/security issues?...
13:10 and it's way out of the scope here...
13:12 we already have 2 possible solutions: 1. allow access to a couple of prefs (we really only need 2 so far) to 'catalogue' only, and 2. the weird 'config' route that would return the list of what need the app to startup (couple of prefs and specific permissions)
13:14 tcohen https://www.permify.co/post/im[…]control-in-vue-js
13:18 ashimema what pushes you away from having a read only config route (behind the right permissions)?
13:18 tcohen so, we can take a shortcut to get out of this specific situation, but we will need to spend some hours an a couple meetings coming up with a data structure like that user.json
13:18 I agree with a read-only route
13:18 I think I proposed that heh
13:19 ashimema we should know what perms a user has.. so should know what routes we can hit and expect a return.. as such /config/vue seems reasonable to have a read route to get vue prefs
13:19 oh
13:19 * ashimema isn't keeping up well
13:19 tcohen I just highlight that we do server-side rendering with our .tt files
13:19 and Vue requires new ways
13:20 I think permissions could be baked on session cookies as JWT tokens
13:20 but we  still need the business/config endpoint to know more about what needs to be displayed
13:20 that page explains it
13:21 one option is for it to return 'the sysprefs', but we can stop for a few hours and think of better data structures
13:22 no attempt to block anything here, just thinking beyong ERM
13:22 picking Manuel bbia
13:23 ashimema okies
13:31 Joubu I think I prefer a erm/config route instead of a global 'user' that could become a mess easily
13:58 tcohen, ashimema: I've added a patch on bug 33606 for discussion
13:58 huginn 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33606 blocker, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Access to ERM requires parameters => 'manage_sysprefs'
14:02 lukeg joined #koha
14:18 oleonard joined #koha
14:46 JBoyer joined #koha
16:14 reiveune bye
16:15 reiveune left #koha
16:43 cait joined #koha
16:53 oleonard The qa tool warning on Bug 33158 is weird... I assumed it was a false positive since the includes work as they should
16:53 huginn 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33158 minor, P5 - low, ---, oleonard, Failed QA , Use template wrapper for authorized values and item types administration tabs
17:19 bag joined #koha
17:19 MarkHofstetter joined #koha

← Previous day | Today | Next day → | Search | Index

koha1