← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 01:52 | cait1 joined #koha | |
| 04:55 | Oak joined #koha | |
| 05:22 | lds joined #koha | |
| 06:50 | marcelr joined #koha | |
| 06:50 | marcelr | hi #koha |
| 07:20 | Anne_Marie joined #koha | |
| 07:22 | magnuse__ joined #koha | |
| 07:30 | thibaud_g joined #koha | |
| 07:53 | Joubu | ashimema, MatthewBlenkinsop[m] around? |
| 07:55 | cait joined #koha | |
| 07:55 | cait | good morning #koha |
| 07:57 | marcelr | hi cait |
| 07:58 | alex_ joined #koha | |
| 07:58 | alex_ | Bonjour ! |
| 07:59 | cait2 joined #koha | |
| 08:00 | cait1 joined #koha | |
| 08:01 | lds joined #koha | |
| 08:01 | cait3 joined #koha | |
| 08:11 | cait1 joined #koha | |
| 08:20 | cait1 | hm can I change the print layout somehow with the CSS preferences? |
| 08:22 | Joubu | NoticeCSS is used if "is html" is ticked |
| 08:22 | marcelr | hi Joubu, was just hoping that you should let it go :) |
| 08:22 | cait1 | ah, I am wondering about printing the pages |
| 08:22 | not notices | |
| 08:22 | a library is not happy witht he printouts of lists | |
| 08:22 | i think I'll try adding a noprint calss with jquery | |
| 08:23 | Joubu | ha, then you are talking about intranetusercss? |
| 08:24 | marcelr: I am not convinced.. sorry! | |
| 08:24 | marcelr: moreover it's code we will never manage to remove, we will have to keep it forever.. | |
| 08:25 | cait1 | Joubu: opac even :) but I'll try the trick with js and let you iknow if it works |
| 08:28 | that appears to work | |
| 08:29 | Joubu | @later tell tcohen could you ask Bernardo to have a look at 32584? |
| 08:29 | huginn | Joubu: The operation succeeded. |
| 08:30 | marcelr | all code can be removed, everything has its price; this argument can be applied to most developments |
| 08:34 | Joubu | nope, here it will be used in notice templates by libraries. If you remove them you will break the notices. |
| 08:35 | marcelr | sure, code should be used |
| 08:39 | just note that these are regular DateTime arguments | |
| 08:40 | not custom parameters | |
| 08:41 | we could even switch to years=>2 ? | |
| 08:42 | and days => -1 etc | |
| 08:42 | if that would convince you? | |
| 08:44 | it wont be prettier.. | |
| 08:45 | add => { days => 1 } | |
| 08:50 | Joubu | I don't think you will convince me that having 2 different ways of doing the same thing is a good idea |
| 08:57 | marcelr | thats not uncommon, but i will stop now :) |
| 09:14 | cait joined #koha | |
| 09:16 | MatthewBlenkinsop[m] | <Joubu> "ashimema, Matthew Blenkinsop..." <- I'm here, Pedro just passed your message on about 32923, I've made a note to push it but I don't think it is in master yet |
| 09:17 | ashimema | We're all in a company meeting today |
| 09:18 | Will catch up the queue tonight or tomorrow before we string freezer | |
| 09:19 | cait2 joined #koha | |
| 09:22 | Joubu | MatthewBlenkinsop[m]: I wanted to make sure it will be part of the upcoming 22.11.x |
| 09:22 | and I will push it | |
| 10:51 | oleonard | Hi #koha |
| 11:01 | cait2 | hello oleonard :) |
| 11:53 | mtj | hey team, ive had a bit of a tidyup on the plack 'auto-reload' patch |
| 11:54 | on bug 31729 | |
| 11:54 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=31729 enhancement, P5 - low, ---, mtj, Needs Signoff , Enable automatic filesystem refresh in Plack |
| 11:55 | mtj | if anyone wants to try to test/break it |
| 11:55 | * ashimema | adds to his ever growing hackfest list 🙂 |
| 11:59 | mtj | have people taken a look at shellcheck before... https://www.shellcheck.net/ |
| 12:00 | ashimema | i use it |
| 12:00 | mtj | ive found it really helpful, for improving my terrible shell scripting skillzz :) |
| 12:00 | ashimema | I don't write shell scripts all the often but when I do I find that really helpful |
| 12:01 | mtj | yeah, same... |
| 12:08 | re 31729: i think a useful follow-up patch, would be to have some KOHA_WATCH=1 variable that could be set in an instance's koha.conf file | |
| 12:10 | ..so we wouldnt have to explictly start an instance's koha-plack with a --watch arg | |
| 12:11 | ashimema | nice idea |
| 12:12 | mtj | i did experiment with starting --watch when $DEV_INSTALL was set |
| 12:13 | ..but i thought it might be a bit cheeky to assume that everyone using KTD, would like --watch running, by default | |
| 12:15 | we can add that stuff, later | |
| 12:25 | cait2 | hm someone with a package installation of 22.11 around that could have a quick look at star ratings? |
| 12:25 | when I try to rate something i get a Forbidden (403) alert | |
| 12:26 | marcelr joined #koha | |
| 12:26 | marcelr | o/ |
| 12:27 | cait2 | it works for the same branch in ktd... |
| 12:27 | alex_ joined #koha | |
| 12:29 | marcelr | mtj: how does this koha watcher do it performance wise? |
| 12:30 | cait2 | hm I wonder if it's something we have done to secure the API or so |
| 12:30 | I'll check into that | |
| 12:32 | mtj | hi marcelr, i'm expecting the watcher mod, wont overload a system |
| 12:32 | marcelr | is inotify-tools installed already ? |
| 12:33 | mtj | its basically tiny shell script running a 2 second loop, looking for a file in /tmp dir |
| 12:34 | ..if it sees the expected file, it sends a HUP to plack | |
| 12:35 | marcelr | looks nice, you should add the dependency for inotify tools |
| 12:35 | mtj | so, its possible on a slooow system - that the 2 sec loop is too fast to reload plack? |
| 12:37 | but i could not break my test system, by running many HUPS too fast - so promising | |
| 12:37 | marcelr | cool |
| 12:38 | mtj | the inotify process does not seem to use much CPU to monitor the koha dir |
| 12:39 | marcelr | couldnt you use inotify too on the /tmp file ? |
| 12:39 | instead of 2 secs | |
| 12:40 | mtj | hmm, yes - i think it originally used that method |
| 12:41 | marcelr | i only saw a warn about inotify and new directories |
| 12:41 | directly after creation it could skip an alert | |
| 12:42 | but that does not seem to be case here | |
| 12:43 | mtj | ah, you are trying patch now marcelr? |
| 12:43 | marcelr | not yet :) just glancing the code |
| 12:43 | mtj | ok ok |
| 12:44 | marcelr | get it signed off today, i will qa tomorrow |
| 12:44 | mtj | joubu did point out some problems with my original patch |
| 12:45 | ..like a git-checkout, that could trigger 1000s of plack reloads, one for each file updated :/ | |
| 12:45 | marcelr | ha inotify will be bit stressed with git checkout :) probably |
| 12:45 | mtj | snap |
| 12:45 | marcelr | stress tests are good |
| 12:46 | but thats just development | |
| 12:46 | so you might need a pause and restart option etc | |
| 12:47 | mtj | yeah, i guess we migth bump into some 'edge cases' |
| 12:48 | marcelr | thats our living :) |
| 12:51 | mtj: fs.inotify.max_user_watches=SOME_NUMBER in sysctl.conf ? | |
| 12:52 | and fs.inotify.max_user_instances | |
| 12:55 | mtj | ah nice |
| 12:56 | marcelr: i performed a terrible test on my KTD, and it passed :) | |
| 12:57 | marcelr | might be nice to put something in your code that sends the HUP signal only once per x seconds or so to prevent continuous reloads |
| 12:57 | mtj | i did a 'git reset --hard v21.05.00' from master, and back - and plack reloaded and was functional |
| 12:57 | marcelr | or a future improvement of course |
| 12:58 | yeah might depend on resources | |
| 12:58 | mtj | ...was failing every 2 seconds, before finally reloading correctly tho :/ |
| 12:59 | ^ i think thats a good example of an unlikely edge case | |
| 13:00 | marcelr | at least for prod |
| 13:00 | not on my dev container | |
| 13:01 | and the funny things is the reload is more important for devs | |
| 13:01 | Dyrcona joined #koha | |
| 13:03 | mtj | yeah, good point |
| 13:06 | perhaps we can detect if plack startup failed last time? - then we start increasing sleep loop, until plack finally succeeds | |
| 13:08 | inotify pkg is added to KTD, master branch | |
| 13:08 | marcelr | ok |
| 13:09 | mtj | ill look at increasing the sleep time, on failure |
| 13:22 | hi Joubu, re logging to plack-error, i dont have a good reason :) | |
| 13:22 | Joubu | they are not errors |
| 13:22 | mtj | i think i was just using it, while testing the patch |
| 13:23 | ^ yes, i agree | |
| 13:25 | Joubu: perhaps watcher.output? | |
| 13:25 | watcher.log? | |
| 13:27 | we could remove logging?, but logging might be useful if we have to troubleshoot later | |
| 13:27 | * oleonard-away | bbl |
| 13:28 | Joubu | plack-watcher.log? |
| 13:35 | marcelr | watcher.log |
| 13:36 | mtj | shorter is better? :) |
| 13:40 | Joubu | longer is more explicit :D |
| 13:40 | watcher of what? | |
| 13:43 | mtj | sold! |
| 13:46 | patch sent | |
| 13:47 | astyles joined #koha | |
| 14:08 | Joubu | trivial QA on a Vue patch at bug 32807 |
| 14:08 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=32807 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , No need to fetch all if we need to know if one exist |
| 14:28 | oleonard joined #koha | |
| 14:49 | oleonard | How do you run the backup that generates the file for the "Export configuration" option? |
| 15:46 | domm[m] | Hey, hopefully easy question: I'm importing some records via bulkmarcimport.pl. The records contain 942 and 952 fields. The imort works and I find data in biblio and biblioitems. But no items are imported. Any ideas? |
| 15:46 | (thats still on a 20.11 version, btw) | |
| 15:48 | caroline | domm[m], what do the 952 contain? |
| 15:48 | domm[m] | a, b, y (and pot. some more) |
| 15:48 | caroline | The only time I've had problems is when 952 contain invalid codes, like a homebranch code that doesn't exist or itemtype code that doesn't exist |
| 15:50 | domm[m] | Yeah, but those are valid values (and I think the importer will complain if they are missing?) |
| 15:52 | caroline | It was my only idea, sorry |
| 16:09 | cait joined #koha | |
| 16:10 | cait | domm[m]: error handling was not super great int he past, not sure if that has been fixed |
| 16:10 | capitalization matches too? | |
| 16:11 | if you want/can share an example we might be able to tell | |
| 16:25 | domm[m] | it seems that somewhen during the import 952 is removed from the record (it seems in AddBiblio). But as i'm running this on a test instance, it might be that we fkd something up on the setup of that test machine... |
| 16:31 | cait | hm it should be removed |
| 16:32 | but only after the item was added | |
| 16:32 | it doesn't remain in the MARC | |
| 16:52 | emlam joined #koha | |
| 16:52 | emlam | o/ |
| 17:00 | cait | hi emlam :) |
| 17:01 | cait1 joined #koha | |
| 17:04 | cait1 left #koha | |
| 17:08 | cait2 joined #koha | |
| 17:08 | cait2 left #koha | |
| 17:09 | cait joined #koha | |
| 17:10 | cait3 joined #koha | |
| 17:11 | cait3 left #koha | |
| 17:13 | cait1 joined #koha | |
| 17:15 | cait1 joined #koha | |
| 17:24 | fridolin joined #koha | |
| 17:24 | fridolin | yellow |
| 17:26 | ashimema | red |
| 17:28 | fridolin | rosé ;) |
| 17:35 | domm[m] | it worked on another instance; on the broken one it also worked when importing via web. and as we're going to upgrade soon, i won't continue to investigate |
| 19:27 | caroline | TIL "Marc Flavours" is a manufacturer of flavours based in India |
| 20:49 | marie-luce joined #koha | |
| 22:03 | magnuse_ joined #koha | |
| 23:20 | domm joined #koha | |
| 23:40 | cait joined #koha | |
| 23:47 | cait joined #koha | |
| 23:56 | cait joined #koha |
← Previous day | Today | Next day → | Search | Index