← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:17 | mtj | hi folks, im about |
| 00:17 | hi lukeg, tcohen | |
| 00:21 | ill do the releases now | |
| 03:53 | hi dcook, i do have a script to fix the 'debian/control out of date' problem | |
| 03:54 | ..i wrote it some time ago, but did not put it live :/ | |
| 03:55 | ill make sure to do it today | |
| 04:03 | dcook | thanks mtj :D |
| 04:17 | mtj: Although even with the updated control file I'm having the worst time trying to build this thing.. | |
| 04:17 | Couldn't get it to build on Debian Bullseye | |
| 04:17 | Managed to build it on Ubuntu Jammy, but reprepro doesn't like how Ubuntu builds the packages | |
| 04:18 | And it takes 12.5 minutes to build it on Ubuntu. Blech... | |
| 04:21 | mtj | dcook: koha-common installs ok on deb11 |
| 04:21 | dcook | I'm so curious how that's possible |
| 04:21 | It should get a package conflict | |
| 04:21 | mtj | ..so looks like the libtest-dbix-class-perl problem is specific to docker image |
| 04:21 | dcook | I've looked at regular VMs and they have that package too |
| 04:23 | libossp-uuid-perl is on all my Debian systems | |
| 04:23 | Not on the Ubuntu ones though | |
| 04:23 | mtj | https://cdn.artifacts.gitlab-s[…]t87hSGEppu79U7sg= |
| 04:23 | thats a basic 'apt install koha-common' on deb11 | |
| 04:24 | dcook | How is the deb11 created? |
| 04:24 | mtj | 'Pulling docker image debian:bullseye ...' |
| 04:24 | dcook | That's interesting |
| 04:25 | mtj | hope it helps |
| 04:25 | dcook | I'll try pulling down a later debian:bullseye |
| 04:26 | I imagine at some point we'll want to replace reprepro as well. I don't think it's been updated in a long time.. | |
| 04:28 | Actually... I'm installing some tools first and it looks like one of those is installing libossp-uuid-perl.. | |
| 04:28 | They're all tools needed to build packages though.. | |
| 04:34 | mtj | hmm, try using pbuilder |
| 04:34 | dcook | I've tried before but it doesn't work the way I want to use it |
| 04:34 | I think the way I do things overall is better :p | |
| 04:34 | Except of course when I bump into little things like this heh | |
| 04:36 | mtj | exactly |
| 04:37 | dcook | Looks like it's the devscripts |
| 04:37 | mtj: On the plus side, it makes me think more ;) | |
| 04:41 | mtj | dcook: the better way to build a pkg, is to start with a pristine OS |
| 04:42 | dcook | O_o |
| 04:42 | It's normal to have build tools and deps when you're building a package | |
| 04:44 | mtj | yes, i agree :) |
| 04:45 | i guess you have added extra build tools and deps, that has caused a problem | |
| 04:45 | dcook | I don't think there are any extra |
| 04:46 | Or rather, I don't specify any extra | |
| 04:46 | Looking in deeper now | |
| 04:46 | And really the problem is libtest-dbix-class-perl :p | |
| 04:46 | I don't think we should be installing libtest-dbix-class-perl in the prod package, but I see why we do it | |
| 04:47 | Kind of seems like the recommendations for devscripts are being installed and not just the dependencies, but let's see.. | |
| 04:48 | Not sure why my older unrelated Debian systems have libossp-uuid-perl installed.. | |
| 04:48 | But unrelated.. | |
| 04:50 | mtj | i dont think we should install libtest-dbix-class-perl pkg too |
| 04:51 | dcook | Maybe we should have a separate package like koha-test that is installed into koha-testing-docker but isn't needed otherwise |
| 04:52 | mtj | all the test* packages are getting included via cpanfile |
| 04:53 | dcook | They're all Recommends though |
| 04:53 | mtj | dcook: curious... why do you have libossp-uuid-perl installed? |
| 04:53 | apt-cache rdepends --installed libossp-uuid-perl | |
| 04:54 | dcook | rdepends isn't super useful there |
| 04:54 | https://packages.debian.org/bullseye/devscripts | |
| 04:54 | Recommends libsoap-lite-perl | |
| 04:54 | https://packages.debian.org/bu[…]libsoap-lite-perl | |
| 04:54 | It depends on libossp-uuid-perl | |
| 04:54 | In theory I might be able to install devscripts without recommends but.. I think I'll just hack on my debian/control file a bit more | |
| 04:59 | mtj | dcook: im building the pkgs from a deb9 pbuilder instance, so that might explain the differences btw us |
| 05:00 | dcook | A deb9 pbuilder? Wouldn't those packages be rather old at this point? |
| 05:00 | I'm surprised you wouldn't have more issues.. | |
| 05:03 | I think pbuilder probably is a better way to go overall but I've gone off on my own path... | |
| 05:12 | mtj | re: using a deb9 env... ive been planning to bump to deb10 after u18 goes EOL |
| 05:15 | i dont quite trust 'upgrading' from deb9 to u18 pbuilder env | |
| 05:20 | dcook: i like your idea of a koha-tests pkg | |
| 05:21 | ..would be good to skip them for prod, and devs can use koha-test pkg in docker | |
| 05:22 | re reprepro, i think there is a plan to switch to aptly | |
| 05:31 | dcook | I keep meaning to look at aptly more.. |
| 05:38 | Ah yes no end of problems running pbuilder in a container. I think this is why I didn't do it before heh | |
| 05:45 | mtj | dcook: a docker container, or other? |
| 05:45 | dcook | docker container |
| 05:46 | I recall that Jonathan and Tomas use pdebuild in a container I think but I don't know if they make the basetgz in the container or if they do that on the host.. | |
| 05:50 | mtj | https://bugs.debian.org/cgi-bi[…]rt.cgi?bug=930684 |
| 05:51 | dcook | Yeah I've skimmed that one a bit |
| 05:51 | mtj | might be fixed here https://packages.debian.org/bu[…]ports/debootstrap |
| 05:52 | https://packages.debian.org/bullseye/debocker | |
| 05:52 | ..or swap pbuilder with debocker | |
| 05:53 | i havent heard of that one ^ | |
| 05:54 | dcook | Well, removed libtest-dbix-class-perl and now I'm able to build using my existing methodology, so all good for now heh |
| 05:55 | Although 12 minutes still seems really slow.. | |
| 05:56 | mtj | its about the same time for me |
| 05:59 | dcook: ill keep a look out for a docker/pbuilder type solution | |
| 05:59 | dcook | Thanks, mtj :) |
| 06:11 | mtj | debian seem to be using docker with dpkg-buildpackage, instead of pbuilder |
| 06:13 | their docker image looks minimal, with no devscripts pkgs, etc | |
| 06:14 | https://salsa.debian.org/perl-[…]-createtable-perl | |
| 06:15 | https://salsa.debian.org/perl-[…]/pipelines/433838 | |
| 06:15 | https://salsa.debian.org/perl-[…]rl/-/jobs/3325628 | |
| 06:17 | that looks like a nice general solution, for us | |
| 06:27 | paxed | anyone got a script to trim or reduce a production database so it could be used for testing env? |
| 07:31 | reiveune joined #koha | |
| 07:32 | reiveune | hello |
| 07:32 | wahanui | kia ora, reiveune |
| 07:49 | Joubu | mtj: silly question, how can we know what is the latest version packaged for a given branch? |
| 07:53 | thibaud_g joined #koha | |
| 07:56 | mtj | hi Joubu |
| 07:56 | wahanui | hi Joubu are you around? |
| 07:57 | cait joined #koha | |
| 07:58 | mtj | you can try 'apt policy some-package' |
| 07:59 | ..but, i think you will need to set your branch/suite before | |
| 07:59 | ..in your /etc/apt/sources.d/koha.list file | |
| 07:59 | then 'apt update' | |
| 08:00 | * cait | waves |
| 08:01 | Joubu | mtj: without using a command |
| 08:02 | in a browser | |
| 08:02 | mtj | aah |
| 08:03 | Joubu | I think we need to make this info available on the dashboard |
| 08:04 | cait1 joined #koha | |
| 08:04 | mtj | hi cait :) |
| 08:06 | magnuse_ joined #koha | |
| 08:06 | mtj | Joubu: a great idea |
| 08:08 | Joubu | From where could we pull the info? |
| 08:08 | mtj | probably easy to scrap it from the apt website |
| 08:08 | http://debian.koha-community.o[…]pool/main/k/koha/ | |
| 08:09 | ashimema | wow that pages styling is aweful now |
| 08:09 | mtj | http://debian.koha-community.o[…]oha/current.22.11 |
| 08:10 | ashimema | that looks simple enough to parse... |
| 08:10 | * ashimema | goes back to school duties.. bbiab |
| 08:11 | Joubu | thanks mtj! |
| 08:11 | mtj | hi ashimema, will catch you then |
| 08:12 | Joubu | dashboard has encoding issues - Tomás Cohen Arazi - 1 |
| 08:25 | ashimema | hmm.. I bet that's to do with the recent OS upgrade of the bugzilla server. |
| 08:32 | @seen rangi | |
| 08:32 | huginn | ashimema: rangi was last seen in #koha 1 year, 30 weeks, 4 days, 12 hours, 4 minutes, and 6 seconds ago: <rangi> ive been accused of worse |
| 08:33 | * ashimema | wonders if the database encoding changed.. we had some similar issues on bugzilla itself semi-recently I seem to remember.. |
| 08:33 | ashimema | I see that the dashboard does a 'SET NAMES 'utf8' and SET CHARACTER SET 'utf8' on connect |
| 08:33 | bet we need to alter that line slghtly. | |
| 08:42 | Joubu | because of mb4? is that what you mean? |
| 08:46 | thibaud_g joined #koha | |
| 08:52 | thibaud_glt joined #koha | |
| 08:52 | thibaud_glt joined #koha | |
| 08:53 | thibaud_glt1 joined #koha | |
| 08:54 | mtj | yeah, i was thinking the same |
| 08:54 | i might attempt to fix the wonky layout on deb.kc.org website | |
| 08:56 | alex_ joined #koha | |
| 08:58 | mtj | ashimema: shall we sort this release now-ish? |
| 08:59 | ..and push tarballs, wordpress and pkgs | |
| 09:00 | ooh, 9am... a bit early | |
| 09:13 | magnuse__ joined #koha | |
| 09:13 | ashimema | I'm back from the school run now |
| 09:13 | I have a morning call then can look at things | |
| 09:14 | I "think" tarballs etc are ready.. just need copying accross | |
| 09:14 | I certainly drafted the 22.11 wordpress post so that just needs publishing | |
| 09:14 | I'll check the others during or after my call | |
| 09:37 | mtj | np, ill be about for a while |
| 10:00 | thibaud_g joined #koha | |
| 10:08 | ashimema | right.. sorry about that |
| 10:08 | call ended up a bit longer than usual.. and more involved | |
| 10:08 | back now | |
| 10:09 | I'd go ahead and push the packages now.. | |
| 10:09 | I'll work through the last steps to bring the tarballs in sync and publish the announcement if that's OK with you mtj | |
| 10:12 | cait joined #koha | |
| 10:12 | cait | ashimema++ mtj++ |
| 10:19 | cait1 joined #koha | |
| 10:25 | ashimema | still there mtj ? |
| 10:25 | I've moved the tarballs accross, done the symlinks and published the announcements to the website | |
| 10:25 | will go ahead with the email to the lists as soon as you let me know the packages are moved 🙂 | |
| 10:32 | mtj | hiya, here |
| 10:35 | 1 tic.. | |
| 10:41 | ashimema | 😄 |
| 10:45 | paulderscheid joined #koha | |
| 10:45 | mtj | twas a longgg tic |
| 10:48 | ashimema: pkgs are pushed | |
| 10:49 | ashimema | awesome |
| 10:49 | thanks mtj 🙂 | |
| 10:49 | your a star | |
| 10:49 | mtj | you too xx |
| 10:53 | paulderscheid_ joined #koha | |
| 11:03 | Joubu | mtj, ashimema: https://gitlab.com/koha-commun[…]erge_requests/123 |
| 11:04 | ashimema | nice.. |
| 11:04 | will review in a moment properly.. | |
| 11:04 | just pulling the security branches and tags and pushing them all to the main repo at the minute 😜 | |
| 11:05 | paulderscheid[m] | Morning #koha |
| 11:10 | mtj | Joubu: ive given your merge request a thumbs-up, heart, and dancing-man |
| 11:11 | ..and a cake | |
| 11:12 | ashimema | lol |
| 11:13 | looks reasonable to me 🙂 | |
| 11:13 | shall I merge | |
| 11:14 | mtj | yes pleese 🕺 |
| 11:15 | ashimema | done 🙂 |
| 11:15 | a few minutes to build and it'll be live 🙂 | |
| 11:18 | Joubu | lol that was fast! |
| 11:18 | ashimema | 🙂 |
| 11:19 | I like it 😜 | |
| 11:19 | it's useful info | |
| 11:19 | Joubu | that's a bit difficult to read |
| 11:22 | ashimema | we can tweak as needed |
| 11:30 | thibaud_glt joined #koha | |
| 11:33 | thibaud_g joined #koha | |
| 12:17 | Joubu | @later tell liliputech there is installer/data/mysql/db_revs/211112000.pl~ in 21.11.x (?) |
| 12:17 | huginn | Joubu: The operation succeeded. |
| 12:24 | thibaud_glt joined #koha | |
| 12:26 | thibaud_g joined #koha | |
| 12:31 | thibaud_g joined #koha | |
| 12:45 | EmmiTakkinen[m] joined #koha | |
| 12:51 | thibaud_g joined #koha | |
| 13:17 | magnuse_ joined #koha | |
| 13:36 | Dyrcona joined #koha | |
| 13:59 | magnuse__ joined #koha | |
| 14:11 | Joubu | I would recommend to not upgrade to the latest 21.05 |
| 14:11 | there are some bad errors in jenkins | |
| 14:12 | mtj: 21.05 is completely broken | |
| 14:22 | marie-luce joined #koha | |
| 14:33 | davidnind | the chatbot has stopped logging again 8-( |
| 14:56 | emlam joined #koha | |
| 15:01 | lukeg joined #koha | |
| 15:01 | tuxayo | Meeting time :) |
| 15:03 | #startmeeting Development IRC Meeting 11 January 2023 | |
| 15:03 | huginn | Meeting started Wed Jan 11 15:03:24 2023 UTC. The chair is tuxayo. Information about MeetBot at http://wiki.debian.org/MeetBot. |
| 15:03 | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 15:03 | The meeting name has been set to 'development_irc_meeting_11_january_2023' | |
| 15:03 | tuxayo | #link https://wiki.koha-community.or[…]g_11_January_2023 Today's agenda |
| 15:03 | #topic Introductions | |
| 15:05 | ashimema | #info Martin Renvoize, PTFS Europe, UK |
| 15:05 | paulderscheid[m] | #info Paul Derscheid, LMSCloud GmbH, Germany |
| 15:05 | lukeg | #info Lucas Gass, ByWater Solutions |
| 15:05 | emlam | #info Emily Lamancusa, MCPL, USA |
| 15:07 | tuxayo | qa_team? |
| 15:07 | wahanui | qa_team is cait, marcelr, khall, kidclamp, lukeg, aleisha, fridolin, ashimema, tuxayo, nugged, petrova, Joubu and dcook |
| 15:07 | tuxayo | rmaints? |
| 15:07 | wahanui | rmaints is, like, liliputech, wainui, lukeg and ashimema |
| 15:08 | cait1 | #info Katrin Fischer, BSZ, Germany |
| 15:08 | kidclamp | #info Nick Clemens, ByWater Solutions |
| 15:08 | lukeg | Our security release was accounced today! |
| 15:08 | kidclamp | huzzah! |
| 15:09 | cait1 | #info Security releases were accounced today! |
| 15:09 | ashimema | 🙂 |
| 15:09 | cait1 | Meeting bot is here, so hopefully the meeting will log ok |
| 15:09 | ashimema | tests need some looking into |
| 15:09 | Joubu | #info Jonathan Druart |
| 15:09 | tuxayo | #topic Announcements |
| 15:10 | Joubu | I have not investigated but regarding Jenkins failures I would not upgrade 21.05 |
| 15:10 | There is a compil error on C4::Auth | |
| 15:10 | paulderscheid[m] | Thanks for the warning! |
| 15:10 | tuxayo | Anything else to announce that doesn't fit better the other topics? |
| 15:11 | Logging doesn't work unfortunately: https://irc.koha-community.org[…]3-01-11#i_2469114 | |
| 15:12 | cait1 | tuxayo: meeting bot is separate |
| 15:12 | tuxayo | #topic Updates from the Release Maintainers |
| 15:13 | rmaints? | |
| 15:13 | wahanui | well, rmaints is liliputech, wainui, lukeg and ashimema |
| 15:13 | tuxayo | cait1: ah cool! |
| 15:13 | khall joined #koha | |
| 15:13 | cait1 | looking good there: https://meetings.koha-community.org/2023/ |
| 15:14 | khall | #info Kyle M Hall, ByWater Solutions |
| 15:14 | tuxayo | Perfect :D |
| 15:16 | team++ for the security release | |
| 15:16 | Joubu | I am not about the ++ really, it was a nightmare to coordinate, and now the builds are failing |
| 15:16 | tuxayo | #info update your installation, see https://koha-community.org/ for infos about the security release. |
| 15:17 | cait1 | what can we do to improve the process? |
| 15:17 | better documentation? hand-over for RMaints? | |
| 15:18 | ashimema | OK.. rmaint report wise |
| 15:18 | Joubu | more communication, read the comments on bugzilla, don't ignore jenkins failures! |
| 15:18 | lukeg | Communication has been an issue with the release team |
| 15:18 | Joubu | And... dont' publish security bugs when jenkins is failing |
| 15:18 | ashimema | #info Security releases have gone out, but it was a challenge to co-ordinate release over xmas period. |
| 15:18 | lauraesca[m] joined #koha | |
| 15:18 | cait1 | was the problem that jenkins didn't run on the changes because they were on the security branches? |
| 15:19 | so no access? | |
| 15:19 | Joubu | then run the prove commands locally? |
| 15:19 | ashimema | We need to make sure rmaints know how to run the full test suit locally for security |
| 15:19 | you can't rely on Jenkins | |
| 15:19 | I ran ours locally, but there appears to be failures on Jenkins.. I only ran a subset of tests it appears. | |
| 15:20 | In general, I think rmaints should have a retrospective and talk about how we can do this better next time. | |
| 15:20 | lukeg | Yes |
| 15:21 | cait1 | yeah, but maybe we could also make a note on the wiki: extra care torun all tetst locally |
| 15:21 | ashimema | there are some key skills that need a bit of work.. we can get there together.. I intend to liase a bit with people and try to co-ordinate some shared learning. |
| 15:21 | cait1 | for security |
| 15:21 | or so | |
| 15:21 | ashimema | yup |
| 15:21 | tuxayo | > don't ignore jenkins failures! |
| 15:21 | It's not part of the process to run the tests locally. So it can be forgotten. Anyone to complete the RMaint doc? | |
| 15:21 | cait1 | I can add a general note, but if there is a trick to run "all" someone else might want to add that |
| 15:22 | * ashimema | has really struggled to keep on top of everything lately.. juggling new employees, support demands and then trying to help co-ordinate release and community actions on top. |
| 15:22 | ashimema | new employees are awesome btw... all my queues are moving again 🙂 |
| 15:22 | tuxayo | > if there is a trick to run "all" |
| 15:22 | run from the kohadev user. On root some tests will fail. | |
| 15:23 | Joubu | https://gitlab.com/koha-commun[…]c4dev/-/issues/58 - this will help. Before it's done you need to replicate ktd/run.sh |
| 15:23 | ashimema | but there's always a learning curve for a new team onboarding.. be that internally or in community. |
| 15:23 | yup.. we need to get that bug sorted Joubu.. that'll help a lot | |
| 15:24 | Joubu | it's almost at the top of my list.. |
| 15:25 | ashimema | Joubu++ |
| 15:26 | tuxayo | #action cait add to RMaint documentation to run the test suite locally for security release |
| 15:26 | ashimema | we need more spread of knowledge somehow too... right now I feel like Tomas, Joubu, Mason or I are all a little bit overly relied upon.. we need to try and spread our pooled knowledge a bit further so when one of us is out of action we're not so stuck as a community. |
| 15:26 | cait1 | I just did: Important: As Jenkins won't run on the changes in the security branches, it's important to run the full test suite locally to avoid any unnoticed failures! |
| 15:27 | hope I put it in the right spot | |
| 15:27 | tuxayo | last time I looked at run.sh, the core of it was prove -r t/ xt/ -j $(nproc) --rules='seq=t/db_dependent/**.t' |
| 15:27 | ashimema | right now.. if mjt is out we're stuck for packaging for example |
| 15:27 | but there's a bit of a lack of volunteers to take on learning some of that knowledge.. | |
| 15:28 | we need some people to step up and help with CI | |
| 15:28 | Packaging | |
| 15:28 | dev tools in general | |
| 15:28 | paulderscheid[m] | I'd be up to write docs. |
| 15:29 | Joubu | cait1: I am not blaming anyone, but jenkins is failing for stable branches for a while, it's not because of the security branches |
| 15:29 | just that people don't mind about jenkins failures | |
| 15:29 | cait1 | I understand, but that might go somewhere else in the tasks/docs |
| 15:29 | Joubu | and now that the failures are not even on this channel it's even worse it seems |
| 15:30 | cait1 | I also feel like we have some people who know stuff, but we don't have a lot of good documentation to point people to |
| 15:30 | it's something we shoudl focus a bit more on | |
| 15:30 | the wiki often has contraditcting informration spread on many pages for some stuff, need to reduce that and find the 'truth' in there | |
| 15:30 | ashimema | I was pro the bot move.. but I think we did move too much.. I think some noise was good on here.. |
| 15:30 | cait1 | I plan to maybe tackle some topics and compile some list of those pages - but I haven't fully formed a plan yet |
| 15:30 | ashimema | like Jenkins failures I feel would be good to have |
| 15:31 | cait1 | but will for sure need some help |
| 15:31 | +1 | |
| 15:31 | tuxayo | > like Jenkins failures I feel would be good to have |
| 15:31 | That still require all the rmaints get the chat here for failures. | |
| 15:32 | Or maybe the point is so someone else ping them about the builds still failing? | |
| 15:33 | Joubu | no, rmaints should be responsible watching jenkins build after they push to their branch |
| 15:33 | * ashimema | uses the dashboard |
| 15:33 | ashimema | I check for failures there regularly for our branch |
| 15:34 | tuxayo | > rmaints should be responsible watching jenkins build after they push to their branch |
| 15:34 | +1, having the current process followed would be the best | |
| 15:34 | thd joined #koha | |
| 15:36 | tuxayo | there are indeed some builds that have been failing for a long time :o |
| 15:37 | emlam | re: ashimema's point on knowledge spread, I'm still just starting to learn how to develop Koha in general and asking newbie questions, but ultimately I'd love to learn from the pooled knowledge and help with documentation |
| 15:37 | cait1 | hm yeah, maybe we need to be more strict and revert in those cases if possible |
| 15:37 | emlam: let me know if I can help you with documentation - it's good to know where/waht we are missing specifically or most urgently | |
| 15:38 | i might also be able to dig something up from knowing where to look | |
| 15:38 | (which is not how it should work) | |
| 15:38 | emlam | cait1++ |
| 15:38 | ashimema | likewise.. if you can't find cait I might be able to point in the right direction too |
| 15:39 | emlam | ashimema++ |
| 15:40 | caroline | I assume you're talking about dev documentation? |
| 15:40 | tuxayo | So ok to plan so discussion on completing the process and emphasizing the need to not less failing CI? |
| 15:40 | * caroline | not trying to recruit or anything... |
| 15:40 | cait1 | not less... no failing :) |
| 15:40 | tuxayo | rmaints? |
| 15:40 | wahanui | rumour has it rmaints is liliputech, wainui, lukeg and ashimema |
| 15:40 | tuxayo | ↑↑↑ |
| 15:40 | (completing the process: the rmaint doc) | |
| 15:41 | moving on? | |
| 15:41 | Joubu | actions for the failures? :D |
| 15:41 | right now people should not upgrade to 21.05, and sec releases have been announced | |
| 15:41 | emlam | caroline: yes |
| 15:42 | thd | #info Thomas Dukleth, Agogme, New York City |
| 15:42 | Joubu | to latest 21.05 |
| 15:44 | tuxayo | > actions for the failures? |
| 15:44 | > right now people should not upgrade to 21.05 | |
| 15:44 | I can reach wainui, any lead about how fix 21.05 while keeping the security fixes? | |
| 15:46 | #action tuxayo reach wainui about the broken 21.05 release and investigate the failures. | |
| 15:46 | Joubu | ask the original author |
| 15:47 | don't ask somebody else to rebase | |
| 15:47 | that would be my advise | |
| 15:49 | tuxayo | > ask the original author |
| 15:49 | > don't ask somebody else to rebase | |
| 15:49 | ok then I'll also reapply the 21.11 patch on a previous 21.05 to see if the backport was tricky. | |
| 15:49 | thanks for the lead | |
| 15:49 | lead/hint (I don't the right word) | |
| 15:49 | #topic Updates from the QA team | |
| 15:49 | qa_team? | |
| 15:49 | wahanui | it has been said that qa_team is cait, marcelr, khall, kidclamp, lukeg, aleisha, fridolin, ashimema, tuxayo, nugged, petrova, Joubu and dcook |
| 15:50 | cait1 | #info Queues are quite full right now, I am pushing for the bad bugs and the old bugs... need more hands - please QA! |
| 15:50 | tuxayo | tcohen around? For next topic to be "Update from the Release manager (23.05)" |
| 15:50 | kidclamp | poking rabbit/background stuff thanks to dcook and Joubu for lots of work |
| 15:50 | cait1 | yeah, that's totally out of my league and important |
| 15:51 | and easily bad bugs too | |
| 15:51 | #info Work ongoing for rabbitMQ and bakground job improvements and fixes | |
| 15:51 | jus tnoticed that it's quiet now, in theory we have a big QA team ;) | |
| 15:53 | Joubu | bug 32481 |
| 15:53 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=32481 critical, P5 - low, ---, dcook, Signed Off , Rabbit times out when too many jobs are queued and the response takes too long |
| 15:53 | Joubu | bug 32393 |
| 15:53 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=32393 normal, P5 - low, ---, jonathan.druart+koha, Needs Signoff , background job worker explodes if JSON is incorrect |
| 15:53 | * cait1 | hands over to Joubu :) |
| 15:53 | Joubu | bug 32594 |
| 15:53 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=32594 enhancement, P5 - low, ---, nick, In Discussion , Add a dedicated ES indexing background worker |
| 15:53 | Joubu | bug 32594 |
| 15:54 | Should be high priority for everbody | |
| 15:54 | bug 32395 | |
| 15:54 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=32395 enhancement, P5 - low, ---, koha-bugs, In Discussion , Why do we send jobs params to the broker |
| 15:55 | Joubu | and others, but those ones should go first. |
| 15:56 | cait1 | thx |
| 15:57 | ready to move on? | |
| 15:57 | tuxayo | thanks! |
| 15:57 | #topic Status of roadmap projects | |
| 15:57 | Yes, I needed to find an email | |
| 15:57 | #info roadmap: https://annuel.framapad.org/p/[…]p_for_Koha_v23.05 | |
| 15:58 | tcohen said in an email in koha-devel: | |
| 15:58 | «Now, it is time for us to build a new one ofr this cycle. Please fill with the things you plan to work on this cycle, and put your name so we all know and can help each other.» | |
| 15:59 | #topic Actions from last meeting | |
| 15:59 | thd | Still have extra work now but next month, should test a new incremental version of MediaWiki Canasta container. |
| 15:59 | tuxayo | «tuxayo: Open tickets on KTD for the basic stuff needed to easily work on the non-root user.» |
| 15:59 | done | |
| 16:00 | bag joined #koha | |
| 16:00 | tuxayo | «tuxayo: Call for a volunteer on mailing lists to open the bidding for KohaCon24 and confirm the task list for that. » |
| 16:00 | Done, but I should also sent to the general list | |
| 16:01 | #action tcohen To schedule/call a "CSRF day" to work on related patches together (previously deferred until after the 22.11 release). | |
| 16:01 | #action tcohen To draft proposal for master→main change and draft of action list (previously deferred until after the 22.11 release). | |
| 16:01 | «oleonard ashimema: Draft in the developer handbook how to form our modals. With template of a simple case and a case with form inside. Update: focus is currently on staff interface redesign changes, see the draft style guide: https://annuel.framapad.org/p/[…]-styleguide-draft (previously deferred until after the 22.11 release).» | |
| 16:01 | Anything on this? | |
| 16:03 | #action oleonard ashimema Draft in the developer handbook how to form our modals. With template of a simple case and a case with form inside. Update: focus is currently on staff interface redesign changes, see the draft style guide: https://annuel.framapad.org/p/[…]-styleguide-draft (previously deferred until after the 22.11 release). | |
| 16:03 | #topic General development discussion (trends, ideas, ...) | |
| 16:04 | Use of Gitea: We use Gitea for git.koha-community.org. Gitea was "forked" and is now Forgejo[1] - see the links update and related links[2] (sounds eerily familiar 8-(.. ). The community needs to look at what to do next, such as whether to continue to use Gitea, update to Forgejo, do something else.... (David Nind) | |
| 16:04 | [1] https://forgejo.org/ | |
| 16:04 | [2] https://forgejo.org/2022-12-26-monthly-update | |
| 16:04 | ashimema | oop.. sorry.. |
| 16:04 | back now | |
| 16:06 | the ux guidelines are still moving forward slowly.. I need to grab oleonard and cait to discuss next steps | |
| 16:06 | it's something I'd like to get formalised at hackgest | |
| 16:07 | cait1 | we can try that - might also be good to get feedback on the new style sin general there |
| 16:07 | tuxayo: forgejo is the 'good' one? | |
| 16:07 | paulderscheid[m] | On that topic: Wouldn't it be useful to use somthing like penpot to visually formulate those guidelines in addition to written documentation? |
| 16:07 | tuxayo | cait1: that's what it looks like ^^ |
| 16:08 | ashimema | nice idea paulderscheid |
| 16:09 | paulderscheid[m] | open-source + self-hosted |
| 16:09 | cait1 | "After Gitea Ltd confirmed the takeover of the Gitea project on 30 October 2022, a group of people proposed that Codeberg e.V. should become the custodian of a fork of Gitea. The proposal was accepted 16 November 2022" - e.V. is a German thing actually |
| 16:09 | ashimema | be lovely to host a community one 😜 |
| 16:09 | cait1 | what is a penpot? :) |
| 16:09 | paulderscheid[m] | https://github.com/penpot/penpot |
| 16:10 | Maybe we can host some stuff with LMSCloud's resources. | |
| 16:10 | tuxayo | https://penpot.app |
| 16:11 | Added penpot mention in the styleguide draft | |
| 16:12 | Hopefully there is a public instance hanging somewhere to try how it fits us without needing to host immediately. | |
| 16:13 | paulderscheid[m] | There aren't really any alternatives, though. This is the only one I can think of, that really suits koha. |
| 16:14 | I mean, Figma is now part of Adobe. | |
| 16:16 | tuxayo | Thanks for the hint paulderscheid and we will keep in mind that LMSCloud can host stuff ^^ |
| 16:17 | Anything else relating the styleguide? | |
| 16:17 | And the trouble Gitea is going through. | |
| 16:17 | paulderscheid[m] | Short addition before changing topics: https://www.plasmic.app/ |
| 16:17 | tuxayo | I guess I can also forward it to koha-devel. |
| 16:17 | paulderscheid[m] | Just glanced at it, though. |
| 16:19 | tuxayo | paulderscheid: that would be another tool the graphically document the styleguide? |
| 16:19 | #action tuxayo forward to the Forgejo/Gitea news and question to koha-devel | |
| 16:19 | paulderscheid[m] | Ah, you can't self-host easily it seems. |
| 16:20 | Penpot is the only serious option, I think. | |
| 16:21 | tuxayo | s/forward to the/forward the |
| 16:22 | #topic Review of coding guidelines | |
| 16:22 | «SQL8 of our coding guidelines state that SQL should not be in .pl, but should be in the module in C4 or Koha. This would mean that SQL in the Koha namespace is allowed and there is no mention of DBIC in the coding guidelines right now. (Deferred from previous meeting(s).)» | |
| 16:23 | cait completed with: «The question is: Is it allowed to use SQL statements in .pm modules in the Koha namespace? » | |
| 16:23 | «The question here is if you can use SQL or if you should use dbic (not dbi) to make database queries. » | |
| 16:24 | cait1 | I think ashimema recently said on a bug we don't allow SQL in .pm in Koha |
| 16:24 | but I didn't find it in the coding guidelines | |
| 16:24 | I'd like to add it | |
| 16:24 | maybe as an addition to SQL 8? | |
| 16:25 | tuxayo | https://wiki.koha-community.or[…]Coding_Guidelines «Other than those 2 cases, all SQL must be in the C4/xxxx.pm or Koha/xxxx.pm (xxxx being the module your SQL refers to) » |
| 16:25 | cait1 | or Perl 20 |
| 16:25 | tuxayo | that don't go with «we don't allow SQL in .pm in Koha» ^^" |
| 16:25 | cait1 | PERL20 |
| 16:25 | ecaxtly | |
| 16:26 | ashimema | I could have swarn it was in the guidelines |
| 16:26 | dang.. my memory is bad then | |
| 16:26 | it sohuld be 😜 | |
| 16:26 | cait1 | I'd say it should be? |
| 16:26 | i think the problem was that I phrased my question strangely, noone got what I meant with that agenda item when i was not around :) | |
| 16:26 | so we could rewrite SQL8 | |
| 16:26 | ashimema | hehe |
| 16:26 | cait1 | and add a PERL20.2 |
| 16:26 | Joubu | there should be no raw sql, nowhere, isn't it what should be in the guidelines? |
| 16:26 | tuxayo | IIUC What is usually done with ORMs is that if there is SQL it can only be in the equivalent of our schema file. in the "custom section" |
| 16:27 | cait1 | Joubu: i'd like that, but maybe we need to explain about not addig any new SQL |
| 16:27 | because we stil have C4/reports | |
| 16:27 | Joubu | yes, no new of course |
| 16:27 | cait1 | I'dl ike something clearly spelled out to be able to point to it in QA of couse :) |
| 16:28 | hm and atomicupdates? | |
| 16:28 | i think they actually need to use SQL to work? | |
| 16:29 | tuxayo | Can we get away with not even needing to have a handcrafted SQL query in the DBIC schema files? |
| 16:29 | > hm and atomicupdates? | |
| 16:29 | Ah yes lol! | |
| 16:29 | Joubu | Just don't be strict and we are good |
| 16:29 | you can write SQL queries if it's easier, or the only way to do | |
| 16:30 | sometimes ORMs have limitations | |
| 16:30 | cait1 | that is not the clear line I was hoping for |
| 16:30 | Joubu | but most of the time we don't need them |
| 16:30 | cait1 | har dto tell sometimes when it's really neededor not |
| 16:30 | have we hit any restrictions that we could not get around yet with the ORM? | |
| 16:30 | Joubu | when you can do without, do without |
| 16:31 | cait1 | otherwise i'd say we require DBIC |
| 16:31 | tuxayo | (without SQL?) |
| 16:31 | Joubu | yes I remember writing some in a sub query or something |
| 16:31 | cait1 | and people need to argue when they want to use SQL |
| 16:31 | Joubu | or QA show them how to do without |
| 16:31 | I need to run, sorry. See you tomorrow | |
| 16:32 | tuxayo | > sometimes ORMs have limitations |
| 16:32 | > but most of the time we don't need them | |
| 16:32 | That's what I understood also. They all provide something like the section for custom queries that we have in our schema files. But it should be rarely used. | |
| 16:32 | thd | Joubu: Thanks for that clarificaton++ |
| 16:32 | tuxayo | thanks for the help Joubu , see ya |
| 16:32 | cait1 | so... how can we improve the coding guidelines? |
| 16:33 | right now we don't even mention dbic... | |
| 16:33 | khall_ joined #koha | |
| 16:34 | tuxayo | So in the end: no SQL by default except for database upgrades. But if it's not possible to do a query with the ORM or if it's much less readable or a performance bottleneck, then it should be done in a custom subroutine in the relevant DBIC schema class. |
| 16:35 | Does that makes sense? | |
| 16:35 | paulderscheid[m] | Yes |
| 16:35 | ashimema | "Wherever possible SQL::Abstract syntax should be used over raw SQL in the /Koha namespace" |
| 16:35 | with a link to 'https://metacpan.org/pod/SQL::[…]sic#WHERE-CLAUSES' | |
| 16:36 | hmm | |
| 16:36 | it find it pretty rare these days that I need to resort to raw SQL | |
| 16:36 | very occasionally a string ref within a abstract syntax | |
| 16:36 | \"" | |
| 16:36 | \\"" | |
| 16:37 | the advantages of doing it as SQL::Abstract are that DBIC understands it and can optimise things behind the scenes for you.. | |
| 16:39 | tuxayo | So SQL::Abstract is how to construct complex queries outside of the CRUD automatically provided by the ORM? |
| 16:40 | And without having to type raw SQL. | |
| 16:40 | ashimema | SQL::Abstract is the syntax for queries etc that DBIC is based on top of |
| 16:40 | lukeg joined #koha | |
| 16:40 | ashimema | it's the name for the dbic query structure |
| 16:42 | tuxayo | "Wherever possible SQL::Abstract syntax should be used over raw SQL in the /Koha namespace" |
| 16:42 | Should we also mandate that those queries are in custom subroutine in the DBIC modules? | |
| 16:43 | To isolate the logic of getting data. And be sure to not duplicate it. | |
| 16:44 | cait1 | ashimema++ thx |
| 16:46 | mtj | hi all |
| 16:46 | tuxayo | hi mtj ^^ |
| 16:47 | mtj | Joubu: perhaps some good news? .. i forgot to build a new 21.05 pkg |
| 16:48 | paulderscheid[m] | He had to go already |
| 16:48 | tuxayo | yes good news actually XD |
| 16:48 | cait1 | will you update the wiki? |
| 16:48 | tuxayo | #action tuxayo try to sum up ideas about guideline for SQL and sent to koha-devel for completion, rephrasing and terminology fixing. |
| 16:49 | ashimema | 🙂 |
| 16:49 | mtj | ..so current 21.05 pkg is still 21.05.21, from nov |
| 16:49 | ashimema | no worries |
| 16:49 | perhaps good | |
| 16:49 | thd | What is happening with channel logs? |
| 16:49 | mtj | i forgot 21.05 is now lTS |
| 16:49 | ashimema | I feel we should get the tests passing consistently everywhere and re-roll a package 😜 |
| 16:50 | tuxayo | > will you update the wiki? |
| 16:50 | The coding guidelines? | |
| 16:50 | wahanui | the coding guidelines is https://wiki.koha-community.or[…]Coding_Guidelines |
| 16:50 | tuxayo | > i forgot 21.05 is now lTS |
| 16:50 | mtj: It's not. It's just that we have enough volunteer that we can also maintain it. | |
| 16:50 | It's a bonus :) | |
| 16:51 | thd | Who maintains IRC channel logging? |
| 16:51 | cait1 | thd: the bot is getting kicked off - rangi was looking into it |
| 16:52 | reiveune left #koha | |
| 16:52 | tuxayo | thd: rangi and they where informed about the issue. |
| 16:52 | yes, what cait1 said | |
| 16:53 | Still the meetings are getting logged via another boot :) | |
| 16:53 | mtj | i have a backup of the channel logs, so we can rebuild them |
| 16:53 | thd | mtj++ |
| 16:53 | tuxayo | mtj: does [alohalog](https://matrix.to/#/@_oftc_alohalog:matrix.org) have them published somewhere? |
| 16:54 | #topic ACK pre vs post processing for background jobs | |
| 16:55 | cait1 | meeting is getting a little long'ish |
| 16:55 | tuxayo | Unless there are a few people here very inspired about that, let's defer it. |
| 16:55 | cait1 | should we try to wrap up? |
| 16:55 | actually i need to cook dinner :) | |
| 16:55 | tuxayo | here was the content if someone wants to add someone that I relay to the next meeting: |
| 16:55 | mtj | aah '22.11 will be the first official LTS Release. (Decision: Development IRC meeting 3 August 2022)' |
| 16:55 | tuxayo | «Bug 32573 - background_jobs_worker.pl should ACK a message before it forks and runs the job suggests we should ACK of STOMP messages before we begin processing which would avoid the issue 30 minute time issue among other problems. It appears that the STOMP documentation and the RabbitMQ documentation do not agree. We should have a vote if needed» |
| 16:55 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=32573 normal, P5 - low, ---, kyle, In Discussion , background_jobs_worker.pl should ACK a message before it forks and runs the job |
| 16:56 | tuxayo | #topic Set time of next meeting |
| 16:56 | for this timeslot: same hour the 8th february? | |
| 16:57 | paulderscheid[m] | 👍️ |
| 16:57 | cait1 | mtj: yes, we hope to keep that around for a long while :) |
| 16:57 | tuxayo | #info Next meeting: 25 January 2022, 23 UTC |
| 16:57 | mtj | backup logbot is https://ilbot3.kohaaloha.com/koha/ |
| 16:57 | tuxayo | that's for the other timeslot |
| 16:57 | cait1 | 8th shold be ok |
| 16:58 | tuxayo | mtj: thanks a lot, that can help when the other is down :) |
| 16:58 | mtj: can I add the link in the IRC_Regulars with alohalog` ? | |
| 16:59 | ######info Next next meeting: 8 February 2022, 15 UTC | |
| 16:59 | mtj | tuxayo: yes ok |
| 16:59 | tuxayo | #endmeeting |
| 16:59 | huginn | Meeting ended Wed Jan 11 16:59:20 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
| 16:59 | Minutes: https://meetings.koha-communit[…]-01-11-15.03.html | |
| 16:59 | Minutes (text): https://meetings.koha-communit[…]3-01-11-15.03.txt | |
| 16:59 | Log: https://meetings.koha-communit[…]11-15.03.log.html | |
| 16:59 | tuxayo | thanks all for the attendance ^^ |
| 16:59 | yay logs work! | |
| 17:04 | mtj: the search function is 2 times faster on your logs than on irc.koha-community.org ^^ | |
| 17:04 | I'll use that now :P | |
| 17:08 | mtj | i did find a solution to create 'private' builds for jenkins, to use for our SEC releases |
| 17:08 | tuxayo | Oh, yes forgot to announce! Hackfest in Marseille, France March, 27th - 31th! https://lists.koha-community.o[…]nuary/047486.html |
| 17:08 | cait1 | bye all |
| 17:08 | cait1 left #koha | |
| 17:09 | tuxayo | mtj++ |
| 17:09 | mtj | #info lets create 'private' builds for jenkins, to use for our SEC releases |
| 17:09 | tuxayo | (meeting ended) |
| 17:10 | mtj | tuxayo: greate news re hackfets! |
| 17:11 | tuxayo | That would be awesome, we struggle to be diligent to look at jenkins, but having all RMaints run the tests locally wasn't easy when in a past sec release I asked that we do that. |
| 17:12 | So having a private CI build would be a nice step! | |
| 17:23 | mtj | yes indeed, doing SEC releases without jenkins, is not much fun :/ |
| 17:30 | khall joined #koha | |
| 17:44 | khall_ joined #koha | |
| 18:12 | tcohen | hi all |
| 18:25 | lukeg | hi tcohen |
| 18:25 | kohalogbot joined #koha | |
| 18:55 | mary_ joined #koha | |
| 18:56 | mary_ | Hi I was wondering if anyone knew of a field and table that I can call on in SQL to show me the link to an item in the online public catalog? |
| 18:57 | cait[m] | you can bulid your links using the biblionumber or itemnumber |
| 18:57 | if you look at the reports library you will see how to do that | |
| 18:57 | reports library? | |
| 18:58 | there is w hole section with example v | |
| 18:58 | https://wiki.koha-community.or[…]rts_Library#Links | |
| 18:58 | mary_ | excellent thank you! =))) |
| 19:10 | thd joined #koha | |
| 20:13 | caroline | How do I identify the security bugs? I'm looking at https://koha-community.org/koh[…]2-05-08-released/ and it's not very clear which ones are the security ones... (can DM me if it's too sensitive for IRC logs) |
| 20:47 | lukeg joined #koha | |
| 20:55 | tcohen | tuxayo: around? |
| 21:01 | ashimema | . |
| 21:03 | tcohen | ashimema: thought you were out already |
| 21:03 | I've made a change to ktd | |
| 21:03 | git pull; ktd pull | |
| 21:03 | :-D | |
| 21:03 | ashimema | I am ;-) |
| 21:03 | tcohen | then don't |
| 21:03 | ashimema | Always here for you though tcohen |
| 21:04 | tcohen | I made a required change in ktd |
| 21:04 | first step into the right direction for devs | |
| 21:04 | ktd --shell now puts you in a instance shell | |
| 21:04 | and ktd --root --shell in a root shell | |
| 21:05 | and the instance user is a (passwordless) sudoer as well | |
| 21:06 | ashimema | Nice! |
| 21:06 | cait[m] | hm, wrong first step for me :) |
| 21:07 | now I will always need to escape form that shell | |
| 21:07 | can we make git bz work in there next? | |
| 21:07 | ashimema | Huh |
| 21:07 | cait[m] | git bz and git so don't work in instance shell |
| 21:07 | tcohen | cait[m]: you can ktd --root --shell |
| 21:07 | cait[m] | basiclaly everything i need :) |
| 21:07 | ashimema | I always do git bz outside of ktd entirely |
| 21:07 | tcohen | I can try |
| 21:07 | have a few minutes before leaving for vacation | |
| 21:08 | ashimema | Have a great vacation tcohen |
| 21:08 | paulderscheid[m] | tcohen: Very nice |
| 21:08 | cait[m] | yep :) enjoy and relax! |
| 21:09 | ashimema | Didn't running so and bz as the ktd root user cause the permissions issues in the first place cait |
| 21:09 | cait[m] | yes |
| 21:09 | tcohen | I want cookies |
| 21:09 | cait[m] | I already filed issues! |
| 21:09 | tcohen | in exchange |
| 21:09 | cait[m] | Marseille? :) |
| 21:10 | * tcohen | gets greedy when talking about cookies |
| 21:10 | tcohen | I'm pondering cait |
| 21:10 | ashimema | Cookies and Whisky on me in Marseille |
| 21:11 | tcohen | we'll sort it out, ashimema |
| 21:12 | jumped to 3g for the docker images download | |
| 21:12 | -.- | |
| 21:13 | * ashimema | has the fun of digging back into sandboxes again tomorrow.. getting rather bogged down with sandboxes these days.. they're such a time drain |
| 21:13 | ashimema | Hugs tcohen |
| 21:15 | cait[m] | Whisky... brrrr |
| 21:16 | ashimema | Gin then cait? |
| 21:16 | cait[m] | nah, I'll stick with the cookies |
| 21:16 | tcohen | I'd go for a german gin |
| 21:16 | cait[m] | maybe a ginger beer |
| 21:16 | tcohen | monkey 47 for the win |
| 21:17 | ashimema | Black valley gin was rather nice |
| 21:17 | tcohen | ohhh, haven't tried |
| 21:18 | ashimema | I'm off the booze for January as it happens.. got a couple of nice bottle for Christmas that are calling out to me... Feb isn't too far off though :) |
| 21:20 | cait[m] | booze would be easy... cookies on the other hand... |
| 21:23 | ashimema | https://www.waitrose.com/ecom/[…]901-625286-625287 |
| 21:23 | Looking forward to trying that one | |
| 21:23 | Hehe | |
| 21:27 | tcohen | I just got a Caol Ila bottle |
| 21:27 | giving islay a try | |
| 21:29 | so long, and thanks for all the fish | |
| 21:29 | tcohen out | |
| 21:30 | \o | |
| 21:30 | cait[m] | bye :) o/ |
| 21:33 | ashimema | Night night |
| 21:41 | tuxayo | hi again #koha |
| 21:42 | tcohen++ «ktd --shell now puts you in a instance shell» | |
| 21:51 | caroline | tcohen++ enjoy your vacation! |
| 21:54 | tuxayo | oh vacations :) enjoy tcohen ^^ |
| 21:54 | Wainui around? | |
| 23:00 | lukeg joined #koha |
← Previous day | Today | Next day → | Search | Index