← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:38 | dcook | Hmm looks like the new staff interface doesn't have "Help" anymore? |
| 01:47 | tuxayo | dcook: Which page? I see it |
| 01:47 | dcook | tuxayo: Every page? |
| 01:47 | Maybe I'm looking in the wrong spot | |
| 01:48 | tuxayo | In home page, checkout, search results |
| 01:48 | dcook: It's bellow the library selector | |
| 01:48 | dcook | tuxayo: I can see it on the home page |
| 01:48 | Ah maybe it's just on the new page... | |
| 01:49 | Another thing to add to the Failed QA for this issue.. :/ | |
| 01:49 | tuxayo | Good catch! |
| 01:49 | dcook | I've already got a huge list of problems. I don't know if I have the energy to go through every permutation.. |
| 01:49 | Already taken hours.. | |
| 01:49 | But for a good cause.. | |
| 01:51 | tuxayo | Drop the less important ones |
| 02:06 | dcook | They're all important hehe |
| 02:06 | But no you're right | |
| 02:06 | Some of the less important stuff.. doesn't matter if it works or not.. | |
| 02:10 | schnydszch joined #koha | |
| 02:14 | schnydszch | Good day! Has anyone experienced this: pwgen: invalid option -- 'r' |
| 02:14 | Usage: pwgen [ OPTIONS ] [ pw_length ] [ num_pw ] | |
| 02:14 | ? | |
| 02:18 | this is during koha-create | |
| 04:27 | Oak joined #koha | |
| 05:07 | schnydszch joined #koha | |
| 05:13 | eugene_ joined #koha | |
| 06:07 | marcelr joined #koha | |
| 06:08 | schnydszch joined #koha | |
| 06:08 | marcelr | davidnind++ |
| 06:08 | hi #koha | |
| 06:08 | inlibro++ | |
| 06:08 | anyone else i forgot? | |
| 06:14 | reiveune joined #koha | |
| 06:14 | reiveune | hello |
| 06:15 | Joubu | hi #koha :) |
| 06:17 | wiki update end of August? | |
| 06:27 | aravindiitd[m] joined #koha | |
| 06:29 | fridolin joined #koha | |
| 06:33 | rangi[m] joined #koha | |
| 06:37 | ashimema joined #koha | |
| 06:37 | ashimema | dcook++ |
| 06:46 | alex_ joined #koha | |
| 06:47 | alex_ | Bonjour |
| 06:47 | wahanui | hola, alex_ |
| 06:55 | cait joined #koha | |
| 06:55 | marcelr | hi Joubu |
| 06:55 | wahanui | hi Joubu are you around? |
| 06:57 | cait1 joined #koha | |
| 07:03 | marcelr | bug 31784 anyone? |
| 07:03 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=31784 normal, P5 - low, ---, m.de.rooy, Needs Signoff , SingleBranchMode ignores public flag |
| 07:26 | ashimema | Not too many sleepless nights I hope Joubu :-) |
| 07:27 | marcelr | discussion? bug 31786 |
| 07:27 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=31786 enhancement, P5 - low, ---, oleonard, NEW , Sub template->param($var) should return the value |
| 07:28 | Joubu | ashimema: trying to get used to it :D |
| 07:39 | eugene_ joined #koha | |
| 07:51 | eugene__ joined #koha | |
| 07:54 | marcelr | bug 31785 for qa_team? |
| 07:54 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=31785 major, P5 - low, ---, m.de.rooy, Signed Off , Adding a new library does not respect public flag |
| 07:54 | marcelr | one line |
| 07:56 | when call a field 'public', i already sense problems :) | |
| 07:56 | and when I see || undef, kind of the same | |
| 07:57 | davidnind[m] joined #koha | |
| 07:57 | davidnind[m] | Anyone with KTD running at the moment? Could you check if you can make a library private? (Administration > Libraries > edit > Change Public to 'No'). |
| 07:57 | marcelr | hi davidnind[m] i did :) |
| 07:57 | outside of ktd btw | |
| 07:57 | but in a docker container | |
| 07:58 | note the difference btw between new library and existing one | |
| 08:00 | tundunf joined #koha | |
| 08:00 | davidnind[m] | I can't make either a new library or an an existing library not public (also tried on a sandbox http://staff-publiclib.sandbox[…]ersolutions.com/) |
| 08:01 | marcelr | hmm is it on current master ? applied 31785? |
| 08:02 | davidnind[m] | Possible some other system preference affecting this... |
| 08:04 | on current master - with and without 31785 | |
| 08:04 | marcelr | i did a fetch, repeated for new and existing, and it works |
| 08:05 | let me try sandbox too | |
| 08:05 | davidnind[m] | you can use the one above - I haven't deleted it yet |
| 08:06 | MichaelaSieberBIB[m] joined #koha | |
| 08:06 | domm[m] joined #koha | |
| 08:06 | Lea[m] joined #koha | |
| 08:06 | KodoKorkalo[m] joined #koha | |
| 08:06 | mason[m] joined #koha | |
| 08:06 | paulderscheid[m] joined #koha | |
| 08:06 | SlackIntegration[m] joined #koha | |
| 08:06 | sushi[m] joined #koha | |
| 08:06 | tubaclarinet[m] joined #koha | |
| 08:06 | tuxayo joined #koha | |
| 08:06 | uhusiano[m] joined #koha | |
| 08:06 | MathewWood[m] joined #koha | |
| 08:06 | cait1 | hi MichaelaSieberBIB[m] ;) |
| 08:06 | marcelr | i see what you mean davidnind[m] |
| 08:06 | MichaelaSieberBIB[m] | Good morning :-) |
| 08:06 | marcelr | the library is added but not visible or so ? |
| 08:07 | davidnind[m] | If you add a new library and say No for public, it is ignored and stays as Yes. |
| 08:08 | For an existing library, you get a message "An error occurred when updating this library. Perhaps it already exists." and Public stays as 'Yes' | |
| 08:09 | marcelr | how can i see which patch is applied there? |
| 08:10 | davidnind[m] | it is just master - I didn't enter any bug number |
| 08:11 | marcelr | how can I add 31785 |
| 08:11 | i never use them :) | |
| 08:12 | davidnind[m] | Actions > Apply patches (or start a new one with that in the bug number field) |
| 08:12 | From the Sandbox page https://sandbox.bywatersolutions.com/ | |
| 08:13 | marcelr | ok i am addign one |
| 08:14 | please wait..provisioning | |
| 08:15 | davidnind[m] | takes a few minutes |
| 08:15 | marcelr | yeah |
| 08:15 | patience is one of my strong ponts | |
| 08:15 | points | |
| 08:15 | hmm | |
| 08:16 | davidnind[m] | 😄 |
| 08:18 | marcelr | davidnind it works with 31785 applied sandbox marceltest |
| 08:19 | https://staff-marceltest.sandb[…]admin/branches.pl | |
| 08:22 | fridolin1 joined #koha | |
| 08:29 | davidnind[m] | marcelr: if you change public to Yes, then try and change back to Ni, you can't (cant't change existing ones) |
| 08:39 | marcelr | davidnind[m]: i cant recreate that |
| 08:39 | tried on the sandbox | |
| 08:39 | Pascal joined #koha | |
| 08:40 | cait1 | could it be one of those mysql strict issues again? |
| 08:43 | davidnind[m] | marcelr: try with "David's library" (test2) on the sandbox you setup |
| 08:44 | Pascal | Hello together :) yesterday we tried for the first time to use the --where extension of membership_expiry.pl ( https://bugs.koha-community.or[…]_bug.cgi?id=28456 ). Using it for example with borrowernumber works, but when I use it the same way with the categorycode I always get an error. Although the categorycode actually exists. Can anyone here reproduce this error? |
| 08:46 | marcelr | davidnind[m]: ok, i see it |
| 08:46 | strange | |
| 08:46 | trying to reproduce it on my box now | |
| 08:48 | very weird: cannot recreate it on my box; so it is the sandbox ? | |
| 08:51 | davidnind[m] | and koha-testing-docker as well, I'll try in non-struct mode if I can remember how) |
| 08:52 | ashimema | this patron autocomplete thing is weird |
| 08:52 | davidnind[m] | should be able to work around signing of bug 31775 in the meantime |
| 08:52 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=31775 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Show opac_info of single library |
| 08:54 | marcelr | davidnind[m]: i suspect that the error has to do with the smtp stuff that is in the same try catch block |
| 08:54 | davidnind[m] | ashimema: when adding a patron to a patron list? |
| 08:54 | marcelr | i dont have smtp configured |
| 08:54 | cait1 | Pascal: what was the statement you used? |
| 08:54 | Pascal: and what was the error? | |
| 08:55 | davidnind[m] | marcelr: neither do I, but I'll add and see if that helps - can log a new bug otherwise |
| 08:56 | ashimema | Joubu.. do you understand the two different patron_autocomplete functions? |
| 08:56 | it feels like one was updated whilst the other wasn't | |
| 08:56 | marcelr | hmm doubts about smtp |
| 08:59 | davidnind[m]: i can reproduce it with strict sql mode now on my box | |
| 08:59 | step closer | |
| 08:59 | davidnind[m] | marcelr++ |
| 08:59 | marcelr | [2022/10/14 08:59:06] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'public' cannot be null at /usr/share/koha/Koha/Object.pm line 170 |
| 09:00 | closer | |
| 09:01 | Joubu | ashimema: cannot remember! |
| 09:02 | ashimema | thought that might be the case.. |
| 09:02 | no worries, I'll keep digging | |
| 09:02 | very confused at the minute.. but that's nothing unusual | |
| 09:02 | Joubu | patron-autocomplete.js is the one I added recently |
| 09:02 | Pascal | Hello cait1: The statement we used was "koha-foreach /usr/share/koha/bin/cronjobs/membership_expiry.pl -n -c -v --where="categorycode='STUD'" --before 120 --after 120" |
| 09:02 | Joubu | I guess the other one is something I forgot to replace and remove |
| 09:03 | but maybe the 3 searches from where it's used have something specific? | |
| 09:03 | Pascal | And the error we got was the following: getting upcoming membership expires at /usr/share/koha/bin/cronjobs/membership_expiry.pl line 187. No method count found for Koha::Patrons DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'categorycode' in where clause is ambiguous at /usr/share/koha/lib/Koha/Objects.pm line 578 at /usr/share/koha/bin/cronjobs/membership_expiry.pl line 199. |
| 09:03 | ashimema | indeed |
| 09:03 | cait1 | Pascal: looks right on first glance |
| 09:03 | ashimema | I'm digging a little deeper to try and get the history.. |
| 09:03 | though I could have swarn I tested that patron lists case.. | |
| 09:03 | oh well | |
| 09:03 | cait1 | Pascal: try making it borrowers.categorycode |
| 09:04 | the SQL error points to more than one table having categorycode, so you need tos pecifcy | |
| 09:08 | fridolin1 left #koha | |
| 09:11 | Pascal | cait1: Thank you I will try it! |
| 09:11 | marcelr | davidnind[m]: sorry for the confusion, but it should work now (follow-up patch) |
| 09:11 | the strict sql mode was the crux; thx cait++ | |
| 09:12 | schnydszch joined #koha | |
| 09:15 | Pascal | @cait1: Now i got a similar error: root koha2:~# koha-foreach /usr/share/koha/bin/cronjobs/membership_expiry.pl -n -c -v --where="borrowers.categorycode='STUD'" --before 120 --after 120 getting upcoming membership expires at /usr/share/koha/bin/cronjobs/membership_expiry.pl line 187. No method count found for Koha::Patrons DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'borrowers.categorycode' in |
| 09:16 | huginn` | Pascal: I'll give you the answer as soon as RDA is ready |
| 09:16 | wahanui | i already had it that way, huginn`. |
| 09:17 | davidnind[m] | Pascal: I tried an example (after changing a borrower to expire in 10 days in Staff (S) category) and got the same error |
| 09:23 | Joubu | Pascal: try 'me.categorycode' |
| 09:23 | davidnind[m] | paste bot not comming through, hopefully this is readable: https://paste.koha-community.org/16580 |
| 09:23 | cait1 | Joubu: thx :) |
| 09:23 | was going to look at the script | |
| 09:24 | davidnind[m] | For me, adding the "me" worked: perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="me.categorycode = 'S'" |
| 09:29 | marcelr | sounds like documenting or patching usage .. |
| 09:30 | Pascal | Can you explain me why we have to use me.categorycode in this case? I think it doesn't exists an 'me' table |
| 09:31 | And thank you so much for solving my issue! :) | |
| 09:31 | Maybe i can document it then :) | |
| 09:33 | cait1 | you can "name" tables in SQL |
| 09:34 | like you can do SELECT * from borrowers b and then b will refer to the table | |
| 09:34 | but it could also have to do with how DBIC works in this case (that someone else might be able to explain) | |
| 09:35 | or if you have a UNION for 2 different tables, you'd also 'name' the new table and can refer to it then - just saying the name doesn't have to exist as a table in the database | |
| 09:35 | Pascal | Oh nice this is really useful:) |
| 09:40 | Maybe Jobu can explain me if he has the time what specifically causes this Problem so it could be updated in the usage of the script :) | |
| 10:09 | marcelr | cu |
| 10:23 | oleonard | o/ |
| 10:34 | cait joined #koha | |
| 10:50 | schnydszch joined #koha | |
| 10:53 | schnydszch joined #koha | |
| 11:02 | eugene_ joined #koha | |
| 11:12 | tcohen | hola #koha o/ |
| 11:12 | oleonard | Hi tcohen |
| 11:13 | schnydszch joined #koha | |
| 11:15 | schnydszch joined #koha | |
| 11:16 | eugene_ joined #koha | |
| 11:22 | * cait | wave |
| 11:23 | cait | @later tell tcohen because there are no installtaoin instructions for docker compose 2 ;) |
| 11:23 | huginn` | cait: The operation succeeded. |
| 11:25 | alex_ joined #koha | |
| 11:36 | oleonard | I don't think folks are going to be happy until we revert the table style changes in the redesign. :( |
| 11:36 | I wish we could come up with something "new" | |
| 11:41 | tcohen | oleonard: are you suggesting jajm should produce a patch reverting it? |
| 11:41 | or is there a bug filed already for this? | |
| 11:42 | oleonard | I think we don't have a good solution at the moment. |
| 11:43 | jajm | what's wrong with the tables ? the lack of borders ? |
| 11:46 | oleonard | I think we've seen a lot of comments about the lack of borders being a problem. I'm not calling for any particular change, just highlighting something that I think is still a rough spot. |
| 11:49 | tcohen | cait I fixed the docker compose v2 install instructions link, hope that's enough |
| 11:52 | Joubu | I've noticed that the navigation is also weird for tables using DT, no idea if it has been reported already |
| 11:53 | tcohen | Joubu! |
| 11:53 | THE Joubu! | |
| 11:53 | wahanui | the joubu is starting to brew again |
| 11:54 | Joubu | hopefully, wahanui |
| 11:54 | wahanui | Joubu: excuse me? |
| 12:05 | cait1 | oleonard-away: but have there been new comments? I mean since it was pushed? |
| 12:26 | oleonard | cait1: Maybe I'm just worrying. |
| 12:32 | cait joined #koha | |
| 12:33 | cait1 | oleonard: maybe :) |
| 12:47 | tcohen: thx :) | |
| 13:03 | oleonard | Datatable search broken on the libraries admin page |
| 13:06 | Joubu | Something went wrong when loading the table. |
| 13:06 | 200: OK | |
| 13:06 | OK but something went wrong..? | |
| 13:07 | there you click and there is a 500 | |
| 13:07 | DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.opac_info' in 'where clause' | |
| 13:07 | is that what you see? | |
| 13:08 | oleonard | Joubu: When I type in the DataTable "search" box at the top of the libraries admin table list I get this error in the console: Uncaught TypeError: col.data.split is not a function |
| 13:08 | Joubu | hum, forget that, I was in the middle of an bad state |
| 13:09 | cait1 | Joubu: are you back? |
| 13:09 | Joubu | yes, I think so! |
| 13:10 | cait1 | confetti! |
| 13:10 | wahanui | o/`'`'`'`'`'`'`'`'`'`'`'` |
| 13:18 | Joubu | oleonard: did you open a bug report already? |
| 13:18 | oleonard | No, would you like me to? |
| 13:19 | Joubu | I know why it's crashing, not how to fix it |
| 13:19 | I can add it on the original bug | |
| 13:19 | oleonard | Okay |
| 13:22 | Joubu | oleonard: I've added a comment on bug 29144 |
| 13:22 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29144 enhancement, P5 - low, ---, m.de.rooy, Pushed to master , Move branches.opac_info to AdditionalContents allowing multi language |
| 13:28 | drbone joined #koha | |
| 14:08 | lukeg1 | hi |
| 14:24 | schnydszch joined #koha | |
| 14:31 | oleonard | Hi lukeg1 |
| 14:31 | Joubu | Is it only me, or the "New" button looks like a grey/disabled button? |
| 14:31 | https://snipboard.io/CNS7Bu.jpg | |
| 14:32 | caroline | Joubu, I noticed that too. I figure it was still a WIP |
| 14:33 | oleonard | It was a deliberate design choice in the original work |
| 14:33 | https://docs.google.com/presen[…]Vy0/edit#slide=id.g1155f3a071f_0_161 | |
| 14:34 | But I don't think the design took into account the possibility of a similar kind of button which might be disabled | |
| 14:34 | caroline | a "no button" button design |
| 14:35 | cait1 | I have to admit i don't like the grey on the toolbars |
| 14:35 | I had opened an issue for that too | |
| 14:35 | they are kinda harder to read and don't stand out as things you can do on the page | |
| 14:35 | i'd love if we could discuss making the action easier to spot on apage | |
| 14:36 | lukeg1 | cait1: I very much agree |
| 14:36 | oleonard | The emphasis is deliberately removed from them because the focus is supposed to be on the content of the page |
| 14:36 | (my understanding of the design intention) | |
| 14:36 | cait1 | yeah, but i am not sure that will work |
| 14:36 | ashimema | lol.. |
| 14:37 | caroline | I think you're right oleonard https://docs.google.com/presen[…]Vy0/edit#slide=id.g1155f3a071f_0_116 |
| 14:37 | cait1 | they look inactive and they are neither links nor buttons |
| 14:37 | ashimema | Koha is an action heavy application.. so hiding the actions to highlight the content is a somewhat strange design choice |
| 14:37 | cait1 | I was even wondering how to write the manual |
| 14:38 | my ktd up seems to be stuck at this, but no error, has somebody seen that? koha-db-1 | Version: '10.5.17-MariaDB-1:10.5.17+maria~ubu2004' socket: '/run/mysqld/mysqld.sock' port: 3306 mariadb.org binary distribution | |
| 14:38 | ashimema | please, please, please look at the tree of bugs hanging off of https://bugs.koha-community.or[…]_bug.cgi?id=30952 now.. comment on one's you agree with, want changes on and add any other things you think about |
| 14:38 | huginn` | Bug 30952: enhancement, P5 - low, ---, julian.maurice, Pushed to master , New design for staff interface |
| 14:38 | cait1 | Ill try to |
| 14:39 | ashimema | my big push to get it pushed was exactly to get this sort of feedback from a wider group.. |
| 14:39 | cait1 | just still way behind from being away most of this week |
| 14:39 | but yep, we need more voices overall | |
| 14:39 | koha-koha-1 | Cannnot open file No such file or directory at /kohadevbox/misc4dev/cp_debian_files.pl line 35 < and that here ? | |
| 14:39 | ashimema | without it being forced into peoples faces it doesn't matter how much we ask for feedback.. we just weren't getting it 😜 |
| 14:39 | oleonard | Yup, not even with me begging them to look at it with me at KohaCon |
| 14:39 | * ashimema | realises that sounded rude.. |
| 14:40 | caroline | it's a good idea ashimema |
| 14:40 | Other than some screenshots oleonard shared, I hadn't interacted with it until yesterday | |
| 14:40 | ashimema | wasn't meant to be.. more that.. we have more hands on deck now.. we can get things fixed 🙂 |
| 14:40 | hence the current mission going on to add 'page-section' to things.. the current debate on 'flat vs 3d vs mixed' | |
| 14:40 | I'm hopefull we'll have those sorted fairly quick.. | |
| 14:41 | lukeg1 | Now that it is in master it is much easier for us all to work on. |
| 14:41 | ashimema | toolbars is another keen one I want to resolve as a team |
| 14:41 | exactly 🙂 | |
| 14:41 | iterate quick peeps 🙂 | |
| 14:42 | which reminds me.. more reviews on bug 31762 would be awesome.. | |
| 14:42 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=31762 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Flat vs 3D or Mixed |
| 14:42 | ashimema | and a QA on it's dependancy |
| 14:43 | my proposal isn't the only solution.. just one I felt looked half reasonable as a starting point. | |
| 14:44 | 'flatten everything' has been the direction of travel so I took that approach. | |
| 14:44 | Joubu | cait1: do you see $KOHA_SRC/debian/koha-common.install ? |
| 14:45 | cait1 | where exactly? |
| 14:45 | Joubu | echo $KOHA_SRC/debian/koha-common.install |
| 14:45 | ls $KOHA_SRC/debian/koha-common.install | |
| 14:45 | cait1 | and thx for trying to help, just a little lost - will follow instructions :) |
| 14:45 | /debian/koha-common.install | |
| 14:45 | for the echo | |
| 14:46 | Joubu | no, it's missing the koha root dir |
| 14:46 | cait1 | so $KOHA_SRC might not be set? |
| 14:46 | ok, where does it get that from? | |
| 14:46 | oleonard | If anyone wants to test drive a "pills" tab design, I've added a patch to Bug 31759. Note that it depends on Bug 30487 because I was looking at circ and patron details. |
| 14:46 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=31759 enhancement, P5 - low, ---, koha-bugs, NEW , Tabs vs Pills |
| 14:46 | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30487 enhancement, P5 - low, ---, oleonard, Signed Off , Convert checkout and patron details page tabs to Bootstrap | |
| 14:46 | cait1 | and I am outsidie in the host now |
| 14:47 | Joubu | or is it $SYNC_REPO |
| 14:47 | sorry it's $SYNC_REPO | |
| 14:47 | cait1 | i'll echo taht then |
| 14:48 | interesting | |
| 14:48 | it has koha, but it shoudl be Koha | |
| 14:48 | I am trying something | |
| 14:49 | ashimema | oleonard++ |
| 14:49 | thanks | |
| 14:49 | cait1 | Joubu: I've taken the simpler route... renaming my repo |
| 14:49 | I didn't set that one up and the K was annyoing me anyway | |
| 14:50 | ashimema | can we get a guideline on alert positioning too.. |
| 14:50 | we have a mix of above the toolbar, between the toolbar and the header, below the toolbar and any other random place.. | |
| 14:50 | Joubu | ashimema: are there screenshots to compare the "Flat vs 3D or Mixed" suggestions? |
| 14:51 | ashimema | I think there might be a screenshot in the github issue.. but not of what I've done.. |
| 14:52 | all I did was take the drop shadows away.. | |
| 14:52 | cait1 | Joubu++ |
| 14:52 | oleonard | I think that this is another example of where the original design intended to guide focus to the main content of the page. |
| 14:52 | cait1 | missed you :) |
| 14:52 | my koha is running again and I can use the ktd comamnds now | |
| 14:58 | cait joined #koha | |
| 15:01 | Joubu | \o/ |
| 15:01 | ashimema | woop, woop |
| 15:03 | oleonard | If we do make toolbar buttons more button-like I think we should try going back to right-aligned: https://snipboard.io/WztIbE.jpg |
| 15:04 | caroline | Do we sometimes have disabled buttons? I wonder how different they would look |
| 15:04 | Joubu | same but left-aligned? :D |
| 15:05 | oleonard | I don't think we ever have disabled buttons in the main toolbar but I could be wrong. |
| 15:06 | caroline | I don't remember any instance either, but my memory is not great for that kind of thing (for anything really) |
| 15:07 | Joubu | oleonard: on catalogue/detail, do you see "remove from cart" even if not in cart? |
| 15:08 | oleonard | Yes |
| 15:08 | caroline | The only greyed out / disabled thing I remember is the "Summary" check box in the messaging preferences, if you don't select a message transport type |
| 15:09 | ashimema | I can't seem to apply bug_30487 oleonard |
| 15:09 | Joubu | bug 31803 |
| 15:09 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=31803 normal, P5 - low, ---, koha-bugs, NEW , "remove from cart" button displayed even if not in cart |
| 15:09 | ashimema | I ended up liking the right aligned too oleonard |
| 15:10 | but Katrin pushed back when i mentioned it.. | |
| 15:10 | Joubu | it's way to far on wide screens |
| 15:10 | ashimema | I think just right aligning them actually helps with their focus.. even if we don't push them to being more button like |
| 15:10 | lukeg1 | I am in the 'left aligned' camp :) |
| 15:10 | * ashimema | has a wide screen and didn't really worry so much... they were much clearer once I started adding page-sections to pages. |
| 15:11 | ashimema | fair enough.. |
| 15:13 | got it to apply | |
| 15:15 | cait1 | For the translators: Strings on Pootle have been updated |
| 15:18 | reiveune | bye |
| 15:18 | reiveune left #koha | |
| 15:19 | emlam joined #koha | |
| 16:15 | cait1 left #koha | |
| 16:34 | lukeg joined #koha | |
| 16:43 | PedroAmorimAmmo[m] joined #koha | |
| 16:46 | pamorim joined #koha | |
| 17:01 | cait joined #koha | |
| 18:01 | lukeg joined #koha | |
| 18:06 | cait | lukeg: can we please have bug 31351 backported? I was wondering, are you working from master git logs or do you use another system? |
| 18:06 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=31351 major, P5 - low, ---, stalkernoid, Pushed to master , Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars |
| 19:01 | lukeg joined #koha | |
| 19:03 | lukeg | cait: i will backport 31351 this afternoon! |
| 19:04 | I do work from the master gitlog | |
| 19:21 | caroline | It's so nice to build the manual and not have a million warnings! Thanks again cait++ and davidnind++ |
| 19:22 | cait | lukeg: was just wondering as this seemed to have slipped through if we could improve process somehow, thx for the quick response! |
| 19:22 | caroline++ :) | |
| 19:22 | true teamwork there | |
| 19:23 | davidnind[m] | caroline++ |
| 19:23 | for figuring out how to fix it! | |
| 19:24 | lukeg | cait: it is not that is slipped through, it is just that I have been fighting to catch up with Tomas and the master branch. |
| 19:25 | Im doing my best to catch up | |
| 19:28 | cait | it's ok, was not sure where you are currently at |
| 19:28 | wonder if there was some way to give some precedence to the bad bugs... like highlighting them | |
| 19:28 | if there is... something we coudl do... | |
| 19:29 | caroline | davidnind[m], oops sorry, I clicked one button too many and merged my own submission... |
| 19:29 | davidnind[m] | caroline: no problem! |
| 19:29 | caroline | That's what happens when you just blindly click 'Next' |
| 19:31 | davidnind[m] | 😀 |
| 19:32 | lukeg | cait: Yes, it would be nice if there was a better way. Right now I rely on people telling me backport bad bugs |
| 19:35 | cait | so the thing is... you'll get to them in time, but you are behind abit and if we want to ensure priority push, better get in touch :) what's your preferred way of communication? |
| 19:37 | lukeg: ^ | |
| 19:38 | lukeg: bug 31673 is another pretty urgent one | |
| 19:38 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=31673 blocker, P5 - low, ---, nick, Pushed to master , DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint |
| 19:38 | cait | blocks update |
| 19:40 | lukeg | noted, I will get it in today |
| 19:42 | cait: preferred method of communication is email. ( lucasbywatersolutions.com ) |
|
| 19:43 | caroline | maybe you could use the priority levels? |
| 19:44 | that last one is 'blocker', but the priority is P5-low | |
| 19:50 | cait | i was thinking maybe the keywords |
| 19:51 | lukeg: what that work for you? we can set rel_22_05_candidate for urgent ones | |
| 19:51 | so every time you push, you check these out first | |
| 19:51 | just working through this week's bug mail as I've been gone a few days, so might find some more | |
| 19:53 | lukeg | cait: that will work for me. I will start to check rel_22_05_candidate when I begin a push session for 22.05.x |
| 19:53 | cait++ | |
| 19:53 | cait | great :) I'll quickly check what else is in there before adding more |
| 19:56 | caroline | In Reports > Statistics wizards, the 'Filter' column... Do you think 'Filter' is meant as a noun (a filter) or a verb (to filter)? |
| 20:00 | cait | hm |
| 20:00 | it kinda works as both there i guess | |
| 20:00 | davidnind[m] | tricky! |
| 20:00 | cait | but maybe noun? |
| 20:01 | I feel like a noun might work better as it's a table column header | |
| 20:01 | caroline | I wanted to add context to the marc-overlay-rules page, because there it's clearly used as a noun and in French it looks really weird |
| 20:02 | cait | thx for doing these changes btw |
| 20:02 | it often overlaps with German problems | |
| 20:04 | caroline | I always feel selfish doing this, but I'm glad it helps other languages too :) |
| 20:05 | davidnind[m] | according to dictionary.com for a verb, you would need an object, such as filter by period or filter by item type https://www.dictionary.com/browse/filter |
| 20:06 | but it could be a noun as well... | |
| 20:06 | with English, where used to so much ambiguity and get away without being so precise! | |
| 20:08 | my grammar is not the greatest, so would go with what makes better sense for translation | |
| 20:08 | caroline | I would go the lazy way and just add the noun context for marc-overlay-rules and leave the rest as is... |
| 20:52 | @later tell oleonard I found an instance of a disabled button https://snipboard.io/8RpBoe.jpg (the Close basket button is unavailable because I have uncertain prices in my basket) | |
| 20:52 | huginn` | caroline: The operation succeeded. |
| 20:53 | caroline | Not sure what you all think, if it's different enough from the other ones |
| 21:18 | cait | nope |
| 21:18 | I am not happy with toolbar as whole yet | |
| 21:19 | I think one part is... it's links/actions just looking like text | |
| 22:40 | lukeg | davidnid[m]: Can you recreate this? https://bugs.koha-community.or[…]_bug.cgi?id=31808 |
| 22:40 | huginn` | Bug 31808: enhancement, P5 - low, ---, koha-bugs, NEW , When placing a hold patron name is not displaying correctly |
| 22:52 | davidnind[m] | lukeg: yes, I'm see that as well - tested on both Firefox and Google Chrome |
| 22:53 | lukeg | Thanks, I was looking at your page-section bug for this page when I noticed it. Confirming I'm not crazy :) |
| 22:55 | davidnind[m] | lukeg++ (not crazy) |
| 23:46 | schnydszch joined #koha |
← Previous day | Today | Next day → | Search | Index
