← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:04 | koha-jenkins | Project Koha_Master_D11_MDB_Latest build #832: STILL UNSTABLE in 56 min: https://jenkins.koha-community[…]1_MDB_Latest/832/ |
| 00:13 | ibeardslee left #koha | |
| 00:38 | AndrewFH joined #koha | |
| 01:57 | koha-jenkins | Project Koha_19.11_U16 build #135: SUCCESS in 26 min: https://jenkins.koha-community[…]ha_19.11_U16/135/ |
| 02:00 | Project Koha_19.11_U21 build #29: SUCCESS in 31 min: https://jenkins.koha-community[…]oha_19.11_U21/29/ | |
| 02:11 | Project Koha_19.11_D11 build #37: SUCCESS in 42 min: https://jenkins.koha-community[…]oha_19.11_D11/37/ | |
| 02:13 | Project Koha_19.11_U18 build #369: SUCCESS in 43 min: https://jenkins.koha-community[…]ha_19.11_U18/369/ | |
| 02:18 | Project Koha_19.11_D10 build #227: SUCCESS in 50 min: https://jenkins.koha-community[…]ha_19.11_D10/227/ | |
| 02:19 | Project Koha_19.11_D8 build #454: SUCCESS in 22 min: https://jenkins.koha-community[…]oha_19.11_D8/454/ | |
| 02:23 | alohabot | 🎁 🐙 Koha '19.11.x' packages pushed to 'koha-staging' repo 🍝🍒🥒 |
| 02:31 | koha-jenkins | Project Koha_19.11_D9 build #406: SUCCESS in 31 min: https://jenkins.koha-community[…]oha_19.11_D9/406/ |
| 02:43 | mtj | hi tcohen, the json-val package has the correct version, for me |
| 02:44 | pastebot | "mtj" at 127.0.0.1 pasted "json-val 5.07" (37 lines) at https://paste.koha-community.org/8368 |
| 02:46 | mtj | perhaps you have a cpan'd version that is conflicting? (just a guess) |
| 02:47 | koha-jenkins | Project Koha_19.11_D9 build #407: SUCCESS in 27 min: https://jenkins.koha-community[…]oha_19.11_D9/407/ |
| 02:51 | Project Koha_19.11_U20 build #280: SUCCESS in 37 min: https://jenkins.koha-community[…]ha_19.11_U20/280/ | |
| 02:55 | Project Koha_19.11_U_Stable build #77: SUCCESS in 44 min: https://jenkins.koha-community[…]9.11_U_Stable/77/ | |
| 03:11 | mtj | tcohen: can you paste the same commands? ^^ |
| 04:22 | alohabot | 🎁 🐙 Koha '20.11.x' packages pushed to 'koha-staging' repo 🍝🍧🍱 |
| 04:22 | koha-jenkins | Project Koha_20.11_U_Stable build #95: SUCCESS in 31 min: https://jenkins.koha-community[…]0.11_U_Stable/95/ |
| 04:33 | Project Koha_20.11_U18 build #193: SUCCESS in 40 min: https://jenkins.koha-community[…]ha_20.11_U18/193/ | |
| 04:44 | Project Koha_20.11_U21 build #44: SUCCESS in 53 min: https://jenkins.koha-community[…]oha_20.11_U21/44/ | |
| 04:52 | Project Koha_20.11_D10 build #204: SUCCESS in 30 min: https://jenkins.koha-community[…]ha_20.11_D10/204/ | |
| 04:56 | Project Koha_20.11_D11 build #233: UNSTABLE in 1 hr 1 min: https://jenkins.koha-community[…]ha_20.11_D11/233/ | |
| 04:58 | Project Koha_20.11_U16 build #172: SUCCESS in 1 hr 7 min: https://jenkins.koha-community[…]ha_20.11_U16/172/ | |
| 05:16 | Project Koha_20.11_U20 build #207: UNSTABLE in 43 min: https://jenkins.koha-community[…]ha_20.11_U20/207/ | |
| 05:22 | Project Koha_20.11_D10 build #205: SUCCESS in 30 min: https://jenkins.koha-community[…]ha_20.11_D10/205/ | |
| 05:37 | JBoyer joined #koha | |
| 05:42 | koha-jenkins | Project Koha_20.11_D9 build #198: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_20.11_D9/198/ |
| 05:46 | Yippee, build fixed! | |
| 05:46 | wahanui | Congratulations! |
| 05:46 | koha-jenkins | Project Koha_20.11_U20 build #208: FIXED in 47 min: https://jenkins.koha-community[…]ha_20.11_U20/208/ |
| 06:57 | udkoha joined #koha | |
| 07:12 | alex_a joined #koha | |
| 07:13 | alex_a | Bonjour |
| 07:13 | wahanui | what's up, alex_a |
| 07:31 | fridolin1 joined #koha | |
| 07:33 | mtj | tcohen++, i tested bug 30194.. it looks graet 👁👄👁 |
| 07:33 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30194 enhancement, P5 - low, ---, tomascohen, Signed Off , Update required JSON::Validator version |
| 07:34 | marcelr joined #koha | |
| 07:34 | marcelr | hi #koha |
| 07:36 | Joubu | @later tell fridolin dbrevs still not synced, see last email |
| 07:36 | huginn | Joubu: The operation succeeded. |
| 07:37 | marcelr | Joubu i need your help on Auth a little bit |
| 07:38 | 29915 follow-up | |
| 07:39 | reiveune joined #koha | |
| 07:39 | reiveune | hello |
| 07:40 | marcelr | fridolin1 |
| 07:41 | Joubu | marcelr: I will have a look |
| 07:42 | marcelr | great |
| 07:42 | i dont understand why I didnt see this earlier | |
| 07:44 | note also the subtle change between passing emptry string and undefined | |
| 07:44 | fridolin1 | Joubu: arf "dbrevs still not synced", with kohastrcture you mean ? |
| 07:44 | marcelr | fridolin1: hi |
| 07:44 | fridolin1 | hi everyone |
| 07:44 | marcelr | i still have another patch on bug 29915 |
| 07:45 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29915 major, P5 - low, ---, jonathan.druart+koha, Pushed to stable , Anonymous session generates 1 new session ID per hit |
| 07:45 | marcelr | which midhg need your attention soon |
| 07:45 | Joubu is looking now | |
| 07:45 | the last patch | |
| 07:45 | midhg = might | |
| 07:45 | alex_a joined #koha | |
| 07:54 | Joubu | fridolin1: see my last email, I sent you the steps to recreate the difff |
| 07:59 | fridolin1 | yep on it |
| 08:00 | cait joined #koha | |
| 08:01 | fridolin1 | arf ok "ALTER TABLE branchtransfers MODIFY COLUMN reason" in DVREv, in kohastructure there is this change also on "cancellation_reason" |
| 08:01 | Joubu: any idea who is correct ? kohastrcuture or DBRev | |
| 08:02 | marcelr | cancellation_reason belongs to article_requests fridolin1 |
| 08:03 | fridolin1 | ah indeed looks like there is no need to add recalls on it |
| 08:04 | cait1 joined #koha | |
| 08:05 | Joubu | I haven't looked at it |
| 08:07 | marcelr: we are talking about branchtransfers.cancellation_reason here | |
| 08:09 | fridolin1: looks like dbrev is missing the change to this column | |
| 08:09 | marcelr | ok |
| 08:10 | Joubu | that's one reason I said yesterday we shouldn't get rid of kohastructure.sql, most of the time the problems are in the atomic update |
| 08:10 | fridolin1 | indeed |
| 08:11 | Joubu | fridolin1: 53aa7b523b27b6b18e8c7147d34ad5276072bcf0 |
| 08:11 | kohastructure modifies the 2 columns of branchtransfers | |
| 08:12 | but bug_19532-add_recalls_enum_branchtransfers.perl was modifying only 'reason' | |
| 08:12 | lds joined #koha | |
| 08:14 | fridolin1 | ahhh ok the dbic is not an alias, it uses kohastructure.sql |
| 08:14 | good to know | |
| 08:14 | Joubu | `dbic` is making sure your dbic schema files will be synced with the current kohastructure, yes |
| 08:21 | fridolin1 | looking at code does not seem possible to set recall in cancelation_reason |
| 08:21 | maybe DBRev is correct | |
| 08:28 | marcelr | Joubu think there is a bug too in Auth.t |
| 08:28 | around line 551 | |
| 08:29 | we should clear userid and password cgi params | |
| 08:29 | ashimema | morning |
| 08:29 | marcelr | hi ashimema |
| 08:30 | git mv Auth.pm BrainDamage.pm | |
| 08:30 | ashimema | lol |
| 08:30 | I spent hours digging into auth.pm yesterday and came out with a headache and the bug still existing ☹️ | |
| 08:31 | Joubu | what was the bug, ashimema? |
| 08:31 | marcelr: not on it yet ;) | |
| 08:31 | ashimema | I think it's a local thing |
| 08:32 | we have a package install on 20.11 and one instance gets into an auth loop if the user doesn't have a certain permission | |
| 08:32 | but I can't for the life of me work out why | |
| 08:32 | you log in.. all seems fine.. you click to any other page.. it logs you out | |
| 08:33 | not reported it yet as I can't replicate it anywhere else.. and it seems especially odd that only this tenant is suffering whilst all the others on there are working fine. | |
| 08:33 | must be data related somehow or something. | |
| 08:43 | marcelr | Joubu added an adjustment to Auth.t now |
| 08:43 | cait1 | ashimema: check the self check permissions |
| 08:44 | a normal staff user should not have thse | |
| 08:53 | Axelle joined #koha | |
| 09:03 | ashimema | It's manage_sysprefs |
| 09:03 | If that's missing | |
| 09:08 | cait joined #koha | |
| 09:14 | cait1 joined #koha | |
| 09:31 | marcelr | Joubu: I updated 29957 too for your kind consideration :) |
| 09:40 | Joubu | we should clear the language cookie imo |
| 09:47 | marcelr | not making it an exception you mean |
| 09:47 | ? | |
| 09:51 | Joubu | yes |
| 09:51 | Did you run the selenium tests from 28786? | |
| 09:53 | marcelr | I dont have selenium sorry |
| 09:53 | Joubu | If I understand correctly you are clearing the cookies on explicit logout only |
| 09:54 | we need a clear_session sub that will ->delete and ->flush the session AND clear the cookies | |
| 09:54 | marcelr | yes just as in the first patch |
| 09:54 | Joubu | don't you thin? |
| 09:54 | marcelr | one change at a time ? |
| 09:55 | when you do want to clear the cookies also? | |
| 09:55 | Joubu | when the session is deleted |
| 09:55 | marcelr | note btw that the change on bug 29915 has more priority |
| 09:55 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29915 major, P5 - low, ---, jonathan.druart+koha, ASSIGNED , Anonymous session generates 1 new session ID per hit |
| 09:56 | marcelr | i could have a look at that Joubu on 29957 |
| 09:56 | will put it Assigned again | |
| 09:56 | and change the initial koha-conf setting | |
| 09:56 | wahanui | marcelr: that doesn't look right |
| 09:56 | wahanui joined #koha | |
| 09:56 | Joubu | I am actually reviewing that bug, on top of your 29915 follow-up |
| 09:57 | marcelr | wahanui is always right |
| 09:57 | ok | |
| 09:58 | Joubu | marcelr: so why did you comment the ->flush call in 89b9c441faf862aa1c5c7b8420c15fe8e9afcbd2 ?? :) |
| 09:59 | marcelr | i added that line while testing then commented it and tested further, and now i am testing again and still think i'd better uncomment it |
| 10:01 | + # $session->flush; was a harmless addition :) | |
| 10:01 | Joubu | it shouldn't be needed to flush |
| 10:01 | after a ->new.. | |
| 10:02 | marcelr | well I am not really sure about it |
| 10:02 | Joubu | however we are missing a flush in check_api_auth.. |
| 10:02 | marcelr | CGI::Session troubles |
| 10:02 | which line | |
| 10:03 | Joubu | "Always explicitly calling flush() on the session before the program exits is recommended. For extra safety, call it immediately after every important session update." |
| 10:03 | well, that's for another bug... :D | |
| 10:03 | but I would remove the flush call after new | |
| 10:03 | it shouldn't be needed | |
| 10:03 | marcelr | how do you read "Update" ? |
| 10:03 | Joubu | and if it does we need to understand why |
| 10:04 | $session->param('key', $value) | |
| 10:04 | marcelr | an insert is an update of the table etc |
| 10:09 | i will submit him again without the flush | |
| 10:09 | Joubu | marcelr: select count(*) from sessions; run |
| 10:09 | use C4::Auth qw( get_session ); | |
| 10:09 | get_session; | |
| 10:09 | then count again | |
| 10:10 | with and without the flush | |
| 10:10 | same behaviour => +1 row in the table | |
| 10:10 | => flush is useless | |
| 10:10 | marcelr | yes i tested without flush now |
| 10:11 | - # $session->flush; + # no need to flush here | |
| 10:13 | * Joubu | rebasing bug 28786 for the 10th times |
| 10:13 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=28786 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Two-factor authentication for staff client - TOTP |
| 10:13 | fridolin1 left #koha | |
| 10:14 | marcelr | o no fridolin left already :) |
| 10:14 | we needed some pushing.. | |
| 10:17 | updated the last patch on 29957 too now | |
| 10:25 | Joubu | bad news, selenium tests from 28786 are failing... |
| 10:25 | can be a rebase issue | |
| 10:25 | I am tired of those auth patches | |
| 10:25 | really | |
| 10:29 | marcelr | yeah but i would like that 29915 followup to not wait on all the rest actually |
| 10:30 | Joubu | yes but I need to make sure it does not break tests :) |
| 10:31 | remember, the plan was not to rewrite the whole C4::Auth and find 42 critical bugs before the new 2FA enhancement was pushed :D | |
| 10:31 | marcelr | its Koha |
| 10:32 | its a small fix, and i have tested it now 100x | |
| 10:32 | ashimema | is tochen travelling now? |
| 10:32 | he's usually about by this time | |
| 10:36 | Joubu | ashimema: no yet |
| 10:36 | ashimema | okies |
| 10:57 | AndrewFH joined #koha | |
| 11:01 | marcelr | brb |
| 11:42 | Joubu | ashimema: did you "auto generate" the yaml for your patch "Simply OpenAPI Specification"? |
| 11:42 | ashimema | for the swagger.yaml I di |
| 11:42 | s/di/did/ | |
| 11:43 | I used your little script (adding in parameters) on the spec I'd come up with.. | |
| 11:43 | so it got ordered nicely | |
| 11:43 | so definitions, paths and parameters blocks should all be nicely sorted | |
| 11:45 | Joubu | I think we should apply the scrip to all the yaml files |
| 11:46 | we are going to modify all of them anyway, maybe a good time to uniformize that? | |
| 12:05 | enkidu joined #koha | |
| 12:19 | tcohen | hola #koha |
| 12:19 | ashimema++ | |
| 12:20 | Joubu++ | |
| 12:20 | mtj++ | |
| 12:32 | Joubu, ashimema do you think we could need to use our objects.search helper outside the OpenAPI plugin? | |
| 12:33 | i.e. that we might make use of it in other kind of paths | |
| 12:33 | ashimema | hmm.. I doubt it right now |
| 12:33 | * ashimema | considers for a moment |
| 12:33 | tcohen | the current Objects.t failures are due to the fact Mojolicious can return a hashref or an arrayref |
| 12:33 | depending on the arity | |
| 12:34 | marcelr joined #koha | |
| 12:34 | marcelr | o/ |
| 12:34 | tcohen | but objects.search expects an arrayref for the q parameter |
| 12:34 | because the spec was tought it is a 'multi' | |
| 12:35 | Objects.t tests the helper without going through the OpenAPI plugin | |
| 12:35 | and thus fails | |
| 12:35 | one fix is to add an empty 'extra q' | |
| 12:35 | marcelr | Joubu how do we get 29915 now further (only) ? |
| 12:35 | tcohen | another fix is answer 'yes' to my question, then expand objects.search further... |
| 12:36 | marcelr | nobody says no tcohen |
| 12:36 | but yes is something different :) | |
| 12:36 | tcohen | have you booked for Marseille marcelr? |
| 12:36 | hahaha | |
| 12:36 | marcelr | no luck |
| 12:37 | i was never out of my village ;) | |
| 12:38 | tcohen | so we need a hackfest at the Rijksmuseum |
| 12:38 | marcelr | Joubu it was already pushed to stable |
| 12:38 | yes definitely tcohen | |
| 12:38 | i should get somebody to organize it | |
| 12:38 | oleonard | I would love that |
| 12:40 | ashimema | +1 |
| 12:40 | * ashimema | loves marseille, but wouldn't mind a rotating euro hackfest |
| 12:41 | ashimema | wouldn't mind a non-euro one either.. but it gets more expensive and thus harder to build the business case for the purse holder |
| 12:42 | Joubu | marcelr: I am on it |
| 12:42 | it's a nightmare | |
| 12:43 | marcelr | 29915 isnt, maybe the rest ? |
| 12:43 | Joubu | C4::Auth is a nightmare, 29915 and the rest |
| 12:43 | I cannot PQA it until I understand what's going on in further patches | |
| 12:43 | and why the tests are failing | |
| 12:43 | marcelr | selenium tests only? |
| 12:44 | Joubu | no |
| 12:44 | I am on it :) | |
| 12:44 | marcelr | ok |
| 12:44 | good to hear | |
| 12:44 | khall around? | |
| 12:44 | Joubu | it's getting the login page whereas it's logged in |
| 12:45 | so a refresh displays the mainpage | |
| 12:45 | something going wrong with the get_session call | |
| 12:45 | and lasttime | |
| 12:45 | marcelr | where exactly, which patches are applied (the whole bunch)? |
| 12:46 | ashimema | ooh, ooh |
| 12:46 | that's exactly the symptom I had on my 21.11 I was talking about earlier | |
| 12:46 | marcelr | i would recommend to do one report at the time |
| 12:47 | Joubu | If you want me to PQA your follow-up I need to understand what's going on |
| 12:47 | if you want it PQA now, ask somebody else :) | |
| 12:47 | marcelr | no youre the one ! |
| 12:47 | just thinking that looking at one patch is easier than 30 together :) | |
| 12:48 | i would not mind to push 2FA before the cookies one | |
| 12:49 | i love rebasing hahaha | |
| 12:50 | Joubu | The thing is... I checked out a 3 months old local branch, and 2FA was broken already on it... Which is pretty weird as I run the tests every time I rebase... |
| 12:50 | So I dont' have a working 2FA tree right now to compare | |
| 12:52 | marcelr | me neither, but i will check your rebase :) |
| 12:52 | Joubu | is a new session supposed to have lasttime? |
| 12:53 | I am getting "expired" from check_cookie_auth when the form is submitted | |
| 12:53 | marcelr | $session->param( 'lasttime', time() ); |
| 12:53 | i guess so | |
| 12:54 | tcohen | qa_team |
| 12:54 | ashimema | that is literally the exact place I got stuck yesterday Joubu |
| 12:54 | tcohen | two follow-ups added to bug 30165, chose your favourite |
| 12:55 | ashimema | lasttime not being set yet |
| 12:55 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30165 major, P5 - low, ---, tomascohen, Pushed to master , Several q parameters break the filters |
| 12:55 | Joubu | ashimema: where you testing 2FA? |
| 12:55 | ashimema | nope |
| 12:55 | this was on a vanilla 21.11.02 | |
| 12:55 | package install | |
| 12:55 | marcelr | its another thing i guess |
| 12:55 | Joubu | ashimema: so without 29915?! |
| 12:55 | marcelr | like you already suspected |
| 12:55 | ashimema | yup |
| 12:56 | Joubu | I am gonna ignore this information for now :D |
| 12:56 | ashimema | that's fair |
| 12:56 | I just find it surprising | |
| 12:57 | tcohen | Joubu: 30172 doesn't apply |
| 12:57 | ashimema | you could verify it's not the same issue if you like.. by giving your user 'manage_sysprefs' permission |
| 12:57 | that solves it.. | |
| 12:57 | but of course.. the customer doesn't want all staff to have that perm | |
| 12:57 | marcelr | lol |
| 12:57 | exciting | |
| 13:06 | enkidu joined #koha | |
| 13:32 | udkoha | hi all - I just have another koha-testing-docker question |
| 13:32 | with "kp" the database should stay persistent - BUT - we get Database is not empty! at /kohadevbox/misc4dev/populate_db.pl line 101 | |
| 13:33 | line 101: is if ( $prefs_count or $patrons_count ) { die(..) } and of course this is true | |
| 13:33 | is there a workaround? | |
| 13:34 | Joubu | no |
| 13:34 | well yes, you can dump then reinject the DB once the container is up | |
| 13:36 | udkoha | yes - I know that this would be a solution; perhaps omitting the populate.pl call would be another way to make "kp" work correctly - or are there any other side effects? |
| 13:36 | khall_ joined #koha | |
| 13:38 | marcelr | hi khall: keep your eye on a followup for 29915 |
| 13:38 | Joubu | @later tell fridolin 29915 - only the last patch is needed |
| 13:38 | huginn | Joubu: The operation succeeded. |
| 13:39 | marcelr | Joubu you attached the wrong version |
| 13:39 | there is the flush back in | |
| 13:40 | i replaced it already | |
| 13:40 | Joubu | oops, thanks! |
| 13:40 | marcelr | thx Joubu++ |
| 13:44 | Joubu | and the selenium are still passing with this version (I had to check, just in case..) |
| 13:46 | marcelr | passing_tests++ |
| 13:47 | we lost your signoff now on 29915 Joubu ? | |
| 13:48 | on the patch at least | |
| 13:49 | Joubu | I forgot to :x my editor when attaching the patch... |
| 13:50 | marcelr | thx |
| 13:51 | Joubu | ashimema: Is the removal of $validate correct here? https://bugs.koha-community.or[…]ent.cgi?id=132152 |
| 13:51 | marcelr | Joubu did you still put cookies in between before 2FA ? |
| 13:53 | Joubu | marcelr: yes! |
| 13:53 | marcelr: I pushed to a remote branch - https://gitlab.com/joubu/Koha/-/commits/bug_28786 | |
| 13:53 | for the rebase in 6 months | |
| 13:53 | marcelr | hahaha |
| 13:54 | AndrewFH joined #koha | |
| 13:54 | khall joined #koha | |
| 13:58 | marcelr | khall did you see my line about 29915 |
| 13:59 | apparently not | |
| 14:03 | theminh joined #koha | |
| 14:04 | theminh | Hi! When I am running the QA tool, the spelling check seems to be skipped: |
| 14:04 | OKKoha/DiscreteCalendar.pm OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK valid | |
| 14:05 | Does anyone knows why it is skipped ? | |
| 14:05 | Joubu | install codespell |
| 14:06 | udkoha: I don't know, you can try. Note that there is an entry in the config to use the different misc4dev repo/branch | |
| 14:06 | DEBUG_GIT_REPO_MISC4DEV=no | |
| 14:06 | DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/koha-commun[…]koha-misc4dev.git | |
| 14:06 | DEBUG_GIT_REPO_MISC4DEV_BRANCH=master | |
| 14:07 | you could return early in populate.pl and see how it behaves | |
| 14:10 | theminh | Thank you:) |
| 14:17 | Joubu | marcelr: all the koha-conf entries can be passed to koha-create |
| 14:19 | lukeg joined #koha | |
| 14:31 | marcelr | yeah but we decided to comment them all ? |
| 14:39 | Joubu: i dont see koha-create supporting ALL entries only selected ones | |
| 14:40 | Joubu | certainly some are missing.. |
| 14:40 | marcelr | quite a few |
| 14:41 | but if that is a new requirement, i could have a look | |
| 14:42 | unwritten rules are the best' | |
| 14:43 | koha-create --keep-cookie A --keep-cookie B | |
| 14:43 | ashimema | yes Joubu, it was intentional tidy up.. but I forgot to mention it in the commit message |
| 14:44 | khall_ joined #koha | |
| 14:44 | ashimema | if you look at the prior patches, Tomas slightly alters the signature of spec_ok so you no longer need to pass validate |
| 14:44 | marcelr | cu later |
| 14:44 | Joubu | ashimema: is the spec for plugins still validated? |
| 14:44 | ashimema | yup |
| 14:44 | Joubu | k |
| 14:45 | ashimema | I tested against the tests and a couple of plugins 🙂 |
| 14:45 | it's validated above here on a first run that includes all plugins.. and if that fails we then validate each plugin separately still 🙂 | |
| 14:49 | bug 29810 does my head in | |
| 14:49 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29810 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Add embed options documentation |
| 14:49 | ashimema | I think I've found collectionFormat still doesn't work at the header level :(* |
| 14:49 | reporting upstream | |
| 14:49 | I was so looking forward to that working | |
| 15:09 | khall joined #koha | |
| 15:21 | * oleonard | engraves "I was so looking forward to that working" on his own headstone |
| 15:22 | udkoha | Joubu: thanks for your good idea - we already talked to create our own container with more bash aliasses etc. etc. :-) |
| 15:27 | Joubu | if you have a fix for kp, please share it with us! :) |
| 15:28 | It shouldn't be hard but most of us just don't care much about the DB data for dev testing | |
| 15:28 | ashimema | indeed |
| 15:47 | * oleonard | much prefers using his own DB data for testing because it's more complete |
| 16:16 | JesseM_ joined #koha | |
| 16:25 | alex_a joined #koha | |
| 16:46 | cait1 left #koha | |
| 16:52 | cait joined #koha | |
| 16:57 | koha-jenkins | Project Koha_21.11_U_Stable build #53: SUCCESS in 34 min: https://jenkins.koha-community[…]1.11_U_Stable/53/ |
| 17:04 | Project Koha_21.11_U20 build #47: SUCCESS in 41 min: https://jenkins.koha-community[…]oha_21.11_U20/47/ | |
| 17:09 | reiveune | bye |
| 17:09 | reiveune left #koha | |
| 17:13 | AndrewFH joined #koha | |
| 17:15 | koha-jenkins | Project Koha_21.11_D10 build #63: SUCCESS in 50 min: https://jenkins.koha-community[…]oha_21.11_D10/63/ |
| 17:16 | alohabot | 🎁 🐨 Koha '21.11.x' packages pushed to 'koha-staging' repo 🍎🥪🧀 |
| 17:19 | rauf joined #koha | |
| 17:20 | rauf | anything method to customize patron form??? |
| 17:25 | oleonard | rauf: You can use system preferences to change which fields are required and which are hidden |
| 17:28 | koha-jenkins | Project Koha_21.11_U18 build #52: SUCCESS in 1 hr 3 min: https://jenkins.koha-community[…]oha_21.11_U18/52/ |
| 17:32 | oleonard | Whoops, missed that I missed 'em. |
| 17:32 | koha-jenkins | Project Koha_21.11_U21 build #44: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_21.11_U21/44/ |
| 17:32 | Project Koha_21.11_D11 build #66: STILL UNSTABLE in 1 hr 9 min: https://jenkins.koha-community[…]oha_21.11_D11/66/ | |
| 17:38 | * ashimema | clocks off having doubled his PQA count in the last hour |
| 17:38 | ashimema | have a good one #koha |
| 17:47 | koha-jenkins | Project Koha_21.11_D9 build #44: SUCCESS in 43 min: https://jenkins.koha-community[…]Koha_21.11_D9/44/ |
| 18:04 | Project Koha_21.05_D10 build #248: SUCCESS in 32 min: https://jenkins.koha-community[…]ha_21.05_D10/248/ | |
| 18:10 | JBoyer joined #koha | |
| 18:14 | AndrewFH joined #koha | |
| 18:15 | alohabot | 🎁 🐮 Koha '21.11.x' packages pushed to 'koha-staging' repo 🥥🍝🍿 |
| 18:18 | koha-jenkins | Yippee, build fixed! |
| 18:18 | wahanui | Congratulations! |
| 18:18 | koha-jenkins | Project Koha_21.05_U20 build #178: FIXED in 49 min: https://jenkins.koha-community[…]ha_21.05_U20/178/ |
| 18:28 | alohabot | 🎁 😻 Koha '21.05.x' packages pushed to 'koha-staging' repo 🥘🥧🍨 |
| 18:29 | koha-jenkins | Project Koha_21.11_D12 build #41: SUCCESS in 1 hr 1 min: https://jenkins.koha-community[…]oha_21.11_D12/41/ |
| 18:30 | Project Koha_21.05_U16 build #177: UNSTABLE in 42 min: https://jenkins.koha-community[…]ha_21.05_U16/177/ | |
| 18:34 | tuxayo | ashimema++ |
| 18:35 | fridolin joined #koha | |
| 18:37 | koha-jenkins | Project Koha_21.05_U_Stable build #174: SUCCESS in 32 min: https://jenkins.koha-community[…].05_U_Stable/174/ |
| 19:13 | Project Koha_21.11_U21 build #45: SUCCESS in 43 min: https://jenkins.koha-community[…]oha_21.11_U21/45/ | |
| 19:16 | alohabot | 🎁 😻 Koha '21.11.x' packages pushed to 'koha-staging' repo 🍠🍈🍅 |
| 19:22 | koha-jenkins | Project Koha_21.05_D12 build #104: ABORTED in 53 min: https://jenkins.koha-community[…]ha_21.05_D12/104/ |
| 19:30 | Project Koha_21.05_D9 build #174: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]oha_21.05_D9/174/ | |
| 19:30 | alohabot | 🎁 🐻 Koha '21.05.x' packages pushed to 'koha-staging' repo 🥒🍧🍊 |
| 19:32 | fridolin | tuxayo: aourd ? |
| 19:32 | Bug 30296 is in 20.11.x ? | |
| 19:32 | tuxayo | fridolin: y |
| 19:32 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30296 normal, P5 - low, ---, jonathan.druart+koha, Passed QA , Correct path for cookie bibs_selected |
| 19:32 | koha-jenkins | Project Koha_21.05_U18 build #167: UNSTABLE in 1 hr 13 min: https://jenkins.koha-community[…]ha_21.05_U18/167/ |
| 19:33 | tuxayo | fridolin: I asked how it should be tested because I can't reproduc e |
| 19:34 | I had to dig the code and try to understand how is the code called. | |
| 19:35 | And I'm pretty sure I got my guess about user workflow wrong | |
| 19:36 | *got my guess wrong | |
| 19:37 | fridolin | tuxayo: mmm since it is passed QA you may juste test is does not break the bibs_selected feature |
| 19:43 | koha-jenkins | Project Koha_21.05_U20 build #179: UNSTABLE in 33 min: https://jenkins.koha-community[…]ha_21.05_U20/179/ |
| 19:51 | Project Koha_21.05_D10 build #249: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_21.05_D10/249/ | |
| 20:15 | nugged joined #koha | |
| 20:18 | koha-jenkins | Project Koha_21.11_D12 build #42: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_21.11_D12/42/ |
| 20:23 | Project Koha_21.11_U20 build #48: SUCCESS in 51 min: https://jenkins.koha-community[…]oha_21.11_U20/48/ | |
| 20:24 | Project Koha_21.05_D11 build #204: SUCCESS in 1 hr 1 min: https://jenkins.koha-community[…]ha_21.05_D11/204/ | |
| 20:33 | oleonard joined #koha | |
| 20:34 | koha-jenkins | Project Koha_21.11_D9 build #45: SUCCESS in 1 hr 3 min: https://jenkins.koha-community[…]Koha_21.11_D9/45/ |
| 20:36 | Project Koha_21.11_U_Stable build #54: SUCCESS in 44 min: https://jenkins.koha-community[…]1.11_U_Stable/54/ | |
| 20:51 | Project Koha_21.11_D10 build #64: UNSTABLE in 33 min: https://jenkins.koha-community[…]oha_21.11_D10/64/ | |
| 21:04 | cait joined #koha | |
| 21:04 | cait | hi all |
| 21:18 | koha-jenkins | Yippee, build fixed! |
| 21:18 | wahanui | Congratulations! |
| 21:18 | koha-jenkins | Project Koha_21.05_U18 build #168: FIXED in 42 min: https://jenkins.koha-community[…]ha_21.05_U18/168/ |
| 21:24 | Project Koha_21.05_D12 build #105: SUCCESS in 32 min: https://jenkins.koha-community[…]ha_21.05_D12/105/ | |
| 21:31 | Yippee, build fixed! | |
| 21:31 | wahanui | Congratulations! |
| 21:31 | koha-jenkins | Project Koha_21.11_D11 build #67: FIXED in 1 hr 7 min: https://jenkins.koha-community[…]oha_21.11_D11/67/ |
| 21:33 | Yippee, build fixed! | |
| 21:33 | wahanui | Congratulations! |
| 21:33 | koha-jenkins | Project Koha_21.05_U16 build #178: FIXED in 59 min: https://jenkins.koha-community[…]ha_21.05_U16/178/ |
| 21:39 | Project Koha_21.11_U18 build #53: SUCCESS in 1 hr 15 min: https://jenkins.koha-community[…]oha_21.11_U18/53/ | |
| 22:00 | Project Koha_21.05_U_Stable build #175: SUCCESS in 41 min: https://jenkins.koha-community[…].05_U_Stable/175/ | |
| 22:19 | tuxayo | cait: hi :) |
| 22:27 | cait | hello :) |
| 22:28 | koha-jenkins | Project Koha_21.05_D10 build #250: SUCCESS in 54 min: https://jenkins.koha-community[…]ha_21.05_D10/250/ |
| 22:32 | Project Koha_21.11_U20 build #49: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_21.11_U20/49/ | |
| 22:44 | Project Koha_21.11_D12 build #43: SUCCESS in 43 min: https://jenkins.koha-community[…]oha_21.11_D12/43/ | |
| 22:53 | Project Koha_21.05_D9 build #175: SUCCESS in 1 hr 13 min: https://jenkins.koha-community[…]oha_21.05_D9/175/ | |
| 23:09 | Project Koha_21.11_U18 build #54: SUCCESS in 37 min: https://jenkins.koha-community[…]oha_21.11_U18/54/ | |
| 23:10 | fridolin joined #koha | |
| 23:26 | koha-jenkins | Project Koha_21.05_U16 build #179: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_21.05_U16/179/ |
| 23:26 | Yippee, build fixed! | |
| 23:26 | wahanui | Congratulations! |
| 23:26 | koha-jenkins | Project Koha_21.11_D10 build #65: FIXED in 57 min: https://jenkins.koha-community[…]oha_21.11_D10/65/ |
| 23:43 | Project Koha_21.11_U_Stable build #55: SUCCESS in 34 min: https://jenkins.koha-community[…]1.11_U_Stable/55/ |
← Previous day | Today | Next day → | Search | Index