IRC log for #koha, 2022-02-15

← Previous day | Today | Next day → | Search | Index

All times shown according to UTC.

Time Nick Message
00:26 aleisha joined #koha
00:26 aleisha hi all! been a while :)
00:27 i'm looking for some help with analytic records/host items
04:19 koha-jenkins Project Koha_19.11_U21 build #10: UNSTABLE in 25 min: https://jenkins.koha-community[…]oha_19.11_U21/10/
04:24 alohabot 🎁 🦁 Koha '19.11.x' packages pushed to 'koha-staging' repo
04:27 koha-jenkins Project Koha_19.11_D9 build #393: UNSTABLE in 36 min: https://jenkins.koha-community[…]oha_19.11_D9/393/
04:28 Project Koha_19.11_U20 build #264: UNSTABLE in 37 min: https://jenkins.koha-community[…]ha_19.11_U20/264/
04:36 Project Koha_19.11_U_Stable build #67: UNSTABLE in 45 min: https://jenkins.koha-community[…]9.11_U_Stable/67/
04:44 Project Koha_19.11_D11 build #26: UNSTABLE in 24 min: https://jenkins.koha-community[…]oha_19.11_D11/26/
04:45 Project Koha_19.11_D10 build #213: UNSTABLE in 51 min: https://jenkins.koha-community[…]ha_19.11_D10/213/
04:52 Project Koha_19.11_D8 build #439: UNSTABLE in 25 min: https://jenkins.koha-community[…]oha_19.11_D8/439/
05:12 Project Koha_19.11_U16 build #118: UNSTABLE in 43 min: https://jenkins.koha-community[…]ha_19.11_U16/118/
05:12 Project Koha_19.11_U16 build #119: STILL UNSTABLE in 27 min: https://jenkins.koha-community[…]ha_19.11_U16/119/
05:21 Project Koha_19.11_U18 build #359: UNSTABLE in 44 min: https://jenkins.koha-community[…]ha_19.11_U18/359/
06:13 fridolin joined #koha
07:28 alex_a joined #koha
07:29 alex_a Bonjour
07:29 fridolin1 joined #koha
07:35 Joubu cait: about the git so warning, I sent an email to the list and updated the wiki page, some months ago
07:35 "Replace git-filter-branch with git-filter-repo
07:36 August 26th 2021
07:41 reiveune joined #koha
07:41 reiveune hello
07:52 lds joined #koha
07:57 MarkHofstetter1 joined #koha
07:59 cait joined #koha
08:00 magnuse \o/
08:03 cait1 joined #koha
08:07 huginn News from kohagit: Bug 26704: (follow-up) Rebase for bug 29785 <https://git.koha-community.org[…]c1757a7a1455a6fcd>
08:07 News from kohagit: Bug 28405: Add author for multi holds view <https://git.koha-community.org[…]f78c1b5116ee1b00f>
08:07 News from kohagit: Bug 29570: Simplify for loop <https://git.koha-community.org[…]e46709704092c9ac3>
08:07 News from kohagit: Bug 29570: Enable sorting orders by summary <https://git.koha-community.org[…]c2d45d91a73cef3a3>
08:07 News from kohagit: Bug 29570: Fix sorting orders by biblioitems columns <https://git.koha-community.org[…]0f45b55f5ee46fa32>
08:07 News from kohagit: Bug 29570: Regression tests <https://git.koha-community.org[…]c7c4d54284ce225ce>
08:07 News from kohagit: Bug 28576: Update the maximum size of an image. <https://git.koha-community.org[…]18920c82d591c79ee>
08:07 News from kohagit: Bug 28405: add author name to request.tt when it exists <https://git.koha-community.org[…]b82a258f74f1af4d6>
08:07 News from kohagit: Bug 26704: Unit tests <https://git.koha-community.org[…]2da69dfeccfb54fb3>
08:07 News from kohagit: Bug 29579: Show saved SQL report ID in database query <https://git.koha-community.org[…]4c766605556a9b0c3>
08:07 News from kohagit: Bug 29519: Allow resolution of claims return at checkin <https://git.koha-community.org[…]6a6fbb00506e31562>
08:07 News from kohagit: Bug 29515: Make title for HTML customizations optional <https://git.koha-community.org[…]98746e2fd9c5ce7af>
08:07 News from kohagit: Bug 28576: Add patron image in patron detail section does not specify image size... <https://git.koha-community.org[…]944ae393128637bf1>
08:07 News from kohagit: Bug 26704: Update Koha::Item to use Koha::Object::Messages <https://git.koha-community.org[…]7d3a1c0b0c3436ba8>
08:07 News from kohagit: Bug 24630: (follow-up 2) call number when singleBranchMode=1 <https://git.koha-community.org[…]e32a1b94f57a911a0>
08:07 News from kohagit: Bug 24630: (follow-up 1) fix indenting <https://git.koha-community.org[…]a262272b897f83a12>
08:07 News from kohagit: Bug 26257: Move translatable strings out of subscription-add.tt and into subscription... <https://git.koha-community.org[…]4583f0eb8d039ab62>
08:07 News from kohagit: Bug 24630: UNIMARC XSLT changes for bug 7611 <https://git.koha-community.org[…]fa35bf819c0a79a8c>
08:11 domm Is it possible to somehow separate different libraries/branches in one instance?
08:11 i.e. mount library A at one URL, and library B at another
08:12 without using different instances for each library/branch?
08:15 AnkeB joined #koha
08:18 Joubu domm: cannot remember exactly what is the trick but I know some are doing funky stuffs
08:18 like with the syspref IndependentBranches and env var OPAC_SEARCH_LIMIT
08:19 domm ok, thanks for that pointer, seems like a good entry-point :-)
08:23 marion joined #koha
08:32 alohabot 🎁 🐯 Koha 'master' packages pushed to 'koha-staging' repo ... 🍆 🍍 🌶
08:34 Joubu domm: https://wiki.koha-community.or[…]rfaces_by_URL_RFC
08:35 bug 3244
08:35 most of it is certainly obsolete, but you may find something more recent if you search for the correct keywords from there :)
08:38 Is bugz down?
08:41 I sent Chris an email
08:42 and ofc it's back now
08:43 koha-jenkins Project Koha_Master_D11_CPAN build #532: UNSTABLE in 35 min: https://jenkins.koha-community[…]ter_D11_CPAN/532/
08:45 domm Joubu: yeah, I found that RFC and we'll play around a bit with those suggestions - but as this doc is 10+ years old we're not too optimistic .. :-)
08:55 koha-jenkins Project Koha_Master_U21 build #89: UNSTABLE in 47 min: https://jenkins.koha-community[…]ha_Master_U21/89/
09:02 Project Koha_Master_D11_My8 build #746: UNSTABLE in 54 min: https://jenkins.koha-community[…]ster_D11_My8/746/
09:02 magnuse domm: you can have somewhat different OPACs for different libraries in one instance using this trick: https://wiki.koha-community.or[…]_in_Apache_config
09:03 we are using that actively
09:10 koha-jenkins Project Koha_Master_U_Stable build #378: UNSTABLE in 1 hr 3 min: https://jenkins.koha-community[…]ter_U_Stable/378/
09:22 Project Koha_Master build #1914: UNSTABLE in 1 hr 13 min: https://jenkins.koha-community[…]Koha_Master/1914/
09:22 Project Koha_Master_D9 build #1873: UNSTABLE in 39 min: https://jenkins.koha-community[…]a_Master_D9/1873/
09:36 ashimema indeed, we use the apache config override stuff too magnuse domm
09:36 there are some bugs to help improve things again for the migration from prefs to news too
09:37 would love to see those move forward a bit as it's a regression 😉
09:39 koha-jenkins Project Koha_Master_U20 build #301: UNSTABLE in 43 min: https://jenkins.koha-community[…]a_Master_U20/301/
09:40 cait1 foudn a real fun bug... or more my training participants did: bug 30106
09:41 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30106 major, P5 - low, ---, koha-bugs, NEW , Items silently moved to serial record without updating search index
09:41 cait1 koha silently changes the record an item is attached to and forgets about updating Zebra
09:42 * cait1 shakes in disgust
09:43 domm thanks ashimema & magnuse !
09:44 * ashimema just spotted the emoji chain in alohabot pushes..
09:44 giggles
09:53 koha-jenkins Project Koha_Master_D10 build #529: UNSTABLE in 50 min: https://jenkins.koha-community[…]a_Master_D10/529/
09:54 cait1 ashimema: maybe you could persuade domm to sign off on your waiting bug in QA queue
09:55 i'd be willing to move it to PQA with 2 sign-offs - I am really bad with Apache myself
09:58 koha-jenkins Project Koha_Master_D12 build #75: UNSTABLE in 35 min: https://jenkins.koha-community[…]ha_Master_D12/75/
10:14 tcohen good morning
10:24 alex_a joined #koha
10:25 koha-jenkins Project Koha_Master_D11_MDB_Latest build #795: UNSTABLE in 46 min: https://jenkins.koha-community[…]1_MDB_Latest/795/
10:33 Joubu oleonard: I am having trouble to make the sticky header working on the (rewritten) main patron search - bug 30063. If by chance you have some spare time, could you have a look?
10:33 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30063 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Make the main patron search use the /patrons REST API route
10:33 * fridolin1 will work tomorow on jenkin fails
10:35 Joubu fridolin1: I had the bad habit to fix jenkins, but it's not a RM task IMO. Authors should take their responsabilities and fix the failures their patches caused ;)
10:36 domm ashimema: which bug is it that cait1 mentioned needing signoff?
10:36 cait1 bug 28955
10:36 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=28955 major, P5 - low, ---, martin.renvoize, Signed Off , Add option to set default branch from Apache
10:37 cait1 it's in the area you were asking about and we could count Nick for QA if we get another outside QA team sign-off
10:38 fridolin1 Joubu: i learn a lot with those failures
10:39 see u tomorrow
10:40 tcohen bye fridolin
10:43 domm cait1: ok, I'll look into this when we start testing our branch setup
10:45 cait1 thx :)
10:53 * ashimema adds more details to https://wiki.koha-community.or[…]IP2_configuration
10:54 ashimema it certainly needs testing.. 🙂
10:54 It's a fun area
11:10 koha-jenkins Project Koha_Master_D11_MDB_Latest build #796: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]1_MDB_Latest/796/
11:10 Project Koha_Master_D9 build #1874: STILL UNSTABLE in 1 hr 17 min: https://jenkins.koha-community[…]a_Master_D9/1874/
11:26 cait joined #koha
11:27 oleonard Hi #koha
11:28 Joubu: "Patch failed at 0001 Bug 30093: Make patron search from request.pl use the REST API"
11:28 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30093 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Rewrite the patron search when placing a hold with the REST API route
11:29 Joubu oleonard: could you use the remote branch?
11:29 oleonard Yes
11:32 Joubu I'm getting JS errors when I do a patron search
11:41 Joubu what error do you get?
11:42 ashimema ooh.. I hadn't spotted 30093
11:42 * ashimema is still working through testing 30055
11:43 oleonard Uncaught ReferenceError: l is not defined ... member.pl:1882:13
11:43 Uncaught ReferenceError: $format_address is not defined ... member.pl 2120:37
11:43 Joubu maybe I forgot an include file :-/
11:44 hum nope, it's there
11:57 tcohen koha-plack --restart kohadev?
11:57 Joubu looks like a client-side error
12:05 AndrewFH joined #koha
12:28 marion joined #koha
12:28 ashimema Joubu still around?
12:30 Joubu yes
12:30 ashimema on bug 30055 you re-impliment the PatronDefaultFields stuff... awesome
12:30 but
12:30 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30055 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Rewrite some of the patron searches to make them use the REST API routes
12:30 ashimema why did you switch the '-or' to an '-and'
12:31 for me, that means the results now turn up zero..
12:31 Joubu I had trouble with that part :D
12:31 ashimema I think it should still be an '-or', just with it only being applied over the DefaultFields
12:31 hehe
12:31 I see
12:31 I'll have a play
12:31 Joubu I wrote that Friday before the weekend and at the time the results looked ok
12:32 ashimema ps, Once we've nailed it, we need to add the JSDoc documentation for this change in kohaTable 🙂
12:32 Joubu -or won't work
12:32 ashimema oh really?
12:32 why's that
12:32 Joubu In which case do you see wrong result?
12:32 ashimema I do
12:33 I'm still doing side by side testing with an existing site (with the same data set as my dev env)
12:33 I get zero results with 30055.. and that makes sense because the -and means we're looking for 'like %david' in all the fields.. not 'any' of the fields
12:35 Joubu if I search "d", I am seeing this:
12:36 {"-and":[[{"me.surname":{"like":"%d%"}},{"me.first​name":{"like":"%d%"}},{"me.othernames":{"like":"%d​%"}},{"me.cardnumber":{"like":"%d%"}},{"me.userid"​:{"like":"%d%"}},{"extended_attributes.value":{"li​ke":"%d%"},"extended_attributes.code":[]}],[]]
12:36 it's doing a or but in the -and
12:37 ashimema interesting
12:37 Joubu but please have a try, it gave me headache when I looked at it
12:37 the code in datatables.js is not trivial, and everything small change can have a big impact on the results
12:37 ashimema I see '{"-and":[{"-and":[{"me.surname":{"like":"%d%"}},{​"me.firstname":{"like":"%d%"}},{"me.othernames":{"​like":"%d%"}},{"me.cardnumber":{"like":"%d%"}},{"m​e.userid":{"like":"%d%"}},{"extended_attributes.va​lue":{"like":"%d%"},"extended_attributes.code":["A​CTIVEC","CAT1","COURSECODE","FACULTY","LOSTCARD","​NEWS","SMART","SRC","T_J_PAT","TEST"]}]},[]]}'
12:38 a double -and
12:38 my head hurts.. I'll grab a tea and ponder it.
12:38 I did some work on adding filter options to the kohaTable wrapper btw.. would love to see that come in some time.. no-one seems interested in them yet ☹️
12:38 i.e not like 'like' (contains)
12:39 Joubu which bug?
12:39 ashimema bug 29302 and bug 29422
12:39 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=29302 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , The dataTables Koha RESTful API wrapper should allow picking match type at the column level
12:39 Bug https://bugs.koha-community.or[…]_bug.cgi?id=29422 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Add additional match types to dataTables api wrapper
12:40 ashimema we should work out how to write unit tests for this js
12:41 hagud joined #koha
12:42 ashimema I must admit.. I've not played with the 'default_filters' stuff much at all.. you're on new ground there for me..
12:42 tcohen hola hagud
12:42 hagud good morning, we have configured koha with saml2 (shibboleth) but we can't see the option at koha-conf.xml for update user , anybody knows if is it possible to update users via shibbolet?
12:42 ashimema I'll have more of a play with it now
12:42 hagud hola tomas!
12:46 Joubu ashimema: I will provide selenium tests (maybe, later)
13:04 tcohen https://vimeo.com/237527670
13:07 AndrewFH joined #koha
13:08 ashimema interesting
13:19 tuxayo I knew I stumbled on Cypress before, on the same topic:
13:19 https://www.testim.io/blog/pup[…]ss-how-to-choose/
14:12 Dyrcona joined #koha
14:33 lukeg joined #koha
14:47 sodesvaux joined #koha
14:57 ashimema hmm, my brain hurts
14:58 Brooke joined #koha
15:00 ashimema Joubu.. I feel like 'additional_filters'/'default_filters' should always be 'ANDed' onto whatever search you have..
15:00 MarkHofstetter1 joined #koha
15:00 ashimema but..
15:00 you should be able to 'OR' inside that ANDed search
15:00 your logic seems slightly off to me.
15:01 I'm not entirely sure about passing functions into that default_filters param either.. I think I'd have build the default_filters/additional_filters block before passing it
15:02 Joubu ashimema: that's the whole trick, we need a function to get an up-to-date info
15:02 if you pass the value when DT is built, the value won't be updated
15:03 here we want to adjust the query depending on the value of the inputs
15:03 ashimema are we not mis-using the feature then?
15:03 'default_filters' feels like it's meant to be applied at instantiation of the table
15:03 and not changed after
15:04 I would expect to pass additional components to .search instead
15:04 Joubu call it "additional_filters" then :)
15:04 I am open to any better ideas
15:05 this way seemed flexible and easy to implement
15:05 ashimema ok.. well it doesn't help that default_filters isn't really documented in any meaningful way
15:06 or rather.. the documentation that is there states 'apply at table initialisation'
15:06 Joubu I admit that I hijacked the existing parameter, but it's to give it more flexibility
15:06 * ashimema thinks 'add_filters' should also be 'show_filter_row' for clarities sake
15:06 ashimema i get your reasoning now
15:06 Joubu agreed
15:06 ashimema but yeah
15:07 I kinda feel like having all three would be clearest
15:07 Joubu can you have an example filters that don't return the correct result set?
15:07 ashimema 'show_filter_row', 'add_filters', 'default_filters'
15:08 Joubu I would just rename default_fiters to additional_filters
15:08 ashimema with default_filters working as before, show_filter_row replacing the current 'add_filters' and an 'add_filters' for yours functional extra here
15:08 Joubu if it's a function it will be dynamic, otherwise it will be a constant value
15:08 ashimema ok.. the issue I have with this is that you can no longer just pass an arrayref as far as I can tell
15:14 Joey joined #koha
15:15 ashimema so what didn't work about using -or
15:15 I can't get any results with -and, but you said -or doesn't work for you
15:15 it only works with -or for me
15:15 Joubu cannot remember but it didn't built the correct query
15:15 there was a AND with the extended attributes
15:17 Joey Can I ask a question please?
15:18 questions* :)
15:18 Is this the place for that?
15:18 ashimema go for it Joey
15:19 Joubu.. the or works for me in all combinations I've tried here.. including extended attributes
15:19 they're nested
15:20 cait1 hm can maybe someone remind me which EDIfACT parts we support?
15:21 Joey Thanks for that ashimema. I'm trying to get this tool security approved for my organisation and want to run a few things by you that I can't find online anywhere. Firstly, when running this tool on a VM locally, does it report anything back to the Koha team?
15:21 cait1 ORDERS, QUOTES, INVOIC, ... somd kind of message?
15:22 Joey: there is a statistics tool, but you have to turn it on explicitly
15:23 Koha asks you to turn it on, but it's off by default. It's called Hea
15:23 Joey A statistics tool? OK so not on by default, what info does that capture out of curiosity?
15:23 cait1 https://hea.koha-community.org/
15:24 Joey Thanks Cait1
15:24 cait1 the settings are in the systempreferences and if you turn it on there is a section for giving information on locaton of branches for the map there
15:24 but it's all voluntary
15:24 optonal
15:25 Joey OK thanks- that makes sense.
15:25 Do you guys as a team have any incident response plans? In case Koha is compromised in any way?
15:25 cait1 yuo can also turn it off server side by deactivating the cronjob that runs for it once a month (if you want to make sure it's not activated unintentionally)
15:25 Joey Might be best
15:25 cait1 there is a workflow for security related bugs
15:26 and security releases
15:26 is that the kind of information you meant?
15:27 Joey That's something yes thanks but I was thinking more in terms of users data
15:27 However if its run on our VPC or locally, this shouldn't be an issue for you guys
15:28 Right?
15:31 Is this what you were referring to: https://koha-community.org/security/
15:40 cait1 Joey: yes, that's part of it
15:40 can you explain a bit more what else you are lookign for?
15:41 we probably have it, but i lack the terminology :)
15:42 Joey No worries! This is what I've been asked to get:
15:42 Does the provider have a clear incident response and patching system in place to remedy any publicly reported issues in their service, or libraries that the service makes use of?   The provider’s previous track record on this is a good metric to see how they will cope with any new issues.
15:48 caroline I think you're confusing the Koha community with the provider
15:48 The provider can be an external company or the library itself
15:48 The Koha community is not a provider
15:49 oleonard Joey: The community has a great track record for quickly addressing security issues and providing patches. It's up to the manager of your Koha instance to apply the patches in a timely manner.
15:51 Joey Ah OK understood, so we could manage this internally and have the desired person update the system regularly
15:51 oleonard Yes
15:52 Releases are done monthly and security releases are labeled as such
15:53 Joey Great thanks and lastly, will that provider also be responsible for the implementation of MFA/SSO?
15:57 oleonard The Koha community provides the code, the service provider provides the implementation.
15:59 Joey Thanks, sounds like common sense to me! Appreciate filling me in :)
16:00 bag joined #koha
16:00 domm Joey: If yor library doesn't want to / can provide support itself, take a look here: https://koha-community.org/sup[…]-support/country/
16:01 Joey Alright domm, I'll check with them but keep that link in mind!
16:02 Cheers!
16:02 reiveune bye
16:02 reiveune left #koha
16:03 Joubu it's reiveune o'clock
16:07 cait1 lol
16:07 I feel like it's cait o'clock too... but not quite ready to leave yet
16:08 oleonard: sad I'll miss the meeting tomorrow, but I am leading a workshop same time :(
16:08 Joubu oleonard: hey, thanks! I fixed the sticky header. Calling .show() in initComplete did the trick!
16:08 oleonard Oh good Joubu, glad to hear it
16:08 cait1: We'll make sure you get all the info
16:09 Joubu oleonard: I don't understand why we need it but it's working :D
16:09 oleonard I know it's short notice but I wanted to take advantage of the timing of the meeting
16:10 Joubu: Currently the search header is grouped with search results in terms of visibility.
16:11 Joubu: I do wish the order of the elements could be the same in the new version.
16:14 Joubu oleonard: I shoudn't change that
16:36 cait joined #koha
16:48 AndrewFH joined #koha
16:48 cait joined #koha
17:09 josef_moravec joined #koha
17:40 cait1 oleonard++ thx
17:40 cait1 left #koha
17:49 cait joined #koha
18:06 MarkHofstetter1 joined #koha
18:31 oleonard qa tool acting weird today... flagging template variables as spelling errors?
18:34 AndrewFH joined #koha
18:35 kivilahtio joined #koha
18:36 lari joined #koha
19:39 fridolin joined #koha
19:44 AndrewFH joined #koha
19:59 MarkHofstetter1 joined #koha
21:29 lukeg joined #koha
22:31 Eileen joined #koha
23:40 cait joined #koha

← Previous day | Today | Next day → | Search | Index

koha1