← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
Time | Nick | Message |
---|---|---|
00:00 | koha-jenkins | Project Koha_21.05_U21 build #47: STILL FAILING in 2 min 50 sec: https://jenkins.koha-community[…]oha_21.05_U21/47/ |
00:03 | Project Koha_21.05_D12 build #61: STILL FAILING in 3 min 1 sec: https://jenkins.koha-community[…]oha_21.05_D12/61/ | |
00:06 | Project Koha_Master_U21 build #53: STILL FAILING in 3 min 13 sec: https://jenkins.koha-community[…]ha_Master_U21/53/ | |
00:09 | Project Koha_Master_D11_CPAN build #499: STILL FAILING in 2 min 59 sec: https://jenkins.koha-community[…]ter_D11_CPAN/499/ | |
00:12 | Project Koha_21.05_D10 build #172: STILL FAILING in 2 min 46 sec: https://jenkins.koha-community[…]ha_21.05_D10/172/ | |
00:15 | Project Koha_Master build #1864: STILL FAILING in 2 min 47 sec: https://jenkins.koha-community[…]Koha_Master/1864/ | |
00:17 | Project Koha_21.05_U21 build #48: STILL FAILING in 2 min 49 sec: https://jenkins.koha-community[…]oha_21.05_U21/48/ | |
00:20 | Project Koha_21.05_D12 build #62: STILL FAILING in 2 min 49 sec: https://jenkins.koha-community[…]oha_21.05_D12/62/ | |
00:23 | Project Koha_Master_D11_CPAN build #500: STILL FAILING in 2 min 47 sec: https://jenkins.koha-community[…]ter_D11_CPAN/500/ | |
00:25 | fridolin joined #koha | |
00:26 | koha-jenkins | Project Koha_Master_U_Stable build #344: STILL UNSTABLE in 32 min: https://jenkins.koha-community[…]ter_U_Stable/344/ |
00:26 | Project Koha_Master_D11_My8 build #714: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]ster_D11_My8/714/ | |
00:26 | Project Koha_Master_U21 build #54: STILL FAILING in 2 min 49 sec: https://jenkins.koha-community[…]ha_Master_U21/54/ | |
00:29 | Project Koha_21.05_D10 build #173: STILL FAILING in 2 min 48 sec: https://jenkins.koha-community[…]ha_21.05_D10/173/ | |
00:32 | huginn` | News from kohagit: Revert "Bug 29403: Fix api/v1/patrons.t" <https://git.koha-community.org[…]46c84892455dd1ba8> |
00:32 | News from kohagit: Revert "Bug 29403: Match the whole string" <https://git.koha-community.org[…]a6f3842a3d879c3f5> | |
00:32 | News from kohagit: Revert "Bug 29403: Unit tests" <https://git.koha-community.org[…]3b31d83160d4880d6> | |
00:36 | mtj | hmm, i think jenkins is having a TGIF |
00:44 | bag | ha |
00:47 | koha-jenkins | Project Koha_Master_U20 build #267: NOW UNSTABLE in 55 min: https://jenkins.koha-community[…]a_Master_U20/267/ |
00:53 | Project Koha_Master_D9 build #1841: STILL UNSTABLE in 1 hr 0 min: https://jenkins.koha-community[…]a_Master_D9/1841/ | |
01:02 | Project Koha_Master_D11_MDB_Latest build #755: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]1_MDB_Latest/755/ | |
01:05 | Project Koha_Master_D9 build #1842: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]a_Master_D9/1842/ | |
01:08 | Yippee, build fixed! | |
01:08 | wahanui | Congratulations! |
01:08 | koha-jenkins | Project Koha_21.05_U21 build #49: FIXED in 41 min: https://jenkins.koha-community[…]oha_21.05_U21/49/ |
01:38 | Yippee, build fixed! | |
01:38 | wahanui | Congratulations! |
01:38 | koha-jenkins | Project Koha_21.05_U_Stable build #113: FIXED in 51 min: https://jenkins.koha-community[…].05_U_Stable/113/ |
01:47 | Yippee, build fixed! | |
01:47 | wahanui | Congratulations! |
01:47 | koha-jenkins | Project Koha_21.05_D12 build #63: FIXED in 53 min: https://jenkins.koha-community[…]oha_21.05_D12/63/ |
01:49 | AndrewFH joined #koha | |
01:50 | koha-jenkins | Yippee, build fixed! |
01:50 | wahanui | Congratulations! |
01:50 | koha-jenkins | Project Koha_Master_U21 build #55: FIXED in 42 min: https://jenkins.koha-community[…]ha_Master_U21/55/ |
01:53 | Yippee, build fixed! | |
01:53 | wahanui | Congratulations! |
01:53 | koha-jenkins | Project Koha_Master_D11_CPAN build #501: FIXED in 50 min: https://jenkins.koha-community[…]ter_D11_CPAN/501/ |
01:54 | jzairo joined #koha | |
02:14 | koha-jenkins | Yippee, build fixed! |
02:14 | wahanui | Congratulations! |
02:14 | koha-jenkins | Project Koha_Master_U_Stable build #345: FIXED in 33 min: https://jenkins.koha-community[…]ter_U_Stable/345/ |
02:29 | Project Koha_Master_D10 build #496: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]a_Master_D10/496/ | |
02:33 | Yippee, build fixed! | |
02:33 | wahanui | Congratulations! |
02:33 | koha-jenkins | Project Koha_Master_D9 build #1843: FIXED in 43 min: https://jenkins.koha-community[…]a_Master_D9/1843/ |
02:45 | Yippee, build fixed! | |
02:45 | wahanui | Congratulations! |
02:45 | koha-jenkins | Project Koha_Master_D12 build #49: FIXED in 51 min: https://jenkins.koha-community[…]ha_Master_D12/49/ |
02:46 | Yippee, build fixed! | |
02:46 | wahanui | Congratulations! |
02:46 | koha-jenkins | Project Koha_Master_D11_My8 build #715: FIXED in 58 min: https://jenkins.koha-community[…]ster_D11_My8/715/ |
03:14 | AndrewFH joined #koha | |
03:15 | koha-jenkins | Yippee, build fixed! |
03:15 | wahanui | Congratulations! |
03:15 | koha-jenkins | Project Koha_Master_D11_MDB_Latest build #756: FIXED in 41 min: https://jenkins.koha-community[…]1_MDB_Latest/756/ |
03:22 | Yippee, build fixed! | |
03:22 | wahanui | Congratulations! |
03:22 | koha-jenkins | Project Koha_Master_U20 build #268: FIXED in 52 min: https://jenkins.koha-community[…]a_Master_U20/268/ |
03:30 | Project Koha_Master_D11_My8 build #716: SUCCESS in 37 min: https://jenkins.koha-community[…]ster_D11_My8/716/ | |
03:36 | Project Koha_Master_D11_CPAN build #502: SUCCESS in 50 min: https://jenkins.koha-community[…]ter_D11_CPAN/502/ | |
03:42 | Yippee, build fixed! | |
03:42 | wahanui | Congratulations! |
03:42 | koha-jenkins | Project Koha_Master_D10 build #497: FIXED in 55 min: https://jenkins.koha-community[…]a_Master_D10/497/ |
04:04 | Project Koha_Master_D11_MDB_Latest build #757: SUCCESS in 35 min: https://jenkins.koha-community[…]1_MDB_Latest/757/ | |
04:36 | enkidu joined #koha | |
05:08 | koha-jenkins | Project Koha_21.05_D10 build #174: ABORTED in 2 min 20 sec: https://jenkins.koha-community[…]ha_21.05_D10/174/ |
05:22 | Project Koha_21.05_D10 build #175: STILL FAILING in 13 min: https://jenkins.koha-community[…]ha_21.05_D10/175/ | |
05:42 | lmstrand joined #koha | |
05:53 | reiveune joined #koha | |
05:53 | reiveune | hello |
05:53 | wahanui | kia ora, reiveune |
06:12 | chriss joined #koha | |
06:23 | Oak joined #koha | |
06:33 | fridolin joined #koha | |
07:03 | marcelr joined #koha | |
07:04 | marcelr | hi #koha |
07:55 | alex_a joined #koha | |
07:55 | alex_a | Bonjour |
08:02 | cait joined #koha | |
08:03 | cait1 joined #koha | |
08:04 | cait1 | good morning #koha |
08:08 | marcelr | hi cait1 |
08:09 | marion joined #koha | |
08:10 | koha-jenkins | Project Koha_Master_D10 build #498: SUCCESS in 40 min: https://jenkins.koha-community[…]a_Master_D10/498/ |
08:11 | Joubu | fridolin: what do you use to "format" code? - https://bugs.koha-community.or[…]ent.cgi?id=128640 |
08:12 | it's not consistent, if you decide to clean it should be consistent (space before/after, etc.) | |
08:12 | koha-jenkins | Project Koha_21.05_D10 build #176: NOW UNSTABLE in 57 min: https://jenkins.koha-community[…]ha_21.05_D10/176/ |
08:14 | fridolin | Joubu: ah i use perl tidy in my IDE, i should use CLI |
08:14 | is there a special config ? | |
08:17 | Joubu | perltidy |
08:18 | fridolin | https://wiki.koha-community.or[…]hp?title=Perltidy ? |
08:25 | ashimema | Interesting, not earn that page for a while |
08:26 | I bet my perltidy setup is wrong | |
08:27 | I had a mojo inspired perltidy sometime ago . But I assumed we had a project specific one in Koha and haven't actually checked for it in years | |
08:29 | We aught to have a perltidyrc in the project, even if it reflects the defaults so we can ensure anyone's local perltidy gets overridden without have to have them manually add nopro | |
08:29 | * ashimema | opinion |
08:33 | fridolin | +1 |
08:42 | Ok i found max lines 80 whas missing in my IDE config for PerlTidy | |
08:42 | cait1 | i think we have one |
08:42 | fridolin | same result now |
08:42 | cait1 | in the project I man or used to have |
08:43 | fridolin | i'll leave what is in master but i'll be carefull for next time |
08:43 | cait1 | ah ok, I was thinking perlcritic, sorry |
08:43 | fridolin | max line length i mean |
08:46 | Joubu: can you confirm the maximum line length is defautl value 80 please ? | |
08:49 | davidnind | Add to .editorconfig ? |
08:51 | Joubu | isn't the we have perltidyrc in the QA repo |
08:51 | * we have perltidyrc in the QA repo | |
08:51 | cait1 | ah |
08:51 | fridolin | aaaa be have also xt/perltidyrc |
08:52 | Joubu | max line length must not be enforced to 80, we are not ready for that.. |
08:53 | fridolin | oki ouf |
08:54 | --maximum-line-length=178 i see | |
08:55 | https://git.koha-community.org[…]ter/xt/perltidyrc | |
08:55 | marcelr | i hope we are not starting spaces and tabs again ;) |
08:57 | ashimema | I don't agree with Max line 80 these days.. |
08:58 | It's very arbitrary and small given I don't know if any terminal emulators that limit that these days | |
08:58 | fridolin | with a 4K screen there is virtualy no limit ^^ |
08:59 | marcelr | if no one cares for 28962 or 28943 i will close them within a few weeks just like two others i already dropped |
08:59 | bug 28962 | |
08:59 | wahanui | bug 28962 is, like, ready for signoff |
08:59 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=28962 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Unverified self registrations should be removed shortly |
08:59 | Joubu | and so we *don't* actually have a perltidyrc in qa-test-tools |
08:59 | marcelr | bug 28943 |
08:59 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=28943 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Lower the risk of accidental patron deletion by cleanup_database.pl |
09:02 | marcelr | does anyone want to test 29336 ? |
09:02 | nlegrand joined #koha | |
09:02 | nlegrand | a good day |
09:02 | marcelr | hi nlegrand |
09:03 | ashimema | bug 29336 |
09:03 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29336 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Some authorised_value FKs are too short |
09:03 | marcelr | i am in the drop development mood now |
09:03 | nlegrand | hey marcelr |
09:03 | wahanui | it has been said that marcelr is just amazed that next is faster than count |
09:03 | marcelr | hmm |
09:03 | paxed | oh joy. "Waiting for table metadata lock" |
09:03 | ashimema | It's hard |
09:04 | * paxed | frowns at SendCirculationAlert and boos |
09:04 | ashimema | I don't like dropping developments, but there is only so many hours in a day and not enough people interested in testing and QAing |
09:04 | marcelr | right |
09:04 | ashimema | I can try to take a look at those though |
09:04 | marcelr | if it takes three months to signoff patches with 10 lines, i am out |
09:05 | once again | |
09:05 | ashimema | Hugs |
09:05 | Joubu | marcelr: I let you a comment |
09:05 | "This one should be pushed along with bug 29390 in my opinion." | |
09:05 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29390 enhancement, P5 - low, ---, m.de.rooy, ASSIGNED , Authorised values: Why not adding the FK on the way? |
09:05 | Joubu | and 29390 does not have patches |
09:06 | ha :D | |
09:06 | marcelr | thats a deadlock: i dont start on the second before some response on the first |
09:06 | Joubu | you let me a comment on 29390 and I did reply |
09:06 | didn't* | |
09:06 | ashimema | Perhaps, for some select devs we should allow them to skip SO so they hit the QA queue instead |
09:07 | marcelr | 29309 can be quite nasty |
09:07 | 29390 | |
09:07 | ashimema | Please add 'bug' so I get quick links and descriptions ;) |
09:07 | marcelr | ^ |
09:07 | ashimema | Typing from phone here whilst on the school run ;) |
09:08 | marcelr | ok |
09:08 | Joubu | marcelr: let's work on that next week, I cannot today |
09:08 | ashimema | Ah, insee |
09:08 | fridolin left #koha | |
09:08 | ashimema | My bad |
09:10 | Joubu | marcelr: that's the typical type of answer I was expected for my "dev list for 22.05" email ;) |
09:10 | paxed | marcelr: i share your sentiment. re. so slowness (and how hard it is to get code in) |
09:10 | Joubu | I sent an email to offer my help for the next 6 months, on specific topics |
09:11 | almost nobody replies :) | |
09:18 | marcelr | Joubu i still must send that reply |
09:24 | ashimema | I also need to reply |
09:24 | It's a lack of time and serious customer deadlines looming that I'm struggling with | |
09:25 | * ashimema | is trying to get better at managing his time |
09:29 | Joubu | to be honest, it's not the top priority |
09:29 | top priority is always the same, dashboard > criticals and blockers | |
09:29 | ashimema | indeed |
09:29 | Joubu | bug 29689, bug 29696, bug 29457 |
09:29 | ashimema | that's where I focus the majority of my community time |
09:29 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29689 blocker, P4, ---, jonathan.druart+koha, Signed Off , Update to 21.11 broken auto-generated barcode in <branchcode>0001 option |
09:29 | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29696 critical, P5 - low, ---, jonathan.druart+koha, Needs Signoff , "Suggest for purchase" missing biblio link | |
09:29 | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29457 critical, P5 - low, ---, martin.renvoize, In Discussion , Fee Cancellation records the wrong manager_id | |
09:30 | Joubu | and the 6 majors.. |
09:31 | paxed | end of the year crunch. thankfully we finished ours last week, moving 8 old consortia to a new hosting provider |
09:33 | marcelr | why is bug 29457 in discussion again ? |
09:34 | if we cant agree about the warnings, please push the fix on its own ! | |
09:34 | no reason to wait? | |
09:35 | Joubu | what's your suggestion? Never warn? |
09:38 | marcelr | i spent hours already there changing the dbrev, and now again discussion? |
09:38 | the fix needs to be pushed | |
09:38 | split the report? | |
09:40 | Joubu | it's already impossible to deal with the problem now, it will be really impossible once the fix is pushed and backported |
09:40 | 2x impossible | |
09:41 | but at least now we can warn in one situation | |
09:41 | marcelr | i dont understand: without the fix we are better off, you mean? |
09:42 | the warn is for most people irrelevant | |
09:42 | Joubu | at least we know the situation |
09:42 | marcelr | it is an edge case |
09:45 | Joubu | the problem is the backport. With your patch backported, the warning is irrelevant |
09:45 | + my ( $count_bad ) = $dbh->selectrow_array( q{SELECT COUNT(*) FROM accountlines WHERE credit_type_code = 'CANCELLATION' AND manager_id IS NOT NULL} ); | |
09:46 | this will be true and display incorrect warnings | |
09:46 | Worth noting that the problem appears because we don't have bug 27880. Maybe time to focus on it for next time something like that happens.. | |
09:46 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=27880 enhancement, P5 - low, ---, julian.maurice, Needs Signoff , Store each database migrations state in database |
09:50 | marcelr | we could add a temporary local syspref to store the first event that we warn |
09:51 | but i wont write code on that report anymore now | |
09:52 | ashimema | I replied to your post at last |
09:54 | I wondered about a temporary syspref approach too | |
09:57 | I can add a followup with that now | |
09:57 | I've not managed to get on with todays real tasks yet | |
10:09 | How about we just generalise the comment down again | |
10:10 | the db update does nothing, not even a lookup | |
10:10 | just output the message saying | |
10:10 | 'You might have some incorrect data for account cancellation lines, see the bug for details' | |
10:10 | or something along those lines | |
10:10 | leave it to the administrator to read the discussion and come to their own conclusion? | |
10:11 | * ashimema | goes to get tea |
10:12 | marcelr | ashimema: the problem is the second run |
10:12 | add a local pref, set it and skip the warn the second time | |
10:14 | ashimema | if we make the comment generic enough the second run doesn't matter |
10:14 | paxed | god damn it |
10:14 | ashimema | you still only tell them to check the comments of the bug |
10:14 | paxed | Waiting for table metadata lock |
10:14 | ashimema | we don't give any directions of anything to actually do |
10:16 | marcelr | you are free to remove my patch and submit a new one :) |
10:16 | the comment on the bug lists two sql options | |
10:17 | ashimema: no the second run will confuse people since things will have changed in the meantime with correct data | |
10:17 | ashimema | or not |
10:17 | they read the comments on the bug to understand | |
10:17 | the point is.. | |
10:17 | there's no wording that can fit inside the db update that will be totally clear | |
10:18 | marcelr | hence my remark earlier: just push the fix |
10:18 | can we get it out of discussion by doing so ? | |
10:19 | or yes, a very very general remark that you will be writing now ? | |
10:19 | no sql statements | |
10:19 | ashimema | exactly.. |
10:19 | literally something like: 'You might have some incorrect data for account cancellation lines, see the bug for details' | |
10:20 | marcelr | and note that this can be the second time |
10:20 | You can ignore this remark if you saw it before? | |
10:21 | or so | |
10:21 | ashimema | fair |
10:21 | marcelr | please submit |
10:21 | ashimema | ok |
10:29 | marcelr | i will have a look right now |
10:29 | can we wake up fridolin lol | |
10:29 | ashimema | thanks |
10:30 | marcelr | Joubu: finally i send my reply; ashimema helped me do it |
10:31 | ashimema | marcelr, did you see Joubu's 2FA patches already? |
10:32 | they're on my list.. I just haven't found a moment to test them fully | |
10:32 | marcelr | yes |
10:32 | ashimema | cool |
10:33 | as for 'small bugs that never get SO attention.. personally I'd be happy for them to go straight to the QA queue.. I try to focus my efforts on QA unless specifically prompted to look at an SO.. | |
10:33 | so for the small ones, I often miss then | |
10:34 | and on the odd occasions I go and do a SO queue purge.. I tend to grab all the smaller looking one's and move them straight through doing an SO + QA in one wherever I feel I can | |
10:34 | marcelr | Will fix this: File must have the exec flag |
10:40 | bug 29457 in PQA for the last time | |
10:40 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29457 critical, P5 - low, ---, martin.renvoize, Passed QA , Fee Cancellation records the wrong manager_id |
10:40 | ashimema | thanks dude |
10:40 | it was a big of a painful one that.. | |
10:40 | my initial mistake.. but the fix, though simple, caused us all sorts of pain | |
10:43 | marcelr | i am glad to have contributed to a critical patch today; two hours ago i felt different ;) |
10:44 | ashimema | I think we're all feeling the pain recently.. we certainly need an in person meet up some time to 'chew the cud' and have a drink/chocolate/whatever together |
10:45 | you guys have pulled me out of a defeatist stupor a few times in recent times of late 🙂 | |
10:53 | cait1 | thx for mentioning chocolate .) |
10:53 | * cait1 | is in hell today entering circulation rules |
10:53 | cait1 | well... maybe not hell, but I could do with some chocolate and less rules |
10:55 | koha-jenkins | Yippee, build fixed! |
10:55 | wahanui | Congratulations! |
10:55 | koha-jenkins | Project Koha_Master build #1873: FIXED in 1 hr 15 min: https://jenkins.koha-community[…]Koha_Master/1873/ |
10:55 | cait1 | ... and so much to read back here |
10:57 | marcelr | dont do it cait |
10:57 | alex_a joined #koha | |
10:57 | marcelr | i warned you :) |
10:58 | htg | |
10:59 | cait1 | For being slow to get code in... I think ti boils down to people writing more code than reviewing - for our model we need double the review time to write code time to blance it out... |
11:01 | you did... | |
11:04 | and we don't have balance right now | |
11:04 | also the devs don't check on NSO bugs a lot - and so architecture/internals get stuck | |
11:05 | all the bugs, that won't get tested by testers not close to the code | |
11:07 | ashimema | indeed |
11:09 | cait1 | so it's probably not an issue of slwo, it's overall a matter of backlog and missing hours |
11:09 | ashimema | exactly |
11:09 | wish I had a solution | |
11:09 | tcohen | hola #koha |
11:09 | cait1 | I think the only thing we can do right now is prioritize... (bugs before enh) and oldest to newest... |
11:09 | tcohen | hi ashimema |
11:10 | cait1 | but especially the old to new doesn't work well - I have been asking for the same bugs again and again over last cycle there |
11:10 | I am to blame too... just trying to get better, also giving earlier feedback on nso bugs where we can | |
11:20 | oleonard joined #koha | |
11:21 | oleonard | Hi #koha |
11:26 | cait1 | hi oleonard |
11:26 | wahanui | hi oleopard |
11:48 | cait joined #koha | |
11:52 | koha-jenkins | Yippee, build fixed! |
11:52 | wahanui | Congratulations! |
11:52 | koha-jenkins | Project Koha_21.05_D10 build #177: FIXED in 56 min: https://jenkins.koha-community[…]ha_21.05_D10/177/ |
11:59 | ashimema | lol, digging back into ISO dates is hilarious. |
12:00 | Joubu still around? | |
12:10 | AndrewFH joined #koha | |
12:34 | jzairo joined #koha | |
12:43 | AndrewFH joined #koha | |
12:43 | Joubu | ashimema: not really, but shoot |
12:45 | ashimema | no worries |
12:45 | I posted comments and patches to bug 29718 | |
12:45 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29718 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , DateTime - our 'iso' is not ISO 8601 |
12:45 | ashimema | and now.. I really need to stop procratinating and get back to my task list.. |
12:45 | * ashimema | has been bad today. |
12:46 | oleonard | "submitting patches" bad is my favorite kind of bad. |
12:46 | ashimema | hehe |
12:47 | Joubu | ashimema: ok I will get back to it next week. |
12:47 | ashimema | no rush |
12:47 | Joubu | already wondering why T should be insensitive however :D |
12:47 | ashimema | it's been buggy for years.. it's awesome we're getting it better |
12:48 | I've been here before 😉 | |
12:48 | and yielded to someone asking for it to be.. when I was going about the same thing for the RFC3339 handling | |
12:48 | basically.. | |
12:48 | wahanui | basically is checks the Bugzilla statuses are correct, then updates the status, adds the 'released in versions' text and adds a comment |
12:48 | ashimema | whilst the standard suggests it should be T.. the expectation in real life is that the parsing is generally case insensative |
12:49 | Joubu | The support is really only for DT strinfigication, which is using T |
12:49 | anyway, not important | |
12:49 | ashimema | indeed |
12:49 | but also wouldn't hurt.. right? | |
12:49 | Joubu | We certainly need to distinguish "sql" and "iso" |
12:50 | as we are sending "iso" when it's actually "sql" | |
12:50 | ashimema | if we wanted to be fully iso.. then we'd forbid passing am/pm |
12:50 | yeah | |
12:50 | I'd be game for a proper distinction | |
12:50 | Joubu | (and why doesn't mysql return iso?!) |
12:50 | ashimema | it would be more code, but much clearer code |
12:50 | cait1 | what's the difference? |
12:50 | wahanui | the difference is, like, that Koha doesn't support what you wnt in any other place :) |
12:50 | cait1 | between iso and sql? |
12:50 | Joubu | I don't think we pass am/pm with iso |
12:50 | ashimema | mysql does return iso.. but an ISO from many years ago 😉 |
12:50 | I believe | |
12:51 | like.. 2004 they removed double digit dates and required 4 chars | |
12:51 | but the iso standard prior to 2004 allowed for them | |
12:51 | which is kinda crazy | |
12:51 | right now.. if you suggest it's iso you can still pass am/pm and we won't fail | |
12:52 | in theory.. we should.. as ISO shouldn't support it. | |
12:52 | honestly.. I have no idea when am/pm strings are getting passed in | |
12:52 | ever | |
12:53 | Joubu | in practice I am pretty sure we don't do that, ampm is passed without dateformat and the syspref's value is used |
12:54 | but yeah, code might be wrong :) | |
12:54 | ashimema | hehe |
12:55 | marion joined #koha | |
13:12 | vfernandes joined #koha | |
13:12 | vfernandes | hi #koha |
13:15 | quick question: I'm getting different count results for authorities using the method get_usage_count (https://github.com/Koha-Commun[…]uthorities.pm#L50) and using the method count_auth_use (https://github.com/Koha-Commun[…]ch/Search.pm#L263) | |
13:16 | the records count in the authorities search results is correct, the records count in the authority details isn't correct | |
13:17 | why have two methods? shouldn't the result be the same? | |
13:20 | after doing some debug, if we use QueryAutoTruncate, the method get_usage_count will search for authid* which can lead to incorrect results | |
13:23 | AndrewFH joined #koha | |
13:27 | cait1 | vfernandes: sounds like you should report a bug |
13:46 | koha-jenkins | Project Koha_21.05_U18 build #110: SUCCESS in 36 min: https://jenkins.koha-community[…]ha_21.05_U18/110/ |
13:51 | Project Koha_21.05_U16 build #120: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_21.05_U16/120/ | |
13:52 | Dyrcona joined #koha | |
14:01 | koha-jenkins | Project Koha_21.05_U_Stable build #114: SUCCESS in 51 min: https://jenkins.koha-community[…].05_U_Stable/114/ |
14:01 | Project Koha_21.05_D12 build #64: SUCCESS in 50 min: https://jenkins.koha-community[…]oha_21.05_D12/64/ | |
14:04 | Project Koha_21.11_U_Stable build #8: FAILURE in 3 min 9 sec: https://jenkins.koha-community[…]21.11_U_Stable/8/ | |
14:08 | Project Koha_21.05_D9 build #114: SUCCESS in 57 min: https://jenkins.koha-community[…]oha_21.05_D9/114/ | |
14:10 | alex_a joined #koha | |
14:18 | koha-jenkins | Project Koha_21.05_U21 build #50: SUCCESS in 1 hr 7 min: https://jenkins.koha-community[…]oha_21.05_U21/50/ |
14:18 | tcohen: Bug 29427: Make SMTP transport set debug mode correctly | |
14:18 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29427 normal, P5 - low, ---, tomascohen, Pushed to oldstable , Debug mode not honoured in SMTP transport |
14:20 | koha-jenkins | Project Koha_21.05_U20 build #118: UNSTABLE in 33 min: https://jenkins.koha-community[…]ha_21.05_U20/118/ |
14:29 | Project Koha_21.05_D11 build #136: SUCCESS in 37 min: https://jenkins.koha-community[…]ha_21.05_D11/136/ | |
14:52 | AndrewFH joined #koha | |
14:56 | koha-jenkins | Project Koha_21.11_U20 build #8: SUCCESS in 51 min: https://jenkins.koha-community[…]Koha_21.11_U20/8/ |
15:04 | Project Koha_21.11_D10 build #17: SUCCESS in 44 min: https://jenkins.koha-community[…]oha_21.11_D10/17/ | |
15:10 | Project Koha_21.11_U18 build #9: SUCCESS in 1 hr 1 min: https://jenkins.koha-community[…]Koha_21.11_U18/9/ | |
15:11 | Project Koha_21.11_U21 build #7: SUCCESS in 42 min: https://jenkins.koha-community[…]Koha_21.11_U21/7/ | |
15:15 | tuxayo | Koha was/is this week! :o |
15:15 | has anyone seem some of the talks? | |
15:15 | *seen? | |
15:15 | oleonard-away | Kohacon? As far as I know they haven't posted anything |
15:22 | koha-jenkins | Project Koha_21.05_D10 build #178: SUCCESS in 1 hr 4 min: https://jenkins.koha-community[…]ha_21.05_D10/178/ |
15:22 | tcohen: Bug 29427: Make SMTP transport set debug mode correctly | |
15:22 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29427 normal, P5 - low, ---, tomascohen, Pushed to oldstable , Debug mode not honoured in SMTP transport |
15:49 | koha-jenkins | Project Koha_21.05_D11 build #137: SUCCESS in 37 min: https://jenkins.koha-community[…]ha_21.05_D11/137/ |
15:55 | fribeiro joined #koha | |
15:59 | koha-jenkins | Project Koha_21.11_D12 build #9: SUCCESS in 57 min: https://jenkins.koha-community[…]Koha_21.11_D12/9/ |
16:09 | Yippee, build fixed! | |
16:09 | wahanui | Congratulations! |
16:09 | koha-jenkins | Project Koha_21.11_U_Stable build #9: FIXED in 59 min: https://jenkins.koha-community[…]21.11_U_Stable/9/ |
16:14 | Project Koha_21.11_D9 build #8: SUCCESS in 1 hr 17 min: https://jenkins.koha-community[…]/Koha_21.11_D9/8/ | |
16:15 | Project Koha_21.11_U18 build #10: SUCCESS in 37 min: https://jenkins.koha-community[…]oha_21.11_U18/10/ | |
16:26 | reiveune | bye |
16:27 | oleonard | Bye reiveune ! |
16:27 | reiveune left #koha | |
16:27 | koha-jenkins | Project Koha_21.05_U21 build #51: SUCCESS in 1 hr 4 min: https://jenkins.koha-community[…]oha_21.05_U21/51/ |
16:29 | Project Koha_21.11_U20 build #9: SUCCESS in 40 min: https://jenkins.koha-community[…]Koha_21.11_U20/9/ | |
16:30 | enkidu joined #koha | |
16:42 | koha-jenkins | Project Koha_21.11_D10 build #18: UNSTABLE in 42 min: https://jenkins.koha-community[…]oha_21.11_D10/18/ |
16:49 | Project Koha_21.11_U21 build #8: SUCCESS in 33 min: https://jenkins.koha-community[…]Koha_21.11_U21/8/ | |
17:03 | cait1 | tuxayo: there was no live stream |
17:03 | bye all and have a nice weekend! | |
17:03 | cait1 left #koha | |
17:06 | koha-jenkins | Project Koha_21.11_D12 build #10: SUCCESS in 56 min: https://jenkins.koha-community[…]oha_21.11_D12/10/ |
17:11 | Project Koha_21.11_U18 build #11: SUCCESS in 41 min: https://jenkins.koha-community[…]oha_21.11_U18/11/ | |
17:17 | tuxayo | > there was no live stream |
17:17 | oh :o | |
17:26 | koha-jenkins | Project Koha_21.11_D9 build #9: SUCCESS in 37 min: https://jenkins.koha-community[…]/Koha_21.11_D9/9/ |
17:28 | Project Koha_21.05_D10 build #179: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]ha_21.05_D10/179/ | |
17:31 | cait joined #koha | |
17:35 | koha-jenkins | Project Koha_21.11_D12 build #11: SUCCESS in 53 min: https://jenkins.koha-community[…]oha_21.11_D12/11/ |
18:09 | Project Koha_21.11_D9 build #10: SUCCESS in 42 min: https://jenkins.koha-community[…]Koha_21.11_D9/10/ | |
18:21 | AndrewFH joined #koha | |
19:14 | koha-jenkins | Project Koha_21.05_D11 build #138: SUCCESS in 37 min: https://jenkins.koha-community[…]ha_21.05_D11/138/ |
19:16 | Project Koha_21.05_U18 build #111: SUCCESS in 35 min: https://jenkins.koha-community[…]ha_21.05_U18/111/ | |
19:25 | Project Koha_21.05_D12 build #65: SUCCESS in 49 min: https://jenkins.koha-community[…]oha_21.05_D12/65/ | |
19:35 | Project Koha_21.05_D9 build #115: UNSTABLE in 59 min: https://jenkins.koha-community[…]oha_21.05_D9/115/ | |
19:36 | Yippee, build fixed! | |
19:36 | wahanui | Congratulations! |
19:36 | koha-jenkins | Project Koha_21.05_U20 build #119: FIXED in 57 min: https://jenkins.koha-community[…]ha_21.05_U20/119/ |
19:41 | Project Koha_21.05_D10 build #180: SUCCESS in 1 hr 2 min: https://jenkins.koha-community[…]ha_21.05_D10/180/ | |
19:51 | Project Koha_21.05_U21 build #52: SUCCESS in 35 min: https://jenkins.koha-community[…]oha_21.05_U21/52/ | |
19:52 | fridolin joined #koha | |
19:53 | fridolin | hi |
19:53 | tcohen | hi! |
19:56 | koha-jenkins | Project Koha_21.05_U16 build #121: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_21.05_U16/121/ |
20:15 | Project Koha_21.05_D12 build #66: SUCCESS in 49 min: https://jenkins.koha-community[…]oha_21.05_D12/66/ | |
20:27 | Project Koha_21.05_U18 build #112: SUCCESS in 36 min: https://jenkins.koha-community[…]ha_21.05_U18/112/ | |
20:30 | Project Koha_21.05_U20 build #120: SUCCESS in 54 min: https://jenkins.koha-community[…]ha_21.05_U20/120/ | |
20:31 | Project Koha_21.05_U_Stable build #115: SUCCESS in 54 min: https://jenkins.koha-community[…].05_U_Stable/115/ | |
20:34 | Project Koha_21.05_D11 build #139: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_21.05_D11/139/ | |
20:42 | Project Koha_21.05_D10 build #181: SUCCESS in 1 hr 1 min: https://jenkins.koha-community[…]ha_21.05_D10/181/ | |
21:00 | Project Koha_21.05_D12 build #67: SUCCESS in 32 min: https://jenkins.koha-community[…]oha_21.05_D12/67/ | |
21:16 | Project Koha_21.05_U18 build #113: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_21.05_U18/113/ | |
21:27 | Project Koha_21.05_U16 build #122: SUCCESS in 1 hr 11 min: https://jenkins.koha-community[…]ha_21.05_U16/122/ | |
21:29 | Yippee, build fixed! | |
21:29 | wahanui | Congratulations! |
21:29 | koha-jenkins | Project Koha_21.05_D9 build #116: FIXED in 58 min: https://jenkins.koha-community[…]oha_21.05_D9/116/ |
21:33 | Project Koha_21.05_U20 build #121: SUCCESS in 33 min: https://jenkins.koha-community[…]ha_21.05_U20/121/ | |
21:38 | Project Koha_21.05_U21 build #53: SUCCESS in 1 hr 7 min: https://jenkins.koha-community[…]oha_21.05_U21/53/ | |
21:46 | Project Koha_21.05_D10 build #182: SUCCESS in 1 hr 3 min: https://jenkins.koha-community[…]ha_21.05_D10/182/ | |
21:54 | Project Koha_21.05_D11 build #140: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_21.05_D11/140/ | |
22:05 | Project Koha_21.05_D12 build #68: SUCCESS in 32 min: https://jenkins.koha-community[…]oha_21.05_D12/68/ | |
22:27 | Project Koha_21.05_U18 build #114: SUCCESS in 58 min: https://jenkins.koha-community[…]ha_21.05_U18/114/ | |
22:32 | Project Koha_21.05_U20 build #122: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_21.05_U20/122/ | |
22:34 | Project Koha_21.05_U_Stable build #116: SUCCESS in 56 min: https://jenkins.koha-community[…].05_U_Stable/116/ | |
22:38 | Project Koha_21.05_U16 build #123: UNSTABLE in 1 hr 11 min: https://jenkins.koha-community[…]ha_21.05_U16/123/ | |
22:42 | Project Koha_21.05_D9 build #117: SUCCESS in 36 min: https://jenkins.koha-community[…]oha_21.05_D9/117/ | |
22:47 | Project Koha_21.05_D10 build #183: UNSTABLE in 1 hr 1 min: https://jenkins.koha-community[…]ha_21.05_D10/183/ | |
23:11 | Project Koha_21.05_D11 build #141: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_21.05_D11/141/ | |
23:26 | Project Koha_21.05_U18 build #115: SUCCESS in 58 min: https://jenkins.koha-community[…]ha_21.05_U18/115/ | |
23:40 | Project Koha_21.05_U21 build #54: SUCCESS in 1 hr 6 min: https://jenkins.koha-community[…]oha_21.05_U21/54/ | |
23:51 | Yippee, build fixed! | |
23:51 | wahanui | Congratulations! |
23:51 | koha-jenkins | Project Koha_21.05_D10 build #184: FIXED in 1 hr 3 min: https://jenkins.koha-community[…]ha_21.05_D10/184/ |
23:55 | Project Koha_21.05_D9 build #118: SUCCESS in 1 hr 12 min: https://jenkins.koha-community[…]oha_21.05_D9/118/ |
← Previous day | Today | Next day → | Search | Index