← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:25 | bdonnahue2 joined #koha | |
| 00:37 | bdonnahue1 joined #koha | |
| 00:39 | bdonnahue3 joined #koha | |
| 01:35 | bdonnahue1 joined #koha | |
| 04:20 | bdonnahue1 joined #koha | |
| 05:10 | chriss joined #koha | |
| 05:13 | chriss2 joined #koha | |
| 06:12 | magnuse | \o/ |
| 06:21 | alex_a joined #koha | |
| 06:21 | alex_a | Bonjour |
| 06:33 | paul_p__ joined #koha | |
| 06:35 | cait joined #koha | |
| 06:43 | reiveune joined #koha | |
| 06:43 | reiveune | hello |
| 06:47 | oleonard joined #koha | |
| 06:51 | magnuse | yay, the "Technical highlights" section of the 20.11 release notes are super awesome! |
| 06:51 | Joubu++ | |
| 06:53 | cait joined #koha | |
| 06:59 | lds joined #koha | |
| 07:01 | * dcook | waves to magnuse |
| 07:01 | dcook | FYI I always think of your name as "mag-noose" rather "magnus-e" heh |
| 07:02 | fewer syllables I guess. Maybe I'm lazy | |
| 07:05 | paul_p joined #koha | |
| 07:07 | paul_p_ joined #koha | |
| 07:13 | fridolin joined #koha | |
| 07:14 | fridolin | hi there |
| 07:14 | wahanui | bidet, fridolin |
| 07:16 | fridolin | arf yesterday was dev meeting, sorry i couldnt make it |
| 07:18 | cait | fridolin: just checked - the strings for 20.11 pushed last are still missing. were you in touch with Bernardo? |
| 07:19 | eager to translate, as I am currently locked out of other thigns here... | |
| 07:22 | sophie_m joined #koha | |
| 07:23 | fridolin | cait: i will mail im, he said he exports strings on each 15th |
| 07:23 | cait | he did |
| 07:23 | you announced later | |
| 07:24 | i had already translated the updates from 15th | |
| 07:24 | i check almost every day, since we are slowly working through translating the manual... 10 minutes a day if possible :) | |
| 07:26 | Joubu | rangi: new merge request for the dashboard - https://gitlab.com/koha-commun[…]erge_requests/114 |
| 07:27 | sophie_m joined #koha | |
| 07:29 | magnuse | dcook: it's really just magnus, the e is from my surname, because the magnus nick was taken when we moved to oftc :-) |
| 07:40 | ashimema | monring |
| 07:41 | cait | good morning ashimema |
| 07:42 | ashimema | Think I'll have an accounts day today.. seems people are suddenly finding bugs with cash management |
| 08:22 | did joined #koha | |
| 08:26 | kohaputti joined #koha | |
| 09:30 | dersmon joined #koha | |
| 09:31 | dersmon | hi everyone |
| 09:32 | i got a follow up question to yesterdays error | |
| 09:32 | quick recap: i get a "Uncaught TypeError: b.settings()[0].aoColumns[c] is undefined" in my basket.pl view | |
| 09:34 | which blocks initialization of other components (we tripped over this when we were unable to reopen baskets) | |
| 09:34 | i removed the columnsettings and now everything else seems to be working as expected: | |
| 09:34 | Joubu | dersmon: which exact Koha version do you use? |
| 09:36 | ashimema | hum |
| 09:36 | whens the next documentation meeting? | |
| 09:36 | dersmon | https://pastebin.com/ppewxL9m |
| 09:36 | we are currently on 19.05.17 | |
| 09:36 | which is quite old, i am aware | |
| 09:37 | the columnsettings look like this: | |
| 09:37 | https://pastebin.com/hpuPfsVq | |
| 09:37 | so | |
| 09:38 | now it works for me, but i am unsure which unintended consequences deleting the column settings may have | |
| 09:38 | so i thought i'd ask ;) | |
| 09:38 | Joubu | it won't display the "columns" button at the top of the table |
| 09:39 | that's all | |
| 09:39 | just tested right now on 19.05.17 and it's working ok for me | |
| 09:42 | dersmon | interesting |
| 09:42 | do you see anything in the columnsettings variable pasted above? | |
| 09:44 | we did a minor upgrade from 19.05.07 because of some elastic search error, before we did not have that problem | |
| 09:45 | Joubu | dersmon: http://paste.koha-community.org/213 |
| 09:46 | I've played a bit with the hidden values in the admin area | |
| 09:46 | so it's not the default values that are displayed | |
| 09:48 | dersmon: you can try and delete the entries in columns_settings related to this table | |
| 09:48 | module=acqui, page=basket, tablename=orders | |
| 09:48 | in the DB I mean | |
| 09:49 | dersmon | then it will be re-added based on some config file? |
| 09:50 | Joubu | yes, admin/columns_settings.yml |
| 09:50 | dersmon | ok cool, will try |
| 09:50 | thank you :) | |
| 09:52 | hm | |
| 09:52 | i only got some cataloguing entries | |
| 09:52 | xD | |
| 09:54 | Joubu | weird. Sorry I cannot help you more for a version that is no longer maintained. But comment the line, it won't hurt more than removing the "Columns" button to hide/show columns by default |
| 09:55 | dersmon | yeah |
| 09:55 | so this means that we are actually using the defaults? | |
| 09:55 | i mean the fact that there are no entries in the database for acqui | |
| 09:55 | Joubu | no, defaults are in the js variable |
| 09:56 | defaults are picked from the yml file. The admin interface let you overwrite the file, and if you do so the DB will contain your config. | |
| 09:56 | 906 var columns_settings = [% ColumnsSettings.GetColumns( 'acqui', 'basket', 'orders', 'json' ) | $raw %]; | |
| 09:56 | this line is retrieving the "current state" (either default or specific) | |
| 09:57 | 909 KohaTable("orders", { | |
| 09:57 | [...] | |
| 09:57 | dersmon | i see |
| 09:57 | Joubu | 919 }, columns_settings); |
| 09:57 | ^ this is telling: create me a table on "#orders" with this columns settings | |
| 09:57 | if you replace 919 with "});" the table will be created without the "columns settings" featuer | |
| 09:57 | feature | |
| 09:58 | one other possibility is that your cached version of the yml file is not up-to-date | |
| 09:59 | but if you upgraded, you certainly reset the cache anyway | |
| 10:13 | alex_a_ joined #koha | |
| 10:24 | fridolin | cait: Bernardo tells me PO files where updated on 15th, but a few commits pushed after impact strings so he updated right now |
| 10:25 | should be ok now | |
| 10:25 | Joubu | mtj: you created the "Wiki team" on the roles for 21.11, but the link points to https://wiki.koha-community.or[…]t_roles#Wiki_team which is not created |
| 10:25 | thx fridolin! | |
| 10:36 | cait1 joined #koha | |
| 10:36 | oleonard | o/ |
| 10:46 | This would be a great day to QA Bug 27566... Y'know, if you were a QA person maybe | |
| 10:46 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=27566 normal, P5 - low, ---, oleonard, Signed Off , CSS rule not applying to HTML select / option - displays with serif font ignoring rules |
| 10:50 | tcohen | morning |
| 10:51 | hc joined #koha | |
| 11:17 | did joined #koha | |
| 11:20 | JBoyer_ joined #koha | |
| 11:22 | cait | fridolin: thx - there are some quite prominent strings changed, like the navigation links |
| 11:26 | fridolin: updates happened now, i have translated. Maybe worth another email? other might have already checked and won't do it again | |
| 11:41 | fridolin | yep ok |
| 11:54 | cait | fridolin++ |
| 12:24 | Dyrcona joined #koha | |
| 12:38 | tcohen | oleonard around? |
| 12:39 | oleonard | Present |
| 12:39 | tcohen | in your vast experience |
| 12:39 | he | |
| 12:39 | is it common to find some glossary of icons in the UI | |
| 12:40 | for example: on the circ page, current checkouts, we provide some information in a textual way | |
| 12:40 | and it feels like we could be using self-explanatory icons | |
| 12:40 | and/or colors | |
| 12:40 | with maybe such glossary | |
| 12:41 | so, instead of just a warning icon with a tooltip, have an explanation on the UI | |
| 12:41 | and then add new icons for new things you want to highlight | |
| 12:41 | for example, a checkout is flagged for automatic checkin | |
| 12:42 | I would hate to add, yet more, text saying 'This is scheduled for automatic checkin' | |
| 12:42 | * ashimema | likes icons with tooltips |
| 12:43 | oleonard | Yeah I think if we use an icon to communicate all by itself we need a tooltip of some kind |
| 12:43 | tcohen | oh my oh my |
| 12:43 | oleonard | I don't think it's fair the user to make them refer to a separate thing in order to understand the interface |
| 12:43 | * tcohen | is happy to see new routes pushed |
| 12:43 | tcohen | haha |
| 12:44 | oleonard thanks, that was my doubt | |
| 12:44 | oleonard | I agree that there are cases where it's nice to use an icon by itself instead of text, especially for a page like the circ page where it's crowded already |
| 12:45 | tcohen | ✌🏻 |
| 12:46 | Joubu | tcohen: I would add something similar to the auto renewal flag |
| 12:49 | tcohen | good |
| 12:51 | huginn | News from kohagit: Bug 28064: (QA follow-up) Remove value from button <https://git.koha-community.org[…]54bf73e4ee7e2bb14> |
| 12:51 | News from kohagit: Bug 16787: DBRev 20.12.00.036 <https://git.koha-community.org[…]5242bdefbe241cf83> | |
| 12:51 | News from kohagit: Bug 16787: (follow-up) Add noReservesAllowed to ERROR_MAP <https://git.koha-community.org[…]24750dbec2560d6d1> | |
| 12:51 | News from kohagit: Bug 23195: (follow-up) One text invoice should be open <https://git.koha-community.org[…]de859bb6ebf2109d9> | |
| 12:51 | News from kohagit: Bug 28157: Add handling for the x-koha-library header <https://git.koha-community.org[…]12adcb94c311f668b> | |
| 12:51 | News from kohagit: Bug 28157: Regression tests <https://git.koha-community.org[…]50742833cdd07e5fb> | |
| 12:51 | News from kohagit: Bug 28157: Add Koha::Patron->can_log_into <https://git.koha-community.org[…]e6ed74a3a9cefb5a1> | |
| 12:51 | News from kohagit: Bug 16787: (follow-up) Fix check to ensure reasons are passed to template <https://git.koha-community.org[…]464bc5821c58c10fb> | |
| 12:51 | News from kohagit: Bug 23195: Always count shipping costs as 'spent' <https://git.koha-community.org[…]ea510d5899c1ee050> | |
| 12:51 | News from kohagit: Bug 23195: Unit tests <https://git.koha-community.org[…]183bed4827d4b9eea> | |
| 12:51 | News from kohagit: Bug 28002: Unit tests <https://git.koha-community.org[…]46149a980385b3349> | |
| 12:51 | News from kohagit: Bug 28064: Add dotransfer field to slip print submission <https://git.koha-community.org[…]021f9e53a30c0b90d> | |
| 12:51 | News from kohagit: Bug 23666: (follow-up) Adjust to new exceptions <https://git.koha-community.org[…]626e007d2aa993c7c> | |
| 12:51 | News from kohagit: Bug 28002: Add extended_attributes support to POST /patrons <https://git.koha-community.org[…]0bcbcb6a0246b2bdf> | |
| 12:51 | News from kohagit: Bug 23666: Add PATCH /patron/:patron_id/extended_attributes/:extended_attribute_id <https://git.koha-community.org[…]0ca43e98e6e07dabe> | |
| 12:51 | News from kohagit: Bug 23666: (QA follow-up) Fix wrong required permissions <https://git.koha-community.org[…]fb841dc3ed24ff94b> | |
| 12:51 | News from kohagit: Bug 23666: Unit tests <https://git.koha-community.org[…]f1645526e3e5dfad9> | |
| 12:51 | News from kohagit: Bug 23666: Add extended attributes routes <https://git.koha-community.org[…]3481b104e78a53af8> | |
| 12:51 | News from kohagit: Bug 23666: Add spec <https://git.koha-community.org[…]d7477a17cb9d8b420> | |
| 12:51 | News from kohagit: Bug 27240: Basket export cleanup. <https://git.koha-community.org[…]fd1e5008cb4d99034> | |
| 12:54 | kohaputti | interesting, it is possible to define decimal number for how many holds are possible :D |
| 12:58 | and seems to be possible to break the smart-rules.pl if enough decimals :D http://paste.debian.net/plain/1194680 | |
| 12:58 | marie-luce joined #koha | |
| 12:59 | oleonard | kohaputti: I'm surprised a library hasn't asked for official support for half a hold |
| 12:59 | caroline_catlady | interesting! |
| 13:01 | koha-jenkins | Project Koha_Master_D11 build #270: FAILURE in 10 min: https://jenkins.koha-community[…]a_Master_D11/270/ |
| 13:03 | Project Koha_Master_D9_MDB_Latest build #570: FAILURE in 10 min: https://jenkins.koha-community[…]9_MDB_Latest/570/ | |
| 13:03 | lukeG1 joined #koha | |
| 13:04 | koha-jenkins | Project Koha_Master_D9 build #1627: FAILURE in 10 min: https://jenkins.koha-community[…]a_Master_D9/1627/ |
| 13:14 | Project Koha_Master build #1623: FAILURE in 10 min: https://jenkins.koha-community[…]Koha_Master/1623/ | |
| 13:15 | Project Koha_Master_D10_CPAN build #298: FAILURE in 11 min: https://jenkins.koha-community[…]ter_D10_CPAN/298/ | |
| 13:17 | stef joined #koha | |
| 13:21 | koha-jenkins | Project Koha_Master_D11 build #271: STILL FAILING in 10 min: https://jenkins.koha-community[…]a_Master_D11/271/ |
| 13:24 | Project Koha_Master_D9_MDB_Latest build #571: STILL FAILING in 10 min: https://jenkins.koha-community[…]9_MDB_Latest/571/ | |
| 13:27 | Joubu | mtj, tcohen: timeout for all the master jobs upped to 20min (instead of default 10) |
| 13:27 | (timeout for the git fetch) | |
| 13:31 | koha-jenkins | Project Koha_Master_D9 build #1628: STILL FAILING in 10 min: https://jenkins.koha-community[…]a_Master_D9/1628/ |
| 13:34 | mtj | hi koha, thanks Joubu |
| 13:35 | koha-jenkins | Project Koha_Master_D10_CPAN build #299: STILL FAILING in 10 min: https://jenkins.koha-community[…]ter_D10_CPAN/299/ |
| 13:35 | Joubu | it should pull instead of wipe out at the end of the job and clone the whole repo before starting a job |
| 13:40 | mtj | Joubu: any plans to move jenkins builds over to your great build.pl script? |
| 13:41 | Joubu | mtj: yes, I am waiting for tcohen's stamp on the merge request |
| 13:41 | tcohen | gimme a few |
| 13:41 | mtj | ok ok :p |
| 13:43 | i see ubuntu 21.04 is released today, shall we add some ktd/jenkins builds for it? | |
| 13:46 | Joubu | mtj: we should rename Koha_Master_U2010 with Koha_Master_Ubuntu_Latest |
| 13:47 | and yes, make it use U21.04 | |
| 13:47 | mtj | Joubu: great idea |
| 13:47 | Joubu | happy to let you do it if you want to :) |
| 13:48 | bdonnahue1 joined #koha | |
| 13:48 | mtj | ok, can do |
| 13:49 | koha-jenkins | Project Koha_Master_U2010 build #158: UNSTABLE in 58 min: https://jenkins.koha-community[…]Master_U2010/158/ |
| 14:03 | Joubu | mtj, tcohen: do you know why we set "delete workspace before build starts" for our jobs? |
| 14:05 | mtj | its to stop jenkins from using too much disk space, and crashing the system |
| 14:06 | Joubu | mtj: but I bet it's also why we have to clone the repo before the job starts :) |
| 14:06 | koha-jenkins | Project Koha_Master_D9_My8 build #552: UNSTABLE in 1 hr 14 min: https://jenkins.koha-community[…]aster_D9_My8/552/ |
| 14:07 | mtj | Joubu: yes its true |
| 14:10 | always repo cloning is bad... but its probably better than having the jenkins nodes randomly crash | |
| 14:11 | tcohen | well |
| 14:11 | Joubu | the problem is that now we have 7 nodes cloning the repo at the same time when a push happened :) |
| 14:11 | tcohen | we use clones from a local clone |
| 14:11 | koha-jenkins | Project Koha_20.11_U20 build #70: SUCCESS in 36 min: https://jenkins.koha-community[…]oha_20.11_U20/70/ |
| 14:11 | tcohen | Koha_Source is already there |
| 14:12 | so it should just be updating that with the latests refs | |
| 14:12 | and performing a shallow clone, locally | |
| 14:12 | Joubu | tcohen: definitely not what happened ~20min ago |
| 14:12 | https://jenkins.koha-community[…]r_D11/270/console | |
| 14:12 | 14:51:10 Using reference repository: /srv/jenkins/workspace/Koha_Source | |
| 14:12 | ha, yes | |
| 14:13 | tcohen | well, so gitea was overloaded and failed with small chunks |
| 14:13 | Joubu | I don't understand why it was so slow then |
| 14:14 | good news, so the behaviour is correct :) | |
| 14:15 | mtj | if we disable 'delete workspace', im not sure how much extra disk a node would need |
| 14:15 | tcohen | "good news" LOL |
| 14:15 | Joubu | I was confused by the "15:01:11 ERROR: Error cloning remote repo 'origin'" |
| 14:15 | which is actually a timeout for the git fetch, not a git clone | |
| 14:15 | ashimema | oleonard around? |
| 14:15 | Joubu | tcohen: yes it's good news, we don't clone the repo for each job |
| 14:16 | tcohen | https://snipboard.io/Dkz0w5.jpg |
| 14:16 | no swap usage | |
| 14:16 | Joubu | upping the timeout to 20min is the only thing we can do for now then |
| 14:17 | mtj | Joubu, tcohen - do we switch to a mirror repo to help with the load? (gitlab/github) |
| 14:17 | tcohen | not a bad idea |
| 14:17 | Joubu | not gitlab |
| 14:17 | tcohen | yeah, that's the issue |
| 14:17 | Joubu | the problem is the repo won't necessarily up-to-date |
| 14:17 | tcohen | let's keep trying with gitea |
| 14:17 | Joubu | be* |
| 14:18 | tcohen | Gitlab has size limitations |
| 14:18 | Joubu | no, gitlab is not syncing when a push happened |
| 14:18 | github is synced with a gitea post-push hook | |
| 14:19 | tcohen | github then? |
| 14:19 | Joubu | but, on a big push, you may have a sync issue (jenkins triggered before github mirror is done) |
| 14:20 | oleonard | I'm here ashimema |
| 14:20 | Joubu | tcohen: we can try |
| 14:20 | koha-jenkins | Project Koha_20.11_U16 build #69: SUCCESS in 53 min: https://jenkins.koha-community[…]oha_20.11_U16/69/ |
| 14:21 | ashimema | I'm struggling again with bloomin number inputs and accessability/localisation |
| 14:21 | I think our ACC guidelines is wrong | |
| 14:21 | the UK gov site recommends one thing.. then links of to examples that actually recommend something different again. | |
| 14:22 | oleonard | :/ |
| 14:23 | ashimema | I'm tempted to ditch the pattern match entirely.. thoughts? |
| 14:23 | caroline_catlady | government making it easy for citizen to find accurate info on their website since 1990! |
| 14:23 | ashimema | https://design-system.service.[…]t-input/#numbersI'm looking at 'Asking for decimal numbers' on |
| 14:23 | Joubu | mtj, tcohen: I am going to update master's jobs to use build.pl, and will switch some jobs to use github |
| 14:24 | ashimema | currently our guideline recommends 'pattern="[0-9]*"' |
| 14:24 | which actually prevents `.` and `,` doesn't it | |
| 14:24 | which you found and fixed in some places.. but not all | |
| 14:24 | on the manual invoice page you updated it to `^\d+(\.\d{2})?$` | |
| 14:24 | but.. that prevents ',' in french | |
| 14:25 | hence my thinking just remove that validation entirely (which reminds me.. 'amount' is a required field.. but it's not marked as such on manual invoice or manual credit forms | |
| 14:26 | mtj | Joubu: i think github is a good start |
| 14:27 | oleonard | ashimema: So their recommendation is "just use a text input, whatever." Without any advice on how to provide validation. |
| 14:28 | ashimema | pretty much :( |
| 14:28 | `<input type="text" inputmode="numeric">` I think | |
| 14:29 | oleonard | It would certainly be nice to hear more details about why inputmode decimal doesn't work sometimes. |
| 14:29 | mtj | tcohen, Joubu, i think we can eventually disable 'delete workspace', but we will need to make sure the nodes have enough disk space - which has been an historic problem for us |
| 14:29 | ashimema | I bet it's a bug in certain phones |
| 14:29 | I've not seen it in real life | |
| 14:29 | but I only have one phone to play with.. haha | |
| 14:29 | mtj | tcohen, Joubu so, better system monitoring/alerting, ssh access etc |
| 14:30 | ashimema | I still kinda like input masks.. |
| 14:30 | but | |
| 14:30 | I have no idea how accessible they are.. | |
| 14:30 | koha-jenkins | Project Koha_20.11_D9 build #85: SUCCESS in 1 hr 6 min: https://jenkins.koha-community[…]Koha_20.11_D9/85/ |
| 14:30 | ashimema | it causes us no end of issues having mixtures of 1,000.00 or 1.000,00 for example |
| 14:35 | I reckon we'd be safe to allow almost anything .. to allow for pasting | |
| 14:35 | then post process it.. | |
| 14:36 | dropping symbols other than .,\d (like USD or $ for example) | |
| 14:36 | then working from the tail backwards and looking for the first non digit char ( comma or dot) | |
| 14:36 | if it's two places in.. it's the decimal separator | |
| 14:37 | if it's three it's a thausand separator.. | |
| 14:37 | if it's a thausand separator and we've not come accross a decimal one.. add two '0' and a decimal sep | |
| 14:38 | sounds complicated.. but should do the trick I reckon | |
| 14:38 | * ashimema | goes looking at the jquery validator docs and if they support validation functions |
| 14:44 | caroline_catlady | do any of your libraries not allow on shelf holds? |
| 14:47 | oleonard | We've always allowed on-shelf holds. |
| 14:48 | caroline_catlady | I have a case of a library who does not allow on shelf holds, but for serials, I specified in the circ rules that opac users are forced to choose a specific item |
| 14:48 | koha-jenkins | Project Koha_Master build #1624: NOW UNSTABLE in 36 min: https://jenkins.koha-community[…]Koha_Master/1624/ |
| 14:49 | caroline_catlady | I think even though on-shelf holds are not allowed, if one item in a serial record is checked out, I should be able to place a hold on that item? |
| 14:49 | I think I'll just try to convince them to allow on-shelf holds lol! | |
| 14:50 | I don't think a lot of libraries still don't allow on-shelf holds, it's probably a very fringe case | |
| 14:51 | koha-jenkins | Project Koha_20.11_D10 build #88: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_20.11_D10/88/ |
| 14:51 | oleonard | caroline_catlady: What you describe does sound like a bug, but I fear it would be difficult to fix |
| 14:52 | caroline_catlady | holds are never an easy fix from what I understand |
| 14:53 | koha-jenkins | Project Koha_20.11_U2010 build #65: SUCCESS in 46 min: https://jenkins.koha-community[…]a_20.11_U2010/65/ |
| 14:54 | caroline_catlady | maybe i just still misunderstand the options of the on-shelf holds options (yes, if any unavailable, if all unavailable) |
| 14:55 | Joubu | mtj, tcohen: https://tree.taiga.io/project/koha-ils/task/104 |
| 14:56 | mtj, tcohen: and also the comment there - https://tree.taiga.io/project/koha-ils/task/102 | |
| 15:00 | reiveune | bye |
| 15:00 | reiveune left #koha | |
| 15:01 | fridolin left #koha | |
| 15:09 | koha-jenkins | Yippee, build fixed! |
| 15:09 | wahanui | Congratulations! |
| 15:09 | koha-jenkins | Project Koha_20.11_U18 build #66: FIXED in 1 hr 38 min: https://jenkins.koha-community[…]oha_20.11_U18/66/ |
| 15:13 | Project Koha_Master_D10_CPAN build #300: STILL FAILING in 10 min: https://jenkins.koha-community[…]ter_D10_CPAN/300/ | |
| 15:14 | Joubu | ashimema: number validation - not sure I am understand. I would base the validation on a pref or the locale of the browser |
| 15:15 | s/ am// | |
| 15:15 | kidclamp: could you have a look at the failing test from bug 16787? | |
| 15:15 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=16787 normal, P5 - low, ---, nick, Pushed to master , 'Too many holds' message appears inappropriately and is missing data |
| 15:16 | kidclamp | looking |
| 15:22 | ashimema | What about canada Joubu |
| 15:23 | I'm told they interchangably format number because of their history (french + english) | |
| 15:23 | caroline_catlady | we're weird |
| 15:23 | ashimema | so they might have 1,000.00 and 1.000,00 in use on the same system |
| 15:23 | correct me if I'm wrong caroline | |
| 15:23 | caroline_catlady | I've never seen 1.000,00 |
| 15:23 | koha-jenkins | Project Koha_Master_D9 build #1629: STILL FAILING in 9 min 49 sec: https://jenkins.koha-community[…]a_Master_D9/1629/ |
| 15:23 | ashimema | oh really |
| 15:23 | my sources are wrong then.. haha | |
| 15:24 | caroline_catlady | it could be 1,000.00 or 1 000,00 or 1 000.00 or 1000,00 or 1000.00 |
| 15:24 | Joubu | just wondering if adding a number with more than 2 decimals won't break your validation |
| 15:24 | think... bitcoin.. :D | |
| 15:24 | * ashimema | hasn't traded in bitcoin yet.. |
| 15:25 | caroline_catlady | But I would be comfortable telling people to always use the same format |
| 15:25 | koha-jenkins | Project Koha_Master_D11 build #272: NOW UNSTABLE in 54 min: https://jenkins.koha-community[…]a_Master_D11/272/ |
| 15:25 | ashimema | did those ******** decide to go wierd and trade with more than two palces |
| 15:25 | places.. even | |
| 15:25 | caroline_catlady | like in excel, you choose a format ad use that one exclusively |
| 15:26 | Joubu | 10€=0.0022044BTC |
| 15:26 | ashimema | can't we all just trade in the smallest unit |
| 15:26 | Joubu | supporting numbers with more than 2 decimals can be important |
| 15:27 | caroline_catlady | we do sometimes have issues with rounding because our tax rates have 4 decimals |
| 15:27 | ashimema | bitcoin is a right mare.. what is the smallest tradable unit of a bitcoin.. |
| 15:27 | or do they literally not care.. because it's entirely electronic | |
| 15:28 | either way.. I think we need to drop the pattern match for our numeric fields | |
| 15:29 | well.. out non-integer ones at least | |
| 15:29 | kidclamp | patch there Joubu |
| 15:29 | ashimema | I'll trade you half a pig for a patch that fixes all our decimal and rounding issues kidclamp |
| 15:30 | oleonard | Do I hear .5025 pigs? |
| 15:31 | ashimema | How about half a pig and one chicken? |
| 15:31 | kidclamp | rm -rf ./acqui; git commit -a -m "Remove problems" |
| 15:31 | Joubu | thanks kidclamp, will push a bit later today |
| 15:31 | ashimema | you forgot accounts kidclamp ;') |
| 15:31 | * ashimema | read that as Joubu was going to nuke acq for us |
| 15:32 | oleonard | \o/ |
| 15:32 | kidclamp | fair enough ashimema - you can have all my haypennies when you clean up my patch |
| 15:32 | Joubu | acqui is not enough to get rid ot the problems |
| 15:32 | -m "Remove problems - part 1" | |
| 15:32 | kidclamp | what if we just stoppped having users? |
| 15:33 | oleonard | How would we know who to ask for money? |
| 15:33 | ashimema | rm -rf /kohaclone; git commit -a -m "Problem solved" |
| 15:33 | kidclamp | "Mischief managed" |
| 15:33 | Joubu | you removed the git repo |
| 15:33 | ashimema | lol |
| 15:33 | oops | |
| 15:33 | tuxayo | PTFS-E's accounting will have questions when seeing an invoice for .5025 pig + 1 chicken shipped to the USA |
| 15:34 | ashimema | 😂 |
| 15:34 | you | |
| 15:34 | oop | |
| 15:36 | cait joined #koha | |
| 15:51 | koha-jenkins | Project Koha_Master_D9_MDB_Latest build #572: NOW UNSTABLE in 59 min: https://jenkins.koha-community[…]9_MDB_Latest/572/ |
| 15:57 | Project Koha_20.11_D11 build #101: UNSTABLE in 29 min: https://jenkins.koha-community[…]ha_20.11_D11/101/ | |
| 16:08 | Project Koha_20.11_U18 build #67: SUCCESS in 44 min: https://jenkins.koha-community[…]oha_20.11_U18/67/ | |
| 16:19 | Project Koha_Master_U2010 build #159: FAILURE in 1 min 13 sec: https://jenkins.koha-community[…]Master_U2010/159/ | |
| 16:21 | Project Koha_20.11_U20 build #71: SUCCESS in 56 min: https://jenkins.koha-community[…]oha_20.11_U20/71/ | |
| 16:29 | Bob joined #koha | |
| 16:29 | Bob | Bonjour |
| 16:30 | caroline_catlady | now I have the Beauty & the Beast "Bonjour" song in my head lol! Bonjour! Bonjour! Bonjour, Bonjour Bonjour! |
| 16:30 | Bob | Hi ! |
| 16:30 | caroline_catlady | There goes the baker with his tray like always! |
| 16:30 | (sorry I can sing disney songs for days) | |
| 16:31 | Bob | I have a issue with koha, is it the right place ? |
| 16:31 | caroline_catlady | yes, don't mind my ramblings |
| 16:31 | Bob | ;-) |
| 16:31 | koha-jenkins | Project Koha_Master_D10_CPAN build #301: STILL FAILING in 10 min: https://jenkins.koha-community[…]ter_D10_CPAN/301/ |
| 16:31 | Project Koha_Master_D11 build #273: STILL UNSTABLE in 33 min: https://jenkins.koha-community[…]a_Master_D11/273/ | |
| 16:34 | kohaputti | has anybody investigated startmans --preload-app option for Koha? I notice my RAM usage went down almost 2G when using --preload-app and loading plack happens in split second instead of taking 5-10 seconds. |
| 16:35 | https://metacpan.org/pod/distr[…]an/script/starman mentions it might have unwanted side effects so I don't know if that applies to koha | |
| 16:37 | Bob | I have this message in validation " Les champs du biblio.biblionumber et du biblioitems.biblioitemnumber doivent être liés à un sous-champ MARC," but I cannot edit those fields in koha => MARC... what can I do? |
| 16:39 | kohaputti | oh, the doc also mentions the -M option to starman, so even if some of our code cannot use this preload feature we could use it in other parts |
| 16:41 | koha-jenkins | Project Koha_Master_D10_CPAN build #302: STILL FAILING in 10 min: https://jenkins.koha-community[…]ter_D10_CPAN/302/ |
| 16:41 | Project Koha_Master_D9_MDB_Latest build #573: FAILURE in 20 min: https://jenkins.koha-community[…]9_MDB_Latest/573/ | |
| 16:42 | caroline_catlady | Bob I've never tried it, but maybe you can edit your bibliographic framework by exporting and importing it back |
| 16:43 | Bob | Ok I will try, thanks for you help |
| 16:43 | caroline_catlady | Bob https://inlibro.com/knowledge-[…]et-importation-2/ |
| 16:43 | it would be in the "kohafield" column | |
| 16:45 | koha-jenkins | Project Koha_20.11_U16 build #70: UNSTABLE in 1 hr 35 min: https://jenkins.koha-community[…]oha_20.11_U16/70/ |
| 16:47 | Bob | I koha-jenkins am using a fresh install of koha 20.11.04.000 |
| 16:49 | koha-jenkins | Project Koha_20.11_D9 build #86: SUCCESS in 1 hr 8 min: https://jenkins.koha-community[…]Koha_20.11_D9/86/ |
| 16:51 | tuxayo | Is that a big deal in "MARC bibliographic framework test" to have: |
| 16:51 | The biblio.biblionumber and biblioitems.biblioitemnumber fields be mapped to a MARC subfield, | |
| 16:51 | koha-jenkins | Project Koha_Master_D9 build #1630: STILL FAILING in 20 min: https://jenkins.koha-community[…]a_Master_D9/1630/ |
| 16:51 | Project Koha_Master_D10_CPAN build #303: STILL FAILING in 10 min: https://jenkins.koha-community[…]ter_D10_CPAN/303/ | |
| 16:53 | tuxayo | unimarc test data have this error but marc21 doesn't |
| 16:55 | koha-jenkins | Project Koha_Master_D10_CPAN build #304: STILL FAILING in 10 min: https://jenkins.koha-community[…]ter_D10_CPAN/304/ |
| 17:23 | tcohen | tuxayo it means things are broken? |
| 17:28 | tuxayo | tcohen: maybe, i was helping someone to troubleshoot issues and this check was failing. But so it does on unimarc base data. And I found a unimarc demo with also this check failing |
| 17:28 | tcohen | this is about 999$b and 999$c being mapped |
| 17:28 | right? | |
| 17:28 | tuxayo | So I directed them to the french mailing list to ask if other working instances have this failing check. |
| 17:29 | In unimarc base data it's 001 @ and 090 a . Maybe the check is only for marc21 | |
| 17:32 | huginn | News from kohagit: Bug 16787: (follow-up) Add and adjust ILSDI tests <https://git.koha-community.org[…]7ce5767b1c7fb3f75> |
| 17:34 | caroline_catlady | tuxayo: I don't know if it's marc21 specific... I think it looks at Administration > Koha to MARC mapping and checks if biblionumber and biblioitemnumber have values |
| 17:34 | if it's a fresh install, I think maybe something in the default framework is broken? | |
| 17:35 | tuxayo | fresh 20.11.04 |
| 17:35 | Even if they have values, the check fails | |
| 17:36 | koha-jenkins | Project Koha_Master_D9_MDB_Latest build #574: STILL FAILING in 3 min 10 sec: https://jenkins.koha-community[…]9_MDB_Latest/574/ |
| 17:37 | caroline_catlady | the sql for the framework seems ok... if it's juste that the check fails, I wouldn't worry about it too much, as long as they can catalog and the records are saved |
| 17:38 | koha-jenkins | Project Koha_Master_D9 build #1631: STILL FAILING in 2 min 2 sec: https://jenkins.koha-community[…]a_Master_D9/1631/ |
| 17:40 | tuxayo | thanks for the check caroline_catlady |
| 17:42 | koha-jenkins | Project Koha_Master_D10_CPAN build #305: NOW UNSTABLE in 52 min: https://jenkins.koha-community[…]ter_D10_CPAN/305/ |
| 17:42 | Project Koha_Master_D10_CPAN build #306: STILL UNSTABLE in 48 min: https://jenkins.koha-community[…]ter_D10_CPAN/306/ | |
| 17:42 | Project Koha_Master_D10_CPAN build #307: FAILURE in 4 min 16 sec: https://jenkins.koha-community[…]ter_D10_CPAN/307/ | |
| 17:44 | tuxayo | code «# checks biblio.biblionumber and biblioitem.biblioitemnumber (same tag and tab=-1) |
| 17:44 | » | |
| 17:44 | It's the same tag in marc21 but not in unimarc | |
| 17:44 | hence the check failing | |
| 17:44 | koha-jenkins | Project Koha_Master_D11 build #274: FAILURE in 2 min 3 sec: https://jenkins.koha-community[…]a_Master_D11/274/ |
| 17:44 | caroline_catlady | ah! |
| 17:45 | koha-jenkins | Project Koha_Master_D9_My8 build #553: FAILURE in 31 sec: https://jenkins.koha-community[…]aster_D9_My8/553/ |
| 17:45 | caroline_catlady | I don't know why it has to be in the same tag... |
| 17:47 | koha-jenkins | Project Koha_Master_D10_CPAN build #308: STILL FAILING in 2 min 2 sec: https://jenkins.koha-community[…]ter_D10_CPAN/308/ |
| 17:53 | Project Koha_Master build #1625: STILL UNSTABLE in 1 hr 14 min: https://jenkins.koha-community[…]Koha_Master/1625/ | |
| 17:57 | cait1 joined #koha | |
| 18:13 | caroline_catlady | khall++ |
| 18:18 | * caroline_catlady | wishes we could have a koha cookbook potluck |
| 18:28 | koha-jenkins | Yippee, build fixed! |
| 18:28 | wahanui | Congratulations! |
| 18:28 | koha-jenkins | Project Koha_Master_U2010 build #160: FIXED in 46 min: https://jenkins.koha-community[…]Master_U2010/160/ |
| 18:56 | Yippee, build fixed! | |
| 18:56 | wahanui | Congratulations! |
| 18:56 | koha-jenkins | Project Koha_Master build #1626: FIXED in 1 hr 2 min: https://jenkins.koha-community[…]Koha_Master/1626/ |
| 19:17 | tuxayo | Is that expected : |
| 19:17 | 1. Administration › MARC frameworks => new framework | |
| 19:17 | 2. Marc structure | |
| 19:17 | 3. Internal server error | |
| 19:17 | caroline_catlady | lol! |
| 19:54 | koha-jenkins | Project Koha_Master build #1627: UNSTABLE in 57 min: https://jenkins.koha-community[…]Koha_Master/1627/ |
| 19:59 | cait | not quite |
| 19:59 | it should ask you to copy an existing on | |
| 19:59 | e | |
| 20:00 | tuxayo: I don't replicate on master? | |
| 20:00 | oleonard joined #koha | |
| 20:00 | tuxayo | cait: thanks I will do more tests |
| 20:01 | cait | hm maybe i should repeat after a git pull |
| 20:02 | any special chars in your frameowrkcode? | |
| 20:03 | tuxayo: latest master is still ok for me | |
| 20:08 | philor | fails for me: MARC bibliographic framework > New framework, code ABC description DEF, Submit, find it in the list, Actions > MARC structure, boom |
| 20:09 | not that I would actually ever do anything other than create > import, I'm not going to create a whole framework from scratch | |
| 20:57 | tuxayo | thanks both for trying :) |
| 20:57 | So it seems it can crash. Now trying to find what could be different. | |
| 21:00 | 'koha_kohadev.biblio_framework.frameworktext' isn't in GROUP BY [for Statement "select count(*),marc_tag_structure.frameworkcode,frameworktext from marc_tag_structure,biblio_framework | |
| 21:00 | WHERE biblio_framework.frameworkcode=marc_tag_structure.frameworkcode group by marc_tag_structure.frameworkcode"] | |
| 21:04 | Might be the DBMS, which are yours cait , philor ? Mine is MariaDB 10.5 | |
| 21:04 | A PTFS-E sandbox have MariaDB 10.1 and it crashes | |
| 21:13 | philor | tuxayo: maria 10.1 for me, too |
| 21:34 | cait | that certainly looks like "strict mode" striking again |
| 21:35 | look for the mysql omnibus bug | |
| 21:35 | and file it | |
| 21:35 | hter are more like it that require rewrites | |
| 23:16 | tuxayo | :o thanks |
| 23:52 | Is bug 17258 the one about SQL strict mode? | |
| 23:52 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=17258 major, P5 - low, ---, jonathan.druart, NEW , [OMNIBUS] MySQL 5.7 |
← Previous day | Today | Next day → | Search | Index