← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:31 | inlibro joined #koha | |
| 01:05 | AndrewFH joined #koha | |
| 01:31 | inlibro joined #koha | |
| 02:31 | inlibro joined #koha | |
| 02:45 | sonOfRa joined #koha | |
| 03:31 | inlibro joined #koha | |
| 04:07 | koha-jenkins | Project Koha_Master_D10 build #486: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]a_Master_D10/486/ |
| 04:32 | inlibro joined #koha | |
| 05:32 | inlibro joined #koha | |
| 06:32 | inlibro joined #koha | |
| 07:06 | ashimema | Joubu++ # fantastic set of pushes yesterday. |
| 07:06 | Morning #koha | |
| 07:14 | did joined #koha | |
| 07:15 | ere joined #koha | |
| 07:16 | Joubu | sorry ashimema, I haven't found anything to FQA at least one of them |
| 07:16 | :D | |
| 07:19 | ashimema | Let me know if you want a hand getting Jenkins green again :) |
| 07:19 | more than happy to help | |
| 07:28 | reiveune joined #koha | |
| 07:28 | reiveune | hello |
| 07:28 | ashimema | My todo list today.. bug 22824, bugs linked to bug 27829... wish me luck.. haha |
| 07:29 | then bug 25260 | |
| 07:29 | it's gonna be a busy day. haha | |
| 07:31 | Joubu | ashimema: first the failing tests please :) |
| 07:32 | inlibro joined #koha | |
| 07:37 | ashimema | okies |
| 07:37 | fridolin joined #koha | |
| 07:37 | * ashimema | starts with waiting_or_in_transit test |
| 07:41 | ashimema | humm, can't replicate that one here right now.. |
| 07:41 | * ashimema | updates k-t-d |
| 07:46 | Joubu | ashimema: biblios.t you mean? |
| 07:46 | ashimema | Mm, |
| 07:47 | It just passed three times in a row for me | |
| 07:47 | Joubu | failing here |
| 07:47 | ashimema | I'm just stopping k-t-d now to make sure I'm running exactly as on Jenkins |
| 07:47 | Weird | |
| 07:47 | All good, I'm sure I'll get there | |
| 07:47 | Joubu | fetch origin? :) |
| 07:48 | ashimema | Yup |
| 07:55 | alex_a joined #koha | |
| 07:56 | alex_a | Bonjour |
| 08:05 | lds joined #koha | |
| 08:07 | paul_p joined #koha | |
| 08:09 | ashimema | doh.. pre coffee brain |
| 08:09 | I was running Biblio.t not Biblios.t | |
| 08:13 | nlegrand joined #koha | |
| 08:13 | nlegrand | Bonjour #koha ! |
| 08:15 | fridolin | Joubu: Bug 26363 do we need to urgently push into master and stable ? |
| 08:24 | Joubu | I will push it in the next couple of hours |
| 08:25 | why is that so urgent? | |
| 08:29 | ashimema | Biblios.t fix attached to bug 26057, moving onto the Reserves.t failure now Joubu |
| 08:32 | inlibro joined #koha | |
| 08:33 | ashimema | damn, a second bloomin thing in my stash! |
| 08:33 | same issue as the first one.. | |
| 08:33 | I'll amend the followup on 26057 | |
| 08:41 | bugger me.. it's the whole mini set.. Im just squashing them all.. save you getting too many followups that are all basically the same problem manifesting in each location | |
| 08:46 | Joubu, the final QA follow-up on bug 26057 should fix all the tests! | |
| 08:46 | seems I had no less than 5 commits stashed here! I've squashed them all into one | |
| 08:49 | Joubu | thx |
| 08:49 | ashimema | not at all.. sorry for my muppet moment forgetting to attach them to the branch |
| 08:50 | moving on to bug 22824 now :) | |
| 08:55 | wow.. so good to see C4::Boolean go away.. dang | |
| 08:56 | Joubu | \o/ |
| 08:57 | ashimema | don't think I'd realised quit how inconsistent our handling of prefs was in this regard |
| 08:57 | this is such a nice changeset | |
| 09:07 | humm.. wonderin what Bernardo meant with the YAML::Syck for the langinstaller | |
| 09:07 | i.e your 'FIXME Really?' haha | |
| 09:07 | I'll ask him | |
| 09:11 | Joubu | I did some testing and it seems to work ok |
| 09:12 | ashimema: the warning and fixme must be removed if pushed | |
| 09:13 | but I wanted to highlight the warning for you/QA | |
| 09:13 | ashimema | indeed |
| 09:13 | I'll have a chat with Bernardo.. try and work out why he thought this in the first place | |
| 09:13 | Joubu | I think what it means is exactly what we are doing in this patchset |
| 09:13 | ashimema | in my quick test, I agree with you.. I can't see any issues.. but maybe we're not seeing what Bernardo was |
| 09:14 | Joubu | before we wanted to rely on $YAML::Syck::ImplicitTyping |
| 09:14 | ashimema | yeah.. |
| 09:14 | consistent change throughout | |
| 09:14 | Joubu | now that we fixed everything we don't need it anymore |
| 09:14 | ashimema | agreed |
| 09:14 | cait joined #koha | |
| 09:15 | magnuse_ | would be interesting to see the proportion of code in Koha:: vs C4:: again, i think we played a bit with that in marseille once upon a time |
| 09:15 | kia ora cait | |
| 09:15 | ashimema | just doing some final testing now and then will PQA I reckon |
| 09:15 | Joubu | ashimema: it's not him - 814795da60318c70059fc1dfbe7be4da37109db0 |
| 09:15 | ashimema | in general, you've caught all the cases that had come to mind |
| 09:15 | cait | good morning all :) |
| 09:15 | ashimema | oh wow.. so it is |
| 09:16 | cait | what did i miss? |
| 09:16 | I'll be around for koha things today and tomorrow, so don't be too surprised :) | |
| 09:16 | ashimema | the world has moved on allot since 2010! |
| 09:16 | :) | |
| 09:16 | Joubu | cait: ashimema's transfer work is pushed you can test it :) |
| 09:16 | cait | excellent timing I'd say :) |
| 09:17 | ashimema | lots of devs in good moods today cait :) |
| 09:17 | cait | oooooh even better |
| 09:17 | who else? | |
| 09:17 | i've got about 500 bug mails to catch up from this week, so I really don't know | |
| 09:17 | ashimema | well.. I've not seen Tomas yet today.. but he was certainly in a great mood last night :) |
| 09:17 | cait | do we know why? |
| 09:18 | ashimema | dunno.. just bouncing well off each other at the minute I reckon |
| 09:19 | cait | for bug 12224 - you meant + - "[% today %]<br />" ? |
| 09:19 | oh still no huginn? | |
| 09:19 | Joubu? i could o that follow up i think then | |
| 09:20 | Joubu | yes |
| 09:20 | ashimema | dang, did I miss a date formatting during QA |
| 09:20 | poop | |
| 09:20 | I'm usually pretty good at spotting those now | |
| 09:20 | cait joined #koha | |
| 09:20 | cait | oops lost connection |
| 09:21 | ashimema | mind you.. when hidden in a long string notice text I can forgive myself a bit |
| 09:21 | cait | Joubu: I'll take care of it, thx! |
| 09:21 | ashimema | :) |
| 09:22 | tcohen | (early) morning |
| 09:22 | ashimema | ooh, tcohen. good morning to you :) |
| 09:23 | Joubu | can't be good, too early! |
| 09:23 | cait | good morning tcohen :) |
| 09:24 | * cait | hands out some leftover birthday cake |
| 09:24 | ashimema | humm, couple of QA script failures.. on that yaml bug.. digging into them now |
| 09:24 | seems to think about.tt doesn't compile | |
| 09:33 | inlibro joined #koha | |
| 09:35 | ashimema | hmm |
| 09:46 | Joubu | mtj: the error says *must*, so I guess that's the docker login command that is failing |
| 09:49 | reiveune1 joined #koha | |
| 09:50 | ashimema | Joubu, do you have any idea why the QA script errors on the about page change for your YAML work? |
| 09:50 | reiveune1 left #koha | |
| 09:51 | ashimema | seems to fail for the 'invalid_yesno.count' part.. seems to stop parsing or something once it's hit it. |
| 09:51 | reiveune1 joined #koha | |
| 09:52 | Joubu | ashimema: will have a look! |
| 09:52 | ashimema | thanks |
| 09:52 | I've had a punt and am just confused by it.. | |
| 09:53 | reiveune1 left #koha | |
| 09:53 | reiveune joined #koha | |
| 09:55 | Joubu | ashimema: oops, there is bad space there |
| 09:56 | ashimema | there is? |
| 09:57 | that's what I thought the error said.. but when I looked at the template itself I couldn't see the problem | |
| 09:57 | Joubu | ·warnNoActiveCurrency |
| 09:58 | ashimema | :q |
| 09:58 | koha-jenkins | Project Koha_Master_D9 build #1578: NOW UNSTABLE in 1 hr 4 min: https://jenkins.koha-community[…]a_Master_D9/1578/ |
| 09:58 | Joubu | ashimema: I reattached the patch |
| 09:58 | ashimema | :) |
| 09:59 | reiveune left #koha | |
| 09:59 | reiveune joined #koha | |
| 10:01 | ashimema | brill |
| 10:05 | * ashimema | is sooooo happy to see the modernisation and cleaning efforts going on in the koha codebase at the moment |
| 10:05 | ashimema | PQA |
| 10:09 | cait | just remember to document, you all! :) |
| 10:09 | ashimema | hehe |
| 10:22 | severine_q joined #koha | |
| 10:23 | severine_q | Hello #Koha :) |
| 10:23 | cait | hi severine_q :) |
| 10:24 | ashimema | cait.. I'm sure Joubu would love you lots if you QA'd the removal of sql translations branches I just SO'd |
| 10:24 | severine_q | Hi cait ! how are you ? |
| 10:25 | cait | there is lots to do, just still going through mails :) |
| 10:25 | ashimema | https://bugs.koha-community.or[…]raph.cgi?id=24973 |
| 10:26 | Hi Severine, I'm great :) | |
| 10:27 | Received your card a couple of days ago.. thankyou.. it's in pride of place in my home office now :) | |
| 10:27 | How are you? | |
| 10:27 | My girls were so excited to see a french postmark on the envelope as it came through the door :) | |
| 10:28 | cait | :) |
| 10:28 | severine_q | Hi ashimema ! |
| 10:28 | cait | severine_q: reminds me - i got the christmas card a few days ago - hadn't been in the office for a long time! |
| 10:28 | severine_q | i'm glad I made them happy :) |
| 10:28 | cait | thank you! it's on my pinboard here now |
| 10:29 | severine_q | nice ! |
| 10:29 | ashimema | There's something very special about this community of people, you're all so lovely :) |
| 10:29 | severine_q | I was happy to send them, I think this year it wasn't as uggly as the previous years :) |
| 10:33 | inlibro joined #koha | |
| 10:39 | reiveune left #koha | |
| 10:42 | koha-jenkins | Project Koha_20.11_U18 build #47: ABORTED in 10 min: https://jenkins.koha-community[…]oha_20.11_U18/47/ |
| 10:42 | Project Koha_Master_D10 build #487: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]a_Master_D10/487/ | |
| 10:44 | Project Koha_20.11_U20 build #51: FAILURE in 1 min 24 sec: https://jenkins.koha-community[…]oha_20.11_U20/51/ | |
| 10:46 | Project Koha_20.11_D9 build #69: FAILURE in 34 sec: https://jenkins.koha-community[…]Koha_20.11_D9/69/ | |
| 10:46 | Project Koha_20.11_U16 build #52: FAILURE in 12 sec: https://jenkins.koha-community[…]oha_20.11_U16/52/ | |
| 10:46 | ashimema: Bug 27680: (QA follow-up) Update test for dbic_merge_sorting | |
| 10:47 | ashimema | hum |
| 10:47 | what's causing the complete failures.. that's weird | |
| 10:48 | Joubu | me |
| 10:48 | I am adding a new node, but docker is not installed.. | |
| 10:48 | ashimema | aha, i see |
| 10:48 | okies | |
| 10:49 | * ashimema | quietly wonders if an rpi would be enough to host a node |
| 10:50 | Joubu | I don't think so, we have the ES container that is exploding because RAM is lacking |
| 10:50 | koha-jenkins | Project Koha_20.11_U2010 build #48: FAILURE in 12 sec: https://jenkins.koha-community[…]a_20.11_U2010/48/ |
| 10:50 | ashimema: Bug 27680: (QA follow-up) Update test for dbic_merge_sorting | |
| 10:50 | Project Koha_20.11_U18 build #48: FAILURE in 12 sec: https://jenkins.koha-community[…]oha_20.11_U18/48/ | |
| 10:50 | ashimema: Bug 27680: (QA follow-up) Update test for dbic_merge_sorting | |
| 10:51 | reiveune joined #koha | |
| 10:53 | mtj | hi Joubu, i think combined ram/swap usage is high as 16 gig, on the docker nodes |
| 10:53 | ashimema | wowsers |
| 10:53 | 16GB! | |
| 10:54 | my pi is 8GB | |
| 10:54 | Joubu | The new node I am adding has 8 |
| 10:54 | will see.. | |
| 10:55 | https://jenkins.koha-community[…]11_D10/68/console | |
| 10:55 | since when do we have a full output?? | |
| 10:57 | koha-jenkins | Project Koha_20.11_D10 build #69: FAILURE in 6 min 26 sec: https://jenkins.koha-community[…]oha_20.11_D10/69/ |
| 10:58 | mtj | hmm, might be more like 13 gig, usage |
| 10:59 | Joubu: since 20.11 was added to ktd, its better for you? | |
| 10:59 | Joubu | what do you mean? |
| 11:00 | https://jenkins.koha-community[…]r_D10/482/console | |
| 11:00 | this is an usual output | |
| 11:00 | there is only the filenames, warnings, and failure | |
| 11:00 | not the list of the different tests that are passing | |
| 11:00 | mtj | do you prefer the full output for 20.11 on jenkins? |
| 11:01 | Joubu | I am not talking about the consoleFull/Full log view |
| 11:02 | koha-jenkins | Project Koha_20.11_U20 build #53: STILL FAILING in 4 min 49 sec: https://jenkins.koha-community[…]oha_20.11_U20/53/ |
| 11:02 | mtj | Joubu: ah ok... i thought you were |
| 11:03 | koha-jenkins | Project Koha_Master_D9 build #1579: FAILURE in 12 sec: https://jenkins.koha-community[…]a_Master_D9/1579/ |
| 11:07 | mtj | Joubu: the difference between the 2 jenkins console logs - is from 20.11 builds running 'prove -v' |
| 11:11 | Joubu | right, I see your commit "add prove -" |
| 11:11 | -v | |
| 11:11 | do you remember why we needed it? | |
| 11:12 | koha-jenkins | Project Koha_Master_D9 build #1580: STILL FAILING in 2 min 43 sec: https://jenkins.koha-community[…]a_Master_D9/1580/ |
| 11:13 | Joubu | "Native controller process has stopped - no new native processes can be started" |
| 11:13 | so 8G is not enough... | |
| 11:13 | awesome | |
| 11:14 | tcohen: shouldn't we consider to run the tests by default without ES and having 1 job with ES running on a specific (big) node? | |
| 11:14 | tcohen | I like that |
| 11:15 | Joubu | or maybe a light test suite that is ran by default (without www and selenium) |
| 11:17 | khall joined #koha | |
| 11:17 | mtj | hmm, i take back my 16 gig statement, looks like only 12 gigs 'committed' |
| 11:18 | ...so, 4G ram, 8G swap might be ok | |
| 11:18 | sorry.. 4G ram, 10G swap | |
| 11:21 | ashimema | next dev meeting is going ot be busy.. I've added a bunch of topics the last couple of days |
| 11:21 | oop | |
| 11:21 | I like that idea too... one meganode for ES | |
| 11:22 | oleonard joined #koha | |
| 11:23 | oleonard | Hi #koha |
| 11:23 | ashimema | morning oleonard |
| 11:23 | koha-jenkins | Project Koha_Master_D9_My8 build #520: NOW UNSTABLE in 51 min: https://jenkins.koha-community[…]aster_D9_My8/520/ |
| 11:25 | mtj | Joubu: 'prove -v' isnt needed - i was only using it for ktd debugging before 20.11.00 release |
| 11:27 | khall_ joined #koha | |
| 11:28 | mtj | i like the idea of a shared ES node for testing |
| 11:33 | inlibro joined #koha | |
| 11:33 | koha-jenkins | Project Koha_20.11_D10 build #68: SUCCESS in 51 min: https://jenkins.koha-community[…]oha_20.11_D10/68/ |
| 11:46 | Yippee, build fixed! | |
| 11:46 | wahanui | Congratulations! |
| 11:46 | koha-jenkins | Project Koha_20.11_U20 build #52: FIXED in 53 min: https://jenkins.koha-community[…]oha_20.11_U20/52/ |
| 11:57 | fridolin joined #koha | |
| 11:57 | jjhon joined #koha | |
| 11:58 | jjhon | hello everyone; i have the following problem, when i make a reservation i need a notice to be sent to the patron's email, this does not happen and koha sends the notice to the library's email. what am i doing wrong? has it happened to anyone? how can i solve it? thanks a lot! |
| 12:02 | Joubu | khall_: one patch is missing on 27842 |
| 12:10 | khall_ | Joubu I'll take care of that! |
| 12:13 | cait | jjhon: the feature does work that way |
| 12:13 | there is no feature to send an email on placing a hold ot the patron at the moment | |
| 12:14 | the mail to the library is intended to speed up processing | |
| 12:14 | ashimema | is it not crazy late for you mtj?.. It's lovely to have you around, but I sometimes wonder if you get enough sleep.. haha |
| 12:14 | cait | khall_: when you get to it... judging form the comments you'd make a lot of librarians happy with a rebase of bug 20262 |
| 12:15 | ashimema | I have a vague feeling there might be a bug open asking for that enhancement |
| 12:15 | * ashimema | wnats huggin back |
| 12:15 | * cait | lights the QA signal |
| 12:15 | cait | 94 in signed off! |
| 12:16 | do we know which server huginn lives on? | |
| 12:16 | oleonard | it's gmcharlt's, and he doesn't seem to be around |
| 12:17 | * ashimema | has a feeling rebasing bug 20262 might be easier said than done.. I know I've touched allot there since that was written.. wasn't aware of that one |
| 12:18 | cait | oleonard: his personal oneß |
| 12:18 | ? | |
| 12:18 | oleonard | I don't know about that |
| 12:20 | ashimema | I have a vague feeling it's on bugs.koha-community.org's server |
| 12:20 | jjhon | thank you <cait>. |
| 12:21 | cait | ashimema: that would be rangi's then |
| 12:21 | Joubu: I believe the git server section requires an update? *hint* https://wiki.koha-community.or[…]dministration#git.koha-community.org | |
| 12:21 | ashimema | mmm, it's certainly one I don't have access to.. and even if I did.. I don't know how hugging runs |
| 12:22 | cait | i like that bot name typo |
| 12:22 | shows your love for it :) | |
| 12:22 | ashimema | lol |
| 12:23 | oleonard | ashimema: After a year in quarantine none of us know how hugging runs. |
| 12:26 | ashimema | :D |
| 12:27 | oleonard | ashimema: do you know anything about the "renew_results" parameter referenced in pay.pl ? |
| 12:28 | khall_ | cait 20262 has sat for over a year, so I don't have high hopes, but I'll give it a shot! |
| 12:28 | ashimema | vaguely.. I seem to remember AndrewIsh added it? |
| 12:31 | reiveune left #koha | |
| 12:31 | ashimema | how can I help oleonard? |
| 12:32 | oleonard | I just can't see how the parameter is passed from anywhere, and I'm trying to understand the circumstances under which renew_results.inc is used. |
| 12:32 | AndrewFH joined #koha | |
| 12:32 | ashimema | ok, give me a few mins and I'll remind myself how it works |
| 12:33 | inlibro joined #koha | |
| 12:33 | ashimema | it was added in bug 23051. |
| 12:35 | oleonard | Joubu: Did the CSS get updated after the follow-up to Bug 25846? |
| 12:36 | ashimema: The bug reference helps. I don't usually test with fine-accruing items so that's where I'll start. You don't need to go any further. | |
| 12:37 | reiveune joined #koha | |
| 12:38 | cait | :) |
| 12:38 | oleonard: working on your patches, but don't tell anyone I favor you :P | |
| 12:38 | ashimema | it happens if you pay off the fine on a still checked out item |
| 12:38 | it automatically renews the item so the fine stops accruing | |
| 12:39 | I can't seem to find if it was attached to a syspref though right now.. the code looks like it wasn't | |
| 12:39 | hope that helps :) | |
| 12:46 | cait | I still have the email issue when testing self registration: |
| 12:46 | Invalid 'from' parameter: root localhost at /usr/share/perl5/Exception/Class/Base.pm line 88 |
|
| 12:46 | and I SWEAR my KohaAdminEmailAddress is not root@ | |
| 12:46 | it's actaully katrinsomething.de |
|
| 12:47 | Joubu: help? I know you didn't believe me firt time around... but maybe a fresh start? :) | |
| 12:47 | tcohen | git grep Email::Valid |
| 12:47 | ^^ for some hints? | |
| 12:48 | cait | what am i looking for? |
| 12:48 | actually i was wondering if this oculd be linked to the smtp config and kohadevbox? | |
| 12:49 | tcohen | cait: that looks like the output from Koha::Email->create |
| 12:49 | reiveune1 joined #koha | |
| 12:49 | cait | it's trying to send the verification email |
| 12:49 | and failing | |
| 12:49 | reiveune1 left #koha | |
| 12:50 | tcohen | you need to track where Koha::Email->create is called |
| 12:50 | cait | PatronSelfRegistrationVerifyByEmail |
| 12:50 | wahanui | PatronSelfRegistrationVerifyByEmail is set to not required on both server |
| 12:50 | tcohen | and see what is being set for the from field |
| 12:50 | cait | i had this discussion in length on a bug with Joubu |
| 12:50 | he swears on kohaadminemailaddress | |
| 12:50 | but it doesn't fit the error | |
| 12:50 | PatronSelfRegistrationVerifyByEmail | |
| 12:50 | wahanui | PatronSelfRegistrationVerifyByEmail is, like, set to not required on both server |
| 12:52 | TimothyAlexis joined #koha | |
| 12:52 | jzairo joined #koha | |
| 12:52 | cait | tcohen: but your comment reminded me i can just turn off the emial verification for this |
| 12:53 | tcohen | no, we need to get to the root |
| 12:53 | :-D | |
| 12:54 | I agree with Jonathanç | |
| 12:55 | the code clearly passes KohaAdminEmailAddress to C4::Letters::EnqueueLetter | |
| 12:55 | so it must be some cache? | |
| 12:56 | cait | there has been several restart_all in between testing |
| 12:56 | tcohen | so, to reproduce |
| 12:56 | I need to enable PatronSelfRegistrationVerifyByEmail | |
| 12:56 | and set a sane address on KohaAdminEmailAddress | |
| 12:56 | and try to register | |
| 12:56 | cait | yes |
| 12:56 | but he couldn't see the problem... so I am quite stuck, maybe you can | |
| 12:58 | tcohen | I'm trying now |
| 12:58 | cait | thx |
| 12:59 | maybe it's just not doable anymore without a real working email setup? | |
| 13:00 | tcohen | that would be wrong |
| 13:00 | this is the Koha::Email library raising an exception because the passed 'from' parameter is not a valid email | |
| 13:00 | so, something else is wrong | |
| 13:01 | ok, bad KohaAdminEmailAddress makes it explode as you say | |
| 13:01 | now setting it to something sane! | |
| 13:01 | having it explode because of a bad setup is a bad bug on its own anyway | |
| 13:01 | he | |
| 13:03 | did you use the browser 'back' function, or really started over? | |
| 13:04 | cait | ther have been days and weeks in between tests now :) |
| 13:04 | yes, started over | |
| 13:04 | tcohen | this is weird |
| 13:04 | :-D | |
| 13:05 | cait | ep |
| 13:05 | yep | |
| 13:06 | tcohen | it is coming from nowherE! |
| 13:06 | cait | does this mean you are seeing something odd too or is it still limited to my haunted kohadevbox? |
| 13:06 | tcohen | I managed to reproduce it in koha-testing-docker |
| 13:07 | cait | ok, so at least we can establish it's not only me :) |
| 13:08 | fridolin | cait: Bug 21883 ready for testing, thanks a lot this is asked a lot by our customers |
| 13:08 | https://bugs.koha-community.or[…]_bug.cgi?id=21883 | |
| 13:14 | tcohen | cait: got it |
| 13:14 | cait | what is it? |
| 13:14 | wahanui | well, it is probably set to oldoldstable or 18.11 |
| 13:15 | tcohen | when I first tried, it exploded because rootlocalhost was set (by default) in KohaAdminEmailAddress |
| 13:15 | I changed it to my personal address | |
| 13:15 | retried, BOOM | |
| 13:15 | same error, mentioning rootlocalhost |
|
| 13:16 | I did a koha-dump --exclude-indexes kohadev | |
| 13:16 | zcat /var/spool/koha/kohadev/kohadev-2021-03-04.sql.gz | grep 'rootlocalhost' |
|
| 13:16 | and noticed the message_queue actually had the first attempt | |
| 13:16 | so when you add a new register request, with a good setup | |
| 13:17 | it still tries to send the first one, from the message_queue table | |
| 13:17 | and explodes | |
| 13:17 | cait | aah |
| 13:17 | tcohen | I removed it from message queue and it started working |
| 13:17 | so we need to make sure bad addresses don't reach the message_queue | |
| 13:17 | that's a bug to file IMHO | |
| 13:18 | cait | I'll try to do that in a few minutes - thx! |
| 13:19 | zjmarlow joined #koha | |
| 13:19 | tcohen | great! |
| 13:19 | cait | why is causing rootlocalhost such trouble btw? i remember testing with localhost setup in th epast |
| 13:19 | not for production servers, of course, bu ti thought it was ok for local testing? | |
| 13:19 | tcohen | that's because the Email::Valid library doesn't consider it valid |
| 13:21 | will file an Issue on the library's project, we can at least request a good explanation | |
| 13:22 | cait | cool :) |
| 13:23 | oleonard | Hey while you're talking email, does anyone remember if it is the case that system preferences which ask for an email can accept multiple emails? |
| 13:23 | tcohen | I don't think so |
| 13:24 | cait | i believe to have seen some libraries claiming that worked in the past... but it's not inended use for sure |
| 13:24 | there is an old bug about sending emails to multiple email addresses that did never make it in | |
| 13:25 | * oleonard | asks before submitting a patch for Bug 27805 |
| 13:25 | oleonard | https://bugs.koha-community.or[…]_bug.cgi?id=27805 |
| 13:25 | cait | thx oleonard :) |
| 13:26 | oleonard: hm actually that would no longer allow to enter adminlocalhost |
|
| 13:26 | so maybe we need to think this through an dchange the default for kohaadminemailaddress? | |
| 13:28 | oleonard | I'm pretty sure I tested that. It trigger's the browser's built-in email address validation which is fairly loose |
| 13:28 | I'll be sure to test again before I submit | |
| 13:29 | cait | ok :) |
| 13:30 | going to file the queue bug now | |
| 13:33 | Joubu | cait: wiki page updated |
| 13:33 | oleonard: indeed, I forgot to regenerate the css! oops | |
| 13:33 | inlibro joined #koha | |
| 13:34 | AndrewFH joined #koha | |
| 13:35 | cait | tcohen: Bug 27860 - Bad KohaAdminEmailAddress breaks patron self registration form until notice is removed from message queue |
| 13:36 | thx for investigating1 | |
| 13:36 | Joubu | I don't understand why it tries to send the existing notice |
| 13:36 | tcohen | Email::Valid has tests to check *.localhost addresses are considered invalid, as per some RFC I couldn't track |
| 13:36 | cait | tcohen++ |
| 13:36 | tcohen | so I guess the answer will be 'no' |
| 13:36 | Joubu good point | |
| 13:36 | cait | i know |
| 13:37 | becuase of the method we use to send "immediately" for notices in the message quuee | |
| 13:37 | it tries to send all unsend ones with the lettercode | |
| 13:37 | Joubu | yes but we generate it, then send it right away |
| 13:37 | it shouldnt | |
| 13:37 | cait | how would we do it differently? |
| 13:37 | tcohen | the fix should check the setup is sane, and report back to the user to contact the sysadmin |
| 13:37 | cait | it's the easiest way |
| 13:38 | otherwise you'd have to get back the id for the generated message_queue entry | |
| 13:38 | tcohen | instead of queuing the message and waiting for the SendLetters call to explode |
| 13:38 | cait | to make sure we onyl try to send this one |
| 13:38 | Joubu | 209 my $num_letters_attempted = C4::Letters::SendQueuedMessages( { |
| 13:38 | 210 letter_code => 'OPAC_REG_VERIFY' | |
| 13:38 | 211 } ); | |
| 13:38 | yes, that's bad | |
| 13:38 | cait | yep exactly |
| 13:38 | we have the same call for password resets iirc | |
| 13:38 | Joubu | it should pass an id |
| 13:39 | cait | where would it get it from? |
| 13:39 | Joubu | message_queue.message_id |
| 13:39 | cait | yes |
| 13:39 | but do we get the id back? | |
| 13:40 | ashimema | Joubu... |
| 13:40 | wahanui | joubu is kidding, right ;) |
| 13:40 | Joubu | enqueueletter returns it |
| 13:40 | cait | ok |
| 13:40 | then we should :) | |
| 13:41 | i didn't know htat | |
| 13:42 | ashimema | Joubu, why do we filter by the current logged in users branch when calling delete in Koha::Patron->extended_attributues($new_set) |
| 13:42 | something feels weird there | |
| 13:42 | Joubu | 1561 $self->extended_attributes->filter_by_branch_limitations->delete; |
| 13:42 | that | |
| 13:42 | ashimema | yup |
| 13:43 | it feels to me like we'd either want to just delete all attributes.. or filter by the patrons homebranch | |
| 13:43 | magnuse_ | cait++ tcohen++ |
| 13:43 | ashimema | not the current staff member branch? |
| 13:45 | Joubu | When you (librarian) create a patron you display the attributes you can see |
| 13:45 | and that's the ones your library has access | |
| 13:45 | ashimema | hum |
| 13:45 | Joubu | "Select "All libraries" if this attribute type should always be displayed. Otherwise select libraries you want to associate with this value." |
| 13:45 | ashimema | that kinda makes sense |
| 13:47 | still seems somewhat odd.. but I'm sure it's just my brain playing games | |
| 13:47 | * ashimema | is investigating mandatory attributes |
| 13:48 | ashimema | I presume that is the same.. they're linked to the librarian performing the action, not the patron |
| 13:49 | TimothyAlexis | So... Today I've tried reinstalling everything in order to get koha-testing-docker to work again... |
| 13:50 | Now I'm getting this instead: | |
| 13:50 | koha_1 | Cannnot open file No such file or directory at /kohadevbox/misc4dev/cp_debian_files.pl line 35. | |
| 13:50 | koha_koha_1 exited with code 2 | |
| 13:52 | marie-luce joined #koha | |
| 13:53 | Dyrcona joined #koha | |
| 13:54 | tcohen | Joubu, ashimema should the API be able to overwrite all the things? |
| 13:55 | and in that case, should we add a flag to the method for explicitly overwriting them all? | |
| 13:55 | ashimema | good question |
| 13:56 | amoyano joined #koha | |
| 13:56 | * tcohen | is thinking in terms of x-koha-override |
| 13:56 | ashimema | if this linked to the patron homebranch then we can catch things more clearly |
| 13:57 | tcohen | it feels like using the patron's home branch fits better |
| 13:57 | because you either are a superlibrarian that can do all things | |
| 13:57 | ashimema | as it appears to be linked to the librarian performing the action.. I think that's far less clear.. in effect the api patron is likely a superlibrarian level.. they don't want to be limited by a particular branch |
| 13:57 | I agree | |
| 13:57 | tcohen | in which case the constraints should be those from the patron's home branch |
| 13:57 | ashimema | there's even a note in the filter that says.. we should probably not limit by homebranch if it's a superlibrarian carying out the action |
| 13:58 | Joubu | TimothyAlexis: echo $SYNC_REPO? |
| 13:58 | tcohen: overwritting all the things? the patron attributes? | |
| 13:59 | tcohen | you can easily reach a situation in which the patron is set some attributes by some other branch's librarian, and they are not visible to the home library |
| 13:59 | Joubu yes | |
| 13:59 | ashimema | but yeah.. if the UI currently uses the logged in branch to know what to display.. then the UI doesn't allow for a superlibrarian to change a patron from another branch unless the superlibrarian switches branch |
| 13:59 | TimothyAlexis | $SYNC_REPO is /usr/local/Koha |
| 13:59 | ashimema | exactly what tcohen said |
| 13:59 | TimothyAlexis | Where I've got Koha cloned into. |
| 14:00 | tcohen | export SYNC_REPO=/usr/local/Koha |
| 14:00 | ku | |
| 14:00 | is that what you're running? | |
| 14:00 | TimothyAlexis | I put it in .bashrc |
| 14:01 | Joubu | TimothyAlexis: that's the known error when SYNC_REPO is not set properly |
| 14:01 | TimothyAlexis | Yes I'm starting it with 'ku' |
| 14:01 | hmm | |
| 14:04 | Joubu | tcohen, ashimema: Bug 7919 - Display of values depending on the connexion library (authorised values, patron categories, extended attributes) |
| 14:04 | I wanted to make sure it was the expected behaviour | |
| 14:04 | sooo | |
| 14:05 | that's tricky :D | |
| 14:05 | cait | it certainly sounds tricky |
| 14:05 | ashimema | hum,, fun |
| 14:06 | Joubu | maybe we should assume logged in library == borrowers.branchcode?.. |
| 14:07 | TimothyAlexis | OK I got past that, but have the same error as before :) |
| 14:09 | tcohen | Joubu, ashimema maybe 'display' is not exactly the same as being able to set |
| 14:09 | Joubu | TimothyAlexis: sorry to insist but, before you run the ktd command you should make sure the env var is set: ls $SYNC_REPO/Koha.pm |
| 14:09 | pastebot | "TimothyAlexis" at 127.0.0.1 pasted "This is the full output to terminal after running 'ku'" (348 lines) at http://paste.koha-community.org/27965 |
| 14:09 | Joubu | tcohen: you are cheating |
| 14:10 | tcohen | am I |
| 14:10 | Joubu | not displaying means you cannot access it |
| 14:10 | TimothyAlexis | I'm getting "/usr/local/koha/Koha.pm" |
| 14:10 | tcohen | because you don't want those attributes set for patrons on X branch |
| 14:11 | Joubu | TimothyAlexis: so it's not the same error, try "kd" first to destroy the DB |
| 14:11 | tcohen | but you can change the session branch, and set them |
| 14:11 | TimothyAlexis | Joubu: I mean, the same error as yesterday, before I reinstalled everything |
| 14:11 | tcohen | and then, when we 'display' the patron's info it displays the attributes, depending on the caller's logged branch |
| 14:11 | but the attributes are all set | |
| 14:12 | that's the current behavior | |
| 14:12 | I'm too used to play with the superlibrarian user in the dev env, aren't I | |
| 14:12 | ashimema | sorry.. I was still reading the bug |
| 14:12 | tcohen | can a non-superlibrarian switch branches? |
| 14:13 | ashimema | yes they can |
| 14:13 | so long as singlebranchmode isn't enabled.. I think | |
| 14:13 | tcohen | so yeah |
| 14:13 | ashimema | or maybe there are some other prefs at play |
| 14:13 | care to weight in cait? | |
| 14:13 | tcohen | any attribute can be set to a patron right now, and it just displays the ones frmo the logged branch |
| 14:14 | the patron in the OPAC always logins to its home branch | |
| 14:14 | ashimema | and mandatory is ONLY set at a display level |
| 14:14 | cait | actually - no |
| 14:14 | ashimema | it isn't actually constrained in any way |
| 14:14 | cait | i think it's hard |
| 14:14 | ashimema | haha.. lol |
| 14:14 | tcohen | so they can see OPAC-allowed attributes, from their home branchç |
| 14:14 | cait | independentbranches also doesn't allow to switch branches |
| 14:15 | if that is of any help... | |
| 14:15 | tcohen | my feeling is we should leave that to the controllers, on each scenario |
| 14:15 | ashimema | that's the other one I was thinking of.. thanks cait |
| 14:16 | Joubu | if you are from library A and attr B is restricted to library B, patron (from the OPAC) shouldn't be allowed to get/set attr B |
| 14:16 | tcohen | agreed |
| 14:17 | ashimema | well.. any time I've trained this I've always said the mandatory etc options in those attributes are a) inclusive.. i.e if you set mandatory + only at branches x, y, z + only for category code then it's the full set.. it's not mandatory for all categorycodes.. only the ones you selected it could be applied to.. etc etc. |
| 14:17 | tcohen | so, from the OPAC POV, attributes belonging to teh home branch are displayed |
| 14:17 | ashimema | and b |
| 14:17 | Joubu | so maybe you should check the permissions? |
| 14:17 | ashimema | it was about the patron.. not about the librarian setting them |
| 14:17 | Joubu | if you can login on staff then you can edit all of them |
| 14:19 | tcohen | Joubu so it is a display problem (modulo IndependentBranches) |
| 14:20 | I need my brain to rest a bit | |
| 14:20 | ashimema | broken brain |
| 14:21 | it seems wrong to be able to set a patron to have attributes that don't relate at all to their homebranch | |
| 14:21 | humm.. or is it.. | |
| 14:21 | tcohen | it feels wrong |
| 14:21 | ashimema | might you have different rules at different branches that rely on an attribute that's local to that branch... |
| 14:21 | Joubu | a use case is: Patron from A go to library A, the librarian can set some attributes from this library. Then patron goes to B and other attributes are set there |
| 14:22 | ashimema | and have a roaming borrower that needs attributes setting for multiple branches? |
| 14:22 | yowsers.. how the heck does that then work with mandatory on top.. | |
| 14:23 | So.. I'm starting to agree that we shouldn't wipe out other branches attributes in this case | |
| 14:24 | but at the same time.. mandatory needs handling at a different level | |
| 14:24 | cait | oleonard: where is he forget link when using "search to hold"? |
| 14:24 | i thought it was in hte pull down on the detail page... but it's not | |
| 14:24 | ashimema | is mandatory in relation to the patrons branch, the librarians branch.. or does it ignore branches entirely.. i.e. should it require that's it's a global attribute and not a branch specific one |
| 14:25 | oleonard | cait: It should be |
| 14:25 | cait | hm i only have Place hold and Place hodl for... |
| 14:25 | oleonard | Bug 27749? |
| 14:25 | cait | exactly |
| 14:25 | Joubu | ashimema, tcohen: (not related) https://gitlab.com/koha-commun[…]erge_requests/191 would that works? (I haven't tested it) |
| 14:27 | tcohen | it looks correct |
| 14:27 | ashimema | humm |
| 14:27 | oleonard | cait: I think we must be misremembering |
| 14:27 | ashimema | don't the tests that require elastic already just skip if elastic isn't present/turned on.. |
| 14:28 | and isn't turning elastic on optional in how we start k-t-d? | |
| 14:28 | tcohen | not in the docker-compose.yml |
| 14:29 | ashimema | oooh.. |
| 14:29 | so it isn't | |
| 14:29 | I thought ES was optional.. but defaulted to on. | |
| 14:30 | Joubu | the find|prove does not work actually |
| 14:30 | ashimema | I think I'd generalise it more |
| 14:30 | Joubu | well, the -s does not work |
| 14:30 | tcohen | shuffle? |
| 14:31 | Joubu | yes |
| 14:31 | they are execute in the same order | |
| 14:31 | d | |
| 14:31 | tcohen | so, what is needed is |
| 14:31 | - not running ES | |
| 14:31 | - not setting ES in ENV, so the tests are skipped | |
| 14:31 | * ashimema | would like a ku that ran without ES... that would really help with my local dev env.. haha |
| 14:32 | ashimema | indeed |
| 14:32 | tcohen | so we should be able to solve it only with the docker-compose file |
| 14:32 | Joubu | I wanted to drop www and selenium, they are slow |
| 14:32 | ashimema | humm.. so long as they finish I'd say selenium and www aren't too bad.. are they? |
| 14:33 | Joubu | not bad but slow :) |
| 14:33 | ashimema | but then.. I suppose if we have a bigger node running them anyways there's no real reason to worry about them in the light nodes |
| 14:33 | Joubu | too many jobs (8x1h) per push |
| 14:33 | ashimema | yeah.. I've come around |
| 14:33 | tcohen | I like this, having one big node for the heavy lifting |
| 14:34 | inlibro joined #koha | |
| 14:34 | tcohen | and light runs on the rest of them |
| 14:34 | ashimema | ok.. so looking at your patch again with that in mind.. |
| 14:34 | cait | oleonard: hm i am pretty sure... that we had a forget one |
| 14:34 | ashimema | why set SELENIUM_ADDR and SELENIUM_PORT ;) |
| 14:35 | Joubu | indeed |
| 14:35 | because I am a developer and I copy pasted the above :D | |
| 14:36 | ashimema | haha |
| 14:36 | I still think it might be nice to have a middle ground that can run selenium + www without having to also include ES | |
| 14:36 | Joubu | (updated) |
| 14:36 | ashimema | from the jenkins side I think this is great |
| 14:36 | cait | oleonard: even without the forget link i have trouble with the club |
| 14:37 | ashimema | from the running a local dev env side.. I'd love to have an easy alias to ku with selenium with without ES.. |
| 14:37 | I regularly run out of memory when running k-t-d because of the ES box | |
| 14:38 | Joubu | then we must remove it from docker-compose.yml and have a separate one for es |
| 14:38 | ashimema | that's kinda what I'm thinking |
| 14:38 | wahanui | thinking is so much easier |
| 14:38 | ashimema | we already have distinct compose files for es5, es6 and es7 |
| 14:39 | tcohen | we already have a separate es compose file, actually |
| 14:39 | that | |
| 14:39 | ashimema | indeed |
| 14:39 | Joubu | but better to provide a separate yml maybe |
| 14:39 | to not break other things (koha-sandboxes in mind) | |
| 14:39 | tcohen | that's the reason I didn't remove it |
| 14:39 | he | |
| 14:39 | but to be honest, the sandboxes should be using an external single ES server | |
| 14:40 | Joubu | so we end up with the light.yml :) |
| 14:40 | ashimema | yeah.. |
| 14:40 | tcohen | I always said I liked it :-D |
| 14:40 | ashimema | go for it |
| 14:40 | I've come around | |
| 14:40 | Joubu | merge it then :D |
| 14:46 | tcohen | https://gitlab.com/koha-commun[…]pelines/265462978 |
| 14:48 | ashimema | i'm confused.. how do we share a db container in the sandboxes... |
| 14:48 | tcohen | do we? |
| 14:49 | ashimema | I thought we did |
| 14:49 | tcohen | we probably use a custom docker-compose.yml? |
| 14:49 | we should share DB, ES and Selenium | |
| 14:49 | the Java tools are memory intensive | |
| 14:50 | ashimema | looking at the ansible playbook |
| 14:50 | we add a new db prior to starting the k-t-d | |
| 14:51 | tcohen | where's the ansible playbook? |
| 14:51 | I'm not *that* familiar with the sandboxes | |
| 14:51 | ashimema | hum |
| 14:52 | I don't think it uses the compose at all.. | |
| 14:52 | tcohen | I believe it uses it when deploying a new sandbox |
| 14:52 | ashimema | we basically just run this ansible: https://github.com/bywatersolu[…]dbox-instance.yml |
| 14:53 | I'm not great with ansible | |
| 14:53 | but isn't line 60 adding a db.. on localhost | |
| 14:53 | tcohen | line 89 |
| 14:54 | it starts ktd | |
| 14:54 | ashimema | then yeah, 89 starts k-t-d |
| 14:54 | but how does it start it.. | |
| 14:54 | tcohen | and points it to the previously set DB |
| 14:54 | ashimema | using one of our compose files? |
| 14:54 | tcohen | no |
| 14:55 | it only starts the koha-testing container! | |
| 14:55 | ashimema | so yeah.. it does share db's |
| 14:55 | tcohen | so no Selenium |
| 14:55 | Joubu | are you use it does not use docker-compose.yml as default? |
| 14:55 | ashimema | well.. in this case no selenium is fine.. we don't run tests |
| 14:55 | tcohen | we could |
| 14:55 | if testing selenium things | |
| 14:55 | Joubu | I am pretty sure es is running on the sandbox |
| 14:56 | ashimema | am I right in thinking we don't start up ES either on the sandboxes? |
| 14:56 | I thought it was. | |
| 14:56 | but I can't see how here | |
| 14:56 | tcohen | you are looking at a playbook |
| 14:56 | that is launched when a new instance is created | |
| 14:57 | ashimema | indeed |
| 14:57 | tcohen | there's another one for setting THE server |
| 14:57 | https://github.com/bywatersolu[…]andbox-server.yml | |
| 14:57 | it launches ES | |
| 14:57 | and the DB | |
| 14:57 | Joubu | right, that's it |
| 14:57 | tcohen | and a shared memcached as well |
| 14:57 | all using docker | |
| 14:58 | on the same kohanet network | |
| 14:58 | so things work with the default values | |
| 14:58 | oleonard | Joubu: I appreciate your attention to detail always, so I was happy to follow up on Bug 26959 |
| 14:58 | tcohen | tricky, but smart |
| 14:58 | ashimema | https://github.com/bywatersolu[…]x-server.yml#L210 |
| 14:58 | Joubu | haha, thanks oleonard! |
| 14:58 | ashimema | nice one |
| 14:59 | so it does all share a database container, an es container and a memcached container.. right? | |
| 14:59 | nice | |
| 14:59 | tcohen | right |
| 14:59 | khall++ | |
| 15:00 | ashimema | :D |
| 15:00 | tcohen | he's good at gluing things and making them work |
| 15:00 | ashimema | right.. |
| 15:00 | now.. before that distraction.. what the heck was I doing.. lol | |
| 15:01 | tcohen | extended_attributes |
| 15:01 | run away! | |
| 15:01 | haha | |
| 15:01 | ashimema | did we come to a conclusion about mandatory extended_attributes |
| 15:01 | lolo | |
| 15:01 | Joubu | ashimema: you were testing 27526 |
| 15:01 | ashimema | lol |
| 15:01 | tcohen | me too |
| 15:02 | Joubu | ashimema: you were QAing 27526 (in advance) |
| 15:02 | ashimema | hahaha |
| 15:02 | okies.. think I'll move on to that one then.. | |
| 15:02 | extended_attributes has broken my brain.. | |
| 15:02 | I'll leave some notes on the bug with my thoughts and come back to it with fresher eyes later | |
| 15:03 | koha-jenkins | Project Koha_Master_D9 build #1581: STILL FAILING in 3 min 14 sec: https://jenkins.koha-community[…]a_Master_D9/1581/ |
| 15:03 | Joubu | tcohen: 16:03:12 koha_1 | /kohadevbox/run.sh: line 216: syntax error near unexpected token `else' |
| 15:03 | oops | |
| 15:03 | ashimema | bug 25260 rebase was also on my list for today |
| 15:03 | it's been a really productive day.. but damn.. my list is long still | |
| 15:03 | and growing | |
| 15:04 | cait | same |
| 15:05 | tcohen | it never ends |
| 15:05 | cait | nope |
| 15:06 | could we 'cookie' the toggle data menus link on bug 5697? | |
| 15:10 | ashimema | 22569 is now ready for QA cait ;) |
| 15:10 | cait | i am getting a feeling of... overwhelmedness |
| 15:10 | oleonard | cait: I can certainly add that if you think we need it |
| 15:10 | ashimema | hehe |
| 15:11 | cait | i thin it would be nice because it unsets if we page or change number of results too... still writing notes, will submit in a bit |
| 15:13 | oleonard: submitted now on the bug | |
| 15:15 | ashimema: could you take on 27668 maybe? | |
| 15:15 | i signed off as it was blocking another bug in qa queue | |
| 15:15 | ashimema | okies |
| 15:15 | cait | thx! |
| 15:21 | severine_q joined #koha | |
| 15:34 | inlibro joined #koha | |
| 15:41 | cait | ashimema: i migh tmake tomorrow transfers day |
| 15:41 | any chance on you being around? | |
| 15:41 | ashimema | I'll be here |
| 15:42 | cait | okies |
| 15:45 | oleonard | cait++ |
| 15:45 | ashimema++ | |
| 15:45 | Joubu++ | |
| 15:45 | QA++ | |
| 15:45 | Koha++ | |
| 15:46 | This is all pointless isn't it, because no huginn no karma? | |
| 15:46 | Anyway, I'm shouting it from the rooftop. | |
| 15:46 | cait | huginn!!!!! |
| 15:46 | wahanui | i think huginn is going to make me lie... |
| 15:46 | ashimema | lol |
| 15:48 | gmcharlt | |
| 15:48 | wahanui | gmcharlt is usually lurking much earlier.. hense your pointing him out |
| 15:48 | ashimema | gmacharlt |
| 15:48 | gmcharlt | |
| 15:48 | wahanui | gmcharlt is usually lurking much earlier.. hense your pointing him out |
| 15:48 | caroline | what a healthy relationship these bots have with each other... |
| 15:49 | oleonard | huginn's disappearance really shows how much we depend on them. |
| 15:50 | cait | yeah, might be good to have a backup of them somewhere |
| 15:50 | gitlab? | |
| 15:50 | wahanui | it has been said that gitlab is missing 18.11.x |
| 15:52 | cait | forget gitlab |
| 15:52 | wahanui | cait: I forgot gitlab |
| 15:59 | AndrewFH joined #koha | |
| 16:01 | severine_q | Is it possible to install other languages in sandbox ? |
| 16:02 | i didn't found how to do that and wanted to check something before filling a new bug :/ | |
| 16:04 | cait | i think only in the biblibre ones right now :( |
| 16:04 | but their old system is down i believe | |
| 16:04 | maybe file an issue on the gitlab repo for the devboxes? i'd love that addition | |
| 16:05 | severine_q | thanks cait :) |
| 16:10 | maybe you could check that if you have a few time cait ? | |
| 16:10 | when I search in staff interface, I come back to Home if I change language while I'm on a page results or biblio details | |
| 16:11 | do you experiment the same with German ? | |
| 16:11 | cait | check your baseurl setting :) |
| 16:11 | it has to be ecactly riht | |
| 16:11 | severine_q | fine ! |
| 16:11 | cait | https/http make a difference too |
| 16:11 | severine_q | good to know ! |
| 16:11 | cait | yep, recently figured that out too :) |
| 16:13 | severine_q | cait, you are just wonderful !!!! |
| 16:13 | oleonard | That's what I've been saying!! |
| 16:14 | severine_q | :D |
| 16:15 | reiveune left #koha | |
| 16:15 | ashimema | ack.. I forgot about the installing translations bug for sandboxes |
| 16:16 | that shouldn't be too hard to achieve I wouldn't think | |
| 16:16 | do any of you install translations in k-t-d? | |
| 16:16 | cait | severine_q: just been bugging... i think Joubu... about this in the past :) |
| 16:16 | happy to share the shared wishdom | |
| 16:19 | KSorbo joined #koha | |
| 16:19 | ashimema | tcohen |
| 16:19 | I SO'd bug 25260 | |
| 16:19 | such a nice improvement | |
| 16:22 | KSorbo | Having a problem with sending email. I have install postfix. It will send correctly from the ubuntu command line. I have added the Koha Admin email address. Yet when I attempt to send an email (e.g., reset password email), the system says "Invalid 'from' parameter: rootlocalhost" |
| 16:22 | cait | sorry, that's a little funny- i've bene there before |
| 16:22 | please check your KohaAdminEmailAddress system preference setting first | |
| 16:23 | tcohen | thanks, ashimema ! |
| 16:23 | fridolin | wahanui: check |
| 16:23 | wahanui | fridolin: sorry... |
| 16:23 | ashimema | shared my SO'd branch with you on slack ;) |
| 16:23 | tcohen | oleonard have you seen this https://snipboard.io/2Ai3aK.jpg ? |
| 16:23 | KSorbo | @cait - I have checked the KohaAdminEmailAddress. It is set to the same as the system sending |
| 16:24 | fridolin | wahanui: re |
| 16:24 | wahanui | fridolin: i'm not following you... |
| 16:24 | cait | ok |
| 16:24 | tcohen | all preference-choice seem to be 2.22222px width |
| 16:24 | cait | do you know how to run sql statements? |
| 16:24 | fridolin | wahanui: re |
| 16:24 | wahanui | fridolin: sorry... |
| 16:24 | KSorbo | @cait. Yes. |
| 16:24 | cait | check the message_queue table for entries for your password reset email |
| 16:24 | and if the from address there has an invalid value | |
| 16:25 | if so, delete or fix those entries | |
| 16:25 | KSorbo | @cait - will do that right now |
| 16:26 | cait | KSorbo: to epxlain, we discussed this bug here earlier today: Bug 27860 - Bad KohaAdminEmailAddress breaks patron self registration form until notice is removed from message queue the same mechanism is also used for the password reset |
| 16:26 | and the perl error you gave is the same | |
| 16:27 | fridolin joined #koha | |
| 16:29 | fridolin | wahanui: re |
| 16:29 | wahanui | fridolin: what? |
| 16:29 | fridolin | tesging my notifications |
| 16:29 | :) | |
| 16:30 | oleonard | tcohen: I don't see the same thing. I see a different number, calculated by the plugin I assume. |
| 16:30 | tcohen | KSorbo maybe > DELETE FROM message_queue WHERE from_address='rootlocalhost'; |
| 16:30 | koha-jenkins | Project Koha_20.11_D9 build #70: SUCCESS in 46 min: https://jenkins.koha-community[…]Koha_20.11_D9/70/ |
| 16:31 | tcohen | oleonard this is 20.05 |
| 16:32 | fridolin | wahanui: re |
| 16:32 | wahanui | fridolin: sorry... |
| 16:32 | KSorbo | @tcohen @cait. I have 1 entry with rootlocalhost, and 7 entries with the correct to and from address. ALL reply_address are set to null. |
| 16:32 | fridolin | wahanui: re |
| 16:32 | wahanui | fridolin: excuse me? |
| 16:32 | KSorbo | Deleteing as suggested |
| 16:32 | fridolin left #koha | |
| 16:33 | tcohen | +1 |
| 16:33 | as cait said, we just found the same situation | |
| 16:34 | inlibro joined #koha | |
| 16:36 | KSorbo | @tcohen. Deleted as suggested and retried. Now all entries show sent. (Still awaiting arrival of the email) |
| 16:36 | koha-jenkins | Project Koha_Master_D9 build #1582: STILL UNSTABLE in 1 hr 10 min: https://jenkins.koha-community[…]a_Master_D9/1582/ |
| 16:37 | tcohen | sent => they are in the hands of the MTA, and Koha did its job |
| 16:37 | great | |
| 16:39 | lukeG joined #koha | |
| 16:40 | koha-jenkins | Project Koha_20.11_U18 build #49: SUCCESS in 57 min: https://jenkins.koha-community[…]oha_20.11_U18/49/ |
| 16:42 | KSorbo | @cait @tcohen. THANKS! Never would have figured that out without your knowledge |
| 16:47 | koha-jenkins | Project Koha_20.11_U16 build #53: SUCCESS in 1 hr 1 min: https://jenkins.koha-community[…]oha_20.11_U16/53/ |
| 16:47 | cait | KSorbo: I didn't either - tcohen did :) |
| 16:49 | koha-jenkins | Project Koha_Master_D11 build #227: FAILURE in 2 min 47 sec: https://jenkins.koha-community[…]a_Master_D11/227/ |
| 16:49 | joubu: Bug 22824: DBRev 20.12.00.021 | |
| 16:54 | KSorbo | Another?? I am using one of the translation packages for the OPAC (id_ID). However, there are quite a few phrases that are not translated. Can you direct me to the location where I can assist / complete the translation? |
| 16:56 | nlegrand | KSorbo: you can start here: https://wiki.koha-community.or[…]/Translating_Koha |
| 16:56 | cait | KSorbo: which langauge? |
| 16:56 | just curious... doesn't really change the answer | |
| 16:56 | tcohen | Indonesian |
| 16:57 | cait | oh wow :) |
| 16:57 | reading htat page will help | |
| 16:58 | but to explain a little before, we use po files that are maintained via translate.koha-community.org | |
| 16:58 | and then included in each release | |
| 16:58 | youcould change the po files locally and rerun the translatoin tools... but that would only be a very short time solution | |
| 16:58 | better to translate online | |
| 17:02 | KSorbo | Found the pootle site... |
| 17:12 | ashimema | with the old sandboxes.. what languages were available? |
| 17:15 | koha-jenkins | Project Koha_20.11_U2010 build #49: UNSTABLE in 44 min: https://jenkins.koha-community[…]a_20.11_U2010/49/ |
| 17:15 | cait | all |
| 17:15 | you selected which to install when setting it up | |
| 17:16 | ashimema | hum |
| 17:16 | cait | it was not preselected |
| 17:16 | but maybe hte list was hardcoded - i never noticed a language missing | |
| 17:16 | mostly using German of course | |
| 17:19 | ashimema | I'm thinking of adding the top hitters rather than a full list.. mostly because hard coding a list is simpler than trying to look one up on the fly |
| 17:28 | cait | makes sense |
| 17:28 | maybe use the one from release ontes | |
| 17:28 | and if some language is requested would be probably not too hard to add? | |
| 17:34 | inlibro joined #koha | |
| 17:35 | tcohen | Fun with Koha/Perl. |
| 17:35 | http://paste.koha-community.or[…]bmit=Format+it%21 | |
| 17:36 | How many tests can you count? | |
| 17:36 | cait | 4? |
| 17:36 | wahanui | 4 is probably good |
| 17:37 | cait | 2? |
| 17:37 | wahanui | 2 are correct |
| 17:37 | tcohen | 6 |
| 17:37 | cait | h |
| 17:37 | hm | |
| 17:37 | get_ok, json_is .. and? | |
| 17:37 | tcohen | because I forgot I mocked ->pickup_locations and added a test inside of |
| 17:37 | jahahaha | |
| 17:37 | ashimema | 4 |
| 17:38 | lol | |
| 17:38 | tcohen | don't ever do that |
| 17:38 | haha | |
| 17:38 | cait | ok, i feel like a hopeless case here :) |
| 17:38 | ashimema | he hid a test inside a function that's not in the snippet |
| 17:38 | lol | |
| 17:38 | sandboxes getting a quick restart | |
| 17:38 | tcohen | I tricked myself! |
| 17:44 | koha-jenkins | Yippee, build fixed! |
| 17:44 | wahanui | Congratulations! |
| 17:44 | koha-jenkins | Project Koha_Master_D9_My8 build #521: FIXED in 1 hr 3 min: https://jenkins.koha-community[…]aster_D9_My8/521/ |
| 17:54 | ashimema | you can now install translations on ptfs-e sandboxes |
| 17:54 | cait | woohoo |
| 17:54 | ashimema++ | |
| 17:55 | ashimema | setup a sandbox -> once it's come up go to 'Actions -> Install translation' in the sandbox manager |
| 17:55 | we don't switch the preferences inside the box.. we leave that to the end user :) | |
| 17:56 | if sonia is here.. I just borrowed your sandbox to test it.. so that one has french installed (but not yet enabled) ;) | |
| 17:56 | cait | :) |
| 17:56 | you sould send an email | |
| 17:56 | advertising | |
| 17:56 | ashimema | and on that note.. I think it's time for me to clock off |
| 17:57 | cait | or at least mention at announcements or so |
| 17:57 | have a nice evening! | |
| 18:00 | koha-jenkins | Project Koha_Master_D9 build #1583: STILL UNSTABLE in 1 hr 11 min: https://jenkins.koha-community[…]a_Master_D9/1583/ |
| 18:00 | ashimema | email sent |
| 18:03 | koha-jenkins | Project Koha_20.05_U20 build #274: FAILURE in 2 min 26 sec: https://jenkins.koha-community[…]ha_20.05_U20/274/ |
| 18:05 | Project Koha_20.05_U16 build #245: FAILURE in 2 min 10 sec: https://jenkins.koha-community[…]ha_20.05_U16/245/ | |
| 18:07 | Project Koha_20.05_U18 build #109: FAILURE in 2 min 21 sec: https://jenkins.koha-community[…]ha_20.05_U18/109/ | |
| 18:09 | Project Koha_20.05_D10 build #241: SUCCESS in 39 min: https://jenkins.koha-community[…]ha_20.05_D10/241/ | |
| 18:12 | Project Koha_20.05_U16 build #246: STILL FAILING in 2 min 16 sec: https://jenkins.koha-community[…]ha_20.05_U16/246/ | |
| 18:14 | reiveune1 joined #koha | |
| 18:14 | reiveune1 left #koha | |
| 18:14 | koha-jenkins | Project Koha_20.05_U20 build #275: STILL FAILING in 2 min 30 sec: https://jenkins.koha-community[…]ha_20.05_U20/275/ |
| 18:16 | reiveune joined #koha | |
| 18:17 | koha-jenkins | Project Koha_20.05_U18 build #110: STILL FAILING in 2 min 21 sec: https://jenkins.koha-community[…]ha_20.05_U18/110/ |
| 18:19 | Project Koha_20.05_D10 build #242: FAILURE in 2 min 9 sec: https://jenkins.koha-community[…]ha_20.05_D10/242/ | |
| 18:25 | reiveune joined #koha | |
| 18:29 | oleonard | Sorry tcohen I can't reproduce your problem with the preferences |
| 18:34 | inlibro joined #koha | |
| 18:38 | khall joined #koha | |
| 18:41 | koha-jenkins | Project Koha_20.05_U2010 build #138: SUCCESS in 53 min: https://jenkins.koha-community[…]_20.05_U2010/138/ |
| 18:41 | Yippee, build fixed! | |
| 18:41 | wahanui | Congratulations! |
| 18:41 | koha-jenkins | Project Koha_Master_D10 build #488: FIXED in 57 min: https://jenkins.koha-community[…]a_Master_D10/488/ |
| 18:47 | Project Koha_20.05_D9 build #241: SUCCESS in 59 min: https://jenkins.koha-community[…]oha_20.05_D9/241/ | |
| 18:50 | Project Koha_20.05_D9 build #242: FAILURE in 2 min 16 sec: https://jenkins.koha-community[…]oha_20.05_D9/242/ | |
| 18:50 | khall_ joined #koha | |
| 19:34 | koha-jenkins | Project Koha_20.05_U2010 build #139: SUCCESS in 52 min: https://jenkins.koha-community[…]_20.05_U2010/139/ |
| 19:34 | inlibro joined #koha | |
| 20:11 | huginn joined #koha | |
| 20:11 | gmcharlt | @quote random |
| 20:11 | huginn | gmcharlt: Quote #41: "owen: Being an ass doesn't qualify as a medical condition ;)" (added by jwagner at 03:13 PM, October 16, 2009) |
| 20:11 | oleonard | \o/ |
| 20:11 | gmcharlt++ | |
| 20:12 | AndrewFH joined #koha | |
| 20:13 | cait | huginn!!! |
| 20:13 | wahanui | huginn is going to make me lie... |
| 20:13 | huginn | wahanui: I'll give you the answer just as soon as RDA is ready |
| 20:13 | wahanui | i already had it that way, huginn. |
| 20:13 | cait | gmcharlt++ |
| 20:13 | we missed it os much | |
| 20:14 | oleonard | We were all in huginn withdrawal |
| 20:14 | cait | yep, quite horribly |
| 20:15 | oleonard | We like you too gmcharlt but you don't talk to us as much :) |
| 20:15 | gmcharlt | and I'm absoutely terrible at giving weather updates, let alone predicting it ;) |
| 20:15 | oleonard | To be fair... so is huginn these days |
| 20:15 | @wunder 45701 | |
| 20:15 | huginn | oleonard: Error: I could not find a valid location for: 45701 |
| 20:17 | cait | bug 1 |
| 20:17 | bug 100 | |
| 20:17 | bug 2000 | |
| 20:17 | hm | |
| 20:17 | bug 27871 | |
| 20:17 | i guess our most missed feature is still a bit broken | |
| 20:18 | or it's me... it doesn't like me anymore :( | |
| 20:18 | huginn? | |
| 20:18 | wahanui | hmmm... huginn is going to make me lie... |
| 20:18 | oleonard | bug 20375 |
| 20:19 | cait | gmcharlt: was huginn in an accident? |
| 20:19 | oleonard | bug √−1 |
| 20:19 | * gmcharlt | looks into it |
| 20:20 | cait | thank you |
| 20:21 | huginn | Bug http://bugs.koha-community.org[…]show_bug.cgi?id=1 major, P2, ---, chris, CLOSED FIXED, Missing uploadedmarc table definition |
| 20:23 | gmcharlt | bug 100 |
| 20:24 | @bug 100 | |
| 20:27 | reiveune left #koha | |
| 20:27 | cait | bug 20375 |
| 20:27 | oleonard | bug twenty-six thousand four hundred and ninety seven |
| 20:35 | inlibro joined #koha | |
| 20:37 | huginn joined #koha | |
| 20:38 | gmcharlt | bug 200 |
| 20:39 | cait | bug 8476 |
| 20:43 | huginn joined #koha | |
| 20:59 | gmcharlt | bug 200 |
| 21:00 | cait | stubborn |
| 21:00 | bug 6918 | |
| 21:01 | ashimema | Woo |
| 21:01 | Hello gmcharlt | |
| 21:03 | Weird | |
| 21:03 | huginn | Bug https://bugs.koha-community.or[…]ow_bug.cgi?id=200 normal, P2, ---, chris, CLOSED FIXED, Returning withdrawn item doesn't show error message |
| 21:03 | Bug https://bugs.koha-community.or[…]w_bug.cgi?id=6918 normal, P3, ---, kyle.m.hall, Failed QA , Can't place holds on 'on order' items with AllowOnShelfHolds off | |
| 21:19 | gmcharlt | bug 1235 |
| 21:21 | huginn | Bug https://bugs.koha-community.or[…]w_bug.cgi?id=1235 normal, P2, ---, paul.poulain, CLOSED FIXED, increase 'tagorder' column to smallint?. |
| 21:25 | gmcharlt | so, it's been working all this time... just with a big delay |
| 21:25 | sorting that out | |
| 21:25 | @quote random | |
| 21:25 | huginn | gmcharlt: Quote #189: "libsysguy: one need not ask why where there are librarians involved :P" (added by wizzyrea at 03:30 PM, February 28, 2012) |
| 21:25 | gmcharlt | @bug 2456 |
| 21:27 | huginn | gmcharlt: Bug https://bugs.koha-community.or[…]w_bug.cgi?id=2456 normal, PATCH-Sent (DO NOT USE), ---, gmcharlt, CLOSED FIXED, Moving some C4::VirtualShelves subs from EXPORT to EXPORT_OK |
| 21:28 | gmcharlt | bug 24672 |
| 21:28 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=24672 major, P5 - low, ---, jonathan.druart, CLOSED FIXED, Error on receiving orders when there is an order with a deleted record |
| 21:28 | gmcharlt | bug 27252 |
| 21:28 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=27252 major, P5 - low, ---, nick, Pushed to oldoldstable , ES5 no longer supported (since 20.11.00) |
| 21:28 | gmcharlt | query bookmobile |
| 21:28 | reiveune joined #koha | |
| 21:28 | gmcharlt | bug 2466 |
| 21:28 | huginn | Bug https://bugs.koha-community.or[…]w_bug.cgi?id=2466 blocker, PATCH-Sent (DO NOT USE), ---, gmcharlt, CLOSED FIXED, can't remove value in item modif |
| 21:28 | cait | yay! |
| 21:28 | gmcharlt++ | |
| 21:28 | gmcharlt | much better |
| 21:28 | cait | @karma gmcharlt |
| 21:28 | huginn | cait: Karma for "gmcharlt" has been increased 260 times and decreased 0 times for a total karma of 260. |
| 21:28 | caroline | gmcharlt++ |
| 21:29 | cait | thx for fixing! |
| 21:35 | inlibro joined #koha | |
| 21:42 | koha-jenkins | Project Koha_20.05_D10 build #243: STILL FAILING in 2 min 21 sec: https://jenkins.koha-community[…]ha_20.05_D10/243/ |
| 21:45 | Project Koha_20.05_U18 build #111: STILL FAILING in 2 min 10 sec: https://jenkins.koha-community[…]ha_20.05_U18/111/ | |
| 21:46 | Project Koha_20.05_U16 build #247: STILL FAILING in 1 min 38 sec: https://jenkins.koha-community[…]ha_20.05_U16/247/ | |
| 22:00 | cait | Joubu: around by chance? |
| 22:00 | Error while loading /etc/koha/sites/kohadev/plack.psgi: Can't locate C4/Boolean.pm in @INC (you may need to install the C4::Boolean module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer /home/vagrant/kohaclone/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5. | |
| 22:00 | 24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /etc/koha/sites/kohadev/plack.psgi line 29. | |
| 22:01 | or ashimema? | |
| 22:01 | wahanui | ashimema is, like, suspecting network.. ashimema's ssh terminal is sluggish.. I type something and it take a second or two to actually appear |
| 22:01 | cait | my koha is broken. |
| 22:06 | reiveune | bye |
| 22:06 | reiveune left #koha | |
| 22:07 | cait | right no more QA... tonight. I got it |
| 22:25 | koha-jenkins | Project Koha_20.05_D9 build #243: NOW UNSTABLE in 43 min: https://jenkins.koha-community[…]oha_20.05_D9/243/ |
| 22:33 | Project Koha_20.05_U2010 build #140: SUCCESS in 53 min: https://jenkins.koha-community[…]_20.05_U2010/140/ | |
| 22:35 | inlibro joined #koha | |
| 22:36 | koha-jenkins | Yippee, build fixed! |
| 22:36 | wahanui | Congratulations! |
| 22:36 | koha-jenkins | Project Koha_20.05_U20 build #276: FIXED in 52 min: https://jenkins.koha-community[…]ha_20.05_U20/276/ |
| 22:43 | oleonard | @wunder 45701 |
| 22:43 | huginn | oleonard: Error: I could not find a valid location for: 45701 |
| 22:43 | oleonard | :/ |
| 23:35 | inlibro joined #koha | |
| 23:59 | KotH joined #koha |
← Previous day | Today | Next day → | Search | Index
