← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
Time | Nick | Message |
---|---|---|
00:58 | irma_ joined #koha | |
01:16 | kathryn joined #koha | |
01:17 | wizzyrea | my @bad_dates; # I've had a few. < LOL! |
01:18 | dcook | lol |
01:18 | wizzyrea | atz++ |
01:19 | eythian | I think you mean +++ATH0, wizzyrea |
01:19 | wizzyrea | lulz |
01:35 | BobB joined #koha | |
01:47 | dcook | Hmm, does anyone have a recent example of a new module using DBIC? |
01:48 | I'm wondering what scope to give $schema | |
01:48 | * dcook | tries to recall eythian's biblioiterator code.. |
01:48 | dcook | I don't think that's relevant though |
01:48 | eythian | what do you mean by scope¿ |
01:49 | dcook | Well, I'm making a bunch of subs in this module, and they're probably all going to need to use the DBIC object stored in $schema |
01:49 | So I'm wondering if I should declare it at the file level | |
01:49 | Rather than within each sub | |
01:49 | Or pass it around within the class itself | |
01:49 | Both of which seem inefficient | |
01:51 | Koha::Acquisition::Order seems to declare it within each sub | |
01:51 | eythian | Definitely not at the file lever |
01:51 | level | |
01:52 | I'd just have it at the sub level. | |
01:52 | I expect there's some magic to make it not slow | |
01:53 | dcook | I hope so :/ |
01:53 | I'll give it a shot. Thanks, eythian :) | |
01:54 | eythian++ | |
01:54 | Probably due way more than just one increment :p | |
01:54 | eythian | remember: don't optimise. |
01:54 | dcook | Yeah, I'm still struggling with that a bit |
01:55 | Doing my best not to though! | |
01:55 | Just leaving reminders to myself where I could | |
01:55 | So far I notice about a 10 second difference between caching the XSLT, and I haven't gotten to frameworkcode year | |
01:55 | yet* | |
01:55 | Even then... maybe 20 second difference on 7500 records isn't bad | |
01:56 | At the moment decomposing the code from the .pl script into functions in the perl module | |
01:56 | Mostly because it's kind of a pain the way they're laid out in the .pl script right now | |
01:56 | But thanks for the reminder. It's a good one to remember :) | |
01:58 | Admittedly, a lot of this is still figuring out how to use DBIC well.. | |
01:58 | I think I'm actually starting to like it | |
02:14 | Another quick question for you, eythian | |
02:14 | If I want to check for 0 as true... I wrap it in quotation marks? | |
02:16 | Guess I can test this quickly.. | |
02:17 | eythian | dcook: what's the context? |
02:17 | wahanui | rumour has it the context is everything |
02:17 | dcook | if condition |
02:17 | $test == 0 | |
02:17 | BobB_ joined #koha | |
02:17 | eythian | so you want to see if you can an actual zero value? |
02:17 | dcook | Yep |
02:18 | eythian | I think just == would do it. |
02:18 | but test it | |
02:18 | I can imagine that it might not do what I expect | |
02:18 | dcook | Cool. I want to say I've run into this situation before but I can't remember how it was resolved |
02:19 | Just trying "if ($test)" now | |
02:19 | Can't get anything to evaluate to true :S | |
02:20 | irma joined #koha | |
02:20 | eythian | if ($test) is different |
02:21 | you're seeing if it evaluates to true, so 0 and "" will be false | |
02:22 | dcook | Mmm, right |
02:22 | Wait | |
02:22 | But you should still be able to tell if $test has a number in it | |
02:23 | eythian | which I think == 0 will do |
02:23 | dcook | == 0 certainly works but I don't know if it's working the way I think it's working |
02:24 | as == "0" works identically | |
02:24 | eythian | you can't do that |
02:24 | dcook | You can :S |
02:24 | eythian | you need to use eq |
02:24 | dcook | I just tried it and there was no errors |
02:24 | You should use eq since it should be a string | |
02:24 | But == works too :S | |
02:24 | cjh | with == it is converting "0" to 0 |
02:24 | eythian | yes |
02:24 | that | |
02:25 | so if it may be something that can't be a number, it will warn | |
02:25 | dcook | I figured that must be it |
02:25 | cjh | if you actually want a string comparison you ned eq "0" |
02:25 | dcook | Just tried with "1" as well |
02:25 | cjh | $foo == "a"; # dont do this. |
02:25 | dcook | ^ that should throw errors |
02:26 | So == should be working the way one would think it would work | |
02:26 | eythian | well, you have to account for coercion |
02:26 | $ perl -w -e '$t=""; if ($t==0) {print "true\n";}' | |
02:26 | Argument "" isn't numeric in numeric eq (==) at -e line 1. | |
02:26 | true | |
02:26 | is that a valid result in your case? | |
02:26 | dcook | Mmm, but declaring it.. |
02:26 | eythian: Hmm? | |
02:27 | Ahh | |
02:27 | $t should always be a number | |
02:27 | I've ran into that issue in the past though for sure | |
02:27 | eythian | "should" |
02:27 | dcook | Hmm, yeah "should" :/ |
02:27 | I was doing a scalar of an array | |
02:27 | cjh | does should include error cases |
02:28 | dcook | But now I'm just comparing whatever DBIC is outputting |
02:28 | And DBIC is a bit too magical to know for sure | |
02:28 | Actually, I have no idea why DBIC is giving me 0, 1, or 2 | |
02:28 | eythian | what are you actually trying to do, because I have a suspicion that you may be doing something in a bit of an odd way. |
02:28 | or you have some odd circumstances | |
02:29 | dcook | eythian: That's what I'm thinking too :p |
02:29 | I want to know whether my query is returning 0 results, 1 result, or more than 1 result | |
02:29 | I suppose no matter what, I need to check the number whether that's by issuing a count query or by checking the number of results sent back | |
02:30 | eythian | if (!$res->count) { no results } elsif ($res->{count} { one result } else { more than one } |
02:30 | dcook | 0 = add new record, 1 = update record, > 1 = no action and send a warning |
02:30 | eythian | err |
02:30 | correcting for syntax and things | |
02:30 | dcook | O_o |
02:30 | Won't $res->count always be true? | |
02:31 | I suppose it would evaluate to 0 though and in that context it might be false.. | |
02:31 | eythian | I dunno, I'm just assuming it contains the number of results or something |
02:31 | whatever value that gives you a scalar thing | |
02:31 | might be an array or something | |
02:32 | dcook | At the moment I have if ($test == 0 ) {} elsif ($test == 1) {} elsif ($test > 1){} |
02:32 | The last could just be an else but sometimes I like to have it be more explicit for readability | |
02:32 | And for specificity | |
02:32 | eythian | oh, there's an error in mine |
02:32 | dcook | Yeah, I was wondering about your elsif |
02:32 | eythian | I'm missing the ==1 case |
02:33 | your version doesn't handle weird results like undef or negatives | |
02:33 | (which should be impossible, but stranger things | |
02:33 | ) | |
02:33 | also, an else is nice because you don't need to know that there's some special case going on | |
02:33 | dcook | Hmm (!$test) won't work |
02:33 | eythian: Yeah, I was just thinking about that | |
02:34 | If I do need to know about a special case, I suppose I could do it within the "else" block | |
02:34 | eythian | why not? |
02:34 | dcook | Don't know. It's not working though |
02:34 | I wish I could take a better look at these variables without dumping out the whole Koha::Schema | |
02:35 | eythian | perl -d |
02:35 | dcook | I'm wondering if it's returning a boolean object.. |
02:35 | perl -d... let's see | |
02:36 | How do I progress through the script? I know I've done this before but it's been a while | |
02:36 | n? | |
02:36 | wahanui | somebody said n was number |
02:36 | dcook | Oh, just enter |
02:36 | Hmm, that doesn't show me what's happening in the sub which is where the test is | |
02:37 | eythian | set a breakpoint or something |
02:37 | or trace into it | |
02:38 | dcook | trace like strace? |
02:39 | eythian | no |
02:40 | like 's' vs. 'n' | |
02:40 | dcook | That's good because that wasn't helpful :p |
02:40 | ? | |
02:40 | eythian | enter repeats the last s or n |
02:40 | s for step into, n for step over | |
02:41 | press 'h' for help | |
02:43 | dcook | Hmm |
02:44 | No way to go backwards, eh? | |
02:47 | eythian | Don't think so |
02:48 | dcook | So much useless data printed out with these objects... bleck |
02:48 | Wow... accidentally found the line I wanted.. | |
02:48 | Which I realize now I could've done a lot easier | |
02:49 | eythian | there is an execute to line mode |
02:50 | dcook | Yeah, I thought I saw that before but now I don't :S |
02:52 | eythian | c [ln|sub] Continue until position |
02:52 | dcook | Bingo! |
02:52 | merci :) | |
02:54 | Hmm, still having trouble navigating around :/ | |
02:54 | I swear I can run the same commands in the same order and get different results.. | |
02:55 | Oh wait... it's because of accessors.. | |
02:55 | Because they're subs themselves | |
02:56 | Hmm.. I think I might understand.. | |
02:58 | Because $test is a ResultSet object... when it tries to evaluate it, it triggers some logic in the object | |
02:58 | it runs a "count" itself... but I don't know why | |
02:58 | eythian | well, how else will it know how many results it has? |
02:58 | dcook | Exactly |
02:58 | Magic | |
02:59 | If you use list context, the list clearly has 3 result objects in it | |
02:59 | But in scalar context... I had no idea how it would do it | |
02:59 | But how does the object do that? | |
03:00 | eythian | I dunno |
03:00 | dcook | I guess it would be by search |
03:00 | eythian | there's probably a way |
03:00 | * dcook | is a silly pants |
03:00 | dcook | Hmm maybe not silly |
03:01 | eythian: hehe. Now I know why my wife gets frustrated when I say probably :p | |
03:01 | eythian | heh |
03:01 | I know you can do want_array, but I don't know how that applies to an object. | |
03:01 | dcook | Yeah, I'm trying to backtrack now |
03:02 | If you use "wantarray" with "ResultSet->search", you'll get an array back | |
03:02 | But if you don't want an array... | |
03:03 | (ref $self)... interesting | |
03:03 | A different way of saying __PACKAGE__? | |
03:03 | I guess not.. | |
03:03 | Or maybe. Doesn't matter. It creates a new object of the same class.. | |
03:06 | Hmm reading source is no fun | |
03:07 | There must be a better way with the debugger | |
03:09 | $ = DBIx::Class::ResultSet::count(ref(DBIx::Class::ResultSet), undef, '') called from file 'git/Koha/OAI/Importer.pm' line 71 | |
03:09 | . = Koha::OAI::Importer::determine_status(ref(Koha::OAI::Importer), ref(HASH)) called from file 'oai_importer.pl' line 44 | |
03:13 | Definitely something about the class itself.. | |
03:16 | So if I read that right... the variable is actually a reference to a sub? | |
03:17 | eythian | hmm...maybe |
03:17 | I don't really understand it | |
03:17 | or, know what I'm looking at | |
03:18 | dcook | Stack trace in the Perl debugger |
03:18 | on the line if ($test) | |
03:19 | Hmm, and I think CPAN might be having issues.. | |
03:19 | eythian | http://perldoc.perl.org/overload.html <-- maybe this |
03:20 | dcook | I was leaning that way so it gives me hope that you are pointing to it |
03:21 | yay for metacpan being up.. | |
03:21 | use overload | |
03:21 | '0+' => "count", | |
03:21 | Well.. | |
03:21 | use overload | |
03:21 | '0+' => "count", | |
03:21 | 'bool' => "_bool", | |
03:21 | fallback => 1; | |
03:22 | So the "count" sub is run whenever Perl tries to "numify" it | |
03:22 | maybe.. | |
03:23 | In any case, I'm quite certain you're right, eythian | |
03:24 | It looks like "if ()" uses numify... | |
03:24 | "if (!$test)" would only work if it was treated as a bool.. | |
03:29 | Mmm | |
03:29 | Actually, it looks like "if ()" would use the bool method | |
03:29 | Which looks like it'll always be 1 | |
03:30 | Whereas $test == 1 will use the numify method which is count | |
03:30 | eythian++ | |
03:30 | * dcook | loves the feeling of figuring stuff out |
03:30 | eythian | and now you know for next time :) |
03:30 | dcook | Would've been better if I would've decided on looking at overload without you prompting me, but getting help isn't a bad thing |
03:30 | Yep :) | |
03:32 | And it looks like it might only do that because there is no method for "+" and fallback is set to true | |
03:32 | Interesting stuff... | |
03:42 | * dcook | is actually really delighted to figure that one out |
03:42 | dcook | Ahhhh! |
03:43 | I am so glad that I looked at the clock | |
03:43 | * dcook | has a rather important medical exam rather soon... |
04:01 | runs off to get pricked, poked, and prodded. | |
04:01 | eythian | enjoy...? |
04:38 | mtj | ooh, rangi ashimema http://news.slashdot.org/story[…]cks-down-on-gnome |
04:40 | https://engineering.groupon.co[…]ct-names/#updated | |
04:41 | perhaps a better link | |
06:07 | cait joined #koha | |
06:08 | BobB_ | hi cait |
06:09 | cait | morning BobB_ :) |
06:09 | BobB_ | welcome to you and good night from me :) |
06:42 | * magnuse | waves |
07:24 | cait | z39.50? |
07:24 | wahanui | z39.50 is the ANSI standard of the beast. |
07:24 | cait | i know we have a page with koha targets on the wiki |
07:24 | but i can't find it :( | |
07:24 | can someone help? | |
07:24 | z39.50 servers? | |
07:25 | wahanui | z39.50 servers is always a good idea. |
07:26 | cait | i was looking for a koha target to test bug 6681 with |
07:26 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=6681 major, P2, ---, simith.doliveira, Signed Off , When importing a biblio record via Z39.50, authority links and items also get imported |
07:29 | ashimema | mtj: tis awesome aint it.. |
07:29 | i'm impressed.. the power of a social campaign it seems | |
07:30 | cait | morning ashimema |
07:31 | ashimema | morning cait |
07:35 | magnuse | z39.50 servers is at http://wiki.koha-community.org[…]en_Z39.50_Sources |
07:36 | z39.50 servers? | |
07:36 | wahanui | i guess z39.50 servers is always a good idea. |
07:36 | cait | ok |
07:36 | so why didn't i find that looking for z39.50? | |
07:36 | magnuse | wahanui: forget z39.50 servers |
07:36 | wahanui | magnuse: I forgot z39.50 servers |
07:36 | magnuse | z39.50 servers is at http://wiki.koha-community.org[…]en_Z39.50_Sources |
07:36 | z39.50 servers? | |
07:36 | wahanui | i guess z39.50 servers is at http://wiki.koha-community.org[…]en_Z39.50_Sources |
07:36 | cait | hmpf! |
07:37 | off to work now - thx magnuse++ ! | |
07:37 | magnuse | cait: because you didn't scroll down far enough? :-) |
07:37 | cait | idid! |
07:37 | maybe i typoed without noticing? | |
07:37 | magnuse | because z39.50 is a stupid protocol? |
07:37 | cait | will never findout i guess :) |
07:37 | cya later! | |
07:45 | reiveune joined #koha | |
07:45 | reiveune | hello |
07:47 | magnuse | bonjour reiveune |
07:47 | reiveune | bonjour magnuse dcook rangi |
07:50 | alex_a joined #koha | |
07:50 | alex_a | bonjour |
07:52 | magnuse | bonjour alex_a |
08:00 | gaetan_B joined #koha | |
08:00 | gaetan_B | hello |
08:06 | * ashimema | is on a qa mission this morning.. |
08:06 | ashimema | trivial qa's are dropping like flies :) |
08:07 | now moving on to 'minor' | |
08:09 | magnuse | ashimema++ |
08:09 | bonjour gaetan_B | |
08:10 | gaetan_B | bonjour magnuse, i'm heading north tonigh, will be in Stockholm for two days ;) |
08:10 | ashimema | and now onto 'normal' |
08:11 | gaetan_B | (which is certainly not Oslo, but will be the closest i have ever been!) |
08:12 | Joubu | hi #koha |
08:16 | magnuse | gaetan_B: close, but no cigar ;-) |
08:18 | cait joined #koha | |
08:18 | cait | ashimema++ :) |
08:20 | oooh did they win? | |
08:20 | https://twitter.com/JDsTwittic[…]32443128695758848 ? | |
08:21 | ashimema | cool |
08:21 | cait | not sure yet, nothing on the site hm |
08:22 | https://twitter.com/nzosa/stat[…]32442177238863872 | |
08:22 | catalystAcademy won for sure :) yay! | |
08:22 | magnuse | "The winner for the 2014 award for Open Source in Education is @CatalystAcademy" |
08:23 | https://twitter.com/nzosa/stat[…]32442177238863872 | |
08:23 | woohoo! | |
08:23 | cait | yeah pretty cool :) but think koha didn't win |
08:23 | magnuse | The winner of the Open Source Software Project in 2014 is http://fyi.org.nz |
08:23 | cait | yeah |
08:24 | but the academy totally deserves it | |
08:24 | magnuse | yup |
08:33 | Viktor joined #koha | |
08:43 | magnuse | tjänare Viktor! |
08:44 | Viktor: gaetan_B is going to stockholm! | |
08:44 | Viktor | Hej Magnuse :) |
08:44 | magnuse | ...for a couple of days |
08:44 | gaetan_B | hi Viktor :) somehow i thought you were in Germany |
08:45 | Viktor | Hi gaetan_B |
08:45 | Nope - I'm in Sweden even if I do know a bit german and have some connections to the country. | |
08:45 | Stockholms nice - what's the occasion? :) | |
08:46 | gaetan_B | the university is thinking of using Koha, they very competent and are doing msot of the project on their own |
08:47 | they want our help on the migration specifically (1,5 million items, and a little less records, but a pretty big catalog definitely) | |
08:47 | Viktor | Aha - then I know exactly what you are talking about. I've had them visitin in october :) |
08:47 | magnuse | small world, eh? :-) |
08:47 | gaetan_B | indeed |
08:47 | Viktor | Indeed magnuse gaetan_B :) |
08:47 | sophie_m joined #koha | |
08:53 | paul_p joined #koha | |
08:55 | ashimema | is the biblire git repo always fantastically slow to fetch? |
08:56 | attempting to checkout bug 11944 to qa a patch atop it.. | |
08:56 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=11944 major, P5 - low, ---, jonathan.druart, Passed QA , Cleanup Koha UTF-8 |
09:04 | lds joined #koha | |
09:04 | ashimema | Damn cait is a qa machine.. just checked out the stats again.. 529 passed qa's, 190 failed qa's this year to date! |
09:04 | magnuse | cait++ |
09:04 | ashimema | cait++ |
09:05 | magnuse | she's done almost half of the pqa... |
09:05 | ashimema | that's just fractionally under half all passed qa's in the last year to date.. |
09:05 | haha.. jinx | |
09:05 | magnuse | :-) |
09:06 | ashimema | those stats are alarming.. we should get life insurance on cait |
09:06 | magnuse | yeah |
09:06 | ashimema | magnus |
09:07 | magnuse | ? |
09:08 | ashimema | wrong window |
09:08 | was searching for you in the stats ;) | |
09:09 | Joubu | ashimema: What means "slow"? |
09:09 | ashimema | well.. I've been attempting to fetch from it for 15 minutes or so now.. |
09:09 | about to cancel.. | |
09:10 | running it verbose now to get some feedback | |
09:11 | Joubu | it does not look slow from here : 1.50MiB/s :) |
09:11 | (git clone) | |
09:11 | ashimema | interesting.. |
09:11 | wahanui | well, interesting is sometimes good and sometimes bad |
09:11 | ashimema | http://git.biblibre.com/biblibre/kohac.git |
09:11 | that's the right repo right? | |
09:12 | hmm.. or should I be using https (though your certs always claim they're untrusted in my browser I just asusmed they're self signed | |
09:13 | Joubu | ashimema: yet |
09:13 | I cloned using git://, not http | |
09:13 | (but you cannot) | |
09:14 | ashimema | I see.. yeah.. I also asusmed that git protocol access would be restricted so didn't try ;) |
09:14 | Joubu | fatal: The remote end hung up unexpectedly |
09:15 | ashimema: Paola and Zeno got the same error | |
09:15 | ashimema | I've not got a fatal.. |
09:16 | not by http at least.. | |
09:16 | Joubu | ashimema: try: mkdir biblibre_repo; cd biblibre_repo |
09:16 | git init | |
09:16 | git remote add -t ft/bug_11944 -m ft/bug_11944 koha-biblibre http://git.biblibre.com/biblibre/kohac.git | |
09:16 | git fetch -p -f --depth=1 koha-biblibre | |
09:16 | git branch --track bug_11944 koha-biblibre/ft/bug_11944 | |
09:16 | something like that... | |
09:16 | ashimema | I was adding you guys as a remote to my existing repo ;).. |
09:17 | but your right.. I can limit the depth to that one branch.. | |
09:17 | that should help allot.. | |
09:17 | thanks. | |
09:17 | Joubu | our repo is becoming quite huge... |
09:18 | ashimema | the community repo is pretty huge ;) |
09:18 | give's a rather large starting point unfrotunately. | |
09:20 | interesting.. | |
09:20 | wahanui | interesting is sometimes good and sometimes bad |
09:20 | ashimema | even your 'git fetch -v -p -f --depth=1 biblibre' stalls for me |
09:21 | It worked at some point.. as I QA's the patch ;) | |
09:23 | gerundio joined #koha | |
09:29 | * ashimema | gives up.. time for some real work of the day |
09:50 | Viktor joined #koha | |
10:00 | nlegrand joined #koha | |
10:00 | nlegrand | hey #koha :) |
10:01 | long time no see ^^ I should be back for some time now :) | |
10:07 | ashimema | welcome back nlegrand |
10:07 | good to see you again :) | |
10:07 | nlegrand | thx ^^ |
10:18 | viktor_away joined #koha | |
10:19 | ashimema | anyone fancy testing a sip patch? |
10:19 | I'de love to see bug 7904 get moving :) | |
10:19 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7904 enhancement, P5 - low, ---, colin.campbell, Needs Signoff , SIP modules handling of @INC is confused |
11:22 | Joubu | question of the day asked in bug 13240 :) |
11:22 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13240 normal, P5 - low, ---, jonathan.druart, ASSIGNED , advanced_notices.pl contains code obfuscation |
11:23 | ashimema | my that's a nasty construct |
11:30 | * cait | has no idea |
11:31 | Joubu | cait: not sure to understand what you suggested on 13234 :) |
11:31 | cait: I would prefer to keep readingrec.pl and opac-readingrec.pl similar | |
11:33 | pug joined #koha | |
11:40 | cait | Joubu: so we are talking about the patron accoutn :) |
11:41 | and I agree, having them similar would be good | |
11:41 | i think i have to take a look at how the reading records look now - but later | |
11:41 | they are turned off n our installations | |
12:20 | tcohen joined #koha | |
12:24 | phasefx joined #koha | |
12:25 | tcohen | morning! |
12:40 | kmlussier joined #koha | |
12:41 | tcohen | @wunder cordoba, argentina |
12:41 | huginn | tcohen: The current temperature in Cordoba Aerodrome, Argentina is 20.0°C (9:00 AM ART on November 12, 2014). Conditions: Partly Cloudy. Humidity: 36%. Dew Point: 8.0°C. Pressure: 30.01 in 1016 hPa (Rising). |
12:44 | oleonard joined #koha | |
12:45 | oleonard | Hi #koha |
12:50 | meliss joined #koha | |
12:58 | rocio joined #koha | |
13:06 | viktor_away joined #koha | |
13:16 | ashimema | @wunder stevenage, uk |
13:16 | huginn | ashimema: The current temperature in Pin Green, Stevenage, United Kingdom is 12.1°C (1:10 PM GMT on November 12, 2014). Conditions: Scattered Clouds. Humidity: 75%. Dew Point: 8.0°C. Pressure: 29.44 in 997 hPa (Rising). |
13:20 | magnuse | @wunder boo |
13:20 | huginn | magnuse: The current temperature in Bodo, Norway is 0.0°C (1:50 PM CET on November 12, 2014). Conditions: Clear. Humidity: 75%. Dew Point: -4.0°C. Windchill: -6.0°C. Pressure: 30.30 in 1026 hPa (Steady). |
13:20 | * magnuse | had to scrape ice off the car this morning |
13:21 | * cait | grumps at this day |
13:22 | francharb joined #koha | |
13:23 | oleonard | Oh no but mine just started cait! |
13:23 | Joubu | oleonard: Can I have you POV on bug 13234 please? |
13:23 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13234 enhancement, P5 - low, ---, jonathan.druart, ASSIGNED , Make on-site checkouts visible in OPAC |
13:25 | oleonard | Yes. Joubu you were able to reproduce Bug 13232? How? |
13:25 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13232 major, P5 - low, ---, jonathan.druart, Needs Signoff , patron letter browse not working |
13:25 | Joubu | oleonard: just clicking on a letter :) |
13:26 | oleonard: Does it work for you? | |
13:27 | oleonard | Yes |
13:27 | Joubu | oleonard: hum, weird, it should not! :) |
13:29 | oleonard: I know why! | |
13:29 | oleonard: I have a borrower with cardnumber="" | |
13:29 | oleonard | Ah, and so did nengard |
13:30 | Joubu | oleonard: I really would like to understand bug 13226 too, do you have more info to give me? |
13:30 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13226 major, P5 - low, ---, koha-bugs, NEW , Significant slowdown of checkins with fix for notices ignoring the dateformat preference |
13:30 | oleonard | Yep, now I can reproduce. |
13:31 | Joubu I would be happy to do whatever I can but I don't know what | |
13:31 | Joubu | oleonard: maybe could you export the record? let me know the date you use to debar the patron (1 or more?) |
13:31 | the info on the issue | |
13:32 | oleonard: or better, reproduce the issue on a sandbox | |
13:39 | NateC joined #koha | |
13:40 | Joubu | oleonard: In the description of bug 13226, you mentionned bug 11244, how did you find it? Using git bisect? |
13:40 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13226 major, P5 - low, ---, koha-bugs, NEW , Significant slowdown of checkins with fix for notices ignoring the dateformat preference |
13:40 | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=11244 major, P5 - low, ---, jonathan.druart, Pushed to Master , notices ignoring the dateformat preference | |
13:40 | oleonard | Yes |
13:51 | drojf joined #koha | |
13:52 | drojf | hi #koha |
13:52 | * cait | waves |
13:53 | drojf | hi cait |
13:54 | @wunder berlin, germany | |
13:54 | huginn | drojf: The current temperature in Berolinastr., Berlin-Mitte, Berlin, Germany is 11.6°C (2:50 PM CET on November 12, 2014). Conditions: Mostly Cloudy. Humidity: 89%. Dew Point: 10.0°C. Pressure: 29.68 in 1005 hPa (Steady). |
13:54 | drojf | :/ |
14:00 | tcohen | magnuse: can u take a look at bug 12750, please? I adjusted the description as you suggested |
14:00 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12750 enhancement, P5 - low, ---, tomascohen, Needs Signoff , koha-create should be able to configure SRU server for the created instance |
14:00 | papa joined #koha | |
14:05 | talljoy joined #koha | |
14:07 | carmenh joined #koha | |
14:07 | maryj joined #koha | |
14:09 | chris_n joined #koha | |
14:10 | tcohen | khall: http://snag.gy/hx6nv.jpg |
14:10 | khall | let me see if I can recreate that |
14:10 | tcohen | that's on current master |
14:12 | wrong, i was testing on top of 13116, maybe that's the problem | |
14:14 | khall | on a fresh db install, all tests pass for me both on master and on master with 13116 |
14:15 | papa joined #koha | |
14:16 | cait | i am sure they passed for me too - i always run Reserves.t |
14:17 | but not sure hwat might hav echanged since | |
14:17 | and itmight be i tested with empty reserves and oldreserves | |
14:22 | nengard joined #koha | |
14:23 | Joubu | oleonard: any idea for bug 13234? |
14:23 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13234 enhancement, P5 - low, ---, jonathan.druart, ASSIGNED , Make on-site checkouts visible in OPAC |
14:24 | tcohen | there was a typo on sysprefs.sql |
14:24 | and it prevented the DB to be correctly populated | |
14:25 | oleonard | Joubu: Do you have a rough patch I can look at so I can see what you're thinking about? |
14:25 | * oleonard | is trying to reproduce 13226 on a clean(er) database |
14:27 | Joubu | oleonard: ok, I will try to provide a working patch |
14:28 | oleonard | Joubu: If you would rather get more information before doing that, I understand |
14:29 | Joubu | oleonard: Yes, I would like :) |
14:30 | oleonard: In master, tabs exist on opac-readingrec, 1 for "all items" and 1 for "50 items only" | |
14:30 | oleonard: I don't want to add a second tab level for "checkouts" and "on-site checkouts" | |
14:30 | oleonard: I suggested to replace the existing tabs with links | |
14:31 | oleonard | Why not group on-site checkouts with regular checkouts? Is it important that the patron be able to look at only their history of on-site checkouts? |
14:32 | cma joined #koha | |
14:32 | Joubu | oleonard: it works like that on the staff interface. And it was originaly wanted by the customer |
14:33 | tcohen: erk, sorry for the typo :-/ | |
14:33 | tcohen | heh |
14:33 | Joubu | tcohen: I tried to add check on .sql files in the qa tools, but did no't managed to do it. |
14:35 | tcohen | Joubu: maybe SQL::Statement::Structure |
14:36 | Joubu | sounds good! |
14:38 | blou joined #koha | |
14:40 | tcohen | Joubu: i was tempted to use it for validating user-introduced SQL reports |
14:41 | * tcohen | didn't have the time, though |
14:42 | chris_n joined #koha | |
14:45 | tcohen | khall: it is failing, again! |
14:45 | huginn | New commit(s) kohagit: Bug 11634: DBRev 3.17.00.054 <http://git.koha-community.org/[…]b1c959df421bb68e9> / Bug 11634 [QA Followup 3] - Found holds should be considered unavailable <http://git.koha-community.org/[…]abcc84ca0033b17ff> / Bug 11634 [QA Followup 2] - Implement check for IsAvailableForItemLevelRequest <http://git.koha-community.o |
14:46 | khall | tcohen: on master? |
14:46 | tcohen | yes |
14:46 | khall | are you using the data included with koha, or is this a db of you own? |
14:46 | tcohen | current master |
14:46 | oleonard | Joubu: I suspect this may be where things are slowing down: "Trying to replace 9999-12-31 at C4/Letters.pm line 662." |
14:46 | tcohen | clean db |
14:50 | Joubu | oleonard: ha! |
14:50 | good catch | |
14:50 | oleonard | Joubu: Checkin is fast with an unrestricted patron and with a patron who is restricted until a date which is more reasonable (even 2074) |
14:50 | Joubu | I didn't triy without a restriction date! |
14:53 | tcohen | khall: can u reproduce on your box? |
14:53 | JesseM joined #koha | |
14:54 | khall | tcohen: which ut file is failing for you? |
14:54 | tcohen | t/db_dependent/Circulation.t |
14:55 | khall | confirmed |
14:55 | * tcohen | breathes relieved |
14:55 | wahanui | it has been said that breathes relieved is not his fault |
14:56 | tcohen | khall: will you take a look? |
14:57 | khall | will do! |
14:57 | tcohen | thx! |
14:58 | sophie_m joined #koha | |
15:13 | * oleonard | did not see that members/readingrec.pl had changed when testing on-site checkouts |
15:15 | cait | oleonard: hope I didn't miss something there |
15:16 | oleonard | cait: No, just me! |
15:16 | tcohen | oleonard: i'm seeing a wrong behaviour in the record diff feature |
15:17 | oleonard | My main issue with Bug 13234 is that it would be better for it to work like the staff side -- server-side datatables pagination |
15:17 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13234 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Make on-site checkouts visible in OPAC |
15:17 | oleonard | ...except that wouldn't be no-JS friendly :| |
15:18 | tcohen: In the JS-diff? | |
15:19 | tcohen | oleonard: yes |
15:19 | http://snag.gy/XCvD7.jpg | |
15:19 | sophie_m joined #koha | |
15:25 | khall | tcohen: figured it out, patch soon to come |
15:27 | tcohen | khall++ |
15:32 | jenkins_koha | Project Koha_Master_D7 build #227: UNSTABLE in 43 min: http://jenkins.koha-community.[…]ha_Master_D7/227/ |
15:32 | * Tomas Cohen Arazi: Bug 7673: (RM followup) typo in sysprefs.sql | |
15:32 | * Olli-Antti Kivilahti: Bug 13116 - Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates. | |
15:32 | * Kyle M Hall: Bug 13116 [QA Followup] - Remove tabs, use unless instead of if | |
15:32 | * Kyle M Hall: Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds | |
15:32 | * Kyle M Hall: Bug 11634 [QA Followup] - Unit Tests | |
15:32 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7673 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , New patron permissions to manage items (edit, batchmod, delete all) |
15:32 | jenkins_koha | * Kyle M Hall: Bug 11634 [QA Followup 2] - Implement check for IsAvailableForItemLevelRequest |
15:32 | * Kyle M Hall: Bug 11634 [QA Followup 3] - Found holds should be considered unavailable | |
15:32 | * Tomas Cohen Arazi: Bug 11634: DBRev 3.17.00.054 | |
15:32 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13116 enhancement, P5 - low, ---, olli-antti.kivilahti, Pushed to Master , Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates. |
15:32 | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=11634 enhancement, P5 - low, ---, kyle, Passed QA , Allow renewal of item with unfilled holds if other available items can fill those holds | |
15:32 | drojf joined #koha | |
15:46 | paul_p joined #koha | |
15:48 | sophie_m joined #koha | |
15:55 | tgoat joined #koha | |
15:59 | gaetan_B | bye ! |
16:02 | reiveune | bye |
16:02 | reiveune left #koha | |
16:23 | cait left #koha | |
16:28 | nlegrand | Bye ! |
16:37 | sophie_m joined #koha | |
16:39 | thd-away` joined #koha | |
17:03 | oleonard | Joubu++ |
17:03 | not_suffering_from_space_madness++ | |
17:20 | Joubu: I signed off on Bug 13234 but added a follow-up | |
17:20 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13234 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Make on-site checkouts visible in OPAC |
17:29 | carmenh joined #koha | |
17:43 | Dyrcona joined #koha | |
18:06 | huginn | New commit(s) kohagit: Bug 11634 [QA Followup] - Make unit tests pass <http://git.koha-community.org/[…]03d1845f31fa8fd20> / Bug 11319: [QA follow-up] Remove a warning from GetModificationTemplates <http://git.koha-community.org/[…]0cf643091a1c2ec6b> / Bug 11319: [QA follow-up] Add test message to MarcModificationTemplates.t <http://git.koh |
18:09 | carmenh joined #koha | |
18:10 | paul_p joined #koha | |
18:34 | wnickc joined #koha | |
18:41 | carmenh joined #koha | |
18:46 | jenkins_koha | Yippee, build fixed! |
18:46 | wahanui | o/ '`'`'`'`'`'`'`'`'` |
18:46 | jenkins_koha | Project Koha_Master_D7 build #228: FIXED in 42 min: http://jenkins.koha-community.[…]ha_Master_D7/228/ |
18:46 | * Jonathan Druart: Bug 11319: Koha::SimpleMARC should take a hashref for parameters | |
18:46 | * Jonathan Druart: Bug 11319: Add UT for the fields management | |
18:46 | * Jonathan Druart: Bug 11319: Add the field management for Koha::SimpleMARC | |
18:46 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=11319 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Marc modification templates improvements |
18:46 | jenkins_koha | * Jonathan Druart: Bug 11319: Add specific UT for nonexistent field/subfield |
18:46 | * Jonathan Druart: Bug 11319: Template modifications | |
18:46 | * Marcel de Rooy: Bug 11319: [QA follow-up] Add test message to MarcModificationTemplates.t | |
18:46 | * Marcel de Rooy: Bug 11319: [QA follow-up] Remove a warning from GetModificationTemplates | |
18:46 | * Kyle M Hall: Bug 11634 [QA Followup] - Make unit tests pass | |
18:46 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=11634 enhancement, P5 - low, ---, kyle, Pushed to Master , Allow renewal of item with unfilled holds if other available items can fill those holds |
18:48 | jenkins_koha | Yippee, build fixed! |
18:48 | wahanui | o/ '`'`'`'`'`'`'`'`'` |
18:48 | jenkins_koha | Project Koha_Master_U14 build #216: FIXED in 46 min: http://jenkins.koha-community.[…]a_Master_U14/216/ |
18:48 | * Jonathan Druart: Bug 11319: Koha::SimpleMARC should take a hashref for parameters | |
18:48 | * Jonathan Druart: Bug 11319: Add UT for the fields management | |
18:48 | * Jonathan Druart: Bug 11319: Add the field management for Koha::SimpleMARC | |
18:48 | * Jonathan Druart: Bug 11319: Add specific UT for nonexistent field/subfield | |
18:48 | * Jonathan Druart: Bug 11319: Template modifications | |
18:48 | * Marcel de Rooy: Bug 11319: [QA follow-up] Add test message to MarcModificationTemplates.t | |
18:48 | * Marcel de Rooy: Bug 11319: [QA follow-up] Remove a warning from GetModificationTemplates | |
18:48 | * Kyle M Hall: Bug 11634 [QA Followup] - Make unit tests pass | |
18:54 | rangi | morning |
18:55 | gerundio joined #koha | |
18:57 | jenkins_koha | Yippee, build fixed! |
18:57 | wahanui | o/ '`'`'`'`'`'`'`'`'` |
18:57 | jenkins_koha | Project Koha_Master_U12 build #234: FIXED in 58 min: http://jenkins.koha-community.[…]a_Master_U12/234/ |
18:57 | * Jonathan Druart: Bug 11319: Koha::SimpleMARC should take a hashref for parameters | |
18:57 | * Jonathan Druart: Bug 11319: Add UT for the fields management | |
18:57 | * Jonathan Druart: Bug 11319: Add the field management for Koha::SimpleMARC | |
18:57 | * Jonathan Druart: Bug 11319: Add specific UT for nonexistent field/subfield | |
18:57 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=11319 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Marc modification templates improvements |
18:57 | jenkins_koha | * Jonathan Druart: Bug 11319: Template modifications |
18:57 | * Marcel de Rooy: Bug 11319: [QA follow-up] Add test message to MarcModificationTemplates.t | |
18:57 | * Marcel de Rooy: Bug 11319: [QA follow-up] Remove a warning from GetModificationTemplates | |
18:57 | * Kyle M Hall: Bug 11634 [QA Followup] - Make unit tests pass | |
18:57 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=11634 enhancement, P5 - low, ---, kyle, Pushed to Master , Allow renewal of item with unfilled holds if other available items can fill those holds |
18:59 | * oleonard | thinks he saw rangi appear somewhere in all that |
19:00 | rangi | heh |
19:02 | https://www.flickr.com/photos/[…]2157648839590587/ <-- last night | |
19:02 | Koha was a finalist, but http://fyi.org.nz/ won in our category, which is cool, cos they are awesome, still making it to finalist is pretty sweet | |
19:05 | oleonard | Looks pretty swank |
19:10 | rangi | yeah it was nice |
19:16 | https://www.flickr.com/photos/[…]inui/15774811865/ <-- dessert last night | |
19:23 | ibeardslee | it was quite a dessert |
19:29 | Phlunk3 joined #koha | |
19:30 | cait joined #koha | |
19:30 | kathryn joined #koha | |
19:31 | wnickc joined #koha | |
19:34 | cait | hi again #koha |
19:37 | oleonard | Hi cait |
19:37 | cait | hi oleonard :) |
19:39 | rangi | @later tell Joubu can you ping me tonight nz time (your morning) we have an paid intern (aleisha) starting soon and one of the things id like her to work on is hea (doing some frontend work, etc) would that be ok? |
19:39 | huginn | rangi: The operation succeeded. |
19:39 | rangi | hi cait |
19:39 | cait | hi rangi |
19:39 | rangi: great idea about hea | |
19:39 | maybe she could work on some docs too? | |
19:39 | rangi | yep :) |
19:39 | cait | :) |
20:10 | chris_n joined #koha | |
20:48 | hankbank joined #koha | |
21:01 | Viktor joined #koha | |
21:07 | eythian | hi |
21:07 | wahanui | niihau, eythian |
21:07 | cait | hi eythian |
21:08 | eythian | hi there cait |
21:09 | papa joined #koha | |
21:10 | eythian | good early morning papa |
21:10 | papa | exactly, good early morning |
21:34 | nengard_webinar | is the wiki down? |
21:35 | rangi | looks like it |
21:35 | wahanui | Can we get some hard data on that? |
21:37 | cait left #koha | |
21:44 | nengard left #koha | |
21:56 | tgoat joined #koha | |
22:12 | wajasu joined #koha | |
22:21 | dcook | Hehe. Even immigration is telling people not to use IE 8 :p |
22:21 | "If you encounter this problem you are encouraged to use an alternative browser, such as Google Chrome, Mozilla Firefox or a later version of IE." | |
22:22 | eythian | heh |
22:34 | talljoy | IE-- |
22:35 | wizzyrea | I am impressed that a government isn't requiring you to use IE7 |
22:35 | talljoy | lol |
22:35 | wizzyrea | :) |
22:35 | talljoy | or netscape |
22:35 | wizzyrea | ohsnap |
22:35 | talljoy | lol |
22:36 | who is the resident export on import record rules? specifically 'match checks' | |
22:36 | anyone? anyone? | |
22:37 | errr s/export/expert/ | |
22:37 | eythian | I just nominate dcook for things like that. |
22:37 | talljoy | ha! |
22:37 | eythian | whether he is or not |
22:37 | talljoy | nice. |
22:38 | well, i'll be putting in a bug then. seems match checks don't work. | |
22:38 | eythian | I seem to recall someone saying that on-list |
22:39 | wizzyrea | I recall that as well, but there was a trick about it |
22:39 | gah I can't recall. | |
22:39 | talljoy | i found one bug that related more to acq and marcxml |
22:39 | bz 12586 | |
22:40 | wizzyrea | it was something about editing the match checks... it might be in the IRC log. but it was a year or two ago |
22:40 | eythian | bug 12586 |
22:40 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12586 enhancement, P5 - low, ---, olli-antti.kivilahti, Needs Signoff , Record matching rules - Required match checks doesn't work with MARCXML |
22:41 | talljoy | that one. similar, but not quite |
22:41 | same thing? | |
22:41 | chrisvella94 joined #koha | |
22:42 | talljoy | that is the same thing |
22:42 | BobB joined #koha | |
22:42 | talljoy | i'll reference this bug. |
22:44 | dcook | wizzyrea: I bet you the department itself uses XP and IE7 :p |
22:45 | talljoy: Yeah, I'm decent with match checks | |
22:45 | * dcook | isn't reading the scrollback all that well though |
22:45 | talljoy | well matchchecks appear to cause matching failure. |
22:45 | sad day | |
22:45 | dcook | Or maybe I mean match points.. |
22:45 | talljoy | matchpoints rock |
22:45 | but when paired with match checks, much sadness ensues | |
22:46 | dcook | I think I know match points well, and I did some digging into match checks which I can't remember now :p |
22:46 | * dcook | has a bit of immigration to do but could possibly take a look later |
22:48 | talljoy | lot of paperwork, eh? |
22:51 | dcook | Mostly just uploading stuff now |
22:51 | Printing, signing | |
22:51 | So yes, lots of paperwork :) | |
22:58 | tcohen joined #koha | |
22:59 | tcohen | hi there |
22:59 | wahanui | privet, tcohen |
23:04 | tcohen | hi rangi |
23:07 | rangi | heya tcohen |
23:07 | tcohen: did you translate the etherpad into spanish? | |
23:08 | tcohen | etherpad? |
23:10 | dcook | etherpad? |
23:10 | rangi | https://etherpad.mozilla.org/YiC0J8efmw |
23:10 | dont you people read my emails!!???!! | |
23:10 | dcook | Emails? |
23:10 | wahanui | Emails are getting annoying :) |
23:10 | dcook | hehe |
23:10 | I didn't see any emails | |
23:10 | rangi | http://lists.koha-community.or[…]ember/040905.html |
23:10 | tcohen | heh |
23:11 | dcook | Ahhh, I did see that |
23:11 | It's not that I ignored it per se | |
23:11 | tcohen | I wasn't the one that translated it! |
23:13 | rangi: it is supposed to be in english, right? | |
23:13 | rangi | back in english now |
23:13 | i saved the spanish revision, if there was anything that was different | |
23:15 | tcohen | rangi: it looked like a google translation |
23:16 | * dcook | shudders at the mention of google translate |
23:16 | dcook | Actually, it was handy when I was in Greece, but horrible for translating documents.. |
23:21 | rocio left #koha | |
23:53 | mtompset joined #koha | |
23:53 | mtompset | Greetings, #koha. |
23:54 | tcohen: You here? :) | |
23:54 | tcohen | hi mtompset |
23:54 | ||
23:54 | mtompset | Wanted to ask you about bug 13075. |
23:54 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13075 minor, P5 - low, ---, mtompset, Needs Signoff , Use of uninitialized value while proving db_dependent/Holds.t |
23:54 | tcohen | what about it |
23:54 | mtompset | You put another patch on the bug. |
23:54 | tcohen | yeap |
23:54 | mtompset | Is that still related? |
23:55 | tcohen | both are needed, to remove the warnings |
23:55 | i signed yours | |
23:55 | mtompset | Okay... I'll check out your patch. |
23:55 | Since I would like this bug dealt with. :) | |
23:56 | tcohen | yeah, die unnecesary warnings.. die! |
23:56 | mtompset | Is create_helper_biblio something in the test file? |
23:56 | tcohen | yeap |
23:56 | creates a dummy record | |
23:56 | MARC::Record | |
23:56 | wahanui | MARC::Record is http://search.cpan.org/~gmchar[…]ib/MARC/Record.pm |
23:57 | tcohen | it is relevant to call it with some itemtypes as parameter for some tests that are itype dependent |
23:57 | but it is not called with an itemtype on others | |
23:59 | mtompset | curses... I hate the assumption of default data. |
← Previous day | Today | Next day → | Search | Index