← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:41 | francharb joined #koha | |
| 01:57 | barton_away joined #koha | |
| 02:03 | barton_a1ay joined #koha | |
| 02:15 | barton_a1ay joined #koha | |
| 02:18 | PHAMQUANGQUYEN joined #koha | |
| 02:25 | barton_a1ay joined #koha | |
| 02:37 | barton_a1ay joined #koha | |
| 02:38 | tgoat joined #koha | |
| 02:47 | barton_a1ay joined #koha | |
| 03:08 | barton_away joined #koha | |
| 03:15 | barton_a1ay joined #koha | |
| 03:22 | barton_away joined #koha | |
| 03:29 | barton_a1ay joined #koha | |
| 03:36 | barton_away joined #koha | |
| 03:47 | barton_away joined #koha | |
| 03:58 | barton_away joined #koha | |
| 04:05 | barton_a1ay joined #koha | |
| 06:10 | mtj | hey rangi, about tonite? |
| 07:54 | cait joined #koha | |
| 09:15 | magnuse | kia ora cait |
| 09:15 | cait | hi magnuse :) |
| 09:17 | reading through old bugs a bit and closing some:) | |
| 09:42 | magnuse | cait++ |
| 09:42 | cait | wegot almost 2000 bug reports open currently |
| 09:42 | in NEW | |
| 09:42 | 190 in assigned | |
| 09:43 | not sureif this link works: http://bugs.koha-community.org[…]ngdesc_type=allwo | |
| 09:45 | magnuse | nah, doesn't work |
| 09:45 | but i was looking at the numbers a couple of weeks back or so | |
| 09:45 | we report more bugs than we fix | |
| 09:45 | but a lot of the open ones are enh | |
| 09:47 | cait | yep true |
| 09:47 | i amstill looking at the long list of enh right now | |
| 09:48 | i am trying to make some subjects a bit more specific -hopefully not making it worse :) | |
| 09:48 | magnuse | sorry, gotta run |
| 09:49 | cait | have a nice sunday :) |
| 11:36 | bgkriegel++ :) | |
| 13:15 | ashimema joined #koha | |
| 13:33 | ashimema joined #koha | |
| 14:14 | ashimema joined #koha | |
| 16:42 | Jesse_away joined #koha | |
| 18:55 | catalystpeter joined #koha | |
| 18:59 | catalystpeter | systempreferences's "value" field is text. But installer/data/mysql/updatedatabase.pl likes to write integers to it (e.g. lines 745-746.) Maybe this works OK for Perlish or Mysqlish reasons, but it seems like it has the potential to go horribly wrong. I surmise that if changing a line that writes an integer value in an INSERT or UPDATE statement it should change to a text value (ie stick quotes around it.) Does that seem sane? |
| 18:59 | ^ wrt bz9920 | |
| 19:02 | rangi | bug 9920 |
| 19:02 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9920 enhancement, P5 - low, ---, koha-bugs, NEW , Set minPasswordLength to a higher value by default |
| 19:03 | rangi | catalystpeter: it does seem sane .. if you use placeholders in sql, it does this for you |
| 19:03 | eg update blah set column = ? | |
| 19:04 | $sth->execute($someinteger) | |
| 19:04 | catalystpeter | rangi: thanks - in the case of updatedatabase.pl it is all hard-coded. maybe the whole script is deprecated - hard to know from here. |
| 19:04 | rangi | the dbi module does the appropriate thing, it goes, oh thats a text column and quotes it |
| 19:05 | hm yeah we should fix it to use placeholders, at least for any new ones for a start | |
| 19:05 | catalystpeter | rangi: so, for a trivial patch, if i change |
| 19:05 | $dbh->do("INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('minPasswordLength',12,'Specify the minimum length of a patron/staff password',NULL,'free')"); | |
| 19:06 | so that it uses placeholders it will then look different from all around it | |
| 19:06 | rangi | true, in that case probably best to just do '12' |
| 19:06 | catalystpeter | cool, will do. less risky that way in the short term for this training-wheels committer. |
| 19:06 | rangi | *nod* |
| 19:07 | catalystpeter | rangi: thanks |
| 20:01 | rocio joined #koha | |
| 20:06 | rocio left #koha | |
| 20:21 | rangi | @later tell tcohen look what i found http://alfajores.co.nz/ |
| 20:21 | huginn | rangi: The operation succeeded. |
| 20:22 | wizzyrea | rangi: omgosh. |
| 20:22 | hawkes bay, surprising. | |
| 20:23 | (to me) | |
| 20:23 | rangi | *nod* |
| 20:25 | * cait | is jealous |
| 20:27 | rangi | just volunteered for 3.18.x rmaint .. maybe im still drunk |
| 20:27 | wizzyrea | hehe |
| 20:28 | * cait | thinks so |
| 22:11 | dac | hehe |
| 22:24 | BobB joined #koha | |
| 22:43 | cait left #koha | |
| 22:45 | irma joined #koha | |
| 23:21 | francharb joined #koha | |
| 23:35 | papa joined #koha |
← Previous day | Today | Next day → | Search | Index