← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
Time | Nick | Message |
---|---|---|
00:01 | tgoat joined #koha | |
00:24 | rocio left #koha | |
00:29 | dcook | Woo. Random Daft Punk on the playlist... |
00:29 | :D | |
00:30 | pianohacker | hell yeah |
00:30 | new or old? | |
00:30 | eythian | http://www.burgerwelly.com/#/?quarter=cbd <-- dcook, you should have scheduled a visit for this week |
00:31 | dcook | pianohacker: middle? |
00:31 | Mmmm burgers | |
00:31 | What are kumara crisps? | |
00:31 | eythian | chips made from kumara |
00:31 | dcook | :P |
00:32 | Sweet potato, eh? Neat | |
00:32 | eythian | Kumara is a kind of sweet potato |
00:32 | wnickc joined #koha | |
00:32 | pianohacker | what in tarnation is a crisp |
00:32 | *murica noises* | |
00:34 | dcook | hehe |
00:34 | rangi | pianohacker: what you would call chips |
00:34 | chips are what we call fries | |
00:34 | dcook | pianohacker: If it helps, in Australia, they call chips chips and fries chips. |
00:34 | rangi | also we sometimes call crisps chips too |
00:34 | * dcook | admires the Australian devotion to the potato |
00:35 | pianohacker | wow, I knew a bit but apparently there is even more craziness than I thought |
00:35 | dcook | They also do killer wedges, which are really lacking back in Canada |
00:35 | pianohacker: I have a Canadian friend moving here in 2 weeks, and she's been teaching herself Australian using an app ;) | |
00:35 | pianohacker | bahahahaha |
00:35 | dcook | eythian: Have you checked out any of the burgers yet? |
00:36 | Oh, I really need to stop looking at that website. *drools a bit too much* | |
00:37 | eythian | dcook: foolish question :) |
00:37 | dcook | I have yet to find a really satisfying burger in Australia. |
00:37 | hehe | |
00:37 | eythian | I had the third one for lunch today |
00:37 | dcook | Oooh. That was one of the first ones that piqued my interest. |
00:37 | Hot & Saucy Stag? | |
00:37 | eythian | oh, not in order |
00:38 | doing them in rough order of "what's nearby work" | |
00:38 | dcook | Mmm |
01:01 | wnickc_ joined #koha | |
01:29 | carmenh joined #koha | |
01:48 | ivan joined #koha | |
01:50 | ivan | I have an actively running server that does not yet have email notifications enabled (it doesn't have postfix setup). If I setup postfix on the server will it send old emails that previously could not be sent? |
01:51 | rangi | check the messages table in the database |
01:52 | if its full up with pending messages, then yes | |
01:52 | you can safely delete them | |
01:52 | eythian | start with 'mailq' |
01:52 | ivan | Excellent. I wan't to make sure if I set it up I won't have a bunch of old messages get sent. |
01:53 | Thank you. I will check that now. | |
01:53 | wnickc_ | message_queue or messages? just curious for my own sake |
01:53 | rangi | message_queue |
01:53 | wahanui | it has been said that message_queue is good for reporting |
01:53 | eythian | oh, yeah, that too |
01:54 | also mailq if a mail server was installed but not configured. | |
01:54 | ivan | I am referring to messages as in email notification messages. |
01:54 | So I should check mailq, something else? | |
01:54 | eythian | and message_queue in the koha database |
01:54 | ivan | Ok |
01:56 | dcook | @wunder syd |
01:56 | huginn | dcook: The current temperature in Sydney, New South Wales is 15.0°C (11:52 AM EST on August 19, 2014). Conditions: Heavy Rain Showers. Humidity: 77%. Dew Point: 11.0°C. Pressure: 29.98 in 1015 hPa (Steady). |
01:56 | * dcook | can't tell if it's rain or hail or some new form of precipitation... |
01:56 | dcook | It's like it's falling in every direction at once.. |
01:57 | eythian | @wunder nzwn |
01:57 | huginn | eythian: The current temperature in Wellington, New Zealand is 13.0°C (1:30 PM NZST on August 19, 2014). Conditions: Mostly Cloudy. Humidity: 54%. Dew Point: 4.0°C. Pressure: 30.06 in 1018 hPa (Steady). |
01:57 | eythian | not actually too bad here. |
01:58 | I really wonder how merging biblios handles it if they each have a rating from the same person. | |
01:58 | I bet it explodes | |
02:21 | ivan | eythian: Does it matter if I delete the records from the table using a truncate or a regular delete? |
02:21 | Put another way, should I reset the ID counter? | |
02:21 | Does it matter? | |
02:21 | eythian | doesn't matter, I like to reset the counters, but it's not a big deal either way |
02:21 | ivan | Ok |
02:23 | Alright, mailq and message_queue are clear. Sounds like I am safe to start configuring postfix, no? | |
02:23 | rangi | yep seems alright |
02:23 | eythian | yep |
02:24 | ivan | Excellent thanks again. |
02:34 | bag | @whoami |
02:34 | huginn | bag: I don't recognize you. |
02:34 | bag | boooo |
02:34 | eythian | @whoami |
02:34 | huginn | eythian: I don't recognize you. |
02:34 | eythian | hmm |
02:34 | it spells recognise wrong. | |
02:36 | bag | HA not for me eythian |
02:36 | must be a US bot | |
02:36 | eythian | that's just cos you spell it wrong :) |
02:51 | wnickc_ | goodnight #koha |
06:27 | laurence joined #koha | |
06:31 | ashimema_afk | morning |
06:33 | cait joined #koha | |
06:39 | reiveune joined #koha | |
06:39 | reiveune | hello |
06:40 | indradg joined #koha | |
06:46 | ashimema joined #koha | |
06:50 | indradg joined #koha | |
07:08 | yohann joined #koha | |
07:11 | * cait | waves |
07:13 | cait | @wunder Hannover |
07:13 | huginn | cait: Error: No such location could be found. |
07:14 | cait | @wunder Hannover, Germany |
07:14 | huginn | cait: The current temperature in Hannover, Germany is 14.8°C (9:14 AM CEST on August 19, 2014). Conditions: Scattered Clouds. Humidity: 78%. Dew Point: 11.0°C. Pressure: 29.80 in 1009 hPa (Rising). |
07:14 | ashimema | Hi cait |
07:14 | thought you were away today? | |
07:14 | cait | morning ashimema |
07:14 | i will be :) just checking weather reports | |
07:14 | then breakfast, then zoo :D | |
07:15 | bu tlooks like it's going to rain :( | |
07:16 | ashimema | oh no.. the animals will all hide |
07:17 | indradg | hi #koha |
07:17 | cait | ashimema: i don't want to hear that |
07:18 | * dcook | waves to the folks from the other side of the world |
07:18 | ashimema | hey dcook.. |
07:18 | how hangs it? | |
07:18 | cait | hm someone signed off again! |
07:18 | hehe | |
07:18 | dcook | Long story, but not too bad at the moment |
07:18 | You, ashimema? | |
07:18 | cait | hey dcook |
07:18 | ashimema | not bad. |
07:18 | just reading keyboard reviews.. | |
07:19 | this one may ifnally give up the ghost.. | |
07:19 | not bad for a thrown in with desktop.. cheepy logitch.. best part of 10 years | |
07:19 | dcook | hey cait :) |
07:20 | * dcook | checks his keyboard |
07:20 | ashimema | I'm usre the animals will come out to play cait.. maybe the zoo will be quieter too |
07:20 | dcook | When I was changing desks, I could've switched to a fancier keyboard, but I liked the way my old one felt. |
07:20 | Muscle memory and all t hat | |
07:20 | ashimema | Yeah.. |
07:20 | I know that feeling.. I'm gonna miss this one if it eventually dies.. | |
07:21 | cait | ashimema: giving up the ghost? |
07:21 | we have exactly the same in german | |
07:21 | den geist aufgeben | |
07:21 | ashimema | I kinda like that no-one else in the house can use it too.. it's so warn that none of the keys have the letter on anymore |
07:21 | :) | |
07:21 | cait | heh |
07:22 | breakfast time | |
07:22 | have a good day/evening everyone | |
07:22 | cait left #koha | |
07:23 | ashimema | really wish it was easier to go into a shop and 'play' with a bunch of keyboards.. |
07:26 | dcook | hehe |
07:26 | I really wish it would stop raining so much | |
07:27 | ashimema | There's too much choice in keyboards now.. |
07:27 | dcook | ashimema: You need to talk to pianohacker and cjh. Hehe. |
07:28 | ashimema | Mechanical or Not Mechanical, Ergonomic or Not Ergonomic, Wireless or Wired.. |
07:28 | and that before talking about all the crazy key layouts you can go for if so inclined. | |
07:28 | ack. | |
07:29 | * ashimema | gives up and sticks with his logitech.. hopefully it'll last a bit longer yet |
07:31 | Joubu | good morning #koha |
07:32 | ashimema | morning Joubu |
08:21 | indradg | morning Joubu |
09:28 | BUG 12780 | |
09:28 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12780 enhancement, P3, ---, indradg, NEW , Addition of plugins-menu.inc for handling a nav menu for Koha Plugins |
09:30 | rangi | remember to set it to needs signoff, when you have patches attached ready to test |
09:30 | indradg | thanks rangi |
09:31 | done! | |
09:50 | ashimema | oh.. rangi is here again |
09:51 | indradg.. interestingly enough i looked at that bug this morning beofre the aptches were added ;) | |
09:53 | rangi.. have you looked at the TestBuilder bug.. wondered if you have any comments.. I'm a bit baffled as to the point if i'm completely honest. | |
09:54 | bug 12603 | |
09:54 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12603 enhancement, P5 - low, ---, yohann.dufour, Signed Off , TestBuilder - Module to simplify the writing of tests |
09:55 | Joubu | ashimema: Hi! Why are you baffled? |
09:56 | ashimema | Maybe i'm only looking at the most basic use cases.. but so far I'm sort of inclined to agree with mtompset that the abstraction actually makes the tests slightly more complicated to write? |
09:58 | what does it do beyond wrapping sql in a transaction so it can be rolled back? | |
09:58 | Joubu | ashimema: hum, try to write UT for Acquisition :) |
09:58 | and you will understand why this is useful | |
09:59 | ashimema: sorry, I didn't understand your last question | |
09:59 | ashimema | give me a tic.. re-reading code again |
10:07 | hmm.. it basically sets up dependencies for you right? | |
10:07 | Joubu | that's it |
10:07 | ashimema | so rather than needing to import half of koha's modules.. you just import builder |
10:07 | Joubu | DB dependencies, not modules (pm) |
10:08 | ashimema | then use builder to define the db changes you need for the test |
10:08 | looking at bug 12607, it makes it look like it also does the module imports for you | |
10:08 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12607 enhancement, P5 - low, ---, yohann.dufour, Signed Off , TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t |
10:09 | ashimema | i.e a whole host os 'use' dissapear in the patch.. |
10:09 | is that just un related tify up then? | |
10:09 | Joubu | ashimema: no, the script does not use routines from Biblio, bookseller, etc. anymore |
10:09 | ashimema | k.. so it's unrelated tify up |
10:10 | Joubu | before TestBulder, the UT script has to add a bookseller in DB (so call C4::Bookseller::AddBookseller), add a budget, a biblio, etc. to create an order |
10:10 | now, the script all my $order = TestBuilder->({src => 'order'}); | |
10:10 | and that's all! | |
10:10 | (don't remember the syntax exactly) | |
10:11 | the builder generate the data (bookseller, biblio, budget, etc.) in DB | |
10:11 | with random data (because we don't care about the bookseller name, etc. for unit tests) | |
10:11 | ashimema | I see.. |
10:12 | Joubu | but you can access to the generated data: |
10:12 | +my $supplierid = $order1->{_fk}->{basketno}->{booksellerid}; | |
10:13 | it is certainly not perfect, and some cases will cause problems (I suppose, I don't know). Because the DB structure is quite weird sometimes | |
10:13 | ashimema | my thoughts are mosty that upon adding/editing a module you're learning the internal api's of koha.. and so writing tests with them are surely relatively easy.. whereas with TestBuilder.. you have to learn a new api to be able to write a test using it.? |
10:14 | Joubu | the API is quite simple |
10:14 | ashimema | I suppose i'm just a bit vague as to what real advantage.. other than saving a few lines.. it brings to the table for test writers... |
10:14 | I suppose if your starting by writing tests instead of the other way around it makes pretty good sense | |
10:14 | Joubu | and yes, like all new module, there are methods to call and to know how to call them :) |
10:15 | ashimema | ok.. I'll have a punt at QAing it.. |
10:15 | just wanted to get comments really.. | |
10:15 | Joubu | yep, me too :) |
10:15 | ashimema | did you/yohan see my comment on the bug inquiring as to whether we could use it as a route to makeing more tests db independant? |
10:16 | Joubu | It's not possible to use the TestBuilder for independent UT |
10:17 | That was your question? | |
10:18 | ashimema | not in it's current form.. |
10:18 | my question was.. can you see a followup being able to accomplish some db independance? | |
10:19 | Joubu | ashimema: Actually, I wanted something like you described (if I understand correctly), but it looked quite difficult |
10:19 | ashimema | basically.. I'd like to see allot more mocked so that we don't have to have a configure db to run the tests.. |
10:19 | for instance.. the package builder will not run db dependant tests.. | |
10:19 | Joubu | And the TestBuilder was an idea from yohann. Since I didn't want to impose him something, I let him do what he wanted to do |
10:20 | ashimema | cool.. I see. |
10:21 | right.. got a customer call to get to. | |
10:21 | will take another look at this when i get back.. | |
10:21 | Joubu | ashimema: I don't think it could be extended to independent tests. The main goal is to create the foreign keys (recursively) for a DB row, basically. |
10:21 | trendynick joined #koha | |
10:26 | ashimema | that's a shame.. |
10:27 | I was hoping it could be expanded to instead mock such data/connections. | |
10:27 | I'd prefer to see such an abstraction go the route of making one test work both with or without a database.. | |
10:28 | that way tests could be run more often and more thoroughly. | |
10:28 | anywho.. | |
10:28 | in a call now. | |
10:51 | atheia joined #koha | |
11:17 | kmlussier joined #koha | |
11:32 | indradg joined #koha | |
11:33 | tcohen joined #koha | |
11:35 | kmlussier joined #koha | |
11:37 | tcohen | morning |
11:39 | @wunder cordoba, argentina | |
11:39 | huginn | tcohen: The current temperature in Bo Alto de San Martin, Cordoba City, Argentina is 14.9°C (8:35 AM ART on August 19, 2014). Conditions: Clear. Humidity: 75%. Dew Point: 11.0°C. Pressure: 30.06 in 1018 hPa (Steady). |
11:43 | reiveune left #koha | |
11:46 | collum joined #koha | |
11:50 | reiveune joined #koha | |
11:53 | meliss joined #koha | |
12:09 | barton | morning, #koha! |
12:09 | nengard joined #koha | |
12:12 | barton | I have a question about Home > Tools > Patron lists -- Are these viewable to all staff members, or just to the person who creates the list? |
12:13 | ... and is there any way to control how these are shared? | |
12:15 | nengard | barton just the person who creates the list and not really from the patron side |
12:15 | barton | nengard++ |
12:16 | @karma | |
12:16 | huginn | barton: Highest karma: "gmcharlt" (132), "cait" (118), and "oleonard" (79). Lowest karma: "^" (-7), "-" (-6), and "MARC" (-5). You (barton) are ranked 41 out of 265. |
12:16 | tgoat joined #koha | |
12:16 | barton | @karma barton |
12:16 | huginn | barton: Karma for "barton" has been increased 4 times and decreased 0 times for a total karma of 4. |
12:17 | barton | huh. wonder how that happened. |
12:17 | phasefx_ joined #koha | |
12:17 | barton | @karma nengard |
12:17 | huginn | barton: Karma for "nengard" has been increased 7 times and decreased 0 times for a total karma of 7. |
12:20 | Dyrcona joined #koha | |
12:21 | tcohen joined #koha | |
12:22 | tcohen | morning! |
12:22 | wahanui | it has been said that morning is a state of the cait |
12:31 | ashimema | afternoon! |
12:32 | @karma | |
12:32 | huginn | ashimema: Highest karma: "gmcharlt" (132), "cait" (118), and "oleonard" (79). Lowest karma: "^" (-7), "-" (-6), and "MARC" (-5). You (ashimema) are ranked 6 out of 265. |
12:32 | tcohen | hi ashimema |
12:32 | @karma | |
12:32 | huginn | tcohen: Highest karma: "gmcharlt" (132), "cait" (118), and "oleonard" (79). Lowest karma: "^" (-7), "-" (-6), and "MARC" (-5). You (tcohen) are ranked 5 out of 265. |
12:33 | jenkins_koha | Starting build #548 for job Koha_Docs (previous build: FIXED) |
12:33 | Project Koha_Docs build #548: SUCCESS in 3 min 14 sec: http://jenkins.koha-community.[…]ob/Koha_Docs/548/ | |
12:33 | Nicole C. Engard: fix typo | |
12:38 | ashimema | how goes it tcohen.. |
12:39 | tcohen | fine ashimema |
12:40 | huginn | New commit(s) kohagit: Bug 12708 - Unexpected behaviour in IE 9 and lower when using openWindow <http://git.koha-community.org/[…]52e818cfe8d8f9c8f> / Bug 9180: All branches should be returned if a default rule exists <http://git.koha-community.org/[…]1a5379315b5167127> / Bug 12180 - Remove HTML from batchMod.pl <http://git.koha-community.o |
12:47 | tcohen | @later tell gmcharlt can u take a look at bug 12781 please? |
12:47 | huginn | tcohen: The operation succeeded. |
12:47 | tcohen | khall: around? |
12:47 | khall | yo |
12:47 | tcohen | I added you to bug 12781 cc, could you please take a look too? |
12:47 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12781 major, P5 - low, ---, tomascohen, Signed Off , DBIx::Class schema should preserve case for column names |
12:48 | tcohen | i'm not sure it is a problem introduced by later DBIx::Class::Schema::Loader |
12:48 | or just something we did wrong in the first place | |
12:49 | but it seems to be breaking in several places | |
12:49 | khall | I'll take a look! |
12:50 | huginn | New commit(s) kohagit: Bug 11614: Untranslatable label_element_title in label management <http://git.koha-community.org/[…]24ce363d03e08f407> / Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl <http://git.koha-community.org/[…]ec1e6dc87436a2d22> / Bug 7143 Updating the about page <http://git.koha-community.org/gitweb/?p= |
12:55 | tcohen | khall: thanks! |
13:00 | indradg joined #koha | |
13:30 | jenkins_koha | Project Koha_Master_D7 build #129: UNSTABLE in 47 min: http://jenkins.koha-community.[…]ha_Master_D7/129/ |
13:30 | * Tomas Cohen Arazi: Bug 12753: Warnings in t/SIP_Sip.t could be tested | |
13:30 | * Katrin Fischer: Bug 12501: Show dissertation note (MARC21 502) in XSLT results | |
13:30 | * Bernardo Gonzalez Kriegel: Bug 12177 - Remove HTML from authorities.pl | |
13:30 | * Bernardo Gonzalez Kriegel: Bug 12180 - Remove HTML from batchMod.pl | |
13:30 | * Jonathan Druart: Bug 9180: All branches should be returned if a default rule exists | |
13:30 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12753 trivial, P5 - low, ---, chris, Pushed to Master , Warnings in t/SIP_Sip.t could be tested |
13:30 | jenkins_koha | * David Cook: Bug 12708 - Unexpected behaviour in IE 9 and lower when using openWindow |
13:30 | * Chris Cormack: Bug 7143 Updating history | |
13:30 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12501 enhancement, P5 - low, ---, katrin.fischer, Pushed to Master , Show Dissertation note (MARC21 502) in XSLT results |
13:30 | jenkins_koha | * Chris Cormack: Bug 7143 Updating the about page |
13:30 | * Bernardo Gonzalez Kriegel: Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl | |
13:30 | * Bernardo Gonzalez Kriegel: Bug 11614: Untranslatable label_element_title in label management | |
13:30 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12177 minor, P5 - low, ---, bgkriegel, Pushed to Master , Remove HTML from authorities.pl |
13:30 | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12180 minor, P5 - low, ---, bgkriegel, Pushed to Master , Remove HTML from batchMod.pl | |
13:30 | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9180 major, P5 - low, ---, jonathan.druart, Pushed to Master , Default rules are not always used for overdues | |
13:30 | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12708 normal, P5 - low, ---, dcook, Pushed to Master , Unexpected behaviour in IE 9 and lower when using openWindow | |
13:30 | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7143 trivial, P5 - low, ---, m.de.rooy, ASSIGNED , Bug for tracking changes to the about page | |
13:30 | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12695 minor, P5 - low, ---, bgkriegel, Pushed to Master , Remove CGI::scrolling_list from marc21_linking_section.pl | |
13:30 | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=11614 normal, P5 - low, ---, bgkriegel, Pushed to Master , Untranslatable label_element_title in label management | |
13:43 | Joubu | Hum, on the catalogue result page (intranet), I got "No item was selected" when I try to add some records to the cart. Could someone confirm there is a bug? |
13:43 | (of course, I selected items...) | |
13:44 | Actually the checkbox does not contain the biblionumber... | |
13:46 | edveal joined #koha | |
13:48 | talljoy joined #koha | |
14:06 | rocio joined #koha | |
14:07 | Joubu | it's really not a good idea to map biblio.biblionumber with something else before going go away for 3 weeks... |
14:19 | ashimema | good luck Joubu |
14:24 | jenkins_koha | Yippee, build fixed! |
14:24 | wahanui | o/ '`'`'`'`'`'`'`'`'` |
14:24 | jenkins_koha | Project Koha_Master_D7 build #130: FIXED in 46 min: http://jenkins.koha-community.[…]ha_Master_D7/130/ |
14:42 | tcohen | hi Joubu |
14:42 | is it a problem on your local branch or on master? | |
14:43 | indradg joined #koha | |
14:43 | Joubu | tcohen: no, just in my head... |
14:43 | tcohen | heh |
14:44 | Joubu | I changed the mapping of biblio.biblionumber 3 weeks ago, and of course, I forgot to restore the good value |
14:44 | (don't ask me why...) | |
14:44 | jwagner joined #koha | |
14:58 | Callender joined #koha | |
14:59 | nengard left #koha | |
15:01 | Callender joined #koha | |
15:02 | yohann left #koha | |
15:04 | smrt joined #koha | |
15:06 | smrt | hi everyone, I might be completely overlooking something but is there a way to prevent patrons from placing holds through the OPAC if they have overdue items? |
15:30 | reiveune | bye |
15:30 | reiveune left #koha | |
15:36 | jenkins_koha | Yippee, build fixed! |
15:36 | wahanui | o/ '`'`'`'`'`'`'`'`'` |
15:36 | jenkins_koha | Project Koha_Master_U12 build #135: FIXED in 58 min: http://jenkins.koha-community.[…]a_Master_U12/135/ |
15:43 | nengard joined #koha | |
15:48 | huginn | New commit(s) kohagit: Bug 12432 [QA Followup] - Make "All" tab work when switching back to it <http://git.koha-community.org/[…]91c34123b75e1ad9f> / Bug 12432 - Saved reports tabs not working <http://git.koha-community.org/[…]6a445c726137710a8> |
15:56 | tcohen | is there a free QA Cslot? |
15:56 | bug 12782 | |
15:56 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12782 normal, P5 - low, ---, chris, Signed Off , t/db_dependent/XISBN.t should work on DOM too |
15:58 | New commit(s) kohagit: Bug 11842 - fix framework caching with memcache/plack <http://git.koha-community.org/[…]1f2562d062004d7fd> / Bug 12589 - Manage label batch view should show item type description instead of... <http://git.koha-community.org/[…]7b70cfff31d13b0f0> / Bug 12694: Remove CGI::scrolling_list from unimarc_field_4XX.pl <http:/ | |
16:04 | nengard left #koha | |
16:13 | indradg joined #koha | |
16:14 | carmenh joined #koha | |
16:50 | jenkins_koha | Yippee, build fixed! |
16:50 | wahanui | o/ '`'`'`'`'`'`'`'`'` |
16:50 | jenkins_koha | Project Koha_Master_U12_MariaDB build #67: FIXED in 56 min: http://jenkins.koha-community.[…]r_U12_MariaDB/67/ |
16:50 | * Kyle M Hall: Bug 12432 - Saved reports tabs not working | |
16:50 | * Kyle M Hall: Bug 12432 [QA Followup] - Make "All" tab work when switching back to it | |
16:50 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12432 major, P5 - low, ---, kyle, Pushed to Master , Saved reports tabs not working |
16:57 | RubEns joined #koha | |
16:59 | RubEns | Hi, any idea to save the search results in koha and create report, need to know the most viewed items or searches made. |
17:02 | pippIn joined #koha | |
17:02 | pippIn left #koha | |
17:03 | RubEns | Hi, any idea to save the search results in koha and create report, need to know the most viewed items or searches made. |
17:05 | wnickc joined #koha | |
17:10 | jenkins_koha | Project Koha_Master_D7 build #132: UNSTABLE in 47 min: http://jenkins.koha-community.[…]ha_Master_D7/132/ |
17:10 | * Kyle M Hall: Bug 12432 - Saved reports tabs not working | |
17:10 | * Kyle M Hall: Bug 12432 [QA Followup] - Make "All" tab work when switching back to it | |
17:10 | * Bernardo Gonzalez Kriegel: Bug 12704: Remove CGI::scrolling_list from unimarc_field_225a.pl | |
17:10 | * Bernardo Gonzalez Kriegel: Bug 12694: Remove CGI::scrolling_list from unimarc_field_4XX.pl | |
17:10 | * Owen Leonard: Bug 12589 - Manage label batch view should show item type description instead of code | |
17:10 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12432 major, P5 - low, ---, kyle, Pushed to Master , Saved reports tabs not working |
17:10 | jenkins_koha | * Robin Sheat: Bug 11842 - fix framework caching with memcache/plack |
17:10 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12704 normal, P5 - low, ---, bgkriegel, Pushed to Master , Remove CGI::scrolling_list from unimarc_field_225a.pl |
17:10 | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12694 normal, P5 - low, ---, bgkriegel, Pushed to Master , Remove CGI::scrolling_list from unimarc_field_4XX.pl | |
17:10 | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12589 normal, P5 - low, ---, robert.higgins, Pushed to Master , Manage label batch view should show item type description instead of code | |
17:10 | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=11842 normal, P5 - low, ---, robin, Pushed to Master , MARC framework editing is broken when memcache is enabled | |
17:12 | cma joined #koha | |
17:16 | jmsasse joined #koha | |
17:28 | pabloab joined #koha | |
17:29 | jmsasse joined #koha | |
17:30 | bag | hey jmsasse |
17:30 | jmsasse | Bag: hiya. |
17:30 | bag | I should be able to have a call tomorrow |
17:30 | what time where you thinking? you can talk in your local time - I'll adjust | |
17:31 | jmsasse | My director is in office tomorrow. |
17:32 | 11:30 AM? | |
17:33 | bag | hmm... ok I'll put it on the calendar |
17:33 | can you email me a phone number to use? | |
17:33 | jmsasse | Permissions development was the topic? |
17:34 | email to brendanbywatersolutions.com? | |
17:34 | bag | it was more a general what's important for you - khall already understand the permissions development topic |
17:34 | that works jmsasse | |
17:34 | jmsasse | OK, my director will have some input on that for you. |
17:34 | bag | cool :) |
17:35 | jmsasse | Sorry I stumbled into the wrong channel. |
17:36 | bag | no worries :) |
17:36 | jmsasse++ | |
17:36 | jmsasse | Forgot it was #bws-partners. |
17:36 | khall active? | |
17:39 | Khall: great job on covers that flow :-) | |
17:39 | Pablo2 joined #koha | |
17:39 | jmsasse | Khall: been looking for something like that for a while. |
17:41 | talljoy joined #koha | |
17:51 | Pabloab joined #koha | |
18:09 | francharb joined #koha | |
18:15 | tcohen | hi bag |
18:16 | bag | hey tcohen |
18:17 | tcohen | joy, nicole and you? |
18:24 | @later tell wizzyrea please take a look at a filesystem permission error when trying to export/download the registration data (on cform) | |
18:24 | huginn | tcohen: The operation succeeded. |
18:27 | pianohacker joined #koha | |
18:41 | tcohen | ashimema: do u know why we use patron_id instead of patronId on ILS-ID? |
18:42 | * tcohen | is reading the specification and maybe not understanding something |
18:55 | edveal joined #koha | |
19:06 | tcohen | bye #koha |
19:28 | Dyrcona1 joined #koha | |
19:32 | jenkins_koha | Starting build #549 for job Koha_Docs (previous build: SUCCESS) |
19:32 | Project Koha_Docs build #549: SUCCESS in 2 min 19 sec: http://jenkins.koha-community.[…]ob/Koha_Docs/549/ | |
19:32 | Nicole C. Engard: retitle for 3.18 | |
19:43 | rangi | ashimema: fwiw i dont really get it either, hence my no comment |
19:46 | tcohen joined #koha | |
19:46 | rangi | hi tcohen |
19:47 | tcohen | hi rangi |
19:47 | rangi: you're familiar with ILS-ID, right? | |
19:48 | Dyrcona joined #koha | |
19:48 | rangi | not really, it was a standard that failed, not many things use it in the wild unfortunately |
19:49 | tcohen | oh, I see |
19:50 | i was looking at a passedqa bug, and noticed there's somediscrepancy on how stuff is named | |
19:51 | (between the 1.1 version that is online, and Koha's code) | |
19:51 | rangi | http://www.diglib.org/community/groups/ils-di/ basically it morphed into XC |
19:51 | yeah, there was never a ratified standard | |
19:52 | so compliance isnt really a thing | |
19:52 | Dyrcona1 joined #koha | |
19:55 | rangi | tcohen: it might be worth emailing to ask who is using the ils-di api |
19:56 | tcohen_ joined #koha | |
19:56 | tcohen_ | are we part of the specification writing board? |
19:56 | rangi | and wether renaming things would break stuff for them |
19:56 | tcohen_ | rangi: so ILS-DI -> NCIP 2.0? |
19:56 | (i mean, Koha) | |
19:56 | rangi | tcohen_: there is no ILS-DI anymore |
19:56 | there never was | |
19:56 | there was a recommendation | |
19:56 | no one (apart from us and a couple of others) ever implemented it | |
19:57 | 07:55 <@rangi> tcohen: it might be worth emailing to ask who is using the ils-di api | |
19:57 | 07:56 <@rangi> and wether renaming things would break stuff for them | |
19:57 | http://www.diglib.org/community/groups/ils-di/ | |
19:57 | tcohen_ | rangi: sorry, networking issues |
19:57 | rangi | no worries |
19:57 | tcohen_ | the old tcp connexion took over my nickname |
19:58 | so, you're familiar with ILS-DI :-P | |
19:58 | i mean, NCIP | |
19:58 | gmcharlt | well, the BibLibre Drupal stuff still uses the ILS-DI API, right? |
19:58 | rangi | afaik yes, and i think EDS do too |
19:59 | so changing the names might break stuff for them | |
19:59 | what i was trying to say, is there isnt actually a standard to comply to, so not breaking for existing users is probably better | |
19:59 | but i probably wasnt being clear | |
19:59 | tcohen_ | it is clear rangi |
19:59 | bug 8868 | |
20:00 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8868 normal, P3, ---, julian.maurice, Passed QA , ILS-DI: CancelHold needs to take a reserve_id |
20:00 | tcohen_ | is changing the API |
20:00 | rangi | ah yep, afaik only the biblibre drupal connector uses that functionality |
20:00 | so that might be ok, but it might be worth asking on the list? | |
20:01 | * tcohen | thinks the drupal connector has its own api implementation (koha-restfull) |
20:01 | gmcharlt | tcohen: they may have changed at some point? |
20:01 | but rangi's right, can ask | |
20:02 | * tcohen | is not sure, he just thought they wrote it for that purpose |
20:02 | rangi | could well b |
20:02 | e | |
20:02 | tcohen | PTFS-Europe also uses ILS-DI for his VuFind KohaRest driver |
20:03 | rangi | im guessing since they are changing it, biblibre must be using it for something still |
20:03 | tcohen | np, will ask on the dev list |
20:03 | rangi | sweet |
20:04 | im trying to track down this 400 thing | |
20:04 | that seems to have got everyone excited | |
20:04 | man i wish libraries would get this excited about other stuff | |
20:04 | maybe we should purposefully breakt things once in a while to keep them engaged | |
20:04 | tcohen | what is that 400 thing? |
20:04 | pianohacker | so the facebook approach? |
20:05 | cait joined #koha | |
20:05 | tcohen | pianohacker: heh |
20:05 | rangi: facets? | |
20:05 | wahanui | facets are drawn from the records in the search results and are being worked on in bug 11232: http://bugs.koha-community.org[…]_bug.cgi?id=11232 |
20:05 | pianohacker | just in time, cait |
20:05 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=11232 new feature, P5 - low, ---, gmcharlt, ASSIGNED , Retrieve facets from Zebra |
20:05 | 04Bug 11232: new feature, P5 - low, ---, gmcharlt, ASSIGNED , Retrieve facets from Zebra | |
20:05 | cait | hm? |
20:05 | rangi | tcohen: yep |
20:05 | pianohacker | you're in big trouble, cait... |
20:05 | tcohen | yeah, is dcook's fault |
20:05 | cait | am i? |
20:05 | rangi | http://lists.katipo.co.nz/pipe[…]ugust/040519.html |
20:05 | cait | why this time? |
20:05 | rangi | that thread |
20:05 | tcohen | he promised to patch C4::Search to retrieve facets from Zebra |
20:06 | :-P | |
20:06 | cait | ?? |
20:06 | rangi | im just trying to figure out what added the 400s |
20:06 | cait | a prf |
20:06 | a pref | |
20:06 | rangi | there is a pref? |
20:07 | cait | there is a system preference that will allow you to search for 400 from auth in your bibliograhic search |
20:07 | rangi | and it went in on? |
20:07 | cait | nope |
20:07 | not to my knowledge | |
20:07 | maybe for new, but not on existing | |
20:07 | it's off in ours | |
20:07 | rangi | then how are people who upgraded seeing 400 |
20:07 | in the facets | |
20:07 | can you remember the bug? | |
20:08 | cait | let me find the pref, then take a shower ok? i just got in from aloooong day of walking and seeing lots of animals .) |
20:08 | rangi | k |
20:08 | im reading the code, i dont see a pref being used in building the facets, but i hope im wrong | |
20:08 | tcohen_ joined #koha | |
20:08 | cait | not in the facets |
20:08 | rangi | oh |
20:09 | well its the facets that we are talking about | |
20:09 | cait | it includes the forms in the bilbiographic record |
20:09 | and probably they get indexed | |
20:09 | and then included in the numbers, is my guess | |
20:09 | rangi | right so the index must have been added |
20:09 | cait | but i haven't read all of it the emails yet |
20:09 | yeha, it's the point of the feature | |
20:09 | pianohacker | we're not doing a grs1 deprecation until 3.18 at the earliest, right? so that's not related? |
20:09 | cait | it's for people who want to find the sheet music from tschaikovsky, no matter how it's spelled |
20:09 | rangi | http://lists.katipo.co.nz/pipe[…]ugust/040511.html |
20:10 | yeah that makes sense | |
20:10 | cait | the pref is IncludeSeeFromInSearches |
20:10 | rangi | but its specifically to do with facets |
20:10 | cait | it adds the 400 from the authorities to zebra |
20:10 | it uses an indicator z | |
20:10 | rangi | right so that will be the issue then |
20:10 | cait | to differentiate from other fields i think |
20:10 | rangi | cos those are added |
20:10 | whether you want to search them or not | |
20:11 | cait | i can try to read up the thread in a bit, but need to warm up first |
20:11 | lots of rain here today, i got soaked :) | |
20:11 | rangi | the thread isnt actually useful |
20:11 | just that one email | |
20:11 | the thread is just a lot of 'me too' | |
20:12 | cait | i have 24 emails in my inbox from today - no idea what's there yet, but need to change out of wet clothes now :) |
20:12 | * tcohen_ | doesn't see why indexes are related to facets |
20:13 | rangi | the change is |
20:13 | my $marc_record = new_record_from_zebra ( | |
20:14 | but i dont think that did it either | |
20:15 | tcohen joined #koha | |
20:16 | pastebot | "rangi" at 127.0.0.1 pasted "the facet changes" (54 lines) at http://paste.koha-community.org/161 |
20:16 | rangi | its something in there, thats my suspicion |
20:17 | cait | hm the z seem to be excluded |
20:17 | 516 | |
20:17 | i really have to read the thread in a moment i think | |
20:17 | could it be that a name is doubled? | |
20:17 | rangi | you really dont :) |
20:17 | cait | like ti appears in 100 |
20:17 | so it would show up in facets | |
20:17 | but when you click on it | |
20:18 | the search goeson the aut index | |
20:18 | rangi | you only have to read the one email, the rest is blah blah i dont like it |
20:18 | cait | and that also includes the 400 |
20:18 | rangi | but no more info |
20:18 | cait | so you get more results that it would show in the count |
20:18 | rangi | its not the name is double |
20:18 | tcohen joined #koha | |
20:18 | rangi | its that 100s and 400s are now showing in the author facets |
20:18 | they dont want to see 400s there | |
20:19 | tcohen | facets are read from C4::Koha::getfacets |
20:19 | rangi | and if you revert that chunk of code |
20:19 | i pasted | |
20:19 | you get the old behaviour | |
20:19 | http://lists.katipo.co.nz/pipe[…]ugust/040511.html | |
20:20 | cait | hm i think the 400 arenot 400 when added to the record |
20:20 | they might be 1xx with an indicator z then | |
20:20 | rangi | so i wonder if cait is on to somehing with the z |
20:20 | yes | |
20:20 | i think so | |
20:20 | thats the diff | |
20:20 | cait | becuase 400 is something else on bibliographic level |
20:20 | rangi | in 3.14.x |
20:20 | we drop the z's | |
20:20 | in 3.16.x we dont | |
20:21 | at least i think thats what we are doing :) | |
20:21 | cait | drop before display? |
20:22 | the feature came in 3.12 i think | |
20:22 | with the authority work from jared | |
20:22 | and i am still in wet clothes... brb | |
20:22 | rangi | i dont think its to do with that feature |
20:22 | i can replicate the behaviour in that email | |
20:22 | tcohen | rangi: line 516, right? |
20:22 | cait | without it being turned on, you dan't have the 400 at all on bibliogrpahic level :) |
20:22 | rangi | it doesnt matter |
20:22 | they still show | |
20:22 | cait | or you shouldn't |
20:22 | rangi | in the facets |
20:23 | cait | because that would be a bug |
20:23 | rangi | you can turn it off |
20:23 | they will still show | |
20:23 | cait | authorities and bibiographic data don't get combined ithout |
20:23 | after reindexing? | |
20:23 | rangi | tcohen: yep |
20:23 | cait | it works similar like adding the items i think |
20:23 | gah, brb, really now | |
20:23 | tcohen | we just need to filter z |
20:23 | rangi | tcohen: i think so yeah |
20:24 | i think it accidentally changed when we did bug 11096 | |
20:24 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=11096 major, P5 - low, ---, gmcharlt, Pushed to Master , Koha cannot retrieve big records from Zebra |
20:26 | * tcohen | doesn't like the idea of having angry people in cordoba to take revenge |
20:26 | rangi | ill write a mail to the list saying we have tracked it down and it is to do with the z subfields |
20:26 | please file a bug and we will fix it | |
20:26 | somethign like that | |
20:26 | tcohen | awesome |
20:28 | jmsasse_ joined #koha | |
20:29 | tcohen | from getfacets |
20:29 | { | |
20:29 | idx => 'au', | |
20:29 | label => 'Authors', | |
20:29 | tags => [ qw/ 100a 110a 700a / ], | |
20:29 | sep => ', ', | |
20:29 | }, | |
20:29 | rangi | *nod* |
20:31 | tcohen | maybe it is a bug in MARC::Record |
20:32 | my $data = $field->as_string( $subfield_letters, $facet->{sep} ); | |
20:32 | rangi | could be, but its something that we used to handle in 3.14.x and dont in 3.16.x |
20:32 | * tcohen | agrees, it is just he can't understand what's going on, yet |
20:32 | rangi | yeah |
20:32 | tcohen | steps to reproduce? |
20:32 | wahanui | steps to reproduce are on comment 1 |
20:33 | tcohen | have a record with 100$z ? |
20:33 | check $z appears in the author's facet? | |
20:33 | rangi | yep |
20:33 | basically have 100a | |
20:34 | linking to an authority that has 400 fields | |
20:34 | and see if those 400s show up in the facet | |
20:34 | tcohen | ok |
20:36 | cait | tcohen: indicator z |
20:36 | but what rangi said | |
20:37 | tcohen | second indicator z in the 100 field of the authority record? |
20:38 | cait | nope |
20:39 | you got 100 in bibliographic | |
20:39 | and a normal authority with a main heading and 400 | |
20:39 | tcohen | ok, that's correct |
20:39 | cait | then you have IncludeSeeFromInSearches turned on (i think) |
20:39 | and reindex | |
20:39 | tcohen | http://snag.gy/Qhux0.jpg |
20:39 | ah | |
20:40 | rangi | yeah thats it |
20:40 | cait | and it should add the 400 from the authority to your zebra indexed record, as i think 1xx with an indicator z |
20:40 | rangi | you need that pref on and reindex |
20:40 | however if you turn it off | |
20:40 | and dont do a full reindex | |
20:40 | they will still stay there | |
20:40 | cait | because the records don't get... recomposed? |
20:40 | rangi | until you edit them |
20:40 | tcohen | http://snag.gy/UcwS2.jpg |
20:40 | reproduced | |
20:40 | cait | yep |
20:41 | rangi | yeah and then git checkout v3.14.09 |
20:41 | and refresh | |
20:41 | and its gone | |
20:41 | without doing any indexing or anything | |
20:41 | tcohen | is the feature present in 3.14? |
20:41 | (includeseefrom...) | |
20:41 | rangi | yep |
20:42 | tcohen | 3.12.0 feature... |
20:43 | cait | yep |
20:43 | tcohen | ah |
20:44 | understood | |
20:44 | found the code that mangles the records on behalf of rebuild_zebra.pl | |
20:46 | rangi | sent an email |
20:52 | tcohen | ok, have the fix |
20:52 | rangi | sweet you can reply to my email :) |
20:52 | id really like one of the libraries to file the bug | |
20:52 | will see if they do | |
20:55 | pastebot | "tcohen" at 127.0.0.1 pasted "this works" (19 lines) at http://paste.koha-community.org/162 |
20:56 | rangi | looks like a perfectly valid fix |
20:56 | however | |
20:56 | please put a | |
20:56 | # we need to drop the z so we dont get 400s from authority files in the facets | |
20:56 | or something like that | |
20:56 | or someone will remove it again some time in the future :) | |
20:57 | tcohen | don't worry |
20:57 | we will have a regression test for this one | |
20:57 | rangi | yay :) |
20:57 | tcohen | heh |
20:57 | rangi | comments are still handy tho |
20:57 | if it had been commented in 3.14x | |
20:57 | tcohen | yeah |
20:57 | rangi | we would have spotted it a ton faster |
21:00 | * cait | likes comments :) |
21:01 | rangi | i wonder what i was actually going to do today |
21:02 | * cait | could make suggestions :) |
21:02 | rangi | i think it was tidy up and send up my patches for adding multiple covers to the opac, with fallback |
21:02 | tcohen | :-D |
21:03 | rangi | http://git.catalyst.net.nz/gw?[…]fs/heads/wr222309 |
21:03 | that stuff | |
21:03 | wahanui | that stuff is calculated on the fly, but I'm not an expert on that |
21:04 | * cait | approves :) |
21:04 | rangi | although that might have to wait until next week |
21:04 | pianohacker: question for you | |
21:05 | in systempreferences can we do multiple dropdowns for a syspref? | |
21:05 | tcohen | rangi: btw, thanks for signing the XISBN.t patches :-D |
21:05 | rangi | eg, i want to say i want to try local, then google, the nznatlib covers |
21:05 | tcohen | /rangi, yes |
21:06 | rangi | currentlyt the syspref is Local|Google|NZNatlib |
21:06 | which works great, but is pretty stink UX :) | |
21:06 | oh cool | |
21:07 | tcohen | BakerTaylorUsername |
21:07 | BakerTaylorPassword | |
21:07 | rangi | thanks tcohen |
21:08 | rocio_lunch: whats for lunch? | |
21:08 | rocio_lunch | soup! |
21:08 | lol | |
21:08 | rangi | nice :) |
21:08 | rocio_lunch | :) |
21:08 | rangi | http://www.burgerwelly.com/#/?quarter=lambton <--- somethign from here will be mine |
21:08 | (in 3 hours or so) | |
21:09 | tcohen | heh |
21:09 | rangi | tcohen: ahhh those are 2 different prefs tho |
21:09 | tcohen | ah, yes |
21:09 | rangi | - pref: BakerTaylorUsername - pref: BakerTaylorPassword |
21:10 | tcohen | but shown on the same place |
21:10 | rangi | yep |
21:10 | ill keep thinking | |
21:10 | i dont really want to have to make 8 sysprefs | |
21:10 | and then you chose the 1, 2, 3, 4 etc | |
21:10 | tcohen | heh |
21:11 | rangi | for the order you want them to fallback in |
21:11 | * tcohen | belives rangi will use YAML at some point |
21:11 | cait | rangi: there is a patch from jonathan about the multiple drop down i think - want me to find it? |
21:11 | rangi | yes please |
21:12 | cait | bug 9043 i think |
21:12 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9043 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Adding system preferences to control the visibility of the content on the Advanced Search page |
21:13 | cait | he just redid it bcaues there was a roblem with the first javascript library used |
21:13 | haven't taken a look at the new patch yet (it's from today) | |
21:13 | rangi | sweet ill take a look, thanks |
21:14 | cait | nto sure if it's what you need, but hsould be quick to check |
21:19 | @later tell francharb i'd really like to take a look at your overdues spec,but I am on vacation until end of this week | |
21:19 | huginn | cait: The operation succeeded. |
21:21 | pianohacker | rangi: like a <select multiple>? |
21:22 | rangi | kinda, except it has to be ordered |
21:22 | the order matters | |
21:23 | i dunno how you would do that with a select multiple | |
21:23 | cait | hm maybe need another option then |
21:23 | rangi | ideally you have one dropdown with 8 options you select one, then you get another dropdown with 7 options now |
21:23 | cait | hm maybe something like jared did for the opac plugins? |
21:24 | you can drag and drop them | |
21:24 | rangi | but no idea htfu to do that |
21:24 | cait | and they are stored in a pref i think |
21:24 | pianohacker | yeah what she said |
21:24 | rangi | oh yeah that would work too |
21:24 | yay | |
21:24 | pianohacker | worse case it's really pretty easy to add a new preference type |
21:24 | assuming that the code is roughly as sane as I remember | |
21:25 | rangi | sweet |
21:25 | thanks, basically thats the last bit i have to do before this Koha::CoverImages and Koha::CoverImages::Local etc are ready to submit | |
21:25 | francharb | It would be awesome cait. Enjoy your vacation and we will talk about the rfc after! Thanks! |
21:26 | cait | francharb: i also left a question on one the bug reports i think |
21:26 | francharb | ok, i will take a look tomorrow!! |
21:26 | cait | cool :) |
21:26 | francharb | :) |
21:27 | pianohacker | :D! |
21:28 | cait: what's the thing you were talking about with the opac plugins? I'd like to take a look | |
21:28 | cait | oh |
21:28 | it's outside the systme preference editor | |
21:28 | go to administration | |
21:28 | then it has it's own page | |
21:29 | but i think it is saved as some kind of data structure into a pref | |
21:29 | administration > did you mean | |
21:29 | pianohacker | ohh, smooth! |
21:30 | cait | you can pick them and reorder |
21:30 | also activate some and not others - not sure how this oculd be integrated into the editor, but it would be cool :) | |
21:31 | pianohacker | it could just be another preference type; there's already all the custom stuff for language settings |
21:31 | rangi | i could totally put it outside system preferences |
21:31 | under tools | |
21:32 | Cover Images | |
21:32 | wahanui | Cover Images are the only thing not broken, and it's starting to look like they're breaking now too |
21:32 | rangi | there is no reason it has to be under sysprefs really |
21:32 | ill have a think about that too | |
21:32 | pianohacker | only thing putting it under sysprefs gives you is some level of organization and searchability. Not like there's really a strong convention either way, though. |
21:35 | rangi | yeah |
21:36 | pianohacker | I should work on that cronjob unification idea I had... |
21:36 | cait | pianohacker: rancor patches first! :P |
21:37 | rangi | heh |
21:37 | pianohacker | rangi, tcohen: question for you guys. Part of the work I did for my school/Koha project was refactoring the C4::Service API into an object-oriented Koha::Service API, and porting all the existing services to it. What would be involved with integrating that, in your minds? Especially as goes unit tests? |
21:39 | cait: Waiting to hear back on a big set of changes from our client, we're getting close to a big milestone, I promise :) If you're interested, my github branch, https://github.com/pianohacker[…]ree/rancor-submit, is up to date | |
21:39 | rangi | first up, im super happy thats been done |
21:39 | cool | |
21:39 | cait | pianohacker: i can wait - just really want for it to make it in |
21:39 | rangi | i have to go be a consultant on continuous integration and stuff for a uni here for the next couple of days, (which i think im doing wrong cos i always end up doing work) |
21:39 | cait | and time is running rally |
21:40 | rangi | but will have a chance to look next week |
21:40 | pianohacker | same here! When's the next feature freeze? |
21:40 | rangi | i think the way id do it is |
21:40 | cait | tcohen: did we set the dates yet? |
21:40 | rangi | submit tests and the module first |
21:40 | then patches switching things to using it | |
21:40 | kinda like the replyto stuff i did i guess | |
21:41 | cait | pianohacker: release is november - about half of the time is gone now i think? |
21:41 | rangi | tcohen might have a better suggestion |
21:42 | http://bugs.koha-community.org[…]w_bug.cgi?id=9530 | |
21:42 | huginn | 04Bug 9530: enhancement, P5 - low, ---, chris, Needs Signoff , Allow separate 'Reply To' and 'From' email address for notices |
21:42 | pianohacker | I like that. I'll do my best to add lots of unit tests to Koha::Service itself. The tricky part is testing as far as the ported services go, especially since they're all so different |
21:42 | rangi | bascially the first 2 signed off ones added all the infrastructure |
21:42 | then each patch after switched more stuff to use it | |
21:42 | yeah | |
21:42 | pianohacker | bug 12272 |
21:42 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=12272 enhancement, P5 - low, ---, jweaver, NEW , Refactor C4::Service API into Koha::Service class |
21:43 | rangi | cool |
21:43 | pianohacker | ah, that makes sense. will need some rebasing, but open source makes you a rebase ninja pretty fast :) |
21:45 | wizzyrea | rangi regarding your ordered sysprefs, could you do it like the interface in the notice editor? |
21:46 | rangi | true |
21:46 | that could work too | |
21:47 | Mahdi joined #koha | |
21:53 | wnickc | bye #koha! |
21:54 | tcohen | pianohacker, cait: i haven't set official dates, but october is expected to be feature freeze |
21:54 | wizzyrea | tcohen: try your download now |
21:54 | tcohen | and also, I agree with rangi's approach |
21:54 | having the libs included with good tests coverage | |
21:55 | cait | tcohen: ok |
21:55 | tcohen | and switching each functionality at a time |
21:55 | with the help of us, the testers :-D | |
21:55 | wizzyrea: will do | |
21:55 | pianohacker | tcohen: what are your opinions as far as test plans/etc. for the /svc/ stuff, since they're such a mixed bag |
21:55 | cait | pianohacker: but that doesn't mean submitting the feature by october.. ;) |
21:56 | pianohacker | cait: oh heavens no. If school doesn't decide to cheerfully murder me right out the gate, I'm hoping to have a new patchset by the end of this month |
21:56 | tcohen | pianohacker: i think there needs to be consensus on that |
21:56 | but I thought having /api/v1.0/ for a REST API would be a good start | |
21:56 | (instead of /svc) | |
21:56 | pianohacker | tcohen: oh right that touches on that long email chain on the list... |
21:57 | tcohen | yeap |
21:57 | pianohacker | tcohen: I'll start by just porting the systempreferences API, since that's small and easy to test |
21:57 | tcohen | i am writing some crud stuff there |
21:57 | pianohacker | We have two incompatible output formats and authentication schemes (at least) in /svc/, so there's a lot more to standardize |
21:58 | the current Koha::Service class is focused on preserving the current functionality of both the XML and JSON services | |
21:58 | tcohen | pianohacker: i'd spend time on the api-key authentication mechanism, or even our oauth2 implementation |
21:58 | wizzyrea++ # it worked! | |
21:58 | bbl | |
22:02 | pianohacker | @later tell tcohen do we have any patches or existing code using either of those? |
22:02 | huginn | pianohacker: The operation succeeded. |
22:02 | cait1 joined #koha | |
22:07 | pianohacker | hi internet |
22:12 | eythian | hi |
22:12 | wahanui | privet, eythian |
22:14 | pianohacker | yo eythian |
22:18 | cait1 | good night :) |
22:19 | pianohacker | night cait1 |
22:19 | cait1 left #koha | |
22:36 | tcohen | hi |
22:55 | Mahdi joined #koha | |
23:14 | Mahdi joined #koha | |
23:19 | Mahdi_ joined #koha | |
23:26 | papa joined #koha |
← Previous day | Today | Next day → | Search | Index