← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:10 | tcohen | hehe |
| 00:11 | another one? | |
| 00:12 | rangi | that was more like it, if they keep playing like that, it will be competitive |
| 00:15 | so far thats 4 tries from wellington players | |
| 00:34 | talljoy joined #koha | |
| 02:23 | NateC joined #koha | |
| 02:47 | wajasu joined #koha | |
| 03:11 | eythian_ joined #koha | |
| 04:47 | libsysguy joined #koha | |
| 05:48 | libsysguy joined #koha | |
| 05:48 | mtompset joined #koha | |
| 05:49 | mtompset | Greetings, #koha. |
| 05:55 | cait joined #koha | |
| 06:02 | mtompset | Greetingd, cait. |
| 06:02 | cait | hi mtompset |
| 06:03 | mtompset | Greetings even. :) |
| 06:04 | Is Barcodes_ValueBuilder.t a required test? | |
| 06:04 | cait | ? |
| 06:05 | mtompset | The only use of Test::MockModule is in that test, and a db_dependent test. |
| 06:05 | cait | we just inroduced mock I think |
| 06:08 | mtompset | Yes, but 3.8.5 tarball (and hence git) would fail a 'make test', because Test::MockModule and DBD::Mock aren't in the PerlDependencies.pm file. |
| 06:08 | I see a patch for it under bug 8806 | |
| 06:08 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8806 enhancement, P5 - low, ---, robin, Needs Signoff , Debian packaging updates |
| 06:09 | mtompset | and because they weren't in PerlDependencies.pm, I didn't make sure they were in the ubuntu .packages files. :) |
| 06:10 | Thankfully, the packages are right. :) | |
| 06:12 | eythian_ | mtompset: yeah, that bit me too (hence my patch) |
| 06:14 | cait | hi eythian |
| 06:14 | eythian_ | hello |
| 06:21 | mtompset | eythian_: That's why I also have bug 8784 -- not that I think anyone expressly uses debian.packages now, but I know my check_deps.sh script does when I decide to check if the file is missing anything based on PerlDependencies.pm |
| 06:21 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8784 minor, P5 - low, ---, mtompset, Needs Signoff , Missing files in debian.packages list |
| 06:22 | mtompset | My check_deps.sh script is similar to debian/list-deps |
| 06:22 | But it generates 3 files. .fix, .all, and .missing | |
| 06:22 | .fix needs to be added into the debian.packages (or ubuntu.packages) files. | |
| 06:23 | .all is everything. | |
| 06:23 | and .missing is what has no libraries which are apt-get'able. | |
| 06:23 | I do need to tweak the script though, because I chose the xpm over the non-xpm version of GD. | |
| 06:24 | I should have choosen the non-xpm version. | |
| 06:27 | I was noticing that the debian/control file doesn't list everything. | |
| 06:30 | eythian_ | what doesn't it list? |
| 06:30 | mtompset | I did a grep for lib... |
| 06:30 | there are 82 lines. | |
| 06:31 | comapre that against the debian.packages file in install_misc | |
| 06:31 | or the ubuntu.packages file | |
| 06:32 | I'm wondering if perhaps there are things which could be axed from those files. | |
| 06:33 | because it seems to me that the number of lines for the libs... should be the same as the number of items in PerlDependencies.pm | |
| 06:34 | (seeing as PerlDependencies.pm should be canonical, correct?) | |
| 06:35 | well grep "^ lib" and ": lib" | |
| 06:35 | for 82 lines. | |
| 06:35 | eythian_ | diff -w <(grep lib debian/control| sort|sed -e 's/,//') <(grep lib install_misc/debian.packages|sort |sed -e 's/install//') |
| 06:35 | that might give some clue | |
| 06:36 | it's not perfect, but maybe for eyeballing it | |
| 06:37 | (I'm not actually doing Koha stuff right at the moment, because it's Sunday, so aren't going to look too closely) | |
| 06:37 | mtompset | calling up a putty, which I can cut and paste to. :) |
| 06:38 | eythian_ | bbs, it's too loud right here, going somewhere quieter. |
| 06:39 | pastebot | "mtompset" at 127.0.0.1 pasted "Differences based on sorting and manual pruning." (85 lines) at http://paste.koha-community.org/202 |
| 06:43 | eythian_ joined #koha | |
| 06:43 | eythian_ | there we go, no yelling at the league in outside voices. |
| 06:46 | mtompset | http://paste.koha-community.org/202 |
| 06:46 | just in case you missed it. | |
| 06:46 | How is debian/control generated? | |
| 06:47 | eythian_ | debian/update-control.sh |
| 06:47 | or similar | |
| 06:48 | * cait | pokes eythian for ignoring her pm and runs off |
| 06:48 | eythian_ | cait: I didn't get it |
| 06:48 | I bet you sent it to me logged in from work, which isn't me at the moment | |
| 06:48 | cait | oh, you have an underscoretoday :) |
| 06:48 | libsysguy joined #koha | |
| 06:48 | cait | that is a little confusing :) |
| 06:48 | mtompset | Yes, he's trying to avoid work. It is Sunday. |
| 06:49 | eythian_ | it's not common, just that my laptop was still thinking it was in Yurp, and so auto-logged in. |
| 06:49 | mtompset | Ah, better explanation. :) |
| 07:12 | * magnuse | waves |
| 07:13 | eythian_ | So does the sea, magnuse. So does the sea. |
| 07:14 | magnuse | lol |
| 07:17 | * cait | waves at magnuse trying to make eythian sea sick |
| 07:17 | cait | :P |
| 07:19 | * magnuse | waves back |
| 07:19 | magnuse | ...and forth |
| 07:21 | * mtompset | waves his arms like kermit the frog introducing a guest start. ;) |
| 07:21 | cait | we are mean people |
| 07:22 | mtompset | eythian_: So, how does whatever processes the control file handle the lines with pipes? |
| 07:22 | eythian_ | they're an 'or' |
| 07:22 | beyond that, I'm not sure how apt picks. | |
| 07:22 | mtompset | libcgi-pm-perl | perl-modules, |
| 07:22 | libdigest-sha-perl | perl, | |
| 07:23 | libgd-gd2-noxpm-perl | libgd-gd2-perl, | |
| 07:23 | libtest-simple-perl | perl-modules, | |
| 07:23 | eythian_ | possibly those with the least dependencies if not already installed |
| 07:28 | mtompset | ${shlib:Depends}, ${misc:Depends} |
| 07:28 | where are those defined? | |
| 07:30 | Sorry... I should let you relax. | |
| 07:39 | eythian_ | they're not, they're apt/dpkg things I think |
| 07:48 | libsysguy joined #koha | |
| 07:51 | cait | hi libsysguy :) |
| 07:55 | mtompset | Hmmm... so they are, it seems. |
| 07:55 | Have a good day (24 hour period). | |
| 08:04 | magnuse | eythian_: Bug 8568 is an easy signoff, when you feel like it :-) |
| 08:04 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8568 enhancement, P5 - low, ---, magnus, Needs Signoff , Fix some errors in docs for scripts provided by the Debian packages |
| 08:54 | libsysguy joined #koha | |
| 09:54 | libsysguy joined #koha | |
| 10:50 | magnuse joined #koha | |
| 10:55 | libsysguy1 joined #koha | |
| 11:25 | cait left #koha | |
| 11:55 | libsysguy joined #koha | |
| 12:50 | cjh joined #koha | |
| 12:56 | libsysguy joined #koha | |
| 13:19 | cait-m joined #koha | |
| 13:19 | * cait-m | waves |
| 13:40 | libsysguy1 joined #koha | |
| 13:52 | gmcharlt | the wiki is back up |
| 14:07 | drojf joined #koha | |
| 14:07 | drojf | good day #koha |
| 14:17 | magnuse | gmcharlt++ |
| 14:23 | cait joined #koha | |
| 14:24 | * cait | waves |
| 14:24 | drojf | hi cait and magnuse |
| 14:25 | bornie21 joined #koha | |
| 14:27 | drojf | oh, found another koha library in berlin, cool |
| 14:33 | cait | drojf: hm? which one? |
| 14:33 | and hi magnuse | |
| 14:33 | if you are still here - hotel is booked too, I am all ready for the adventure of norway :) | |
| 14:34 | drojf | what are you doing in norway? i'm jealous |
| 14:37 | well, archive really | |
| 14:38 | cait | cool |
| 14:38 | make them add themselves to the wiki page? | |
| 14:39 | helping magnuse with a koha event :) | |
| 14:39 | and visiting | |
| 14:39 | drojf | cool, where? in bodø? |
| 14:40 | cait | oslo |
| 14:40 | drojf | nice :) |
| 14:42 | cait | I hope it will be :) |
| 15:02 | @wunder OSL | |
| 15:02 | huginn | cait: The current temperature in Holter S, Nannestad, Norway is 11.1°C (4:56 PM CEST on September 30, 2012). Conditions: Mostly Cloudy. Humidity: 71%. Dew Point: 6.0°C. Pressure: 29.77 in 1008 hPa (Rising). |
| 15:07 | tcohen joined #koha | |
| 15:34 | cait-m joined #koha | |
| 17:35 | SJeffery joined #koha | |
| 17:39 | SJeffery | Who is in charge of updating the website itself? |
| 17:39 | Would that be Nicole? | |
| 17:47 | jcamins_1way | SJeffery: a lot of people have access. Liz Rea is the administrator, though. |
| 17:49 | Is there an error you noted? | |
| 18:01 | bornie21 joined #koha | |
| 18:28 | rangi | Morning |
| 18:28 | wahanui | Morning is a state of mind. or whenever the cat wants breakfast. |
| 18:28 | rangi | Hehe I guess we will never know what's wrong with the website |
| 18:50 | cait joined #koha | |
| 19:23 | mtj | morning #koha |
| 19:24 | cait | good morning mtj :) |
| 19:26 | rangi | hi mtj and cait |
| 19:27 | cait | hi rangi |
| 19:33 | lamiette joined #koha | |
| 19:35 | rangi | hey lamiette |
| 19:37 | kathryn joined #koha | |
| 19:39 | cait | hi kathryn |
| 19:40 | :) | |
| 19:40 | kathryn | hi cait :) |
| 19:40 | cait | :) |
| 20:00 | wajasu joined #koha | |
| 20:14 | rangi | jcamins_1way: you about? |
| 20:15 | getting this error on master | |
| 20:15 | Can't locate object method "new" via package "C4::Linker::Default" (perhaps you forgot to load "C4::Linker::Default"?) at /home/chrisc/git/catalyst-koha/C4/Biblio.pm line 503. | |
| 20:15 | cait | hm |
| 20:16 | not sure, but there was a patch for the linkers I think | |
| 20:16 | hm | |
| 20:16 | but doesn't seem related | |
| 20:18 | wajasu | my db version is at 3.0900057 but my updatadatabase.pl , which has 3.09.00.044 showing a ccode being added, is not showing in mysql describe statistics table. |
| 20:19 | can someone with a recent master look to see if they have ccode on thier statistics table? i wonder why i don't. | |
| 20:23 | i was writing a a test to show if the DBIx schema is in sync with the Koha::Schema, and that was something it flagged. | |
| 20:23 | cait | this test will be awesome |
| 20:23 | I wanted that for a long time :) | |
| 20:30 | wajasu | we are going to need it because updatedatabase.pl is going to be the source of record for the schema for a long time and until there is a switch, the DBIx Koha::Schema with its ~140 tables, easily diverges. So now a signer/QA would be able to run the test to see. |
| 20:56 | just started with fresh DB. lets see. | |
| 21:02 | eythian | hello |
| 21:02 | wahanui | hi, eythian |
| 21:02 | cait | hi eythian |
| 21:04 | eythian | http://www.listener.co.nz/comm[…]ees-sitting-down/ <-- cait |
| 21:07 | cait | ah the comment is right |
| 21:07 | eythian | yeah, I figured |
| 21:08 | wajasu | ok. my DBIx Koha::Schema test for being synchronized with the DB is working. |
| 21:08 | cait | eythian: eichhörnchenschweif? :) |
| 21:09 | you probably already forgot :) | |
| 21:09 | eythian | I don't even remember seeing that one :) |
| 21:10 | cait | we made you say it I think |
| 21:10 | it's the tail of a squirrel | |
| 21:11 | eythian | ah right :) this rings a bell actually. |
| 21:11 | But I don't think I saw it written. | |
| 21:11 | that was part of your "make fun of the foreigner" day, right? ;) | |
| 21:14 | cait | hm |
| 21:14 | did we have a special day for that? | |
| 21:15 | I thought we spreat it out quite evenlty | |
| 21:16 | ignore the typos | |
| 21:17 | eythian | you are probably right. |
| 21:17 | cait | but be fair :) |
| 21:18 | you made fun of our attempts to pronouce english and maori words :) | |
| 21:18 | eythian | that's true :) it was a small price to pay then ;) |
| 21:18 | cait | heh |
| 21:19 | the last office is very empty now | |
| 21:19 | b. is gone, only m. now | |
| 21:21 | eythian | I should come back to help you keep up numbers. |
| 21:22 | cait | agreed :) |
| 21:22 | eythian | kathryn may complain though |
| 21:23 | cait | would she accept chocolate? |
| 21:23 | kathryn | hmmmmnnnn |
| 21:23 | cait | swiss chocolate |
| 21:23 | wahanui | i heard swiss chocolate was good - how close are you? :) cait is in Konstanz |
| 21:23 | eythian | haha |
| 21:24 | kathryn | stroopwafels maybe |
| 21:25 | however that's spelt | |
| 21:25 | eythian | that's not german |
| 21:25 | kathryn | I know! |
| 21:25 | see, you can't go | |
| 21:25 | eythian | rats, sorry cait. |
| 21:25 | kathryn | no stroopwafels in germany, no eythian |
| 21:25 | cait | lol |
| 21:26 | if google is right | |
| 21:26 | you can buy hem here | |
| 21:26 | honey or caramel | |
| 21:26 | ? | |
| 21:26 | eythian | can't bring honey here. |
| 21:26 | cait | oh right |
| 21:26 | so caramel then | |
| 21:26 | eythian | I have 2 caramel ones left. I should have brought more. |
| 21:27 | cait | I love those |
| 21:27 | kathryn | bags! |
| 21:27 | eythian | they're like a Dutch food group it turns out. |
| 21:27 | cait | hot cup of tee, waffle on top... wait a bit and hmmm |
| 21:27 | s/tee/tea | |
| 21:27 | s/hmm/mmmh | |
| 21:27 | kathryn | ergh in tea? gross |
| 21:27 | cait | not in tea |
| 21:27 | only let it warm up a bit by putting it on top of the cup :) | |
| 21:28 | kathryn | oh! :) |
| 21:34 | cait | try it :) eythian still has some ;) |
| 21:35 | and then send him back to get more :) | |
| 21:39 | jcamins_1way | rangi: there's a patch for that somewhere, but can't find it right now. |
| 21:39 | nengard reported the bug, I think. | |
| 21:39 | It was a PBP fix. | |
| 21:39 | rangi | cool as long as its known |
| 21:40 | ahh fix for that should be revert then | |
| 21:40 | we can't have style fixes breaking actual functionality | |
| 21:41 | * rangi | votes for more use of revert and/or shaming of people who break functionality doing style fixes :-) |
| 21:42 | rangi | also skipping of qa ... |
| 21:44 | drojf | nice to come here because of a bug and people are already talking about it :) |
| 21:46 | so back to bed | |
| 21:46 | rangi | heh |
| 21:49 | cait | good plan |
| 21:49 | good nigh all | |
| 21:49 | rangi | night cait |
| 21:49 | eythian | bye cait |
| 22:18 | mtj | jcamins_1way, rangi bug 8818 is nicole's PHP bug report |
| 22:18 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8818 critical, P5 - low, ---, gmcharlt, Signed Off , Authority linker error on Z cataloging |
| 22:21 | mtj | i'm still curious about why my change is a no-op, and what a perlcritic happy fix is |
| 22:23 | rangi | that patch is perlcritic happy fix |
| 22:25 | the other fix, a better one | |
| 22:25 | than changing it | |
| 22:25 | is to get the perlcriticrc from koha | |
| 22:26 | http://git.koha-community.org/[…]b1f45e75a5fcf426f | |
| 22:26 | see lines 4 and 5 | |
| 22:26 | that allows us to do eval { require $variable } | |
| 22:27 | while still failing any other stringy ones | |
| 22:28 | tcohen joined #koha | |
| 22:28 | rangi | http://search.cpan.org/dist/Pe[…].pm#CONFIGURATION |
| 22:30 | so you see why its a no op eh? | |
| 22:30 | The string form of eval is recompiled every time it is executed, whereas the block form is only compiled once. | |
| 22:31 | when its compiled, the value of $linker_module is default | |
| 22:32 | my $linker_module = "C4::Linker::" . ( C4::Context->preference("LinkerModule") || 'Default' ); | |
| 22:32 | when its run, it looks up the value in the db | |
| 22:32 | but we just use the old one | |
| 22:33 | wajasu | looked at the perlcriticrc. that explains why when i put Modern::Perl instead of the use strict;use warnings; i got unhappy perlcritic |
| 22:33 | rangi | thats why "require $linker_module" is different to { require $linker_module } |
| 22:33 | wajasu | isn't that syspref empty/blank which means default? |
| 22:33 | mtj | aaaaa, got it! :) |
| 22:34 | rangi | wajasu: doesn't matter if its blank or not, it will always be default now |
| 22:34 | wajasu | ok |
| 22:34 | rangi | thats why the perlcritic fix was wrong |
| 22:34 | mtj | yeah, my other mistake when doing those perlcritic patches - was to not use koha's ./t/perlcritic.rc file, too :/ |
| 22:35 | my ~/perlcritic.rc file was missing the [Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval] line :/ | |
| 22:36 | wajasu | i wrote a DBIx Koha::Schema test which checks if all the Koha::Schema has existinging columns and relations (about 4000 tests). :) |
| 22:36 | mtj | so… a bit of a cock-up, but a learning experience none the less… :) |
| 22:38 | wajasu | so now i see some new tables (borrower_files, closure, etc) that are part of bug 8798 patch that libsysguy has worked on. |
| 22:38 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8798 enhancement, P5 - low, ---, elliott, Signed Off , Add the use of DBIx::Class |
| 22:39 | wajasu | already gst is now gstrate. |
| 22:40 | also, in Context.pm i am going to add folowup so that the mysql connect connects the same as the current one (i.e. with utf8 enabled, and the SET NAMES, and timezone). | |
| 22:40 | but for the Koha::Schema. | |
| 22:46 | mtj: revisting the koha_perl_deps.pl initially there is -m missing, -u update required, so to get the functionality you suggested for generating a cpanfile, i believe you would want -n needed (those from the -m and -u sets) so that you can generate a cpanfile for just what is needed, right? | |
| 22:48 | eythian | @wunder wellington |
| 22:48 | huginn | eythian: Error: No such location could be found. |
| 22:48 | eythian | @wunder wellington, nz |
| 22:48 | huginn | eythian: The current temperature in Wellington, New Zealand is 16.0°C (11:00 AM NZDT on October 01, 2012). Conditions: Partly Cloudy. Humidity: 55%. Dew Point: 7.0°C. Pressure: 29.62 in 1003 hPa (Steady). |
| 22:48 | eythian | oh, doesn't say the wind :( |
| 22:50 | mtj | wajasu, yes but….. carton already does this task too |
| 22:50 | wajasu | right. thats why i really only needed -a -g |
| 22:51 | mtj | well, carton already builds a cpanfile, from the PerlDep.pm file |
| 22:53 | wajasu | how does it do that? |
| 22:53 | from C4/Installer/PerlDependencies.pm? | |
| 22:54 | mtj | yep, calling it , via Make.PL |
| 22:54 | wajasu, the script i really want shows all installed perl module versions, after a 'apt-get -i koha-common' | |
| 22:55 | wajasu | doesn't -i do that? |
| 22:55 | koha_perl_deps.pl -i ? | |
| 22:56 | mtj | aah yep :) all good :p |
| 22:57 | wajasu | where is Make.PL? |
| 22:58 | mtj | makefile.PL |
| 22:58 | wajasu | vi Makefile.PL |
| 22:59 | what target writes the cpanfile? | |
| 23:00 | mtj | sorry? |
| 23:01 | wajasu | did you say that after one runs perl Makefile.PL that there is a cpanfile generated? |
| 23:02 | mtj | no |
| 23:03 | wajasu | so i just wanted to know if its still worth me adding a the option (-g) so that we can get a cpanfile that carton can use. |
| 23:03 | mtj | 'carton install' generates a cpanfile/carton.lock file , after executing Makefile.PL |
| 23:04 | … makefile.pl tells carton what perl modules and versions are needed | |
| 23:04 | … by calling PerlDeps.pm | |
| 23:05 | wajasu | oh. i thought we would have to add Module::Install at the top. But i guess its smart enough. |
| 23:05 | mtj | wajasu, theres some info in bug 8807 |
| 23:05 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8807 normal, P5 - low, ---, gmcharlt, NEW , add Carton support to Koha |
| 23:06 | mtj | its got a 1.2 meg carton.lock file attachment , built using 'carton install' |
| 23:06 | wajasu | now i understand why the carton check fails without the carton.lock now |
| 23:07 | mtj | so, i think a worthy test here is… install a fresh koha-common, on a fresh debian |
| 23:08 | … then run koha-deps.pl - the 'installed' and 'required' cols should be identical | |
| 23:09 | if there is a mismatch between the 'installed' and 'req' ver numbers - its a bug, somewhere... | |
| 23:10 | does that make some sense to anyone ? | |
| 23:13 | wajasu | fresh-debian + latest koha-common I'll give that a try next time i build one. |
| 23:14 | mtj | yep, me too :) |
| 23:16 | wajasu | did you add what needs to be added to .gitignore? |
| 23:18 | mtj | yep |
| 23:19 | i must confess 'carton install' currently barfs on the non-cpan graphicsmagick stuff :/ | |
| 23:19 | wajasu | yea. for me as well. |
| 23:19 | mtj | … but thats another patch, for another issue |
| 23:20 | wajasu | so is that patch "needing signoff" ? |
| 23:21 | libsysguy joined #koha | |
| 23:21 | libsysguy | afternoon everyone |
| 23:22 | mtj | wajasu, pass - but there are yet-to-be logged BLOCKER bugs, stopping it from being commited |
| 23:22 | wajasu | hello |
| 23:22 | ok | |
| 23:22 | mtj | … like the GM failing issue |
| 23:24 | yeah, no hury on that one - its just the start of a long discussion about how to do CPAN stuff better | |
| 23:24 | wajasu | ahh. i was having success with PERL5LIB=./local/lib/perl5:/home/koha/kohaclone in my dev install. |
| 23:26 | i like being able to add Perl::Critic, Devel::Cover, Devel::TraceUse Regexp::Debugger etc to my environment just by adding to my cpanfile. then carton install | |
| 23:27 | i want a t/cpanfile for dev/test related things. | |
| 23:28 | but i can keep my own. | |
| 23:29 | libsysguy: i wrote a test to compare the Koha:Schema with the mysql DB schema. it complained about borrower_files, and closure and closure_rrule | |
| 23:30 | is that stuff you are working on? | |
| 23:30 | libsysguy | I'm not working on borrower files |
| 23:30 | but I am working on closure and closure_rrule | |
| 23:31 | so it makes sense that it would have complained with those | |
| 23:31 | wajasu | after a fresh mysql and updatedatabase, i don't have borrower_files in my DB, and the Koha::Schema must have borrower_files. |
| 23:32 | libsysguy | im sure its something that slipped in from my db |
| 23:32 | I was on master | |
| 23:32 | but perhaps an update failed to remove it | |
| 23:33 | wajasu | its going to be a pain to keep up with what was different in the patch and what changes daily. even gst is now gstrate in one table. |
| 23:33 | libsysguy | I think its probably an issue we should address when we want to use deployment handler |
| 23:34 | it will be up to the RM to keep those files up to date with the regen script until we decide it save to load it from kohastructure.sql | |
| 23:34 | or start managing it with versioning | |
| 23:34 | wajasu | i might just add this koha schema sync test as a patch to help. |
| 23:35 | libsysguy | just add it as a dependency on the first one |
| 23:35 | wajasu | ok. |
| 23:35 | libsysguy | mtj aren't you the one that failed it the first time for tabs |
| 23:36 | mtj | yep, prolly |
| 23:37 | libsysguy | heh |
| 23:37 | sorry | |
| 23:37 | feel free to check it again ;) | |
| 23:37 | mtj | libsysguy, i failed some patch from you recently…. |
| 23:37 | libsysguy | that was it |
| 23:37 | emacs likes the tabs | |
| 23:37 | wajasu | libsysguy: i also was working on a followup patch to do the same connect behavior as we do for the dbh. mysql_enable_utf8=>1, SET NAMES, and SET TIMEZONE etc. at connect time. |
| 23:38 | libsysguy | im not sure we should be setting the timezone |
| 23:38 | wajasu | libsysguy: i signedoff on the tabs. ran perlcritic on it. |
| 23:38 | libsysguy | tabs? |
| 23:38 | wahanui | tabs are different |
| 23:38 | libsysguy | I have some updates for that bug when it gets pushed |
| 23:38 | wajasu | the tabs patch that someone failed. |
| 23:38 | libsysguy | hmm |
| 23:39 | wajasu | i still wonder if we should be loading the DateTime component across the board for the whole schema. if it make coding durations and such easier. |
| 23:40 | libsysguy | that is what I did |
| 23:40 | wajasu | cool. |
| 23:40 | libsysguy | later |
| 23:40 | I haven't pushed it yet | |
| 23:40 | I've been wrapped up with other stuff | |
| 23:40 | I really just need to PM paul or wait on jcamins to get their thoughts | |
| 23:44 | mtj | yeah, DBIx a big deal, that prolly needs to be discussed on koha-devel first... |
| 23:45 | afaik, most of the long-time devs are keen for DBIx | |
| 23:47 | eythian | I think so yeah, ideally it would go in to master just after a release to have plenty of time to shake out. |
| 23:48 | mtj | yeah, thats the one eythian :) |
| 23:48 | wajasu | i'm trying to see if i can use the DBIx in writing tests, to shake it out and get tests written to ensure test coverage. |
| 23:49 | mtj | and im personally unsure why DBIx might be a better ORM for Koha, than Rose:DB |
| 23:50 | … so i wont comment :) | |
| 23:51 | wajasu | i wish you could just create a new Koha API that the controllers code against, so that if later you could migrate the persistence layer to other ones. as long as tests exists it would be doable. |
| 23:52 | eythian | every problem can be solved by adding another layer of abstraction :) |
| 23:53 | wajasu | :) |
| 23:55 | well if someone wants to code to the api, and put a "remoting" (via plack or such), the persistence tier could be a long running process, with reusable db connections. | |
| 23:58 | eythian | "well I'm not doing anything more interesting in 2013" :) |
← Previous day | Today | Next day → | Search | Index