← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:08 | melia left #koha | |
| 00:11 | Judit joined #koha | |
| 00:11 | Judit | monrning |
| 00:17 | Judit1 joined #koha | |
| 00:26 | Judit joined #koha | |
| 00:30 | Judit1 joined #koha | |
| 01:01 | Judit joined #koha | |
| 01:01 | Irma joined #koha | |
| 02:00 | ala_3vo joined #koha | |
| 02:02 | ala_3vo | Hello #koha |
| 02:03 | After installing koha-common, mysql and koha-create, I encountered an error message | |
| 02:03 | Syntax error on line 69 of /etc/koha/apache-shared.conf: | |
| 02:03 | Invalid command 'RewriteEngine', perhaps misspelled or defined by a | |
| 02:03 | module not included in the server configuration | |
| 02:04 | Action 'configtest' failed. | |
| 02:04 | The Apache error log may have more information. | |
| 02:18 | libsysguy | ala_3vo you may need to enable mod_rewrite |
| 02:19 | $ a2enmod rewrite | |
| 02:24 | ala_3vo | libsysguy: thanks that worked |
| 02:24 | libsysguy | sweet, good luck |
| 02:31 | ala_3vo | if I koha-create --create-db instancename another, I still have that same error. |
| 02:31 | why is that? | |
| 02:34 | libsysguy | I'm not sure ala_3vo |
| 03:23 | janPasi joined #koha | |
| 03:51 | bartsimpson joined #koha | |
| 04:08 | cait joined #koha | |
| 05:14 | cait | hi #koha |
| 05:19 | Judit1 joined #koha | |
| 05:22 | * mtj | waves to cait |
| 05:27 | BobB joined #koha | |
| 05:31 | cait | hi mtj :) |
| 06:24 | mtj | woahh - jcamins' c4::search test looks impressive |
| 06:26 | i cant remember seeing a patch thats too big for bugzilla, ever? | |
| 06:26 | kf joined #koha | |
| 06:27 | Judit1 left #koha | |
| 06:27 | mtj | jcamins++ |
| 06:31 | kf | hi mtj |
| 06:32 | jcamins++ :) | |
| 06:34 | ala_3vo joined #koha | |
| 06:35 | mtj | -> https://github.com/jcamins/koha/tree/search_t |
| 06:35 | ... twas the test, i was talking about | |
| 06:36 | julian_m joined #koha | |
| 06:40 | julian_m | hello |
| 06:40 | wahanui | niihau, julian_m |
| 06:51 | francharb joined #koha | |
| 06:52 | francharb | Good morning |
| 06:56 | kf | hi francharb |
| 06:57 | drojf | hi #koha |
| 06:57 | kf | hi #koha |
| 06:58 | drojf | moin kf |
| 07:02 | hdl joined #koha | |
| 07:04 | drojf | uk-- |
| 07:09 | francharb joined #koha | |
| 07:19 | hdl joined #koha | |
| 07:23 | ala_3vo | Hello #koha |
| 07:25 | After installation of koha-common, and mysql successfully there was a syntax error when I run koha-create | |
| 07:26 | cat: /etc/koha/passwd: No such file or directory | |
| 07:26 | Koha instance is empty, no staff user created. | |
| 07:26 | wahanui | i already had it that way, ala_3vo. |
| 07:27 | ala_3vo | okay, what was the problem wahanui? |
| 07:27 | eythian joined #koha | |
| 07:28 | ala_3vo | I have tried about 3 times on test environment and it came out the same |
| 07:30 | but when I upgrade from previous version it was okay... | |
| 08:01 | rangi | n/names |
| 08:39 | WaqarAzeem joined #koha | |
| 08:43 | ala_3vo joined #koha | |
| 08:56 | WaqarAzeem | Hello! how can i find... the version of Koha running on my server? |
| 08:57 | eythian | WaqarAzeem: you can go to the 'About' page in the staff client |
| 08:58 | WaqarAzeem | thanks |
| 09:00 | koyauni joined #koha | |
| 09:01 | koyauni | hi guys, anyone good with Debian dedicated servers |
| 09:01 | eythian | koyauni: it depends, what's your question? |
| 09:02 | koyauni | I got this unmanaged server with hetzner.de and I can not run php pages, |
| 09:03 | I say this sort of thing are so basic that a server should do these thing out of box but they say this is it take it or leave it :( | |
| 09:03 | here is a sample page | |
| 09:03 | http://xuwarin.org/phpinfo.php | |
| 09:03 | it is Debian 6, with Apache 2, Php 5.x | |
| 09:04 | and I have gone though hell putting koha on it I do not want to juet leave it | |
| 09:04 | eythian | "More information about this error may be available in the server error log." <-- what does that information tell you? |
| 09:05 | koyauni | in /var/log/apache/ |
| 09:05 | last line says | |
| 09:05 | [Thu Aug 16 10:42:25 2012] [notice] Apache/2.2.16 (Debian) DAV/2 mod_fcgid/2.3.6 mod_python/3.3.1 Python/2.6.6 mod_ssl/2.2.16 OpenSSL/0.9.8o mod_perl/2.0.4 Perl/v5.10.1 configured -- resuming normal operations | |
| 09:06 | eythian | that's not the important line. The one with the error is the one you need to be looking at. |
| 09:06 | koyauni | I do not see PHP resumin after restart |
| 09:06 | eythian | I don't really know much about PHP |
| 09:06 | koyauni | that is in the error.log |
| 09:06 | eythian | Yes, but it's not an error. |
| 09:07 | It's a notice. | |
| 09:07 | koyauni | I see this line as well |
| 09:07 | [Thu Aug 16 10:42:25 2012] [error] python_init: Python path being used '/usr/lib/python2.6/:/usr/lib/python2.6/plat-linux2:/usr/lib/python2.6/lib-tk:/usr/lib/python2.6/lib-old:/usr/lib/python2.6/lib-dynload'. | |
| 09:08 | eythian | you should try the request again and see what gets added to the logs |
| 09:08 | all these look like startup information. | |
| 09:08 | also, if this is a koha server, why do you have php and such installed on it anyway? | |
| 09:08 | koyauni | where is this log file |
| 09:09 | may be I look in the wrong log | |
| 09:09 | eythian | I don't know |
| 09:09 | somewhere in /var/log/apache2 most likely | |
| 09:09 | do the request and see what files change | |
| 09:09 | koyauni | I have my page for uni with information about the library |
| 09:10 | how do you make sure in SSH command that php is runing | |
| 09:10 | I an in there and I am looking at error.log | |
| 09:10 | eythian | I don't know, I don't use PHP much, and when I have had to, it just works. |
| 09:11 | koyauni | me too, I have never seen something like this |
| 09:11 | eythian | and is error.log the one that changes when you do the request that causes the error. |
| 09:11 | koyauni | and this bloody server admin say this it we do not give support :( |
| 09:11 | eythian | Well, that's what an "unmanaged" server means. |
| 09:13 | koyauni | this is odd, nothing is add to, when I reload or reaccess the page |
| 09:14 | that you have to manage it yourself after purchase | |
| 09:15 | but I just got this, it is like buying a TV and take it home, and it does not switch on | |
| 09:15 | eythian | are you sure you're hitting the right server, or looking in the right place for your log files? I'd have a look through your apache configuration and see if it's logging somewhere else. |
| 09:15 | koyauni | so they keep telling you that is find out why |
| 09:15 | :( | |
| 09:16 | these are two domains two domains I have activated on that server for now, xuwarin.org and kurdistanica.com | |
| 09:16 | I can see html pages | |
| 09:16 | but no script pages | |
| 09:17 | mtj | koyauni, you have a php problem - not a koha problem |
| 09:17 | koyauni | I am in the root of the server |
| 09:17 | eythian | Well, if nothing is being logged at all, then you are either looking in the wrong place for your log files, or you're accessing the wrong server (or something more unusual, but those are the common situations.) |
| 09:18 | koyauni | I have koha at library.koyauniversity.org and it is installed, do not know if it is working yet |
| 09:18 | mtj | (there are not many php experts in this #irc channel) |
| 09:18 | koyauni | I need to get the server right before I point to it |
| 09:19 | I do not think this is PHP problem rather Debian server issue to run any script | |
| 09:19 | eythian | if you can't see the logs, you need to find out what's going on. To do that you need to look through your configuration. Things are pretty much always logged. |
| 09:22 | mtj | koyauni, well.... whatever your problem is... its not a koha problem, yes? |
| 09:24 | do you have php installed, even? | |
| 09:25 | ... via your systems parallels-panel admin-gui? | |
| 09:25 | rangi | http://xuwarin.org/ <-- what page do you see here? I see something about parallels |
| 09:26 | mtj | rangi, yep, me too |
| 09:26 | koyauni | that is normal HTML page server defualt |
| 09:26 | rangi | thats not debian |
| 09:27 | koyauni | I checked yes, php5 is on Debian |
| 09:27 | eythian | yeah, that is not the normal server default for debian at all. |
| 09:27 | I think you are accessing the wrong server. | |
| 09:28 | koyauni | no this is Debian 6 dedicated server with Plesk that is Plesk default page |
| 09:28 | mtj | also, http://library.koyauniversity.org shows parellels page, not koha |
| 09:28 | koyauni, no not plesk - parellels | |
| 09:28 | eythian | then maybe you need to be looking into your plesk configuration. |
| 09:29 | mtj | ahh, parellels == plesk, sorry... |
| 09:30 | koyauni | I found the bloody things |
| 09:30 | mtj | koyauni, so your plesk did not install php properly |
| 09:31 | koyauni | they have a setting with run PHP as FastCGI thing |
| 09:31 | I changed that to Apache mode and it worked | |
| 09:31 | mtj | yes, you dont have fast-cgi installed... |
| 09:31 | -> http://xuwarin.org/test/fcgi/test.html | |
| 09:31 | koyauni | sorry guys to take you time |
| 09:32 | http://www.names.co.uk/support[…]ted_on_plesk.html | |
| 09:32 | that page saved me, | |
| 09:33 | so they have set up my server and put Plesk on Fastcgi without having FastCGI | |
| 09:34 | do I even need this | |
| 09:34 | http://davejamesmiller.com/blo[…]ebian-6-0-squeeze | |
| 09:35 | eythian | Not for koha you don't |
| 09:35 | beyond that, I don't know | |
| 09:36 | mtj | koyauni, koha uses perl, not php |
| 09:38 | dear #koha, is anyone using a snazzy carousel thingy on their opac? | |
| 09:39 | koyauni | I have installed that, I want to make sure that the server is working for all my projects before I point my domain to this new NS |
| 09:39 | mtj | ... a book carousel, that is |
| 09:42 | * mtj | sends the biblibre folk an email re: carousel |
| 09:58 | mtj | ... but i would like to see some other examples, for improvements & ideas |
| 10:02 | eythian | When you click left, it moves to the right which is confusing initially |
| 10:02 | also should be mouse draggable :) | |
| 10:06 | mtj | yeah, i agree re: left/right |
| 10:07 | ... mouse stuff in version 2 :) | |
| 10:09 | this carousel is quite nice too -> http://www.jacksasylum.eu/Cont[…]Flow/download.php | |
| 10:44 | drojf joined #koha | |
| 11:00 | francharb | mtj, I emailed you back on the carousel thing! ;) |
| 11:00 | francharb_lunch | now, time for lunch! |
| 11:06 | mib_pzwneg joined #koha | |
| 11:07 | mib_pzwneg | Has anyone noticed LDAP auth seems to stop when upgraded from 3.6.x to 3.8? Or is there a subtle change in the config I am missing!? |
| 11:08 | nengard joined #koha | |
| 11:11 | jcamins | mib_pzwneg: I don't really know anything about LDAP, but did you look at the blog post on ByWater's blog about configuring LDAP? |
| 11:13 | mib_pzwneg | jcamins: No, I will take a look. I had it configured fine on 3.6 though, so I thought if there was some substantial changes it would have been in the release notes for 3.8 and there is nothing. |
| 11:14 | jcamins | I am not aware of any changes, but I use 3.6, and don't use LDAP. |
| 11:15 | Hm. There don't appear to be any further changes to the LDAP code. | |
| 11:16 | jwagner joined #koha | |
| 11:17 | eythian | I've done a 3.4 to 3.8 upgrade, and LDAP didn't break. |
| 11:17 | mib_pzwneg | Thanks jcamins. The blog doesn't offer me anything I didn't know - If I switch on debug in the Net::LDAP class I can see the binding correctly, and even the user's (trying to login) attributes get logged fine, just fails to login to Koha! |
| 11:18 | jcamins | What version of 3.8? |
| 11:19 | mib_pzwneg | I just pulled the latest stable from koha-community - one second I will get the exact version |
| 11:20 | 3.08.03 | |
| 11:20 | jcamins | Okay, that's a good version to be using. |
| 11:20 | eythian: how's Konstanz? | |
| 11:20 | eythian | It's good. Today is getting better now that the rain stopped, too. |
| 11:23 | mtj | heya francharb_lunch , thanks for the reply |
| 11:23 | my carousel is using -> http://www.professorcloud.com/[…]site/carousel.htm | |
| 11:24 | (which is the same as koha.mediathequeouestprovence.fr, afaik) | |
| 11:25 | nengard joined #koha | |
| 11:43 | clrh | dear develppers, in wich debian version do you program ? |
| 11:43 | wheezy ? | |
| 11:43 | wahanui | hmmm... wheezy is testing |
| 11:43 | mtj | ... ldap problem looked like a problem worthy of a bug report :/ |
| 11:43 | clrh | squeeze? |
| 11:43 | wahanui | squeeze is 3.2.x |
| 11:43 | clrh | squeeze is 6.0 |
| 11:44 | mtj | clrh - the stable version of debian :) |
| 11:44 | ... always | |
| 11:48 | eythian | clrh: mostly squeeze, but I tend to build against unstable so I have advanced warning of things changing. |
| 11:48 | no wahanui, squeeze is 6.0 | |
| 11:48 | wahanui | okay, eythian. |
| 11:49 | clrh | ok eythian thanks |
| 11:49 | I hope your last too wekks at Marseille were cool too :) | |
| 11:49 | I didn't tell you goodbye! | |
| 11:50 | eythian | Yeah, it was good :) |
| 11:50 | No, I think I you got back the work day after I finished. | |
| 11:50 | jcamins | I use Squeeze. |
| 11:56 | mtj | but, its great to know people like eythian++ are testing koha on debian-testing, for the rest of us :) |
| 12:02 | woah, awesome icons -> http://fortawesome.github.com/[…]Awesome/#examples | |
| 12:03 | yes please :) | |
| 12:03 | nengard joined #koha | |
| 12:04 | mtj | hmm, is the (CC BY 3.0) license compatible with koha's license? |
| 12:04 | 'The Font Awesome webfont, CSS, and LESS files are licensed under CC BY 3.0' | |
| 12:05 | http://creativecommons.org/licenses/by/3.0/ | |
| 12:07 | jcamins | CCSA2.5 is. |
| 12:07 | CC BY 2.5, rather. | |
| 12:15 | francharb | mtj, you're welcome! ;) |
| 12:23 | mtj | jcamins, aah ok - sounds like we need to bump Koha to gpl3+ to use those fonts/icons... |
| 12:25 | ftw, ive recently discovered some very interesting svg/vector icons too -> http://raphaeljs.com/icons | |
| 12:26 | ... first ive ever seen, i think? (mit license too :) ) | |
| 12:29 | drojf | ecuador++ |
| 12:40 | mbalmer joined #koha | |
| 12:47 | chris_n` joined #koha | |
| 12:49 | Callender joined #koha | |
| 12:50 | tcohen joined #koha | |
| 12:57 | ago43 joined #koha | |
| 13:03 | Callender joined #koha | |
| 13:08 | talljoy joined #koha | |
| 13:18 | maximep joined #koha | |
| 13:19 | oleonard joined #koha | |
| 13:24 | libsysguy joined #koha | |
| 13:25 | oleonard | Hi #koha |
| 13:34 | mtj | hiya oleonard |
| 13:36 | druthb joined #koha | |
| 13:39 | datadoctor joined #koha | |
| 13:39 | datadoctor joined #koha | |
| 13:41 | datadoctor | I'm looking at the Tools > Notices editor - looks like it is much easier to edit the quick slip and print slip. |
| 13:43 | You can add your branch information, biblio and biblioitem information (like MARC info), borrower, news and issue information to the quick slip, print slip, etc. | |
| 13:47 | I am wondering how easy it would be to add renewal information and item replacement price, as they are not in the list. Are we limited to the values that appear in the list? | |
| 13:48 | Tools > Notices > Edit Quickslip (Modify Notice) | |
| 13:52 | mtj | you might need to modify the sql to pull that info from other tables ( like 'reserves' table ) |
| 13:53 | datadoctor | Thanks. I will check that. Reserves might give me current holds. |
| 13:53 | mtj | rep-price should be currently available, not sure about renewal info |
| 13:54 | datadoctor | Price looks easier. We currently total the replacement prices on our quickslip, and inform the patron about how much they have saved by using the library. |
| 13:54 | Hoping to implement that on 3.8 as well. | |
| 13:56 | For renewals, we can compare date issued with current date, and cross-check with remaining renewals. I think that will isolate today's renewals. | |
| 13:57 | If I can't deliver it through the Notices editor for the quickslip, I can probably pull the information from mysql and deliver it through the template. | |
| 13:57 | I'm thinking that's moremember-receipt.tt or printslip.tt... | |
| 13:58 | Although a lot of the information comes from Members.pm. | |
| 14:09 | pastebot | "nengard" at 127.0.0.1 pasted "looking for report help - is this possible? how would I get just the numbers from the isbn field?" (4 lines) at http://paste.koha-community.org/111 |
| 14:21 | eythian | http://dev.mysql.com/doc/refma[…]ng-functions.html <-- nengard, there may be something here that helps |
| 14:22 | (sorry, that answer is a bit RTFM-y, but it's all I got right now :) | |
| 14:22 | nengard | I love the mysql manual :) |
| 14:22 | and did look there, but I think this needs regex and no manual will ever help me understand that :) hehe | |
| 14:24 | eythian | oh, I understand regexes. If you just want the part up-to the space: s/^([^ ]*) .*$/$1/ |
| 14:24 | oleonard | Hey, watch your language! |
| 14:26 | eythian | I don't think mysql regexes can do this |
| 14:27 | they seem to be for truthiness of matching, or used as LIKE | |
| 14:27 | datadoctor | We are using regex to parse the last renewed date and the current date for comparison, converting to a date in the format: 20120816 |
| 14:27 | eythian | datadoctor: in SQL? |
| 14:27 | datadoctor | In PERL |
| 14:27 | Sorry, mixing my metaphors | |
| 14:27 | eythian | Yeah, this case needs SQL. |
| 14:28 | nengard: I think SUBSTRING_INDEX may be helpful | |
| 14:29 | nengard | okay i'll take a look |
| 14:29 | eythian | it'll let you grab everything before the space, anyway. |
| 14:30 | as for applying the dates, I'm not sure. Probably group by the sanitised ISBN and take the max of the dates. Then test that. | |
| 14:30 | That might just work. | |
| 14:30 | nengard | thanks! I'll see what I cam come up with - the dates part I can do |
| 14:30 | she wants the date added | |
| 14:30 | that's another field | |
| 14:32 | eythian | yeah, so something like select [fix up isbn] as isbn, count(*) as count, max(date_added) as max_date where max_date > <<limit>> group by isbn; |
| 14:32 | with the appropriate from and joins and stuff | |
| 14:32 | Not sure that'll work, but it might. | |
| 14:33 | datadoctor | Would SELECT SUBSTRING be useful? |
| 14:33 | for trimming the suffix out | |
| 14:33 | Oh, I see that's covered by the SUBSTRING INDEX | |
| 14:37 | pastebot | "nengard" at 127.0.0.1 pasted "resulting report" (5 lines) at http://paste.koha-community.org/112 |
| 14:37 | nengard | eythian, okay so this worked ? but you're right - adding the date is hard |
| 14:37 | where does WHERE go when there is a HAVING | |
| 14:38 | something like WHERE b.datecreated between '2011-01-01' and '2012-01-10' | |
| 14:39 | gbk77 joined #koha | |
| 14:40 | eythian | hmm, I don't know, I've not used HAVING |
| 14:40 | nengard | sekjal taught me about HAVING |
| 14:40 | gmcharlt | nengard: SELECT ... GROUP BY ... HAVING |
| 14:41 | nengard | and can i put WHERE in there? |
| 14:41 | gmcharlt | the where clause is optional, but if you need it... |
| 14:41 | SELECT ... FROM ... WHERE ... GROUP BY ... HAVING | |
| 14:41 | nengard | oh! |
| 14:41 | okay | |
| 14:41 | eythian | that makes some sense |
| 14:42 | wajasu | at mysql prompt> help select; for reference |
| 14:42 | pastebot | "nengard" at 127.0.0.1 pasted "final report! Thank you all!! it's going on the wiki" (6 lines) at http://paste.koha-community.org/113 |
| 14:43 | eythian | awesome :) |
| 14:44 | nengard | eythian++ |
| 14:44 | gmcharlt++ | |
| 14:44 | :) | |
| 14:45 | wajasu | jcamins_away: i think i got you remote search_t search unit test setup in a local branch. what would you like me to run to test. all tests? how? |
| 14:46 | mveron joined #koha | |
| 14:47 | gmcharlt | nengard++ |
| 14:48 | mveron | Hi #koha |
| 14:59 | datadoctor | g'day! |
| 15:05 | eythian | http://pastebin.ubuntu.com/1150789/ |
| 15:07 | datadoctor | :D |
| 15:10 | hdl1 joined #koha | |
| 15:12 | wajasu | if i want to run a single unit test, does anyone know how i would do that? |
| 15:14 | gmcharlt | wahanui: prove t/Foo.t |
| 15:14 | wahanui | gmcharlt: i'm not following you... |
| 15:14 | gmcharlt | er, |
| 15:14 | wajasu: prove t/Foo.t | |
| 15:15 | ;) | |
| 15:15 | wajasu | here goes. |
| 15:15 | do i have to run perl Makefile first? | |
| 15:16 | gmcharlt | generally speaking, no |
| 15:17 | wajasu | trying prove t/db_dependent/Search.t ... |
| 15:19 | gmcharlt | wajasu: db_dependent tests require a little more setup |
| 15:19 | in particular, KOHA_CONF would have to be set, pointing to a database with the sample data loaded | |
| 15:19 | and some of the non-DB-dependent tests may want to point to the stock koha-conf.xml template, e.g. | |
| 15:20 | wajasu | i'm trying to test bug 8649 |
| 15:20 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Needs Signoff , C4::Search needs a unit test |
| 15:20 | gmcharlt | but just to suppress the "unable to locate Koha configuration file" warning |
| 15:28 | wajasu | it ran will some failures, i'll fool with it a bit and wait until jcamins shows up |
| 15:40 | maximep | wow, I guess I really did bug 8645 without thinking about it |
| 15:40 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8645 normal, P5 - low, ---, pelletiermaxime, ASSIGNED , Fix background-job-progressbar.js for translations |
| 15:41 | maximep | in 3.6 it was in an .inc file, so it was translatable |
| 15:41 | it was moved in a js which isnt | |
| 15:41 | and I just copied the code -_- | |
| 15:41 | jcamins | Someone looking for me? |
| 15:41 | Ah, wajasu. | |
| 15:41 | wajasu++ | |
| 15:41 | Actually, t/db_dependent/Search.t does not require a working database. | |
| 15:41 | It just requires MySQL. | |
| 15:42 | wajasu: what failed? | |
| 15:49 | pastebot | "wajasu" at 127.0.0.1 pasted "bug 8649 Search.t test" (203 lines) at http://paste.koha-community.org/114 |
| 15:49 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Needs Signoff , C4::Search needs a unit test |
| 15:49 | jcamins | Ahh... everything. |
| 15:50 | francharb | see you! |
| 15:50 | jcamins | Okay, it looks like it's searching your Zebra server and not the test's. |
| 15:51 | wajasu | jcamins: the first time i ran it i had less tests, then i only installed DBD::Mock and you see those results in paste |
| 15:51 | jcamins | Do you have Test::MockModule? |
| 15:52 | Could you paste the output of perl t/db_dependent/Search.t? | |
| 15:52 | wajasu | yes. koha_perl_deps reports 0.05 |
| 15:53 | ok i'll do that | |
| 15:53 | jcamins | I suspect I probably missed a file or two. |
| 15:53 | I shall delete my data directory and check it out again. | |
| 15:54 | No, it's not that. All the files exist. | |
| 15:54 | wajasu | you saw my git commands. do i need to do a git pull or fetch/merge? |
| 15:54 | jcamins | No, that looked right to me. |
| 15:57 | pastebot | "wajasu" at 127.0.0.1 pasted "bug 8649 Search.t test > perl t/db_dependent/Search.t" (199 lines) at http://paste.koha-community.org/115 |
| 15:57 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Needs Signoff , C4::Search needs a unit test |
| 15:58 | jcamins | Hrm. |
| 16:00 | So why would the test be connecting to the wrong Zebra server? | |
| 16:00 | Do you have anything in t/db_dependent/data/zebra.log? | |
| 16:01 | wajasu | empty |
| 16:01 | jcamins | Okay, so set_context isn't working. |
| 16:02 | Oh. | |
| 16:02 | Geez. | |
| 16:02 | This is embarrassing. | |
| 16:02 | gmcharlt | jcamins: I suspect that using set_context() and mocking the methods needs to be done before use_ok('C4::Seaarch') |
| 16:02 | plus what you just noticed ;) | |
| 16:02 | jcamins | gmcharlt: nah, I think the problem is the whole "jcamins" in the path name. |
| 16:04 | gmcharlt | jcamins: out of curiosity, what's your platform? I'm not entirely sure that the compiled zebra indexes are portable, at least to the box I've been using |
| 16:04 | jcamins | wajasu: okay, do a git pull and try again. |
| 16:04 | gmcharlt: Debian... | |
| 16:04 | wahanui | debian is what most people use and there are good manuals and even packages for that |
| 16:04 | gmcharlt | jcamins: right, but what architecture? |
| 16:05 | jcamins | I'm trying to figure that out. |
| 16:05 | gmcharlt | uname -a |
| 16:05 | jcamins | Thanks. |
| 16:05 | i686 | |
| 16:06 | So I need to do the indexing, too. | |
| 16:06 | Okay, we can do that. | |
| 16:06 | gmcharlt | yeah |
| 16:06 | (box I'm using for testing is x86_64) | |
| 16:06 | pastebot | "wajasu" at 127.0.0.1 pasted "bug 8649 Search.t test > perl t/db_dependent/Search.t #2" (35 lines) at http://paste.koha-community.org/116 |
| 16:06 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Needs Signoff , C4::Search needs a unit test |
| 16:06 | jcamins | Well... that's not an improvement. |
| 16:06 | Are you on x86_64? | |
| 16:07 | 'Cause apparently that's going to be an issue. | |
| 16:07 | wajasu | i'm on x86_64 deb |
| 16:07 | jcamins | Right. Guess I'd better change the patch to reindex, too. |
| 16:07 | This might take a little bit... | |
| 16:07 | * jcamins | sighs. |
| 16:07 | jcamins | I knew it was too easy. |
| 16:08 | gmcharlt | jcamins: well, I think you're very close |
| 16:08 | wajasu | I'm grabbing lunch then later you let me know and I'll pull and try again. |
| 16:08 | melia joined #koha | |
| 16:09 | talljoy1 joined #koha | |
| 16:09 | jcamins | gmcharlt: I think I can probably use rebuild_zebra -k, use the export in the test, and then index that directly with zebidx. |
| 16:09 | I hope. | |
| 16:10 | Mocking the data in rebuild_zebra.pl would be... not fun. | |
| 16:10 | gmcharlt | jcamins: that should be close enough -- besides, it will be handy to have the actual MARC file(s) anyway |
| 16:10 | not to be too much of a pain, but are the records CC0 or the like? | |
| 16:11 | jcamins | They're the sample records from wizzyrea. |
| 16:11 | gmcharlt | ok |
| 16:12 | jcamins | Maybe we need a "sample data generator," which takes a bunch of records, and adds a bunch of items to them. |
| 16:13 | * jcamins | does not volunteer to write it. |
| 16:14 | gmcharlt | jcamins: could you do me a favor, grab the snippet of C from http://stackoverflow.com/quest[…]ian-or-big-endian |
| 16:14 | then do gcc test.c; ./a.out | |
| 16:14 | jcamins | Sure. |
| 16:14 | little-endian. | |
| 16:16 | How could an x86 machine be big-endian? | |
| 16:16 | gmcharlt | my amd64 is also little endian |
| 16:17 | wajasu | i ran it in my koha debian VM and it said little-endian |
| 16:17 | uname -a => Linux biblio 2.6.32-5-amd64 #1 SMP Sun May 6 04:00:17 UTC 2012 x86_64 GNU/Linux | |
| 16:18 | jcamins | gmcharlt: bet Zebra was implemented using int rather than long. |
| 16:19 | I hate int. | |
| 16:20 | Actually, I guess they'd have to use size_t, if they support little endian systems. | |
| 16:20 | gmcharlt | I attached an strace to the zebrasrv child process ... trying a search on my box causes it to die with a floating point exception |
| 16:22 | jcamins | wajasu: I'm going to have to rebase the branch. |
| 16:23 | Well, I guess I could call it search_t2. | |
| 16:24 | Oh, darn. | |
| 16:24 | I forgot to do git rm. | |
| 16:25 | talljoy joined #koha | |
| 16:25 | jcamins | Fear not. regular expressions to the rescue. |
| 16:27 | * chris_n | bemoans spending ~8hours to write 12 lines of code |
| 16:27 | chris_n | but loves the results |
| 16:27 | kf | what are you working on? |
| 16:27 | :) | |
| 16:27 | chris_n | a webmin interface for pykota |
| 16:28 | datadoctor | sounds cool |
| 16:28 | jcamins | Woohoo! |
| 16:28 | kf | what is pykota? :) |
| 16:28 | * chris_n | has successfully ridden his network of Win32 servers |
| 16:28 | kf | python... ? |
| 16:28 | chris_n | yay! |
| 16:28 | jcamins | Wait. |
| 16:28 | chris_n | kf: its written in python |
| 16:28 | jcamins | I forgot to add the data. |
| 16:28 | chris_n | kf: pykota.com |
| 16:28 | its print accounting backend for cups | |
| 16:29 | probably very useful to libraries and academic institutions | |
| 16:29 | kf | oh interesting |
| 16:29 | wahanui | interesting is sometimes good and sometimes bad |
| 16:29 | kf | good this time :) |
| 16:29 | chris_n | jcamins: data is always important |
| 16:30 | jcamins | Also, it leaves .mf files. |
| 16:31 | adnc_ joined #koha | |
| 16:31 | jcamins | Wait... this is no good. |
| 16:31 | * jcamins | moves things between scripts. |
| 16:34 | jcamins | Wait... |
| 16:34 | Drat. | |
| 16:36 | Great... | |
| 16:36 | Now the test doesn't work on my system either. | |
| 16:37 | kf | oh no, even 25 |
| 16:38 | jcamins | Yay! |
| 16:38 | (regarding the registrations, not regarding the fact that Zebra hates me. | |
| 16:40 | Ah. | |
| 16:40 | Here's the problem. | |
| 16:44 | kf | ah, wrong window :) |
| 16:47 | eythian joined #koha | |
| 16:50 | jcamins | Yay! |
| 16:50 | New patch attached to the bug. | |
| 16:50 | Note that you still require the fix for bug 7648 to use it. | |
| 16:50 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7648 enhancement, P5 - low, ---, kyle.m.hall, NEW , staff can make themselves superlibrarians |
| 16:50 | jcamins | This should work on any architecture. |
| 16:51 | I hope. | |
| 16:51 | Note that it's a bit slower now. | |
| 16:55 | gmcharlt | jcamins: do you have it on a branch as well? |
| 16:55 | jcamins | gmcharlt: I'll push it, one moment. |
| 16:56 | It's on search_t2. | |
| 16:56 | On my github repo. | |
| 17:08 | wajasu | got search_t2 |
| 17:08 | ran. but errors. | |
| 17:08 | jcamins | Same ones? |
| 17:08 | wajasu | yes |
| 17:08 | jcamins | Hm. |
| 17:09 | gmcharlt | jcamins: once I finish setting up a new repo, I have a follow up patch for you |
| 17:09 | jcamins | Same as the first run or same as the second? |
| 17:09 | gmcharlt: ah, I guess you were able to figure out what was wrong? | |
| 17:09 | gmcharlt | jcamins: yeah, I've got the test cases working for me |
| 17:09 | jcamins | Yay! Progress! |
| 17:11 | So I guess set_context still isn't working for wajasu. | |
| 17:11 | pastebot | "wajasu" at 127.0.0.1 pasted "bug 8649 search_t2 > perl t/db_dependent/Search.t #3" (42 lines) at http://paste.koha-community.org/117 |
| 17:11 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Needs Signoff , C4::Search needs a unit test |
| 17:11 | gmcharlt | yeah, that's what my patch deals with |
| 17:12 | * gmcharlt | waits not-so-patiently for a push to finish |
| 17:12 | jcamins | Oh, the set_context is in the wrong place. |
| 17:13 | Also whatever problem you located. | |
| 17:14 | gmcharlt | jcamins: https://github.com/gmcharlt/koha-test, branch bug8649 |
| 17:15 | jcamins | Fetching now. |
| 17:16 | Ohhh. | |
| 17:16 | wajasu: gmcharlt's branch? | |
| 17:17 | wajasu | i see it |
| 17:17 | jcamins | s/: /: could you try / |
| 17:17 | * jcamins | sighs. |
| 17:17 | wajasu | ok |
| 17:17 | jcamins | English I speaking goodly do. |
| 17:18 | I'm going to blame that on C4::Search. | |
| 17:18 | mbalmer joined #koha | |
| 17:18 | druthb | lol |
| 17:18 | gmcharlt | jcamins: another thing I noticed -- if a test fails, the test case hangs waiting for zebrasrv to die ... which never happens |
| 17:18 | jcamins | Ooh. |
| 17:18 | That'd be a problem. | |
| 17:19 | mbalmer | hi |
| 17:19 | wahanui | que tal, mbalmer |
| 17:19 | wajasu | jcamins: you want me to remote add the gmcharlt's koha-test? |
| 17:19 | jcamins | wajasu: yes please. |
| 17:19 | wajasu | ok |
| 17:19 | jcamins | And if it works, you can sign off on those patches, and upload them to the bug. |
| 17:19 | Meanwhile, I shall ponder how to catch a catastrophic failure. | |
| 17:19 | mbalmer | kf? |
| 17:19 | wahanui | kf is cait or really, really sweet. or <reply>she gives me memory loss or a holds expert. |
| 17:20 | jcamins | Stick the entire thing in an eval {} ? |
| 17:20 | gmcharlt | jcamins: sec, I'm trying something |
| 17:22 | jcamins | gmcharlt: has my monomania rubbed off on you? :) |
| 17:24 | gmcharlt | jcamins: wajasu: I've pushed a follow-up to my branch |
| 17:25 | kf | mbalmer? :) |
| 17:25 | druthb | kf? |
| 17:25 | wahanui | kf is cait or really, really sweet. or <reply>she gives me memory loss or a holds expert. |
| 17:25 | jcamins | druthb? |
| 17:25 | wahanui | i heard druthb was a migration specialist and great friend or crazy as a loon. |
| 17:25 | wajasu | gmcharlt: just did pull |
| 17:26 | druthb | :D |
| 17:28 | pastebot | "wajasu" at 127.0.0.1 pasted "bug 8649 gmcharlt koha-test search_t > perl t/db_dependent/Search.t #4" (47 lines) at http://paste.koha-community.org/118 |
| 17:28 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Needs Signoff , C4::Search needs a unit test |
| 17:28 | melia joined #koha | |
| 17:28 | gmcharlt | wajasu: do you have KOHA_CONF set in your environment? |
| 17:29 | wajasu | yes |
| 17:29 | gmcharlt | what happens if you unset it? |
| 17:29 | wajasu | hold on |
| 17:30 | same | |
| 17:30 | gmcharlt | wajasu: probably a silly question, but is idzebra installed on that box? |
| 17:31 | wajasu | its koha-common based |
| 17:31 | jcamins | Oooh... the data directory isn't installed properly? |
| 17:32 | I shall build packages and find out. | |
| 17:35 | gmcharlt | hmm -- me just got it working on a koha-common based box as well |
| 17:35 | wajasu: another thing to try -- unsetting PERL5LIB | |
| 17:37 | wajasu | gmcharlt: no diff w/o PERL5LIB |
| 17:37 | kf left #koha | |
| 17:37 | gmcharlt | is there anyting in zebra.log? |
| 17:38 | wajasu | empty |
| 17:38 | gmcharlt | wahanui: in Search.t, try changing the log option from none,request to all |
| 17:38 | wahanui | gmcharlt: i'm not following you... |
| 17:38 | gmcharlt | then running the test again |
| 17:38 | second time ... | |
| 17:38 | wajasu: ^^ | |
| 17:39 | wajasu | ok |
| 17:39 | gmcharlt | if that doesn't work, try deleting t/db_dependent/data/etc/koha-conf.xml before running the test again |
| 17:42 | jcamins | If nothing shows up in the log, it means the fork isn't working. |
| 17:42 | (or the exec) | |
| 17:43 | gmcharlt | wajasu: you have /usr/bin/zebrasrv and /usr/bin/zebraidx, right? |
| 17:43 | wajasu | its running |
| 17:44 | yes both | |
| 17:45 | gmcharlt | anything showing up in zebra.log now that the log verbosity is turned up? |
| 17:45 | wajasu | yes |
| 17:45 | i should be in your branch right? | |
| 17:45 | gmcharlt | yes |
| 17:46 | wajasu | hold on. |
| 17:48 | libsysguy joined #koha | |
| 17:48 | jcamins | wajasu: you don't need to have Zebra running when you start the test. |
| 17:49 | wajasu | wait pasting log |
| 17:49 | jcamins | How did you build the packages? I can't build packages based on master. |
| 17:50 | pastebot | "wajasu" at 127.0.0.1 pasted "bug 8649 gmcharlt koha-test zebra.log > perl t/db_dependent/Search.t #5" (50 lines) at http://paste.koha-community.org/119 |
| 17:50 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Needs Signoff , C4::Search needs a unit test |
| 17:50 | jcamins | Ohhh. |
| 17:50 | wajasu: kill all the Zebra processes running. | |
| 17:51 | Then try again. | |
| 17:51 | wajasu | ok |
| 17:51 | jcamins | (you can restart Zebra after you've killed all the processes) |
| 17:53 | gmcharlt | also, I wonder why its trying to bind to port 9999 -- the koha-conf.xml generated by zebra_config.pl isn't uncommenting that out |
| 17:53 | or in, as the case may be | |
| 17:53 | wajasu | killed zebra. now zebra log shows starting zebrasrv and entering event loop |
| 17:54 | jcamins | gmcharlt: that's a good point. |
| 17:54 | wajasu: the log showed that only after you ran the test, right? | |
| 17:55 | wajasu | it must have, what else would have started it. |
| 17:55 | jcamins | wajasu: nothing should, that's why I was checking that you hadn't manually started Zebra pointing at the log. |
| 17:55 | pastebot | "wajasu" at 127.0.0.1 pasted "bug 8649 gmcharlt koha-test zebra.log > perl t/db_dependent/Search.t #6" (66 lines) at http://paste.koha-community.org/120 |
| 17:55 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Needs Signoff , C4::Search needs a unit test |
| 17:56 | jcamins | wajasu: wait... I'm confused. |
| 17:56 | That's the output you're getting? | |
| 17:56 | With part of the log in the middle? | |
| 17:57 | wajasu | after the test, there is no zebra process running. the zebra log doesn't show anything after : [debug] Entering event loop. |
| 17:57 | gmcharlt | jcamins: I've seen that before with the log level change I ask him to make -- I think zebrasv is spitting some of that to stderr |
| 17:57 | jcamins | gmcharlt: oh, okay. |
| 17:58 | wajasu | he had me change it to "all" |
| 17:58 | jcamins | Right. |
| 17:58 | I didn't realize that always printed to stderr. | |
| 17:59 | gmcharlt | I think those are just before it opens its logfile |
| 18:00 | wajasu: what are the contents of t/db_dependent/data/var/lib/zebradb/biblios/register on your system? (it should just contain a README file) | |
| 18:01 | wajasu | yes, but its called READMEE with two EEs |
| 18:01 | * gmcharlt | blinks |
| 18:02 | jcamins | Did I do that? |
| 18:02 | wajasu | no. |
| 18:02 | my typo | |
| 18:03 | its there its fine. | |
| 18:03 | gmcharlt | and no other files, right? |
| 18:03 | wajasu | nothing else |
| 18:04 | all the other zebradb places are the same. | |
| 18:04 | rambutan joined #koha | |
| 18:09 | gmcharlt | wajasu: could you add the following line after the set_context() line, then rerun? |
| 18:09 | diag($context->{'listen'}->{'biblioserver'}->{'content'}); | |
| 18:12 | jcamins | Wait a minute. |
| 18:12 | wajasu: how do you have kohaclone mounted? | |
| 18:13 | pastebot | "wajasu" at 127.0.0.1 pasted "bug 8649 gmcharlt koha-test zebra.log > perl t/db_dependent/Search.t #7" (105 lines) at http://paste.koha-community.org/121 |
| 18:13 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Needs Signoff , C4::Search needs a unit test |
| 18:13 | wajasu | over sshfs |
| 18:14 | * jcamins | bets sshfs doesn't support special files. |
| 18:14 | wajasu | i'll pull it into the VM if you like. or maybe i need a sshfs flag. |
| 18:15 | jcamins | Give it a try. |
| 18:15 | gmcharlt | jcamins: I think you have it -- I can't imagine a file socket working working over sshfs |
| 18:15 | jcamins | If that's the problem, I'll just modify the paths to use a temporary directory on /tmp |
| 18:15 | cait joined #koha | |
| 18:16 | nengard | when using the marc export tool what encoding is it using? is it utf-8 by default? |
| 18:16 | jcamins | nengard: defaults to utf-8, yes. |
| 18:16 | cait | hi all |
| 18:16 | nengard | thank you |
| 18:17 | maximep left #koha | |
| 18:17 | wajasu | i'm cloning my sshfs kohaclone mount to an inVM one, |
| 18:19 | jcamins | I guess this means I need to create the directories on the fly, too. |
| 18:20 | wajasu | All tests successful. |
| 18:20 | jcamins | Woohoo! |
| 18:20 | gmcharlt | yay |
| 18:20 | wajasu | you guys are tenacious!!! |
| 18:20 | maximep joined #koha | |
| 18:20 | * jcamins | isn't quite sure how gmcharlt caught it. |
| 18:20 | wajasu | it was all wajasu's fault :| |
| 18:21 | * jcamins | is on a white whale quest to rid the world of C4::Search and bring excellent searching to Koha. |
| 18:21 | wajasu | please, lets get it under /tmp or /var/tmp. i like my sshfs |
| 18:22 | gmcharlt | jcamins: tempdir() from File::Temp would be a good choice, methinks |
| 18:22 | pastebot | "wajasu" at 127.0.0.1 pasted "bug 8649 gmcharlt koha-test zebra.log > perl t/db_dependent/Search.t #8" (12 lines) at http://paste.koha-community.org/122 |
| 18:22 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Needs Signoff , C4::Search needs a unit test |
| 18:23 | gmcharlt | actually, hang on a sec |
| 18:23 | jcamins | gmcharlt: that was my plan. |
| 18:23 | gmcharlt | jcamins: cool, I'll leave you to it |
| 18:23 | jcamins | If you have a better plan, though, I'm happy to change plans. |
| 18:24 | gmcharlt | jcamins: I have a patch coming in a minute |
| 18:24 | jcamins | Woohoo! |
| 18:26 | wajasu | another idea. jcamins, you had an issue posting a large patch. what if you tar gzipped it. would it be smnaller an d work? |
| 18:26 | jcamins | wajasu: no, we'd still have socket problems. |
| 18:27 | wajasu | with bugzila? thats the issue? |
| 18:29 | jcamins | No, the large patch wouldn't fix the socket issue you ran into. |
| 18:38 | wajasu | http://www.thegeekstuff.com/20[…]x_allowed_packet/ |
| 18:38 | jcamins | wajasu: turns out that there was no reason for such a large patch anyway. |
| 18:39 | wajasu | i wondered why. |
| 18:39 | jcamins | wajasu: I was trying to eliminate the need to reindex every time you run the test suite. |
| 18:39 | No dice. | |
| 18:40 | wajasu | is that the initial delay before output? |
| 18:40 | jcamins | Yup. |
| 18:41 | Well, there's a delay for installing files, then a much longer delay for indexing. | |
| 18:41 | gmcharlt | jcamins: wajasu: I've pushed a follow up to my branch |
| 18:43 | wajasu | pulled it. it ran |
| 18:43 | gmcharlt | and from your sshfs clone, in particular? |
| 18:43 | wajasu | i see Name "DBI::errstr" used only once: possible typo at t/db_dependent/Search.t line 37. |
| 18:43 | whats up with that | |
| 18:44 | jcamins | wajasu: I'm not sure, actually. |
| 18:44 | gmcharlt | just a minor warning |
| 18:46 | jcamins | Works great. |
| 18:46 | gmcharlt++ | |
| 18:47 | gmcharlt | wajasu: jcamins: I've pushed to a new branch called bug8649_signed_off |
| 18:47 | that includes a follow-up to quiet that warning | |
| 18:47 | also includes my signoffs | |
| 18:47 | wajasu: I'd appreciate it if you used that branch for generating your own signoffs | |
| 18:49 | jcamins | Thanks! |
| 18:50 | gmcharlt | as far as the issue of dealing with patches that are too big to attach... I suggest just putting in a pull request instead |
| 18:51 | jcamins | I also do that for the overly complex patches like bug 2060. |
| 18:51 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=2060 enhancement, P3, ---, jcamins, Signed Off , Ability to import Authorities from Staff Client |
| 18:51 | gmcharlt | we could borrow an idea from the Evergreen project and set up a working Git repo that on git.k-c.org that anybody could push to |
| 18:51 | jcamins | Oooh. |
| 18:51 | I like that idea. | |
| 18:51 | gmcharlt | if folks would prefer to avoid too much scattering about on github or gitorious |
| 18:52 | jcamins | I don't mind having a dozen remotes, but it seems to me that would be helpful for developers who are newish, and maybe aren't 100% clear on setting up their own public repos. |
| 18:53 | wajasu | so you want me to pull from bug8649_signed_off , run passing tests, then signoff referring to gmchart's git repo branch? |
| 18:54 | gmcharlt | wajasu: almost -- add your signoffs to the commits, then push to a branch on one of your repos that the RM can get to |
| 18:54 | talljoy1 joined #koha | |
| 18:55 | jcamins | wajasu: you sign off on each commit, then either push it to a public repo or attach the patches to the bugzilla bug. |
| 18:56 | wajasu | ok. i'll try to push to the public repo. |
| 18:57 | jcamins | wajasu: do you have a public repo? |
| 19:00 | wajasu | test passed without warning. now i'll signoff |
| 19:08 | no public repo. can i push to you? | |
| 19:09 | jcamins | wajasu: nah, best bet is to just attach to the bug, then. |
| 19:09 | All the patches are small enough now. | |
| 19:16 | rambutan joined #koha | |
| 19:18 | mtj | wajasu, no public repo? just use github... |
| 19:19 | wajasu | jcamins: i switched to gmcharlts branch, ran tests fine. when i git commit --amend it just mentions "quiet a variable use warning" so i think its just a followup? |
| 19:20 | my format patch is 29 lines | |
| 19:20 | jcamins | wajasu: you need to use git rebase -i to sign off on each one. |
| 19:22 | wajasu | here goes. |
| 19:24 | jcamins | http://wiki.koha-community.org[…]n_a_pushed_branch |
| 19:28 | wajasu | i did a git log and see 5 commits. will that mean i'll have 5 patches to attach to the bugzilla? |
| 19:29 | edveal joined #koha | |
| 19:29 | rangi | Morning |
| 19:29 | jcamins | Morning. |
| 19:29 | wahanui | morning is a state of mind. or whenever the cat wants breakfast. |
| 19:29 | wajasu | afternoon |
| 19:29 | jcamins | wajasu: right. |
| 19:29 | Sorry, didn't see the question earlier. | |
| 19:33 | wajasu | I'm going to try http://stackoverflow.com/quest[…]-git-format-patch |
| 19:33 | if thats ok. | |
| 19:33 | jcamins | We don't want to squash them all because gmcharlt wrote some of the patches. |
| 19:34 | wajasu | so you want them able to pick and choose? |
| 19:34 | jcamins | No, but it's important for history. |
| 19:34 | Oh, you can use this: git format-patch master --stdout > my_new_patch.diff | |
| 19:35 | rangi | Stealing authorship is bad mmmkay |
| 19:36 | jcamins | Also, squashing patches is one of rangi's pet peeves. :) |
| 19:36 | rangi | Yes yes it is |
| 19:36 | wajasu | i'm just trying to help the push master :) |
| 19:37 | master pusher | |
| 19:37 | rangi | Seriously tho history is important, and knowing who authored code too |
| 19:38 | For all sorts of legal reasons | |
| 19:38 | wajasu | i won't squash. |
| 19:38 | rangi | Cool |
| 19:39 | Squashing a series from one person is different | |
| 19:39 | But mixing gets messy | |
| 19:54 | maximep left #koha | |
| 19:54 | maximep joined #koha | |
| 19:55 | adnc_ joined #koha | |
| 19:56 | rangi | My stop |
| 20:01 | back | |
| 20:11 | drojf joined #koha | |
| 20:11 | drojf | good evening |
| 20:11 | rangi | hi drojf |
| 20:11 | drojf | hey rangi |
| 20:19 | bag | morning rangi |
| 20:20 | rangi | heya bag |
| 20:21 | cait | hi bag, hi rangi |
| 20:21 | bag | hey cait |
| 20:23 | oleonard | See ya #koha |
| 20:23 | cait | bye oleonard :) |
| 20:34 | kathryn joined #koha | |
| 20:38 | edveal joined #koha | |
| 20:39 | wajasu | rangi: after git amending each with [SIGNED-OFF] prefixing each 1st line, i ran format-patch -s origin/master and only the last one has has SIGNED-OFF in prefix. is that OK? |
| 20:40 | rangi | as long as the they have the signoff in the patch the subject line doesnt really matter |
| 20:40 | drojf joined #koha | |
| 20:40 | wajasu | it also generated 6 patches instead of 5. so they also have [PATCH 1 of 6] though i am only uploading 2-6. is tht ok. |
| 20:41 | rangi | thats fine |
| 20:41 | you can turn that off by -N for future reference | |
| 20:41 | wajasu | good to know. |
| 20:42 | adnc_ joined #koha | |
| 21:02 | wajasu | whew. glad to have bug 8649 signed off :) |
| 21:02 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8649 enhancement, P5 - low, ---, jcamins, Signed Off , C4::Search needs a unit test |
| 21:03 | rangi | well done |
| 21:04 | jcamins | Yay! |
| 21:05 | wajasu | i'm going for a run. then later will attempt to sign off on a couple that i tried, which folks have updated. |
| 21:06 | jcamins++ | |
| 21:06 | gmcharlt++ | |
| 21:06 | and it runs on my sshfs mount too. | |
| 21:11 | no if someone could signoff on my bug 8378 patch, so that bug 8607, which i signed off on, can get over_notice.pl ready. | |
| 21:11 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8378 critical, P5 - low, ---, koha-bugs, Needs Signoff , <fine> syntax not working on overdues anymore |
| 21:11 | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8607 critical, P5 - low, ---, jonathan.druart, Signed Off , overdue_notices is broken | |
| 21:14 | maximep left #koha | |
| 22:36 | edveal left #koha | |
| 22:40 | papa joined #koha | |
| 22:43 | papa joined #koha | |
| 22:54 | papa joined #koha | |
| 22:57 | papa left #koha | |
| 23:39 | wajasu | ok bug 8382 signed off. |
| 23:39 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8382 blocker, P1 - high, ---, christophe.croullebois, Needs Signoff , It is not possible to cancel an order when receiving on a filtered page in parcel.pl |
| 23:41 | jcamins | Does anyone have any idea what this regular expression does: (?-xism:^\s*) |
| 23:42 | Oh, xism are regexp options. | |
| 23:46 | BobB_ joined #koha | |
| 23:48 | Irma joined #koha |
← Previous day | Today | Next day → | Search | Index