← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:52 | libsysguy left #koha | |
| 04:24 | drojf joined #koha | |
| 04:42 | wajasu joined #koha | |
| 04:47 | wajasu | just tried to reverse engineer the koha mysql schema. she's a beaute! |
| 04:52 | drojf joined #koha | |
| 05:04 | drojf1 joined #koha | |
| 05:13 | drojf joined #koha | |
| 06:01 | sophie_m joined #koha | |
| 06:36 | sophie_m left #koha | |
| 06:47 | sophie_m joined #koha | |
| 06:50 | rangi | wajasu: no need to do that its all documented |
| 06:50 | http://schema.koha-community.org/ | |
| 06:50 | wahanui | http://schema.koha-community.org/ are you looking here? |
| 06:53 | adnc joined #koha | |
| 07:17 | sophie_m left #koha | |
| 07:25 | francharb joined #koha | |
| 07:26 | francharb | good morning #koha |
| 07:26 | ropuch | Good morning :) |
| 07:30 | rangi | francharb: http://stats.workbuffer.org/scroller.html |
| 07:30 | and good morning :) | |
| 07:30 | im totally rewriting the whole thing now | |
| 07:33 | mbalmer joined #koha | |
| 07:37 | mbalmer | morning |
| 07:37 | ropuch | Too much text for <h2> ;-) |
| 07:37 | rangi: consider moving some part of info outside of <h2></h2> | |
| 07:37 | Below maybe? ;> | |
| 07:38 | rangi | im rewriting the whole thing |
| 07:38 | ropuch | I can see changes from yesterday version ;> |
| 07:38 | rangi | yeah im ditching it, rewriting in dancer |
| 07:53 | ibeardslee | not prancer? |
| 07:54 | or vixen or comet | |
| 07:54 | cait joined #koha | |
| 07:54 | cait | morning #koha |
| 07:58 | francharb | 0/ cait |
| 07:58 | cait | hi francharb :) |
| 08:06 | drojf joined #koha | |
| 08:10 | drojf | hi #koha |
| 08:25 | cait | wow |
| 08:25 | I can search again | |
| 08:25 | after reverting one patch | |
| 08:28 | drojf | great |
| 08:28 | what patch was it? | |
| 08:29 | cait | the same htat gave jared trouble |
| 08:29 | adding limits to search history | |
| 08:29 | I am sure it didn't do that when I tested it | |
| 08:31 | drojf | ah the one that rangi reverted out of 3.8? |
| 08:32 | rangi | yep |
| 08:33 | cait | exactly that one |
| 08:33 | i really wonder what's going wrong there, strange symptoms | |
| 08:33 | drojf | oh-oh that could have been bad |
| 08:34 | cait | drojf: but you weren't able to confirm the problem... it still quite a mystery |
| 08:34 | did you activate search history? | |
| 08:35 | drojf | not that i know of |
| 08:38 | cait | not sure if it's activated by default or not |
| 08:38 | it would show up as a separate link on top of your opac | |
| 08:38 | where the link to the borrower account is | |
| 08:39 | adnc joined #koha | |
| 08:40 | drojf | oh yes i had thar |
| 08:40 | that | |
| 08:42 | apparently it does not break everything for everybody or it would not have been pushed to 3.8 | |
| 08:43 | cait | hm yeah, but it certainly broke my master installation |
| 08:43 | perhaps some bad combination of preferneces? I am running out of ideas... | |
| 08:43 | only glad I can continue testing now | |
| 08:43 | ok brb | |
| 09:10 | drojf1 joined #koha | |
| 09:31 | cait | @wunder Konstanz |
| 09:31 | huginn | cait: The current temperature in Taegerwilen, Taegerwilen, Germany is 21.1°C (11:30 AM CEST on July 08, 2012). Conditions: Mostly Cloudy. Humidity: 69%. Dew Point: 15.0°C. Pressure: 29.95 in 1014 hPa (Steady). |
| 09:31 | cait | not so hot today it seems :) |
| 09:35 | oook, deactivating search history in opac fixes all my problems on master (for the logs ;) ) | |
| 09:35 | drojf1 | heh |
| 09:36 | rangi | http://dashboard.koha-community.org/ |
| 09:36 | checkout the random bug | |
| 09:36 | it pulls up one that isnt closed, resolved or pushed | |
| 09:36 | cait | wow cool! |
| 09:37 | rangi++ | |
| 09:37 | I love it | |
| 09:37 | one problem with gbsd I think was lack of visuals :) this is very nice! | |
| 09:38 | drojf1 | hey that's cool |
| 09:38 | rangi++ | |
| 09:38 | rangi | im gonna add oldest 5 bugs needing sign off now |
| 09:39 | drojf1 | make it look scary so we get a guilty conscience :) |
| 09:39 | cait | hehe |
| 09:39 | yeah :) | |
| 09:39 | hm I could try to come up with some css | |
| 09:40 | for the last 10 sign offs | |
| 09:40 | drojf1 | make a double rainbow for jcamins_away |
| 09:40 | he has half the sign offs | |
| 09:42 | rangi | thatwould be good, any css gratefully accepted |
| 09:42 | cait | yeah |
| 09:42 | thinking | |
| 09:42 | rangi | im making that 5, and 5 needs signoff |
| 09:42 | and ill also try to get info from jenkins to display | |
| 09:42 | cait | we don't have long lines here, so I think breaking the information on 2 lines would be better |
| 09:42 | like name and time and bug number and description on next | |
| 09:43 | and then give some more space between entries | |
| 09:43 | I am making a dummy | |
| 09:49 | drojf joined #koha | |
| 09:49 | * drojf | tries a different modem |
| 09:49 | cait | good luck :) |
| 09:49 | drojf | thanks |
| 09:50 | but the one i'm trying is supposed to be the one that acts weird | |
| 09:50 | i'll guess i'll make them send me a third one :( | |
| 09:50 | cait | meh |
| 09:51 | it refuses to upload the picture | |
| 09:51 | francharb | hey cait, do you know the difference between "budget_manage" and "budget_add_del"/"budget_modify" permissions in the acquisition module |
| 09:51 | ? | |
| 09:51 | drojf | eeew some plastic waste is hanging down on my balkony from the guy one floor up |
| 09:51 | cait | no but there is a long standing bug abou tit |
| 09:51 | and noone ever gave me an answer | |
| 09:51 | look for acquisition permissons | |
| 09:51 | drojf | balcony even |
| 09:51 | francharb | cait, I will ask julian tomorrow |
| 09:51 | cait | francharb: it's been confusing from the beginning :( and the descriptions are sometimes even the same |
| 09:52 | francharb: please ask him to take a look at the bug too maybe? | |
| 09:52 | bug 3849 | |
| 09:52 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=3849 normal, P5 - low, ---, paul.poulain, NEW , Acq Permissions unclear |
| 09:52 | cait | it's really an old one |
| 09:52 | rangi | updated |
| 09:53 | francharb | cait, the thing I already know is that "period" means "budgets" and "budgets" means "funds" |
| 09:53 | :) | |
| 09:54 | cait | confusing! heh |
| 09:54 | we should really make it match the interface at least | |
| 09:54 | wher eit shows in the interface | |
| 09:54 | rangi | the needs signoff will get new ones every 100000 milliseconds |
| 09:54 | francharb | and I guess : manage budget is when you want librarian to be able to use funds |
| 09:54 | and budget add/del modify is to allow librarian to manage funds on the admin level | |
| 09:55 | cait++ | |
| 09:55 | drojf | rangi: the number of last signoffs is a lie ;) |
| 09:55 | rangi | oh yeah ill change that |
| 09:55 | cait | rangi give me a minute to show oyu my screenshot... all my tools acting up toda |
| 09:55 | y | |
| 09:55 | * francharb | is adding something new on his todo list |
| 09:55 | francharb | \0/ |
| 09:56 | (by the way, I'm using trello.com to help me getting organised. it's kind of cool! i recommend it ;) | |
| 09:56 | time for lunch | |
| 09:57 | see you later | |
| 09:57 | cait | rearranged the information a bit and added padding:5px to the li element |
| 09:58 | rangi | looking now |
| 09:58 | can you paste the css/html | |
| 09:59 | cait | it's a bit ugly because I did it in firebug, give me a sec |
| 10:06 | hm instead of using padding:5px you could do padding-bottom:10px - then the other things will fit a bit better | |
| 10:06 | and maybe give the content div a bit of margin to the left border | |
| 10:07 | margin:left:5px or something | |
| 10:07 | I am not so good with css - owen would probably not be too happy with me :) | |
| 10:16 | rangi | hows that? |
| 10:16 | cait | yay :) |
| 10:16 | I like it :) | |
| 10:16 | hope you do too? | |
| 10:17 | rangi | yup |
| 10:17 | ibeardslee joined #koha | |
| 10:17 | cait | cool :) |
| 10:17 | rangi | wanna reply to my mail, with the link to that |
| 10:17 | im gonna turn the other one off | |
| 10:17 | cait | ah, so what do you want me to rewrite? |
| 10:17 | new improved version at ... ? | |
| 10:17 | rangi | :) |
| 10:17 | yep, in the spirit of collaboration that koha is famous for :-) | |
| 10:18 | cait | you did all the work on it :) |
| 10:20 | rangi | updated the nav |
| 10:20 | cait | maybe better use {padding-bottom:10px;} and add some padding to the content element? it looks a bit squashed |
| 10:20 | rangi | ? |
| 10:21 | cait | #content {padding: 15px 20px 15px 10px;} |
| 10:21 | what would make it the same as the sidebar | |
| 10:22 | moving the text a bit away from the borders | |
| 10:22 | rangi | lemme try |
| 10:22 | cait | and then: #example_4 ul li { padding-bottom: 10px;} |
| 10:22 | because else the left padding adds up | |
| 10:23 | rangi | like that? |
| 10:27 | cait | rangi: the needs signoff are the oldest now? or random? |
| 10:28 | rangi | oldest |
| 10:32 | francharb | re |
| 10:32 | rangi | wb francharb |
| 10:32 | francharb | \0/ rangi |
| 10:34 | cait | rangi: about the css - still looks the same? |
| 10:34 | nice navigation :) | |
| 10:35 | rangi: I think the css does not work because there are some weird characters in there | |
| 10:35 | I will make you a clean paste | |
| 10:35 | rangi | hmm? |
| 10:36 | cait | http://paste.koha-community.org/18 |
| 10:42 | rangi | hows that? |
| 10:43 | cait | yep |
| 10:43 | :) | |
| 10:43 | now it looks like intended | |
| 10:45 | so if you now made last 5 sign offs h3 instead of h2... all the headlines would be the same size | |
| 10:45 | :P | |
| 10:45 | yes, I am terrible | |
| 10:46 | hm jenkins status is h2 too, it's only b it of mixed, perhaps intentional | |
| 10:50 | rangi | all h3 now |
| 10:57 | cait | yay |
| 10:57 | :) | |
| 10:57 | what will jenkins show? | |
| 10:58 | rangi | probably just the status of jobs |
| 10:59 | cait | :) |
| 11:40 | drojf++ for overdue bug 7143 | |
| 11:40 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7143 trivial, P5 - low, ---, katrin.fischer, Passed QA , Bug for tracking changes to the about page |
| 12:16 | BobB joined #koha | |
| 12:25 | adnc joined #koha | |
| 12:34 | jcamins | Hey, didn't I sign off on bug 5635? |
| 12:34 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=5635 enhancement, P1 - high, ---, stephane.delaune, Needs Signoff , bulkmarcimport new parameters & features |
| 12:36 | cait | jcamins: I can't remember |
| 12:36 | but I had to fail 2 of your patches :( | |
| 12:37 | jcamins | cait: oh no! |
| 12:38 | cait | I am sorry :( |
| 12:38 | jcamins | That's what QA is for. |
| 12:38 | cait | yeah, but I am still sorry |
| 12:39 | jcamins | Could you attach a screenshot of bug 8204? |
| 12:39 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8204 enhancement, P5 - low, ---, jcamins, Failed QA , Authority viewer in OPAC ugly, unfriendly, and mostly useless |
| 12:39 | cait | what's the critical point? |
| 12:40 | jcamins | I'm wondering where the links to the MARC view went. |
| 12:40 | I'm hoping if I see a screenshot, it will give me a hint about why the tabs aren't there. | |
| 12:41 | cait | ah |
| 12:41 | so there should be tabs to different views? | |
| 12:41 | jcamins | Yup. |
| 12:41 | Also, the hash thing is an old bug. | |
| 12:41 | Actually, let me see when I attached the patch. | |
| 12:41 | cait | it's not appearing on current master |
| 12:41 | jcamins | Old bug in my code. |
| 12:42 | Of course it doesn't appear on current master... neither does any indication of what the main entry is. ;) | |
| 12:42 | cait | oh ! |
| 12:42 | I missed the tabs | |
| 12:42 | I am sorry! | |
| 12:42 | the tabs are there :) | |
| 12:42 | so it's only the hash thing | |
| 12:43 | and maybe not showing the headline when there are no entries following | |
| 12:45 | hm | |
| 12:45 | and the fact that my system keeps mailing errors | |
| 12:46 | jcamins | Okay, found the errors. |
| 12:56 | cait | jcamins: have you seen http://dashboard.koha-community.org/ |
| 12:57 | ? | |
| 12:57 | jcamins | cait: I have. |
| 12:57 | It's very, very cool! | |
| 12:57 | cait | it totally is! rangi++ |
| 13:01 | jcamins | 8204 is ready for another look. :) |
| 13:06 | cait | ok |
| 13:06 | going back to that | |
| 13:07 | jcamins | :) |
| 13:07 | cait | hm |
| 13:53 | mveron joined #koha | |
| 13:53 | mveron | hi #koha |
| 13:54 | cait | hi mveron :) |
| 13:54 | why are you not at the beach!? | |
| 13:54 | mveron | It is to hot... |
| 13:55 | cait | @wunder Konstanz |
| 13:55 | huginn | cait: The current temperature in Taegerwilen, Taegerwilen, Germany is 24.3°C (3:55 PM CEST on July 08, 2012). Conditions: Scattered Clouds. Humidity: 61%. Dew Point: 16.0°C. Pressure: 29.92 in 1013 hPa (Steady). |
| 13:55 | cait | mveron: I can undertand that reasoning |
| 13:55 | mveron | 24° is not bad... |
| 13:55 | cait | no, it's nice |
| 13:55 | mveron | But the early morning and the evennings are nics |
| 13:55 | jcamins | Ah-ha! |
| 13:56 | mveron | Much sun, I have not to much contraast on my screen... |
| 13:56 | mbalmer around? | |
| 14:01 | @wunder Kamares | |
| 14:01 | huginn | mveron: Error: No such location could be found. |
| 14:02 | cait | haven't seen mbalmer today I think |
| 14:03 | libsysguy joined #koha | |
| 14:04 | mveron | Thanks, cait :-) |
| 14:10 | libsysguy left #koha | |
| 14:25 | * mveron | ...has to get some cold drink :-) |
| 14:46 | francharb | see you later |
| 14:58 | mbalmer | cait, actually I am here |
| 15:02 | cait | ah |
| 15:03 | only meant I didn't see you talking that day | |
| 15:03 | * cait | just finished her attempt on making baileys fudge like bought in edinburgh |
| 15:04 | mbalmer | yeah, I did not say much, was occupied with debian packaging stuff and setting up secure chrooted repositories |
| 15:05 | cait | ... and I covered half of my kitchen in caramel... |
| 15:05 | mbalmer | hehe ;( |
| 15:05 | cait | hope the result is worth all the stickiness |
| 15:08 | the first saucepan was too small | |
| 15:09 | mbalmer | it will work out. |
| 15:10 | jcamins_away | Why did you chroot the repository? |
| 15:10 | cait | thx :) |
| 15:11 | mbalmer | jcaming_away, every "customers" gets an account and registers the machines using a ssh key. they can access the repo in a safe manner and only get the packages they need to (we use the apt-get ssh method) |
| 15:12 | jcamins_away | mbalmer: ah, I see. |
| 15:12 | mbalmer | so they don't get a shell when they log in via ssh, they can only execute the commands apt-get needs, and are confined to a chroot jail. |
| 15:12 | jcamins_away | Right, that makes sense. |
| 15:12 | * jcamins_away | uses a regular apt repo, so it's just a matter of apt-get upgrade on the customer's server. |
| 15:13 | libsysguy joined #koha | |
| 15:13 | mbalmer | wrote a small shell, aptsh, which allows only find and dd to be executed, aka what apt-get needs. that plus chroot makes it more or less secure (I I think more more than less) |
| 15:14 | yes, and this is a regular repo, clients use synaptic or apt-get update/apt-get upgrade | |
| 15:15 | jcamins_away | Ah, just one only accessed via SSH. |
| 15:15 | mbalmer | client enters our server to the apt sources and hands in his ssh key. we then decide what packages he "sees" |
| 15:16 | yes, and of course it contains only the "special" packages, i.e. customer specific ones. | |
| 15:16 | jcamins_away | Okay, that's pretty cool. :) |
| 15:17 | mbalmer | in the case of licensed software, he only sees those packages he licensed. an all seems to be secure. |
| 15:36 | drojf | @wunder berlin, germany |
| 15:36 | huginn | drojf: The current temperature in Prenzlauer Berg, Berlin, Germany is 25.9°C (5:13 PM CEST on July 08, 2012). Conditions: Overcast. Humidity: 49%. Dew Point: 14.0°C. Pressure: 29.77 in 1008 hPa (Steady). |
| 15:36 | cait | hi drojf |
| 15:36 | drojf | hey cait |
| 15:36 | cait | @wunder Konstanz |
| 15:36 | drojf | overcast. haha. thunderstorm again |
| 15:36 | huginn | cait: The current temperature in Taegerwilen, Taegerwilen, Germany is 23.7°C (5:35 PM CEST on July 08, 2012). Conditions: Mostly Cloudy. Humidity: 65%. Dew Point: 17.0°C. Pressure: 29.92 in 1013 hPa (Steady). |
| 15:46 | sandeepbhavsar joined #koha | |
| 15:46 | sandeepbhavsar | hi all |
| 15:54 | libsysguy joined #koha | |
| 16:19 | drojf | rangi: can you make the "last signoffs" appear in a different colour if it was a bug from the "needs signoff" list? |
| 16:19 | like, premium signoff? | |
| 16:22 | cait | the older the better? |
| 16:22 | I fear my fudge is not setting | |
| 16:23 | drojf | oooh |
| 16:23 | cait | or i am afraid it does not |
| 16:23 | *sigh* | |
| 16:23 | drojf | don't know mudge (haha) about fudgemaking, but maybe some patience will help |
| 16:24 | cait | i hope |
| 16:24 | * drojf | hopes too |
| 16:25 | cait | thx :) |
| 16:26 | adnc joined #koha | |
| 19:06 | mbalmer joined #koha | |
| 19:07 | * drojf | wonders what he has to do to index authorities so that they can be found |
| 19:07 | mbalmer | so |
| 19:09 | drojf | so? |
| 19:09 | wahanui | so is a long road. |
| 19:09 | jcamins_away | drojf: shouldn't need to do much of anything. |
| 19:10 | mbalmer | so means I am going to take a sauna bath ;) |
| 19:11 | drojf | jcamins_away: i added an authority personal name record when i wanted to try a patch of you. turned out it shows up nowhere |
| 19:11 | mbalmer: too much information :P | |
| 19:11 | mbalmer | it's only hot |
| 19:12 | drojf | jcamins_away: i have not really done anything with authorities before so maybe i'm just missing something. zebra said something of 4 authority records, nut i cannot find them either in opac or staff client |
| 19:12 | +but | |
| 19:14 | mbalmer | the hot pot is a cool place to discuss koha features, trust me! |
| 19:35 | paul_p_android joined #koha | |
| 19:37 | drojf | jcamins_away: so you are right in the end and now it just shows up. weird, because i put that data in yesterday. |
| 19:47 | rangi | Wow not one of those suggestions is either valid or good |
| 19:48 | jcamins | rangi: I wondered. |
| 19:49 | cait | rangi, jcamins? |
| 19:50 | jcamins | cait: on the list. |
| 19:50 | * jcamins | won't get involved. |
| 19:52 | cait | hm me neither |
| 19:52 | not until I have figured it out with my coworker | |
| 19:53 | rangi | Well it's easy syspref and move on to something actually useful. |
| 19:53 | Pointless discussions are pointless | |
| 19:56 | And let 'helpful' people help | |
| 19:58 | drojf | yes i don't see why "let's have a syspref" is not the one and only answer to this. after that i don't care what anybody does with it |
| 20:01 | rangi | Slightly |
| 20:01 | drojf | "Solr uses at least 1Gb of memory by default and http://vufind.org/wiki/performance suggests more than 4Gb" |
| 20:01 | who puts such raspberry-pi-unfriendly stuff in koha? | |
| 20:01 | rangi | Heh |
| 20:01 | jcamins | Hehe. |
| 20:01 | Zebra won't be going anywhere for a while, I don't think. | |
| 20:01 | drojf | i guess i should get a "real" git too |
| 20:01 | rangi | Hence the desire to make it optional |
| 20:06 | jcamins | Am I the only one who saw this "loophole" as a feature? |
| 20:06 | The ability for non-authenticated users to e-mail records is standard in every single other OPAC that I have seen. | |
| 20:06 | cait | i liked it too :( |
| 20:06 | jcamins | Since it's considered harmful, I'll just revert out that patch for my customers in a year. |
| 20:10 | kathryn joined #koha | |
| 20:15 | adnc joined #koha | |
| 20:17 | rangi | Well it gets worse if ppl listen to that email. That would restrict to only send to yourself |
| 20:18 | jcamins | Yes, that would be a lot worse, but not being able to send a cart without logging in is a pretty huge nuisance already. |
| 20:20 | rangi | yes, yes it is |
| 20:25 | * cait | nods |
| 20:41 | ropuch | Good evening |
| 20:42 | cait | hi ropuch :) |
| 20:42 | ropuch | cait: how's your opac-search problem? have you solved it? |
| 20:42 | cait | oh yes I have |
| 20:42 | it was a bad patch | |
| 20:42 | ropuch | What was the cause? |
| 20:42 | Oh | |
| 20:42 | cait | not sure how the patch caused the proble |
| 20:42 | but reverting it or disabling opacsearchhistory fixes it | |
| 20:49 | ropuch | Hm, it's been a long time since I send some patch, what should I type in "Message-ID to be used as In-Reply-To for the first email?" |
| 20:50 | (I'm trying to send updated polish translation for some installer files) | |
| 20:50 | rangi | https://gitorious.org/koha-dashboard now people can clone and fix my css |
| 20:50 | ahh, ropuch i would just attach them to the bug | |
| 20:51 | and mark it needs signoff, and not worry about the mailing list | |
| 20:51 | ropuch | So I should create a bug first? |
| 20:51 | rangi | *nod* or check if one already exists and update it |
| 20:52 | there might be one marked resolved already | |
| 20:52 | if not yep, a new one (every patch should have a bug number) | |
| 20:52 | ropuch | Make sense ;) |
| 20:53 | It's kinda funny I'm back on Koha translating when I'm about to stop working in library ;> | |
| 20:55 | rangi | heh |
| 20:55 | you can never escape koha :) | |
| 20:56 | cait | ropuch: oh? |
| 20:56 | rangi | or libraries |
| 20:56 | wahanui | libraries are the kings of overcomplication |
| 20:56 | rangi | https://www.youtube.com/watch?[…]ySY&feature=g-upl |
| 21:02 | libsysguy joined #koha | |
| 21:08 | ropuch | cait: yup, from the next month I won't be working as librarian or in library (but I'll still consider myself as one ;-) |
| 21:08 | cait | hm |
| 21:08 | so what are you going to do then? :) | |
| 21:09 | ropuch | technical support engineer |
| 21:09 | cait | sounds important |
| 21:09 | :) | |
| 21:09 | ropuch | hehehe |
| 21:09 | Yea, 3 words! ;-)) | |
| 21:09 | cait | working with libraries? |
| 21:09 | ropuch | Nope, afair completly unrelated |
| 21:10 | cait | ah |
| 21:10 | but updating koha before you leave? | |
| 21:10 | ropuch | We have 3.8.2 already ;> |
| 21:10 | cait | oh |
| 21:11 | ropuch | Actually I think I will contribute more form now on |
| 21:12 | rangi | w00t!! |
| 21:13 | cait | :) |
| 21:13 | woot indeed | |
| 21:14 | ropuch | I mean: in my spare time |
| 21:15 | cait | you are here now... and I am too... heh |
| 21:15 | drojf | oh cait signed off my patch for the german translators. that's cool, i really don't want to enter koha history with a patch that just puts my name in a file. i have not submitted this since 3.4 so i have something real before… |
| 21:16 | cait | drojf: we should have added your name there earlier :) |
| 21:16 | was I not supposed to sign it off? | |
| 21:16 | drojf | doesn't matter, but i'd prefer to get my other patch in first |
| 21:17 | so i have actually done someting ;) | |
| 21:17 | cait | heh |
| 21:17 | don't worry about that | |
| 21:17 | you already did something | |
| 21:19 | drojf | heh that is just a blatant scheme to get somebody to look at bug 8377 :D |
| 21:19 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8377 enhancement, P5 - low, ---, 5p4m, Needs Signoff , Show HTML5 video/ audio in OPAC for media files in 856 |
| 21:19 | drojf | also i wonder how i would make it not call me 5p4m without changing my email address |
| 21:19 | cait | I suspected it :P |
| 21:20 | hm, you can't probably | |
| 21:20 | rangi | drojf: git or bugzilla? |
| 21:21 | drojf | rangi: i thought that huginn gets that from bugzilla |
| 21:21 | rangi | bugzilla has your real name |
| 21:21 | drojf | if that is something in git i should change it myyelf of course |
| 21:21 | yes | |
| 21:21 | that is why i am confused | |
| 21:22 | rangi | hmm not sure lemme try something |
| 21:22 | drojf | but i entered the bug in bugzilla first. and the info huginn gives is not from a patch. so i assume it just uses whatever is before the @ in my email address? |
| 21:22 | cait | drojf: your author line looks nice in the patch |
| 21:23 | drojf: that was my guess | |
| 21:23 | rangi | bug 6679 |
| 21:23 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=6679 minor, P1 - high, ---, chris, Needs Signoff , Fixing code so it passes basic Perl::Critic tests |
| 21:23 | rangi | hmm yeah its just not taking the real name field |
| 21:24 | looks like huginn needs a fix | |
| 21:27 | drojf | i think i have a "too much information" problem in my bug description. because the crazy things from the rfc are not part of the patch now, it's just basic functionality plus a little extra. but for a person that does not live inside my head it looks like a lot more has to be considered |
| 21:28 | cait | drojf: step by step test plan on the bug? :) |
| 21:28 | drojf | there is one |
| 21:28 | its just a little above | |
| 21:28 | i made that manually and not in the patch, that was no great idea | |
| 21:29 | cait | don't worry so much |
| 21:33 | rangi | ill try to test tonight when the kids are asleep |
| 21:33 | drojf: have you see magnuse's semantikoha ? | |
| 21:33 | combine that with html5 and the koha opac would be one of a kind | |
| 21:34 | cait | true :) |
| 21:39 | drojf | rangi: that looks very interesting actually :) |
| 21:40 | also it reminds me that he had some bug where he asked about html5 and said it would be too early?! i think about maps | |
| 21:42 | rangi | i think if it degraded |
| 21:42 | then would be fine | |
| 22:02 | ropuch | Good night |
| 22:03 | cait | night :) |
| 22:04 | rangi | cya ropuch |
| 22:04 | mtj | morning #koha |
| 22:05 | rangi: do you know anyone that uses a before/after perlcritic check on commits for qa? | |
| 22:05 | rangi | i run the t/00-perlcritic.t |
| 22:05 | mtj | something like Test::Perl::Critic::Progressive |
| 22:05 | rangi | nope |
| 22:06 | its not actually a requirement yet | |
| 22:07 | if you introduce one into a file thats clean, thats bad, if you dont fix some that already exist i dont think thats a qa fail | |
| 22:07 | so getting all files clean is something that people can work on, but carefully, we have busted functionality cleaning code before | |
| 22:07 | and thats a particularly horrible thing to do | |
| 22:08 | no regressions beats 'clean' code imho | |
| 22:08 | mtj | sure, i agree |
| 22:08 | rangi | so we have to make sure we dont give passing the perlcritic tests to high a priority |
| 22:08 | cait | yeah |
| 22:09 | please don't break things! | |
| 22:09 | mtj | test::Perl::Critic::Progressive seems like a win |
| 22:09 | rangi | yep |
| 22:09 | mtj | it will test your modded files before the commit, and then after too... |
| 22:09 | rangi | also, fixes for critic gripes (which dont actually break anything) |
| 22:10 | should be sep to functional changes | |
| 22:10 | so that the actual change can be seen | |
| 22:10 | mtj | agreed :) |
| 22:10 | rangi | i think that the perlcritic bug is a good place to keep adding them to |
| 22:12 | mtj | im gonna write a perlcritic qa script, to spot newly introduced perlcritic errors for a commit |
| 22:12 | rangi | cool |
| 22:12 | cait | :) |
| 22:12 | rangi | i think a nice thing to do to ease into it, is if you find some, write a quick follow up |
| 22:13 | as a teaching tool | |
| 22:13 | mtj | i thought i might just check that no-one else has that already |
| 22:13 | rangi | then people will learn how to fix them |
| 22:14 | mtj | yep, thats a nice idea, rather than just fixing them myself |
| 22:14 | rangi | *nod* |
| 22:14 | mtj | hi cait :) |
| 22:14 | cait | hi mtj :) |
| 22:15 | jcamins | mtj: I would love a script like that. |
| 22:16 | mtj | yeah, if wanted it for a while now, too... |
| 22:16 | s/if/ive/ | |
| 22:17 | jcamins | Wow... a 23" monitor running at full resolution is really a wonderful thing. |
| 22:18 | mtj | i want a qa script that does 3 things for a commit ... |
| 22:18 | checks for new perlcritic errors, 'perl -c' syntax errors, and t::t errors | |
| 22:18 | jcamins | Good idea. |
| 22:18 | rangi | yep |
| 22:18 | jcamins | I want a script that runs perl -c on all .pl files. |
| 22:18 | I can't figure out how to do that. | |
| 22:18 | rangi | find file |
| 22:18 | jcamins | rangi: has pointed me at examples at several times, but it never seems to work. |
| 22:19 | rangi | and then system() it |
| 22:19 | jcamins | Sorry, not a script. A test. |
| 22:19 | mtj | a test script? :) |
| 22:19 | rangi | tests are scripts |
| 22:20 | jcamins | Yeah, but one that doesn't make prove angry even when it passes. |
| 22:21 | (mtj: watch, rangi is going to say this is easy) | |
| 22:21 | rangi | ok(system(perl -c file)); |
| 22:22 | jcamins | ... can I really do that? |
| 22:22 | Cool. | |
| 22:22 | That I could manage. | |
| 22:23 | mtj | can we start a koha-qa-tool repo on git.kc.org? |
| 22:23 | jcamins | mtj: there's release-tools. |
| 22:23 | I have to talk to gmcharlt about getting push access to that. | |
| 22:23 | rangi | The return value is the exit status of the program as returned by the wait call. |
| 22:23 | so yep it should work | |
| 22:23 | give it a try | |
| 22:23 | jcamins | rangi: thanks. |
| 22:24 | I would like to have a set of WWW::Mechanize regression tests that are not in the main Koha repo. | |
| 22:25 | rangi | hmm maybe not it returns this |
| 22:25 | mainpage.pl syntax OK | |
| 22:25 | so | |
| 22:26 | jcamins | system("perl -c $file") =~ m/syntax OK/ maybe? |
| 22:26 | rangi | something yeah that oughta do it something like that |
| 22:27 | jcamins | mtj: see, if we did that, we could do really sophisticated things like run the test against a known good version and then compare the results to the new version. |
| 22:28 | mtj | that == www::mech tests? |
| 22:28 | rangi | ahhh |
| 22:28 | jcamins | mtj: that == separate repo |
| 22:28 | rangi | 0 = pass |
| 22:28 | 1 = fail | |
| 22:28 | got: '0' | |
| 22:28 | so | |
| 22:28 | perl -e 'use Test::More; ok(!system("perl -c mainpage.pl"))' | |
| 22:29 | mtj | hmm, why not in the main repo? |
| 22:29 | rangi | ok 1 |
| 22:29 | jcamins | mtj: because then we have to have the tests in for the known good versions. |
| 22:30 | rangi | which makes sense. perl -c passes if nothing is wrong so 0 exit state |
| 22:30 | mtj | rangi++ awesome :) |
| 22:31 | rangi | so if you look at t/00-load.t |
| 22:31 | for how to use File::Spec and File::Find | |
| 22:32 | should be able to do it like that | |
| 22:32 | jcamins | Yeah, that's the one I just copied. |
| 22:34 | Yup, that worked. | |
| 22:35 | Only one problem... it only checks files with the .pl extension. | |
| 22:37 | rangi | i think you could run 2 loops |
| 22:37 | like it does, one for .pm too | |
| 22:38 | althought load.t catches those | |
| 22:38 | jcamins | Right. But there are also Perl scripts with no extension. |
| 22:38 | rangi | ah yep, you might have to spec them manually, and/or fix that :) |
| 22:39 | jcamins | Need some interface to file... |
| 22:39 | rangi | ie make a an array of their names, (or just give them .pl) |
| 22:40 | probably worth checking why we do that, and if we need to anyway? | |
| 22:41 | jcamins | Yeah, that's the option I'm going to go with. |
| 22:41 | We need to in /svc, I think. | |
| 22:41 | Not elsewhere. | |
| 22:41 | rangi | hmm true |
| 22:41 | jcamins | Hey! |
| 22:41 | rangi | well we could do Alias /svc/clown /svc/clown.pl |
| 22:41 | jcamins | Rewrite rules! |
| 22:41 | rangi | yeah or that |
| 22:41 | jcamins | /svc/*.pl -> /svc/* |
| 22:41 | rangi | yep |
| 22:41 | alias is a little faster | |
| 22:42 | but you cant shortcut like that | |
| 22:42 | so rewite wins | |
| 22:42 | rewrite too | |
| 22:46 | ok walking 2 five year olds down the hill to the movie theatre | |
| 22:46 | bbl, hopefully :) | |
| 23:21 | jcamins | Oh, cool! |
| 23:21 | Test::Strict does this automatically. |
← Previous day | Today | Next day → | Search | Index