IRC log for #koha, 2024-03-22

← Previous day | Today | Next day → | Search | Index

All times shown according to UTC.

Time Nick Message
00:40 tuxayo wiki down indeed
00:42 plus api doc, jenkins and portainer
00:42 @later tell tcohen portainer down
00:42 huginn` tuxayo: The operation succeeded.
00:53 tuxayo Any opinion about the phrasing of the options of new sysprefs from bug 34643? It's about giving more granularity for CircConfirmItemParts (by introducing CircConfirmItemPartsSCI and CircConfirmItemPartsSCO)
00:53 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=34643 enhancement, P5 - low, ---, kyle, Signed Off , Split CircConfirmItemParts for self-checkout and self-checkin
00:53 tuxayo The existing phrasing is :
00:53 CircConfirmItemParts: **Don't require** staff to confirm that all parts of an item are present at checkin/checkout.
00:53 CircConfirmItemParts: **Require** staff to confirm that all parts of an item are present at checkin/checkout.
00:53 The new is:
00:53 CircConfirmItemPartsSCI: **Allow** multi-part items to be checked in via the web-based self check-in or self checkout modules.
00:53 CircConfirmItemPartsSCI: **Don't allow** multi-part items to be checked in via the web-based self check-in or self checkout modules.
00:53 CircConfirmItemPartsSCO: **Allow** multi-part items to be checked out via the web-based self checkout module.
00:53 CircConfirmItemPartsSCO: **Don't allow** multi-part items to be checked out via the web-based self checkout module.
00:57 It seems we have to use require for legacy one and allow for the new ones due to the context they are used.
01:01 But the swap in meaning (Allow is permissive and require is about enforcing) confuses me for some reason. I wonder if that's avoidable. And the "don't" having the meaning "disabled" for CircConfirmItemParts and "enabled" for CircConfirmItemPartsSCI and CircConfirmItemPartsSCO is also confusing.
01:02 😵‍💫
01:03 So insight is welcome on this ^^
01:11 davidnind The new phrasing seems OK to me
01:38 tuxayo davidnind-away: thanks, then I can move on, it's just classic non native speaker confusion :)
01:50 thd davidnind: I posted some messages to you a little later than this hour  yesterday explaining that I may have identified why a few users had trouble receiving the wiki email confirmation messages.
01:51 davidnind: I confirmed an email account yesterday for someone reporting no confirmation message.
01:52 davidnind: I will have to set a password for her on the command line when the server running the wiki is functioning again.
01:54 davidnind: secure-mailgate.com is serving the messages for the wiki and Joubu is asking how we can set DKIM signatures for messages there.
01:59 davidnind:  Mostly library organisation email systems which people use allow messages to pass without DKIM or DMARC but the library system from yesterday is an exception.  The mail system was working for the wiki before the wiki server went down.  The problem was about authentication that email messages have the content and origin which the message headers claim.
02:13 davidnind thd: thanks for sorting out - for the last month things have been looking OK. Most registrations have been having confirmed show up. There is still one in the holds queue that I sent a message to, so when things are up again if you could have a look that would be great!
02:13 tuxayo++
02:13 thd++
02:15 tuxayo davidnind++ Thanks helping with that English proofreading issue ^^
02:21 thd davidnind: Maybe  you could get Rachel at Katipo's attention about adding the DMARC line to the DNS for lists.katipo.co.nz while we test Discourse.  It may only affect a minority of Koha people behind restrictive systems but people on such systems cannot confirm their email for the Koha general mailing list.
02:24 davidnind: She is waiting to handover the mailing list to an active maintainer but Discourse needs much testing and fixing a third party mail system for the wiki, Discourse, etc. is not so trivial even if the third party system is fixed tomorrow there is still much more to do.
02:36 dcook I suppose this highlights how the koha community infrastructure is a bit "behind the curtain"
02:36 The email thing really isn't that hard, especially if we were using one mail server
02:38 thd Having community infrastructure widely distributed helped the community survive when there was turmoil with LibLime.
02:39 dcook You can still do that via DNS
02:39 If there were turmoil with an individual now, we'd be pretty bad off
02:43 thd Apparently, no one in the Koha community has direct access for configuring DKIM at secure-mailgate.com or we do not yet know what to do.  The underlying problem is that in 2024 you have much difficulty catching an IP address with good mail reputation for a VPS to run a mail server.
02:45 Joubu has sent an email to ask the people at secure.mailgate.com
02:46 dcook Yeah mail reputation is... ugh. Even if you legitimately send a lot of email, you'll still get a bad reputation.
02:46 Yeah, fingers crossed they say something good
02:46 thd Joubu also does not have low level access to all the systems otherwise we might have a few more things working correctly if he was not otherwise too busy.
02:47 dcook I liked Owen's joke about checking the wiki for which systems are managed by who (when the wiki first went down)
02:47 by whom*
02:48 thd The people at secure-mailgate.com must have something good to say as email is their primary business.
02:48 dcook Do we really know that for sure?
02:48 There's no info about them online
02:48 It could be someone in their basement running it as a side hustle for all we know
02:49 thd Are they not securemailgate.de ?
02:49 AndroUser2 joined #koha
02:50 dcook ¯\_(ツ)_/¯
02:51 thd Still very little about them online other than some party is funding Koha to use their service for solving an important problem of mail server reputation which never used to be a problem when spam was rampant.
02:52 They are German.  We may know some people near them.
02:57 I hardly send any email.  Have been running the same mail server of my own for years and I end up in the spam box when sending test messages to a newly created test Gmail account when I had been in the inbox in previous testing.
02:59 Problems can be nothing wrong with your IP address but there had been a problem with another IP address in the same subnet.
03:00 bag joined #koha
03:01 thd I may also have taken too long to join the DKIM and DMARC party.  Gmail does not even validate whether DKIM signatures match message content and passes things to the inbox with DMARC and no DKIM signature.
03:01 wajasu remember the days when you could send an email to joe@cool.net and everyong in the cool.net domain would get it?
03:03 i had throw away email addreses and the domains are getting blacklisted
03:04 i seem to recal, that i couldn't sign onto github or gitlab a year ago so i coulnd participate with koha stuff.
03:04 thd wajasu: Was that a general property of email delivery at some early time such that xx@domain.tld was sent to yy@domain.tld and zz@domain.tld ?
03:05 wajasu yes in the 70s and 80s.  then in the 90s when businesses came onboard spam was born.
03:06 we used to just ask for a domain and they were free.
03:07 i used to scream that people were wasting the namespace.  abusing the commons
03:07 so nothing can be completely free
03:07 thd I was around then but I only had access to 18th century computers, card catalogues and their early electronic versions.
03:07 wajasu i had blocks of IP4 and they stole them from me a few years back.
03:09 wheni was a young C programmer, I used to implement RFCs as they first become available.  TCP stacks, SMTP, FTP, GOPHER, ... Web Browser.
03:09 it took me hours to compile XWindows in the 80s.
03:10 i had to get an XWindow terminal that was monochrome to have multiple windows open.  We were using serial switch boxes with dumb terminals.
03:10 today people use tmux
03:11 thd It took me hours to bring up XWindows while the system thrashed the swap space the first time I tried.  The console worked fine without graphics.
03:13 Lynx, Elinks, etc. no longer render enough sites not because of graphics but because of unnecessary JavaScript.
03:14 I hope that deprecating TemplateToolkit in favour of Vue.js does not leave an entirely blank page with no fallback for anything in the OPAC.
03:14 wajasu while you guys are at it, with the DNS, one should check if old subdomains are left adrift. https://www.youtube.com/watch?v=GH6O3oBZLK8
03:20 thd I have a recently acquired IP address at which someone else's old subdomain keeps trying to resolve.
03:24 wajasu i had a koha server for someone that would get bogged down every 6 months.  i though maybe it was amazon prime day, but in the end, i had to work on the robots.txt.  the robots kept coming for a couple of days, then it subsided.
03:24 AndroUser2 joined #koha
04:09 tuxayo The explanation field in the systempreference table is weird, I don't get where it's displayed. Because the actually text we see comes from circulation.pref.
04:10 > i used to scream that people were wasting the namespace.  abusing the commons
04:10 XD
04:10 true
04:13 > i had blocks of IP4 and they stole them from me a few years back.
04:13 lol, to be fair, that's even more of a common than domain names.
04:13 However, there are many more actors that should have been expropriated before getting at you wajasu  https://xkcd.com/195/
04:15 Various US army organization and early US tech companies have an insane number of ipv4 adresses.
04:17 And of course, they are the less used blocks: https://i.pinimg.com/originals[…]d544383b73595.jpg
04:17 What would Ford and GE do with all those IPs XD
04:18 wajasu he who owns the IPs owns the ...
04:21 tuxayo thd:
04:21 > I hope that deprecating TemplateToolkit in favour of Vue.js does not leave an entirely blank page with no fallback for anything in the OPAC.
04:21 Yeah thd, we can still proudly advertise some level of compat with IE4 or IE5 I don't remember (when the wiki work, I'll be able to find my test results) it would be a shame to loose that :)
04:22 thd I have the backup
04:22 tuxayo One problem to go more backwards in browser support was that the browser don't support <button> XD
04:22 > I have the backup
04:22 ho lol, the test wiki?N
04:23 https://wiki.test.koha-community.org
04:23 maybe not that one, it might be on the same server
04:24 thd I have not tried running restoring it but I downloaded the most recent backup from tcohen's Nextcloud instance.
04:25 tuxayo no worries, that silly page isn't going anywhere
04:26 thd The test wiki has an old database from the time of migration.  There is no process in place to synchronize the test wiki database with the current database.
04:27 I think that quite a few things were on the same server.
04:28 We might loose a day or two of content.
04:32 tuxayo wajasu: thanks, that DNS video was interesting
04:32 thd There may also be a more recent snapshot in the data centre.
04:32 tuxayo Sending to my sysadmin friends ^^
04:33 > We might loose a day or two of content.
04:33 There are no news that the server store is dead, are they?
04:33 *storage
04:33 Last time it was just an outage I think, no loss
04:33 thd I have seen that presenter previously.  He definitely has an engaging style, NetworkChuck.
04:34 The server would not start.
04:34 wajasu i'm just slooowly trying to tweak the ktd to start/stop faster.  i added the init: true to the koha service section and it doesn't delay and kill after 10 secs now.  that adds up when you work bugs.
04:35 tuxayo wajasu: nice :)
04:35 AndroUser2 joined #koha
04:35 tuxayo Maybe paralelism would help? At least for the update of the l10n there is not need to have this blocking.
04:35 thd The storage device could be fine and the hardware fault may be some other problem.
04:37 tuxayo For the rest, there might be too many dependencies to make things parallel. Maybe not all the built of the JS and CSS stuff
04:37 Could be started earlier.
04:37 Or at least could be done in parallel to zebra and ES indexing.
04:40 Yeah, the rest, I'm not sure. But it seems l10n update and yarn build could be launched right away.
04:40 thd I have two types of backup from tcohen's Nextcloud.  One is the database and persistent volumes and the other is /var/lib/docker/volumes which includes docker configuration in portainer_data and other important things.  There are also other backups which are not wiki specific which their was no reason to make available to me.
04:41 tuxayo On first run, that would make KTD fully usable minus translating while it's downloading l10n. Likely not many people would even notice this.
06:52 AndroUser2 joined #koha
06:53 wajasu i just added https://docs.docker.com/refere[…]ache-apt-packages  into the dists/bullseye/Dockerfile and if I drop my koha testing image, when i rebuild its done.
06:54 that would really might  help whoever does koha/koha-testing builds.
06:55 i needed to do docker buildx prune OR docker buildx prune -a to remove all those internat caches. WARNING dont do the prune if you have stuff to keep.
06:56 so now i am thinking about the run.sh.
06:58 i wonder if i could do a git show -s --format="%H" HEAD  to get a hash for a directory like misc/translator/po and compare to the remote
06:59 but the git filter isnt that slow, once the whole things is pulled
07:00 or maybe we can list some language prefixes in the .env TRANSLATE_PREFIX and then just download those that we want to work on.
07:02 if i could detect if the directories containing SQL changed, then i could only re-populate the db when it changed
07:05 maybe using a tool like hashdir
07:08 i could run hashdir on the sql/schema dirs in the koha git, and write to a volume(in koha git) and when the container restarts, we see if there is a change, and if so repopulate the db.
07:09 cait joined #koha
07:24 marcelr joined #koha
07:24 marcelr o/
07:28 patches are not really moving these days..
07:30 Joubu: 36081 is for you, you can do it better..
07:33 magnuse bug 36081
07:33 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=36081 is not accessible.
07:37 reiveune joined #koha
07:39 marcelr @later tell cait please push 35536 and friends (35548); 35062 touches few lines waits for 2m in pqa
07:39 huginn` marcelr: The operation succeeded.
07:41 marcelr hi all, i need some testers for bug 27893, 36068, 36018 and 35994 simple acquisiton improvements
07:41 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=27893 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Delete of biblio should warn about attached acq orders and cancel them
07:45 reiveune hello
07:52 cait joined #koha
07:52 cait good morning #koha on this sunny GBSD!
07:52 marcelr hi cait
07:52 sunny??
07:52 cait very sunny here :)
07:52 marcelr grey
07:52 AndroUser2 joined #koha
07:52 marcelr rainy
07:53 its coming your way later
07:53 cait it might, because I am invited to a birthday party this weekend
07:53 Joubu the weather is grey but you heart is sunny marcelr, right? ;)
07:53 marcelr sure
07:54 always positive
07:54 thibaud_g joined #koha
08:02 lds joined #koha
08:28 cait Joubu filed all the recent Jenkins failures - but I think we don't have patches yet
08:29 Joubu they are random failures
08:30 cait always fun
08:30 well, let's GBSD! Working on the bug bugs now
08:30 Joubu especially when it's always me looking at them, yes
08:30 cait yes, that's why I was putting it out here - hoping to raise attention and get more eyes on it
08:31 Joubu you won't :D
08:31 and they are tricky ones...
08:32 cait let me try! think "sunny" :)
08:32 AndroUser2 joined #koha
08:32 lukeg joined #koha
08:34 magnuse joined #koha
08:43 ashimema Woop woop, that's two PRs for bugzilla merged.. we're moving again 🙂
08:46 AndroUser2 joined #koha
08:52 magnuse ashimema++
08:53 cait cool :)
08:53 ashimema++
08:53 moving here too
08:55 Joubu marcelr: 36326 - IIRC only my patch was needed
08:56 cait not pushed yet
08:56 but on ym branch
08:57 Joubu please wait for marcelr reply, or push only the first patch :)
08:57 see the discussion there
08:57 cait hm bit confusing - on the bug you said only the second patch?
08:58 I'll wait with both right now - remove them from my branch for now
08:59 marcelr will have a look
08:59 cait when the first one is the one, can you pelase make the commit message a little nicer?
09:00 marcelr no i think he means the second
09:00 first is from Pedro
09:00 iirc
09:00 Joubu yes, sorry
09:00 marcelr Joubu always makes nice commit messages ;)
09:01 cait not always ;)
09:01 but mostly
09:12 thd Wiki seems to be back up as if it was never down.  Even my login state was preserved.
09:21 Maybe tcohen will have some information later about what actually failed.  The system was evidently completely recoverable without resorting to a backup which would have been older and probably not even a data centre snapshot from before it went down.
09:22 cait some problem witht he hoster is what I got, he might know more
09:22 not specific to the wiki
09:22 thd Not specific to the wiki certainly but there seemed to be some hardware failure with the server not starting.
09:24 The file system was obviously intact as some updates would otherwise have been lost.
09:26 dolf joined #koha
09:28 dolf From time to time, I get an e-mail from the Cron Daemon of the Debian VM on which my Koha is running:
09:28 Connection to the memcached servers '127.0.0.1:11211' failed. Are the unix socket permissions set properly? Is the host reachable?
09:28 If you ignore this warning, you will face performance issues
09:28 This happens sporadically, sometimes a few days apart, and sometimes a month apart. Is there any known cause for this? MemCached seems to be running fine all the time.
09:28 It happens in the /etc/cron.hourly/koha-common script
09:31 lukeg joined #koha
09:32 thd ssh access to the VPS host for the containers was lost for me yesterday as things went down.  My screen session was not preserved which indicates that the system was likely at least restarted even though it would not restart after going down yesterday.
09:33 The database state must have preserved my login state for the wiki which I find most surprising.
09:36 cait dolf: hm usually happens when koha is down for a bit - maybe a backup run or similar?
09:36 is it always the same/similar time?
09:38 first batch pushed for today
09:38 ashimema can someone remind me what the bug was for the cas thing that filled sessions
09:40 Joubu bug 36034
09:40 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=36034 blocker, P1 - high, ---, andreas.jonsson, Pushed to oldstable , cas_ticket is set to serialized patron object in session
09:42 cait first 12 bugs pushed today - will be back for more :)
09:44 dolf cait: It seems to be mostly between 06:30 and 09:30 in the morning, but with some exceptions (around 22:00 and 01:00). About 4 time this month, but not weekly.
09:48 cait hm not sure then, we usually get that if the server is down
09:48 for some reason
09:49 or might get it, it depends on what is going on, but I have seen int in maintenance sometimes
09:55 dolf OK, thanks. I'll try to monitor memcached more closely to see if it really goes down, and why.
10:09 paulderscheid joined #koha
10:18 cait davidnind++ :)
10:18 paulderscheid[m] morning #koha
10:18 So much happened here last night. O.O
10:22 cait did it?
10:23 it's GBSD!
10:23 confetti!
10:29 oleonard wahanui AWOL for GBSD? Scandalous.
10:40 cait that's true
10:40 on strike?
10:41 oleonard wahanui's job is not that taxing but the hours are terrible
10:42 cait lol
10:48 AndroUser2 joined #koha
10:51 AndroUser2 joined #koha
11:08 AndroUser2 joined #koha
11:09 cait can we please get SO/QA on bug 3612?
11:09 huginn` 04Bug https://bugs.koha-community.or[…]w_bug.cgi?id=3612 normal, PATCH-Sent (DO NOT USE), ---, paul.poulain, CLOSED FIXED, bookseller search & management
11:09 cait um not that one
11:10 can we please get SO/QA on bug 36012?
11:10 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=36012 normal, P5 - low, ---, chris, Needs Signoff , ERM/Agreements_spec.ts is failing if run too slow (?)
11:10 cait needed for Jenkins
11:19 tcohen hola #koha o/
11:19 jzairo joined #koha
11:19 cait hola tcohen
11:19 happy GBSD!
11:19 tcohen happy GBSD everyone!
11:19 I'm sorry the technical issues might got in the middle
11:20 next week I'll move the server
11:21 oleonard Sorry for the noise on Bug 36081, I was looking at the wrong thing
11:21 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=36081 is not accessible.
11:22 Joubu tcohen: do you know what happened?
11:31 cait I don#t want them to stay, but all round numbers on dashboard: NSO 140, SO 180, PQA 60
11:32 another 12 bugs pushed - heading out for lunch break, bbiab
11:37 Tea joined #koha
11:42 paulderscheid[m] I just added a .prettierrc.js in bug 36400
11:42 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=36400 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Centralize {js,ts,vue} formatting config in .prettierrc.js
11:43 paulderscheid[m] Does someone want to test?
11:43 I tested w/ vscod{e, ium} and neovim (w/ lazyvim config) and it seems to work as we want it for vue files.
11:44 AndroUser2 joined #koha
11:53 AndroUser2 joined #koha
11:53 Joubu paulderscheid[m]: you need to fix the git hook (part of ktd) and the qa script, to make them all use the same config file
11:54 paulderscheid[m] Could you point me to the files?
11:55 Joubu ktd:files/git_hooks/pre-commit
11:55 paulderscheid[m] Do you mean .git/hooks/ktd/pre-commit
11:56 Ah ok, thanks
11:56 Joubu QohA/File/JS.pm:    my $tidy = qx{yarn --silent run prettier --trailing-comma es5 --arrow-parens avoid $absf};
11:56 QohA/File/Vue.pm:    my $tidy = qx{yarn --silent run prettier --trailing-comma es5 --semi false --arrow-parens avoid $absf};
11:56 this in qa-test-tools
11:56 paulderscheid[m] Alright
11:57 Joubu for QA the script must be run at the root of the koha dir, so you will be able to locate the config file easily
11:57 for ktd you know where it is ;)
11:58 paulderscheid[m] Yep, are PRs fine for those repositoroes?
11:59 *repositories?
11:59 Or also through the bug tracker?
11:59 Joubu PR on gitlab please :)
11:59 paulderscheid[m] Alright
12:00 Joubu better first an issue, then a PR linked to the issue (start the commit with "Issue #42")
12:00 paulderscheid[m] Ok
12:18 pastebot "oleonard" at 127.0.0.1 pasted "EOENT error when running gulp po:update --lang xx-XX" (17 lines) at https://paste.koha-community.org/40325
12:19 oleonard Working with translations is really troublesome lately
12:34 khall joined #koha
12:43 khall_ joined #koha
12:44 cait how was GBSD while I was out?
12:45 EOENT is described in the docs I think
12:45 did you make sure your branch as in a clean state?
12:46 oleonard yes
12:46 cait hm
12:46 Joubu: ? :)
12:47 paulderscheid[m] I added the PRs. Hope I followed the conventions correctly.
12:48 cait paulderscheid[m]++
12:49 paulderscheid[m] We can ++ when it's merged :D But thanks cait :)
12:49 cait hm I broke Jenkins more
12:49 *sigh*
13:01 Dyrcona joined #koha
13:01 * tcohen looks
13:02 cait tcohen: I think i narrowed it down - bug 36331 and a follow-up on bug 35793 (I have that on my branch already)
13:02 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=36331 major, P5 - low, ---, nick, Pushed to master , Items that cannot be held are prevented renewal when there are holds on the record
13:02 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35793 enhancement, P5 - low, ---, jonathan.druart, Pushed to master , Remove Koha::Template::Plugin::Cache
13:02 cait but double checking wouldnot hurt :)
13:02 oh and 36012  would be great (need SO/QA)
13:03 tcohen bug 35536
13:03 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35536 enhancement, P5 - low, ---, m.de.rooy, Pushed to master , Improve removal of Koha plugins in unit tests
13:03 cait wrong number
13:03 tcohen ^^ I'm adding a follow-up for that one
13:04 cait Bug 36012
13:04 ok
13:04 ok!
13:04 tcohen bug 36012
13:04 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=36012 normal, P5 - low, ---, chris, Needs Signoff , ERM/Agreements_spec.ts is failing if run too slow (?)
13:06 tcohen cait: attached
13:10 follow-up on bug 35793 as well
13:10 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35793 enhancement, P5 - low, ---, jonathan.druart, Pushed to master , Remove Koha::Template::Plugin::Cache
13:10 cait tcohen: that I already had written myself
13:10 tcohen ah
13:11 ok
13:11 cait hm but I had killed the file
13:11 maybe need to ttake another look
13:11 tcohen ?
13:11 I'm not following
13:11 cait ah no, it's the same
13:12 the git patch confused me for a second
13:12 we wrote an identical patch
13:12 tcohen The required follow-up for 35793 is just removing the tests
13:12 cait yes
13:12 Joubu cait: ?
13:12 cait that's what I did
13:12 tcohen good
13:12 cait we agree, sorry for making it soudn complicated :)
13:12 Joubu oleonard: rm misc/translator/*.pot
13:12 tcohen looking at bug 36331
13:12 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=36331 major, P5 - low, ---, nick, Pushed to master , Items that cannot be held are prevented renewal when there are holds on the record
13:13 oleonard Thanks Joubu I will try shortly
13:13 blawlor[m] Good morning from UTC -5 happy GBSD!
13:13 tcohen kidclamp: can you look at the  t/db_dependent/Holds.t failure? the RM narrowed it down to 36331
13:14 cait Happy GBSD! :)
13:14 tcohen: test file is dead and grabbed the follow-up on bug 35536
13:14 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35536 enhancement, P5 - low, ---, m.de.rooy, Pushed to master , Improve removal of Koha plugins in unit tests
13:21 cait tcohen++
13:22 grabbing the Agreements one next
13:26 Joubu paulderscheid[m]: you have not based your PR on top of master!
13:26 ktd #415
13:26 paulderscheid[m] Whoopsie
13:27 Joubu we modified this part of the code yesterday
13:28 cait you are all just moving too fast :)
13:32 Joubu paulderscheid[m]:         my $prettier_config_file = '.prettierrc.js';
13:32 this is not correct I think, you need an abs path. You can commit from somewhere else than the root dir
13:32 paulderscheid[m] Ok, then I will fix that.
13:33 Joubu paulderscheid[m]: I would use `git rev-parse --show-toplevel`
13:34 paulderscheid[m] But just for ktd, as the qa-script is expected to run in the project root, huh?
13:34 Joubu yes, only ktd, but actually it should not hurt to have it in qa as well
13:34 paulderscheid[m] Alrighty
13:47 blawlor[m] paulderscheid: to test your bug is the idea to test a bunch of vue files and see if you get any errors? Id the command something like this: npx prettier -c .prettierrc.js /koha/koha-tmpl/intranet-tmpl/prog​/js/vue/components/Breadcrumbs.vue
13:48 paulderscheid[m] Yes, essentially if the already present vue files don't change on format, it's all good because by default a ';' would be inserted after statements.
13:48 But you can also just format before and after the patch is applied and look at the difference in output.
13:49 blawlor[m] ok I'll give it a try
13:49 paulderscheid[m] Please also document which editor(s) you've used.
13:53 schnydszch joined #koha
13:56 kidclamp tcohen: patch attached
13:58 cait tcohen: do oyu have a moment to check it?
13:58 just about to push, but then I'll wait
13:58 tcohen ok
13:58 checking
13:58 cait thanks!
14:03 tcohen looks good, attaching a signed and tidied version
14:03 cait thank you!
14:03 tcohen there are some warnings when tests are run, but unrelared
14:04 cait yeah, some tidy up for another day
14:09 ... and that's another 11 bugs
14:09 + Jenkins follow-ups
14:11 tcohen good harvest
14:12 cait let's see what explodes this time :D
14:14 are you ready to GBSD some more? :)
14:17 blawlor[m] <paulderscheid[m]> "Please also document which..." <- I'm using VScode. before the patch there's an error because the file in the command doesn't exist yet. After the patch it has some warning but no error.... (full message at <https://matrix.org/_matrix/med[…]kvtSZTigesbVfruAG>)
14:17 > <@paulderscheid:matrix.org> Please also document which editor(s) you've used.... (full message at <https://matrix.org/_matrix/med[…]MFGEjhYcjEADPfWAh>)
14:18 paulderscheid[m] Before the patch is applied you just need to run npx prettier ./<FILE_PATH> as we want to see the difference.
14:19 Joubu paulderscheid[m]: actually the PR I was talking about previously (the conflict) is not pushed yet
14:19 paulderscheid[m]: https://gitlab.com/koha-commun[…]erge_requests/494
14:19 paulderscheid[m] You can ignore the warnings about the editorconfig option. I linked a gh discussion about why that occurs (I know, it's annoying).
14:20 I just added the change in the qa-script repo
14:20 What should I do for the ktd repo then Joubu?
14:23 Joubu do you mind to rebase it again? :D
14:23 paulderscheid[m] No, but I think I just made a mistake
14:24 Joubu ok, merged
14:25 blawlor[m] <paulderscheid[m]> "Before the patch is applied..." <- before the patch if I run npx prettier ./koha-tmpl/intranet-tmpl/prog​/js/vue/components/Toolbar.vue it looks like it just outputs the file, is that right?
14:26 oleonard Joubu: Still getting the same po:update error after clearing the .pot files
14:26 paulderscheid[m] Yes, you can use -w to write to the file otherwise it will just output the corrections to STDOUT
14:27 Joubu oleonard: paste the error
14:27 oleonard: did you chown?
14:27 oleonard chown anything in particular?
14:28 Joubu all the things :D but first try with -R misc/translator/po
14:30 pastebot "oleonard" at 127.0.0.1 pasted "EOENT error when running gulp po:update --lang xx-XX" (17 lines) at https://paste.koha-community.org/40330
14:31 Joubu oleonard: is there something in misc/translator/po?
14:33 paulderscheid[m] Should be mergeable now.
14:35 oleonard Joubu: The .po files plus /debian and /ru_RU
14:36 paulderscheid[m] I think you need to teach me some git foo either cait or Joubu at hackfest.
14:36 There's still a lot I need to learn it seems.
14:37 pastebot "Joubu" at 127.0.0.1 pasted "things to check before po:update" (59 lines) at https://paste.koha-community.org/40331
14:37 Joubu oleonard: misc/translator/po should have a .git directory
14:37 oleonard Oh yes, that too sorry
14:38 Joubu if it's not there: rm -rf misc/translator/po && git clone --depth 1 https://gitlab.com/koha-community/koha-l10n misc/translator/po
14:38 if I have not typoed something
14:39 khall joined #koha
14:41 oleonard Joubu: What does `ls -l misc/translator/po|wc -l` do?
14:42 Joubu just show it's not empty :)
14:42 the number of files in the dir
14:42 but I just noticed the paste does not contain all what I selected on the screen
14:42 did the clone fix the problem?
14:46 oleonard Waiting for the clone to finish
14:49 blawlor[m] <paulderscheid[m]> "Yes, you can use -w to write..." <- I think I may be missing something with the command after the patch it doesn't seem to make any changes to the files.
14:49 paulderscheid[m] That’s the point :D
14:50 blawlor[m] paulderscheid[m]: Oh haha
14:50 cait ok, that was another 9 bugs
14:51 QA queue down from 79 this morning to 43
14:51 ... and some QA happened in between this morning and now, so it's some more than that :)
14:52 blawlor[m] so for example before the patch:... (full message at <https://matrix.org/_matrix/med[…]YtHaiPxIqRDziHhTL>)
14:52 cait ... and small victories: all enhancements from January are now gone from the queue
14:52 paulderscheid[m] Doing cardio for 45 min
14:52 Be back in a jiffy
14:52 But that looks good blawlor
14:52 cait ... way to make us feel bad :)
14:53 paulderscheid[m] If I'm not mistaken Joubu already formatted all of those files in the way we want it, so your experience is exactly what we want.
14:54 Joubu all the .vue files are correctly formatted yes, we have tests to ensure that :)
14:54 cait: we fixed that failure already..
14:54 cait which one?
14:55 Joubu see d130a6c66b6cc6fb3221c0ea7e26f2d0825f4f72
14:55 not exactly the same, but same problem with D10
14:55 cait sorry, missing context
14:55 Joubu https://jenkins.koha-community[…]/1431/consoleText
14:55 koha_1       | Can't locate object method "mock" via package "0" (perhaps you forgot to load "0"?) at t/db_dependent/Koha/Plugins/KitchenSink.t line 56.
14:58 cait passes for me locally - what do youneed me to do?
14:59 Joubu *D10*
14:59 paste that on the last bug you pushed that changes the plugin area
15:01 cait there were a few
15:01 oleonard Still no luck Joubu but I'm going to move on
15:01 cait mostly Marcel
15:04 Joubu oleonard: try that: for i in marc-MARC21 marc-UNIMARC staff-prog opac-bootstrap pref messages messages-js installer installer-MARC21 installer-UNIMARC; do gulp po:update --lang ru-RU --task $i; done
15:04 cait Joubu: I am not following you - I'll step out for a few minutes
15:05 davidnind ByWater Solutions Global Bug Squashing Day live has started https://www.youtube.com/watch?v=Q1Taq5Hta3w
15:10 wise_mike[m] joined #koha
15:14 wise_mike[m] Hi, first time here. Do I ask questions here or where?
15:14 If I have Moha on my server with 1000 books, is there an option or an extension so that logged in visitors can add some books to their own personal virtual libraries on the same server? Like "add to cart" but they permenantly add what they want (something like librarything or so)?
15:15 oleonard wise_mike[m]: Patrons could add existing titles to their own list, but they can't add records to the catalog
15:17 emlam joined #koha
15:18 wise_mike[m] Thanks oleonard for the prompt reply. Yes, only I will add the records. Patrons are like users who can sign up in Koha on my server?
15:19 oleonard wise_mike[m]: Yes. They can sign themselves up if you enable patron self-registration in system preferences.
15:21 wise_mike[m] Another thing, if I imported a marc record for a book, and then import the same book from another source with a little bit of different details, or a different print and cover, does koha give the option to merge them or something, or how it works?
15:22 caroline wise_mike[m], https://koha-community.org/man[…]l#merging-records
15:22 oleonard wise_mike[m]: Yes. MARC imports can have "match points," like ISBN or control number.
15:22 wise_mike[m] great.. thanks
15:29 Joubu cait: added a comment 35548#c5
15:33 cait thx, just stood in the sun a little bit
15:35 oleonard recharging just like a Kryptonian
15:35 cait heh
15:41 paulderscheid[m] back
15:44 cait Joubu++
15:48 Joubu When Jenkins says "all good" for Koha_Master at "the end of a Friday afternoon" (for me!), you should stop pushing :D
15:48 good job, cait :)
15:50 cait I am going to stop pushing anyway, ran out of focus I think
15:51 dashbard is still running - where do you see the "all good"?
15:51 Joubu last line in koha-bots - https://jenkins.koha-community[…]Koha_Master/2821/
15:51 cait oh good :)
15:52 Joubu I didn't check if there was still one running!
15:52 cait on the dashboard it's 5 still running
15:53 Joubu indeed! :D
15:53 cait ... well there is hope at least :)
15:53 I kept Jenkins pretty busy today, maybe it will be too exhausted to keep complaining ;)
15:57 there is more green in koha-bots, but not on the dashboard yet
16:00 ok, now htere is red *chews nails*
16:04 khall_ joined #koha
16:07 davidnind jzairo++
16:07 kellym_++
16:08 oleonard Indeed!
16:08 cait oh, was there an online session?
16:09 oleonard Yep
16:09 cait and I missed it :(
16:10 oleonard cait: Pretty standard stuff :)
16:13 cait k
16:18 davidnind It was Kelly and Jessie covering the basic work flow: using Bugzilla and sandboxes and working through signing off a bug
16:18 cait can't show that often enough
16:19 davidnind++ btw :) and isn't that a strange time for you? are you trying to do GBSD in ALL timezones?
16:19 oleonard Double-check davidnind's work after he's hit about 20 hours online :D
16:20 cait oleonard: I have a report that after our update tot he 22.11 the behaior of the search box changed
16:20 but I am not sure if it was intentional... or what to do about it
16:21 oleonard What's the change?
16:21 cait it says that previous to the new staff interface design, if you clicked into the catalog serach box, it would alredy "mark" the search term, so it was easier to remove or change
16:21 oleonard I don't think that's true
16:22 cait don't have prove yet either
16:22 oleonard Could it have been a customization that was broken by the upgrade?
16:22 cait I don't think so, it would have been me doing that
16:22 doublechecking anyway
16:23 davidnind I'm up early today, watched the ByWater Solutions live session (had a 'nap' yesterday afternoon...)
16:24 cait just make sure you get sleep at some point :)
16:24 oleonard: nothing suspicious
16:26 hm in 16.11 it wuld not even show the search term in the input
16:26 ashimema so lovely to see the koha-bots notifications flooding my screens again 🙂
16:26 cait maybe that is the change?
16:26 oleonard cait: 16.11 is what they were upgrading from?
16:28 reiveune bye
16:28 reiveune left #koha
16:28 cait 20.11
16:28 it was the only older one I ofund lying around right now
16:29 was dreading to reset my master... but probably need to
16:34 wise_mike[m] oleonard:  Can a Patron with his own list of 100 books search just inside his list of books?
16:34 oleonard No
16:36 wise_mike[m] Does koha have extensions for such things? Or a place to suggest such feature?
16:36 cait what are you trying to do?
16:38 bug 33092?
16:38 huginn` 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33092 enhancement, P5 - low, ---, koha-bugs, NEW , Add ability to search within a list
16:39 wise_mike[m] I am setting up koha on my server, adding like specific genre of books, say 1000 books (records). Then open the website to users (I was the could be made patrons so they can add the books they own to their own list).  My question is, if it is possible for a user with list of 50 books for example to search just inside his own list.
16:40 oleonard wise_mike[m]: The link cait posted above links to Koha's bug tracker, where someone has filed an enhancement request for this feature.
16:40 wise_mike[m] * I am setting up koha on my server, adding like specific genre of books, say 1000 books (records). Then open the website to users (I was told they could be made patrons so they can add the books they own to their own list).  My question is, if it is possible for a user with list of 50 books for example to search just inside his own list.
16:40 oleonard The feature hasn't been developed
16:41 cait oleonard: hm reset_all fails for 20.11.19 r
16:41 wise_mike[m] Oh thanks, I though that was answering another question. Thanks
16:46 Can patrons add private notes on a certain book in their list? Or add reviews?
16:47 cait no, but there is also a bug for that
16:47 a very old one I am afraid
16:47 bug 813
16:47 huginn` 04Bug https://bugs.koha-community.or[…]ow_bug.cgi?id=813 enhancement, P2, ---, koha-bugs, NEW , OPAC lists should store comments
16:49 wise_mike[m] Thanks, so I just add a comment there to "revive" it, maybe it would get looked on?
16:49 cait a comment is always good
16:49 but most of Koha#s features are sponsored developments
16:49 so someone paying someone to do the development
16:50 oleonard wise_mike[m]: Patrons can add public comments on books, but not private ones.
16:50 cait a comment can be a good "advertising" reminding people about the idea tho
17:06 kidclamp on master the patron search on the holds page loads patrons before any data is entered, was this intentional?
17:08 oleonard That doesn't look right to me
17:09 * cait hides
17:57 caroline_catlady joined #koha
18:00 oleonard "Your branch and 'origin/master' have diverged, and have 5 and 11716 different commits each, respectively"
18:00 I think that might be a new personal best
18:02 cait wow
18:12 happy GBSD and a nice weekend to you all :)
18:19 cait joined #koha
18:49 jzairo left #koha
18:56 lukeg joined #koha
19:14 caroline_catlady joined #koha
19:21 ashimema WOW... oleonard that's impressive
20:02 NikolayGospodinov[m] Hello! Where in the database the uploaded cover images are kept?
20:02 caroline NikolayGospodinov[m], look in the cover_images table
20:03 NikolayGospodinov[m] thank you
23:23 AndroUser2 joined #koha

← Previous day | Today | Next day → | Search | Index

koha1