inlibro.com 1← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:13 | tcohen joined #koha | |
| 00:32 | tcohen joined #koha | |
| 00:51 | tcohen joined #koha | |
| 01:09 | tcohen joined #koha | |
| 01:28 | tcohen joined #koha | |
| 01:40 | khall joined #koha | |
| 01:46 | tcohen joined #koha | |
| 02:27 | tcohen joined #koha | |
| 02:56 | tcohen joined #koha | |
| 04:39 | JBoyer joined #koha | |
| 04:46 | cait1 joined #koha | |
| 04:47 | tcohen joined #koha | |
| 05:19 | tcohen joined #koha | |
| 05:53 | tcohen joined #koha | |
| 06:12 | tcohen joined #koha | |
| 06:45 | tcohen joined #koha | |
| 07:03 | tcohen joined #koha | |
| 07:04 | reiveune joined #koha | |
| 07:04 | reiveune | hello |
| 07:17 | Joubu | caroline: seen th |
| 07:17 | caroline: seen that? https://gitlab.com/koha-commun[…]rrect-permissions | |
| 07:38 | tcohen joined #koha | |
| 07:54 | cait joined #koha | |
| 07:56 | thibaud_g joined #koha | |
| 07:57 | tcohen joined #koha | |
| 08:01 | cait2 joined #koha | |
| 08:07 | Joubu | @later tell tcohen 34333 comment 12 (!) |
| 08:07 | huginn` | Joubu: The operation succeeded. |
| 08:08 | Joubu | @later tell tcohen I thought we had a test for that... |
| 08:08 | huginn` | Joubu: The operation succeeded. |
| 08:08 | Joubu | 2 hours lost for 2 spaces... |
| 08:14 | tcohen joined #koha | |
| 08:15 | ashimema | morning |
| 08:15 | bug 34333 | |
| 08:15 | huginn` | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=34333 enhancement, P5 - low, ---, tomascohen, Pushed to oldstable , Add cancellation request information embed option to the holds endpoint |
| 08:16 | ashimema | ouch |
| 08:17 | Joubu | ashimema: the spec validator returned 400 with "is not in list" (or something) |
| 08:18 | we noticed yesterday that upgrading JSON::Validator fixed the problem | |
| 08:18 | this commit https://github.com/jhthorsen/m[…]a4b8c541b218e2817 | |
| 08:18 | well, this one: https://github.com/jhthorsen/j[…]288fae8bc9f303199 | |
| 08:19 | but actually it was those 2 spaces in the specs... | |
| 08:19 | anyway, we should upgrade, but for now I don't need it. And we need more tests on our specs! | |
| 08:20 | ashimema | yikes.. |
| 08:21 | not sure when that crept in.. I had it all working when testing.. ☹️ | |
| 08:21 | Joubu | it is working |
| 08:21 | unless you have 2 embeds | |
| 08:21 | ashimema | I've been hit with a few similar cases of late though.. I agree it's really hard to spot these spec pieces |
| 08:21 | ah.. of course! | |
| 08:21 | well found mate | |
| 08:23 | Joubu | those indendation issues are really hard to catch, spent 2 hours yesterday diving in the different changes of mojo lib |
| 08:23 | and found the culprit this morning in 5 min... | |
| 08:23 | ashimema | yeah, they're a nightmare |
| 08:23 | Tomas spotted one for me a couple of days back in a plugin I'm working on | |
| 08:23 | had me poking at it for hours just not seeing it | |
| 08:32 | tcohen joined #koha | |
| 08:50 | tcohen joined #koha | |
| 09:09 | tcohen joined #koha | |
| 09:25 | Joubu | why don't we have a FK on old_reserves.branchcode? |
| 09:29 | tcohen joined #koha | |
| 09:32 | Joubu | bug 35611 |
| 09:32 | huginn` | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35611 major, P5 - low, ---, koha-bugs, NEW , Never use "ON UPDATE SET NULL" |
| 09:32 | Joubu | bug 35610 |
| 09:32 | huginn` | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35610 normal, P5 - low, ---, koha-bugs, NEW , Missing FK on old_reserves.branchcode? |
| 09:32 | Joubu | both in discussion |
| 09:38 | ashimema | I'm interested in tcohens merge of those tables into a 'holds' table |
| 09:39 | Joubu | yes, but this is bugfix ;) |
| 09:39 | that can be fixed quite easily and quickly | |
| 09:41 | @later tell tuxayo willing to have a try at providing a singular/plural version for 35477? I can guide you if needed. | |
| 09:41 | huginn` | Joubu: The operation succeeded. |
| 09:46 | ashimema | excellent |
| 09:47 | tcohen joined #koha | |
| 09:58 | cait2 | where are we with the tests? I still need to catch up on email a bit |
| 10:05 | ashimema | I was aiming to take a look at them shortly cait2 |
| 10:06 | just testing something else I had checked out last thing yesterday before I switch | |
| 10:06 | tcohen joined #koha | |
| 10:09 | cait | ok, I will be around until about 3pm and then be back next Wednesday |
| 10:09 | if we could make it work it wuld be nice, but don't want to rush testing | |
| 10:23 | tcohen joined #koha | |
| 10:30 | ashimema | right.. I'm on them now |
| 10:30 | I'm much happier with how bug 12802 works now 🙂 | |
| 10:30 | huginn` | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=12802 enhancement, P5 - low, ---, aleisha, Needs Signoff , Send notices using several email addresses |
| 10:31 | ashimema | Though I'd love some feedback on the preference.. it feels a bit clunky as is |
| 10:31 | (we still have a 'select all' option, but if you use it, you'll incidentally select 'first valid' which will nuke the other options behind the scenes.. | |
| 10:37 | first one tested and good cait | |
| 10:42 | tcohen joined #koha | |
| 10:46 | ashimema | tuxayo around? |
| 10:54 | cait, I think I'd push Joubu's patch and see what Jenkins does | |
| 10:54 | I'm unable to replicate the failure | |
| 10:58 | tcohen joined #koha | |
| 11:00 | cait | ashimema++ |
| 11:00 | I'll finish lunch and packing and then get to it :) | |
| 11:05 | khall joined #koha | |
| 11:15 | tcohen joined #koha | |
| 11:31 | oleonard | o/ |
| 11:33 | tcohen joined #koha | |
| 11:39 | cait1 joined #koha | |
| 11:52 | tcohen joined #koha | |
| 12:01 | Joubu | oleonard: I have adjusted the branch move_to_modal. It now has the behaviour described in the last commit message. |
| 12:07 | kidclamp joined #koha | |
| 12:13 | tcohen joined #koha | |
| 12:22 | tcohen joined #koha | |
| 12:23 | Joubu | oleonard: there is now also a branch named "move_to_modal-simple" that is kind of working (guarantor search only) |
| 12:25 | but it's not perfect, it is using anchors (and so modify the current window location) | |
| 12:26 | the header of the table is still appearing weirdly even when the modal is closed | |
| 12:26 | could be considered good enough for now however | |
| 12:33 | tcohen joined #koha | |
| 12:39 | tcohen | @later tell mtj we need to upgrade Mojolicious::Plugin::OpenAPI |
| 12:39 | huginn` | tcohen: The operation succeeded. |
| 12:41 | tcohen | Joubu++ |
| 12:46 | marcelr joined #koha | |
| 12:46 | marcelr | o/ |
| 12:47 | tcohen | \o |
| 12:47 | @seen mtj | |
| 12:47 | huginn` | tcohen: mtj was last seen in #koha 2 weeks, 5 days, 0 hours, 10 minutes, and 21 seconds ago: <mtj> yep |
| 12:50 | marcelr | bug 35536 and bug 35548 are ready for testing |
| 12:50 | huginn` | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35536 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Improve removal of Koha plugins in unit tests |
| 12:50 | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35548 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Move KitchenSink test on its own and control table creation | |
| 12:55 | cait1 joined #koha | |
| 12:57 | cait2 joined #koha | |
| 12:57 | magnuse | hello caits! :-) |
| 12:58 | cait3 joined #koha | |
| 13:01 | ashimema | nice one marcelr |
| 13:01 | I'll try and take a look today | |
| 13:05 | marcelr | great ashimema, i am looking now at the nice duplication of x's on the smart rules flatpickr |
| 13:05 | i even saw three now | |
| 13:05 | ashimema | it's weird ain't it |
| 13:07 | marcelr | unfortunately i seem to introduce it lol |
| 13:08 | ashimema | I'm sure I've got it before somewhere |
| 13:08 | but can't fit the life of me remember how I resolved it | |
| 13:08 | marcelr | i remember to have seen it on opac-reserve |
| 13:08 | with the hold dates | |
| 13:08 | cait joined #koha | |
| 13:21 | cait | Is bug 35598 ready too? someone for a quick QA? |
| 13:21 | huginn` | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35598 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , selenium/authentication_2fa.t is still failing randomly |
| 13:21 | tcohen joined #koha | |
| 13:30 | cait | maybe not |
| 13:30 | tcohen: qa for bug 35598? :) | |
| 13:30 | huginn` | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35598 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , selenium/authentication_2fa.t is still failing randomly |
| 13:43 | tcohen | am I online? |
| 13:44 | back to my bouncer | |
| 13:45 | caroline | thx Joubu, will try that :) |
| 13:46 | ashimema | I see you tcohen |
| 13:47 | tcohen | great, thanks |
| 13:52 | caroline | english speakers: "Email address to which to send the email" or "Email address at which to send the email" ? |
| 13:52 | I would say to, but I'm not 100% sure | |
| 13:57 | ashimema | neither are all that clear to me |
| 13:58 | are you talking about 'from' address, or 'to' address? | |
| 13:58 | caroline | yes, the parameter --to for runreport.pl |
| 13:58 | ashimema | I'd go with 'Email address to send from/to' |
| 13:59 | to then | |
| 13:59 | 'Email address to send to' | |
| 13:59 | aude_c[m] | Maybe we should just change the wording to "recipient's email"? |
| 13:59 | ashimema | is it an address.. or a field? |
| 13:59 | caroline | it's an email address |
| 13:59 | runreport.pl --to carolineinlibro.com 1 |
|
| 14:00 | ashimema | whilst we're talking email.. I re-wrote bug 12802 last night 😜 |
| 14:00 | huginn` | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=12802 enhancement, P5 - low, ---, aleisha, Needs Signoff , Send notices using several email addresses |
| 14:00 | ashimema | I final test run/qa run would be nice |
| 14:04 | khall_ joined #koha | |
| 14:05 | Dyrcona joined #koha | |
| 14:10 | cait | ok, I got the one patch, but not the other |
| 14:10 | but have to push now because I am running out of time | |
| 14:30 | oleonard | Joubu: I played around with using a non-Bootstrap modal for the patron preview and I think it works pretty well: https://gitlab.com/koha-dev/ko[…]its/move_to_modal |
| 14:31 | cait | happy christmas holidays everyone :) RM will be back in office on next Wednesday |
| 14:31 | oleonard | \o/ |
| 14:31 | cait | cait might be around in between, but leaving the keys and all here ;) |
| 14:32 | caroline | have a good vacation cait! |
| 14:32 | cait | thank you! |
| 14:32 | cait left #koha | |
| 14:33 | oleonard | Joubu: Maybe you did that in move_to_modal-simple and I just neglected to look :D |
| 14:47 | Joubu | oleonard-away: did you manage to have the nested modals work properly? |
| 14:48 | on the other branch I still use the bootstrap modal for the main modal (search) the a simple modal to display the patron's details | |
| 14:57 | marie-luce joined #koha | |
| 14:58 | Joubu | see you in 2024, #koha! |
| 14:58 | tcohen | wait what |
| 14:59 | ashimema | have a great xmas Joubu |
| 15:10 | oleonard | Joubu: That's what I tried in my branch too. I hadn't noticed your *-simple branch. |
| 15:21 | aw-bib[m] | hello! may I ask if there is a solution to non-english salutations in notices? in German the English Dear Joe, does not really work. I wonder if someone has a better solution than to fall back on neutral formulations without names. (was on the wishlist for our old system, just wondering if I can solve it now.) |
| 15:21 | ShomaizaZafar[m] joined #koha | |
| 15:22 | ashimema | not sure what you mean aw-bib |
| 15:22 | you can write entirely translated notices | |
| 15:22 | caroline | aw-bib[m], you can write whatever you want in the notices. You can also check the installer files to see how the notices are translated in german |
| 15:23 | ashimema | Lieber Joe |
| 15:23 | ShomaizaZafar[m] | can i do modifications in koha and make it unique for my university library ? |
| 15:23 | ashimema | it's open source Shomaiza |
| 15:24 | you can do whatever you like 😜 | |
| 15:24 | aw-bib[m] | sure. but in German I'd need a construction like Sehr geehrte Frau X vs. Sehr geehrter Herr Y. So Miss X vs. Mr. Y and few e may enter the game due to funny German gramar. |
| 15:24 | ashimema | short of code changes though.. you do also have a lot of options exposed to you via system preferences too.. OPACUserCSS and OPACUserJS preferences are incredibly powerful |
| 15:24 | aw-bib[m] | @ashimema Lieber Joe is pretty informal. not sure I would send this to our director in case her loans are overdue ;) |
| 15:24 | huginn` | aw-bib[m]: I'll give you the answer just as soon as RDA is ready |
| 15:24 | caroline | aw-bib[m], just move the <<>> things around in the notice |
| 15:25 | ashimema | I see |
| 15:25 | well | |
| 15:25 | aw-bib[m] | @caroline I fixed the technical part pretty well. it'S more like gramar wehre our funny language distinguishes. |
| 15:25 | huginn` | aw-bib[m]: I'll give you the answer just as soon as RDA is ready |
| 15:25 | ashimema | you can use template toolkit conditionals pretty easily |
| 15:25 | caroline | I don't see the problem then |
| 15:26 | ashimema | assuming you have a borrower field that distinguishes male/female/title? |
| 15:26 | aw-bib[m] | there should be one, yes. |
| 15:27 | ashimema | use [% IF borrower.title == 'Miss' %]Sehr geehrte [% borrower.surname %][% ELSE %]Sehr geehrter [% borrower.surname%][% END %] |
| 15:27 | something along those lines | |
| 15:28 | cait would be best to advice.. I bet she's done it a few times | |
| 15:28 | aw-bib[m] | caroline: in German you'd write `Sehr geehrt_e_` for femal patrons while you'd have to write `Sehr geehrt_er_` for male patrons. |
| 15:28 | ashimema this should good! thank you! | |
| 15:29 | ashimema | 🙂 |
| 15:29 | caroline | aw-bib[m], I see. We have the same in French, but take shortcuts like "Cher(e)... " |
| 15:30 | Or, I usually just change the "Dear" to "Hello"... Bonjour Joe | |
| 15:32 | I try to avoid adjectives as much as possible now, cause you never know how the recipient identifies themselves | |
| 15:33 | (and french is terrible for inclusive language) | |
| 15:34 | aw-bib[m] | . o O ( that is a completely different issue. I am not even sure there is a defined way to address someone in certain cases ) |
| 15:34 | French is a _nice_ language. unfortuntely my French is not very good. | |
| 15:35 | marcelr | ashimema: i am not getting it fixed on 35341 now |
| 15:35 | this is flatpickr magic | |
| 15:37 | ashimema | 😧 |
| 15:38 | marcelr | maybe Joubu can help us out; he is on cc in the bug |
| 15:55 | caroline | Should the "Limit patron data access by group" checkbox in the library group https://koha-community.org/man[…]ml#adding-a-group limit staff inside the group from seeing patrons of other libraries in the group even if they only have edit_borrowers |
| 15:56 | I think I misunderstand what "Limit patron data access by group" does | |
| 15:57 | marcelr | htg |
| 15:57 | bye #koha | |
| 16:00 | bag joined #koha | |
| 16:02 | ShomaizaZafar[m] left #koha | |
| 16:39 | reiveune | bye |
| 16:39 | reiveune left #koha | |
| 18:38 | kathryn joined #koha | |
| 18:38 | kathryn | hello, it's been so so so long since I called in, but I couldn't finish work for the year without at least showing up! |
| 18:40 | lots of good wishes to you all for some nice days off work soon, and holiday celebrations if that's what you do :) | |
| 18:48 | davidnind | merry Chrstmas kathryn! |
| 18:51 | tuxayo | ashimema: hi :) I was afk. «I think I'd push Joubu's patch and see what Jenkins does» +1, even if that doesn't fix the flaky test, "Bug 35600 - Prevent checkouts table to flicker" is totally an improvement. |
| 18:51 | huginn` | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=35600 normal, P5 - low, ---, jonathan.druart+koha, Pushed to master , Prevent checkouts table to flicker |
| 18:51 | tuxayo | seen katrin and jonathan's messages but not yours |
| 19:18 | caroline | happy holidays kathryn! It's nice to see you around here :) |
| 19:38 | marie-luce | Happy holidays kathryn! |
| 19:43 | khall joined #koha | |
| 19:53 | tuxayo | @later tell Joubu "singular/plural version for 35477" I was asking about the coding guideline to know if I should fail QA it or not in regards to that. |
| 19:53 | huginn` | tuxayo: The operation succeeded. |
| 19:55 | kathryn | thanks @davidnind and @caroline :D |
| 20:02 | ashimema | Hi kathryn, happy holidays from this side of the world too |
| 20:27 | kathryn | hey @ashimema thank you, too you! |
| 21:35 | khall joined #koha | |
| 22:55 | khall joined #koha | |
| 23:54 | khall joined #koha |
← Previous day | Today | Next day → | Search | Index
