IRC log for #koha, 2023-10-03

← Previous day | Today | Next day → | Search | Index

All times shown according to UTC.

Time Nick Message
00:17 alohabot joined #koha
01:13 cait joined #koha
05:50 reiveune joined #koha
05:53 reiveune hello
06:12 magnuse \o/
06:43 * dcook waves hi and bye
06:47 davewood good morning, anyone with experience using koha+pressreader (www.pressreader.com) especially the authentication part. users that are logged in at our koha instance should automatically be logged into the pressreader account.
06:53 Joubu @later tell PedroAmorim[m] please QA 32474 as soon as you can
06:53 huginn Joubu: The operation succeeded.
07:02 ashimema morning
07:02 Hi Joubu.
07:02 I just asked if you'd be comfortable me QAing that one
07:02 of course, I'm happy for Pedro to take a look alternatively
07:03 Joubu ashimema: yes, please do! :)
07:03 * ashimema has been excited to see that one move 🙂
07:04 lds joined #koha
07:04 Joubu we need it ASAP, and reuse it from all the other places :)
07:04 ashimema exactly 🙂
07:24 doh.. failing test
07:24 I'll get Matt to take a look
07:25 wish I'd not written bookings prior to vue.. I'm sure some of the stuff I've done would be much nicer in vue
07:28 Joubu Well, new vue stuffs don't get attention :D Not sure it's a good move
07:30 @later tell oleonard aware of "Glyph bbox was incorrect"? 34973
07:30 huginn Joubu: The operation succeeded.
07:33 Joubu ashimema: what's the failing test?
07:33 wahanui the failing test is harmless in terms of functionality
07:37 Joubu ashimema: ok, I get it now, I can have a look
07:45 ashimema I've asked Matt to look first thing once he's about. But feel free if it looks obvious to fix
07:45 Yeah, I think Vue just needs a bit more critical mass. It is moving, but we need to encourage more people to play with it and learn more
07:51 Joubu ashimema: found other things on 32474, I am back on it
07:53 ashimema Tests are good at highlighting stuff 😁
08:00 alohabot joined #koha
08:20 MatthewBlenkinsop[m] I haven't done a full tidy up of the patch yet, wanted to check that we were happy with the fixed behaviour before I rebase it
08:20 If the scroll looks good then I'll write the tests, check the searching is working and implement it in the components where it is needed
08:21 Let me know what you think about the scrolling and then I'll finish the rest off today to submit for sign-off
08:23 Just seen the comments on the bug, scroll seems to be what we expect
08:23 I'll rebase it all this morning and re-submit 👍️
08:28 Joubu MatthewBlenkinsop[m]: please look at the current state!
08:28 I am still working on it
08:28 it's full of bugs :D
08:29 MatthewBlenkinsop[m] Yeah it needs a full rebase
08:29 Joubu we have been too focussed on the pagination and forgot to test the other things
08:29 MatthewBlenkinsop[m]: no it does not, the patches are applying
08:29 MatthewBlenkinsop[m] Do you want me to look at it or are you half way through it?
08:29 Joubu look at the last patches, I am trying to fix a last bug, but I am not sure I will have time to find a correct fix
08:31 MatthewBlenkinsop[m] I'll apply those patches and work on the rest
08:31 Need to check the search filtering is working properly
08:31 Joubu the search filtering is working properly
08:31 the problem is the edition
08:32 MatthewBlenkinsop[m] edition?
08:32 Joubu edit an agreement
08:32 we are no longer fetching the license list when the component is created, so the select does not display the "label" (here the license's name)
08:32 MatthewBlenkinsop[m] Ah ok, I'll work on that
08:32 Joubu there was also a problem with the "required" parameter (it was not possible to save the form)
08:33 so basically, the main purpose of the infinite scroll is working (filtering, pagination, etc.)
08:33 MatthewBlenkinsop[m] I've done something similar in the usage statistics module, should be able to apply that here
08:33 Joubu but we broke everything else :D
08:33 the save/edit/display of the label
08:35 MatthewBlenkinsop[m] Those are the less important things ;)
08:35 I'll work on it this morning
08:37 Joubu MatthewBlenkinsop[m]: please see comment 58 before working on it
08:56 cait joined #koha
08:56 cait hello
09:16 noone here?
09:18 ashimema boo
10:22 cait *jumps*
10:22 oleonard: what does the 'all' class do?
10:22 oleonard joined #koha
10:23 cait oleonard: you have to go out and come back in again after I said your name two more times...
10:23 oleonard :D
10:24 cait (12:22:50) cait: oleonard: what does the 'all' class do?
10:25 oleonard It tells DataTables to never hide the column when being responsive
10:29 Joubu: I've never seen that glyph box message before
10:29 cait thx!
10:32 oleonard davewood: I don't know how your users could be automatically logged in on a separate domain
11:24 cait huh
11:24 internal server error when trying to flip a system preference?
11:24 ==> /var/log/koha/kohadev/plack-error.log <==
11:24 wrong_csrf_token
11:24 at /kohadevbox/koha/svc/config/systempreferences line 132
11:24 CGI::Compile::ROOT::kohadevbox_koha_svc_conf​ig_systempreferences::set_preferences(1) called at /kohadevbox/koha/C4/Service.pm line 254
11:25 has anyone seen this csrf error before?
11:25 hm now it started working again after several page reloads...
11:30 lds joined #koha
11:33 marcelr joined #koha
11:33 marcelr o/
11:44 cait thx for the comments marcelr - I'll try to have a look a litte later -  just got to finish something else first
11:45 could I persuade you to take a look at bug 33898? I am working on the inventory one and that would give us a moment of no real bugs in the QA queue
11:45 huginn 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33898 minor, P5 - low, ---, kyle, Signed Off , background_jobs_worker.pl may leave defunct children processes for extended periods of time
11:49 marcelr hmm i gave some comments there already
11:50 i am still looking at your 14092 right now
11:50 looks almost ready ;)
11:53 cait bug 14092
11:53 huginn 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=14092 enhancement, P5 - low, ---, katrin.fischer, Signed Off , Order search doesn't allow to search for 'all statuses'
11:53 cait ah thx
11:53 folding laundry... much less exciting
11:55 lds joined #koha
12:02 marcelr tcohen 96 in pqa ?
12:09 cait i think the security releases were blocking push
12:11 marcelr: i use a note to pick only my orders - otherwise you'd be right
12:12 marcelr ok sure that the note is unique, lol
12:13 cait well, we could use a random string
12:13 if that makes it more likely - but is the trick in general ok?
12:13 i had troube with orders created by other tests actually
12:13 marcelr it is no blocker for me then but the basketno would be safer
12:13 then you really know it is unique
12:13 cait not a bad idea
12:13 :)
12:14 I'll try to get back to that one too
12:14 marcelr i pasted a diff for you
12:14 you know how to apply it ? with linux patch ?
12:15 cait I'll figure it out
12:15 this one might have to wait for tomorrow
12:15 marcelr if i cant use git to apply a patch, i like to try: patch -p1 --merge --no-backup-if-mismatch -i
12:16 with file name added
12:17 cait sounds helpful for people submitting files too
12:17 when you want to turn them into a real patch
12:59 tcohen[m] good morning
13:00 marcelr o/
13:02 Dyrcona joined #koha
13:04 khall joined #koha
13:33 Joubu so many wrong tiny things after this Ubuntu 20.04>22.04 upgrade...
13:33 marcelr are you using it yourself ?
13:33 * ashimema switched to fedora in the last few weeks.. company challenges meant I couldn't keep endeavour
13:34 ashimema fedora has been remarkable
13:34 marcelr i used fedora long time ago; probably much more problems ashimema
13:34 they are going faster
13:34 ashimema haha
13:34 I've found it to be the most stable distro I've ever user so far
13:34 marcelr i chose the safe debian :)
13:35 ashimema I've done Dedian, Ubunut and Arch (endeavour) so far
13:35 marcelr at that time the libraries of fedora were always much further
13:35 too fast for Koha
13:38 Joubu I had to switch to Ubuntu when I bought a new laptop (I don't remember the details exactly), and I do know remember why I promised myself years ago to stick to debian :D
13:39 marcelr a new laptop is a good reason :)
13:39 Joubu (that's just bad faith, the problems are not OS related and I am sure I would have gotten the same problems with a debian upgrade...)
13:39 ashimema agreed
13:39 marcelr use containers for everything !
13:40 but you must like vim lol
13:42 ashimema that is pretty much my style at this point
14:04 emlam joined #koha
14:14 khall joined #koha
14:54 marcelr bug 34976
14:54 huginn 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=34976 enhancement, P5 - low, ---, koha-bugs, NEW , Encryption keys should not be shared between modules
14:55 marcelr htg
15:05 reiveune bye
15:05 reiveune left #koha
15:46 h2 joined #koha
18:18 caroline are sysprefs supposed to all be in sysprefs.sql?
18:19 I can't seem to find AutoApprovePatronProfileSettings in there, unless I'm really not looking at the right place
18:20 ashimema yes
18:23 emlam try updatedatabase.pl?
18:23 caroline it's in updatedatabase.pl, but not is sysprefs.sql
18:24 that is why I was asking if all of them should be in sysprefs.sql
18:24 emlam ah, I see
20:16 khall joined #koha
20:27 khall joined #koha
21:27 SauloPimentel[m] joined #koha
21:28 SauloPimentel[m] Hello, greetings to everyone
22:11 dcook @later tell cait I haven't seen the csrf issue with sysprefs although the anti-csrf has just been added for it. Tried reproducing your issue but couldn't
22:11 huginn dcook: The operation succeeded.
22:56 alohabot joined #koha
23:45 alohabot joined #koha

← Previous day | Today | Next day → | Search | Index

koha1