![https://matrix.org/_matrix/med[…]JSUbwKj/image.png](https://matrix.org/_matrix/media/v3/download/matrix.org/NgRdDWSVbbKMoRvpiJSUbwKj/image.png){kind=link}
← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:12 | oleonard-away | davidnind: I have a whole file of notes I copy and paste from all day long :) |
| 00:25 | tuxayo joined #koha | |
| 00:30 | davidnind | unless it is something I do regularly (like daily), I need to write things down these days... |
| 00:30 | oleonard joined #koha | |
| 02:22 | bag joined #koha | |
| 06:01 | marcelr joined #koha | |
| 06:01 | marcelr | hi #koha |
| 06:04 | reiveune joined #koha | |
| 06:04 | reiveune | hello |
| 06:17 | magnuse_ | \o/ |
| 07:02 | cait joined #koha | |
| 07:05 | SergioMassa[m] joined #koha | |
| 07:12 | cait | hello #koha |
| 07:15 | ashimema | morning |
| 07:16 | I'm still on consents this morning marcelr.. I looked yesterday, but unfortunately had a bit more support land on my plate than I was expecting ☹️ | |
| 07:17 | it's definitely moving forward though.. I've made a few comments on the bugs.. added a few follow-ups to cookies consent and am working on the rebase and follow-ups to your bug that I feel are needed to get us over the finish line 🙂 | |
| 07:17 | great feature | |
| 07:17 | marcelr | hi ashimema ; great |
| 07:17 | ashimema | I actually really really like the move to plugins.. whilst I love to see things in core.. I think the flexibility this leads to is fantastic.. I can see all sorts of uses for it. |
| 07:18 | marcelr | about the pref, i also added it (cheating a bit) to make a simple condition possible in usermenu.inc instead of counting consent types constantly (performance) |
| 07:18 | ashimema | it'll make pedro happy too.. he's very keen on the idea of koha core + plugins |
| 07:18 | Yeah.. I thought it might be performance related.. I'm sure we can cache the result to help with that. | |
| 07:19 | marcelr | we could do some styling to make the GDPR consent a bit more prominent again |
| 07:19 | and perhaps do a Save button for each consent ? | |
| 07:19 | ashimema | I was just wondering about the save button.. I kind of like it being one for all |
| 07:19 | marcelr | then Cookie consent has no trouble |
| 07:20 | ashimema | I'm still contemplating it a bit |
| 07:20 | marcelr | ok |
| 07:21 | ashimema | the jquery to pre-select radio buttons doesn't appear to be working.. I'm just trying to work out why |
| 07:21 | marcelr | it has worked |
| 07:21 | ashimema | I'm sure it has |
| 07:21 | I totally missed it was there at first to be honest | |
| 07:21 | I have a patch here where I do it the old fashioned way in the template | |
| 07:21 | then i spotted the jQuery and wondered what was going on | |
| 07:23 | aha | |
| 07:23 | content.type vs consent_type | |
| 07:23 | marcelr | nice catch |
| 07:24 | ashimema | oh.. |
| 07:24 | no.. you SET it in one loop.. but not in the other | |
| 07:24 | red herring | |
| 07:26 | marcelr | preselect in document.ready and change in onclick ? |
| 07:27 | no i am looking at wrong spot | |
| 07:29 | toggling consent info when user refuses | |
| 07:30 | ashimema | school run time.. bbiab |
| 08:38 | cait | marcelr: as you are looking at a debarment related patch, there is also 29145 in the QA queue currently, not sure, but there coudl be a conflict |
| 08:39 | actually that one is already PQA | |
| 08:39 | marcelr | nice ;) |
| 08:43 | cait | or not... but I have library really keen on the one in PQA |
| 08:43 | it already missed last release for conflicts | |
| 08:47 | marcelr | sure, we will give tomas a hard time choosing; normally he should push the older one first |
| 08:47 | cait | we'll see |
| 08:50 | * PriyanshuSoni[m] | uploaded an image: (12KiB) < https://matrix.org/_matrix/med[…]JSUbwKj/image.png > |
| 08:51 | PriyanshuSoni[m] | I want to remove this "Home" wala portion, what source code i have to use? |
| 09:28 | cait | why do you want to remove it? |
| 09:28 | but if you do, better to use jquery/CSS in the systempreferences for that | |
| 09:37 | you shoudl not change the source code | |
| 09:37 | usually there is another way of doing things | |
| 09:47 | PriyanshuSoni[m] | Actually i have to set something else on the main block, for that purpose i want to remove that for now. |
| 09:50 | cait | you coudl just hide it using CSS, the page id and the id fro the breadcrumbs section |
| 09:51 | marcelr | htg |
| 09:56 | PriyanshuSoni[m] | <cait> "you coudl just hide it using CSS..." <- is there any coding for that? i tried but couldn't find. |
| 10:01 | cait | what do you mean by coding? do you know CSS? |
| 10:05 | PriyanshuSoni[m] | Yes, i know it. |
| 10:12 | ashimema | marcelr.. did you consider translations for you consent types plugins? |
| 11:02 | cait | PriyanshuSoni[m]: you can put CSS in the OpacUserCSS system preference |
| 11:22 | huberto joined #koha | |
| 11:28 | huberto | Hello everyone. I'm trying to call API methods after using OAuth authentication. Right now I am still using Postman to test requests. I am able to get the bearer token, but once I try to use it, I always get the "Authentication failure" error message while doing any kind of request. |
| 11:28 | What are common pitfalls I should look for when using the API with OAuth? | |
| 11:29 | PriyanshuSoni[m] | <cait> "Priyanshu Soni: you can put..." <- I understand that, tried it but couldn't done. Can you help me with this? |
| 11:39 | oleonard | PriyanshuSoni[m]: Do you want to hide the whole breadcrumbs menu or just the home link? |
| 11:46 | huberto | I found my issue, I was missing "CGIPassAuth On" in my Apache site configuration file. |
| 12:14 | PriyanshuSoni[m] | <oleonard> "Priyanshu Soni: Do you want to..." <- Just that home portion, that shows the navigation. |
| 12:18 | cait | ashimema: the volumes patch makes my brain melt |
| 12:19 | tcohen[m] | hi all |
| 12:19 | didn't notice element wasn't running here | |
| 12:19 | ashimema | ? |
| 12:19 | marc volumes? | |
| 12:19 | confused | |
| 12:19 | tcohen[m] | I was wondering how I was so focused in coding this morning :-P |
| 12:23 | cait | tcohen: PM :) |
| 12:23 | ashimema: the patch you rbased for showing/hiding hte marc volumes link | |
| 12:23 | you asked if 008 was needed and made me fall into a rabbit hole | |
| 12:23 | ashimema | lol |
| 12:24 | hugs | |
| 12:24 | cait | hmpf thx :) |
| 12:38 | oleonard | pastes not coming through automatically? |
| 12:38 | PriyanshuSoni[m]: https://paste.koha-community.org/26195 | |
| 12:50 | tcohen joined #koha | |
| 12:59 | Dyrcona joined #koha | |
| 13:58 | cait | ashimema: I think I got it |
| 14:03 | MatthewBlenkinsop++ | |
| 14:06 | ashimema | 😄 |
| 14:07 | jalway | PriyanshuSoni[m]: There's also this plugin from bywater: https://bywatersolutions.com/e[…]ustomize-the-opac |
| 14:07 | It has some interesting features that make customizing the opac a bit easier. | |
| 14:10 | That's kind of an older post, but we're using the galadriel plugin. | |
| 14:25 | cait | ashimema: ths took way too long... but I think it works not better than before |
| 14:25 | ashimema | ? |
| 14:26 | cait | show volumes |
| 14:26 | ashimema | whats the bug number |
| 14:26 | cait | 26314 |
| 14:29 | ashimema | oh.. does 'not' actually mean 'now' above |
| 14:29 | I thought you were about to fail it | |
| 14:29 | cait | oh yes. |
| 14:29 | I was to fail it but then I fixed it :D | |
| 14:29 | ashimema | hehe |
| 14:31 | thanks | |
| 14:32 | cait | thank you for the patch :) |
| 14:32 | ashimema | do we still need the and ($materialTypeCode='ST' or substring($controlField008,22,1)='m') in the xslt? |
| 14:33 | `<xsl:if test="$show_volumes_link='1' and ($materialTypeCode='ST' or substring($controlField008,22,1)='m')">` | |
| 14:33 | cait | we could maybe remove them, but they don't hurt |
| 14:33 | ashimema | ok |
| 14:33 | cait | you already check for that... so maybe we don't need them |
| 14:34 | ashimema | well.. I'm happy it's PQA |
| 14:34 | cait | me too |
| 14:34 | sorry it took so long | |
| 14:34 | ashimema | no worries.. it happens |
| 14:34 | I really must concentrate on bookings some time soon 😧 | |
| 14:35 | been burning out a bit here lately | |
| 14:35 | jalway | This seem good for removing facet in search results? |
| 14:35 | a[title="SAUORDER"] {display: none !important; } | |
| 14:35 | ^^Added to OPACUserCSS | |
| 14:37 | It seems to do exactly what I want, but just thinking about ways it could cause me troubles. | |
| 14:38 | oleonard | jalway: It looks good to me. It'll leave behind a little bit of padding from the link's container, but not very much |
| 14:38 | jalway: You could add more specificity if you wanted more insurance against the rule applying to something else | |
| 14:39 | for instance .facet-label a[title='SAUORDER"] | |
| 14:40 | jalway | I like that, I'll do that. |
| 14:41 | oleonard: Thanks! | |
| 14:41 | oleonard | You bet! |
| 14:42 | cait | oleonard++ :) |
| 14:50 | oleonard: would you be opposed to adding the advanced search in acq to the navigation? | |
| 14:50 | the other option woudl be adding it to the start page like in serials... and I woudl like that, but we already have some other content there | |
| 14:51 | oleonard | The orders search? |
| 14:51 | cait | libraries use it a lot, but need 3 clicks to open it |
| 14:51 | you go acquisitions > oders search > config icon > advanced search link | |
| 14:51 | yes | |
| 14:52 | oleonard | That sounds like a good idea to me |
| 14:52 | cait | for serials we added the similar thing to the start page |
| 14:52 | which one? | |
| 14:52 | oleonard | Adding the link |
| 14:52 | cait | woudl adding it to the start page be too much change? |
| 14:52 | it would give us consistency with serials... | |
| 14:52 | but not with patrons i guess | |
| 14:53 | hm we do have the filters in patrons on start page | |
| 14:53 | serials formon the start page was quite a hit - that's why I was asking | |
| 14:53 | oleonard | It really depends on how people are using acquisitions. I don't have a good sense of people's workflow |
| 14:54 | cait | caroline: around maybe? |
| 14:54 | caroline | yes |
| 14:54 | ashimema | does anyone fully grok acquisitions 😜 |
| 14:54 | I know I don't | |
| 14:54 | cait | I think we do work quit ea bit with it and this is feedback from mulitple trainings at least |
| 14:55 | caroline: did you see the question or want me tosummarize? | |
| 14:55 | ashimema | we keep talking about a mass cleanup there at ptfs-e... most of our customers really don't like it and sales staff hate demoing it... |
| 14:55 | oleonard | Of the top of my head I imagine a form on the acquisitions home page like the vendor search form, but with a reduced set of fields but with a link to the full form |
| 14:55 | cait | better visibility/less clicks to advanced search in acq |
| 14:55 | ashimema | but.. any time I've really asked for what's wrong with it.. it's another case of they can't think of anything better |
| 14:55 | caroline | let me check, but at first glance I would say go for it |
| 14:55 | cait | or maybe a "more" link to unfold? |
| 14:55 | caroline: start page or navigation? | |
| 14:55 | caroline | What are the options? |
| 14:55 | ok let me go to the page | |
| 14:55 | ashimema | both 😜 |
| 14:55 | cait | I was pondering if we coudl give access right on the start page of acq, similar to patrons and serials |
| 14:56 | it hink if we had on start page we don't necessarily need the lin, because the home link would get you there | |
| 14:57 | caroline | The thing is that with serials, there was nothing on the page, so it was easy to just put the search there |
| 14:57 | but in acq, the page is pretty full already | |
| 14:57 | cait | that's the issue yes |
| 14:57 | bug 33662 btw | |
| 14:57 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33662 enhancement, P5 - low, ---, koha-bugs, NEW , Improve visibility of acq advanced search |
| 14:58 | caroline | I would add a link in the nav along with late order, suggestions, invoices, etc |
| 14:58 | cait | I might do the link? and we give this some more thought? |
| 14:58 | ok | |
| 14:58 | will do that then | |
| 14:58 | caroline | and I would probably also add a search bar under 'Manage orders' |
| 14:58 | jalway | We've been using acquisitions for a long time. That sounds like a nice kind of thing. |
| 14:58 | caroline | with a link to adv search |
| 14:59 | cait | hm don't get the second part |
| 14:59 | Manage orders? | |
| 14:59 | where do you mean? | |
| 14:59 | oh there | |
| 14:59 | it#s a bit of a double up already with the top one... isn#t it? | |
| 15:00 | caroline | on the acq main page, there is a section called 'Manage orders' but there is only a vendor search there... I think an orders search bar could logically go there also |
| 15:00 | I mean, the vendor search is also doubled up | |
| 15:00 | the main search at the top is vendor search and it is also under manage orders | |
| 15:00 | cait | true, but not sure if title/vendor are realyl the most important fields there |
| 15:00 | yeah | |
| 15:01 | oleonard | cait: Do you think users would want the whole form there by default? it's big |
| 15:01 | cait | it is - maye we could make it 2 columns? |
| 15:01 | it's very narrow | |
| 15:01 | I am not sure what I would leave off on first glance | |
| 15:02 | I think I might start with the link and we can keep the discussion open? it would already save 2 clicks | |
| 15:03 | caroline | I think the link in the left nav bar is a great first step, and maybe wait for feedback |
| 15:04 | it's easy to add and doesn't disrupt anything too much | |
| 15:04 | reiveune | bye |
| 15:04 | reiveune left #koha | |
| 15:05 | jalway | That advanced search feature is kind of hard to find . . . |
| 15:07 | cait | caroline++ oleonard++ thx :) |
| 15:11 | oleonard | cait: Here it is with the whole form, two columns: https://snipboard.io/sIeRGL.jpg |
| 15:12 | We could change the "manage orders" heading to "Search vendors" if we wanted to keep it. | |
| 15:12 | cait | it would be more accurate |
| 15:12 | I wonder if these should go on top | |
| 15:12 | a lot of actions in koha start with searching the vendor | |
| 15:14 | oleonard | https://snipboard.io/0q32gN.jpg |
| 15:15 | cait | it feels better - caroline - what do you think? |
| 15:16 | caroline | at first glance I find it a bit big |
| 15:16 | but I definitely prefer the vendor search at the top | |
| 15:17 | oleonard | caroline: How about now? :D https://snipboard.io/5Uy9A4.jpg |
| 15:17 | caroline | LOL! |
| 15:17 | cait | I am just writing the test plan for the link heh |
| 15:17 | did you just make the screenshot smaller? | |
| 15:17 | oleonard | Yes |
| 15:18 | caroline | I was thinking to maybe remove a couple of fields and add a link to the histsearch page? |
| 15:18 | cait | which should we remove? |
| 15:18 | I i am not sure if it#s as useful then... | |
| 15:18 | hard. | |
| 15:19 | maybe we shoudl put the screenshot somewhere and ask around? | |
| 15:19 | caroline | I would leave maybe title, author, isbn, vendor and basket |
| 15:20 | cait | i think invoicenumber... order line number |
| 15:20 | too | |
| 15:20 | we need stats on the most searched ones :) | |
| 15:20 | caroline | I think those are the basic order information... after that I don't think it would be unexpected to click an "advanced search" link to search more advancedly ;) |
| 15:21 | I'll ask marie-luce, maybe she has an opinion | |
| 15:22 | cait | I submitted the link patch for now as it was already written - but I think it's a good discussion to have |
| 15:22 | usability in acq is not great | |
| 15:23 | marie-luce joined #koha | |
| 15:23 | marie-luce | Hi everyone |
| 15:24 | ashimema | what level do we try to get to now regards HTML Validators? |
| 15:24 | html4, html5? | |
| 15:24 | transitional? | |
| 15:24 | cait | i thought xhtml |
| 15:24 | * ashimema | can't work it out from the coding guidelines |
| 15:24 | cait | joking |
| 15:24 | html5 i think | |
| 15:25 | ashimema | the w3 validator doesn't like all our training /> |
| 15:28 | cait | caroline: what do you think about bug 28224? :) |
| 15:28 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=28224 enhancement, P5 - low, ---, koha-bugs, NEW , Make date range for order search configurable |
| 15:28 | cait | or marie-luce? |
| 15:28 | we find that one year is not logn enough, especially with standing orders | |
| 15:29 | caroline | You're talking about the From / To fields? |
| 15:29 | cait | I woud like to make it configurable |
| 15:29 | yes | |
| 15:29 | caroline | like with a syspref? |
| 15:29 | cait | I think yes |
| 15:30 | at elast that's what I could achive the easiest | |
| 15:30 | i wonder what is better, "x years" or a hard date? | |
| 15:30 | days seems a bit overkill | |
| 15:30 | a date would need to be adjusted frequently - but woudl be most flexible | |
| 15:30 | caroline | not a hard date I don't think... you would need to go change it no? |
| 15:31 | marie-luce | a date range search would definitely improve sear |
| 15:31 | caroline | I would copy the one for holds to pull |
| 15:31 | cait | le tme check that one |
| 15:31 | caroline | x days back |
| 15:31 | cait | but that's a lot of days :) |
| 15:31 | but yes, I coudl do that I think | |
| 15:31 | caroline | yes, the default would be 365 |
| 15:31 | cait | and keep the current behaviour if empty |
| 15:32 | caroline | and people could put 720 or whatever 365*2 is, etc |
| 15:32 | cait | they might not match up as nicely then with beginning/end of year then |
| 15:32 | but it gives a lot of flexiblity | |
| 15:32 | (because years have different numbers of days) | |
| 15:33 | caroline | I don,t think people will complain for a one day difference (although I could be surprised... people complain for the smallest things sometimes) |
| 15:33 | cait | I'll keept he curent behaviour if empty... i think we should be on the save side then I hope |
| 15:34 | caroline | Did you find the one for holds? HoldsToPullStartDate |
| 15:35 | cait | yep |
| 15:35 | i am thinking | |
| 15:35 | OrdersSearchFromDate ? | |
| 15:35 | caroline | yeah that's good |
| 15:36 | I still have ads in finnish XD https://snipboard.io/xc2o40.jpg | |
| 15:36 | cait | heh |
| 15:49 | marie-luce | funny :D |
| 15:49 | sorry, I'm back | |
| 15:50 | about the order search form https://snipboard.io/0q32gN.jpg | |
| 15:54 | cait | *curious* |
| 15:55 | marie-luce | The option directly in the acquisition page is practical, but I would prefer seeing less search fields. Maybe we could hide and unfold certains fields |
| 15:55 | cait | I woudl like a less/more |
| 15:56 | marie-luce | yes, it would be easier to see the others features |
| 15:58 | What is the different in the code? Which option is less complicated to code? | |
| 15:58 | cait | not sure I could do it right now |
| 15:58 | oleonard | The "more" link could just point to histsearch.pl |
| 15:59 | cait | it's probably the easisest... could we pass on already filled out options? |
| 15:59 | oleonard | Probably! :D |
| 15:59 | caroline | I was thinking about that, do we still need that page (histsearch) if the form is all on the main page? |
| 15:59 | oleonard | histsearch.pl is also the search results page, so yes |
| 15:59 | cait | we have kept it in serials, but I have been wondering there too |
| 15:59 | ah ok | |
| 15:59 | caroline | ok! |
| 16:00 | oleonard | I think the only difficult question is which fields to keep in the brief version of the form |
| 16:00 | cait | I'll rename the link in a bit - working on bug 28224 still |
| 16:00 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=28224 enhancement, P5 - low, ---, katrin.fischer, NEW , Make date range for order search configurable |
| 16:09 | oleonard | cait is there a bug for adding the full search form to acqui-home? |
| 16:11 | cait | if we keep the link patch around, we shoudl file a new one i think |
| 16:11 | the link is on 33662 | |
| 16:11 | or I coudl move the link and keep that one for the general question? | |
| 16:11 | I am just getting back to that one, what do you prefer? | |
| 16:13 | oleonard | I don't see why we can't have a link in the sidebar and a form on acqui-home, so a separate bug is appropriate |
| 16:13 | cait | ok |
| 16:13 | I can file it | |
| 16:13 | i need to do some clean-up :) | |
| 16:13 | give me 10? | |
| 16:13 | oleonard | Of course, no rush |
| 16:14 | cait | bug 28224 is ready for testing |
| 16:14 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=28224 enhancement, P5 - low, ---, katrin.fischer, Needs Signoff , Make date range for order search configurable |
| 16:20 | cait | oleonard: bug 34805 |
| 16:20 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=34805 enhancement, P5 - low, ---, koha-bugs, NEW , Add order search form to acq start page |
| 16:21 | oleonard | cait++ |
| 16:21 | cait | thx for helping and discussing :) |
| 16:38 | oleonard | Batch patron modification broken? 'Can't call method "category_code" on an undefined value' |
| 16:38 | cait | hups |
| 16:39 | do you have a patron without category? | |
| 16:39 | I'll test in mine, sec | |
| 16:39 | I have the same - looks broken | |
| 16:40 | it looks like it might have to do with the attributes | |
| 16:40 | # If this borrower is not in the category of this attribute, we don't want to modify this attribute | |
| 16:40 | 407: next if $attr_type->category_code and $attr_type->category_code ne $patron->categorycode; | |
| 16:40 | 408: | |
| 16:40 | if the patron attribute pull down is left empty - if I select something, the error is not there | |
| 16:40 | can you confirm? | |
| 16:41 | oleonard | Confirmed |
| 16:42 | cait | can you file? |
| 16:42 | I think i have an idea bout the bug which broke it | |
| 16:42 | looking | |
| 16:43 | 27106 | |
| 16:43 | hm ok not that one | |
| 16:43 | i think i confused it with bug 34257 | |
| 16:43 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=34257 normal, P5 - low, ---, lucas, Pushed to oldstable , Library limitations for item types not respected when batch modding items |
| 16:44 | cait | so I don't have an idea about the bug |
| 16:44 | oleonard | Bug 21083 maybe? |
| 16:44 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=21083 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Batch patron modification does not allow to modify repeatable patron attributes |
| 16:44 | cait | maybe |
| 17:01 | fridolin joined #koha | |
| 17:11 | cait | currently working on bug 14092 if someone is also interested in that :) |
| 17:11 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=14092 enhancement, P5 - low, ---, katrin.fischer, NEW , Order search doesn't allow to search for 'all statuses' |
| 17:11 | * cait | is on an acq bug spree |
| 17:18 | cait | why is Acquisition.t such a mess :( |
| 18:02 | caroline_catlady joined #koha | |
| 18:09 | caroline_catlady joined #koha | |
| 19:00 | oleonard_ joined #koha | |
| 19:15 | caroline joined #koha | |
| 20:10 | cait joined #koha | |
| 21:44 | fridolin joined #koha | |
| 21:50 | fridolin left #koha |
← Previous day | Today | Next day → | Search | Index