← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 06:55 | cait joined #koha | |
| 06:57 | alex__ joined #koha | |
| 06:57 | cait1 joined #koha | |
| 07:02 | alex__ joined #koha | |
| 07:03 | thibaud_g joined #koha | |
| 07:17 | alex__ joined #koha | |
| 08:23 | cait1 | good morning #koha |
| 08:28 | PedroAmorim[m] | o/ |
| 08:28 | ashimema | \0 |
| 08:29 | PedroAmorim[m] | easy bugs to SO/QA are 34058 and 33970 if anyone fancy! |
| 08:29 | cait1 | bug 34058 |
| 08:29 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=34058 enhancement, P5 - low, ---, pedro.amorim, Needs Signoff , ILL - Left filters not considering all terms in input |
| 08:29 | cait1 | bug 33970 |
| 08:29 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33970 enhancement, P5 - low, ---, pedro.amorim, Signed Off , We need a "backend" column in "illrequestattributes" table |
| 08:30 | MatthewBlenkinsop[m] | o/ |
| 08:30 | cait1 | hi all :) |
| 08:30 | PedroAmorim[m]: can you remind me where your nice setup script for ILL lives? I forgot to save it | |
| 08:31 | PedroAmorim[m] | https://github.com/ammopt/koha-ill-dev |
| 08:31 | want to add this to k-t-d at some point | |
| 08:31 | a fresher command sits on bug 34223, it'll install FreeForm+BLDSS backend and generate 10k fake requests for you in a single command (if it works) | |
| 08:31 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=34223 minor, P5 - low, ---, koha-bugs, NEW , ILL status filter does not load immediately after selecting a backend filter |
| 08:38 | cait1 | ooh nice |
| 08:41 | maybe I can reuse that to make one for our backend too | |
| 08:43 | Joubu | PedroAmorim[m]: did you see paulderscheid[m]'s command palette plugin? |
| 08:43 | PedroAmorim[m] | cait1: the fake data generation script uses whatever backends you have installed |
| 08:43 | so that should work for your backend, maybe a couple tweaks missing | |
| 08:44 | Joubu: have not sorry! | |
| 08:44 | Joubu | with "fake data", and the discussion we had a couple of months ago (we talked about koha-jump as well), maybe it's a good candidate for that |
| 08:44 | https://github.com/pders01/koh[…]-palette/issues/3 | |
| 08:45 | PedroAmorim[m] | interesting! |
| 08:45 | litelement fancy | |
| 09:09 | cait1 | would someone be able to take a look at the 2 bugs concerning duplicating patrons? bug 33872 and bug 34117 - I had a bit of a strange feeling there |
| 09:09 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33872 minor, P5 - low, ---, Laura.escamilla, Signed Off , Duplicated patron's registration date is set to expiration date of template patron |
| 09:09 | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=34117 normal, P5 - low, ---, lucas, Signed Off , Duplicate patron sets dateenrolled incorrectly | |
| 09:10 | cait1 | hm that sounded a little odd, I was jut not sure I understood it well enough |
| 09:18 | LibraryHU[m] | hello1 |
| 09:18 | can anyone help me regarding KOHA holdings | |
| 09:19 | I want to active holding of patron like if any user wants to hold a book he could hold it.. can anyone help how to enable this | |
| 09:20 | cait1 | can you rephrase? |
| 09:20 | I don't undesrstand what you want to do yet | |
| 09:20 | what do you mean by hold? checkout or place a hold on it? | |
| 09:29 | ashimema | anyone know how to resolve |
| 09:29 | Attaching to koha-db-1, koha-koha-1, koha-memcached-1 | |
| 09:29 | Error response from daemon: failed to create endpoint koha-memcached-1 on network koha_kohanet: failed to add the host (vethe130b48) <=> sandbox (vethfa28f32) pair interfaces: operation not supported | |
| 09:30 | when starting up ktd? | |
| 09:30 | Joubu | df -h? |
| 09:30 | ashimema | hmm |
| 09:30 | there's still 60G around | |
| 09:31 | so it shouldn't be disk | |
| 09:31 | Joubu | try down then |
| 09:31 | ashimema | already tried that |
| 09:31 | and a full prune | |
| 09:31 | Joubu | I think cait got the same problem yesterday |
| 09:31 | ashimema | oh really.. that's interesting |
| 09:31 | I wonder if there's a docker update that hit | |
| 09:31 | cait | it was a network something issue |
| 09:32 | docker-compose -p koha down | |
| 09:32 | this did the trick | |
| 09:33 | ashimema | I think it might have been a kernel update at my end.. |
| 09:33 | hopefully a restart will do the trick | |
| 09:33 | brb | |
| 10:01 | restart did it.. it was the kernal | |
| 10:02 | anyone using vscode dev containers with ktd as the container? | |
| 10:11 | eythian joined #koha | |
| 10:11 | aw-bib[m] | hello! I just managed to get the base install done using a slightly adopted version of `populate_db.pl` from the koha-misc4dev`to use my settings. diving into this I found that it `INSERTS` the yml-files I pass on, so I can not use a similar chain to change settings after the installation. is there something similar to `$installer->load_sql()` that is using `UPDATE`s or even `INSERT` or `UPDATE` whatever is required or would I need to come |
| 10:11 | up with something myself? | |
| 10:11 | * hello! I just managed to get the base install done using a slightly adopted version of `populate_db.pl` from the `koha-misc4dev`to use my settings. diving into this I found that it `INSERTS`the yml-files I pass on, so I can not use a similar chain to change settings after the installation. is there something similar to`$installer->load\_sql()`that is using`UPDATE`s or even `INSERT`or `UPDATE\` whatever is required or would I need to come | |
| 10:11 | up with something myself? | |
| 10:31 | Joubu | aw-bib[m]: see bug 24912 |
| 10:31 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=24912 enhancement, P5 - low, ---, jonathan.druart+koha, ASSIGNED , Generate sql from yaml installer files |
| 10:32 | Joubu | read the comments please |
| 10:32 | aw-bib[m] | at it :) |
| 10:32 | thanks for the pointer :) | |
| 10:33 | Joubu | IIRC the code there is working in most of the cases but there was an egde case (as always...) |
| 10:43 | cait1 joined #koha | |
| 10:55 | khall joined #koha | |
| 10:57 | khall_ joined #koha | |
| 11:05 | eythian joined #koha | |
| 11:20 | marcelr joined #koha | |
| 11:20 | marcelr | o/ |
| 11:20 | kidclamp joined #koha | |
| 11:26 | alex__ joined #koha | |
| 11:29 | LibraryHU[m] | <cait1> "can you rephrase?" <- i mean how to place a hold on any book |
| 11:31 | cait1 | you need to look at circulation rules then |
| 11:31 | if you want people to place holds on books on the shelf, you need to change the setting for on shelf holds there | |
| 11:39 | cait | t |
| 11:43 | tcohen | hola #koha o/ |
| 11:44 | marcelr | hola tcohen |
| 11:54 | tcohen: you are so fast | |
| 12:06 | cait | he is :) |
| 12:08 | aw-bib[m] | Joubu: I fear the code in bug 24912 has the same issue I have with the installer components. it tries to _INSERT_. If I just try to change a setting I get a `duplicate entry` error from `C4::Installer::load_sql`. |
| 12:08 | I could now go for some scripting that does proper `UPDATE`s, if there is nothing at hand. I'd just prefer to have the settings in some file (aka reproduceable and resetable ;) instead of clicking away. so maybe I am just on a wrong track with those ymls... | |
| 12:08 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=24912 enhancement, P5 - low, ---, jonathan.druart+koha, ASSIGNED , Generate sql from yaml installer files |
| 12:09 | cait | aw-bib[m]: what are you trying to do? |
| 12:09 | aw-bib[m] | just set configs in koha to some values I derive from files (one for each of my koha etc.) |
| 12:09 | cait | did you see the file with local changes? that's an sql file - i add my updates and stuff there |
| 12:10 | aw-bib[m] | you refer to the file where I can pass on parameters during installation, right? |
| 12:10 | cait | maybe let's go a step back |
| 12:10 | what's the use case? | |
| 12:10 | i didn't undestand what you said there :) | |
| 12:11 | usually, you install Koha, the web installer is run, adding data in the language you picked - transforming the YAML files to SQL inserts as you say and traslating them | |
| 12:12 | or maybe you talked to Joubu earlier? I guess I missed something | |
| 12:13 | aw-bib[m] | I have at the moment 3 instances of koha I have to set up. |
| 12:13 | I use a simple script to run through the whole installation including webinstall / onboarding (IOW I can now create any of those instances on my box.) | |
| 12:13 | Now I need to _change_ a few settings here and a few there. I can do this in the web-ui, but I'd prefer to do it from a script that just reads config files. | |
| 12:13 | cait | ok |
| 12:13 | what I do is adding to the custom sql file | |
| 12:13 | to make my changes | |
| 12:13 | aw-bib[m] | to make a simple example: UseControlNumber is set to 0 in instance A but instance A needs it to be 1 instead. (wihthout them knowing that they need it ;) |
| 12:14 | cait | it runs at the end: https://git.koha-community.org[…]ocalization/de-DE |
| 12:14 | so if you amend that file with whatever sql it will be executed | |
| 12:15 | if you just add your update for the pref there it will work | |
| 12:15 | or shoudl | |
| 12:16 | hm if you need different things it gets more complicated I guess - but changing the default of a pref would not work by changing the yaml files anyway - you'd need to change sysprefs.sql | |
| 12:16 | aw-bib[m] | ok, I'd keep the settings in sql then. I had the idea that the yml might be easer to handle. so I went that route. I just stumbled upon the loader for yml to use INSERT statements while I need UPDATE statements as in your sql sample. |
| 12:18 | cait | Joubu does know his scripts better, I have never dabbled with them |
| 12:18 | aw-bib[m] | during installation right now I just feed the proper yml for the instance in question to a sligthly adopted version of populate_db.pl. (just adding a path there is simple enough.) so I thought I could use the same files in to reset the instance in case someone screws it with a mouse ;) |
| 12:19 | cait | i am just confused because the system preferences aren't using yaml files etc. |
| 12:19 | not for loading | |
| 12:19 | but it sounds right when you say that we don't do updates | |
| 12:22 | aw-bib[m] | you're right wrt the systemprefs. I use a koha supplied version so I have them all set properly. hence I'll have to change a few like this UseControlNumber you pointed out to me. |
| 12:22 | cait | hope I didn't make things confing - it's just too warm |
| 12:25 | aw-bib[m] | everything fine. :) |
| 12:25 | it's just before i sharpen vi I tend to fiddle out if not something much cleverer than me already solved the issue. | |
| 12:25 | s/something/someone/ | |
| 12:26 | cait | it's a good approach |
| 12:27 | thibaud_g joined #koha | |
| 12:30 | Joubu | aw-bib[m]: if you don't mind me asking, where are you coming from? I might have missed the info earlier however :) |
| 12:31 | aw-bib[m] | I am from germany, if you refer to my physical location. DESY in Hamburg. |
| 12:32 | Joubu | And so I guess you are migrating DESY's ILS to Koha? |
| 12:53 | ashimema | any idea how someone could be introducing bad marcxml records still? |
| 12:54 | we're getting hit.. a lot.. by bad cat records now we've removed the string cleanup stuff we used to have when fetching metadata | |
| 12:54 | Joubu | are they new records? |
| 12:54 | the search_for_inconsistencies script is supposed to catch them | |
| 12:56 | emlam joined #koha | |
| 12:56 | emlam | o/ |
| 12:57 | ashimema | they're new |
| 12:57 | we've cleaned out all the bad ones.. and the problem just comes back a couple of days later | |
| 12:57 | marcelr | which version ashimema ? |
| 13:00 | Joubu | marcelr: from bug 29697 |
| 13:00 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=29697 enhancement, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, Replace GetMarcBiblio occurrences with $biblio->metadata->record |
| 13:01 | marcelr | ok |
| 13:02 | 22.11 was a brave release ;) | |
| 13:07 | ashimema | mm |
| 13:07 | given we're somehow still introducing stuffed records regularly the removal of StripNonXmlChars from the low level record fetch routines is a mess | |
| 13:08 | marcelr | kidclamp wrote a patch for doing it on import |
| 13:11 | cait | could they be copy/pasting abstracts and stuff? |
| 13:11 | i know a lot of bad chars get in that way usually | |
| 13:12 | so import won't fix it if they manage to add them within Koha | |
| 13:12 | ashimema | I thought we were applying StripNonXmlChars at save time instead.. I should go confirm that |
| 13:13 | Joubu | tcohen: what's the docker thing to NOT install? |
| 13:13 | ashimema: read the first comments of 29697 | |
| 13:13 | I was assuming that some StripNonXmlChars calls were missing, and so we were saved to remove it (IIRC) | |
| 13:15 | Docker Desktop, is that it? | |
| 13:16 | ashimema | I could have swarn we'd implemented the failure on save if bad characters were found ☹️ |
| 13:20 | cait | Joubu: i remember tcohen saying that |
| 13:21 | Joubu | ashimema: see comment 2 for more infos |
| 13:23 | ashimema | >Yes, that's why I was suggesting actually with "Either we assume the MARC::XML that is stored is correct, or we need to add more StripNonXmlChars calls." |
| 13:23 | I don't understand what you're saying here | |
| 13:23 | that we do ensure we clean records on save or fail or what? | |
| 13:23 | Joubu | yes |
| 13:24 | ashimema | LOL |
| 13:24 | Joubu | ? |
| 13:25 | ashimema | are we actually throwing an error on entering a bad record? |
| 13:25 | or | |
| 13:25 | are we cleaning records before saving to we never get them | |
| 13:25 | or.. | |
| 13:25 | are we just ignoring them.. letting them save and then having everything blow up when we fetch them | |
| 13:25 | Joubu | we are not cleaning, never |
| 13:26 | not during import, nor save nor display (except the detail.pl script) | |
| 13:26 | ashimema | I'm pretty confident it's C at the moment |
| 13:26 | OK.. | |
| 13:26 | so this is a huge regression then 😜 | |
| 13:26 | Joubu | not if we explode on saving, and the data are correct in the DB |
| 13:27 | cait | y |
| 13:27 | C? | |
| 13:27 | wahanui | C is for the host |
| 13:28 | Joubu | I am seeing call to StripNonXmlChars in ImportBatch actually |
| 13:29 | ashimema | C was the last of three questions above cait.. we just blindly save bad records then explode when we try to retrieve them again |
| 13:29 | though Joubu said we do 'B' (silently clean up the records before save) in ImportBatch | |
| 13:30 | I feel like we aught to throw an error at the import/save step and get the librarian to deal with the bad characters properly | |
| 13:30 | cait | ah |
| 13:30 | sorry, my brain has melted hours ago... | |
| 13:32 | Joubu | ashimema: can you detail on a bug report what you are getting? how are the record created (cataloguing, import?) and where it explodes? |
| 13:32 | it is supposed to explode everywhere but detail.pl anyway | |
| 13:33 | IIRC we wanted clean records in DB, StripNonXmlChars has not been removed (what I thought) and so should be called when necessary | |
| 13:34 | aw-bib[m] | <Joubu> "And so I guess you are migrating..." <- well the ils in join2 actually. so more than one. |
| 13:36 | khall joined #koha | |
| 13:41 | ashimema | I'm just trying to work out how these bad records are getting in now |
| 13:59 | caroline joined #koha | |
| 14:00 | kidclamp | You can import them - records are not checked/cleaned at that time |
| 14:02 | ashimema | what caught me earlier when writing a quick fix script was that you can't even fix a bad record if CatalogLog is on |
| 14:04 | Joubu | kidclamp: aren't the StripNonXmlChars calls in C4::ImportBatch there for that purpose? |
| 14:07 | kidclamp | I would need to look at that more |
| 14:07 | but my impression is our libraries are getting this from imported files | |
| 14:08 | ashimema | all biblio manipulation goes through C4/Biblio methods still right? |
| 14:08 | I'm looking at adding some debugging in as low as I can to work out how these bad records are creeping in. | |
| 14:10 | kidclamp | those look to be for items/and sotring oldxml |
| 14:10 | nothing thouching the incoming | |
| 14:10 | Joubu | one might be missing before AddBiblio |
| 14:10 | l.619 | |
| 14:10 | ashimema | No? Isn't AddBiblio still the mummy of adding new records? |
| 14:11 | oh.. sorry | |
| 14:11 | cross chat | |
| 14:12 | yeah.. may be worth adding one to line 595 | |
| 14:12 | though.. it's 'from_usmarc' | |
| 14:12 | Joubu | or explode :D |
| 14:13 | because we are not important "as it", and maybe we want to alert the user? | |
| 14:14 | ashimema | indeed |
| 14:14 | that's where my mind goes.. I'd like to report bad records before they ever reach the system | |
| 14:14 | rather than try a 'magic fix'.. | |
| 14:14 | though I wouldn't be against magic fix + report with diff of what the magic fix did | |
| 14:19 | Dyrcona joined #koha | |
| 14:22 | kidclamp | I like the idea of trying to recover when we hit it |
| 14:22 | itf we prevent it, then we never hit that code, but it is still there in case of strange things happening | |
| 14:22 | which always happen with data | |
| 14:22 | bug 33270 | |
| 14:22 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=33270 major, P5 - low, ---, nick, Failed QA , OAI-PMH should not die on record errors |
| 14:22 | ashimema | Yeah.. I like your approach on 33720 mostly.. I'd just like to see it at a lower level |
| 14:23 | kidclamp | isn't it pretty low at 33270? |
| 14:23 | ashimema | lol |
| 14:23 | kidclamp | Koha::Biblio::Metadata |
| 14:25 | ashimema | I think I'd like to see it built back right into ->record and the errors recorded from there. |
| 14:25 | so one doesn't even have to think about ->record_strip_nonxml | |
| 14:26 | kidclamp | I am okay with that |
| 14:29 | Joubu | well, the idea was to do it only when needed, on import/create |
| 14:29 | if we assume that records are correct in the DB we should not need that | |
| 14:30 | tcohen: why don't we have the usermod command in ktd's README to add the user to the docker group? Isn't it needed? | |
| 14:30 | tcohen: sudo usermod -aG docker $USER | |
| 14:31 | alohabot joined #koha | |
| 14:33 | emlam | cait still around? |
| 14:37 | marcelr | yes, we should not need to do record mangling each time in ->record imo |
| 14:38 | apart from the question if we should do it all together | |
| 14:39 | ashimema | I'd love to see it done on save (both edit and add) instead |
| 14:39 | i.e the other end | |
| 14:39 | but I'm not 100% we'll ever catch all cases? | |
| 14:45 | kidclamp | ^ that |
| 14:45 | it doesn't hurt to start trying to handle it on import - but, we should always have a way to display/fix when things do get broken | |
| 14:46 | i.e. the user should be able to handle when things go wrong | |
| 14:48 | ashimema | as part of that, we'll need to add some smarts to here: https://git.koha-community.org[…]blio.pm#L372-L375 |
| 14:57 | cait left #koha | |
| 15:00 | bag joined #koha | |
| 15:38 | marie-luce joined #koha | |
| 15:39 | emlam | @later tell cait I see what you mean about bugs 33872 and 34117. I can't track it down for sure, but I think there may be an underlying reference-passing bug when memberentry.pl calls get_expiry_date |
| 15:39 | huginn | emlam: The operation succeeded. |
| 15:53 | khall_ joined #koha | |
| 16:42 | cait joined #koha | |
| 16:50 | bag joined #koha | |
| 17:06 | khall joined #koha | |
| 18:31 | Dyrcona joined #koha | |
| 19:37 | khall joined #koha | |
| 20:44 | khall joined #koha | |
| 21:13 | khall joined #koha | |
| 21:16 | khall joined #koha | |
| 22:37 | aleisha | hello |
| 22:52 | jo joined #koha | |
| 23:08 | jo joined #koha |
← Previous day | Today | Next day → | Search | Index