← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:32 | tuxayo | Hi davidnind aleisha rangi[m] Wainui dcook mtj would the 25th at 22:00 UTC be a good date for a dev meeting in your timezone? The 26th 11:00 for Aotearoa/NZ and the 26th 9:00 for Sydney |
| 00:33 | We skipped a few weeks of planning so we have not next meeting planned after the one this week | |
| 00:34 | dcook | tuxayo: Jan 26th is a public holiday in Australia and I'll be off anyway |
| 00:36 | tuxayo | How about the 19th? |
| 00:36 | thanks for the info dcook | |
| 00:54 | dcook | tuxayo: I'll be on holidays hehe |
| 00:54 | I'm on holidays a lot in January, so don't worry about me | |
| 01:15 | bug 32481 | |
| 01:15 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=32481 critical, P5 - low, ---, dcook, Needs Signoff , Rabbit times out when too many jobs are queued and the response takes too long |
| 01:15 | dcook | I feel so bad for not posting the right patch the first time... :| |
| 01:55 | tuxayo | dcook: a lot of patches aren't the right ones the first time ;) |
| 01:55 | dcook | True enough haha |
| 01:55 | At least I fixed my own mistake... | |
| 01:56 | tuxayo | Most cause more subtle issues and end up in production and require follow-up patches |
| 01:57 | Here it didn't pass the SO stage. | |
| 06:45 | Theodoros joined #koha | |
| 06:51 | fridolin joined #koha | |
| 06:51 | fridolin | yellow |
| 07:42 | reiveune joined #koha | |
| 07:57 | cait joined #koha | |
| 08:00 | cait1 joined #koha | |
| 08:15 | thibaud_g joined #koha | |
| 08:17 | fridolin left #koha | |
| 08:24 | thibaud_g joined #koha | |
| 08:25 | thibaud_g joined #koha | |
| 08:37 | cait1 | hello #koha |
| 08:53 | alex_ joined #koha | |
| 08:59 | magnuse | \o/ |
| 09:28 | reiveune left #koha | |
| 09:32 | paulderscheid[m] | Morning #koha |
| 09:36 | cait1 | morning paulderscheid[m] |
| 09:36 | paulderscheid[m] | o/ |
| 10:33 | ashimema | Morning |
| 11:31 | cait1 | morning ashimema |
| 11:37 | oleonard | Hi all |
| 11:39 | cait1 | hi oleonard :) |
| 11:48 | khall++ thx :) | |
| 11:58 | tcohen | hola #koha o/ |
| 11:58 | cait1 | hola tcohen :) |
| 12:29 | jzairo joined #koha | |
| 12:31 | paulderscheid[m] | Hi tcohen, could you point me to a resource that shows api permission management? |
| 12:52 | marcelr joined #koha | |
| 12:52 | marcelr | hi #koha |
| 12:53 | cait1 | happy new year marcelr :) |
| 12:53 | marcelr | hi cait |
| 12:54 | tcohen around? | |
| 12:58 | tcohen | \o |
| 12:58 | happy new year | |
| 13:00 | it does the right thing Nemo_bis nice | |
| 13:02 | thibaud_g joined #koha | |
| 13:09 | paulderscheid[m] | Is https://api.koha-community.org/ down? Doesn't respond. |
| 13:11 | cait1 | paulderscheid[m]: works for me - maybe fixed now? |
| 13:11 | paulderscheid[m] | Yeah, it loads now. |
| 13:12 | Took forever, though. | |
| 13:13 | Nevermind tcohen, forgot about the api docs. Was searching the wiki... | |
| 13:44 | marcelr | hmm just found that my rabbitmq was only polling default queue :) |
| 13:44 | so the long tasks were really taking loooooooonggggggggggg | |
| 14:15 | caroline | yall, we have two new interns. If you have easy signoffs for people who don't know koha that much, let me know |
| 14:19 | marie-luce joined #koha | |
| 14:20 | cait1 | caroline++ |
| 14:20 | * cait1 | always recommends oleonard's |
| 14:21 | caroline | yeah I usually look at his first too :) |
| 14:21 | maybe lukeg's too since it's a lot of visual stuff | |
| 14:29 | oleonard | Bug 32507 will require many many simple follow-up patches to fully implement, so that will be a good source of work if looks good to QA |
| 14:29 | huginn | 04Bug https://bugs.koha-community.or[…]_bug.cgi?id=32507 enhancement, P5 - low, ---, oleonard, Signed Off , Use template wrapper to build breadcrumb navigation |
| 14:31 | caroline | So it's not really "Signed off" is what I understand? |
| 14:31 | oleonard | It is. The bug lays the groundwork for further changes. |
| 14:32 | (on separate bugs, so not follow-ups in the strict sense) | |
| 14:32 | caroline | ah ok! |
| 14:33 | * ashimema | can jump on QA of that if you like |
| 14:34 | oleonard | ashimema: I'm eager to see if I'm being smart or just think I am :D |
| 14:48 | ashimema | works for me oleonard |
| 14:48 | should help with consistency a little I imagine | |
| 14:50 | it's a clear example of using WRAPPER too.. which is nice | |
| 14:51 | we could add a QA test looking for id="breadcrumb" additions to prevent new cases creeping in. | |
| 14:51 | my only against is, is it worthwhile 😜 | |
| 14:51 | it saves us a few lines on each page.. I suppose lines saved = less lines to get wrong.. | |
| 14:52 | and it allows for a consistency improvement should we ever want to rework the breadcrumb in any way away from 'nav' or whatever.. | |
| 14:54 | caroline joined #koha | |
| 15:02 | oleonard | That's the idea ashimema: Using this kind of construction means we can upgrade Bootstrap without changing breadcrumb markup in multiple files |
| 15:05 | lukeg joined #koha | |
| 15:08 | thibaud_g joined #koha | |
| 15:11 | thibaud_g joined #koha | |
| 15:13 | thibaud_g joined #koha | |
| 15:16 | thibaud_g joined #koha | |
| 15:17 | matts joined #koha | |
| 15:18 | thibaud_glt joined #koha | |
| 15:42 | thibaud_glt joined #koha | |
| 15:49 | thibaud_glt joined #koha | |
| 15:52 | reiveune joined #koha | |
| 15:53 | thibaud_glt joined #koha | |
| 15:57 | ashimema | Ah, excellent.. I see.. well worthwhile then |
| 15:59 | thibaud_g joined #koha | |
| 16:00 | bag joined #koha | |
| 16:05 | Dyrcona joined #koha | |
| 16:07 | thibaud_glt joined #koha | |
| 16:16 | thibaud_glt joined #koha | |
| 16:23 | thibaud_g joined #koha | |
| 16:25 | thibaud_glt1 joined #koha | |
| 16:26 | thibaud_glt1 joined #koha | |
| 16:29 | thibaud_glt joined #koha | |
| 16:39 | lukeg joined #koha | |
| 16:46 | thibaud_g joined #koha | |
| 16:50 | lukeg joined #koha | |
| 16:55 | thibaud_g joined #koha | |
| 16:56 | thibaud_g joined #koha | |
| 16:59 | thibaud_g joined #koha | |
| 17:05 | thibaud_g joined #koha | |
| 17:19 | thibaud_g joined #koha | |
| 17:54 | cait1 left #koha | |
| 19:23 | drbone joined #koha | |
| 19:56 | cait[m] | caroline: keep fingers crossed? about to run translations |
| 19:58 | * caroline | crosses fingers |
| 19:58 | cait[m] | 2502 "%s Default: %s system preference %s Default: ILLDefaultStaffEmail system " |
| 19:58 | 2503 "preference %s " | |
| 19:59 | caroline | that looks good! Are the other pesky lines there? |
| 19:59 | cait[m] | it seems that it turned into: 32821 msgid "ILLDefaultStaffEmail" |
| 19:59 | which is at least better? | |
| 19:59 | caroline | ok well that's not too bad |
| 19:59 | it's definitely better | |
| 20:00 | cait[m] | I'll upload my follow-up |
| 20:03 | copied from here: https://bugs.koha-community.or[…]ent.cgi?id=133381 | |
| 20:04 | caroline | oh cool you managed it! I tried adding spans, but somehow it didn't work for me... must have done something wrong. I'm glad it worked for you! |
| 20:05 | cait[m] | i tihnk it's also that we hcanged to block from set |
| 20:05 | maybe | |
| 20:05 | caroline | hm, getting sha1 error |
| 20:05 | cait[m] | oh |
| 20:05 | let me reattach both, only uploaded the second | |
| 20:05 | caroline | it may be me also |
| 20:06 | cait[m] | try a git pull first to make sure |
| 20:07 | I'll be around - but trying not to burn the cookies in the oven :) | |
| 20:07 | caroline | i pulled and also reset hard just to make sure |
| 20:07 | ok it applied! testing now :) | |
| 20:10 | lukeg joined #koha | |
| 20:13 | cait[m] | fingers crossed |
| 20:13 | brb | |
| 20:35 | caroline | I feel like a newbie, but what is the command to sign-off more than one patch? I usually do git commit --amend -s but it only signed off the last one |
| 20:36 | cait[m] | git so 2 |
| 20:36 | where 2 is the number of patches | |
| 20:36 | if you are using ktd? | |
| 20:37 | caroline | no I just have a normal git |
| 20:38 | is it suppoed to look like this? https://snipboard.io/Y6fGdS.jpg | |
| 20:41 | I don't think I did it correctly... | |
| 20:41 | cait[m] | if you have normal git you could still add that git alias I think |
| 20:41 | I haven' tseen that screen yet | |
| 20:42 | I could fix your lines if you want? | |
| 20:42 | last batch of cookies is in now | |
| 20:42 | caroline | I'll try applying one at a time maybe and singing off each individually |
| 20:43 | cait[m] | I ofund this on the wiki: git rebase -x 'git trailer-add "Thanks-to" "everybody involved in this bug"' HEAD~X # where X is the number of commits you want to rewrite |
| 20:43 | i tihnk you could change "Thanks-to to your full sign-off lin | |
| 20:43 | e | |
| 20:44 | but haven't tried it | |
| 20:45 | caroline | I was able to apply/signoff each individually, but I can't seem to attach them, it says it's too big? |
| 20:45 | cait[m] | hm odd |
| 20:45 | not really big | |
| 20:45 | caroline | it also asks me Rewrite the commit add the bug URL anyways? [yn] y which I've never seen before |
| 20:45 | cait[m] | what was your command? |
| 20:45 | maybe you got too many ocmmits involved | |
| 20:46 | caroline | I'll try saying no |
| 20:46 | cait[m] | git bz attach -e 31957 HEAD~2.. |
| 20:47 | caroline | ah! I think i forgot the two dots |
| 20:47 | sorry! It's ok now! | |
| 20:50 | cait[m] | caroline++ thank you |
| 20:50 | there is a nother bug that is very similar, I'll rework it in the same fashion | |
| 20:50 | emlam joined #koha | |
| 20:50 | caroline | no thank you for correcting it! cait++ |
| 21:05 | cait if i'm not already on the other bug, you can cc me and I'll test | |
| 21:05 | or ping me here | |
| 21:05 | cait[m] | will do, thanks! |
| 21:20 | caroline: patch on 30993 is ready now too | |
| 21:20 | caroline | ok! |
| 21:22 | other than https://wiki.koha-community.or[…]elopment_workflow is there a page that details each bz status? | |
| 21:22 | cait[m] | hm I think that might be the one |
| 21:24 | caroline | ok! Solene is a bit lost with all the statuses |
| 21:25 | cait[m] | I also found https://wiki.koha-community.or[…]gn_off_on_patches - but we are not even mentioning setting to failed qa |
| 21:25 | I'll at least fix that ... | |
| 21:26 | caroline | I noticed the commands on that one are not the same as on the git-bz page |
| 21:26 | cait[m] | ah.. it's in the note at the top |
| 21:26 | we really need to do some clean-up and consolidation on the wiki... just not sure yet how to do it best | |
| 21:28 | caroline | I think solene was following that page at the start and she was trying to create a branch bug_xxxx to test... I was like you don't need to do that? But then that's exactly what it says |
| 21:28 | cait[m] | you can name your branch whatever |
| 21:29 | was she doing "option 3" manually? | |
| 21:29 | caroline | I don't create a branch except when I'm creating a patch, I just git bz apply |
| 21:29 | cait[m] | on master? |
| 21:29 | caroline | yeah, is that bad? |
| 21:29 | cait[m] | that's at leas tnot the recommended way of doing things :) |
| 21:30 | caroline | oops! |
| 21:30 | cait[m] | I always do a branch - but I am not sure I can tell you why one is better than the other |
| 21:30 | having a separate branch allows me to switch back and forth if I want to | |
| 21:30 | caroline | I've always done it that way... |
| 21:31 | cait[m] | where are all those devs when you need them? |
| 21:31 | caroline | drinking beer? |
| 21:31 | cait[m] | it's a good guess |
| 21:48 | caroline | cait[m], don't hesitate to cc me on translation strings bugs in the future (or translation context) |
| 21:49 | cait[m] | will do, thanks caroline |
| 22:53 | lukeg joined #koha | |
| 23:05 | tuxayo | hi #koha :) |
| 23:10 | > I don't create a branch except when I'm creating a patch, I just git bz apply | |
| 23:11 | caroline: It can totally work as long as you don't forget to reset it before trying to get the last changes from main/master and apply another patch. With another branch you still have to remember to move back to main, update it and create another branch. So whatever is the less confusing for you. |
← Previous day | Today | Next day → | Search | Index