IRC log for #koha, 2022-09-26

← Previous day | Today | Next day → | Search | Index

All times shown according to UTC.

Time Nick Message
00:31 bone joined #koha
05:54 reiveune joined #koha
05:55 reiveune hello
06:30 saa joined #koha
06:30 saa No such column 'invoicenumber' on Koha::Schema::Result::Item at /usr/share/koha/lib/Koha/Object.pm line 79: /usr/share/koha/intranet/cgi​-bin/acqui/finishreceive.pl
06:31 after upgrading koha and while using acquisitions module we are getting above error
06:31 what could be wrong
06:52 paxed why is this:
06:52 koha-tmpl/intranet-tmpl/prog/e​n/modules/catalogue/detail.tt:           <span class="results_summary itemtype"><span class="label">Itemtype:</span>
06:52 instead of being in xslt?
06:52 all the other detail info comes via xslt
07:00 alex_ joined #koha
07:00 cait joined #koha
07:01 alex_ Bonjour
07:02 cait1 joined #koha
07:03 lds joined #koha
08:04 liliputech joined #koha
08:05 liliputech hello there, anyone can give me again the link to the form to request a branch for translations? thx!
08:05 happy kohacon btw
08:22 oleonard joined #koha
08:23 oleonard Hi #koha
08:30 Oak joined #koha
08:43 ashimema liliputech: see PM
09:01 liliputech thx ashimema
09:11 cait1 liliputech: kohacon was last week :)
09:12 oleonard o/
09:12 cait1 hi oleonard
09:12 wahanui hi oleopard
09:30 JBoyer joined #koha
10:25 ashimema joined #koha
10:31 rangi[m] joined #koha
10:43 oleonard Anyone around who knows how the HOLD_REMINDER notice works? I assume it requires a cron, but how does it time the reminder?
10:55 cait1 oleonard: i think there is a preference and a messaging setting
10:57 hm,
10:59 oleonard: it looks like it#s set in the holds_reminder.pl cron
10:59 --days parameter
11:00 oleonard Ah, thank you cait1
11:03 Bug 29154 is a bummer
11:03 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=29154 normal, P5 - low, ---, koha-bugs, NEW , Add hold cancellation reason to Holds Awaiting Pickup page
11:08 tcohen hola #koha
11:17 oleonard Hi tcohen
11:18 tcohen recovered, oleonard?
11:18 :-D
11:18 oleonard It wasn't too rowdy :D
11:19 Lovely to see everyone there of course. That's the best part of any get-together
11:20 tcohen :-D
11:21 cait1 sad to have missed it, but glad you al had such a good time
11:21 was impressed by the organisation!
11:22 tcohen saa: have you solved your issue? What Koha version?
11:22 cait1: indeed
11:23 oleonard It really was a very well-run conference
11:24 tcohen kohacon++
11:24 cbrannon++
11:26 oleonard tcohen: I wasn't able to get a lot of feedback from librarians about the staff interface redesign but the feedback I did get was quite positive
11:26 tcohen awesome :-D
11:28 oleonard I think the default font is the biggest issue to be resolved, but I'm convinced now that it should be possible to get this into 22.11
11:30 ashimema I agree oleonard
11:30 we're so very close I reckon it's a goer for this cycle..
11:31 though I also reckon sooner rather than later to let follow-up polishing happen with a wider group for coding input..
11:31 like I'm waiting for this to allow me to persue the cataloging home page refresh I'm working on..
11:32 and I'm also keen to submit some other little UI consistency improvements I think the refresh highlights more
11:33 liliputech joined #koha
11:34 oleonard Agreed on all points ashimema
11:36 tcohen my feeling is we should push it first thing on next cycle, I'm more concerned about the ERM module status right now
11:37 ashimema ah... OK.. if we do that my customers won't get access to it for at least 18 months... ☹️
11:37 no...
11:38 more like 24 months
11:38 we're a .11 shop
11:38 oleonard :O
11:39 ashimema and tend to start jumping around the xx.11.04 ish release of any given cycle
11:39 though we do have a mix of early and later adopters of course..
11:39 but yeah...
11:39 tcohen hmm
11:39 ashimema we're keen for both ERM and the new staff CLI
11:39 tcohen we still have two months
11:39 ashimema (in fact.. my boss is also keen for Bookings.. but I've just not had enough time to work on that one yet)
11:40 tcohen I'm keen on external OAuth2/OIDC which already has a configuration UI
11:40 heh
11:40 ashimema there's been a lot of momentum to fix up the staff ui the last few weeks.. I'm really impressed how far it's come honestly
11:40 hehe.. nice one
11:41 * ashimema really should concentrate on migrating his current systems.. the old computers are getting wiped this evening!
11:41 tcohen good plan
11:42 * tcohen shifts to monday morning duties, then refresh his local copy of the staff interface revamp
11:50 Oak joined #koha
11:57 davidnind[m] joined #koha
11:57 domm[m] joined #koha
11:57 Lea[m] joined #koha
11:57 KodoKorkalo[m] joined #koha
11:57 mtj[m] joined #koha
11:57 paulderscheid[m] joined #koha
11:57 SlackIntegration[m] joined #koha
11:57 SushiJames[m] joined #koha
11:57 tubaclarinet[m] joined #koha
11:57 tuxayo joined #koha
11:57 tcohen jajm: good morning, could you fix t/db_dependent/Koha/SearchEngin​e/Elasticsearch/QueryBuilder.t please?
11:58 let me know if you can work it out today
12:03 jajm tcohen: hi, can you give me a little bit more info ? like which commit broke the tests for instance
12:06 tcohen heh
12:07 yeah, it's the ES availability
12:07 filtering
12:07 bug 25375
12:07 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=25375 normal, P5 - low, ---, julian.maurice, Pushed to master , Elasticsearch: Limit on available items does not work
12:17 tcohen #koha please help fixing failing tests in the Koha_Master task (jenkins). the lack of notifications has made it hard to tell devs to take care of them
12:18 mtj[m]: has anything changed re Test::Mechanize::WWW packaging?
12:18 same for ES deps: ES6 and ES7 tasks are mostly failing recently
12:19 mtj hi tcohen, hmm, not that i know of re: test-mech-www
12:19 tcohen search_utf8.t was passing on 277e19bd10a1e2f2ae39b50e25f58c9938d1a2c3
12:20 but I don't manage to make it pass locally, so I was blaming deps?
12:20 pastebot "tcohen" at 127.0.0.1 pasted "mtj: to reproduce" (4 lines) at https://paste.koha-community.org/15403
12:21 ashimema it's not related to the quoting test that's failing in QueryBuilder.t is it?
12:22 tcohen the test is expecting onloan:false and it is getting available:true
12:22 ashimema ooh.. ooh
12:22 tcohen that's why I pointed that patch i.e. the patch is correct, just missed to update the test
12:22 ashimema coolios
12:24 tcohen mtj[m]: did we change smth related to HTTP::MEssage?
12:24 mtj no changes since dec 2020 https://tracker.debian.org/pkg[…]ww-mechanize-perl
12:24 tuxayo > but I don't manage to make it pass locally
12:24 search_utf8.t might one of those test that never passed locally for me since at least 20.05
12:25 Even though it passed on the CI
12:26 tcohen for me, it is failing to login, I dumped $agent->content and there's the login form again, when it should have the main staff page
12:26 mtj i do have a fix for this bug  https://jenkins.koha-community[…]Build/testReport/
12:26 tcohen \o/
12:26 tuxayo Wait, I mixed up with other tests.
12:26 search_utf8 was okay
12:26 It's
12:26 t/db_dependent/www/auth_values_input_www.t
12:26 t/db_dependent/www/batch.t
12:27 t/db_dependent/www/history.t
12:27 t/Logger.t
12:28 tcohen they pass for me
12:28 ah, batch doesn't
12:28 tuxayo Hum, I have search_utf8.t in my ktd shell history along the above ones so maybe it failed also.
12:29 MarkHofstetter joined #koha
12:31 mtj tcohen: the short version for the failing sele/patrons.t bug is related to bug 31565
12:31 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=31565 normal, P5 - low, ---, lari.taskula, Pushed to master , Patron search filter by category code with special character returns no results
12:32 mtj this patch was the problem... https://bugs.koha-community.or[…]ent.cgi?id=140758
12:32 ...its stripping _ / & chars from search queries
12:33 ...but patron.t test is using those chars in its test queries :/
12:34 to fix.. i changed patron.t to not use those chars
12:34 cait1 I think it woudl be great to have the new UI... and the ERM module
12:34 but i means we need to gain some speed now and make it happen soon
12:35 and yep, I think the font and maybe the toolbar contrast are the the most urgent remaining ones
12:35 mtj another possible fix could be to \escape\ the problimatic chars too
12:36 tcohen thanks, mtj, will think about it
12:37 mtj tcohen: ill send a patch in 10
12:38 tcohen \o/
12:48 ha! porting things to background jobs...
12:49 mtj tcohen: 31565 patch sent
12:49 jajm tcohen: here's the fix: https://bugs.koha-community.or[…].cgi?id=25375#c42
12:49 huginn` Bug 25375: normal, P5 - low, ---, julian.maurice, Pushed to master , Elasticsearch: Limit on available items does not work
12:50 mtj ..its basically a lazy s|_|.| on all queries
12:51 Dyrcona joined #koha
12:52 tcohen jajm++
12:52 mtj++
12:54 mtj tcohen++
12:54 jajm++
12:56 tcohen we've got a serious problem with the background jobs and tests
12:56 as callbacks are being sent to rabbitmq on biblio actions (and many others)
12:57 but the rollback makes the tasks not exist
12:57 it might not be that serious after all, but I feel like some failures are due to this
12:58 and it will get worse until we get some more synchronous actions
12:58 for testing env
13:10 jajm tcohen: can https://bugs.koha-community.or[…]_bug.cgi?id=19821 help to solve this ? (use dedicated database for tests and stop using rollback - it would probably make tests faster too :))
13:10 huginn` Bug 19821: enhancement, P5 - low, ---, jonathan.druart+koha, CLOSED FIXED, Run tests on a separate database
13:12 tcohen that's a big change
13:13 it's in master
13:13 so... we are not using it?
13:15 jajm i only know that Joubu used it... for something :)
13:16 tcohen maybe he added some flag to KTD so the separate DB is used
13:21 mtj: should we accept _ as wildcard on 'like' queries on the API?
13:21 jajm?
13:21 wahanui jajm is it a goal to eliminate the use of the _() function altogether? (single underscore)
13:22 tcohen I feel like we should only support % for wildcard
13:31 cait1 jajm: still around?
13:32 jajm cait1: yes
13:32 cait1 bug 11844
13:32 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=11844 new feature, P5 - low, ---, julian.maurice, Patch doesn't apply , Additional fields for order lines
13:32 mtj tcohen: i agree re: %
13:32 cait1 I know someone who would be keen to sign-off on that one :)
13:33 (and someone else for QA too) - any chance it could be revived?
13:35 tcohen mtj++
13:35 mtj jajm: we can use master on deb12 to use dedicated database
13:35 tcohen thanks
13:36 jajm: that dev of a separate DB is really neat
13:36 mtj jajm: it will be good to test the DD feature on a KTD
13:37 jajm cait1: the rebase seems complicated, i cannot do that today, but i'll try this week
13:38 what is the "DD" feature ?
13:39 cait1 DD?
13:39 do you mean feature freeze?
13:39 not set yet I think
13:40 mtj dd = 'use dedicated database for tests and stop using rollback'
13:40 cait1 ooh!
13:40 jajm ah, okay :)
13:40 cait1 jajm: and rebase would be awesome, thank you :)
13:41 mtj ...what is a good ENV variable to tell jenkins to use DD?
13:42 tcohen prove --norc \ --Mt::lib::Bootstrap=database,​koha_test,marcflavour,UNIMARC
13:43 mtj KOHA_USE_DEV_DB=1
13:44 ^ how about that?
13:46 tcohen Joubu: come back
13:46 haha
13:47 mtj: I pushed the 'forget about _ support as wildcard' option patch
13:47 everyone can blame the RM if they disagree
13:47 thanks for your effort finding the root cause
13:47 mtj++
13:47 mtj++
13:51 mtj yr welcome :)
13:54 lukeg joined #koha
13:55 lukeg hi!
13:55 mtj hmm, not sure whats causing the www/search_utf8.t fail
13:55 hiya lukeg :)
13:59 paulderscheid[m] Good morning from DC
13:59 tcohen hey paulderscheid[m]
13:59 wahanui paulderscheid[m] is this someone elses javascript? If so I'd consider using a CDN link
13:59 oleonard-away wahanui: forget paulderscheid[m]
13:59 wahanui oleonard-away: I forgot paulderscheid[m]
13:59 oleonard Hi paulderscheid[m] :)
13:59 tcohen paulderscheid[m]: what is a generated cover?
13:59 paulderscheid[m] Hi everyone
14:00 A generated cover is a base64 encoded image that you can use if a biblio has none set
14:01 I wanted to attach the stuff but then I noticed that I added bloat to the api (namely new params that feel kind of ugly)
14:01 I have to supply 2 to n string for the controller. Is there something generic already in place for that?
14:02 wahanui: Sorry, can you give me some context?
14:02 wahanui paulderscheid[m]: wish i knew
14:10 cait1 wahanui = bot :)
14:10 wahanui cait1: i'm not following you...
14:11 paulderscheid[m] Just remembered
14:12 ^^
14:12 tcohen do you have an example of those ugly parameters?
14:12 cait1 bye #koha!
14:12 cait1 left #koha
14:13 paulderscheid[m] tcohen: yeah
14:13 one sec
14:14 * paulderscheid[m] sent a code block: https://matrix.org/_matrix/med[…]eLfVXrcxTeQSFNbEt
14:14 paulderscheid[m] it's still JSON in the example because we use 21.05
14:15 tcohen what about: GET /biblios/:biblio_id/default_cover
14:15 <.<
14:18 paulderscheid[m] That makes a lot of sense
14:18 tcohen :-D
14:18 paulderscheid[m] I have to screenshot this or I'll forget
14:18 tcohen I won't
14:20 paulderscheid[m] tcohen++
15:11 reiveune bye
15:11 reiveune left #koha
15:14 lukeg joined #koha
15:16 liliputech joined #koha
15:30 mtj @later tell lukeg: hi, can you revert bz 31499 for 22.05 release
15:30 huginn` mtj: The operation succeeded.
15:33 mtj @later tell liliputech: hi, can you revert bz 31499 for 21.11 release
15:33 huginn` mtj: The operation succeeded.
17:55 bag joined #koha
18:33 cait joined #koha
20:08 tuxayo bugzilla by default automatically going to the next ticket in the current search after adding a comment or changing status is terribly confusing. It was a mess in the patch testing session today and even with telling a lot the librarians about this issue, one fell into it and changed the status of the wrong ticket.
20:08 Thankfully they noticed immediately afterwards.
20:11 dpk_ joined #koha
20:16 cait not sure if that default could be changed
20:18 tuxayo T_T
20:22 cait: hi :) So I did a patch testing session in English and only German speaking people showed up! XD
20:22 One from the national weather service of austria and two from gwdg.de that you might know :)
20:23 cait :)
20:23 i might know them, but wasn't involved in them appearing
20:25 fridolin joined #koha
20:26 fridolin yelllow
20:26 cait pink1
20:28 tuxayo green
20:30 bag colors are overrated
20:30 cait :(
21:19 tcohen heh

← Previous day | Today | Next day → | Search | Index

koha1