IRC log for #koha, 2022-08-09

← Previous day | Today | Next day → | Search | Index

All times shown according to UTC.

Time Nick Message
00:32 fridolin left #koha
01:25 fridolin joined #koha
01:42 sonOfRa_ joined #koha
01:42 davewood joined #koha
01:42 paxed joined #koha
01:42 jo joined #koha
01:42 tcohen joined #koha
01:42 domm joined #koha
01:42 KotH joined #koha
01:42 void09 joined #koha
01:42 jajm joined #koha
01:42 eythian_ joined #koha
01:42 slef joined #koha
01:42 Joubu joined #koha
01:42 fredericd joined #koha
01:42 mtj[m] joined #koha
01:42 domm[m] joined #koha
01:42 claw joined #koha
01:42 Nemo_bis joined #koha
01:42 KodoKorkalo[m] joined #koha
01:42 kivilahtio joined #koha
01:42 matts joined #koha
01:42 lari joined #koha
01:42 zb joined #koha
01:42 paulderscheid[m] joined #koha
01:42 magnuse joined #koha
01:42 SlackIntegration[m] joined #koha
01:42 Lea[m] joined #koha
01:42 SushiJames[m] joined #koha
01:42 tuxayo joined #koha
01:42 davidnind[m] joined #koha
01:42 ashimema joined #koha
01:42 rangi[m] joined #koha
02:51 JesseM joined #koha
03:18 alohalog` joined #koha
03:18 Topic for #koha is now Welcome to #koha this channel is for discussion of the Koha project and software https://koha-community.org
04:02 Oak joined #koha
05:09 domm[m] joined #koha
05:20 Oak joined #koha
05:42 dcook joined #koha
05:44 mtj joined #koha
05:53 fridolin joined #koha
06:00 irc1 joined #koha
06:08 alohalog` joined #koha
06:08 Topic for #koha is now Welcome to #koha this channel is for discussion of the Koha project and software https://koha-community.org
06:09 cait joined #koha
06:17 Oak joined #koha
06:23 cait joined #koha
06:24 cait joined #koha
06:25 MarkHofstetter joined #koha
06:25 cait joined #koha
06:27 cait joined #koha
06:27 MarkHofstetter1 joined #koha
06:27 cait joined #koha
06:33 sijobl joined #koha
06:42 MarkHofstetter joined #koha
06:46 ashimema I can take a look this morning 🙂
06:46 anyone fancy QA on bug 30619
06:46 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=30619 enhancement, P5 - low, ---, isobel.graham09, Signed Off , Add the option to email receipts as an alternative to printing
06:47 ashimema my daughter would love to see her second patch in Koha 😜
06:52 ribasushi joined #koha
06:55 alex_ joined #koha
06:55 alex_ Bonjour
06:55 wahanui privet, alex_
06:56 magnuse \o/
06:57 cait joined #koha
06:58 lds joined #koha
06:59 cait good morning äkoha :)
07:00 ashimema morning cait
07:00 can you see me today?
07:00 fridolin good evening ^^
07:01 cait yes, I can see the ghost now :)
07:01 Oak joined #koha
07:03 ashimema yeay 🙂
07:03 ooh, it's only tuesday.. awesome
07:04 I thought it was wednesday already.. win, I got an extra day 😛
07:07 dcook Speaking of days, time for this one to end heh
07:08 Wish you luck getting through your emails, ashimema
07:08 Feel like I'm still catching up on mine and I was only gone for 4 days...
07:08 Weeks ago...
07:08 ashimema lol
07:08 yeah, it's a challenge
07:08 not too many left though.. loads of bugmail
07:09 dcook Doesn't help when third parties drop the ball and I end up putting out their fires...
07:09 So much bugmail eh
07:09 I don't even remember all the bugmail I generated today hehe
07:09 ashimema haha, yeah.. know that feeling well dcook
07:10 mtj[m] joined #koha
07:10 dcook I've added a CC to your daughter's patch. It's not an area I know much about it, but if I find myself with a master koha-testing-docker I'll take a look
07:10 Oak joined #koha
07:11 dcook If nothing else comes up maybe I'll actually catch up on my backlog tomorrow
07:11 * dcook says each day..
07:12 ashimema 🙂
07:12 dcook But enough of that. Time to enjoy my final few minutes of sunshine today
07:12 Byyyyye
07:12 ashimema enjoy
07:12 magnuse have fun dcook
07:17 akilsdonk joined #koha
07:18 phasefx joined #koha
07:29 sallyf joined #koha
07:30 cait joined #koha
07:33 magnuse gah, items with itype=NULL
07:33 Joubu misc/maintenance/search_fo​r_data_inconsistencies.pl
07:34 * cait waves
08:02 magnuse Joubu: thanks
08:02 kia ora cait
08:05 Joubu magnuse: not aware of the existence of this script?
08:06 IMO every support companies must run this script before adding a site in production
08:06 magnuse probably seen it and forgotten about it again...
08:06 Joubu that should go with checking the about page for warnings
08:06 magnuse yeah, sounds very sensible
08:07 Joubu looks like I am very bad at advertising cool stuffs I wrote..
08:07 ashimema we are truly terrible at running it in ptfs-e..
08:07 I think
08:24 abneiman joined #koha
08:33 fridolin Joubu: we use this script in every major upgrade, it is very usful
08:33 * fridolin just found a funny bug in it ^^
08:51 Joubu @later tell oleonard can you have a quick look at 23840 please?
08:51 huginn` Joubu: The operation succeeded.
08:53 Joubu fridolin: can you QA 29434 please?
08:56 fridolin yep will do
08:56 ASAP
08:58 jeff joined #koha
09:00 felicia joined #koha
09:08 fridolin doooooooooone
09:09 cait Joubu: you can't reply to an A or B wuestion with "yes" :)
09:09 bug 30673
09:09 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=30673 minor, P5 - low, ---, oleonard, Signed Off , Improve is_valid_date function for validating date strings
09:11 Joubu indeed, sorry
09:11 nugged joined #koha
09:13 ashimema dayjs.. that's on my list to play with 😛
09:19 fridolin left #koha
09:36 cait tcohen: ping :)
10:24 oleonard Hi everybody it's me, This Mess.
10:37 ashimema wha...
10:50 wahanui joined #koha
10:54 huginn` News from kohagit: Bug 27779: (QA follow-up) Fix unit test <https://git.koha-community.org[…]e2543bc9bb97c5739>
10:54 News from kohagit: Bug 27779: (QA follow-up) Better translatability <https://git.koha-community.org[…]7e49c9d3d4adfb22e>
10:54 News from kohagit: Bug 31214: Make subfield code non-editable in MARC framework editor <https://git.koha-community.org[…]d7fbcc2df1984a145>
10:54 News from kohagit: Bug 30927: Improve formatting or iCal files for checkout due dates <https://git.koha-community.org[…]a1b2e2f4d0904450e>
10:54 News from kohagit: Bug 29434: add UNIMARC relationship codes for authorities <https://git.koha-community.org[…]00fe5b5b2d7f178d4>
11:14 tcohen morning
11:14 oleonard Hi tcohen
11:15 tcohen Joubu: you're terrible at advertising, but your IPA was great
11:16 ashimema 😂
11:19 Dyrcona joined #koha
11:24 oleonard Does anyone have KTD working with GMail SMTP settings?
11:24 tcohen Joubu: the only way to test the calendar stuff for koha-meetings, is generating a new meeting, right?
11:30 cait oleonard: not sure, but wasn't there some discussiona bout new security measures for gmail? on the mailinglist (I don't have a gmail account) :)
11:41 oleonard My problem was a dumb one: I hadn't set my GMail SMTP configuration as the selection for each library. It's too bad there isn't a way to define a custom SMTP server as the default.
11:46 tcohen that feature was added in 22.05 I think
11:46 the default can be set in koha-conf.xml
11:47 huginn` News from kohagit: Bug 31183: Use filter_by_current in Koha::Holds->get_items_that_can_fill <https://git.koha-community.org[…]c5d88c49ffab34fa5>
11:47 News from kohagit: Bug 31183: Add Koha::Item::Transfers->filter_by_current <https://git.koha-community.org[…]609651a5c6c447d92>
11:47 News from kohagit: Bug 31183: Unit tests <https://git.koha-community.org[…]fffe56bf9e1fce61c>
11:47 News from kohagit: Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences <https://git.koha-community.org[…]9c3d5b5860d117203>
11:50 tcohen Joubu: around?
12:04 huginn` News from kohagit: Bug 10086: (QA follow-up) Fix TT filters <https://git.koha-community.org[…]90e47bf7135a7f0e8>
12:04 News from kohagit: Bug 28269: (QA follow-up) Fix typo in test description <https://git.koha-community.org[…]8e07bf093445973ab>
12:04 News from kohagit: Bug 28269: Add tests for Acquisitions Orders search by ISSN <https://git.koha-community.org[…]dedf44c64c9651696>
12:04 News from kohagit: Bug 28269: Add feature to search Acquisitions Orders by ISSN <https://git.koha-community.org[…]bff5edbec1f9b5335>
12:04 News from kohagit: Bug 10086: Link to go to basket from uncertain prices page <https://git.koha-community.org[…]f400e66789793eb78>
12:04 tcohen 66 contributors already!
12:04 ashimema nice
12:05 tcohen koha++
12:06 oleonard ashimema: You're supposed to wait with "nice" until 3 more contributors
12:11 Joubu tcohen: yes
12:20 oleonard Joubu: Does item information appear on serials/routing-preview.pl ?
12:21 Joubu oleonard: do you know I am a lazy dev?
12:22 oleonard :)
12:22 * ashimema is getting a headache trying to wrap his brain around jQuery promises/thenables
12:22 Joubu oleonard: you are right, I copy/pasted the test plan, and the items are retrieved to get the branchcode
12:22 but... looking at the code I don't really understand what we are doing
12:22 existing code was doing:
12:22 -    my @itemresults = GetItemsInfo( $biblionumber );
12:22 -    my $branch = @itemresults ? $itemresults[0]->{'holdingbranch'} : $subs->{branchcode};
12:23 not sure it's correct to get the first item
12:26 behaviour is coming from commit "Merging in katipo changes for serials" - 2006 :D
12:27 kidclamp or cait maybe? Any ideas which branchcode we should use in serials/routing-preview.pl?
12:27 subscription.branchcode is NOT NULL, why don't we pick this one?
12:31 oleonard Playing around with changing logged-in library, item home library, and subscription library, and nothing seems to affect the output of routing-preview.pl
12:32 Joubu yes, the result should be identical, but wondering if it's correct
12:32 that's for another bug anyway
12:35 kidclamp yeah, it should probably use the 'issue' that you set on the edit page, but I don't really knwo this code
12:37 cait reading...
12:38 Joubu: no - the routing list is independent from items and it's hardcoded.
12:38 Joubu: branchcode of the subscription
12:39 the issue is not necessarily linked to an item, I think we need to pull it from the subscription
12:39 well issue + subscription information
12:41 Joubu I think we are actually getting the branchcode of the holding library from the first published issue
12:41 cait but... therea re no libraries in the issues are they?
12:41 Joubu why not?..
12:42 cait do you mean issues as serial issues or checkouts?
12:42 Joubu serial issues
12:42 the serial item
12:42 cait yeah, there is not always an item
12:42 the serial table has no branchcode, subsription has
12:42 Joubu that's why there is a fallback on subscription.branchcode
12:43 cait ok
12:43 but first issue is odd
12:43 they'll never be able to make it change
12:43 Joubu but serial.serialitem.item (item linked with the serial) can have a holdingbranch
12:43 cait yes, but only if one exists...
12:43 ah ok, they don#t use the first
12:43 Joubu yes
12:43 cait they use the one linked to the serial issue
12:44 via serialitems
12:44 so that makes sense yes
12:44 Joubu nope
12:44 -    my @itemresults = GetItemsInfo( $biblionumber );
12:44 -    my $branch = @itemresults ? $itemresults[0]->{'holdingbranch'} : $subs->{branchcode};
12:44 and GetItemsInfo is doing the weird sort:
12:44 825         ? sort { ($b->{'publisheddate'} || $b->{'enumchron'} || "") cmp ($a->{'publisheddate'} || $a->{'enumchron'} || "") } @results
12:45 cait I am not sure i understand that code
12:45 Joubu so it's the holdingbranch of first published issue of the subscription's biblio
12:45 cait the routing list is only for one issue
12:45 that might be linked to a specific item
12:45 there is no listing or sorting required there really
12:45 maybe we could simplify in a separate bug if necessary?
12:47 Joubu ok, will try
12:55 bug 31330
13:03 cait commented
14:04 the ash register report export is annoying me :(
14:04 now the total is not printing and I don#t see why
14:10 ashimema 😐️
14:10 not good
14:11 promises are confusing me today..
14:11 my brain just isn't in it at the moment
14:19 cait fixed it... somehow I had switched to editing the de-DE file...
14:20 and was wondering why it didn't fix en.. *sigh*
14:22 ashimema lol
14:43 oleonard cait: What coce provider are you using to test Bug 31217?
14:43 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=31217 enhancement, P5 - low, ---, alexbuckley, Signed Off , Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery
14:54 cait oleonard: the one from the bug report
14:54 in the test plan
15:00 bag joined #koha
15:01 oleonard cait I'm not sure what circumstances this creates, but this ISBN triggers the issue for me: 0590426850
15:05 ashimema how are we doing on bug 30718 peeps?
15:05 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=30718 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Use flatpickr's altInput option everywhere
15:05 ashimema tuxayo, are you aiming to test that last patch?
15:05 cait oleonard: my problem was that the covers didn't show at all
15:06 onyl in the results list, not in the detail pages
15:06 so I didn't want to test with something that was obv broken for me
15:06 huginn` News from kohagit: Bug 29897: DBRev 22.06.00.034 <https://git.koha-community.org[…]38cf50465dae0f3f8>
15:06 News from kohagit: Bug 31319: (QA follow-up) Search items directly (biblio not used yet) <https://git.koha-community.org[…]8d9a3cf461b22dd48>
15:06 News from kohagit: Bug 31306: (QA follow-up) Add comments to test <https://git.koha-community.org[…]b94bab2f334eff63a>
15:06 News from kohagit: Bug 31316: (QA follow-up) Remove stray template close tag <https://git.koha-community.org[…]8a9ae94af35da90ce>
15:06 News from kohagit: Bug 29897: Don't display empty li <https://git.koha-community.org[…]bbcb7f3708cc15200>
15:06 News from kohagit: Bug 29897: (QA follow-up) Add valid $2 codes to pref description <https://git.koha-community.org[…]97ddbd8053e7a5481>
15:06 News from kohagit: Bug 29897: Adjust syspref description <https://git.koha-community.org[…]d50158bc7364be77e>
15:06 News from kohagit: Bug 29897: Remove 'linkage' leftover <https://git.koha-community.org[…]2b51704c2028c4177>
15:06 News from kohagit: Bug 31306: Add tests for search_ordered <https://git.koha-community.org[…]b661cdfcafcea7835>
15:07 News from kohagit: Bug 31306: Allow to pass params and attributes to search_ordered <https://git.koha-community.org[…]3cd2c289bbfd83894>
15:07 News from kohagit: Bug 29897: Fix tab display <https://git.koha-community.org[…]2fbf0a9aaf04e3a74>
15:07 News from kohagit: Bug 31306: Add search_ordered sub to order items with extra conditions <https://git.koha-community.org[…]193e55609362c6200>
15:07 News from kohagit: Bug 31319: Remove GetItemsInfo from tags/list.pl <https://git.koha-community.org[…]9064b1fb2cace2008>
15:07 News from kohagit: Bug 31316: Remove GetItemsInfo from opac-sendbasket <https://git.koha-community.org[…]7f81645af6b1e93bd>
15:07 News from kohagit: Bug 29897: Don't display identifier if not in the list <https://git.koha-community.org[…]ff5c7b1f0c915df43>
15:07 News from kohagit: Bug 29897: Move the identifier list to an include file <https://git.koha-community.org[…]9d90c5318ab09c467>
15:07 News from kohagit: Bug 29897: Add VIAF <https://git.koha-community.org[…]4154317ff553dd24d>
15:07 News from kohagit: Bug 29897: Improve syspref's description <https://git.koha-community.org[…]2cb300b9055f6064d>
15:07 News from kohagit: Bug 29897: Add and fix POD <https://git.koha-community.org[…]e8443f9b045595c35>
15:07 News from kohagit: Bug 29897: Don't use $6 for linkage but build the link instead <https://git.koha-community.org[…]7cf8e666a6bc8eb9c>
15:26 tuxayo ashimema: yes will retest 🙂
15:28 ashimema awesome
15:38 cait bye all
15:39 cait left #koha
15:40 ashimema zebra
15:40 oop
15:42 oleonard hyena
15:43 MarkHofstetter joined #koha
15:43 * ashimema tries to work out how to place a curbside pickup request
15:44 oleonard It's a little confusing at first. Did you set up curbside hours for your libraries?
15:44 ashimema I did
15:44 I've enabled the module and then added hours and slots to my main library
15:44 oleonard It should appear in the sidebar menu when you log in to the OPAC
15:45 ashimema hmm
15:45 not seeing it
15:45 any permissions or circ rules involved?
15:46 oh..
15:46 I see
15:46 I expected it to be at an item level I think
15:46 * ashimema hasn't delved into the feature much yet
15:48 ashimema hmm
15:48 should the 'Select a time' heading really be centered rather than left aligned?
15:49 * ashimema uploaded an image: (38KiB) < https://matrix.org/_matrix/med[…]8.09-16_48_41.png >
15:49 ashimema feels a little off to me somehow..
15:49 feels like the time slots should be aligned with the other inputs
15:49 oleonard You and your absurdly large maximized windows :D
15:49 ashimema and the 'Select a time' label aligned with the other labels?
15:50 lol
15:51 oleonard I think that's fair, though, ashimema. It makes more sense (I think) with lots of times and a smaller window
15:51 https://snipboard.io/KUnsY8.jpg
15:52 But it should work either way, so let me tweak it.
15:52 ashimema hmm.. to me I think think it looks a little odd
15:54 ha.. I see the staff client already sort of does that
15:54 Oak joined #koha
15:54 ashimema just without nicely styled buttons
15:54 and it has no label/title at all
15:54 oleonard https://snipboard.io/Wfs7lr.jpg
15:55 ashimema I think I prefer that
15:55 oleonard https://snipboard.io/LlOKiV.jpg
15:55 ashimema I bet moving the first line of selections up to be inline with the label isn't as trivial?
15:56 oleonard I'm not sure, I was tweaking css in dev tools
15:56 This layout will definitely work better when there are fewer time slots
16:07 Oak joined #koha
16:08 oleonard ashimema: https://snipboard.io/6dHY5n.jpg
16:08 ashimema love it
16:10 * ashimema would PQA on that 😛
16:17 ashimema done
16:17 thanks oleonard.. sorry for being such a  stickler
16:18 oleonard Not at all, that's what we want
16:18 🙌
16:20 * ashimema quietly fills up tcohen queue again
16:22 ashimema but now it's time to clock off and see the family
16:22 have  a good evening all
16:22 oleonard Ciao ashimema
16:31 huginn` News from kohagit: Bug 31307: Remove 'already_reserved' flag from opac-reserve.pl <https://git.koha-community.org[…]a6842ff04996975d2>
16:31 News from kohagit: Bug 31311: Remove GetItemsInfo labels/label-item-search <https://git.koha-community.org[…]98deccbe173558bdd>
16:31 News from kohagit: Bug 28909: Fix handling if backend doesn't support <https://git.koha-community.org[…]b175ac846e9822cb8>
16:31 News from kohagit: Bug 28909: Allow illview to use backend template <https://git.koha-community.org[…]a05a4dad915a38d9a>
16:38 cait joined #koha
16:41 huginn` News from kohagit: Bug 31265: (QA follow-up) Align time selection controls like other inputs <https://git.koha-community.org[…]13b7d807519f56495>
16:41 News from kohagit: Bug 31265: Update style of time selection controls <https://git.koha-community.org[…]d3123aa14c0df94d3>
16:59 News from kohagit: Bug 24857: (QA follow-up) Add spec description <https://git.koha-community.org[…]66ac497dcb5511f53>
16:59 News from kohagit: Bug 28787: (QA follow-up) Add spec description <https://git.koha-community.org[…]48cbadd217c40f229>
16:59 News from kohagit: Bug 28787: DBRev 22.06.00.035 <https://git.koha-community.org[…]23d83d32861bbc2ef>
16:59 News from kohagit: Bug 28787: (QA follow-up) Remove unused variable <https://git.koha-community.org[…]2c0f3a5422a2ad4a9>
16:59 News from kohagit: Bug 28787: Fix misleading tests in two_factor_auth.t <https://git.koha-community.org[…]38b38dbf2b84ac894>
16:59 News from kohagit: Bug 28787: (follow-up) Typo and additional test <https://git.koha-community.org[…]600c4550b83465eec>
16:59 News from kohagit: Bug 28787: Comment selenium test that will fail if no SMTP server is defined <https://git.koha-community.org[…]5b8375e1acdb06208>
16:59 News from kohagit: Bug 28787: Mock send_or_die <https://git.koha-community.org[…]e8d83e21d617a462b>
16:59 News from kohagit: Bug 28787: Don't request a token if no email address defined <https://git.koha-community.org[…]85a5cd1cd31990c46>
16:59 News from kohagit: Bug 28787: Don't send the notice if we are not waiting for 2FA <https://git.koha-community.org[…]39a237880321bbb2d>
16:59 News from kohagit: Bug 28787: Rename the REST API route to /auth/otp/token_delivery <https://git.koha-community.org[…]b673d998d12262d1d>
16:59 News from kohagit: Bug 28787: Fix t/db_dependent/api/v1/two_factor_auth.t <https://git.koha-community.org[…]61e7ffd3549338fd8>
16:59 News from kohagit: Bug 28787: Typo authenticaction <https://git.koha-community.org[…]280434d72d0503c50>
16:59 News from kohagit: Bug 28787: (follow-up) Changes in API auth, moved otp out of Letters <https://git.koha-community.org[…]b14e4fb433d9a40f8>
16:59 News from kohagit: Bug 28787: Send a notice with the TOTP token <https://git.koha-community.org[…]d1b993110f1fddfff>
17:09 News from kohagit: Bug 24857: No words <https://git.koha-community.org[…]f22f0e27486c59d11>
17:21 tuxayo oh circulation: hold ratio is broken on master
17:21 CGI::Compile::ROOT::kohadevbox_koha_circ_re​serveratios_2epl::reserveratios_2epl(): DBI Exception: DBD::mysql::st execute failed: 'koha_test.reserves.reservedate' isn't in GROUP BY at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30
17:21 There doesn't seem to be a ticket, lets open one.
17:25 Oh damn, it's broken since forever
17:25 30188
17:25 bug 30188
17:25 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=30188 major, P5 - low, ---, koha-bugs, NEW , Hold ratios report is broken
17:26 tuxayo No one must use it
17:27 oleonard I think it's related to strict SQL mode, so the people that use it must not have strict mode on
18:35 tuxayo thanks for the hint
18:56 fredericd joined #koha
19:04 Joubu joined #koha
19:30 slef joined #koha
20:09 fridolin joined #koha
21:40 alexbuckley joined #koha
22:01 huginn joined #koha
22:05 kivilahtio joined #koha
22:07 matts joined #koha
22:13 bshum joined #koha
22:16 dpk joined #koha
22:17 philor joined #koha
22:23 gmcharlt joined #koha
22:27 zb joined #koha
22:31 tcohen good night/morning y'all
22:58 * dcook waves to tcohen
23:36 JBoyer_ joined #koha
23:43 lavamind joined #koha

← Previous day | Today | Next day → | Search | Index

koha1