← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:00 | fridolin joined #koha | |
| 00:06 | lukeg joined #koha | |
| 00:33 | irma joined #koha | |
| 00:42 | mtj | hi tuxayo, i cant explain your .env problem |
| 00:42 | lukeg joined #koha | |
| 00:45 | mtj | ..i think your docker-compose is prefering .env file, over your shell vars |
| 01:15 | tuxayo | mtj: weird that my docker-compose changed behavior. My last minor upgrade is the 25th of June and since then I often could start ktd without issue. |
| 01:15 | Anyway, it easy to circumvent once it's found out. | |
| 01:20 | lukeg1 joined #koha | |
| 01:49 | lukeg joined #koha | |
| 01:59 | davidnind[m] joined #koha | |
| 02:07 | mtj | tuxayo: i'm running docker-compose version 1.29.2 on deb10 - if it helps :) |
| 02:21 | tuxayo | mtj: 2.5.1 and I was already running 2.5.0 since a month. On EndeavourOS (Arch Linux based) |
| 02:32 | mtj | aah, my version is v1.. quite old |
| 02:45 | tuxayo | Not really https://repology.org/project/d[…]-compose/versions |
| 02:46 | Only Arch, Gentoo and Solus among the distros a bit known have 2.X | |
| 05:02 | koha-jenkins | Project Koha_Master build #2062: UNSTABLE in 1 hr 9 min: https://jenkins.koha-community[…]Koha_Master/2062/ |
| 05:03 | Oak joined #koha | |
| 05:03 | reiveune joined #koha | |
| 05:03 | reiveune | hello |
| 05:09 | Oak | hello |
| 05:09 | wahanui | hello, Oak |
| 05:28 | jack joined #koha | |
| 05:29 | jack | hi all |
| 05:29 | how i want to add chat box in koha 21.11? | |
| 05:47 | marcelr joined #koha | |
| 05:47 | marcelr | o/ |
| 05:48 | @later tell tcohen 'check the atomicupdate folder please' | |
| 05:48 | huginn | marcelr: The operation succeeded. |
| 06:51 | lds joined #koha | |
| 06:56 | alex_ joined #koha | |
| 06:56 | alex_ | Bonjour |
| 07:29 | Joubu | oleonard, kidclamp: Reading your discussion on 'git so' warning I noticed that the solution I sent 10 months ago never reached the list! |
| 07:50 | marcelr | my git signoff takes 0.2 secs with git filter-branch |
| 07:51 | Joubu is it on Debian 11 ? | |
| 07:54 | Joubu | marcelr: do you see the warning? |
| 07:55 | I remember it took several seconds when I saw the warning | |
| 07:59 | marcelr | no warning |
| 08:00 | fridolin | Bug 30973 easy oe |
| 08:00 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30973 minor, P5 - low, ---, fridolin.somers, Needs Signoff , Serials search wrong body id |
| 08:00 | fridolin | one |
| 08:07 | marcelr | jajm's variant with -s is definitely faster |
| 08:27 | Joubu | I will try fridolin's self-promotion |
| 08:27 | bug 30954 | |
| 08:27 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30954 minor, P5 - low, ---, koha-bugs, Needs Signoff , includes/background_jobs_update_elastic_index.inc must be removed |
| 08:27 | fridolin | ^^ |
| 08:28 | Joubu | bug 30974 |
| 08:28 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30974 normal, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Job size not correct for indexing jobs |
| 08:28 | Joubu | easy ones! |
| 08:49 | tcohen: ping 30925 | |
| 09:05 | ashimema | morning |
| 09:05 | bug 20925 | |
| 09:06 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=20925 enhancement, P5 - low, ---, kyle, CLOSED WORKSFORME, Changing font color for pipes between list items in #moresearch |
| 09:06 | ashimema | bug 30925 |
| 09:06 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30925 major, P5 - low, ---, koha-bugs, NEW , Creating public list by adding items to new list creates a private list |
| 09:10 | marcelr | hi ashimema |
| 09:10 | i asked tomas for a fix on 30925 | |
| 09:13 | Joubu | I am wondering which recall page was working when it was pushed :D |
| 09:14 | fridolin left #koha | |
| 09:22 | paulderscheid[m] | Good morning #koha |
| 09:28 | Can anyone help me with the plugin system? I want to bring some JavaScript dependencies in when installing a plugin. | |
| 09:29 | * Can anyone help me with the plugin system? I want to bring in some JavaScript dependencies when installing a plugin. | |
| 09:29 | Is this possible? | |
| 09:33 | cait joined #koha | |
| 09:35 | paxed | paulderscheid[m]: use the intranet_head or opac_head hooks |
| 09:35 | or possibly intranet_js or opac_js | |
| 09:36 | paulderscheid[m] | The problem is, that I need the actual directory of one dependency because it's an esm module and cannot be easily included through a cdn for example. |
| 09:37 | So to clarify my question: Is there a way to install the dependency on disk? | |
| 09:37 | paxed | don't know esm. i guess you could in theory wget or something the js source file from whereever, or just put the js files in the plugin instead. |
| 09:38 | wget or whatever in the plugin install method | |
| 09:38 | paulderscheid[m] | paxed: Where do these end up? |
| 09:38 | by default? | |
| 09:39 | paxed | koha's plugin_dir (from koha-conf) + /Koha/Plugin/whatever |
| 09:39 | paulderscheid[m] | Ok |
| 09:39 | But this directory isn't accessible by the web server, right? | |
| 09:40 | paxed | i think the kitchen sink plugin has examples of js files in it |
| 09:40 | paulderscheid[m] | Or maybe I got my paths wrong. |
| 09:40 | paxed: Thanks, I'll look into it. | |
| 09:57 | ashimema | any more Joubu 😜 |
| 09:58 | Joubu | ashimema: bug 27421, but not an easy one ;) |
| 09:58 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=27421 enhancement, P5 - low, ---, jonathan.druart+koha, In Discussion , Porting tools/stage-marc-import.pl to BackgroundJob |
| 09:59 | Joubu | and thanks! |
| 09:59 | * cait | waves |
| 10:00 | ashimema | no worries |
| 10:03 | paulderscheid[m] | Joubu: I just noticed that you worked on the kitchen-sink-plugin. Did you ever run into MIME-type issues in this report? |
| 10:03 | **https://github.com/bywatersolu[…]report-step1.tt** | |
| 10:04 | *Concerning the JavaScript files.. | |
| 10:04 | ashimema | khall is more involved with that plugin |
| 10:05 | Joubu | nope! |
| 10:05 | paulderscheid[m] | Ok, good to know. |
| 10:05 | Thanks | |
| 10:08 | ashimema: khall is no regular around here | |
| 10:09 | Or is he? | |
| 10:09 | ashimema | I'll poke him to come say hi 😜 |
| 10:09 | paulderscheid[m] | Haha ^^ |
| 10:10 | ashimema | 5 mins and he'll be around |
| 10:10 | * ashimema | sharpens his poking stick some more |
| 10:12 | cait | ashimema: where do you get one of those? |
| 10:12 | and can I have it for christmas? ;) | |
| 10:12 | ashimema | the girls find them in the woods all the time 😛 |
| 10:13 | hehe | |
| 10:14 | oop.. me and David are clashing today.. hehe | |
| 10:14 | two keen testers | |
| 10:15 | paulderscheid[m] | Ah, now I understand the MIME-type issue. |
| 10:16 | Instead of loadings the JS it loads errorpage.tt | |
| 10:17 | khall joined #koha | |
| 10:17 | khall | good day all! |
| 10:17 | ashimema | 🙂 |
| 10:18 | did you sort your issue paulderscheld? | |
| 10:19 | paulderscheid[m] | Nope |
| 10:20 | khall | paulderscheid[m] what's the issue you are having? |
| 10:20 | paulderscheid[m] | Hi khall 👋 I'm working on a plugin that requires some js dependencies. And I looked at how you did it here: |
| 10:20 | https://github.com/bywatersolu[…]k/report-step1.tt | |
| 10:21 | But it seems that the client can't access these files. | |
| 10:21 | Instead I get the errorpage.tt | |
| 10:21 | khall | paulderscheid[m] any errors in your logs? |
| 10:22 | paulderscheid[m] | I'll take a look |
| 10:23 | ashimema | ah, isn't that where the apache stuff comes in.. |
| 10:23 | paulderscheid[m] | Got a couple of these: |
| 10:23 | cannot exec: Permission denied at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 23. | |
| 10:23 | khall | paulderscheid[m] so you are trying to include those javascript files in the html, but you can't access them, is that right? |
| 10:23 | paulderscheid[m] | Yes |
| 10:24 | Found another one, but this was before I adapted your approach: | |
| 10:24 | [2022/06/16 01:27:14] [WARN] Can't exec "/root/kohaclone/plugins/monaco/min/vs/loader.js": Keine Berechtigung at /usr/share/perl5/Plack/App/WrapCGI.pm line 56. | |
| 10:24 | ashimema | did you see this paulderscheld |
| 10:24 | https://koha-community.gitlab.[…]020-12-10-static/ | |
| 10:25 | khall | ashimema that's what I was thinking as well |
| 10:25 | paulderscheid[m] | I thought that it was a permissions issue. |
| 10:25 | ashimema | hehe |
| 10:25 | paulderscheid[m] | Ok |
| 10:25 | * ashimema | reckons paulderscheld is doing it 'the addendum way' |
| 10:25 | ashimema | which we recommend against these days.. |
| 10:26 | the old way was 'simpler' but required admins to make apache changes and it wasn't as secure | |
| 10:26 | paulderscheid[m] | Ok |
| 10:26 | Well I have no problem taking the recommended route | |
| 10:27 | But do I have to add a route for every single file? | |
| 10:27 | ashimema | mm, it's a little painfu; |
| 10:28 | paulderscheid[m] | The thing I need consists of thousands. |
| 10:28 | ashimema | adding a whole library are we |
| 10:28 | paulderscheid[m] | It's like 80MB |
| 10:28 | ashimema | blimey |
| 10:28 | khall | looks like the kitchen sink could use some updates. It presumes that the plugins is made available from apache |
| 10:29 | paulderscheid[m] is this someone elses javascript? If so I'd consider using a CDN link | |
| 10:29 | paxed | i think there's also some hooks missing |
| 10:30 | paulderscheid[m] | That was my first thought, too. |
| 10:30 | khall | paxed yeah, I imagine so. Plugin hooks are always being added and not everyone sends me a pull request! |
| 10:30 | * ashimema | is guilty of that I reckon ☹️ |
| 10:31 | cait | something more for QA to watch out for maybe |
| 10:31 | w could at least note it on the bugs | |
| 10:31 | paulderscheid[m] | Theoretically it can be loaded through a CDN but it creates more bloat because all modules have to be loaded individually. |
| 10:31 | https://cdnjs.com/libraries/monaco-editor | |
| 10:31 | Just look at it. | |
| 10:32 | Well I don't need all languages but it is still a lot. | |
| 10:32 | ashimema | silly question.. why not just use the code editor already in koha? |
| 10:33 | khall_ joined #koha | |
| 10:33 | paulderscheid[m] | That would be a fallback solution. But the goal is to provide as much functionality as possible out of the box without working on custom solutions. |
| 10:34 | Where do I find the built-in editor? | |
| 10:34 | khall_ | paulderscheid[m] there is a gulfile in the kitchen sink plugin that will build your static assets file for you as well |
| 10:34 | paulderscheid[m] | Already tried but it errors out. |
| 10:35 | khall_ | hmm, that's more of a tcohen thing than mine unfortunately |
| 10:35 | paulderscheid[m] | At first I thought it was my node version. But I reinstalled node and gulp runs fine in other projects. |
| 10:35 | khall_ | could be the gulp version |
| 10:35 | Joubu | oleonard: do you agree with bug 30976? |
| 10:35 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30976 normal, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Cover images for biblio should be displayed first |
| 10:35 | khall_ | "devDependencies": { |
| 10:35 | "gulp": "^3.9.1", | |
| 10:35 | "gulp-cli": "^1.2.2", | |
| 10:35 | "gulp-github-release": "^1.1.5", | |
| 10:35 | "gulp-run": "^1.7.1" | |
| 10:35 | }, | |
| 10:36 | paulderscheid[m] | I'll try it. |
| 10:39 | Still errors out. | |
| 10:42 | khall_ | :/ |
| 10:42 | do you have a static_assets directory with the files in it? | |
| 10:42 | paulderscheid[m] | I pasted the stack trace on paste.koha-community.org but it doesn't show up here. Any idea why? |
| 10:42 | khall_ | static_files that is |
| 10:42 | https://github.com/bywatersolu[…]Sink/static_files | |
| 10:43 | paulderscheid[m] | khall_: You mean in general or in the kitchen sink plugin? |
| 10:43 | khall_ | well, in your plugin |
| 10:44 | pastebot | Someone at 127.0.0.1 pasted "test" (1 line) at https://paste.koha-community.org/10099 |
| 10:44 | paulderscheid[m] | Because I just made a fresh clone of the repo and gulp still errors out. |
| 10:44 | khall_ | paulderscheid[m] ah, so you are using the kitchen sink as a base? |
| 10:44 | paulderscheid[m] | Nah, I went with the koha advent one. |
| 10:45 | I wanted to use the kitchen sink as a base but gulp wouldn't build so I switched. | |
| 10:46 | khall_ | paulderscheid[m] I suggest we wait until tcohen show up and see if he's got a more up to date gulpfile |
| 10:46 | paulderscheid[m] | Alright |
| 10:47 | It's almost 8 in Cordoba, I guess it'll be a couple of hours. | |
| 10:48 | ashimema | he's an early riser |
| 10:48 | I wouldn't be surprised to see him around pretty soon | |
| 10:49 | khall_ | yeah |
| 10:49 | paulderscheid[m] | I'll try the api route approach in the meantime |
| 10:50 | BTW, the monaco editor would be a great replacement for the current editor in Koha. It's the base for VSCode and MIT-licensed. | |
| 10:51 | khall_ | looks nice! |
| 10:51 | ashimema | does look nice.. but I wonder if we need something that extensive in Koha |
| 10:52 | I'm not against it though.. I love vscode | |
| 10:52 | paulderscheid[m] | I think there's a demo somewhere |
| 10:52 | If you left click you get the vscode command palette | |
| 10:52 | richt click, sorry | |
| 10:53 | Oak | Hi, what fine rule would be causing this: "cannot checkout, patron has a debt of X amount." |
| 10:53 | Koha 22 | |
| 10:53 | paulderscheid[m] | And multi cursor support and so on |
| 10:53 | What I really need is the multi cursor and the find and replace stuff | |
| 10:57 | Oak | The circ & fines rules this library has: https://i.imgur.com/uILf9nd.png |
| 10:59 | AdamStyles joined #koha | |
| 11:04 | Oak | This, rather: https://i.imgur.com/Q25xuy2.png |
| 11:06 | davidnind[m] | OaK: noissuescharge system preference |
| 11:06 | Oak | Bless you! |
| 11:08 | davidnind[m] | Oak: also AllowFineOverride if you want to allow library staff to override and issue anyway |
| 11:09 | cait | .9 |
| 11:09 | :) | |
| 11:10 | Oak | Beautiful :) Let me check. |
| 11:13 | paulderscheid[m] | khall_: I fixed the gulpfile for my setup |
| 11:38 | lds joined #koha | |
| 11:46 | cait | question on hte mailing list: how do you continue after a database update has failedß |
| 11:47 | [Koha] Database update fails for 21.12.00.016 | |
| 11:47 | Joubu: can you help with that one maybe? | |
| 11:50 | paulderscheid[m] | khall_: As I think this is a general issue I made a PR on your repo. |
| 11:50 | ashimema | oleonard around yet? |
| 11:53 | magnuse | davidnind++ |
| 12:11 | Oak | davidnind++ |
| 12:25 | void09 joined #koha | |
| 12:28 | magnuse | this is the weirdest thing yet. I have a script that picks up records from oai, and saves a file. then another script reads the file with MARC::File::XML->in(), does some checking and uses AddBiblio or ModBiblio to update koha. this has worked nicely on several sites for years. but now there is one site where some of the records have a bad ancoding when they are saved to Koha. but if i rerun the script on the same file, everything is ok. so it seems |
| 12:28 | something outside the script is randomly influencing the encoding of the records bwfore they are saved. anyone have a hunch what could be doing that? | |
| 12:30 | cait: fix the problem and (re)run "apt upgrade" or koha-upgrade-schema? | |
| 12:30 | cait | I think one of them got stuck half way |
| 12:31 | but for the other it might work? I'd just have someon esle reply who knows the current processing of the upgrade files better | |
| 12:32 | magnuse: there are some MARCXML bugs about encoding currently around | |
| 12:32 | no idea if they could be related | |
| 12:32 | encoding breaks on import | |
| 12:33 | bug 2933 and bug 17754 | |
| 12:33 | huginn | Bug https://bugs.koha-community.or[…]w_bug.cgi?id=2933 normal, PATCH-Sent (DO NOT USE), ---, nahuel.angelinetti, CLOSED FIXED, IE support of popup in intranet |
| 12:33 | Bug https://bugs.koha-community.or[…]_bug.cgi?id=17754 normal, P5 - low, ---, gmcharlt, NEW , MARCXML upload in Intranet is broken (encoding) | |
| 12:35 | magnuse | cait: thanks, but my problem happens before the records reach koha, so it's really more a perl MARC module problem, i think |
| 12:40 | Oak | Can a specific saved record (in a file) on this one site's server can be diffed with another server pulling the same record? |
| 12:41 | If no difference then the perl module version may be different. | |
| 12:41 | Narrow down the problem... is all I can think of | |
| 12:46 | cait | #koha++ |
| 12:46 | just love the stuff going on here today :) | |
| 12:47 | magnuse | Oak: the weird thing is i get different results with the same file on the same server |
| 12:48 | Oak | Difference in... which way? Like... corrupt record? |
| 12:48 | #koha++ always | |
| 12:49 | magnuse | yeah, my script saves a record with bad encoding to koha, or crashes completely because of encoding problems. then i rerun the script on the record and the result looks ok |
| 12:49 | mtj | hi magnuse, what os and koha version? |
| 12:49 | huginn | News from kohagit: Bug 30974: Set size for indexing jobs to 1 <https://git.koha-community.org[…]ed2efd79bc5c29321> |
| 12:49 | News from kohagit: Bug 30973: Serials search fix body id <https://git.koha-community.org[…]f01d0a9d3aa7fe4ab> | |
| 12:49 | News from kohagit: Bug 30971: (follow-up) Fix recall.branchcode occurences <https://git.koha-community.org[…]09114879505e9d943> | |
| 12:49 | News from kohagit: Bug 30971: (follow-up) Fix one more occurence <https://git.koha-community.org[…]abcc746dd9e56085a> | |
| 12:49 | News from kohagit: Bug 30971: Recalls log viewer error <https://git.koha-community.org[…]a190b2c63566db0a3> | |
| 12:55 | Joubu | cait: they should restore from a previous backup and run the update DB script |
| 12:55 | Oak joined #koha | |
| 12:58 | mtj | folks, how about a jenkins build that runs a database upgrade from $oldversion before starting testing? |
| 13:00 | huginn | News from kohagit: Bug 30954: (bug 27344 follow-up) Remove background_jobs_update_elastic_index.inc <https://git.koha-community.org[…]81a0a55be936cfd13> |
| 13:00 | mtj | ...then we can try to detect bugs in the upgrade process |
| 13:01 | Joubu | mtj: I think it should be a test file, using a temporary DB (we would test the different DBMS versions) |
| 13:02 | magnuse | mtj: koha 20.11.13.000, Ubuntu 20.04.3 |
| 13:02 | Joubu | wget the 3.2 kohastructure, inject, run updatedatabase, compare a dump with HEAD:kohastructure |
| 13:03 | mtj | Joubu: hmm, i think that should work ^ |
| 13:04 | pastebot | "magnuse" at 127.0.0.1 pasted "when things go wrong, the script dies like this" (3 lines) at https://paste.koha-community.org/10101 |
| 13:04 | cait | i certainly love the idea |
| 13:04 | we have had way too many issues there this time around | |
| 13:07 | magnuse | sounds like a great idea! |
| 13:09 | Oak | magnuse, this looks interesting, https://stackoverflow.com/ques[…]haracter-in-print |
| 13:09 | also, what encoding is set for your console from there you run the script? | |
| 13:10 | mtj | magnuse: can you make a bug for the problem? looks like we probably need to test it between koha versions aka bisect |
| 13:11 | magnuse: has the problem started happening since a recent koha upgrade? | |
| 13:11 | jzairo joined #koha | |
| 13:11 | magnuse | not sure of the timing, but the problem happens before the record makes it to koha, so it's not really a koha problem, i think |
| 13:12 | Oak: how do i check the encoding of the console? anyway, the problem only happens for some records, and i can't see a difference between them | |
| 13:12 | Oak | Can your script explicitly request utf8mb4 as the encoding? |
| 13:13 | mtj | magnuse: ah yes.. im just reading your scrollback - you have 2 scripts |
| 13:14 | Oak | echo $LANG |
| 13:16 | magnuse | i'm doing a paste with more details |
| 13:16 | mtj | magnuse: is your 1st script saving the oai files uncorrupted? |
| 13:16 | Joubu | @later tell oleonard when changing a user's password (members/member-password.pl) the legend of the fieldset appears too big (font-size: 123.1% (?)). It's coming from a .legend rule in staff-global. However we have a specific rule for fieldset.rows>legend (font-size: 110%). On member-pwd the fieldset has the class "brief" instead of "rows". Is that expected? |
| 13:16 | huginn | Joubu: The operation succeeded. |
| 13:17 | magnuse | mtj: yeah, they look ok |
| 13:18 | Oak: echo $LANG; sudo echo $LANG; sudo koha-shell -c "echo $LANG" instancename; - they all say en_US.UTF-8 | |
| 13:18 | cait | Joubu: yeah... I really hope that is an optoin |
| 13:19 | Dyrcona joined #koha | |
| 13:19 | alohabot | 🎁 🦄 Koha 'master' packages pushed to 'koha-staging' repo 🍫🥦🥮 |
| 13:20 | Joubu | cait: I may be wrong, but I think they copy/pasted SQL queries from the bug report, now they reached an inconsistent state. We shouldn't continue trying to fix their problem or that will get worse. |
| 13:20 | cait | you all... I hope if i write nonsense on the mailing list you will not hesitate to correct me :) |
| 13:21 | Joubu: maybe you could add that to the one mail thread? | |
| 13:22 | Joubu | add that I don't think we should continue to help them? :D |
| 13:23 | cait | i meant adding go back to backup and start over |
| 13:23 | it's hard | |
| 13:24 | we need early updaters... but they might hae been a little too early | |
| 13:24 | Joubu: what do you think about: go back to backup and wait for 22.05.01 | |
| 13:26 | mtj | or we do a quick release with the fix? |
| 13:27 | magnuse: its a strange problem hey? can you replicate the bug on another instance? | |
| 13:29 | magnuse | mtj: i can't really replicate on the same instance... i will try another instance tomorrow. for now i have added some more logging to see what happens |
| 13:29 | cait | hm I guess going back and waiting itu out is easier when you work with snapshots/virtualization |
| 13:30 | if they only have a database backup that makes it harder | |
| 13:30 | all in all... could use some help there, don't think we should stop replying | |
| 13:35 | koha-jenkins | Yippee, build fixed! |
| 13:35 | Project Koha_Master_D11_MDB_Latest build #959: FIXED in 44 min: https://jenkins.koha-community[…]1_MDB_Latest/959/ | |
| 13:35 | wahanui | Congratulations! |
| 13:42 | koha-jenkins | Project Koha_Master build #2063: STILL UNSTABLE in 43 min: https://jenkins.koha-community[…]Koha_Master/2063/ |
| 13:48 | magnuse | mtj, Oak: more details https://paste.koha-community.o[…]bmit=Format+it%21 i gotta run now, but will read back |
| 13:50 | koha-jenkins | Project Koha_Master_D11_My8 build #872: SUCCESS in 57 min: https://jenkins.koha-community[…]ster_D11_My8/872/ |
| 13:54 | Joubu | mtj: could you search for the selenium_failure.png file on docker_3? |
| 13:55 | Oak joined #koha | |
| 13:57 | Oak joined #koha | |
| 13:57 | Oak | Checking magnuse |
| 13:57 | koha-jenkins | Project Koha_Master_U22 build #94: SUCCESS in 1 hr 5 min: https://jenkins.koha-community[…]ha_Master_U22/94/ |
| 13:58 | Joubu | mtj, tcohen: Koha_Master_D10 was running on docker_3, I've adjusted its settings, only non-light runs should run on this node |
| 14:02 | Oak joined #koha | |
| 14:10 | koha-jenkins | Project Koha_Master_D9 build #2009: SUCCESS in 40 min: https://jenkins.koha-community[…]a_Master_D9/2009/ |
| 14:18 | Project Koha_Master_U20 build #440: SUCCESS in 43 min: https://jenkins.koha-community[…]a_Master_U20/440/ | |
| 14:27 | tcohen | Joubu: great |
| 14:28 | @later tell marcelr thanks! | |
| 14:28 | huginn | tcohen: The operation succeeded. |
| 14:39 | koha-jenkins | Project Koha_Master_D10 build #688: SUCCESS in 56 min: https://jenkins.koha-community[…]a_Master_D10/688/ |
| 14:40 | khall joined #koha | |
| 14:42 | rictac joined #koha | |
| 14:44 | tuxayo | Hi :) Anyone up to signoff bug 30733 ? A second signoff will allow Fridolin (the 1st signoff) to do the QA. |
| 14:44 | New simpler method to test instead of reviewing hundred of template changes: run the command to update the translations strings before and after the patch and do a diff. I can details for those interested. | |
| 14:44 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30733 enhancement, P5 - low, ---, victor, Signed Off , Simplify translatable strings |
| 14:46 | koha-jenkins | Project Koha_Master_D11_MDB_Latest build #960: SUCCESS in 36 min: https://jenkins.koha-community[…]1_MDB_Latest/960/ |
| 14:47 | paulderscheid[m] | Anyone else already signing off on bug 30733? |
| 14:47 | Otherwise I'll start in a couple minutes | |
| 14:48 | m23 joined #koha | |
| 14:50 | tcohen | paulderscheid[m]: the more eyes, the best |
| 14:54 | huginn | News from kohagit: Bug 30924: DBRev 22.06.00.003 <https://git.koha-community.org[…]2cf501cef2f2651a6> |
| 15:00 | bag joined #koha | |
| 15:03 | koha-jenkins | Project Koha_Master_D12 build #169: SUCCESS in 1 hr 5 min: https://jenkins.koha-community[…]a_Master_D12/169/ |
| 15:05 | Project Koha_Master_U22 build #95: SUCCESS in 46 min: https://jenkins.koha-community[…]ha_Master_U22/95/ | |
| 15:10 | lukeg joined #koha | |
| 15:15 | paulderscheid[m] | tuxayo: I'm very sorry since this thing has been going for ages it seems but the patch doesn't apply anymore on bug 30733. :/ |
| 15:15 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30733 enhancement, P5 - low, ---, victor, Signed Off , Simplify translatable strings |
| 15:16 | alohabot | 🎁 🦄 Koha 'master' packages pushed to 'koha-staging' repo 🥕🍛🍮 |
| 15:19 | koha-jenkins | Project Koha_Master build #2064: STILL UNSTABLE in 40 min: https://jenkins.koha-community[…]Koha_Master/2064/ |
| 15:23 | Project Koha_Master_D11_My8 build #873: SUCCESS in 36 min: https://jenkins.koha-community[…]ster_D11_My8/873/ | |
| 15:28 | tuxayo | paulderscheid thanks a lot for taking a look. I'll be looking now. It's one that get conflicts very easily given how much templates are changed. |
| 15:29 | paulderscheid[m] | Yeah I bet. |
| 15:29 | Ping me if you fixed it, I'll try to be quicker ^^ | |
| 15:49 | koha-jenkins | Project Koha_22.05_U20 build #11: SUCCESS in 44 min: https://jenkins.koha-community[…]oha_22.05_U20/11/ |
| 16:05 | tuxayo | paulderscheid: done, this one was though ^^" |
| 16:06 | paulderscheid[m] | tuxayo: Alright, on it |
| 16:08 | tuxayo | paulderscheid: thanks a lot :D |
| 16:08 | paulderscheid[m] | No problem, this has to be coordinated since it outdates so fast |
| 16:12 | Did you also wrap preexisting <p> tags? | |
| 16:12 | Or do you skip those | |
| 16:16 | tuxayo | I looked at the final strings on the translation platform and then went to find where they are in the templates. I don't think I had to wrap a <p> so that might mean the script that extracts them treats <p> same as <span> |
| 16:18 | koha-jenkins | Project Koha_22.05_U22 build #12: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_22.05_U22/12/ |
| 16:24 | cait | tuxayo: it does afaik |
| 16:26 | paulderscheid[m] | <tuxayo> "I looked at the final strings on..." <- Ok |
| 16:32 | koha-jenkins | Project Koha_22.05_U18 build #15: STILL UNSTABLE in 1 hr 21 min: https://jenkins.koha-community[…]oha_22.05_U18/15/ |
| 16:35 | paulderscheid[m] | tuxayo: I read through the whole thing. Looks good to me but I found three things that I commented on the bug. |
| 16:38 | If those are intended behaviour I'll sign off but I'll wait 'til you had a look at it. | |
| 16:39 | koha-jenkins | Project Koha_Master_D11_MDB_Latest build #961: SUCCESS in 35 min: https://jenkins.koha-community[…]1_MDB_Latest/961/ |
| 16:48 | tuxayo | paulderscheid: thanks for taking time reading the diff, that's great help. |
| 16:48 | What is suspicious in the part with "patron_link = BLOCK" | |
| 16:48 | *? | |
| 16:50 | paulderscheid[m] | tuxayo: Didn't it shift position? |
| 16:51 | I mean the 'Item recalled by' part? | |
| 16:54 | tuxayo | paulderscheid: I had to do something ugly (adding <span> everywhere arguably is already ^^") , extracting the <a> in a BLOCK. Because having the <a> in the middle of the phrase would split it without any recourse. But a BLOCK usage doesn't cause the extractor to split the string. |
| 16:54 | A workaround on top of a workaround. | |
| 16:55 | paulderscheid[m] | Ah, I see ^^ |
| 16:55 | Did you look at the other ones? | |
| 16:55 | In the first one I thought that the span was kinda redundant. | |
| 16:57 | And in the last one I noticed no wrap | |
| 17:01 | tuxayo | paulderscheid: «Did you look at the other ones?» I just finished posting in the ticket. |
| 17:02 | paulderscheid[m] | Ok |
| 17:02 | tuxayo | > I noticed no wrap |
| 17:02 | ? | |
| 17:02 | Wasn't it about the indentation change? | |
| 17:03 | paulderscheid[m] | No, but now I understand thanks to your comment. |
| 17:04 | Well the patch should be good to go. | |
| 17:07 | tuxayo | great, thanks :D |
| 17:10 | paulderscheid[m] | Sign-Off complete |
| 17:10 | Hope this will be on master soon | |
| 17:10 | koha-jenkins | Project Koha_Master_U22 build #96: SUCCESS in 1 hr 5 min: https://jenkins.koha-community[…]ha_Master_U22/96/ |
| 17:10 | paulderscheid[m] | Great work btw |
| 17:13 | tuxayo | paulderscheid: thanks, you helped at the right moment, we will be able to have this backported to 22.05 and thus translators of incomplete languages will be able to benefit from it immediately. |
| 17:13 | paulderscheid[m] | Wonderful tuxayo |
| 17:16 | koha-jenkins | Project Koha_22.05_U20 build #12: SUCCESS in 36 min: https://jenkins.koha-community[…]oha_22.05_U20/12/ |
| 17:17 | Oak joined #koha | |
| 17:19 | Oak joined #koha | |
| 17:21 | koha-jenkins | Project Koha_Master_U20 build #441: SUCCESS in 44 min: https://jenkins.koha-community[…]a_Master_U20/441/ |
| 17:28 | Project Koha_22.05_D11 build #19: STILL UNSTABLE in 1 hr 9 min: https://jenkins.koha-community[…]oha_22.05_D11/19/ | |
| 17:37 | paulderscheid[m] | Today we celebrate the death of Internet Explorer 🎉 Finally the misery has ended 😄 |
| 17:44 | Oak joined #koha | |
| 17:53 | koha-jenkins | Project Koha_Master_D12 build #170: SUCCESS in 36 min: https://jenkins.koha-community[…]a_Master_D12/170/ |
| 17:56 | Project Koha_Master_D9 build #2010: SUCCESS in 1 hr 23 min: https://jenkins.koha-community[…]a_Master_D9/2010/ | |
| 18:05 | tuxayo | > Internet Explorer 11 is no longer supported as of June 15, 2022 |
| 18:05 | Great :D | |
| 18:06 | Now we can despair about Google owning much of how the web works due to the usage share of Chromium based browsers T_T | |
| 18:08 | koha-jenkins | Project Koha_22.05_U22 build #13: SUCCESS in 46 min: https://jenkins.koha-community[…]oha_22.05_U22/13/ |
| 18:28 | Project Koha_Master_D10 build #689: SUCCESS in 35 min: https://jenkins.koha-community[…]a_Master_D10/689/ | |
| 18:30 | fridolin joined #koha | |
| 18:30 | fridolin | yellow |
| 18:34 | reiveune | bye |
| 18:34 | reiveune left #koha | |
| 18:38 | koha-jenkins | Yippee, build fixed! |
| 18:38 | Project Koha_Master build #2065: FIXED in 1 hr 10 min: https://jenkins.koha-community[…]Koha_Master/2065/ | |
| 18:38 | wahanui | Congratulations! |
| 18:45 | paulderscheid[m] | <tuxayo> "Now we can despair about..." <- And Firefox slowly dying (at least accoding to stats) |
| 18:46 | tuxayo | Yes, that's unfortunately credible |
| 18:47 | paulderscheid[m] | I hope these guys will bring in some new ideas |
| 18:47 | https://servo.org/ | |
| 19:16 | koha-jenkins | Project Koha_Master_D9 build #2011: SUCCESS in 1 hr 20 min: https://jenkins.koha-community[…]a_Master_D9/2011/ |
| 19:38 | tuxayo | If people don't want to avoid monopolies [1] and are suggested Chrome when using Google we are mostly doomed. |
| 19:38 | [1] even though every good capitalist should, Adam Smith wrote against monopolies and oligopolies, that's not revolutionary stuff | |
| 19:48 | koha-jenkins | Project Koha_22.05_D11 build #20: STILL UNSTABLE in 1 hr 9 min: https://jenkins.koha-community[…]oha_22.05_D11/20/ |
| 19:51 | e_reks joined #koha | |
| 20:20 | MarkHofstetter joined #koha | |
| 20:27 | koha-jenkins | Project Koha_Master build #2066: UNSTABLE in 39 min: https://jenkins.koha-community[…]Koha_Master/2066/ |
| 21:40 | tuxayo | tcohen: 30733 is passed QA! Can you take a look so it will be possible to backport it before the 22.05.01 string freeze? |
| 21:40 | bug 30733 | |
| 21:40 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30733 enhancement, P5 - low, ---, victor, Passed QA , Simplify translatable strings |
| 22:39 | davidnind[m] | tuxayo++ |
| 22:39 | tuxayo | hi, thanks ^^ |
← Previous day | Today | Next day → | Search | Index