← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
Time | Nick | Message |
---|---|---|
05:50 | fridolin joined #koha | |
06:03 | reiveune joined #koha | |
06:04 | reiveune | hello |
06:27 | marcelr joined #koha | |
06:27 | marcelr | hi #koha |
06:30 | alex_ joined #koha | |
06:30 | alex_ | Bonjour |
06:30 | wahanui | que tal, alex_ |
06:38 | jajm joined #koha | |
06:44 | Himali joined #koha | |
06:44 | Himali | Hello |
06:45 | I have an issue related to Koha, one of the item is placed on hold b the patron. He received mail for same but book doesnot show in his hold list Also when same item is searched in catalogue it shows available, but when opened it shows as hold. tried reindexing but no luck. Please help. | |
07:08 | jeremy_b joined #koha | |
07:12 | lds joined #koha | |
07:24 | magnuse_ | \o/ |
07:28 | marcelr joined #koha | |
07:38 | jeremy_b joined #koha | |
08:07 | severine_q joined #koha | |
08:07 | severine_q | Happy monday Koha !! 🤗 |
08:12 | ashimema | Morning |
08:18 | marcelr joined #koha | |
08:20 | magnuse__ joined #koha | |
08:48 | cait joined #koha | |
08:48 | cait | hi #koha |
08:49 | noone here? | |
08:49 | ashimema | hi |
08:49 | marcelr | o/ |
08:51 | cait | aaah there is life on IRC after all :) |
08:54 | Himali | hi |
08:54 | I have an issue related to Koha, one of the item is placed on hold b the patron. He received mail for same but book doesnot show in his hold list Also when same item is searched in catalogue it shows available, but when opened it shows as hold. tried reindexing but no luck. Please help. | |
08:54 | wahanui | i already had it that way, Himali. |
08:54 | cait | hi Himali |
08:55 | that sounds a little odd | |
08:55 | Himali | previousl same issue, reindexing solved issue |
08:55 | but no luck this time | |
08:55 | cait | maybe because the hold was cancelled |
08:55 | with hold list, you mean the list of holds in the patron account? | |
08:56 | Himali | yes |
08:56 | cait | if you go to the patron account in staff - is there a tab holds history? |
08:56 | Himali | maybe because the hold was cancelled ----> book shows available but when clicked on book it shows 1 holding |
08:57 | cait | hold or holding? |
08:57 | Himali | holding |
08:57 | cait | holding just means item |
08:57 | it's another word for "what the library has" | |
08:57 | it's nothing to do with holds as such, although they sound really similar | |
08:58 | Himali | ok but main issue is |
08:59 | nlegrand joined #koha | |
09:00 | nlegrand | hey |
09:00 | magnuse | kia ora nlegrand |
09:00 | trying to access <intranet>/cgi-bin/koha/tools/batchMod.pl?del=1, i get this error: "Error reading file /etc/koha/sites/koha01/koha-conf.xml. Try running this again as the koha instance user (or use the koha-shell command in debian)" like i was running it on the command line. anyone seen that before? | |
09:00 | cait | magnuse: sorry, pass |
09:01 | maybe something to do with the messaging/queuing? | |
09:01 | hi nlegrand | |
09:04 | magnuse | same error for several of the "catalogue" tools |
09:04 | cait | i was thinking maybe that's all those that are using background jobs now |
09:04 | ashimema | grr.. there are soooooo many darn copy/pastes with tiny changes of the patron autocomplete code ☹️ |
09:04 | it's a nightmare to catch them all | |
09:05 | magnuse | cait: it's version 20.05.15 |
09:05 | cait | does someoene have an idea which change caused bug 30603 and could link it? |
09:05 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30603 major, P5 - low, ---, koha-bugs, NEW , Sort 1 and Sort 2 on patron form are on longer free text when AV categories are empty |
09:07 | cait | magnuse: huh. |
09:17 | nlegrand | o/ magnuse, cait |
09:17 | ashimema | does anyone know why we have such a mix of manually adding patron names (with various order and various amounts of detail and links) and using the includes to do it more consistently? |
09:17 | it's a nightmakre | |
09:24 | marcelr | historical ballast ? |
09:24 | magnuse | ashimema: organic growth over a long time? |
09:26 | catalogue tools that show the problem: Batch item deletion, Batch item modification, Batch record modification, Export data, Stage MARC records for import, Staged MARC record management, Upload local cover image | |
09:26 | other tools are ok. can anyone think of a common thing between them? | |
09:27 | marcelr | magnuse: check koha-conf, permissions, etc ? |
09:27 | magnuse | yeah, that looks ok |
09:28 | cait | ashimema: because the includes were added later in the game? |
09:28 | i think it was Joubu who introduced them - not super recent, but somewhaat | |
09:29 | ashimema | mm |
09:29 | cait | when was rabbitmq introduced? |
09:29 | ashimema | they've been around for ages and and ages |
09:29 | cait | i know it's in 20.11 |
09:29 | maybe we need to check new code stricter for using them? | |
09:29 | and ages is realtive dealing with a 22 year old project :) | |
09:34 | bbiab | |
09:35 | magnuse | cait: bug 22417, 20.11.00 |
09:35 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=22417 new feature, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, Add a task queue |
09:36 | cait | magnuse: so definitely not that hen :( |
09:36 | did it start happen after a recent update so we could maybe limit it to some suspicious change? | |
09:36 | magnuse | no, but maybe still something related to the problems that was meant to fix |
09:51 | cait | back |
09:53 | ashimema: looking at bug 30136 - wondering: wasn't there another feature to make a button show up ... | |
09:53 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30136 new feature, P5 - low, ---, fridolin.somers, Signed Off , Add back to top button when scrolling |
09:54 | ashimema | erm.. pass |
09:54 | do you mean the skip to main content stuff? | |
09:54 | cait | yes! |
10:04 | ashimema: thx | |
10:04 | ashimema | 🙂 |
10:05 | magnuse_ joined #koha | |
10:24 | oleonard | Hi all |
10:34 | cait | hi oleonard and oleonard++ :) |
10:39 | oleonard | cait++ # too |
10:39 | cait | come all and help me make noise on bugzilla :) |
10:39 | * ashimema | is sleepy today |
10:39 | * cait | hands ashimema coffee for tiredness and a cookie for grumpiness |
10:40 | ashimema | lol |
10:40 | I'm not too grumpy today am I? | |
10:42 | I should probably have another go at the test suit as Joubu is out for a couple of days | |
10:43 | cait | it's prevention |
10:43 | ashimema | hehe |
10:47 | the patron-title.inc include is weird | |
10:51 | marcelr | cait++ # 30290 |
10:52 | cait | it feels like I am on a failing spree :( |
10:52 | with bug 30290 being an exception | |
10:52 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30290 enhancement, P5 - low, ---, m.de.rooy, Passed QA , Article requests: Add TOC information to AR notices |
10:53 | cait | oleonard: do you still have a lot of tabs patches to do? |
10:54 | i kind of lost track | |
10:54 | oleonard | Only the hard ones left :) |
10:54 | cait | ah the usual 20% |
10:54 | * ashimema | went and QA'd a whole bunch of those on Friday 🙂 |
10:54 | oleonard | Patrons, circ, MARC and authority editors. |
10:54 | cait | point me to anything you need moving please |
10:54 | ashimema | great work so far oleonard |
10:55 | it's great to see some of this stuff happening | |
10:55 | we really need to keep working through moving things to simple centralised handling.. this patron-title stuff and patron search/autocomplete stuff is a big taks | |
10:55 | task.. even | |
10:57 | cait | yes, lots of good stuff |
10:58 | ... and please let me know if my QA comments don't make sense (feeling bad about all the fails) | |
11:13 | tcohen | hola #koha! |
11:14 | oleonard | Hi tcohen |
11:16 | * tcohen | searches for oleonard's bugs |
11:16 | oleonard | I am covered in bugs |
11:17 | cait | me too ... eeew |
11:17 | ashimema | lol |
11:17 | cait | tcohen: you can leave oleonard's to me.... but i have some nice ones in today's QA mail that are out of my depth |
11:17 | tcohen | alright! |
11:17 | will check | |
11:17 | * tcohen | hasn't gone through email yet |
11:19 | cait | ;) |
11:22 | ashimema | can someone remind me where the data for the system preferences that have a popup of database fields to select from comes from? |
11:22 | liek for 'BorrowerUnwantedField' | |
11:23 | cait | i think it's a .yml |
11:23 | but i might be wrong :) | |
11:24 | ashimema | I thought it was.. but I can't find one now |
11:24 | did they get removed recently.. I have a vague memory | |
11:24 | cait | hm yeah there as a patch about centralizing column names |
11:24 | but i haven't looked into it if that might have touched things | |
11:25 | bug 29695 | |
11:25 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29695 enhancement, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, Centralize columns' descriptions |
11:25 | ashimema | thanks |
11:27 | 🙂 | |
11:27 | funny.. I thought I'd already fixed that in this patchset.. but it seems not | |
11:34 | magnuse__ joined #koha | |
11:37 | ashimema | also.. is there a reason the `DefaultPatronSearchFields` pref doesn't have such a modal select option? |
11:37 | oleonard | Probably only that no one got around to it. |
11:38 | cait | sounds reasonable |
11:39 | can you add patron attributes there? haven't tested but I seem to remember it blocked some | |
11:39 | on another note, ... I'd love some pre-release notes (https://gitlab.com/koha-commun[…]es/-/tree/master), but not sure who to ask | |
11:40 | ashimema | well.. as far as I can tell, in master.. patron attribute searching is hard coded to being turned on |
11:40 | humm.. | |
11:40 | I used to be able to generate those.. but things have changed a bit since I was RM | |
11:41 | tcohen | Joubu |
11:41 | ashimema | liked having really up to date pre-release notes.. It helped me dig in and try to do release note improvements throughout the cycle instead of it all happening at the last minute |
11:41 | indeed.. we had different approaches to it.. it changed a little | |
11:48 | marcelr joined #koha | |
11:49 | cait | ashimema: add SO line to bug 10517 plz |
11:49 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=10517 normal, P5 - low, ---, rudolfbyker, Signed Off , koha-restore fails to create mysqlusermysql_hostname so zebra update fails |
11:50 | cait | and if yo ufeel inclined... just pqa it |
11:52 | ashimema | it's so long since I looked at it I have no idea if it's right any more |
11:52 | ☹️ | |
11:52 | cait | maybe we need to move it back to NSO then :( |
11:52 | * ashimema | decided to just trust his past self |
11:53 | cait | heh |
11:53 | * cait | pots potatoes on, brb |
11:54 | * oleonard | doesn't trust his past self at all |
11:54 | ashimema | hehe |
11:54 | yeah.. I struggle to trust past selves.. | |
11:55 | I'm sure future self would agree current self is untrustworthy too 😛 | |
11:55 | oleonard | Exactly |
12:01 | cait | who would be good to check your past self's work in this case? |
12:02 | oleonard | How far in the future to find a self who is smart enough to check past self from 5 months ago? |
12:05 | jaffar joined #koha | |
12:05 | jaffar | i want name and address of companies who are dealing with koha |
12:07 | oleonard | jaffar: https://koha-community.org/support/paid-support/ |
12:09 | triveni joined #koha | |
12:12 | magnuse_ joined #koha | |
12:15 | domm | When using SRU to import new data, I can use XLST to filter out some fields/subfields. Is it possible (and if so, how) to use SRU to enhance existing data, and mark some fields/subfields as to be never overwritten by an SRU import/update? |
12:16 | When I drop fields via XLST and use "Replace record via SRU", all the old data is gone - ok, "replace" is strong hint that this is to be expected :-) | |
12:17 | cait | not with XSLT, but I think you can do that with the new rules |
12:17 | tuxayo | hi #koha : |
12:17 | :) | |
12:17 | khall joined #koha | |
12:18 | cait | domm: but it's a 21.11 feature |
12:18 | Administration > Record overlay rules | |
12:20 | marcelr | oleonard: i am close to guessing your password :) |
12:20 | tcohen | <.< |
12:20 | cait | tcohen++ thx! |
12:21 | domm | cait: ok, where's that documented? |
12:21 | cait | I am on bug 30475 now |
12:21 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30475 enhancement, P5 - low, ---, oleonard, Signed Off , Convert tools pages tabs to Bootstrap (part 2) |
12:22 | cait | i am not sure if it's gone into the manual yet, but they did a somewhat nice writeup as part of the bug, let me find it |
12:22 | tcohen | marcelr: have you synced with fridolin about those bugs that fix install vs. upgrade? |
12:23 | cait | domm: bug 14957 and https://gitlab.com/gnucifer/ko[…]b2f350df00fec661f |
12:23 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=14957 new feature, P5 - low, ---, glasklas, RESOLVED FIXED, Write protecting MARC fields based on source of import |
12:23 | domm | cait: thx! |
12:23 | marcelr | tcohen: what do you mean? |
12:24 | tcohen | that fridolin has been working on those situations, not sure how deep |
12:24 | just asking if you both communicated about it | |
12:24 | marcelr | he pushed two already so he should know? |
12:24 | ashimema | the docs merge went in a few days ago |
12:24 | just trying to find a link | |
12:25 | marcelr | i think fridolin was catching up recent dbix omissions tcohen ? |
12:25 | tcohen | marcelr: ok, I saw those passing on my inbox and didn't get into depth, just felt like asking if some overlapping could be taking place |
12:25 | I will test yours now | |
12:25 | :-D | |
12:25 | marcelr | great |
12:26 | i am having a strange issue between 20.11 and master with bug 30449 | |
12:26 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30449 minor, P5 - low, ---, m.de.rooy, Needs Signoff , Missing FK constraint on borrower_attribute_types |
12:26 | marcelr | on master kohastructure change is ok while i add a FK for a table that is defined later |
12:27 | but on 20.11 the installer doesnt like it | |
12:27 | while i assume that fk checking is off while running that script | |
12:28 | ashimema | hmm |
12:28 | the latest merges don't appear to be in the manual build! | |
12:28 | grr | |
12:28 | marcelr | is that grr from grrumpy ? |
12:28 | ashimema | domm: https://gitlab.com/koha-commun[…]/-/commits/master |
12:29 | that's the overlay rules documentation | |
12:30 | I can't for the life of me work out why I can't seem to see it on https://koha-community.org/man[…]n/html/index.html though ☹️ | |
12:30 | cait | ashimema: eat your cookie! |
12:30 | ashimema | lol |
12:32 | * cait | will tell you something happy: Tue 18:59 |
12:32 | cait | who can tell me what that is? |
12:32 | come on... one guess? :) | |
12:32 | tcohen | can I get some attention on bug 30587 |
12:32 | domm | ok, I was also wondering why I can't find any mention of this in the docs |
12:32 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30587 normal, P5 - low, ---, tomascohen, Needs Signoff , Incorrect translations in some templates |
12:32 | oleonard | cait: No idea! |
12:33 | tcohen | cait: cookies are ready? |
12:33 | cait | oleonard: oldest bug in QA queue! |
12:33 | oleonard | Nice! |
12:33 | ashimema | lol |
12:33 | cait | I can't remember when we last got this close to "today" |
12:33 | ashimema | oh relaly |
12:33 | cool | |
12:34 | cait | so... if we dealt with the 5 from Tue today... we could stay within a week's timeframe |
12:35 | marcelr | this IF is very powerful |
12:36 | cait | I hope it is... trying to get you all to play the game with me :) |
12:36 | * cait | hands tcohen his anti-grump cookie too |
12:37 | * tcohen | feels better |
12:37 | tcohen | marcelr: about your db structure-sync bugs |
12:38 | marcelr | tcohen any idea about the cause of that fk problem ^^ |
12:38 | tcohen | what do you think we should do with libraries with bad data? |
12:38 | which one marcelr? | |
12:38 | 30449 | |
12:38 | marcelr | i was thinking that i need to do an eval around some db stats |
12:38 | the FK on 30449 | |
12:39 | tcohen | the atomic update is run inside a transaction |
12:39 | marcelr | refers to categories which is not yet there |
12:39 | yeah but i should test the result before i finish ? | |
12:40 | tcohen | I feel like we could be reporting back to the user |
12:40 | yeah | |
12:41 | marcelr | it might not be needed everywhere but if you see one, fail them |
12:41 | tcohen | I leave those bugs for a couple hours |
12:41 | found something I should finish first | |
12:41 | heh | |
12:41 | marcelr | but the inconsistency with fks between 20.11 and master is strange |
12:41 | ashimema | the test failure for search_patrons highlights some weird behavoir.. again.. on the main patron search to me. |
12:42 | severine_q: still around? | |
12:42 | severine_q | yes ashimema ! |
12:43 | ashimema | do you happen to have a moment to talk patron search.. again.. |
12:43 | severine_q | how can I help you ? |
12:43 | ashimema | so after all this patron searching stuff... |
12:43 | severine_q | sure |
12:43 | ashimema | once your on members/member.pl.. |
12:43 | a) can you ever use the 'clear filter' button on the datatable search box? | |
12:44 | I thought you could.. but it appears not in my testing today.. it's always greyed out | |
12:44 | severine_q | ok, let me open my devbox and i'll check that |
12:46 | cait | brb |
12:47 | severine_q | i have a question too :) |
12:47 | I just found some weird action logs generated on an item for 'onloan' data, anyone who can explain it ? https://snipboard.io/mcnQEH.jpg | |
12:47 | oleonard | ashimema: Can confirm. |
12:48 | severine_q | argh... oleonard is too quick for me ! |
12:48 | I confirm too ashimema | |
12:48 | ashimema | I'm wondering when that happened oleonard.. could have swarn at hackfest that wasn't the case |
12:48 | that log is a data dumper output of the whole loan object by the looks severine_q | |
12:48 | nasty | |
12:48 | oleonard | I assume the patron search updates somewhere, but that could be jumping to conclusions |
12:49 | ashimema | huh? |
12:49 | not sure I follow oleonard | |
12:49 | oleonard | The switch to the API for all patron searches. |
12:49 | * ashimema | still doesn't like having soooooo many search boxes on this page |
12:49 | ashimema | ah yes.. |
12:49 | well.. that's what I meant | |
12:50 | I help test and QA that whole patch series and I'm sure when testing it was working ☹️ | |
12:50 | but I can't see any changes since to have broken it since then | |
12:50 | the other issue I'm seeing is the way searches are combined.. again | |
12:50 | * oleonard | feels like he has tempted fate to lay the blame on himself |
12:50 | ashimema | I pointed this out really early on and I thought it was fixed |
12:50 | haha | |
12:50 | don't think it was you oleonard | |
12:51 | the other thing I would like to know is how you think searches should work in combination | |
12:51 | so.. search for something in the left search stuff.. then add a search on top using the datatables search box.. then finally.. filter more by searching using the 'Name' search box in the header bar of the table.. | |
12:52 | they should all combine on top of each other as a filter.. aparently.. | |
12:52 | but I'm getting them nuking some results they shouldn't be | |
12:52 | severine_q | I just found scenne shot I took during hackfest when testing 20063 ashimema, and it seems the option didn't work |
12:52 | https://snipboard.io/6EGyV8.jpg | |
12:53 | see https://bugs.koha-community.or[…].cgi?id=30063#c23 | |
12:53 | ashimema | awesome severine_q |
12:53 | huginn | Bug 30063: enhancement, P5 - low, ---, jonathan.druart+koha, RESOLVED FIXED, Make the main patron search use the /patrons REST API route |
12:53 | ashimema | so that's not a regression since hackfest.. but possibly one we missed during hackfest |
12:53 | severine_q | argh... I'm sorry I missed that... |
12:53 | ashimema | do you agree it should be usable and not disabled at all times |
12:53 | no worries | |
12:53 | severine_q | I agree |
12:53 | ashimema | I must have missed it too.. though I could have sworn I tested it. |
12:53 | oleonard | If we kept the single-field search filter at the top of patron search results I would think it would be an additional filter on top of whatever search the sidebar filter did. |
12:54 | severine_q | yes me too !! |
12:54 | oleonard | But I also think the single-field search filter could be eliminated. |
12:54 | ashimema | that page scares me.. |
12:54 | oleonard | :) |
12:54 | ashimema | you have a search box in the header at the top of the page.. then another on the left side of the page.. then another in the header of the datatable.. then another for each column of the table in the tables thead |
12:56 | severine_q | I like all those search fields |
12:57 | ashimema | I think librarians will likely need training to use them 😉 |
12:57 | but yeah.. i do think they're not working as intended righ tnow | |
12:57 | which is a regression | |
12:58 | severine_q | we've got many patron, specifically with short asiastic name that can be use for both firstname or last name and it can be quite difficult to find the good borrower ! |
12:58 | but it's only useful if it works as expected... :/ | |
12:58 | ashimema | I understand |
12:58 | I've resigned to having all these fields | |
12:59 | all I'm saying is right now in master.. it's not working the way it was at hackfest | |
12:59 | we have a regression which the unit test is catching | |
12:59 | thanks for verifying what it was meant to do though.. that's helpful | |
12:59 | severine_q | weird... |
12:59 | ashimema | my brain was getting addled 😜 |
12:59 | severine_q | you're welcome ! |
13:00 | I can imagine, it took me 3 days to test it !!! | |
13:00 | oleonard | severine_q++ |
13:00 | severine_q | so I can barelly imagine the QA !! |
13:11 | tcohen | marcelr: I've added a possible way to do it on bug 30449, feel free to ditch it and provide your own's |
13:11 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30449 minor, P5 - low, ---, m.de.rooy, Signed Off , Missing FK constraint on borrower_attribute_types |
13:11 | tcohen | I basically added bad codes and checked it explodes and with mine at least tells something meaningful |
13:11 | marcelr | cool |
13:12 | no patches left | |
13:12 | no patches, no bugs ! | |
13:12 | tcohen | y always forget to confirm :-D |
13:15 | marcelr | looks good to me tcohen thx |
13:19 | Satish_PP joined #koha | |
13:19 | Satish_PP | Hello |
13:19 | oleonard | Hi Satish_PP |
13:19 | Satish_PP | Thanks for reply |
13:19 | tcohen | hola Satish_PP |
13:20 | Satish_PP | I have a query as below |
13:20 | We would like to install multiple Koha instances on the same server with only 2 ports opened 80 and 443 for all customers for STAFF and OPAC pages in AWS cloud Pls let us know how do we achieve this using virtual hosts or configuration changes in Ubuntu OS | |
13:21 | cait | you could use sub domains I think |
13:21 | tcohen | that is done automatically when you use the koha-common package, and the koha-create script to generate each instance |
13:22 | cait | library1.yourdomain.org:8080 ... library2.yourdomain.org:8080 etc. |
13:23 | marcelr: saw your QA contact rahter later - I am stealing bug 30288 from you I tihnk :) | |
13:23 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30288 enhancement, P5 - low, ---, aleisha, Signed Off , Provide links to OPACUserJS and OPACUserCSS in tools |
13:25 | khall joined #koha | |
13:25 | cait | ... and ignore the typos please |
13:26 | y | |
13:33 | Satish_PP | If we open multiple ports for each customer with sub domain name, we're facing CPU and Memory issues all the time |
13:33 | and this is slowly the server | |
13:33 | cait | you don't need pultimple ports |
13:34 | well, only 2 - but you need to have differnet URLs for the different instances somehow | |
13:37 | Satish_PP | We have done that... and it is working also... But the WWW-DATA is taking complete CPU and RAM of the AWS server |
13:37 | This is slowing down the server all the time | |
13:41 | lukeg joined #koha | |
13:42 | khall_ joined #koha | |
13:43 | Satish_PP | Can we configure thro only 2 ports ... i.e., 80 and 443 for all customers? ... Each customer will have different sub domain name |
13:44 | cait | yes - but not sure if that#s really the problem you are seeing with CPU and RAM |
13:45 | tcohen | wtf is CookieManager? |
13:45 | haha | |
13:45 | * tcohen | has been intermitently absent for two weeks only |
13:45 | tcohen | and don't know about that LOL |
13:50 | cait | welcome to my world of you guys always changing things! :) |
13:51 | tcohen | :-D |
13:51 | XD even | |
13:51 | cait | tcohen: do you have time for bug 23991? i could give it a go |
13:51 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=23991 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Move SearchSuggestion to Koha::Suggestions |
13:52 | tcohen | I'm working on bug 29924 right now |
13:52 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29924 enhancement, P5 - low, ---, nick, Signed Off , Introduce password expiration to patron categories |
13:52 | tcohen | so go ahead |
13:53 | cait | ok :) |
13:53 | tcohen: are you working through that tree? | |
14:03 | ashimema | ooh.. did they rebase it tcohen |
14:03 | cait | bbiab #koha |
14:05 | tcohen | ashimema: I'm about to submit a couple follow-up patches, minor ones |
14:05 | ashimema | cool |
14:08 | tcohen | wanna check it too? I'm submitting |
14:08 | ashimema | excellent.. I had a weird feeling it added a temporary password or something.. glad to see that isn't the case on a quick glance |
14:09 | I trust your QA tcohen.. | |
14:09 | nice you beat me to it 🙂 | |
14:09 | tcohen | I have one doubt |
14:09 | ashimema | go on.. I'm happy to take a look |
14:09 | tcohen | how password expiration (as opossed to 'account') should interact with OAuth or cookie based auth |
14:10 | ashimema | good question |
14:10 | hmm | |
14:10 | tcohen | I was about to add tests for OAuth |
14:10 | ashimema | my gut says it shouldn't |
14:10 | tcohen | and then it felt like password is one way to interact with Koha, with its own expiration thing |
14:10 | ashimema | i.e if you already have a vaild OAuth token or valid cookie.. they have their own expire schedules |
14:10 | tcohen | and API keys is another matter |
14:11 | ashimema | so they should continue to work |
14:11 | AndrewFH joined #koha | |
14:11 | ashimema | unless something else expires them like a logout |
14:11 | I find our API key stuff a bit tricky | |
14:12 | I really want a distinction between 'API User' and 'Normal user who also has one or more API keys' | |
14:12 | i.e. I'm really looking forward to full fat OAuth support with more than just credentials grant | |
14:15 | cait | Kyle just said he is waiting for 30584 to be able to release - Elasticsearch, if someone can take it |
14:16 | oh kidclamp++ (just PQA'd it) | |
14:16 | khall_ | cait yeah, now it's up to the RM :) |
14:23 | tcohen | ashimema: agreed |
14:24 | ashimema | I'm going mad.. sure I've fixed this before but can't for the life of me remember how or where |
14:25 | if you have an action button in a datatable.. and the action has a class which has a click even bound.. | |
14:25 | how do you get the second page of datatables results to work with the click events | |
14:26 | oleonard | You have to attach the event to a "higher" element in the markup. $("body").on("click", ".action", function(){ |
14:26 | ".action" being the selector for the actual button | |
14:26 | ashimema | lol.. I see the same button in the boraccount page just has an href instead |
14:26 | I see. | |
14:27 | thanks oleonard | |
14:27 | oleonard | Yeah, use a regular link if you want to. Just not for "destructive" actions. Delete should always use a form. |
14:27 | ashimema | do we have a best practice on how high to bind? |
14:28 | i.e your example there.. do we generally stick to body (as the highest level) | |
14:28 | oleonard | ashimema: I think it only depends on whether there is anything else which is going to be updated in the DOM. |
14:28 | ashimema | or can I go a bit lower.. assume I can't bind to the table itself.. as that would have the same problem maybe |
14:28 | * ashimema | tries |
14:28 | oleonard | I don't know if there are inefficiencies for targeting a higher element. |
14:45 | Dyrcona joined #koha | |
14:50 | cait joined #koha | |
15:00 | bag joined #koha | |
15:04 | cait | back |
15:08 | * ashimema | knocks kidclamp down the leaderboard: https://git.koha-community.org[…]ster/authors.html 🙂 |
15:11 | triveni | hi |
15:21 | lukeg joined #koha | |
15:24 | wizzyrea joined #koha | |
15:27 | cait | oleonard-away: wondering about htis change: |
15:27 | - <option value=""></option> | |
15:27 | + <option value="">None selected</option> | |
15:27 | i always feel like an empty option is a cleaner look | |
15:27 | faster to see what is missing with no text... but not sure if we have ever discussed that | |
15:27 | ashimema | anyone got any thoughts/comments regarding bug 30611 ? |
15:27 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30611 enhancement, P5 - low, ---, martin.renvoize, NEW , Add ability to send passwordreseturl in the Welcome email |
15:28 | * ashimema | intends to work on it this week in the hopes it goes through this cycle (to go with all the welcome email changes already pushed this cycle) |
15:28 | ashimema | but wouldn't mind some people's thoughts on the direction it should take |
15:28 | cait | I think the idea is good, but not ure how easy it is |
15:28 | where do you trigger the entry to the table? | |
15:29 | parsing the notice content when it is sent out? | |
15:29 | ashimema | I can work through the technicals fairly easily I think |
15:29 | it's the workflow I'm trying to consider | |
15:29 | the UX | |
15:30 | cait | ah ... separate or ont |
15:30 | hm | |
15:30 | ashimema | like the actual link needs hiding in the notices display too.. that could get more tricky |
15:30 | cait | as they expire pretty soon, maybe it would be better as a separate feature |
15:30 | ashimema | so parhaps it is it's own notice entirely |
15:30 | cait | not sure hiding is necesary/done now |
15:31 | hm but I see your point | |
15:31 | * ashimema | should check that |
15:32 | cait | hm would be good |
15:33 | oleonard | cait: I though I'd gotten an accessibility warning in the past with empty <option>s, but now I'm not seeing confirmation of that. I must have been mistaken. |
15:33 | cait | hm interesting |
15:37 | I am not really finding much on either/or | |
16:20 | lds_ joined #koha | |
16:22 | cait | ashimema: could you have a quick look at bug 30563 with me? |
16:22 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30563 enhancement, P5 - low, ---, julian.maurice, Signed Off , Add system preference to make the cash register field required when collecting a payment |
16:22 | ashimema | sure.. give me a min |
16:34 | * cait | plays the jeopardy melody ;) |
16:40 | khall joined #koha | |
16:40 | * cait | waves at khall |
16:40 | ashimema | hi |
16:40 | sorry | |
16:40 | back now | |
16:40 | was in a meeting | |
16:42 | cait | all good |
16:42 | I was mainly wondering: isn't the register already mandatory? | |
16:42 | or only with cash and that is the difference? | |
16:43 | ashimema | right now it's only mandatory if it's cash |
16:43 | I can't see any reason for not passing this patch so far, it looks good | |
16:44 | cait | ok :) |
16:44 | ashimema | functionally for cash management it's a hard requirement to be required for cash type transactions.. but this doesn't hurt that at all.. just enhances it 🙂 |
16:44 | cait | i wonder what other cash types would make sense tbh |
16:44 | ashimema | I'd say PQA just looking at the code.. if you happen to have it checked out then go for it 🙂 |
16:44 | transaction_types | |
16:45 | cash, credit_card, debit_card | |
16:45 | cait | I was already working on ti, you can leave it to me |
16:45 | ashimema | 🙂 |
16:45 | cait | yeah but if you do a cashout... |
16:45 | the credit_card transactions will make it go wrong | |
16:45 | ashimema | the important thing is that registers only get assigned to actions that are a 'transfer for money' |
16:45 | cait | i mean the action of taking out money |
16:45 | ashimema | i.e. where you actually pass money from patron to library (or vica versa) |
16:45 | cait | yeah, you don't do that for debit or credit card |
16:46 | ashimema | we do a number of other things.. like writeoff.. where it wouldn't make any sense |
16:46 | well you do.. | |
16:46 | your still giving money to the library.. even if it's electronic | |
16:46 | cait | but it doesn't change the amount of cash in the register |
16:46 | ashimema | in the writeoff case the library never receives the money at all.. it's just saying they don't want the money any more. |
16:46 | yeah.. that's true | |
16:47 | cait | on cashout you get told how much money you can take out of th eregister |
16:47 | ashimema | but you can still refined that by the transaction type.. and i believe that's what things like Cashup do already |
16:47 | yup | |
16:47 | cait | that will be thrown off by non-cash transactions |
16:47 | not sure | |
16:47 | ashimema | it shouldn't do.. |
16:48 | cait | unless it has cash hardcoded somewhere i am not sure how it would not :) |
16:49 | but I filed a couple of issues with the cashout/registers ... some things there are still a little odd | |
16:51 | ashimema | I think it is hardcoded somewhere.. I'm just trying to find where |
16:52 | there's some in koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt | |
16:53 | `register.outstanding_accountlines.total( payment_type => 'CASH') * -1` | |
16:53 | also koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | |
16:55 | seems it's only in those templates | |
16:55 | but that's enough to yield the right results in theory. | |
16:55 | right.. I should probably clock off.. family are waiting 😉 | |
17:03 | khall_ joined #koha | |
17:09 | reiveune | bye |
17:09 | reiveune left #koha | |
17:23 | cait | have a nice evening ashimema |
17:23 | ashimema | You too cait |
18:10 | fridolin joined #koha | |
18:14 | wizzyrea joined #koha | |
18:46 | wizzyrea joined #koha | |
18:54 | cait joined #koha | |
19:05 | koha-jenkins | Project Koha_21.05_D12 build #110: SUCCESS in 34 min: https://jenkins.koha-community[…]ha_21.05_D12/110/ |
19:14 | Project Koha_21.05_U20 build #186: SUCCESS in 39 min: https://jenkins.koha-community[…]ha_21.05_U20/186/ | |
19:17 | alohabot | 🎁 🐵 Koha '21.05.x' packages pushed to 'koha-staging' repo 🍄🥞🥕 |
19:22 | koha-jenkins | Project Koha_21.05_D10 build #257: SUCCESS in 48 min: https://jenkins.koha-community[…]ha_21.05_D10/257/ |
19:30 | Project Koha_21.05_D9 build #182: SUCCESS in 59 min: https://jenkins.koha-community[…]oha_21.05_D9/182/ | |
19:32 | Project Koha_21.05_D11 build #208: UNSTABLE in 1 hr 0 min: https://jenkins.koha-community[…]ha_21.05_D11/208/ | |
19:43 | Project Koha_21.05_U16 build #186: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]ha_21.05_U16/186/ | |
19:54 | cait joined #koha | |
19:55 | koha-jenkins | Project Koha_21.05_U18 build #176: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_21.05_U18/176/ |
20:02 | huginn | News from kohagit: Bug 30405: Compiled CSS <https://git.koha-community.org[…]72708507f9252d2e5> |
20:02 | News from kohagit: Bug 27253: (follow-up) Fix UNIXTIME(0) in db_revs/211200037.pl <https://git.koha-community.org[…]1019ce43acab4a400> | |
20:02 | News from kohagit: Bug 28840: (QA follow-up) Update id to ID <https://git.koha-community.org[…]cc5f237cd4ca70eb2> | |
20:02 | News from kohagit: Bug 30584: Fix ES mapping creation <https://git.koha-community.org[…]cfcece583eab77573> | |
20:02 | News from kohagit: Bug 30288: (follow-up) Use CSS for separator pipes <https://git.koha-community.org[…]12be0caf7e17ed515> | |
20:02 | News from kohagit: Bug 29155: (follow-up) Work around change to jQueryUI tab API <https://git.koha-community.org[…]02d9c340d27b59574> | |
20:02 | News from kohagit: Bug 30534: Remove guarantor_id attribute from the patron object <https://git.koha-community.org[…]0f557a378ab13f247> | |
20:02 | News from kohagit: Bug 30405: Reduce font-size for address in patron search result <https://git.koha-community.org[…]5ebb252d653fc51a5> | |
20:02 | News from kohagit: Bug 30461: Fix BatchUpdateAuthority <https://git.koha-community.org[…]57b5f52ff3f4cee34> | |
20:02 | News from kohagit: Bug 30191: Authority search result list in the OPAC should use 'record' instead of... <https://git.koha-community.org[…]6a93cc74d3429ce19> | |
20:02 | News from kohagit: Bug 29155: Update links to jQuery and jQuery Migrate files <https://git.koha-community.org[…]e4ef0572321d44d34> | |
20:02 | News from kohagit: Bug 29155: Upgrade jQuery and jQuery Migrate to latest versions <https://git.koha-community.org[…]fc32fe080c476e337> | |
20:02 | News from kohagit: Bug 28371: Passpreviously fetched branches and itemtypes through and fetch all needed... <https://git.koha-community.org[…]a0453d280ea34348e> | |
20:02 | News from kohagit: Bug 28371: Unit tests <https://git.koha-community.org[…]81c4e5e19ec750277> | |
20:02 | News from kohagit: Bug 28840: Better texts in batch record modification/deletion <https://git.koha-community.org[…]91276178530814f80> | |
20:05 | fridolin | koha-bots are chating ;) |
20:05 | wahanui: shush | |
20:05 | wahanui | fridolin: what? |
20:05 | fridolin | go to sleep |
20:12 | koha-jenkins | Project Koha_21.05_U20 build #187: SUCCESS in 49 min: https://jenkins.koha-community[…]ha_21.05_U20/187/ |
20:13 | bag joined #koha | |
20:15 | alohabot | 🎁 🦄 Koha 'master' packages pushed to 'koha-staging' repo 🍢🍇🥪 |
20:17 | koha-jenkins | Project Koha_21.05_D12 build #111: SUCCESS in 34 min: https://jenkins.koha-community[…]ha_21.05_D12/111/ |
20:28 | alohabot | 🎁 🦁 Koha '21.11.x' packages pushed to 'koha-staging' repo 🍬🍚🥨 |
20:34 | alexbuckley joined #koha | |
20:34 | koha-jenkins | Project Koha_21.05_D10 build #258: SUCCESS in 39 min: https://jenkins.koha-community[…]ha_21.05_D10/258/ |
20:44 | alohabot | 🎁 🦊 Koha '21.05.x' packages pushed to 'koha-staging' repo 🍌🥐🍧 |
20:53 | koha-jenkins | Project Koha_21.11_U21 build #60: SUCCESS in 35 min: https://jenkins.koha-community[…]oha_21.11_U21/60/ |
21:03 | Project Koha_21.11_U20 build #66: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]oha_21.11_U20/66/ | |
21:15 | Project Koha_21.11_D10 build #81: SUCCESS in 40 min: https://jenkins.koha-community[…]oha_21.11_D10/81/ | |
21:16 | alohabot | 🎁 🦁 Koha '21.05.x' packages pushed to 'koha-staging' repo 🥒🥕🥥 |
21:27 | koha-jenkins | Project Koha_21.11_U22 build #4: SUCCESS in 59 min: https://jenkins.koha-community[…]Koha_21.11_U22/4/ |
21:29 | Project Koha_21.11_D12 build #57: SUCCESS in 36 min: https://jenkins.koha-community[…]oha_21.11_D12/57/ | |
21:30 | alohabot | 🎁 😻 Koha '20.11.x' packages pushed to 'koha-staging' repo 🍌🍌🥓 |
21:31 | tuxayo | CI build queue: 29 |
21:31 | It's will be long! | |
21:32 | koha-jenkins | Yippee, build fixed! |
21:32 | Project Koha_21.05_D11 build #209: FIXED in 1 hr 5 min: https://jenkins.koha-community[…]ha_21.05_D11/209/ | |
21:32 | wahanui | Congratulations! |
21:49 | cait joined #koha | |
21:58 | koha-jenkins | Project Koha_21.05_U18 build #177: SUCCESS in 42 min: https://jenkins.koha-community[…]ha_21.05_U18/177/ |
22:19 | Project Koha_21.11_D9 build #60: SUCCESS in 1 hr 16 min: https://jenkins.koha-community[…]Koha_21.11_D9/60/ | |
22:21 | alohabot | 🎁 🐰 Koha '19.11.x' packages pushed to 'koha-staging' repo 🍐🍈🍉 |
22:26 | koha-jenkins | Project Koha_21.05_D9 build #183: SUCCESS in 59 min: https://jenkins.koha-community[…]oha_21.05_D9/183/ |
22:38 | Project Koha_21.11_D11 build #88: SUCCESS in 1 hr 6 min: https://jenkins.koha-community[…]oha_21.11_D11/88/ | |
22:38 | Project Koha_21.05_U20 build #188: SUCCESS in 39 min: https://jenkins.koha-community[…]ha_21.05_U20/188/ | |
23:17 | Project Koha_Master_D11_MDB_Latest build #877: UNSTABLE in 39 min: https://jenkins.koha-community[…]1_MDB_Latest/877/ | |
23:23 | Project Koha_21.05_D12 build #112: SUCCESS in 57 min: https://jenkins.koha-community[…]ha_21.05_D12/112/ | |
23:24 | Project Koha_Master_U22 build #30: STILL UNSTABLE in 46 min: https://jenkins.koha-community[…]ha_Master_U22/30/ | |
23:32 | Project Koha_21.05_U16 build #187: STILL UNSTABLE in 1 hr 13 min: https://jenkins.koha-community[…]ha_21.05_U16/187/ | |
23:34 | wizzyrea joined #koha | |
23:36 | koha-jenkins | Project Koha_21.11_U18 build #72: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_21.11_U18/72/ |
23:54 | Project Koha_Master_Sid build #24: UNSTABLE in 37 min: https://jenkins.koha-community[…]ha_Master_Sid/24/ | |
23:56 | Project Koha_Master_D10 build #617: FAILURE in 20 min: https://jenkins.koha-community[…]a_Master_D10/617/ |
← Previous day | Today | Next day → | Search | Index