IRC log for #koha, 2022-03-17

← Previous day | Today | Next day → | Search | Index

All times shown according to UTC.

Time Nick Message
02:28 JBoyer joined #koha
02:55 fridolin joined #koha
06:47 Jaware joined #koha
06:48 Jaware Dear All, I just upload a pdf file on koha when I try to open it I have seen the following error
06:48 http://10.1.0.100:8000/cgi-bin[…]9c77add9ddd03b939
06:48 udkoha joined #koha
06:49 Jaware An error has occurred! Error 404 This message may have been caused by any of the following reasons: You made use of an external link to an item that is no longer available You followed an outdated link e.g. from a search engine or a bookmark You tried to access a page that needs authentication An internal link in the client is broken and the page does not exi
07:10 magnuse_ \o/
07:30 fridolin1 joined #koha
07:36 reiveune joined #koha
07:36 reiveune hello
07:39 sodesvaux joined #koha
07:47 alex_a joined #koha
07:48 alex_a Bonjour
07:56 Joubu dcook: still around?
07:56 dcook Joubu: Not really!
07:56 Just running a quick install for a client then I'm offline again
07:57 Joubu ok, I will answer you on the list then.
07:57 dcook Sounds good. I'm off again!
07:57 Hope you have a good day :)
07:58 cait joined #koha
07:58 Joubu you too, enjoy your evening!
08:03 cait1 joined #koha
08:07 Joubu fridolin1: around?
08:07 I don't understand your comment on bug 30063, I am not sure we are understanding each other
08:07 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30063 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Make the main patron search use the /patrons REST API route
08:11 fridolin1 yep
08:11 Joubu fridolin1: https://bugs.koha-community.or[…]3&hide_resolved=1
08:12 fridolin1 Joubu: ah is the dependancy on 30094 mandatory to test ?
08:12 Joubu this is the tree, you added your SO on top, but others have patches that are not signed off yet
08:12 fridolin1 ahhh indeeeeed not good
08:13 what a complexe tree ;)
08:13 Joubu bug 30094, bug 30093, bug 30055
08:13 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30094 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Rewrite the patron search when requesting an article with the REST API route
08:13 fridolin1 i revert my signoff
08:13 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30093 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Rewrite the patron search when placing a hold with the REST API route
08:13 Bug https://bugs.koha-community.or[…]_bug.cgi?id=30055 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Rewrite some of the patron searches to make them use the REST API routes
08:13 nlegrand Bonjour
08:14 fridolin1 Joubu: i understand "tree graph" better, its really helfull as RM
08:15 great job btw, I hope we have it in this cycle
08:15 Jaware a pdf file can not be seen
08:15 Joubu me too! It's too big to rebase it during months!
08:16 Jaware I just uploaded a pdf file using after fileupload plugine is emabled
08:17 how ever this error happens An error has occurred! Error 404
08:19 Joubu Jaware: Do you have a CLI access to the database?
08:20 Jaware yes I can access
08:21 Joubu First you should have a look at the about page, to make sure there is not a warning about the feature
08:22 Go to /cgi-bin/koha/about.pl
08:22 the tab "System information"
08:22 then tab "System information"
08:28 lol
08:32 cait2 joined #koha
08:32 paxed pendingreserves is soooo fast with 2227 items.
08:33 alex_a joined #koha
08:34 fridolin1 left #koha
08:42 cait2 good morning #koha
08:43 paxed: maybe it would be a good candidate for similar treatment than the order receive page? (API and such?)
08:43 not sure if there is a bug yet
08:44 paxed feeling like koha needs some stress testing with data sizes like our production systems.
08:44 acquisition is another stupidly slow thing
08:50 Jaware joined #koha
08:51 Jaware No active currency is defined. Please go to Administration > Currencies and exchange rates and mark one currency as active.
08:56 Enable SSL.-> should both staff and opac be enabled for SSL.
08:56 I prefer to enable https for opac only
09:14 magnuse_ why would bulkmarcimport.pl silently ignore all items in 952-fields when importing a bunch of records?
09:14 cait2 translation updates just dropped...
09:15 wondering as the releases yesterday only had 2 patches changed?
09:51 magnuse_ bugzilla down?
09:51 i get "Errorcode: SIGTRAP" from the web interface
09:54 cait2 OK: I have recall texts in 21.11 translations
09:54 that's not good
09:55 https://translate.koha-communi[…]filter=incomplete
09:56 marcelr joined #koha
09:56 marcelr hi #koha
09:56 cait2 hi marcelr
09:57 just spotted recalls turning up in 21.11 translations
09:57 i can only assume the files are generated for the wrong branch? I don't see any commits to blame
09:57 https://translate.koha-communi[…]filter=incomplete
09:57 marcelr hmm
09:59 cait2 the translation files for 21.05 and 20.11 were ok, I already finished those, no surprises, but 21.11 is broken
10:01 I checked another language, same for 21.11
10:01 marcelr ok
10:01 cait2 not sure what to do... file a bug?
10:01 marcelr should be regenerated i guess
10:02 cait2 yeah, we'll need to figure out waht happened and fix them
10:02 ashimema morning
10:02 cait2 but not sure if anyone but Bernardo can
10:02 marcelr hi ashimema
10:02 cait2 ashimema: master strings in 21.11 translations...
10:02 marcelr i think that translation mgr should first try to fix but by regenerate
10:03 cait2 the problem is that the translation manager is unreachable
10:03 * ashimema reads back for context.. sorry, been out for a couple of days so a bit behind
10:04 cait2 I'll start by filing a bug and add the Rmaints and all
10:07 rmaints?
10:07 RMaints?
10:07 ah no wahanui
10:11 bug 30307
10:11 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30307 blocker, P5 - low, ---, bgkriegel, NEW , 21.11 files contain strings from master (Recalls)
10:13 marcelr cait2++
10:13 ashimema: could you plz have another look at the stage of bug 29957 ?
10:13 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=29957 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Cookies not removed after logout
10:15 ashimema grr.. whilst I have access to the translate server, i've never fully got to grips with how it all fits together ☹️
10:15 lots of scripts
10:17 cait2 marcelr: but I can't fix it :(
10:17 marcelr discover is 1, report is 2, etc
10:18 a fix depends on those steps
10:21 ashimema sure
10:22 me feels like he's juggling whilst riding a unicycle right now and all the balls are about to land on his head 😛
10:22 Joubu output of a script on the translate server is: "branch '21.11' set up to track 'origin/master'"
10:22 that smells..
10:22 ashimema that does indeed
10:23 Joubu MASTER="21.11"
10:23 ashimema if you're on the case there Joubu, i'll step away.. I can't even remember where anything sits on there at the minute
10:23 but if you want to run anything past me, just shout.. happy to lend some brain power
10:23 Joubu I can try to fix but cannot promise I won't aggravate the situation...
10:24 marcelr if it is already broken, that might not be a big thing :)
10:25 ashimema: switch to bicycle and extra wheels haha
10:25 Joubu cait2: script is running for 21.11
10:37 cait2 but why thw wrong stringsß?
10:38 ah ok, reading back - can you alert me when it's finihsed?
10:38 de-DE translations were complete, so I should hopefully be able to tell some things
10:42 Joubu de-DE is done, yes
10:45 cait2 checking now
10:47 oleonard Hi all
10:49 marcelr o/
10:49 JBoyer joined #koha
10:56 cait2 about 530 strings - not too much, looking through them now
10:56 I see strings from tcohen's work on holds history - which is alright, those have been backported
10:57 so far I'd say it looks good
10:57 Joubu ^
10:58 I won't miss these
10:58 %s %s %s %sAccount creation fee %sAccount renewal fee %sLost item  %sManual fee %sNew card %sFine %sLost item processing fee %sRental fee  %sDaily rental fee %sRenewal of rental item %sRenewal of daily rental  item %sHold fee %sHold waiting too long %sPayout %s%s %s %s %s %s  %sPayment %sWriteoff %sForgiven %sCredit %sLost item fee refund  %sOverpayment refund %sRefund %sCancelled charge %s%s %s %s %s %s %s
10:58 Joubu ok, then we need to update the RM tasks when a new release id made
10:58 is*
11:00 cait2 actually for the above I had to delete the "article fee" from master out of the list, so undoing master feature changes
11:00 that does indeed look correct
11:02 actually undoing the holds history anonymize ones too - all good (just was wrong above)
11:08 tcohen hola #koha
11:08 hi Joubu
11:09 Joubu o/
11:14 tcohen Joubu: fixing the invalid refs didn't make it work
11:16 Joubu because of a bug in the lib then?
11:18 tcohen I will provide a patch to fix *those* invalid refs so you can see it
11:18 Joubu tcohen: focus on "cities only", remove all the other things
11:19 tcohen I did
11:19 Joubu
11:19 :)
11:19 tcohen ah, one thing the JSON::Validator maintainer noticed
11:19 we don't actually use those top level definitions, parameters, etc
11:20 we point to the files
11:21 * ashimema did a bunch of cleaner valid specs whilst testing
11:21 ashimema the resolution stuff inside JSON::Validator gets them well and trully mixed up on the internal bundling step
11:24 Joubu additional question: why aren't we switching to openapi v3 now then?
11:24 tcohen I thought of doing that
11:25 our docs are actually converted to v3 for rendering
11:25 the main reason... we will break plugins for sure
11:25 Joubu I guess it won't fix the problem, but at least it's doing a step forward without staying behind
11:26 tcohen if we include this bug
11:26 we can make hte move
11:26 (I'm all for the move)
11:26 ashimema yeah.. I see this as step one and then a soon to follow bug for step two
11:27 tcohen v3 adds things like inheritance, nullable (we use a non-compliant trick right now)
11:27 ashimema we decided QAing both at once could be rather challenging too
11:27 tcohen it is really running any of the available tools to convert it
11:28 Joubu If we go with the "all in one big file" version, I think we should get rid of the conversion
11:28 tcohen the challenge will probably be re-splitting things :-D
11:28 Joubu or it will add one more step (and confusions) for testers
11:28 tcohen Joubu: are you saying you would use a single file and just avoid all this problems?
11:29 Joubu it's what we are doing with the bundle
11:29 * ashimema wondered about that.. but the file is many thausands of lines long and I don't imagine git will do too well with it.
11:29 Joubu technically
11:29 ashimema mm
11:30 Joubu otoh I like the uniformization of the bundled version
11:30 it's autogenerated and it's consistent
11:31 like the keys ordered, the string surrounded by quote consistently, etc.
11:31 tcohen yeah
11:31 ashimema yeah, that is nice
11:32 tcohen so
11:32 one file and avoid the build step?
11:32 Joubu can you confirm you have tested plugins that are injecting api routes?
11:32 * ashimema tried a couple and was happy
11:32 tcohen I relied on the tests I wrote for that
11:32 but will re-test
11:33 Joubu if we keep the auto bundle step, how do we document that? how do we tell people to not generate the bundle version? How do we automate that (think sandboxes, etc.)?
11:34 we will have `yarn build css`, `dbic`, 'yarn spec`, `restart_all`... new comers will get lost
11:35 ashimema I wondered if we aught to have a single yarn build rather than 'css' 'spec'
11:35 Joubu we should patch git bz, to make it display info about the patches it applied
11:36 it would be easy to display: "hey, you should run `yarn spec`" if one file in api/v1/swagger is modified in the patchset
11:36 ashimema my fears about a single massive bundled file may well be unfounded
11:36 I've not tired
11:36 tried.. even
11:36 just know the xml in xslt's often causes challenges for merge at times
11:36 and this felt like a similar'ish thing
11:37 Joubu if things stay ordered it shouldn't be a problem
11:37 but we need a test to confirm it is consistent (like load, dump, compare)
11:38 ashimema mm, that's a sensible thought
11:39 tcohen Joubu: how do we proceed?
11:39 Joubu tcohen: I am waiting for your try
11:39 tcohen ah, ok
11:39 Joubu but I will go for lunch first :)
11:42 tcohen I've already gone down this road
11:42 will try to recover my notes about it
11:43 with the top-level fixes, our spec validated correctly using JSON::Validator::Schema::OpenAPIv2, but it was Mojolicious::Plugin::OpenAPI which f*ed up things
11:43 moving upstairs with a bigger screen
12:02 nlegrand joined #koha
12:27 sophie joined #koha
12:33 marcelr joined #koha
12:33 marcelr o/
12:33 tcohen mtj[m]: can you package JSON::Validator 5.05 instead?
12:51 Dyrcona joined #koha
12:52 oleonard thanks marcelr!
12:53 marcelr np
12:53 still eating cookies
13:02 cait2 Joubu++
13:03 marcelr: if I didn't know aht you were talking about... i could get jealous
13:07 pastebot "tcohen" at 127.0.0.1 pasted "Joubu: moved things to top-level, and only left the cities routes (2)" (3 lines) at https://paste.koha-community.org/8291
13:09 Joubu yes, I went there
13:10 tcohen ah, you are waiting for me to test the plugin routes :-D
13:23 Joubu tcohen, ashimema: What about having 1 bundled version for stable branches only? We could as well have skip_validating_specification for stables.
13:23 That does not mean anything, forget that
13:24 evan joined #koha
13:24 Joubu It could work if we manage to make the split version work
13:24 tcohen we *could* have skip_validating_specification on releases, and enabled in dev environments
13:25 I need a oneliner batman gave me
13:25 trying to find it
13:25 Joubu try in the batcave
13:26 tcohen found it at the bar chatting with catwoman
13:27 marcelr not sure tcohen what you are submitting now..
13:31 Joubu he is going to play his joker card
13:31 All 21.11 translations regenerated!
13:33 tcohen aweomse!
13:33 perl -Mojo -e'app->plugin( OpenAPI => { url => "./swagger.yaml" }); app->start' routes
13:33 if I do that, the 'fixed' spec works
13:34 when we manually use JSON::Validator::Schema::OpenAPIv2, and pass the hashref-ed spec to the plugin, things break badly
13:34 pastebot "tcohen" at 127.0.0.1 pasted "Here" (11 lines) at https://paste.koha-community.org/8292
13:35 tcohen and of course, plack doesn't start because of the error I pasted early
13:35 that's why I blame Mojolicious::Plugin::OpenAPI
13:39 Joubu I have a spec that is broken and the command succeeded :D
14:12 ashimema grr.. bug 30003 still not gone through QA
14:12 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30003 major, P5 - low, ---, jake.deery, Signed Off , Register entries doubled up if form fails validation on first submission
14:28 cait2 ashimema: if you invent some time making machine...
14:28 i am currently stuck between updates and a go live here
14:29 marcelr Koha::TimeMachine->create_another_weekday;
14:32 Joubu "Koha::TimeMachine not implemented yet"
14:34 marcelr it will break Koha
14:35 ashimema Koha::TimeMachine - You will suffer overdue charges for this item when you forget to return it in 3 weeks time, would you still like to proceed with checkout?
14:36 marcelr check it out man
14:36 Joubu @later tell fridolin Hey! The DBIC schema is not up-to-date (or the kohastructure is, I don't know). Please double check!
14:36 huginn Joubu: The operation succeeded.
14:37 Joubu @later tell fridolin You should: git checkout origin/master
14:37 huginn Joubu: The operation succeeded.
14:37 Joubu @later tell fridolin You should: git checkout origin/master; d
14:37 huginn Joubu: The operation succeeded.
14:37 Joubu erk!
14:37 @later tell fridolin You should: git checkout origin/master; dbic; then git diff
14:37 huginn Joubu: The operation succeeded.
14:38 magnuse @quote add ashimema> Koha::TimeMachine - You will suffer overdue charges for this item when you forget to return it in 3 weeks time, would you still like to proceed with checkout?
14:38 huginn magnuse: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command).
14:38 Joubu @later tell fridolin commit that result, then go back to 21.05, reset_all, checkout origin/master, updatedatabase, and run update_dbix_class_files.pl with the correct flag to generate the schema from your current DB (not from kohastructure)
14:38 huginn Joubu: The operation succeeded.
14:38 Joubu @later tell fridolin then compare again
14:38 huginn Joubu: The operation succeeded.
14:38 marcelr checkout origin/21.05.x ?
14:39 Joubu @later tell fridolin go back to 21.11 is enough
14:39 huginn Joubu: The operation succeeded.
14:39 Joubu 21.05 shouldn't hurt anyway :D
14:39 tcohen what's going on?
14:40 Koha::TimeMachine->inflate_hour( hours => 2 );
14:40 marcelr Koha::TimeMachine->create_another_weekday( weekend => 1 ); # new parameter
14:46 Joubu git log origin/master --since="01 Jan 2042"
14:50 cait2 did anyone experience/see issues wth the move to circulation_rules?
14:50 I have the second library reporting now that circ is strange and it rusn out we suddenly have some rules without loan periods...
14:51 and I thought it was a manual change, but after the second library no longer so sure
14:54 Joubu 19.12.00.018 it contains issuelength
14:57 critical waiting for QA for one month already, bug 29893
14:57 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=29893 critical, P5 - low, ---, jonathan.druart+koha, Signed Off , ElasticSearch Config UI deletes mappings
14:59 cait2 thx I will check that
15:00 bag joined #koha
15:07 Jeremy_b joined #koha
15:32 cait2 Joubu: the entries are there for the rule issuelenght, but the rule_value is ""
16:05 reiveune bye
16:05 reiveune left #koha
16:16 cait2 Joubu: intersting: the migration is correct, they were there before with issuelength NULL, migrated to "" - but they didn't have any effect
16:17 i think we improved the logic somewhere and suddenly the rules work...
16:54 cait2 left #koha
17:36 khall joined #koha
18:48 AndrewFH joined #koha
19:44 AndrewFH joined #koha
19:48 AndrewFH joined #koha
21:27 huginn News from kohagit: Bug 27812: DBRev 21.12.00.019 <https://git.koha-community.org[…]a5bab08f350c11c3c>
21:27 News from kohagit: Bug 25285: Fix wrong message about required Koha version in plugins <https://git.koha-community.org[…]28b9acc81589baf2c>
21:27 News from kohagit: Bug 30214: (QA follow-up) Clarify code comment <https://git.koha-community.org[…]702b225d51226e351>
21:27 News from kohagit: Bug 30214: Add ACCTDETAILS notice to verified self registration <https://git.koha-community.org[…]9b9d655b6264877c1>
21:27 News from kohagit: Bug 30214: Add ACCTDETAILS notice to self registeration <https://git.koha-community.org[…]14050d1b46228d598>
21:27 News from kohagit: Bug 30212: Make Select2 available for ILL backends <https://git.koha-community.org[…]5aaa94986121b4c34>
21:27 News from kohagit: Bug 17648: (QA follow-up) Restore imediate sending of the notice <https://git.koha-community.org[…]ff6b002f825e80b1d>
21:27 News from kohagit: Bug 17648: (QA follow-up) Further code cleaning <https://git.koha-community.org[…]741acf2fff27f4be8>
21:27 News from kohagit: Bug 27812: (QA follow-up) Fix atomicupdate <https://git.koha-community.org[…]531dc41f82393c66c>
21:27 News from kohagit: Bug 17648: ACCTDETAILS notice does not show in notices.pl <https://git.koha-community.org[…]d2492874598bf5a17>
21:27 News from kohagit: Bug 27812: Add DBRev to warn of the change to the account details notice <https://git.koha-community.org[…]472579e01e1f64a25>
21:27 News from kohagit: Bug 30177: When editing an existing patron set message_prefs_dirty to true <https://git.koha-community.org[…]a7639b7cf6435522a>
21:27 News from kohagit: Bug 30058: Add Koha::Patrons->filter_by_have_subpermission <https://git.koha-community.org[…]f4c0efcc723484e87>
21:27 News from kohagit: Bug 27812: Email should send for all new patron as per the syspref description <https://git.koha-community.org[…]5cb5609ab628920b1>
21:27 News from kohagit: Bug 27812: Remove the ability to transmit a patron's plain text password over email <https://git.koha-community.org[…]5b65eb2c54b1a9976>
22:03 koha-jenkins Yippee, build fixed!
22:03 Project Koha_Master_D11_CPAN build #555: FIXED in 35 min: https://jenkins.koha-community[…]ter_D11_CPAN/555/
22:13 Project Koha_Master_U21 build #115: UNSTABLE in 45 min: https://jenkins.koha-community[…]a_Master_U21/115/
22:15 alohabot 🎁 🦄 Koha 'master' packages pushed to 'koha-staging' repo  🌶🥞🥗
22:23 koha-jenkins Project Koha_Master_D11_My8 build #769: UNSTABLE in 55 min: https://jenkins.koha-community[…]ster_D11_My8/769/
22:31 Project Koha_Master_U_Stable build #406: UNSTABLE in 1 hr 4 min: https://jenkins.koha-community[…]ter_U_Stable/406/
22:40 Project Koha_Master build #1944: UNSTABLE in 1 hr 11 min: https://jenkins.koha-community[…]Koha_Master/1944/
22:42 Project Koha_Master_D9 build #1898: UNSTABLE in 39 min: https://jenkins.koha-community[…]a_Master_D9/1898/
22:57 Project Koha_Master_U20 build #329: UNSTABLE in 43 min: https://jenkins.koha-community[…]a_Master_U20/329/
23:17 Project Koha_Master_D10 build #554: SUCCESS in 34 min: https://jenkins.koha-community[…]a_Master_D10/554/
23:36 Project Koha_Master_D12 build #99: SUCCESS in 1 hr 4 min: https://jenkins.koha-community[…]ha_Master_D12/99/
23:46 Project Koha_Master_D11_MDB_Latest build #825: SUCCESS in 49 min: https://jenkins.koha-community[…]1_MDB_Latest/825/
23:54 Yippee, build fixed!
23:54 Project Koha_Master_U20 build #330: FIXED in 56 min: https://jenkins.koha-community[…]a_Master_U20/330/
23:57 Project Koha_Master_D9 build #1899: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]a_Master_D9/1899/

← Previous day | Today | Next day → | Search | Index

koha1