← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:45 | ashimema joined #koha | |
| 02:30 | tuxayo joined #koha | |
| 03:08 | AndrewFH joined #koha | |
| 04:17 | koha-jenkins | Yippee, build fixed! |
| 04:17 | Project Koha_19.11_U16 build #117: FIXED in 44 min: https://jenkins.koha-community[…]ha_19.11_U16/117/ | |
| 05:26 | Project Koha_Master build #1903: STILL UNSTABLE in 1 hr 9 min: https://jenkins.koha-community[…]Koha_Master/1903/ | |
| 05:57 | fridolin joined #koha | |
| 06:02 | chriss joined #koha | |
| 07:06 | huginn | News from kohagit: Bug 29914: Remove 'Use of uninitialized value ' warnings <https://git.koha-community.org[…]72f6ac0f307a148d8> |
| 07:06 | News from kohagit: Bug 29914: (QA follow-up) Add comment to explain last case <https://git.koha-community.org[…]c90784eb2891be2b5> | |
| 07:06 | News from kohagit: Bug 29914: (QA follow-up) Expand tests to cover failure case before patches <https://git.koha-community.org[…]6dc24661103b4ea4a> | |
| 07:06 | News from kohagit: Bug 29914: (QA follow-up) Remove warn on timeout <https://git.koha-community.org[…]b2feef8ecb9e6af91> | |
| 07:06 | News from kohagit: Bug 29914: Add tests <https://git.koha-community.org[…]3253b06b403faf707> | |
| 07:06 | News from kohagit: Bug 29914: Make check_cookie_auth compare the userid <https://git.koha-community.org[…]40face25949d3b204> | |
| 07:06 | News from kohagit: Bug 29903: Prevent messages to be deleted from unauthorised users <https://git.koha-community.org[…]0085ff178992f0628> | |
| 07:06 | News from kohagit: Bug 29544: (QA follow-up) Simplify code <https://git.koha-community.org[…]59c19c7ac1f46d775> | |
| 07:06 | News from kohagit: Bug 29543: Set autocomplete off for SCO login fields <https://git.koha-community.org[…]84dcef378d4a695b6> | |
| 07:06 | News from kohagit: Bug 29543: Add Mojo::JWT dependency <https://git.koha-community.org[…]01419a5bbe73c5279> | |
| 07:06 | News from kohagit: Bug 29543: (follow-up) Add a warning to SelfCheckoutByLogin <https://git.koha-community.org[…]dc60c229a46e13e78> | |
| 07:06 | News from kohagit: Bug 29542: Prevent access to private list to non authorized users <https://git.koha-community.org[…]0ee898f6cc2931669> | |
| 07:06 | News from kohagit: Bug 29543: Prevent user to checkin or renew items they don't own <https://git.koha-community.org[…]ede49d5ab4e73cf38> | |
| 07:06 | News from kohagit: Bug 29543: Enforce authentication for self-checkout <https://git.koha-community.org[…]249ff10ba3a3f9898> | |
| 07:06 | News from kohagit: Bug 29541: Prevent users from another group to access patron's images <https://git.koha-community.org[…]7f421857ef2a3977a> | |
| 07:06 | News from kohagit: Bug 29544: Fix opac-issue-note.pl <https://git.koha-community.org[…]43257b4e0bf2b5e07> | |
| 07:06 | News from kohagit: Bug 29541: Restrict access to patron's image to borrowers => * and circulate => * <https://git.koha-community.org[…]eaf1cd8330b0995f0> | |
| 07:06 | News from kohagit: Bug 29544: Ensure logged in user is allowed to modify checkout note <https://git.koha-community.org[…]7d39b7310d5c0f1a5> | |
| 07:06 | News from kohagit: Bug 29540: Raise flagsrequired in modrequest <https://git.koha-community.org[…]ecf912f6f0fb29926> | |
| 07:06 | News from kohagit: Bug 28735: Self-checkout users can access opac-user.pl for sco user when not using... <https://git.koha-community.org[…]6eefaac531f8c118e> | |
| 07:10 | koha-jenkins | Project Koha_Master_D11_MDB_Latest build #786: FAILURE in 4 min 2 sec: https://jenkins.koha-community[…]1_MDB_Latest/786/ |
| 07:10 | Project Koha_Master_U_Stable build #370: FAILURE in 3 min 29 sec: https://jenkins.koha-community[…]ter_U_Stable/370/ | |
| 07:11 | Project Koha_Master_D11_CPAN build #524: FAILURE in 3 min 15 sec: https://jenkins.koha-community[…]ter_D11_CPAN/524/ | |
| 07:12 | Project Koha_Master_D11_My8 build #739: FAILURE in 4 min 15 sec: https://jenkins.koha-community[…]ster_D11_My8/739/ | |
| 07:13 | Project Koha_Master_U20 build #294: FAILURE in 3 min 12 sec: https://jenkins.koha-community[…]a_Master_U20/294/ | |
| 07:14 | Project Koha_Master_U21 build #80: FAILURE in 6 min 34 sec: https://jenkins.koha-community[…]ha_Master_U21/80/ | |
| 07:23 | Project Koha_Master build #1904: FAILURE in 8 min 43 sec: https://jenkins.koha-community[…]Koha_Master/1904/ | |
| 07:53 | Project Koha_Master_D10 build #522: SUCCESS in 41 min: https://jenkins.koha-community[…]a_Master_D10/522/ | |
| 07:53 | alex_a joined #koha | |
| 07:54 | alex_a | Bonjour |
| 07:55 | reiveune joined #koha | |
| 07:55 | reiveune | hello |
| 08:00 | cait joined #koha | |
| 08:03 | lds joined #koha | |
| 08:15 | cait1 joined #koha | |
| 08:15 | marion joined #koha | |
| 08:20 | pblaser3 joined #koha | |
| 08:24 | koha-jenkins | Project Koha_Master_D9 build #1866: SUCCESS in 1 hr 14 min: https://jenkins.koha-community[…]a_Master_D9/1866/ |
| 10:50 | dpk joined #koha | |
| 11:12 | oleonard | o/ |
| 11:16 | cait joined #koha | |
| 11:55 | magnuse | ooh, we passed 30000 bugs |
| 11:55 | \o/ | |
| 12:01 | marion joined #koha | |
| 12:15 | tcohen | hola #koha |
| 12:15 | magnuse: YAY! | |
| 12:15 | AndrewFH joined #koha | |
| 12:22 | magnuse | tcohen: :-) |
| 13:23 | alex_a joined #koha | |
| 13:28 | jzairo joined #koha | |
| 13:28 | Dyrcona joined #koha | |
| 13:34 | kidclamp joined #koha | |
| 14:11 | magnuse_ joined #koha | |
| 14:17 | AndrewFH joined #koha | |
| 14:20 | Joubu | khall, ashimema, tcohen: thanks! <3 |
| 14:21 | ashimema | so nice to see this stuff happening 🙂 |
| 14:21 | just reviewing the 'Use iterator' bug now | |
| 14:21 | found one typo so far | |
| 14:22 | but otherwise it's looking good | |
| 14:27 | cait1 | waht are we happy about? :) |
| 14:27 | i need some happy | |
| 14:31 | ashimema | code tidying cait1 |
| 14:31 | making developers lives easier long term.. and reducing likelyhood of bugs | |
| 14:31 | Joubu, I just reviewed bug 29859.. one minor typo fix needed and a question regards performance thoughts for you | |
| 14:31 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29859 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Favor iterators over as_list |
| 14:36 | Joubu | ashimema: Yes, I don't know. Tomas noted that on another bug as well. I've always prefered iterator over the full list |
| 14:37 | maybe it's wrong | |
| 14:37 | The result should be cached at DBMS level anyway, I am not expecting to have a direct DB access | |
| 14:37 | lukeg joined #koha | |
| 14:38 | Joubu | certainly longer than having the count in a variable, but it should be negligeable in term of erf |
| 14:38 | negligible* | |
| 14:38 | of perf* | |
| 14:39 | ashimema | yeah |
| 14:39 | hard call | |
| 14:40 | I like iterators | |
| 14:40 | what did you think about using the first iteration of the iterator to set up the boilerplate stuff instead of calling a count then iterator like we do now? | |
| 14:40 | it won't work in all cases of course.. but for the simple one's it might be a nice little thing | |
| 14:41 | Joubu | I didn't think about anything when I wrote that patch, just not to introduce regressions :) |
| 14:42 | ashimema | I'm happy to do the get_columns fix as a follow-up here whilst I QA if you like.. or would you prefer to fix it ? |
| 14:42 | Joubu | please do |
| 14:43 | ashimema | okies 🙂 |
| 14:43 | Joubu | and thanks :) |
| 14:45 | magnuse__ joined #koha | |
| 15:01 | ashimema | Joubu.. can you remember how tt knows to iterate our scalar resultsets?.. i.e. why/how we don't have to switch out [% FOREACH thing IN things %] for [% WHILE ( thing = things.next ) %] |
| 15:01 | oh.. is it this stuff: http://www.template-toolkit.or[…]r_Virtual_Methods | |
| 15:02 | Joubu | it just knows |
| 15:02 | ashimema | haha |
| 15:02 | magic | |
| 15:12 | AndrewFH joined #koha | |
| 15:20 | cait1 | please keep in mind coding guidelines and such... thinking of new devs learning the ways we do things |
| 15:21 | ashimema | yup |
| 15:21 | it's up there with my thinking | |
| 15:23 | cait1 | good :) |
| 15:28 | gooble_gobble joined #koha | |
| 15:30 | ashimema | these search_limited methods we're introducing to a few Koha::Plural objects.. should they be search_with_patron_limits or something.. and should they be another Koha::Objects::Limits:: parent class instead? |
| 15:30 | Joubu ^ | |
| 15:31 | one in Patrons.pm, Reviews.pm and ArticleRequests.pm so far.. | |
| 15:31 | and one getting added to Suggestions.pm in bug 29886 | |
| 15:31 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29886 enhancement, P5 - low, ---, tomascohen, Signed Off , Add Koha::Suggestions->search_limited |
| 15:35 | Joubu | yes, could be anything better than "search_limited" |
| 15:35 | is the question about wording only? | |
| 15:36 | ashimema | nope |
| 15:36 | wording is half of it | |
| 15:36 | the other half is whether we should be adding a new base class like we have for library limits | |
| 15:36 | instead of adding search_limited subs all over the place | |
| 15:37 | we have search_with_library_limits in Koha::Objects::Limit::Library.. could we add a search_with_patron_limits in a new Koha::Objects::Limit::Patron base class? | |
| 15:37 | * ashimema | is trying to understand the code in the library limits base class now |
| 15:41 | Joubu | that should work, yes |
| 15:56 | Brooke joined #koha | |
| 15:56 | Brooke | o/ |
| 15:59 | bag joined #koha | |
| 16:07 | marie-luce joined #koha | |
| 16:17 | gooble_gobble_1 joined #koha | |
| 16:19 | cait1 left #koha | |
| 16:24 | ashimema | cait1 around |
| 16:38 | hmm | |
| 16:38 | anyone else having issues starting k-t-d? | |
| 16:38 | BEGIN failed--compilation aborted at /kohadevbox/misc4dev/populate_db.pl line 28 | |
| 16:39 | Joubu | ashimema: did you pull? |
| 16:39 | maybe you are missing the new dep | |
| 16:39 | ashimema | yup |
| 16:40 | Joubu | Mojo::JWT? |
| 16:40 | ashimema | I saw that initially.. but I pulled and pruned |
| 16:41 | Joubu | what's the real error? |
| 16:41 | ashimema | now it appears to be the populate_db stuff |
| 16:41 | Joubu | 28 use Koha::SearchEngine::Elasticsearch; |
| 16:41 | :) | |
| 16:41 | ashimema | just trying to start again and watching the logs in more detail this time |
| 16:44 | oh yeah.. it is still missing Mojo::JWT | |
| 16:49 | Joubu | weekend time for me, see you on Monday ;) |
| 16:54 | ashimema | enjoy |
| 17:04 | damn it.. bug 29886 just keeps making me ask more questions. | |
| 17:04 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29886 enhancement, P5 - low, ---, tomascohen, Signed Off , Add Koha::Suggestions->search_limited |
| 17:13 | cait joined #koha | |
| 17:17 | reiveune | bye |
| 17:17 | reiveune left #koha | |
| 17:36 | khall_ joined #koha | |
| 17:52 | caroline | I don't use sandboxes that often, but I fell like I'm hallucinating... Does anyone have access to http://staff-caroline.sandboxe[…]tfs-europe.co.uk/ ? |
| 17:52 | It just brings me back to the sandbox page | |
| 17:54 | oleonard-away | caroline: I found the same thing when I tried it a couple of days ago. |
| 17:54 | oleonard | Biblibre's worked: https://sandboxes.biblibre.eu/ |
| 17:54 | caroline | ok, good to know I'm not going crazy... I feel like I'm only working with half a brain these days |
| 17:55 | ashimema ^^ problem with the sandbox system? | |
| 17:59 | ashimema | Will take another look on Monday . I've clocked out for the weekend now |
| 17:59 | caroline | oop sorry! |
| 17:59 | Have a good weekend! | |
| 18:00 | biblibre's is giving me 503 error... the universe does not want me to have a sandbox lol! | |
| 18:41 | tcohen joined #koha | |
| 18:54 | gooble_gobble_2 joined #koha | |
| 19:11 | AndrewFH joined #koha | |
| 19:58 | fridolin joined #koha | |
| 19:59 | lukeg joined #koha | |
| 20:01 | AndrewFH joined #koha | |
| 22:53 | AndrewFH joined #koha | |
| 23:13 | JBoyer joined #koha | |
| 23:37 | AndrewFH joined #koha | |
| 23:50 | AndrewFH joined #koha |
← Previous day | Today | Next day → | Search | Index