← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:28 | alexbuckley joined #koha | |
| 00:35 | matts_ joined #koha | |
| 00:37 | jo joined #koha | |
| 00:58 | huginn | News from kohagit: Bug 29495: DBRev 21.12.00.008 <https://git.koha-community.org[…]32e5a88d2a21e17c7> |
| 00:58 | News from kohagit: Bug 29808: Do not receive transfer for checked out items <https://git.koha-community.org[…]167093fbea350943e> | |
| 00:58 | News from kohagit: Bug 29808: Unit tests <https://git.koha-community.org[…]15ece3f16fa4dc64a> | |
| 00:58 | News from kohagit: Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding <https://git.koha-community.org[…]29e5959b6cfe4be20> | |
| 00:58 | News from kohagit: Bug 29804: Regression tests <https://git.koha-community.org[…]91cd3da42ba6cf804> | |
| 00:58 | News from kohagit: Bug 28932: Regression tests <https://git.koha-community.org[…]0ecf7cb0de41849fc> | |
| 00:58 | News from kohagit: Bug 28932: Fix duplicate next_action & prev_action <https://git.koha-community.org[…]beb125ab59e98ae2d> | |
| 00:58 | News from kohagit: Bug 29786: Select only specific items for item level holds <https://git.koha-community.org[…]e370c5e43f9534b50> | |
| 00:58 | News from kohagit: Bug 29786: Unit tests <https://git.koha-community.org[…]1b82f57d2ec183de1> | |
| 00:58 | News from kohagit: Bug 29585: Fix unstranslatable strings in addbiblio.tt <https://git.koha-community.org[…]88584fcf1e14fa820> | |
| 00:58 | News from kohagit: Bug 29495: Add relation tests <https://git.koha-community.org[…]87770dd2a93f3e38c> | |
| 00:58 | News from kohagit: Bug 29495: Unit Tests <https://git.koha-community.org[…]6e993f6a9a5c845ac> | |
| 00:58 | News from kohagit: Bug 29495: (follow-up) Use 'item' relationship <https://git.koha-community.org[…]b4f3167d127c7d223> | |
| 00:58 | News from kohagit: Bug 29495: Update relationship methods <https://git.koha-community.org[…]587bfc24b4e349676> | |
| 00:58 | News from kohagit: Bug 29495: Add code level constraint replacement <https://git.koha-community.org[…]d293278bba0bd8fb0> | |
| 00:58 | News from kohagit: Bug 29495: Add DBIC relationships back into Schema <https://git.koha-community.org[…]9fae61e9ccb6653b9> | |
| 00:58 | News from kohagit: Bug 29495: DBIC Schema Rebuild <https://git.koha-community.org[…]5d1fa38b4e927c23f> | |
| 00:58 | News from kohagit: Bug 29495: Drop issue_id constraint from return_claims <https://git.koha-community.org[…]a43bcad5a5405e9bc> | |
| 01:16 | tcohen joined #koha | |
| 01:18 | zb joined #koha | |
| 01:35 | koha-jenkins | Project Koha_Master_D11_CPAN build #513: UNSTABLE in 36 min: https://jenkins.koha-community[…]ter_D11_CPAN/513/ |
| 01:41 | Project Koha_Master_D11_My8 build #728: UNSTABLE in 43 min: https://jenkins.koha-community[…]ster_D11_My8/728/ | |
| 01:50 | Project Koha_Master build #1890: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]Koha_Master/1890/ | |
| 01:57 | Project Koha_Master_U_Stable build #357: UNSTABLE in 1 hr 0 min: https://jenkins.koha-community[…]ter_U_Stable/357/ | |
| 02:04 | Project Koha_Master_U21 build #69: UNSTABLE in 1 hr 6 min: https://jenkins.koha-community[…]ha_Master_U21/69/ | |
| 02:09 | KotH_ joined #koha | |
| 02:09 | koha-jenkins | Project Koha_Master_U20 build #282: STILL UNSTABLE in 34 min: https://jenkins.koha-community[…]a_Master_U20/282/ |
| 02:13 | zb joined #koha | |
| 02:13 | slef joined #koha | |
| 02:14 | koha-jenkins | Project Koha_Master_D9 build #1854: UNSTABLE in 1 hr 15 min: https://jenkins.koha-community[…]a_Master_D9/1854/ |
| 02:17 | jajm joined #koha | |
| 02:19 | claw joined #koha | |
| 02:19 | domm joined #koha | |
| 02:21 | koha-jenkins | Project Koha_Master_D12 build #59: UNSTABLE in 39 min: https://jenkins.koha-community[…]ha_Master_D12/59/ |
| 02:52 | Project Koha_Master_D10 build #510: UNSTABLE in 55 min: https://jenkins.koha-community[…]a_Master_D10/510/ | |
| 03:06 | Project Koha_Master_D11_MDB_Latest build #771: UNSTABLE in 51 min: https://jenkins.koha-community[…]1_MDB_Latest/771/ | |
| 03:34 | schnydszch joined #koha | |
| 03:35 | schnydszch | Hi! I am trying to sign off bug 11873, I'm getting the following message during signoff: https://sandboxes.biblibre.eu/signoff/t11873v2 |
| 03:35 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=11873 normal, P5 - low, ---, oleonard, Needs Signoff , Upgrade jstree jQuery plugin to the latest version |
| 03:58 | koha-jenkins | Project Koha_Master_D11_MDB_Latest build #772: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]1_MDB_Latest/772/ |
| 04:09 | Yippee, build fixed! | |
| 04:09 | Project Koha_21.11_U21 build #15: FIXED in 59 min: https://jenkins.koha-community[…]oha_21.11_U21/15/ | |
| 04:12 | Yippee, build fixed! | |
| 04:12 | Project Koha_21.05_D10 build #204: FIXED in 1 hr 5 min: https://jenkins.koha-community[…]ha_21.05_D10/204/ | |
| 05:20 | Yippee, build fixed! | |
| 05:20 | Project Koha_21.11_D10 build #28: FIXED in 1 hr 7 min: https://jenkins.koha-community[…]oha_21.11_D10/28/ | |
| 05:46 | fridolin joined #koha | |
| 05:57 | reiveune joined #koha | |
| 05:57 | reiveune | hello |
| 05:59 | schnydszch | hello reiveune |
| 06:09 | fridolin | ashimema: have a look at Bug 29495 please, it breaks the test suite |
| 06:09 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29495 major, P5 - low, ---, martin.renvoize, Pushed to master , Issue link is lost in return claims when using 'MarkLostItemsAsReturned' |
| 06:29 | lmstrand joined #koha | |
| 07:13 | cait joined #koha | |
| 07:17 | cait1 joined #koha | |
| 07:18 | cait1 left #koha | |
| 07:39 | fridolin | tcohen: u around ? |
| 07:46 | marion joined #koha | |
| 07:56 | alex_a joined #koha | |
| 07:56 | alex_a | Bonjour |
| 08:03 | lds joined #koha | |
| 08:24 | ashimema | Bit early for tcohen |
| 08:24 | Morning #koha | |
| 08:24 | Will look at test failures this morning fridolin | |
| 08:26 | fridolin | thanks a lot |
| 08:26 | i looked but its complex DBIx feature | |
| 08:29 | ashimema | interestingly, I'm sure I ran that particular test when I was submitting it.. 'cause I predicted issues there |
| 08:29 | School run now, but will dig deep when I get back in half hour | |
| 08:29 | if you're off by then.. have a good night 😉 | |
| 08:31 | marion_ joined #koha | |
| 08:56 | Joubu | fridolin: Hi, do you need help for the PQA bugs? |
| 08:56 | weepoli joined #koha | |
| 08:56 | Joubu | The queue is quite high and it contains a lot of bugs |
| 08:57 | weepoli | Good job folks! |
| 08:58 | Joubu | fridolin: the failing test is explicit, it's missing the koha_object[s]_class |
| 09:00 | fridolin | Joubu: but for me it is present |
| 09:02 | https://git.koha-community.org[…]ts/ReturnClaim.pm | |
| 09:02 | ahhh i see ashimema ^ | |
| 09:02 | missing object_class | |
| 09:04 | Joubu | the error is actually "Value not allowed for auto_incr issue_id in Issue" |
| 09:04 | ashimema: are you on it? | |
| 09:11 | fridolin | Joubu: if there are passedQA to push in priority you can tell me. Otherwise i feel like i'm starting to be more confortable with master envv |
| 09:13 | Joubu | nothing very urgent, but next releases are soon and those that are not pushed are not available for backport |
| 09:14 | fridolin | sure |
| 09:15 | reiveune left #koha | |
| 09:17 | reiveune joined #koha | |
| 09:35 | ashimema | I'm on it.. just been on school run and company meeting so far this morning |
| 09:35 | I've got my terminal open just about to dig in 😉 | |
| 09:45 | my brain is stuck today.. any hints Joubu? | |
| 09:46 | Joubu | I haven't been far, but the are trying to generate a Koha::Checkout passing a PK (issue_id) |
| 09:47 | I guess it's because we removed the FK but I don't understand why.. | |
| 09:48 | ashimema | I'll keep digging |
| 09:48 | just nothing obvious right now.. will grab a coffee and get the brain cells moving again | |
| 09:58 | I wonder if we use belongs_to to presume a db foreign key.. perhaps I should switch it to might_have | |
| 10:05 | humm | |
| 10:26 | nikkom joined #koha | |
| 10:28 | nikkom | hi everyone |
| 10:29 | I have a question about room rezervation. I would be happy İf anyone can help | |
| 10:30 | I'm using https://github.com/ldjamison/k[…]room-reservations and I want to use it in Turkish. What can I do? | |
| 10:32 | alex_a joined #koha | |
| 10:43 | cait1 joined #koha | |
| 10:43 | cait1 | hi #koha |
| 10:43 | ashimema | it's because, I think, testbuilder goes through and creates the issue line.. which populates the issue_id.. then it tries to create the old_issue using the issue_id created in the previous pass |
| 10:44 | Joubu | nikkom: if you are using it already, what is the problem? |
| 10:44 | hi cait1 | |
| 10:44 | fridolin left #koha | |
| 10:44 | ashimema | you'll need to submit a Turkish translation nikkom |
| 10:45 | looks like currently there's only american english and german | |
| 10:45 | tobias engelke did the german translation.. | |
| 10:46 | or perhaps as khall or tcohen for guidance on how to submit such a translation | |
| 10:47 | humm.. | |
| 10:51 | nikkom | I see in english nor @Joubu |
| 10:52 | ashimema : how/where can I submit Turkish translation. Sorry I am new in koha | |
| 10:53 | ashimema | well.. it's a plugin.. so doesn't follow the usual community process as such. |
| 10:54 | in fact.. by your link.. I think you're using a fork already.. my understanding is that ByWater Solutions maintains the 'main' version of that plugin | |
| 10:54 | khall or kidclamp around? ^ | |
| 10:54 | or was that one originally done by equinox? | |
| 11:00 | Joubu.. | |
| 11:00 | still around? | |
| 11:00 | Joubu | yes |
| 11:00 | semarie left #koha | |
| 11:01 | ashimema | I can 'fix' that TestBuilder test by converting my added relations from belongs_to to might_have.. but that raises a DBIC warning instead asking me to switch back to belongs_to because the field is nullable.. |
| 11:01 | any thoughts on that.. | |
| 11:01 | do you think having the dbic warn is OK in our case... or should I be trying to fix TestBuilder itself to not try to create the issue twice.. once for each of the relations | |
| 11:02 | how do we do this elsewhere.. I'm sure we have relations for 'old' in other classses | |
| 11:02 | nikkom | thanks ashimema |
| 11:02 | Joubu | dbic warning seems bad |
| 11:03 | ashimema | hmm |
| 11:03 | Joubu | why are you talking about old? |
| 11:03 | kidclamp | ashimema: we adopted that one, it was written by one of our partners |
| 11:04 | ashimema | any hints/tips for nikkom on how to submit a translation for it? |
| 11:04 | * ashimema | hasn't wrapped his head around plugin translations enough yet to really guide them |
| 11:05 | nikkom joined #koha | |
| 11:05 | kidclamp | it looks to take po files, I would trry contacting lms-tobias for info on how he generated everything |
| 11:05 | then just submit a pull | |
| 11:06 | ashimema | hmm, maybe I could cheat and us a 'has_many' instead of 'might_have'.. but that's even less clear to the developer.. |
| 11:06 | kidclamp | what's in your fork ashimema ? something we could combine to not have two version? |
| 11:06 | ashimema | basically it's working around out screw up. |
| 11:06 | we don't have a fork | |
| 11:06 | but nikkom links to a fork above | |
| 11:06 | https://github.com/ldjamison/k[…]room-reservations | |
| 11:06 | Joubu | https://github.com/bywatersolu[…]eservations/de.po |
| 11:06 | kidclamp | ah, that was the original |
| 11:06 | Joubu | this is what need to be copied and translated |
| 11:06 | ashimema | I see.. |
| 11:07 | Joubu | BUT the po is 8m old and there were some changes in the code in the meanwhile, so maybe it doesn't contain all the strings |
| 11:07 | kidclamp | when Lee got a new job we took it over |
| 11:07 | ashimema | coolios |
| 11:08 | ooh | |
| 11:08 | I should have read the README | |
| 11:08 | it's right there at the bottom | |
| 11:08 | kidclamp | hah, indeed |
| 11:09 | ashimema | nikkom.. see the 'Translations' section at the bottom of the page: https://github.com/bywatersolu[…]room-reservations |
| 11:09 | it walks you through creating the relevant files | |
| 11:09 | then you'll need to actually translate them.. i.e 'this english term is this turkish term'.. and submit them up to ByWater to have them included in the next release | |
| 11:10 | thanks kidclamp | |
| 11:13 | nikkom | thanks ashimema |
| 11:16 | nikkom joined #koha | |
| 11:18 | oleonard | o/ |
| 11:41 | ashimema | follow-up added to bug 29495.. wouldn't mind your review Joubu |
| 11:41 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29495 major, P5 - low, ---, martin.renvoize, Pushed to master , Issue link is lost in return claims when using 'MarkLostItemsAsReturned' |
| 11:42 | ashimema | we don't half have to jump through hoops because of our old_ chuff tables |
| 11:43 | Joubu | I still don't understand why you are talking about "old" |
| 11:43 | there is no link between returnclaims and old_issues | |
| 11:43 | ashimema | the issue is 'issues' and 'old_issues' |
| 11:43 | yes there is. | |
| 11:44 | Joubu | ho right, it's a dbic rs only |
| 11:44 | ashimema | yup |
| 11:44 | Joubu | not a column |
| 11:44 | ashimema | exactly |
| 11:44 | single column contains issue_id and may point to issues, old_issues or be null | |
| 11:45 | Joubu | weird to change one relation but the other |
| 11:45 | ashimema | ? |
| 11:45 | Joubu | you are changing both :D |
| 11:45 | ashimema | 🙂 |
| 11:54 | Joubu | ashimema: your patch smells. We shouldn't modify a dbic rs to make testbuilder happy |
| 11:54 | belongs_to seems correct to me | |
| 11:55 | does it even make sense to have might_have in issue and has_many in returnclaim? | |
| 11:55 | ashimema | mmm |
| 11:55 | Joubu | might_have is 1-1 |
| 11:55 | ashimema | might_have kinda makes sense |
| 11:55 | but.. | |
| 11:56 | causes that dbic warning telling you, you should be using belongs_to | |
| 11:56 | but belongs_to causes our TestBuilder failure | |
| 11:56 | Joubu | maybe testbuilder is wrong |
| 11:56 | ashimema | I'm not close enough to TestBuilder to know how to fix it from that direction |
| 11:56 | but would happily help to QA that if someone's willing to have a first stab | |
| 11:56 | Joubu | did you understand the root of the problem? |
| 11:56 | ashimema | the core issue is dbic relations assume a sane database schema |
| 11:57 | they don't handle a single column being an implicit foreing key to multiple tables.. which is what we have with our archive/old tables. | |
| 11:59 | Joubu | in my understand we are asking builder for generating a return claim, so it generates a bunch of relations, as expected. but why does it generates issue passing an issue_id when it's supposed to be a PK |
| 11:59 | and testbuilder knows that issue_id is a PK and that it shouldn't try to generate it | |
| 12:00 | ashimema | it creates issue fine I think.. it's when it then tries to create old_issue.. it passes the issue_id created in the first run when it creates issue |
| 12:00 | at least that's my best guess | |
| 12:00 | Joubu | hum, not sure about that, the error is: |
| 12:00 | Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 389. | |
| 12:00 | it's saying "Issue", not "OldIssue" | |
| 12:00 | ashimema | ok.. maybe it comes accrsso old issue as a relation first |
| 12:01 | then tries to create issue after | |
| 12:01 | either way.. I'm sure it's creating one from the first relation and then failing the create the next because the field is already populated | |
| 12:02 | I don't have a close enough understanding of test builder | |
| 12:05 | Joubu | ok, going for lunch, then I will present the sandboxes to Kohala workshop, then I will have a look at testbuilder :) |
| 12:05 | ashimema | thanks dude |
| 12:05 | I'm heading off for some lunch now myself | |
| 12:10 | cait1 | :) |
| 12:18 | schnydszch | Joubu: I have some questions re: biblibre sandbox |
| 12:20 | marion joined #koha | |
| 12:25 | schnydszch | or anybody who'd be able to answer re: signing off patches |
| 12:31 | oleonard | Ask, schnydszch, so that someone can answer if they can |
| 12:36 | schnydszch | yeah regarding bug 11873 that I am trying to sign off in biblibre sandbox I am getting <head><title>413 Request Entity Too Large</title></head>.. Failed to attach patch to bug 11873, status=413 |
| 12:36 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=11873 normal, P5 - low, ---, oleonard, Needs Signoff , Upgrade jstree jQuery plugin to the latest version |
| 12:36 | schnydszch | log can be seen here: https://sandboxes.biblibre.eu/signoff/t11873v2 |
| 12:37 | oleonard | schnydszch: The patch is too large to be attached from the sandbox. If you comment on the bug report that you have tested it and want to add your signoff I will add your signoff to the remote branch. |
| 12:38 | schnydszch | Yeah I commented on it. And I can see the tree like structure. So I am signing it off |
| 12:39 | I will comment on the bugzilla again oleonard | |
| 12:50 | marcelr joined #koha | |
| 12:50 | marcelr | hi #koha |
| 12:51 | oleonard | Thanks schnydszch ! |
| 12:51 | Hi marcelr | |
| 12:53 | marcelr | o/ |
| 13:30 | domm | I also have a bug signoff question: I followed this https://wiki.koha-community.or[…]gn_off_on_patches (for Bug 29893), but a) I worked on my github fork of Koha. Should I work on Koha-Community/Koha instead? |
| 13:30 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29893 critical, P5 - low, ---, jonathan.druart+koha, Needs Signoff , ElasticSearch Config UI deletes mappings |
| 13:31 | domm | and b) after running git format-patch -s origin/master I get a lot of new .patch files, where only one is the one I actually wanted to sign off |
| 13:31 | but what do I do with that file? attach to bugzilla? or somehow push to (which) git repo? | |
| 13:33 | oleonard | domm: You attach the signed-off patch to the bug report in Bugzilla |
| 13:33 | domm | oleonard: ok |
| 13:37 | Clr joined #koha | |
| 13:37 | Clr | hello here |
| 13:37 | clr = clrh same | |
| 13:44 | cait1 | domm: you should have a look at git-bz on the wiki - it makes it much easier |
| 13:45 | uploading the patches to bugzilla from command line | |
| 13:45 | if you use ktd or kohadevbox it'sprobably already there | |
| 13:45 | davewood | cait1: hi, i tweaked cronjobs/overdue_notices.pl quite a bit in order to create the output we need. that script isnt really written in a way that makes it easy to change things via command line params. :) |
| 13:46 | http://paste.scsys.co.uk/596437 | |
| 13:47 | cait1 | it's one of the older bits... i believe there is a bug about 'a lot of this shoudl be in a module' |
| 13:47 | but glad you got it working! | |
| 13:49 | Brooke joined #koha | |
| 13:49 | Brooke | 0/ |
| 13:53 | davewood | cait1: the csv file that is created by overdue_notices.pl is then fed to another script and a PDF including the list of all overdue books is created. one pdf file for each borrower. the code lives in a private repository. if its of interest to the community i could publish it somewhere. |
| 13:53 | marie-luce joined #koha | |
| 13:53 | davewood | but there is something in place that does a similiar thing, just in a different way. right? |
| 13:56 | cait1 | you mean creating pdf files? |
| 13:56 | you coudl also use a print template and then use some other scripts to turn this into a PDF I think | |
| 13:57 | there is a job called gather_notices.pl that I think does that | |
| 13:58 | domm | cait1: thanks, I managed to just attache the signed-off patch via the bugzilla web ui |
| 14:05 | cait1 | if you got there, remember to obsolete the older patch you replaced |
| 14:05 | you can do that via the edit function and then setting the obsolete checkbox | |
| 14:06 | i remember when I had to do that all the time... was very glad about git-bz when it appeared :) | |
| 14:10 | davewood | cait1: thanks for the input, next time i wills top by BEFORE i start. :) |
| 14:15 | magnuse | git-bz++ |
| 14:20 | cait1 | heh :) |
| 14:25 | oleonard | domm: I obsoleted the older patch for you |
| 14:25 | lukeg joined #koha | |
| 14:27 | Dyrcona joined #koha | |
| 14:32 | domm | ok, so I might will to look into git-bz :-) |
| 14:34 | (from my semi-external view the way to submit patches to Koha is rather cumbersome, but I understand that you have a lot of workflows in place that suit your needs. But a simple drive-by commit (which would be easy via a github PR) is suite a lot of work...) | |
| 14:37 | Joubu | git format-patch then attach the patch on the bug report should be enough |
| 14:40 | lukeg joined #koha | |
| 15:38 | marcelr | . |
| 15:53 | cait1 | domm: probably true, but we ahve also reformatted patches on bugs submitted in hte past, usually someone will help |
| 16:40 | bag joined #koha | |
| 17:17 | cait1 left #koha | |
| 18:01 | fridolin joined #koha | |
| 18:20 | reiveune | bye |
| 18:20 | reiveune left #koha | |
| 18:45 | gooble_gobble joined #koha | |
| 19:58 | Brooke joined #koha | |
| 19:58 | Brooke | 0/ |
| 20:03 | oleonard | Quittin' time for me! See y'all later |
| 20:07 | lukeg joined #koha | |
| 20:25 | ashimema | Evening |
| 20:27 | Brooke | good evening |
| 21:07 | lukeg joined #koha | |
| 21:30 | lukeg joined #koha | |
| 22:22 | lukeg joined #koha |
← Previous day | Today | Next day → | Search | Index