← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:29 | mtj | hi folks, ill build a new 21.05.05-2 package, with the db update added |
| 00:32 | cait: ^ :) | |
| 00:32 | cait | you're a hero |
| 00:32 | would yo umidn emailing the list? | |
| 00:33 | mtj ^ | |
| 00:33 | mtj | yes, will doo |
| 00:34 | cait | mtj++ mtj++ mtj++ |
| 01:56 | tuxayo | mtj++ |
| 01:56 | saved the day! | |
| 02:00 | cait1 joined #koha | |
| 05:25 | Oak joined #koha | |
| 07:54 | Oak joined #koha | |
| 09:16 | Oak joined #koha | |
| 10:02 | cait joined #koha | |
| 10:04 | Putti joined #koha | |
| 10:10 | Putti joined #koha | |
| 10:40 | Oak joined #koha | |
| 11:49 | Putti joined #koha | |
| 11:50 | Putti | cait, hi! Nice to see you doing QA as well :) |
| 11:50 | cait | the weekend shift :) |
| 11:50 | Putti | haha |
| 11:50 | cait | i am looking int o the ils-di patch right now |
| 11:51 | Putti | We have 66+26=92 bugs to review, I wonder if we are able to go through all those before the 21.11 release |
| 11:52 | cait | i was focusing in the qa queue number... where did you take yours? |
| 11:52 | Putti | the needs sign-off queue for bugs |
| 11:52 | cait | ah ok |
| 11:52 | i am also looking at the smaller enh still as they can still go in until next week | |
| 11:52 | wahanui | okay, cait. |
| 11:52 | Putti | I'm interested mostly on fixing bugs in koha, not new features |
| 11:53 | cait | that's totally ok :) |
| 11:54 | i tihnk we have a bit of a different 'bug' profile where we feel comfortable, so we should make a good team | |
| 11:58 | Putti: I'd be happy to see the "bad bugs" go down too... for numbers - some stuff stuck in doesn't appyl and failed QA probably too | |
| 11:59 | Putti | let me see what there is, but I think some of those were patches from me so I need you to qa ;) |
| 12:00 | cait | oi :) |
| 12:00 | some of yours are scary, but feel free to point me to them | |
| 12:01 | Putti | the mixing of prices was pretty simple |
| 12:01 | bug 14999 | |
| 12:01 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=14999 major, P5 - low, ---, joonas.kylmala, Signed Off , Adding to basket orders from staged files mixes up the prices and quantities between different orders |
| 12:01 | cait | ok, definitely scary |
| 12:01 | Putti | but the changes is trivial imho :D |
| 12:02 | cait | let me get there, I have some time tomorrow too |
| 12:03 | because of the freeze dates and statusthis one still has a little more time | |
| 12:26 | Putti | bug 29283 off the list :) |
| 12:26 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29283 major, P5 - low, ---, koha-bugs, Passed QA , Cannot delete basket with cancelled order for deleted biblio |
| 12:30 | cait | I had to fail the 'save and continue' :( |
| 12:30 | but glad i caught it after almost passing it | |
| 12:34 | now on bug 25883 | |
| 12:34 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=25883 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Show transfer on checkin screen |
| 12:47 | cait | on to bug 27296 |
| 12:47 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=27296 enhancement, P5 - low, ---, oleonard, Signed Off , Return claims should be filtered by default to show unresolved claims |
| 13:02 | Oak joined #koha | |
| 13:02 | Putti | looking at bug 29223... There was a new digest option added and what it does it send the individual messages and the digest message |
| 13:02 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29223 major, P5 - low, ---, nick, Signed Off , Auto-renewals can fail when not digested per branch and patron requests digest |
| 13:02 | Putti | and there was that bug too that 29223 fixes |
| 13:06 | cait | that doesn't sound intentional |
| 13:08 | Putti | added comment there but will open new bug reports, there seems to be actually 3 other bugs here |
| 13:08 | Andrew said something about the HomeOrHolding branch not being followed but I haven't confirmed that | |
| 13:09 | cait | thx for a great job done there |
| 13:10 | as the digest option is new it would be disappointing to see it not working well | |
| 13:10 | Putti | I actually opened bug 27259 earlier this year for HomeOrHoldingBranch |
| 13:10 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=27259 normal, P5 - low, ---, joonas.kylmala, Needs Signoff , HomeOrHoldingBranch is not used in all places |
| 13:10 | Putti | it affected fine calculation, I wonder if I should bumb that to major |
| 13:10 | cait | might be a good idea |
| 13:11 | Putti | but should add fix for automatic_renewal.pl there if what Andrew says it correct |
| 13:11 | is correct* | |
| 13:11 | cait | not sure without having a closer look |
| 13:11 | sometimes good to keep it in separate bugs if it's separate areas | |
| 13:12 | easier to get tested | |
| 13:26 | on flatpickr patches now | |
| 13:26 | bug 29121 | |
| 13:26 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29121 major, P5 - low, ---, tomascohen, Pushed to master , Plugins with broken ->install prevent access to the plugins list |
| 13:27 | cait | doesn't apply :( |
| 13:27 | oh, typo in bug number... ignore me | |
| 13:31 | Putti | oh no, there is yet another bug I discovered for the digest messages, it sends every day/cron run it cannot renew the book a message... |
| 13:31 | even if it is because it is not yet close to due date (auto_too_soon) | |
| 13:31 | I wonder if anyone actually uses this | |
| 13:32 | or some people are getting spammed :D | |
| 13:33 | anyway, out of the scope for this bug but i guess I'm gonna file a few bugs todya... | |
| 13:42 | cait | did you se tthe "don't renew before x days" in the circulation rules? |
| 13:42 | i haven't configured it in a while, but when the feature was first introduced that's how the library designed it | |
| 13:43 | the first renewal will be attempted according to that setting | |
| 13:43 | hm, i guess you did (auto_too_soon) | |
| 13:44 | i failed the opac flatpickr too... onto onboardng now | |
| 13:50 | Putti | cait, no, the problem is just that the digest code path is missing the if $error ne 'auto_too_soon' check that the individual message code path has |
| 13:50 | cait | yep sorry, I think might need a little break / lunch |
| 13:51 | the auto_too_soon was the hint i missed :) | |
| 13:54 | Putti | someone had opened already bug 23296 |
| 13:54 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=23296 enhancement, P5 - low, ---, kyle, NEW , Auto Renewal Notice does not use Library specific notices |
| 13:55 | cait | bug 28982 passed |
| 13:55 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=28982 enhancement, P5 - low, ---, oleonard, Passed QA , Use Flatpickr on onboarding pages |
| 13:56 | cait | we are intending to finish the flatpickr switch for 21.11 |
| 13:56 | so I'll try 29242 next | |
| 13:56 | bug 29242 | |
| 13:56 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29242 normal, P5 - low, ---, oleonard, Signed Off , Flatpickr - Should autocomplete be turned off? |
| 14:00 | Putti | bug 29381 opened for the digest spam |
| 14:00 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29381 major, P5 - low, ---, koha-bugs, NEW , Auto-renewal digest messages are sent on every cron run |
| 14:00 | Putti | is major OK? |
| 14:01 | you could disable this feature to lessen the impact :D | |
| 14:01 | so it is not too bad | |
| 14:02 | cait | yeah but it will be boldly advertised as a new fature in rlease notes |
| 14:02 | so I think major is very ok | |
| 14:24 | Putti | had to fail bug 29223 :( |
| 14:24 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29223 major, P5 - low, ---, nick, Failed QA , Auto-renewals can fail when not digested per branch and patron requests digest |
| 14:43 | cait | Putti: we have time to fix |
| 14:44 | already fialed 4 today too :( | |
| 14:44 | i am moving onto bug 29036 now | |
| 14:44 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29036 minor, P5 - low, ---, bolshawh, Signed Off , Accessibility: OPAC buttons don't have sufficient contrast |
| 14:54 | cait | failed... |
| 14:56 | * cait | sings *49 bugs in the queue* |
| 14:59 | cait | on bug 14783 now |
| 14:59 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=14783 enhancement, P5 - low, ---, bjorn.nylen, Signed Off , Allow patrons to change pickup location for non-waiting holds |
| 15:33 | cait | @later tell oleonard could you maybe check 1) on my comment on bug 14783 ? |
| 15:33 | huginn` | cait: The operation succeeded. |
| 15:38 | cait | Putti: taking a break, my brain hurts |
| 15:38 | Putti | mine too, I'm reading c4/circulation.pm :D |
| 15:45 | wwry joined #koha | |
| 15:46 | Putti | it is strange to me that the circulation event messages are sent to the patron based on the CirControl setting and not using the branch's template where the event happened |
| 15:47 | I think this must be a bug... E.g. AddRenewal's documentation says that the branch it takes as an input is the place where the transaction happened, not the branch which circulation rules were used | |
| 15:48 | but we are giving it the CircControl branch which to me seems wrong | |
| 15:48 | cait | hm for logging the transaction place would make sense |
| 15:48 | but i am a little out of my depth here | |
| 15:49 | Putti | AddRenewal uses the branch only for logging stats and sending the message to patron, it uses CircControl to actually calculate due dates etc |
| 15:50 | cait | might be a question to open for discusson on a bug |
| 15:50 | for logging males sense.... i understand the confusion about message | |
| 15:50 | switching to laundry for a whlie | |
| 15:51 | giving the brain a little rest | |
| 15:55 | Putti | in bug 23296 kelly mcelliot suggests to use CircControl so maybe it is actually wanted |
| 15:55 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=23296 enhancement, P5 - low, ---, kyle, NEW , Auto Renewal Notice does not use Library specific notices |
| 15:56 | Putti | we should just then update the CircControl documentation to say that is also affects messages sent |
| 15:56 | ..And the AddRenewal function documentation | |
| 16:00 | but... this seems so strange because SendCirculationAlert() also says in documentation that the branch should be where the action took place | |
| 16:00 | and not the branch from which the rules were used from | |
| 16:00 | so I wonder if there has been an unadvertised behaviour change at some point | |
| 16:05 | aha "bug 341: Use the Right Branch" | |
| 16:05 | huginn` | Bug https://bugs.koha-community.or[…]ow_bug.cgi?id=341 normal, P2, ---, chris, CLOSED FIXED, Add version 1.9.2 |
| 16:07 | cait | hm wondering the same |
| 16:07 | throwing in messages with circulation is maybe a bit much | |
| 16:07 | maybe this should be a separate switch instead? | |
| 16:09 | I don't understand the problem well enough to give a good opinion here I am afraid | |
| 16:09 | Putti | So before 2009 / before bug 341 the behaviour was to use the Letter template for the item's home branch |
| 16:10 | cait | hm ok |
| 16:10 | Putti | then after bug 341 we have followed the CircControl rule |
| 16:10 | cait | which letters are we talking about? all of them or a specific one? |
| 16:10 | Putti | so that behaviour has been since 2009 |
| 16:10 | Checkin, Checkout and Renewal | |
| 16:10 | cait | i think that# about the time I started out on Koha |
| 16:10 | what's the default cor circControl? *goes checking* | |
| 16:11 | ok home branch | |
| 16:11 | Putti: looking at circControl it has 3 options | |
| 16:12 | "the library you are logged in at" doesn't makes much sense, does it? | |
| 16:12 | for notice templates | |
| 16:12 | Putti | it doesn't, but it has an undocumented fallback |
| 16:12 | let me dig it out | |
| 16:14 | oh dear, maybe not that simple it has default of $item->{homebranch] if HomeOrHoldingBranch is 'holdingbranch' | |
| 16:14 | ah wait.. | |
| 16:15 | taking that back | |
| 16:16 | it uses homebranch if holdingbranch is not defined | |
| 16:16 | cait | hm that should not happen |
| 16:16 | Putti | anyway, so all good |
| 16:16 | cait | these prefs are really very confusing |
| 16:16 | Putti | yupppp |
| 16:16 | cait | we don't have a lot of libraries with branches (yet) |
| 16:17 | but we will have soon... so I guess I will have to learn more about those | |
| 16:18 | Putti | oh but... paying a fine which does auto renewal after it is paid doesn't follow CircControl |
| 16:18 | Koha::Account::Line.pm | |
| 16:18 | the renew_item() function | |
| 16:19 | cait | ok, now that sounds like a bug right? |
| 16:20 | i think htat feature was a quite recent add - oculd have been missed | |
| 16:20 | Putti | well, if we are supposed to follow it, if we assume it is a bug then that bug is also in the automatic_renewals.pl |
| 16:22 | cait | yay... |
| 16:23 | but i guess all renewals should work the same... | |
| 16:25 | Putti | opac-renew.pl also uses the default template for all branches when sending the renewal message |
| 16:28 | cait | i think the problem is also if you renew items from several branches (homebranch) |
| 16:28 | wahanui | okay, cait. |
| 16:28 | cait | you'd have to split the notice |
| 16:28 | into mulitple | |
| 16:28 | Putti | hmm.... another bug: Do we really send two renewal messages if using autorenewal and RenewalSendNotice = 1 |
| 16:28 | cait | we deal with this differently |
| 16:29 | Putti | so one generic renewal message and one autorenewal message |
| 16:29 | cait | sometimes we just use the patron homebranch template (for duedgst i tihnk) |
| 16:29 | Putti: actually, I don't know | |
| 16:30 | Putti | I have a bad feeling we do |
| 16:30 | cait | mmmh yeah, i feel that too |
| 16:30 | consistency and documentation would be great | |
| 16:31 | afk for a few minutes | |
| 16:32 | Putti | Bug 15705: Notify the user on auto renewing |
| 16:32 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=15705 enhancement, P5 - low, ---, jonathan.druart+koha, CLOSED FIXED, Notify the user on auto renewing |
| 16:32 | Putti | this seems to be the culprit |
| 16:32 | anyway... I'm drifting away from the original bug | |
| 16:36 | yup, I get two messages when the notices for renewals and auto-renewals are enabled, just tested | |
| 16:48 | bug 29382 | |
| 16:48 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29382 normal, P5 - low, ---, koha-bugs, NEW , Renewal message is sent twice during auto-renewal |
| 16:49 | Putti | <cait> you'd have to split the notice |
| 16:49 | <cait> into mulitple | |
| 16:49 | The auto-renewal script handles that by setting by having a setting --digest-per-branch | |
| 16:50 | cait | yes |
| 16:50 | Putti | if it is not enabled the global template is used |
| 16:50 | cait | but if you use circ control and item home branch |
| 16:50 | you'd have to split in soem cases anyway | |
| 16:50 | might be a case for circcontrol not being used for messages in general yet (and maybe it shouldn't?) | |
| 16:51 | Putti | <cait> you'd have to split in soem cases anyway |
| 16:51 | I don't understnad | |
| 16:51 | what cases? | |
| 16:51 | cait | when you have items from separate branches on your account |
| 16:51 | and item home branch is set | |
| 16:51 | and you renew | |
| 16:51 | Putti | a librarian renews? |
| 16:52 | cait | hm opac? |
| 16:52 | wahanui | opac is, like, using bootstrap v4.5.0 in 20.11 (bug 20168) |
| 16:52 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=20168 enhancement, P5 - low, ---, oleonard, RESOLVED FIXED, Update of the OPAC bootstrap template to bootstrap v4 |
| 16:52 | cait | ssh wahanui |
| 16:53 | i might just be very confused by now | |
| 16:53 | Putti | opac used the global default |
| 16:53 | cait | what if there was no default notice? |
| 16:53 | boom? | |
| 16:53 | Putti | there is always an empty message? |
| 16:53 | you cannot delete it or can you | |
| 16:54 | or do we have another bug | |
| 16:54 | cait | I dunno, some you can't |
| 16:54 | i think i would have expected the patron's home branch | |
| 16:54 | with a fall back to default | |
| 16:54 | Putti | I remember telling librarians to fill in all the notices even if they don't use them :D |
| 16:54 | just in case it gets used | |
| 16:54 | cait | always better to be on the safe side |
| 16:55 | Putti | Kelly excepted in bug 23296 the Circontrol one to be used |
| 16:55 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=23296 enhancement, P5 - low, ---, kyle, NEW , Auto Renewal Notice does not use Library specific notices |
| 16:55 | cait | yeah but i am not sure that's correct |
| 16:56 | Putti | I would maybe expect the item's checkout branch to be used |
| 16:56 | cait | i will comment on that bug |
| 16:56 | Putti | cait, oh yes... you can delete RENEWAL notice... |
| 16:56 | I guess it is then "boom" | |
| 16:58 | cait | argueing for a little simpler solution |
| 17:01 | ok, getting really confused now | |
| 17:01 | in 18.11 the preduedgst had thi snote here: | |
| 17:01 | arning, this is a template for a Digest, as such, any references to branch data ( e.g. branches.branchname ) will refer to the borrower's home branch. | |
| 17:01 | i appears to be gone in newer version | |
| 17:01 | s | |
| 17:04 | Oak joined #koha | |
| 17:06 | cait | Putti: commented on bug 23296 to what i think should be done there... hope it makes more sense than here |
| 17:06 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=23296 enhancement, P5 - low, ---, kyle, NEW , Auto Renewal Notice does not use Library specific notices |
| 17:06 | cait | bac to house chores for a bit |
| 17:07 | Putti | https://markmail.org/message/4[…]c4k+state:results I'm reading the original notification sending patch set discussion |
| 17:08 | cait | oh my |
| 17:08 | good luck | |
| 17:08 | Putti | what I think is that the original idea was to send the notification based on the template of the library where the action happened, but somehow it was missed that CircControl can have other branches too |
| 17:08 | cait | but that predates branch speicfic notices |
| 17:08 | they were added later | |
| 17:09 | 2009 that was not possible i think | |
| 17:09 | Putti | 2009 was when this patch was introduced |
| 17:09 | cait | that's circ notices yes |
| 17:09 | Putti | before that it was just homebranch |
| 17:09 | of the itme | |
| 17:09 | item | |
| 17:10 | cait | yeah, i think they are discussing which email/branch to print in the notice |
| 17:10 | there were no different templates yet | |
| 17:10 | so waht would <branches.branchname> print | |
| 17:11 | Putti | okay |
| 17:11 | cait | and if you need to split by homebranch... |
| 17:12 | Putti | for the hold pickup messages we use the template for the pickup library |
| 17:13 | so I have also a question for that, whether it should be the patron's branch or like that | |
| 17:13 | cait, any opinions? | |
| 17:16 | the hold pickup library being selected for the template basically means we are using the library template where the action happened | |
| 17:22 | the branch specific notices were introduced in bug 7001 | |
| 17:22 | huginn` | Bug https://bugs.koha-community.or[…]w_bug.cgi?id=7001 enhancement, P3, ---, srdjan, CLOSED FIXED, User Configurable Slips |
| 17:23 | Putti | comment #43 from Liz rea is good :P |
| 17:23 | Liz also bumbed into this circontrol being used problem | |
| 17:25 | cait | old stuff |
| 17:26 | i thnk pickup location makes a lot of sense | |
| 17:26 | it will list the opening hours etc | |
| 17:26 | so that's what you'd want to know for picking up something | |
| 17:26 | i think for hold notices it's actually easier, also because there is no digest option there right now | |
| 17:27 | "You will be happy to know that with CircControl set to "the library you are logged in at" the notices all work the way one would expect." | |
| 17:28 | but what is the expected behaviour? | |
| 17:28 | Putti | yeah.. the discussion stopped there, and this wasn't addressed before pushing the patches :/ |
| 17:29 | cait | i think at least we need to amend the pref description of circ control |
| 17:29 | if it's used in the code already... I at least had o clue | |
| 17:29 | no clue | |
| 17:29 | and it's also argue that sometimes it makes no sense to have them at the same setting... | |
| 17:29 | like for the hold notices it makes more sense as it is now, than to use circcontrol | |
| 17:30 | Putti | for checkin/checkout/renewal Liz seems to have thought it the same way as I do, the branch the action happened |
| 17:30 | for auto-renewal I'd say the branch is the branch where the checkout happened | |
| 17:30 | for opac renewal too | |
| 17:30 | cait | hm |
| 17:30 | that leads to possibly multiple noties generated | |
| 17:30 | by one opac renewal | |
| 17:31 | thta could be expected | |
| 17:31 | or not | |
| 17:31 | Putti | ah, we are talking about digest message for renewal? |
| 17:31 | cait | yeah, hey usually are digest |
| 17:31 | i think there is no single option | |
| 17:31 | the checkin checkout "collect" and are send every 15 minutes | |
| 17:32 | renewal too | |
| 17:32 | auto-renewal - i don#t know | |
| 17:32 | ok, as htey just added a dgst for auto renewa - it probably was not digested before... | |
| 17:32 | Putti | cait, there is only 1 digest message sent even in that case |
| 17:32 | "my $message = C4::Message->find_last_message($borrower, $type, $mtt);" | |
| 17:32 | cait | sorry, I might losing it |
| 17:32 | maybe better to put things in writing somewhere | |
| 17:33 | Putti | it is appended to the last RENEWAL message |
| 17:33 | without taking into account the branch | |
| 17:33 | cait | aah |
| 17:33 | yes, RENEWAL works like CHECKOUT... that makes sense as much as it can | |
| 17:34 | so all renewals that take place between runs of message_queue will be in the same notice | |
| 17:34 | Putti | hmm, but since it uses appending it selects the branch of the first renewal |
| 17:35 | if we were to pass the renewal branch to AddRenewal() | |
| 17:36 | this appending scheme is also here another source of problems... it caused full lock up of koha server in the past | |
| 17:36 | maybe enough bugs discoverd for today | |
| 17:36 | see you next week | |
| 17:36 | cait | same |
| 17:36 | have a great week Putti | |
| 17:36 | Putti | you too :) |
| 17:36 | cait | i'll think aout it, but have to leave too |
| 17:41 | Nemo_bis | nice bug session :) |
| 18:00 | tuxayo | Hi, I'm thinking about sending an email for translators to mention the upcoming string freeze of the major release. |
| 18:00 | The idea is that everything they do in 21.05 in the next 10 days will be copied over to 21.11 and they do it after, they would have the copy it between 21.05 and 21.11. So the more work now, the less work overall :) | |
| 18:00 | Does that makes sense? | |
| 19:06 | Oak joined #koha | |
| 21:09 | Oak joined #koha |
← Previous day | Today | Next day → | Search | Index