← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
Time | Nick | Message |
---|---|---|
02:28 | fridolin joined #koha | |
04:49 | lmstrand joined #koha | |
04:57 | lds joined #koha | |
05:07 | reiveune joined #koha | |
05:35 | gooble_gobble joined #koha | |
05:36 | oleonard joined #koha | |
05:39 | davidnind joined #koha | |
05:56 | fridolin joined #koha | |
06:06 | IgorAS joined #koha | |
06:24 | marcelr joined #koha | |
06:24 | marcelr | hi #koha |
06:28 | reiveune | hello |
06:29 | Oak joined #koha | |
06:44 | alex_a joined #koha | |
06:44 | marcelr | o/ |
06:44 | alex_a | Bonjour |
06:45 | cait joined #koha | |
06:50 | Oak joined #koha | |
07:04 | cait joined #koha | |
07:05 | cait joined #koha | |
07:06 | cait joined #koha | |
07:08 | cait joined #koha | |
07:10 | cait1 joined #koha | |
07:13 | * ashimema | isn't around today.. apologies |
07:18 | cait1 | ashimema: hope for fun reasons, have a nice day |
07:26 | ashimema | Yup, day off with the kids :-) |
07:27 | Have a good day #koha | |
07:27 | Joubu | Enjoy, ashimema! |
07:41 | marcelr | hi ashimema |
07:43 | getting back to Koha/Email; not yet in the stage i hoped it to be | |
07:43 | ashimema | Mmm, |
07:44 | marcelr | not your change especially ashimema; the whole thing raises questions |
07:44 | so i will probably need to open new report(s) | |
07:44 | why did i join qa? | |
07:46 | cait1 | marcelr: I am not sure I want to try and answer that question |
07:46 | ashimema | Yeah, I think some of the ideas behind the change we're good.. but there clearly wasn't enough understanding of the entire process |
07:46 | cait1 | but glad we just elected you again... :) |
07:46 | ashimema | The attachments stuff has me challenged.. |
07:46 | cait1 | and me worried |
07:46 | ashimema | The whole flow is different now |
07:46 | cait1 | it could be a blcoker for our upcoming update |
07:46 | ashimema | Mmm, we use it too.. |
07:46 | marcelr | it wasnt ready when it got pushed |
07:46 | Joubu | marcelr: did you confirm it's broken? |
07:46 | cait1 | we patched up the return path - but of course we need it fixed in Koha properly, the attachements probably arenot so easy to bandaid |
07:47 | ashimema | Anoying thing is.. I could have sworn I tested that area when QAing |
07:47 | Not yet | |
07:47 | marcelr | Joubu broken is not the right word |
07:47 | ashimema | Code wise I can see why it would be though |
07:47 | marcelr | shaky |
07:47 | ashimema | The flow has changed |
07:47 | Joubu | talking about bug 28729 or bug 29330? |
07:47 | marcelr | het rammelt |
07:47 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=28729 critical, P5 - low, ---, martin.renvoize, BLOCKED , Return-path header not set in emails |
07:47 | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29330 blocker, P5 - low, ---, koha-bugs, NEW , Koha cannot send emails with attachments using Koha::Email and message_queue table | |
07:47 | ashimema | Before this work we basically built 99% of the actually email before storing.. now we build most of it just before sending . |
07:48 | marcelr | 28729 first |
07:48 | ashimema | I'm happy return path works . Tested on a couple of live servers with complex requirements |
07:48 | But I'm glad to see marcelr doing due diligence in QA.. | |
07:49 | It's a complex area.. more eyes the better | |
07:49 | marcelr | different MTAs etc |
07:50 | its a minefield | |
07:50 | fridolin | https://demo.biblibre.com Treats or Tricks ... |
07:50 | cait1 | I am just glad we are past the discussion if this ever worked... that was frustrating to me tbh |
07:50 | Joubu | my $bibno = 123; # just a number - Marcel, is that you? :D |
07:50 | cait1 | becaue we rely heavily on it |
07:51 | ashimema | Attachments wise I'm not sure what path to take.. either split attachments back out of the message queue and into their own table and then construct the email at the last minute.. or leave storage as is and start passing more fully formed email formed email objects to send.. and deal with that |
07:51 | marcelr | hmm |
07:51 | thats my signature yes who used it ? | |
07:51 | Joubu | t/db_dependent/TestBuilder.t |
07:51 | yes it's from you | |
07:51 | marcelr | ah yes |
07:51 | Joubu | and test fails if bib 123 does not exist ;) |
07:51 | marcelr | sweet TestBuilder |
07:51 | you should have one | |
07:52 | haha | |
07:52 | Joubu | no more true |
07:52 | marcelr | did we add a FK or so ? |
07:52 | lazy testing | |
07:53 | Joubu | I should send an email to koha-devel about it. Since bug 19821 we are testing Koha_Master on top of a selenium test that will test the installer process |
07:53 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=19821 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Run tests on a separate database |
07:54 | Joubu | So basically, Jenkins has 2 types of run, the LIGHTs and fulls. Koha_Master is the only one running the full run (including www and selenium tests) |
07:54 | * LIGHTs will run prove **/*.t without www and selenium in random order | |
07:55 | marcelr | hmm |
07:55 | Joubu | * Koha_Master will: 1. DROP+CREATE the DB, 2. restart_all, 3. Run selenium test 00-onboarding.t, 4. Repeat 1,2 5 Run selenium test 01-installer.t + all other tests in random order |
07:55 | https://gitlab.com/koha-commun[…]files/run.sh#L225 | |
07:55 | it's there ^^ | |
07:55 | marcelr | the random order might show nice new bugs |
07:56 | Joubu | it was random already |
07:56 | marcelr | ok |
07:56 | Joubu | prove -s |
07:56 | the good thing is that very few tests are failing | |
07:57 | marcelr | just before release, thats pretyy |
07:57 | Joubu | the bad one is that www/search_utf8.t is failing, and it seems (in my understanding) that we have been mocking zebra index wrongly for years |
07:57 | marcelr | mocks are great and misleading |
07:57 | Joubu | that was waiting for 1.5 years in PQA |
07:57 | marcelr | maturing |
07:59 | ashimema | Mmm, I'm always wary of mocks |
07:59 | If manageable I do like integration tests | |
07:59 | Joubu | the problem is the zebra index |
08:00 | you don't want to touch the one for the instance ideally | |
08:00 | ashimema | Mmm.. it's not an easy one |
08:00 | Joubu | I always thought it was working, but apparently it does not |
08:00 | ashimema | We all know how long the dB stuff took.. hense not being able to test the installer |
08:01 | Not saying it easy ... Mocks have their place | |
08:01 | Just easy to hide thing with mocks | |
08:01 | Joubu | not if correctly done |
08:01 | B needs A | |
08:01 | test A correctly | |
08:01 | then you can test B mocking A behaviour | |
08:01 | as you know it's tested already | |
08:04 | marcelr | sometimes a stupid mock gives false feeling of safety |
08:04 | useless testing etc | |
08:31 | alex_a joined #koha | |
09:03 | Joubu | marcelr: please keep in mind we are getting closer to the release and we need an efficient fix |
09:04 | ie. not exploding everything and rebuilding the email code from scratch | |
09:04 | marcelr | yes a minimal fix and a large follow-up preferably from tcohen :) |
09:05 | but my hands were shaking | |
09:05 | cait1 | *thumbs up* |
09:05 | we also need backports | |
09:05 | marcelr | therefore minimal fix |
09:05 | so Joubu feature freeze does not apply here | |
09:06 | this is a bug that doesnt even touch translation | |
09:16 | cait1 | Spammers are going wild again these last few days |
09:17 | marcelr: true, but good to resolve soon and before release still | |
09:17 | marcelr | sure cait1 but I am not gonna rush this one today; i spent hours already btw |
09:22 | cait1 | yes, not meant it taht way either |
09:22 | before release != unlike today | |
09:22 | good to get it right too instead of hurrying | |
09:24 | fridolin | see u |
09:24 | fridolin left #koha | |
09:50 | Joubu | oleonard: Where are we with flatpickr? Noticed the cataloguing plugins? |
09:50 | cataloguing/value_builder/dateaccessioned.pl has datepicker and I don't see patch on bugzilla | |
10:18 | oleonard | Joubu: That one and offline circ are the last I think |
10:23 | Oak joined #koha | |
10:25 | cait joined #koha | |
10:30 | khall joined #koha | |
10:32 | tcohen | hola #koha |
10:43 | oleonard | Hi tcohen |
10:50 | Bug 29369 | |
10:50 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29369 enhancement, P5 - low, ---, oleonard, Needs Signoff , Use Flatpickr in dateaccessioned cataloging plugin |
10:50 | oleonard | Thanks for catching that one Joubu, I'd missed it. |
10:52 | nugged | oleonard, 👍 |
10:53 | kidclamp joined #koha | |
10:54 | * oleonard | grumbles about offline circ |
11:00 | koha-jenkins | Project Koha_21.05_U16 build #83: FAILURE in 20 min: https://jenkins.koha-community[…]oha_21.05_U16/83/ |
11:01 | Project Koha_21.05_U_Stable build #77: STILL FAILING in 21 min: https://jenkins.koha-community[…]1.05_U_Stable/77/ | |
11:09 | kellym joined #koha | |
11:12 | Oak joined #koha | |
11:23 | koha-jenkins | Project Koha_21.05_D12 build #16: FAILURE in 21 min: https://jenkins.koha-community[…]oha_21.05_D12/16/ |
11:23 | Project Koha_21.05_D9 build #81: FAILURE in 22 min: https://jenkins.koha-community[…]Koha_21.05_D9/81/ | |
11:26 | cait1 | oleonard: i was wondering too - so if I catch any non-flatpickr thigns now, file right away? |
11:26 | oleonard | Yup |
11:26 | khall_ joined #koha | |
11:26 | cait1 | okeydokey :) |
11:27 | and thx for providing patches to some of the bugs I filed | |
11:27 | I saw and was happy, but couldn'treally follow-up yet | |
11:30 | koha-jenkins | Project Koha_21.05_D11 build #101: FAILURE in 6 min 18 sec: https://jenkins.koha-community[…]ha_21.05_D11/101/ |
11:37 | Project Koha_21.05_U21 build #8: SUCCESS in 56 min: https://jenkins.koha-community[…]Koha_21.05_U21/8/ | |
11:37 | Project Koha_21.05_U16 build #84: STILL FAILING in 14 min: https://jenkins.koha-community[…]oha_21.05_U16/84/ | |
11:40 | Project Koha_21.05_U20 build #88: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]oha_21.05_U20/88/ | |
11:40 | Project Koha_21.05_U_Stable build #78: STILL FAILING in 10 min: https://jenkins.koha-community[…]1.05_U_Stable/78/ | |
11:42 | Joubu | oleonard: credit goes to nugged :) |
11:45 | koha-jenkins | Project Koha_21.05_D10 build #126: UNSTABLE in 1 hr 6 min: https://jenkins.koha-community[…]ha_21.05_D10/126/ |
11:50 | Project Koha_21.05_D11 build #102: STILL FAILING in 9 min 39 sec: https://jenkins.koha-community[…]ha_21.05_D11/102/ | |
11:51 | Project Koha_21.05_U18 build #79: SUCCESS in 1 hr 11 min: https://jenkins.koha-community[…]oha_21.05_U18/79/ | |
12:01 | Project Koha_21.05_D9 build #82: STILL FAILING in 22 min: https://jenkins.koha-community[…]Koha_21.05_D9/82/ | |
12:15 | Joubu | tcohen: ? |
12:31 | koha-jenkins | Yippee, build fixed! |
12:31 | wahanui | Congratulations! |
12:31 | koha-jenkins | Project Koha_21.05_D12 build #17: FIXED in 54 min: https://jenkins.koha-community[…]oha_21.05_D12/17/ |
12:36 | tcohen | Joubu: |
12:39 | oleonard | oleonard: ~ |
12:49 | koha-jenkins | Yippee, build fixed! |
12:49 | wahanui | Congratulations! |
12:49 | koha-jenkins | Project Koha_21.05_U_Stable build #79: FIXED in 1 hr 4 min: https://jenkins.koha-community[…]1.05_U_Stable/79/ |
12:49 | Yippee, build fixed! | |
12:49 | wahanui | Congratulations! |
12:49 | koha-jenkins | Project Koha_21.05_D9 build #83: FIXED in 47 min: https://jenkins.koha-community[…]Koha_21.05_D9/83/ |
12:49 | Yippee, build fixed! | |
12:49 | wahanui | Congratulations! |
12:49 | koha-jenkins | Project Koha_21.05_D11 build #103: FIXED in 57 min: https://jenkins.koha-community[…]ha_21.05_D11/103/ |
12:51 | Yippee, build fixed! | |
12:51 | wahanui | Congratulations! |
12:51 | koha-jenkins | Project Koha_21.05_U16 build #85: FIXED in 1 hr 11 min: https://jenkins.koha-community[…]oha_21.05_U16/85/ |
12:58 | tcohen joined #koha | |
13:01 | Dyrcona joined #koha | |
13:02 | koha-jenkins | Project Koha_21.05_U16 build #86: SUCCESS in 1 hr 10 min: https://jenkins.koha-community[…]oha_21.05_U16/86/ |
13:05 | NateC joined #koha | |
13:16 | khall joined #koha | |
13:22 | koha-jenkins | Project Koha_21.05_U21 build #9: SUCCESS in 32 min: https://jenkins.koha-community[…]Koha_21.05_U21/9/ |
13:25 | khall_ joined #koha | |
13:26 | koha-jenkins | Project Koha_21.05_U20 build #89: SUCCESS in 55 min: https://jenkins.koha-community[…]oha_21.05_U20/89/ |
13:28 | Project Koha_21.05_D11 build #104: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_21.05_D11/104/ | |
13:29 | oleonard | Okay all you offline circulation fans, have at Bug 29228 |
13:29 | huginn` | Bug https://bugs.koha-community.or[…]_bug.cgi?id=29228 enhancement, P5 - low, ---, oleonard, Needs Signoff , Use Flatpickr on offline circulation page |
13:49 | News from kohagit: Bug 29368: Fix remove_from_cart <https://git.koha-community.org[…]eb9d5fcfb99c8c51c> | |
13:49 | News from kohagit: Bug 29374: Don't crash if search engine returns a deleted record <https://git.koha-community.org[…]986002a34b0d41cce> | |
13:49 | News from kohagit: Bug 29368: Correctly mock Zebra index from tests <https://git.koha-community.org[…]88ab0710fb66d0c3d> | |
13:49 | News from kohagit: Bug 29364: Revert changes to framework visibility made by Search.t <https://git.koha-community.org[…]b2558ee801b1bd7d6> | |
13:49 | News from kohagit: Bug 29363: Fix TestBuilder.t if bib 123 does not exist <https://git.koha-community.org[…]f3c9e165cc088c7b2> | |
13:54 | koha-jenkins | Project Koha_21.05_U16 build #87: SUCCESS in 1 hr 3 min: https://jenkins.koha-community[…]oha_21.05_U16/87/ |
13:55 | Project Koha_21.05_D12 build #18: SUCCESS in 33 min: https://jenkins.koha-community[…]oha_21.05_D12/18/ | |
13:57 | Oak joined #koha | |
13:57 | koha-jenkins | Yippee, build fixed! |
13:57 | wahanui | Congratulations! |
13:57 | koha-jenkins | Project Koha_21.05_D10 build #127: FIXED in 1 hr 8 min: https://jenkins.koha-community[…]ha_21.05_D10/127/ |
14:07 | Project Koha_21.05_U20 build #90: UNSTABLE in 38 min: https://jenkins.koha-community[…]oha_21.05_U20/90/ | |
14:13 | Project Koha_21.05_U18 build #80: SUCCESS in 1 hr 11 min: https://jenkins.koha-community[…]oha_21.05_U18/80/ | |
14:22 | Project Koha_21.05_U_Stable build #80: FAILURE in 27 min: https://jenkins.koha-community[…]1.05_U_Stable/80/ | |
14:26 | Project Koha_Master_U_Stable build #300: NOW UNSTABLE in 1 hr 0 min: https://jenkins.koha-community[…]ter_U_Stable/300/ | |
14:33 | Project Koha_21.05_D9 build #84: SUCCESS in 37 min: https://jenkins.koha-community[…]Koha_21.05_D9/84/ | |
14:45 | Yippee, build fixed! | |
14:45 | wahanui | Congratulations! |
14:45 | koha-jenkins | Project Koha_21.05_U20 build #91: FIXED in 38 min: https://jenkins.koha-community[…]oha_21.05_U20/91/ |
14:50 | Oak joined #koha | |
14:55 | dhart joined #koha | |
14:59 | koha-jenkins | Project Koha_21.05_U21 build #10: SUCCESS in 1 hr 1 min: https://jenkins.koha-community[…]oha_21.05_U21/10/ |
15:06 | Project Koha_21.05_D12 build #19: SUCCESS in 33 min: https://jenkins.koha-community[…]oha_21.05_D12/19/ | |
15:09 | Project Koha_21.05_D10 build #128: SUCCESS in 56 min: https://jenkins.koha-community[…]ha_21.05_D10/128/ | |
15:20 | reiveune | bye |
15:21 | reiveune left #koha | |
15:21 | koha-jenkins | Project Koha_21.05_U16 build #88: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_21.05_U16/88/ |
15:22 | Project Koha_21.05_D11 build #105: SUCCESS in 37 min: https://jenkins.koha-community[…]ha_21.05_D11/105/ | |
15:26 | NateC_ joined #koha | |
15:27 | koha-jenkins | Project Koha_21.05_U18 build #81: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]oha_21.05_U18/81/ |
15:42 | cait joined #koha | |
15:52 | cait joined #koha | |
15:54 | koha-jenkins | Project Koha_Master_D12 build #14: SUCCESS in 54 min: https://jenkins.koha-community[…]ha_Master_D12/14/ |
15:59 | LP_ joined #koha | |
15:59 | LP_ | Hello? |
15:59 | wahanui | Hello is anyone able to test doing an opac search in master with no plugins installed? |
15:59 | oleonard-away | wahanui: forget Hello |
15:59 | wahanui | oleonard-away: I forgot hello |
15:59 | LP_ | Could somone help me with the room booking plugin i keep getting eror 403 |
16:00 | i've installed the KPM and altered by apache config | |
16:00 | koha-jenkins | Project Koha_Master_D11 build #434: SUCCESS in 50 min: https://jenkins.koha-community[…]a_Master_D11/434/ |
16:00 | LP_ | kpz rather |
16:02 | anyone know if theirs an install guide anywheres? | |
16:02 | there | |
16:03 | koha-jenkins | Project Koha_Master_U21 build #12: FAILURE in 3 min 13 sec: https://jenkins.koha-community[…]ha_Master_U21/12/ |
16:05 | Project Koha_Master_D11_MDB_Latest build #715: SUCCESS in 42 min: https://jenkins.koha-community[…]1_MDB_Latest/715/ | |
16:06 | Oak joined #koha | |
16:18 | koha-jenkins | Yippee, build fixed! |
16:18 | wahanui | Congratulations! |
16:18 | koha-jenkins | Project Koha_Master_D11_CPAN build #464: FIXED in 34 min: https://jenkins.koha-community[…]ter_D11_CPAN/464/ |
16:20 | Project Koha_Master_U20 build #229: SUCCESS in 59 min: https://jenkins.koha-community[…]a_Master_U20/229/ | |
16:26 | Project Koha_Master_D11_My8 build #681: SUCCESS in 59 min: https://jenkins.koha-community[…]ster_D11_My8/681/ | |
16:41 | oleonard-away | Why can't I batch delete ILL patrons? |
16:50 | koha-jenkins | Yippee, build fixed! |
16:50 | wahanui | Congratulations! |
16:50 | koha-jenkins | Project Koha_21.05_U_Stable build #81: FIXED in 31 min: https://jenkins.koha-community[…]1.05_U_Stable/81/ |
16:52 | Project Koha_21.05_D10 build #129: UNSTABLE in 47 min: https://jenkins.koha-community[…]ha_21.05_D10/129/ | |
17:04 | Project Koha_Master build #1804: STILL UNSTABLE in 1 hr 10 min: https://jenkins.koha-community[…]Koha_Master/1804/ | |
17:19 | Project Koha_21.05_U16 build #89: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_21.05_U16/89/ | |
17:21 | Project Koha_Master_D9 build #1809: SUCCESS in 1 hr 18 min: https://jenkins.koha-community[…]a_Master_D9/1809/ | |
17:26 | Project Koha_21.05_D9 build #85: SUCCESS in 36 min: https://jenkins.koha-community[…]Koha_21.05_D9/85/ | |
17:27 | Yippee, build fixed! | |
17:27 | wahanui | Congratulations! |
17:27 | koha-jenkins | Project Koha_Master_U_Stable build #301: FIXED in 1 hr 0 min: https://jenkins.koha-community[…]ter_U_Stable/301/ |
17:32 | Project Koha_21.05_U21 build #11: SUCCESS in 40 min: https://jenkins.koha-community[…]oha_21.05_U21/11/ | |
17:43 | NateC_ joined #koha | |
17:54 | cait1 left #koha | |
17:55 | cait joined #koha | |
17:58 | koha-jenkins | Project Koha_21.05_U20 build #92: SUCCESS in 31 min: https://jenkins.koha-community[…]oha_21.05_U20/92/ |
17:58 | Project Koha_Master_D12 build #15: SUCCESS in 54 min: https://jenkins.koha-community[…]ha_Master_D12/15/ | |
18:04 | cait joined #koha | |
18:10 | koha-jenkins | Project Koha_21.05_D11 build #106: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_21.05_D11/106/ |
18:10 | Project Koha_21.05_D12 build #20: SUCCESS in 49 min: https://jenkins.koha-community[…]oha_21.05_D12/20/ | |
18:14 | Project Koha_21.05_U_Stable build #82: FAILURE in 3 min 21 sec: https://jenkins.koha-community[…]1.05_U_Stable/82/ | |
18:20 | Project Koha_21.05_U18 build #82: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]oha_21.05_U18/82/ | |
18:28 | Project Koha_Master_D9 build #1810: SUCCESS in 1 hr 1 min: https://jenkins.koha-community[…]a_Master_D9/1810/ | |
18:34 | Project Koha_Master_D11_MDB_Latest build #716: SUCCESS in 36 min: https://jenkins.koha-community[…]1_MDB_Latest/716/ | |
18:51 | Project Koha_Master_D11_My8 build #682: SUCCESS in 40 min: https://jenkins.koha-community[…]ster_D11_My8/682/ | |
18:55 | Project Koha_Master_U20 build #230: SUCCESS in 56 min: https://jenkins.koha-community[…]a_Master_U20/230/ | |
19:03 | NateC_ joined #koha | |
19:19 | koha-jenkins | Project Koha_21.05_D9 build #86: SUCCESS in 59 min: https://jenkins.koha-community[…]Koha_21.05_D9/86/ |
19:25 | Project Koha_21.05_U18 build #83: SUCCESS in 1 hr 11 min: https://jenkins.koha-community[…]oha_21.05_U18/83/ | |
19:28 | Project Koha_Master_U_Stable build #302: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]ter_U_Stable/302/ | |
19:33 | gooble_gobble joined #koha | |
19:51 | kellym left #koha |
← Previous day | Today | Next day → | Search | Index