← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
Time | Nick | Message |
---|---|---|
04:54 | chriss joined #koha | |
06:10 | cait joined #koha | |
06:11 | cait1 joined #koha | |
06:13 | cait1 | good morning #koha |
06:16 | lds joined #koha | |
06:20 | marcelr joined #koha | |
06:20 | marcelr | hi #koha |
06:24 | cait1 | hi marcelr |
06:27 | magnuse | \o/ |
06:28 | bug 28901 | |
06:28 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=28901 normal, P5 - low, ---, oleonard, NEW , showCart incorrectly calculates position if content above navbar |
06:37 | Joubu | mtj[m]: are you around? |
06:39 | mtj | hi Joubu |
06:39 | wahanui | hi Joubu are you around? |
06:39 | Joubu | mtj[m]: http://paste.koha-community.org/2474 # Why 3.14? |
06:39 | it's stretch on ktd | |
06:40 | On bug 28800, they have 0.97 | |
06:40 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=28800 normal, P5 - low, ---, koha-bugs, NEW , Library list at /cgi-bin/koha/admin/branches.pl appears empty |
06:40 | mtj | probably a mistake by me |
06:42 | Joubu | Do you know if 097 for stretch is ok? |
06:42 | I think it is, but it's too early, and it's Friday | |
06:43 | alex_a joined #koha | |
06:44 | alex_a | Bonjour |
06:44 | mtj | Joubu: for 21.05.02 on deb9 - i think 0.97 is too low |
06:45 | Joubu | it's what requires the cpanfile :-/ |
06:48 | mtj | hmm, cpanfile is incorrect then |
06:50 | i think we will probably have to update the cpanfile manually, for now,., | |
06:51 | Joubu | that's not normal our CI does not reflect the problem |
06:51 | mtj | generating a cpanfile from debian/control caused some breakage |
06:53 | Joubu: correct, the install in bz 28800 is not normal | |
06:55 | you can see an install log of 21.05.02 on deb9 here.. -> https://gitlab.com/mjames/ktd-[…]-/jobs/1531984811 | |
06:56 | Installed: 3.25+dfsg-1+koha3 | |
06:56 | (its a mirror of the kc repo) | |
07:19 | Joubu | weird, maybe they have installed it from cpan them? |
07:20 | mtj: will you comment on the bug or do you want me to? | |
07:20 | mtj | Joubu: yeah probably cpan, i can comment :) |
07:25 | Joubu: now that deb11/bullseye is stable, we may need to move some deb packages about | |
07:26 | perhaps try to move to json-validator 4.x, which has less tricky XS deps | |
07:26 | janPasi joined #koha | |
07:31 | mtj | ..its not urgent, but it should solve some pkging problems |
07:32 | Joubu | I think we are not ready for v4 yet, that's why we are still stuck at 3.25 |
07:35 | mtj | agreed, i have not attempted to test/upgrade with v4 yet |
07:37 | Joubu | we need to adapt the code |
07:39 | ashimema | morning #koha |
07:40 | marcelr | hi ashimema |
07:57 | cait1 | hi ashimema |
07:58 | * ashimema | was feeling refreshed after vacation.. but then he looked at rebasing bug 11175 |
07:58 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=11175 enhancement, P5 - low, ---, joonas.kylmala, Signed Off , Show the parent record's component parts in the detailed views |
07:58 | sophie_m joined #koha | |
08:00 | marcelr | ashimema: nothing better than a few rebases to get rid of your vacation mood |
08:00 | ashimema | indeed |
08:00 | sooo much has changed in a week.. :( | |
08:01 | Joubu | really? |
08:02 | I haven't pushed mush for the last couple of months! | |
08:02 | ashimema | I was surprised.. clearly I just happen to be touching code that moved |
08:02 | for example.. bug 12561 affects it | |
08:02 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=12561 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Remove non-XSLT views |
08:03 | Joubu | should be easy then, it only removed code :) |
08:04 | ashimema | yup.. I'm just being extra vigilent to make sure I don't re-introduce it ;) |
08:04 | it also changes the prototype.. but that's fine.. I just need to make sure I account for that | |
08:42 | magnuse | ashimema++ |
08:44 | ashimema | done :) |
08:48 | cait1 | ashimema++ :) |
08:49 | ashimema | now onto the next thing.. the email backlog |
09:01 | magnuse | such fun! |
09:02 | Joubu | tcohen: ping me when around please (28870 - 28803) |
09:02 | ere joined #koha | |
09:16 | * ashimema | was just wondering about that |
09:24 | cait1 | hm I am seeing a display:block on the element in my code... but it's not in the template |
09:24 | anyone an idea how that could get there? | |
09:25 | it's not done by userjs | |
09:25 | ...or usercss afaikt | |
09:25 | Oak joined #koha | |
09:34 | petrova joined #koha | |
09:47 | cait1 left #koha | |
10:18 | alex_a joined #koha | |
10:21 | oleonard | Hi #koha |
10:23 | nugged | \o/ |
11:01 | tcohen | hola |
11:01 | wahanui | niihau, tcohen |
11:02 | tcohen | holaaaa |
11:05 | Joubu: pong | |
11:05 | ashimema | Ping |
11:08 | tcohen | hola ashimema |
11:08 | wb | |
11:09 | ashimema | :) |
11:09 | tcohen | Joubu: shouldn't we go add Koha::Email::Address instead? |
11:09 | * ashimema | is reminding his brain how item groups (formerly Volumes) works so he can QA |
11:09 | ashimema | looks pretty solid on first inspection.. well.. more like 5th inspection.. but it's moved a bit again @:) |
11:10 | tcohen | ashimema: it is simpler now I think |
11:10 | he | |
11:10 | ashimema | hehe |
11:10 | yeah | |
11:10 | tcohen | the only *big* issue I had found was the UNIQUE constraint |
11:11 | otherwise, solid dev from khall | |
11:11 | * ashimema | is slightly confused by the Koha::Email stuff now |
11:11 | tcohen | Email::Valid doesn't handle UTF-8 chars correctly |
11:11 | so doesn't properly validate addresses | |
11:11 | ashimema | I feel like it's a bit weird that Koha::Email->create can throw exceptions which aren't caught |
11:12 | i.e. I'm not even sure any more where we should be doing the email validation step.. it feels sorta odd doing it inside Koha::Email->create.. | |
11:12 | especially is we validate a bunch of emails in there but only send back an invalid exception without which one is invalid.. I think | |
11:12 | going on memory of writing my bug | |
11:13 | and I agree.. replacing Email::Valid with Email::Address seem the right thing to do.. | |
11:13 | tcohen | there are two different email addresses |
11:13 | those that have been stored on the DB | |
11:13 | ashimema | indeed |
11:13 | tcohen | and the ones that come from user inpu |
11:13 | t | |
11:13 | (sending a cart) | |
11:13 | ashimema | indeed |
11:14 | but I feel like we should be consistent in how/where we throw exceptions for invalid emails.. | |
11:14 | tcohen | in my opinion, we should have a wrapper class for emails, that throws the exception and we move around such objects |
11:14 | cait joined #koha | |
11:15 | ashimema | i.e. either we should check before calling Koha::Email->create and thus create shouldn't do the check on top.. or we should check inside create and always wrap calls to it in a try/catch block that spots and handles the various exceptions it can throw? |
11:15 | and yeah.. I think the idea of an email wrapper object is great.. gives us more flexability overall.. | |
11:16 | so.. should Koha::Email->create require that Koha::Email::Address's are passed in.. rather than text.. | |
11:16 | tcohen | the thing is |
11:16 | the main purpose of Koha::Email now, is to wrap our business | |
11:17 | so a syspref tells everything shuold be bcc to some address | |
11:17 | we do it here | |
11:17 | ashimema | in which case we build K::E::Address objects (which do validation) and catch errors before throwing those at Koha::Email->create (wrapped in a try/catch that catches invalid params sent.. i.e non Koha::Email::Addresses) ? |
11:18 | tcohen | you don't want to check the fallback From in every place we queue an email |
11:19 | you want it automatic | |
11:19 | ashimema | agreed |
11:27 | oleonard | Man we are hurtling towards Bug 30000 |
11:27 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=30000 could not be retrieved: InvalidBugId |
11:27 | oleonard | Just you wait huginn |
11:31 | cait | probably going to be something boring again :) |
11:31 | tcohen: i am glad to see discussion about the email - but please keep backporting in mind | |
11:32 | oleonard | cait: Did you figure out your "display:block" question? |
11:43 | ashimema | hmm.. are our modals deliberately narrow ? |
11:44 | https://nimb.ws/SYKQVc | |
11:46 | oleonard | ashimema: The default Bootstrap 3 modal is 600px wide |
11:47 | ashimema | I see |
11:47 | oleonard | You can use <div class="modal-dialog modal-wide"> to make it wider. |
11:47 | ashimema | I always forget we're on 3 |
11:47 | I was using modal-xl | |
11:47 | that's 4 | |
11:47 | thanks | |
11:48 | * ashimema | is contemplating if a modal is right for this or not |
11:48 | ashimema | working on the bundles feature again.. |
11:49 | we have the materials confirm parts one.. which uses a modal for the blocking confirmation dialogue | |
11:49 | then the bundles piece was just adding the confirmation step on the page and not at a modal | |
11:49 | for consistency I'm feeling like it should be a modal confirm | |
12:01 | tcohen | cait: my patch and Joubu's follow-ups seem reasonably portable. |
12:06 | cait | oleonard: kind of - it comes from the specific css file of this library - but i don#t see where :) I just overwrote it now with !important as a last resort |
12:08 | khall joined #koha | |
12:17 | ashimema | oleonard |
12:17 | wahanui | oleonard is, like, happy for ashimema to write the release script |
12:17 | ashimema | with the modal confirms at checkin.. should they all include the all_checkin_messages block? |
12:18 | oleonard | I don't understand |
12:18 | ashimema | like.. the reserved modal does.. at the bottom of the modal.. |
12:18 | so if there's a hold you get a modal with options to 'Confirm and transfer' and the likes.. | |
12:19 | if there are other messages present.. like 'the item contains multiple materials' | |
12:19 | that will also get displayed in the modal.. at the bottom | |
12:19 | but some of the other modals on the same page don't adhere to that.. so you could confirm and miss a message | |
12:19 | oleonard | It's hard for me to picture how it works, but we certainly want to both keep things consistent and show the user relevant information. |
12:21 | ashimema | mm |
12:21 | okies.. I might have a bit more of a play.. this template is confusing as. | |
12:30 | oleonard | It is. |
12:50 | tcohen | Joubu: I've remebered why I didn't use ->parse |
12:51 | it's because they wanted diacritics in addresses | |
12:55 | Joubu | no, that's wrong |
12:55 | it's invalid | |
12:56 | and IIRC they wanted umlaut in the name part | |
13:07 | tcohen | Joubu: thanks for clarifying, I was sure I read that, and it of course was wrong but felt like there was consensus on keeping the current wrong behavior |
13:07 | anyway. more than happy to be RFC compliant :-D | |
13:26 | koha-jenkins | Project Koha_Master_D9 build #1745: ABORTED in 25 min: https://jenkins.koha-community[…]a_Master_D9/1745/ |
13:30 | Project Koha_Master_D9 build #1746: FAILURE in 3 min 39 sec: https://jenkins.koha-community[…]a_Master_D9/1746/ | |
13:37 | huginn | News from kohagit: Bug 22690: DBRev 21.06.00.018 <https://git.koha-community.org[…]08bceb3e475209109> |
13:37 | News from kohagit: Bug 22690: Remove uneeded return and add no_triggers <https://git.koha-community.org[…]50c05574879d927fc> | |
13:37 | News from kohagit: Bug 22690: DBIC schema changes <https://git.koha-community.org[…]d7e2d9fa99a7a36e0> | |
13:37 | News from kohagit: Bug 25619: Adjust POD and move date check before logging <https://git.koha-community.org[…]3e7119a0bac10531b> | |
13:37 | News from kohagit: Bug 25619: Adjust POD <https://git.koha-community.org[…]0d8681fc0f1d2217e> | |
13:37 | News from kohagit: Bug 22690: (QA follow-up) Fix indexing for Items sets <https://git.koha-community.org[…]b42048828d499c14d> | |
13:37 | News from kohagit: Bug 22690: (QA follow-up) Correct variable name <https://git.koha-community.org[…]d1454bfe6b5b51dc8> | |
13:37 | News from kohagit: Bug 22690: (QA follow-up) Add TrackedLink classes and use them <https://git.koha-community.org[…]4b43c5774d5b6ed2a> | |
13:37 | News from kohagit: Bug 25619: (QA follow-up) Fix subtest description <https://git.koha-community.org[…]902a01caab6726c50> | |
13:37 | News from kohagit: Bug 22690: (QA follow-up) Use relationship accessor <https://git.koha-community.org[…]4506a38ce3a597fa7> | |
13:37 | News from kohagit: Bug 22690: (QA follow-up) Add relationships to linktracker <https://git.koha-community.org[…]66d4c56314049f42d> | |
13:37 | News from kohagit: Bug 22690: (QA follow-up) Clarify uses of DBIC <https://git.koha-community.org[…]914b7865600d097d3> | |
13:37 | News from kohagit: Bug 22690: (QA follow-up) Move adopt_items_from_biblios to Koha::Items <https://git.koha-community.org[…]19b88e6f5053472c1> | |
13:37 | News from kohagit: Bug 22690: (QA follow-up) Improve negation syntax <https://git.koha-community.org[…]93306cc188f7db5f6> | |
13:37 | News from kohagit: Bug 22690: (QA follow-up) Rename 'item_orders' to 'orders' <https://git.koha-community.org[…]0f9d36851e44ac787> | |
13:37 | News from kohagit: Bug 22690: Add missing txn_begin in subtest <https://git.koha-community.org[…]63095788f12453db2> | |
13:37 | News from kohagit: Bug 22690: Remove MoveItemFromBiblio import <https://git.koha-community.org[…]5ac765da8cdd0f47c> | |
13:37 | News from kohagit: Bug 25619: Unit Tests <https://git.koha-community.org[…]22a0c3b2dd1fc20e3> | |
13:37 | News from kohagit: Bug 25619: Add ability to adjust expiration date for waiting holds <https://git.koha-community.org[…]1790b3066c031838b> | |
13:37 | News from kohagit: Bug 22690: (QA follow-up) Make bib-level hold object actually bib-level <https://git.koha-community.org[…]e7caccd1bee2265b0> | |
13:41 | alex_a joined #koha | |
13:44 | ere | \o/ |
13:53 | kidclamp | oleonard: if you can look at 16446 and let me know how to make the radios less ugly I would appreciate it |
13:55 | oleonard | Bug 16446 |
13:55 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=16446 enhancement, P5 - low, ---, nick, Signed Off , Allow librarians to add borrowers to patron lists by borrowernumber |
13:56 | oleonard | Sure |
14:03 | koha-jenkins | Project Koha_Master_D9 build #1747: NOW UNSTABLE in 31 min: https://jenkins.koha-community[…]a_Master_D9/1747/ |
14:03 | oleonard | kidclamp: https://snipboard.io/btQP1M.jpg ? |
14:15 | koha-jenkins | Project Koha_Master_D10_MDB_Latest build #677: UNSTABLE in 37 min: https://jenkins.koha-community[…]0_MDB_Latest/677/ |
14:20 | Joubu | mtj: is that ^ you? |
14:20 | mtj | Joubu: yes, should be fixed on master now |
14:21 | koha-jenkins | Project Koha_21.05_D9 build #51: ABORTED in 50 min: https://jenkins.koha-community[…]Koha_21.05_D9/51/ |
14:23 | Project Koha_Master_D10_My8 build #639: FAILURE in 1 min 57 sec: https://jenkins.koha-community[…]ster_D10_My8/639/ | |
14:31 | Project Koha_Master_U20 build #178: UNSTABLE in 52 min: https://jenkins.koha-community[…]a_Master_U20/178/ | |
14:32 | Project Koha_Master_D10_CPAN build #417: UNSTABLE in 28 min: https://jenkins.koha-community[…]ter_D10_CPAN/417/ | |
15:03 | Project Koha_Master_U_Stable build #244: UNSTABLE in 31 min: https://jenkins.koha-community[…]ter_U_Stable/244/ | |
15:04 | Project Koha_Master build #1742: UNSTABLE in 48 min: https://jenkins.koha-community[…]Koha_Master/1742/ | |
15:07 | huginn | News from kohagit: Bug 22690: Add koha_object[s]_class to fix TestBuilder.t <https://git.koha-community.org[…]6c8ee96111a0e2da3> |
15:26 | koha-jenkins | Project Koha_Master_D11 build #372: UNSTABLE in 55 min: https://jenkins.koha-community[…]a_Master_D11/372/ |
15:30 | Project Koha_Master_D9 build #1748: FAILURE in 33 min: https://jenkins.koha-community[…]a_Master_D9/1748/ | |
15:34 | Project Koha_Master_D10_CPAN build #418: STILL UNSTABLE in 30 min: https://jenkins.koha-community[…]ter_D10_CPAN/418/ | |
15:36 | ashimema | oooh |
15:36 | 'Separate main entry and subdivisions with' looks to still be in the cataloguing.pref file and mentioned non-XSLT view only Joubu | |
15:39 | gooble_gobble joined #koha | |
15:40 | cait left #koha | |
15:47 | koha-jenkins | Yippee, build fixed! |
15:47 | wahanui | Congratulations! |
15:47 | koha-jenkins | Project Koha_Master_D10_MDB_Latest build #678: FIXED in 39 min: https://jenkins.koha-community[…]0_MDB_Latest/678/ |
16:04 | cait joined #koha | |
16:05 | koha-jenkins | Yippee, build fixed! |
16:05 | wahanui | Congratulations! |
16:05 | koha-jenkins | Project Koha_Master_D10_My8 build #640: FIXED in 30 min: https://jenkins.koha-community[…]ster_D10_My8/640/ |
16:09 | tcohen joined #koha | |
16:10 | cait joined #koha | |
16:11 | cait joined #koha | |
16:12 | cait joined #koha | |
16:13 | cait joined #koha | |
16:16 | koha-jenkins | Yippee, build fixed! |
16:16 | wahanui | Congratulations! |
16:16 | koha-jenkins | Project Koha_Master_U20 build #179: FIXED in 54 min: https://jenkins.koha-community[…]a_Master_U20/179/ |
16:19 | Yippee, build fixed! | |
16:19 | wahanui | Congratulations! |
16:19 | koha-jenkins | Project Koha_Master_D10_CPAN build #419: FIXED in 53 min: https://jenkins.koha-community[…]ter_D10_CPAN/419/ |
16:25 | cait joined #koha | |
16:31 | cait joined #koha | |
16:32 | cait joined #koha | |
16:36 | koha-jenkins | Project Koha_Master build #1743: STILL UNSTABLE in 1 hr 5 min: https://jenkins.koha-community[…]Koha_Master/1743/ |
16:37 | Yippee, build fixed! | |
16:37 | wahanui | Congratulations! |
16:37 | koha-jenkins | Project Koha_Master_D11 build #373: FIXED in 31 min: https://jenkins.koha-community[…]a_Master_D11/373/ |
16:50 | morrism joined #koha | |
16:57 | koha-jenkins | Yippee, build fixed! |
16:57 | wahanui | Congratulations! |
16:57 | koha-jenkins | Project Koha_Master_U_Stable build #245: FIXED in 53 min: https://jenkins.koha-community[…]ter_U_Stable/245/ |
16:58 | tcohen | anyone familiar with our move to bcrypt for password? |
17:14 | koha-jenkins | Project Koha_Master_D10_My8 build #641: SUCCESS in 54 min: https://jenkins.koha-community[…]ster_D10_My8/641/ |
17:16 | Project Koha_Master_D9 build #1749: NOW UNSTABLE in 59 min: https://jenkins.koha-community[…]a_Master_D9/1749/ | |
17:29 | Project Koha_Master_D11 build #374: SUCCESS in 51 min: https://jenkins.koha-community[…]a_Master_D11/374/ | |
17:49 | fridolin joined #koha | |
17:50 | fridolin | hi |
17:51 | oleonard | Hi fridolin |
17:55 | fridolin | oleonard: salutations |
17:55 | coffee please | |
17:55 | ^^ | |
17:56 | oleonard | Sorry we ran out of coffee 4 hours ago |
17:56 | kidclamp | oleonard: that is nicer :-) I wasn't sure if you would like the fieldset |
17:57 | oleonard | The image I posted was what I saw. Is it different than what you saw? |
17:58 | kidclamp | your radios look different, but maybe browser wise |
18:06 | oleonard | I don't like the fieldset :( |
18:08 | kidclamp: We already have inconsistencies between how we present options for batch operations, this adds a new one. | |
18:45 | fridolin | oleonard: Bug 28914 if our UI expert can have a look please |
18:45 | huginn | Bug https://bugs.koha-community.or[…]_bug.cgi?id=28914 normal, P5 - low, ---, koha-bugs, Needs Signoff , Wording in authentication forms is confusing |
19:12 | oleonard | fridolin++ |
19:13 | I can give it a test tomorrow if no one gets to it by then | |
19:13 | * oleonard | fades out |
19:32 | fridolin | super giga |
20:09 | koha-jenkins | Project Koha_20.11_U18 build #118: SUCCESS in 36 min: https://jenkins.koha-community[…]ha_20.11_U18/118/ |
20:15 | Project Koha_20.11_U20 build #126: SUCCESS in 42 min: https://jenkins.koha-community[…]ha_20.11_U20/126/ | |
20:29 | Project Koha_20.11_U_Stable build #30: SUCCESS in 53 min: https://jenkins.koha-community[…]0.11_U_Stable/30/ | |
20:35 | dpk joined #koha | |
20:36 | koha-jenkins | Project Koha_20.11_U16 build #112: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]ha_20.11_U16/112/ |
20:39 | Yippee, build fixed! | |
20:39 | wahanui | Congratulations! |
20:39 | koha-jenkins | Project Koha_20.11_D10 build #139: FIXED in 1 hr 6 min: https://jenkins.koha-community[…]ha_20.11_D10/139/ |
20:42 | Project Koha_20.11_U18 build #119: SUCCESS in 32 min: https://jenkins.koha-community[…]ha_20.11_U18/119/ | |
20:50 | Project Koha_20.11_D9 build #133: SUCCESS in 1 hr 16 min: https://jenkins.koha-community[…]oha_20.11_D9/133/ | |
20:53 | Project Koha_20.11_U20 build #127: SUCCESS in 37 min: https://jenkins.koha-community[…]ha_20.11_U20/127/ | |
21:24 | Project Koha_20.11_D11 build #151: SUCCESS in 47 min: https://jenkins.koha-community[…]ha_20.11_D11/151/ | |
21:46 | fridolin joined #koha | |
23:31 | koha-jenkins | Yippee, build fixed! |
23:31 | wahanui | Congratulations! |
23:31 | koha-jenkins | Project Koha_Master_D9 build #1750: FIXED in 34 min: https://jenkins.koha-community[…]a_Master_D9/1750/ |
← Previous day | Today | Next day → | Search | Index