IRC log for #koha, 2021-08-06

← Previous day | Today | Next day → | Search | Index

All times shown according to UTC.

Time Nick Message
00:48 cait1 joined #koha
06:01 fridolin joined #koha
06:02 fridolin hi
06:12 reiveune joined #koha
06:13 reiveune hello
06:13 wahanui what's up, reiveune
06:23 ashimema morning #koha
06:25 fridolin left #koha
06:37 marcelr joined #koha
06:38 marcelr hi #koha
06:38 fridolin joined #koha
06:44 paul_p joined #koha
06:54 Joubu oleonard: What's your plan for the reserve/request.pl and tt?
06:54 I've started to explode some of the code there, but haven't published anything yet
07:02 davidnind joined #koha
07:06 ashimema Joubu, for bug 11175 do you think the Util::Search sub would be better as a method inside Koha::Biblio?
07:06 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=11175 enhancement, P5 - low, ---, joonas.kylmala, BLOCKED , Show the parent record's component parts in the detailed views
07:07 ashimema I'm starting to think that way.. the query is always going to be very directly related to the Bib...
07:08 marcelr Joubu: still looking a bit at 28784
07:08 ashimema bug 28784
07:08 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=28784 is not accessible.
07:09 ashimema Joubu, my question relates to your https://bugs.koha-community.or[…]cgi?id=11175#c148
07:09 huginn Bug 11175: enhancement, P5 - low, ---, joonas.kylmala, BLOCKED , Show the parent record's component parts in the detailed views
07:10 Joubu ashimema: the code does not apply, I don't remember what this sub does
07:10 s/code/patches... hum morning...
07:11 ashimema oh..
07:11 I have it checked out.. let me rebase and upload a new set.
07:14 fresh set uploaded
07:16 the sub builds a search query for component parts..
07:17 so uses the passed biblios 001, 003 or 245 fields to create a search string depending on the UseControlNumber preference and presence of the above fields
07:19 I'm thinking of moving it from Koha::Util::Search->get_component_part_query to Koha::Biblio->component_part_search_query
07:19 or something along those lines
07:19 Joubu that's weird
07:19 ashimema what.. the method?
07:19 or where it resides
07:20 Joubu we build a query to generate a search link in a .xsl file
07:20 ashimema well..
07:20 yeah
07:20 we also use that same query in a few other places..
07:21 I DRY'd it out in my final patch so we use the same construction code in all the places I found to date.
07:21 Joubu what is a "component"?
07:21 ashimema analytics..
07:22 Joubu what do we call it compenent then? :D
07:22 component even
07:22 ashimema parent = Book or Serial, 'component' = records for 'bits in the book or serial.. like articles'
07:22 yeah..
07:22 that was going to be another question.. but that one I was going to direct to cait or marcelr ;)
07:22 it's MARC21 speak
07:23 Joubu will the search always display "components" for a single record?
07:23 ashimema no
07:24 it'll only show if the preference is enabled.. and when there are records found.
07:24 it's the reverse of having a bunch of 774's in the parent record
07:24 instead of the parent having loads of 774's.. each child has a 773 that lists the parent.. hence the search
07:25 we only do the search if the parent says it may have components though I think.. depending on the leader.
07:25 Joubu In bug 27526 I moved some analytics-related code to Koha::Biblio->host_items
07:25 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=27526 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Remove Mod/AddItemFromMarc from additem.pl
07:26 Joubu and the "host items" (aka analytics/component if I understand correctly) are retrieved from the MARC record (773$a$9)
07:26 here I see code that:
07:27 ashimema ah, interesting
07:27 did you see marcelr's addition of get_marc_host ?
07:27 Joubu 1. call get_component_part_query with a biblionumber, 2. return a "search query", 3. Generate a link to finally display a search result
07:27 ashimema which is in master now
07:27 bug 27526 is on my list already.. not had a chance to look yet but I wasn't aware it touched this too
07:27 Joubu so what contain this search result? The same items of "my" Koha::Biblio->host_items
07:27 Is that correct?
07:28 (or am I mixing different things)
07:28 ashimema they're complimentary ;)
07:28 they work in oposite directions I believe
07:28 * they work in opossite directions I believe
07:28 humm
07:29 ah.. sounds like they do very similar then yes.
07:29 let me check out 27526 and compare them
07:30 Joubu If the plan is to display the analytic items of a given record, I don't see why we need a search result
07:30 marcelr ashimema: just reading diagonally, but they work opposite yes
07:31 ashimema how would you do it without a search result?
07:31 Joubu they are displayed on the biblio detail page
07:32 ashimema ok yes
07:32 Joubu I will have to test the patch, I am not sure it's making sense
07:32 ashimema get_marc_components and your host_items are synonyms.. except they achieve it slightly differently
07:32 Joubu not sure I will have time today however
07:32 ashimema breaky time.. be back in a bit
07:32 no worries..
07:33 Joubu but... why differently? :D
07:33 ashimema I'll take a look at your approach
07:33 I think there's lots of overlap here
07:33 EasyAnalytics vs UseControlNumber ;)
07:34 your one only works for Easy.. this one was only working for UseControl.. my update made the one in 11175 work for both.
07:34 breaky and I'll contemplate
07:34 bbiab
07:38 Joubu my main concern is more: why do we need two different ways of doing things. One picks from MARC the other one from search engine
07:40 ashimema Indeed to re-read your sub.. I thought it also did a search
07:40 I can't see how it would work without one
07:44 Joubu 54                 # search for (773$w='Host001' and 003='Host003') or 773$w='Host003 Host001')
07:44 it's in the comment
07:44 it's translating MARC to search indexes
07:45 ashimema exactly
07:46 Joubu I only don't understand why we just don't Koha::Biblio->get_components (or whatever it's named) and display them in a table
07:46 ashimema your sub is weirdly named
07:46 Joubu the method could retrieve the items from the MARC, like we do in other places for analytics
07:47 ashimema it's directionality
07:47 Joubu I reused the name/wording from the controller I copied from the code
07:47 ashimema your host_items sub it not returning the components
07:47 it's returning the host
07:47 or 'hosts'
07:47 773's are in the child
07:48 components it the opposite direction
07:48 right..
07:49 so I think get_marc_components is reasonable.. but I also think your host_items should be merged into marcelr's get_marc_host
07:49 Joubu Koha::Biblio->host_items is returning the items/children
07:50 ashimema the real challenge here is we have two nearly identical features.. one which uses MARC as per the specs and another that was made up but still sorta uses some marc fields
07:50 no it's not
07:50 773's point from child to parent
07:50 marcelr, back me up please ;)
07:50 Joubu it's returning the items from 773$9
07:50 it's all what it si doing
07:51 it's the current C4::Items::GetHostItemsInfo
07:51 marcelr yeah 773 goes to parent
07:51 host
07:51 Joubu k
07:51 ashimema ah.. is $9 in EasyAnalytics literal Item level..
07:51 that could be where some confusion lies
07:52 the marc way is at biblio level I believe
07:52 no notion of holding/item
07:53 yeah, $9 is not at all standard MARC
07:53 right..
07:53 so
07:53 marcelr's get_marc_host will use a search to return the parent biblio record
07:54 your host_items will use $9 to return an exact item.. which seems a little odd to me.. but I suppose if you're bundling items into one biblio then it may make some sense in certain situations.
07:55 Joubu We should have this code isolated in different modules. One per different method
07:55 ashimema hmm
07:55 I'm not so sure
07:56 either way.. I think the search query build should likely not be in ::Util::Search but in ::Biblio
07:56 the reason he constructs the query distinctly if for performance.. though in fact for a long time I'm not sure there's a real performance issue
07:57 we've actually triggered the search inside the controller code for ages.. since bug 15851
07:57 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=15851 enhancement, P5 - low, ---, tomascohen, RESOLVED FIXED, Only display "Analytics: Show analytics" when records have linked analytics
07:57 ashimema which is a bit funky and is what I DRY'd out in my final patch
07:58 Joubu ashimema: yes I would move them close to get_marc_host
07:58 ashimema cool..
07:58 I'll do that in another follow-up now whilst it's fresh in the grey matter
07:58 Joubu I still don't understand why we need to use a search result view
07:59 Shouldn't the "components" of a biblio record be accessed from the record itself?
07:59 ashimema because we don't have any link from the parent to the child
07:59 the data doesn't exist
07:59 that's what a 774 would do
07:59 Joubu I am talking about the UI
07:59 ashimema this is the parent record looking for the children
08:00 oh...
08:00 huh
08:00 as in.. you don't understand the point of the bug at all?
08:00 the tl;dr summary is..
08:01 either show 'Show analytics' as a link or show them in a table directly in the parent record
08:01 Joubu it would helped to have a description and test plan
08:01 ashimema in both cases we already do a search for the analytics themselves.. because people didn't want to see the 'Show analytics' button if no analytics actually existed
08:02 good point.. there are not 'release notes' yet
08:02 I'll use that to give a clear description
08:04 Joubu ashimema: if we move the method to Koha::Biblio you will have a weird class method the build a search engine query
08:04 that you will call from C4::XSLT
08:05 that's why it has been isolated outside of Koha::Biblio I guess
08:05 ashimema we already get the biblio in C4::XSLT..
08:05 so it would just hang of that I think
08:05 but perhaps that's already wrong
08:15 Joubu marcelr: did you see Agnes's comment on bug 21190?
08:15 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=21190 enhancement, P2, ---, m.de.rooy, RESOLVED FIXED, Add logging of successful/unsuccessful login attempts
08:17 marcelr Joubu: yes it drew my attention
08:17 will have  a look
09:04 Joubu: should this follow-up of 28784 be on security still for a while ?
09:06 Joubu marcelr: isn't it independent?
09:06 does it really depend on it?
09:06 marcelr no
09:06 Joubu k
09:06 so yes
09:06 marcelr ok
09:13 fridolin left #koha
09:30 cait joined #koha
09:57 marcelr kidclamp: please have another look at bug 26302, thx
09:57 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=26302 enhancement, P5 - low, ---, m.de.rooy, Signed Off , OPAC XSLT Results: List variable number of itemcallnumbers
10:00 davidnind Does anyone have any idea why Administration > Catalog > Search engine configuration (Elasticsearch)  (koha/admin/searchengine/e​lasticsearch/mappings.pl) is broken in master?
10:00 pastebot "davidnind" at 127.0.0.1 pasted "Error when accessing mappings.pl" (40 lines) at http://paste.koha-community.org/2217
10:02 Joubu davidnind: I am going to fix it right now
10:02 davidnind Joubu++
10:02 thanks!
10:06 Joubu davidnind: done
10:06 huginn News from kohagit: Bug 17600: Fix missing imports from mappings.pl <https://git.koha-community.org[…]7fe7d34b4c990f1c7>
10:07 Oak joined #koha
10:13 davidnind Awesome! Thanks Joubu - all working again now.
10:40 koha-jenkins Project Koha_Master_D9 build #1732: FAILURE in 31 min: https://jenkins.koha-community[…]a_Master_D9/1732/
10:42 Project Koha_Master_D10_My8 build #631: FAILURE in 2 min 12 sec: https://jenkins.koha-community[…]ster_D10_My8/631/
10:42 Project Koha_Master_D10_CPAN build #405: SUCCESS in 33 min: https://jenkins.koha-community[…]ter_D10_CPAN/405/
10:49 Project Koha_Master_D10_MDB_Latest build #662: SUCCESS in 41 min: https://jenkins.koha-community[…]0_MDB_Latest/662/
10:56 Project Koha_Master_U20 build #169: SUCCESS in 47 min: https://jenkins.koha-community[…]a_Master_U20/169/
11:02 Project Koha_Master_U_Stable build #234: SUCCESS in 55 min: https://jenkins.koha-community[…]ter_U_Stable/234/
11:15 Project Koha_Master_D11 build #362: SUCCESS in 32 min: https://jenkins.koha-community[…]a_Master_D11/362/
11:23 Project Koha_Master build #1735: SUCCESS in 1 hr 13 min: https://jenkins.koha-community[…]Koha_Master/1735/
11:23 Oak joined #koha
11:27 koha-jenkins Project Koha_Master_D10_CPAN build #406: SUCCESS in 38 min: https://jenkins.koha-community[…]ter_D10_CPAN/406/
11:28 davidnind left #koha
11:46 koha-jenkins Project Koha_Master_D11 build #363: SUCCESS in 31 min: https://jenkins.koha-community[…]a_Master_D11/363/
11:56 Oak joined #koha
11:57 koha-jenkins Project Koha_Master_D10_MDB_Latest build #663: SUCCESS in 54 min: https://jenkins.koha-community[…]0_MDB_Latest/663/
12:07 Yippee, build fixed!
12:07 wahanui Congratulations!
12:07 koha-jenkins Project Koha_Master_D9 build #1733: FIXED in 1 hr 10 min: https://jenkins.koha-community[…]a_Master_D9/1733/
12:19 Project Koha_21.05_U20 build #40: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_21.05_U20/40/
12:25 Project Koha_21.05_D11 build #46: SUCCESS in 38 min: https://jenkins.koha-community[…]oha_21.05_D11/46/
12:27 Project Koha_Master build #1736: SUCCESS in 1 hr 4 min: https://jenkins.koha-community[…]Koha_Master/1736/
12:27 sonOfRa joined #koha
12:37 tcohen hola
12:37 oleonard: morning
12:38 oleonard Hi
12:40 Joubu rangi: Hi Chris, can you update the kudos.pl script? "Patches pushed for release 21.11" on the dashboard is still empty. Thx!
12:42 Dyrcona joined #koha
12:47 marie-luce joined #koha
12:53 koha-jenkins Project Koha_21.05_D9 build #35: SUCCESS in 33 min: https://jenkins.koha-community[…]Koha_21.05_D9/35/
12:54 Yippee, build fixed!
12:54 wahanui Congratulations!
12:54 koha-jenkins Project Koha_21.05_U18 build #37: FIXED in 57 min: https://jenkins.koha-community[…]oha_21.05_U18/37/
13:09 oleonard I'm trying to revive Bug 7703
13:09 huginn Bug https://bugs.koha-community.or[…]w_bug.cgi?id=7703 normal, P5 - low, ---, kyle.m.hall, Needs Signoff , Don't block bulk hold action on search results if some items can't be placed on hold
13:12 AndrewFH joined #koha
13:17 koha-jenkins Project Koha_21.05_U16 build #36: SUCCESS in 1 hr 9 min: https://jenkins.koha-community[…]oha_21.05_U16/36/
13:17 oleonard That great feeling when a patch you last worked on a year ago still applies
13:17 (I got distracted, okay?)
13:20 Oak joined #koha
13:26 koha-jenkins Project Koha_21.05_U18 build #38: SUCCESS in 33 min: https://jenkins.koha-community[…]oha_21.05_U18/38/
13:46 Project Koha_21.05_U20 build #41: SUCCESS in 54 min: https://jenkins.koha-community[…]oha_21.05_U20/41/
13:49 Yippee, build fixed!
13:49 wahanui Congratulations!
13:49 koha-jenkins Project Koha_21.05_U_Stable build #36: FIXED in 55 min: https://jenkins.koha-community[…]1.05_U_Stable/36/
13:49 Project Koha_21.05_D11 build #47: UNSTABLE in 38 min: https://jenkins.koha-community[…]oha_21.05_D11/47/
13:59 khall joined #koha
14:01 koha-jenkins Project Koha_21.05_D9 build #36: SUCCESS in 34 min: https://jenkins.koha-community[…]Koha_21.05_D9/36/
14:08 Oak joined #koha
14:11 * ashimema thinks he's missing something obvious with bug 28824
14:11 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=28824 normal, P5 - low, ---, martin.renvoize, Needs Signoff , Errant variable declaration in C4::Letters
14:26 koha-jenkins Project Koha_21.05_U16 build #37: SUCCESS in 1 hr 9 min: https://jenkins.koha-community[…]oha_21.05_U16/37/
14:29 Project Koha_21.05_U16 build #38: SUCCESS in 39 min: https://jenkins.koha-community[…]oha_21.05_U16/38/
14:29 oleonard Need advice... I wanted to test something in 20.05.x, so I checked it out and did reset_all
14:29 Now I get this error from the staff client: Auth ERROR: Cannot get_session() at /kohadevbox/koha/C4/Auth.pm line 987
14:30 Who know what do?
14:33 Joubu install libyaml-syck-perl
14:33 and libcgi-session-serialize-yaml-perl
14:34 koha-jenkins Project Koha_21.05_U18 build #39: SUCCESS in 33 min: https://jenkins.koha-community[…]oha_21.05_U18/39/
14:35 oleonard Thanks Joubu I now have a feeling you've told me that before. I appreciate it!
14:38 reiveune bye
14:38 reiveune left #koha
14:39 * cait waves
14:39 ashimema hi cait
14:40 * ashimema is getting upset by analytics code
14:40 koha-jenkins Yippee, build fixed!
14:40 wahanui Congratulations!
14:40 koha-jenkins Project Koha_21.05_D11 build #48: FIXED in 54 min: https://jenkins.koha-community[…]oha_21.05_D11/48/
14:40 cait it certainly is a bit confusing
14:43 koha-jenkins Project Koha_21.05_U20 build #42: SUCCESS in 54 min: https://jenkins.koha-community[…]oha_21.05_U20/42/
14:45 bdonnahue1 joined #koha
14:53 sonOfRa joined #koha
14:57 Oak joined #koha
15:07 koha-jenkins Project Koha_21.05_U16 build #39: SUCCESS in 32 min: https://jenkins.koha-community[…]oha_21.05_U16/39/
15:08 Project Koha_21.05_D11 build #49: SUCCESS in 38 min: https://jenkins.koha-community[…]oha_21.05_D11/49/
15:38 Project Koha_21.05_U20 build #43: SUCCESS in 31 min: https://jenkins.koha-community[…]oha_21.05_U20/43/
15:39 Project Koha_21.05_D9 build #37: SUCCESS in 58 min: https://jenkins.koha-community[…]Koha_21.05_D9/37/
15:39 Project Koha_21.05_U_Stable build #37: SUCCESS in 55 min: https://jenkins.koha-community[…]1.05_U_Stable/37/
15:48 Project Koha_21.05_U16 build #40: SUCCESS in 40 min: https://jenkins.koha-community[…]oha_21.05_U16/40/
15:57 davidnind joined #koha
15:58 davidnind joined #koha
15:59 davidnind joined #koha
15:59 davidnind joined #koha
16:09 koha-jenkins Project Koha_21.05_U20 build #44: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_21.05_U20/44/
16:27 khall joined #koha
16:34 koha-jenkins Project Koha_21.05_D11 build #50: SUCCESS in 55 min: https://jenkins.koha-community[…]oha_21.05_D11/50/
16:37 Project Koha_21.05_U18 build #40: SUCCESS in 1 hr 14 min: https://jenkins.koha-community[…]oha_21.05_U18/40/
16:38 Project Koha_21.05_U16 build #41: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_21.05_U16/41/
16:42 Project Koha_21.05_U18 build #41: SUCCESS in 32 min: https://jenkins.koha-community[…]oha_21.05_U18/41/
17:16 Project Koha_21.05_D9 build #38: SUCCESS in 41 min: https://jenkins.koha-community[…]Koha_21.05_D9/38/
17:16 Project Koha_21.05_U18 build #42: SUCCESS in 33 min: https://jenkins.koha-community[…]oha_21.05_U18/42/
17:23 cait joined #koha
17:25 koha-jenkins Project Koha_21.05_U20 build #45: SUCCESS in 51 min: https://jenkins.koha-community[…]oha_21.05_U20/45/
17:33 Project Koha_21.05_U_Stable build #38: SUCCESS in 55 min: https://jenkins.koha-community[…]1.05_U_Stable/38/
17:52 Project Koha_21.05_U16 build #42: SUCCESS in 1 hr 14 min: https://jenkins.koha-community[…]oha_21.05_U16/42/
18:42 Project Koha_21.05_U16 build #43: SUCCESS in 32 min: https://jenkins.koha-community[…]oha_21.05_U16/43/
18:50 Project Koha_21.05_D11 build #51: SUCCESS in 38 min: https://jenkins.koha-community[…]oha_21.05_D11/51/
19:00 Dyrcona joined #koha
19:05 koha-jenkins Project Koha_21.05_U_Stable build #39: SUCCESS in 55 min: https://jenkins.koha-community[…]1.05_U_Stable/39/
19:11 Project Koha_21.05_D9 build #39: SUCCESS in 59 min: https://jenkins.koha-community[…]Koha_21.05_D9/39/
19:13 Project Koha_21.05_U20 build #46: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_21.05_U20/46/
19:23 Project Koha_21.05_U18 build #43: SUCCESS in 1 hr 13 min: https://jenkins.koha-community[…]oha_21.05_U18/43/
19:25 cait joined #koha
19:31 koha-jenkins Project Koha_21.05_U16 build #44: SUCCESS in 41 min: https://jenkins.koha-community[…]oha_21.05_U16/44/
20:03 Project Koha_21.05_U18 build #44: SUCCESS in 58 min: https://jenkins.koha-community[…]oha_21.05_U18/44/
20:04 Project Koha_21.05_D11 build #52: SUCCESS in 53 min: https://jenkins.koha-community[…]oha_21.05_D11/52/
20:36 Project Koha_21.05_D9 build #40: UNSTABLE in 1 hr 13 min: https://jenkins.koha-community[…]Koha_21.05_D9/40/
20:59 Project Koha_21.05_U_Stable build #40: SUCCESS in 55 min: https://jenkins.koha-community[…]1.05_U_Stable/40/
21:56 dpk joined #koha
22:13 davidnind left #koha
23:54 cait @later tell Fridolin could you have another look at bug 28611 for backporting please? Added some comments to explain
23:54 huginn cait: The operation succeeded.
23:54 cait @seen Fridolin
23:54 huginn cait: Fridolin was last seen in #koha 17 hours, 52 minutes, and 38 seconds ago: <fridolin> hi

← Previous day | Today | Next day → | Search | Index

koha1