← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:16 | kathryn joined #koha | |
| 00:19 | inlibro joined #koha | |
| 01:19 | inlibro joined #koha | |
| 02:12 | dcook_ joined #koha | |
| 02:19 | inlibro joined #koha | |
| 02:35 | dcook joined #koha | |
| 03:19 | inlibro joined #koha | |
| 04:19 | inlibro joined #koha | |
| 04:46 | JBoyer_ joined #koha | |
| 05:11 | lmstrand joined #koha | |
| 05:16 | chriss joined #koha | |
| 05:19 | inlibro joined #koha | |
| 05:33 | did joined #koha | |
| 05:51 | fridolin joined #koha | |
| 06:20 | inlibro joined #koha | |
| 06:22 | marcelr joined #koha | |
| 06:22 | marcelr | hi #koha |
| 06:35 | sophie_m joined #koha | |
| 06:36 | reiveune joined #koha | |
| 06:37 | reiveune | hello |
| 06:40 | cait joined #koha | |
| 06:46 | marcelr | hi reiveune sophie_m cait |
| 06:48 | alex_a joined #koha | |
| 06:48 | alex_a | Bonjour |
| 06:54 | cait joined #koha | |
| 06:54 | sophie_m | hi marcelr |
| 06:54 | cait1 joined #koha | |
| 06:55 | marcelr | bonjour alex_a |
| 06:56 | alex_a | Hallo marcelr |
| 06:58 | lds joined #koha | |
| 07:20 | inlibro joined #koha | |
| 07:55 | * cait1 | waves |
| 07:56 | fridolin | Bug 26534 more awsome font |
| 07:56 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=26534 enhancement, P5 - low, ---, fridolin.somers, Needs Signoff , Add Font Awesome icon only for staff patrons |
| 08:07 | lds joined #koha | |
| 08:20 | inlibro joined #koha | |
| 08:26 | ashimema[m] | nice |
| 08:26 | will SO as soon as I'm done here | |
| 08:26 | good morning #koha | |
| 08:27 | Question | |
| 08:27 | wahanui | it has been said that Question is a bit general |
| 08:28 | ashimema[m] | with the lostreturn policy.. if you have it set to refund then we refund the lost item fee and also set the status of the fee to 'FOUND' |
| 08:28 | should we also update the status to FOUND regardless of whether we apply a refund to it or not? | |
| 08:29 | the item is, after all, still found | |
| 09:09 | cait1 | hm too quiet on bugzilla for a friday |
| 09:09 | where are the Friday QAers? | |
| 09:09 | ashimema[m] | hi |
| 09:09 | * ashimema[m] | is finishing off writing some tests, then will be working on the queue |
| 09:10 | cait1 | jajm: alex_a ? ;) |
| 09:12 | davidnind joined #koha | |
| 09:20 | inlibro joined #koha | |
| 09:33 | ashimema[m] | sorry cait.. before I start removing from the QA queue.. I'm putting one back into it |
| 09:47 | kohaputti joined #koha | |
| 09:58 | * ashimema[m] | is happy with bug 23091 again now |
| 09:58 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=23091 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Add options to charge new or restore forgiven overdues when a lost item is returned |
| 10:16 | ashimema[m] | shrinking again now cait1 |
| 10:20 | inlibro joined #koha | |
| 10:31 | cait1 | :) |
| 10:35 | davidnind++ fridolin++ ashimema[m]++ | |
| 10:38 | ashimema[m] | poor Joubu has a serious queue building |
| 10:39 | * ashimema[m] | can't believe how much QA cait1 gets through.. I thought I did a fair chunk but those numbers put me to shame. |
| 10:42 | ashimema[m] | cait1 still around? |
| 10:42 | tests for SIP | |
| 10:47 | khall joined #koha | |
| 10:52 | oleonard | o/ |
| 10:55 | * ashimema[m] | feels bad.. he's now on a FQA spree it seems |
| 10:57 | vfernandes joined #koha | |
| 11:07 | TimothyAlexis joined #koha | |
| 11:08 | TimothyAlexis | I was trying to apply patch 12556 using git bz and got this: |
| 11:08 | error: sha1 information is lacking or useless (C4/Reserves.pm). | |
| 11:08 | error: could not build fake ancestor | |
| 11:09 | Does anyone know what this means? | |
| 11:09 | And how to resolve it? | |
| 11:10 | oleonard | TimothyAlexis it could mean the patch depends on another patch which wasn't applied |
| 11:11 | It could also mean the person who submitted the patch didn't submit all the dependencies | |
| 11:12 | TimothyAlexis it applies cleanly for me | |
| 11:12 | on master | |
| 11:15 | TimothyAlexis | I deleted the branch I had and checked it out again and now it worked. |
| 11:19 | davidnind | TimothyAlexis: here is the workflow I use when testing (using koha-testing-docker) https://gitlab.com/-/snippets/1893788#branches |
| 11:20 | inlibro joined #koha | |
| 11:22 | TimothyAlexis | davidnind++ |
| 11:24 | davidnind | oleonard: I finally managed to get one of the "Move translatable strings..." bugs tested, I'll try and tackle as many as I can over the weekend |
| 11:24 | (sorry QA Team!) | |
| 11:25 | alex_a joined #koha | |
| 11:25 | oleonard | Thanks davidnind! |
| 11:25 | davidnind++ | |
| 11:26 | davidnind | (I'm also procrastinating about working on my Kohacon2020 presentations) |
| 11:27 | ashimema[m] | :) |
| 11:27 | no better way to procrastinate :) | |
| 11:28 | davidnind | :-D |
| 11:28 | oleonard | Thanks for testing Bug 24958 fridolin! |
| 11:28 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=24958 enhancement, P5 - low, ---, oleonard, Signed Off , Remember last selected tab in SQL reports |
| 11:28 | oleonard | fridolin++ |
| 11:28 | cait1 | back now (lunch) |
| 11:29 | ashimema[m] | good catch on the css for the staff shield bug oleonard.. I should have spotted that |
| 11:29 | cait1 | davidnind++ sign-off machine :) |
| 11:29 | i'll be waiting for these string patches | |
| 11:31 | ashimema[m] | oleonard.. is it just me or is there also a bug with the css declaration a few lines above too |
| 11:31 | i.e `+ #menu` , shouldn't that be `&#menu` ? | |
| 11:31 | davidnind | oops, I missed the grey background not being there.. |
| 11:32 | oleonard | The " + " means next to, the "&" means also |
| 11:32 | ashimema[m] | aha.. cool |
| 11:35 | I'm not so sure about the centering + background element of it actually | |
| 11:36 | oleonard | The centering makes sense to me but I realize that it only works because I have patron images turned on |
| 11:36 | The centering looks good with a patron image, I'm guessing it wouldn't look as good without | |
| 11:37 | ashimema[m] | It's the centering I think that doesn't look quite right for non-staff patrons |
| 11:37 | aha.. that's it I think | |
| 11:37 | without images it looks OK for staff members (because the background comes in too), but for standard users it looks a little odd | |
| 11:39 | kohaputti | TimothyAlexis, thanks for checking out the sip email notification bug report 12556. I'm (Joonas) here also on IRC case you need help with debugging the issue you have with testing the patch set. |
| 11:52 | ashimema[m] | OK.. I've added a couple of followups to bug 26534.. wouldn't mind your expert opinion on that last one oleonard.. I'm sure there's a more elegant way of achieving that one. |
| 11:52 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=26534 enhancement, P5 - low, ---, fridolin.somers, Signed Off , Add Font Awesome icon only for staff patrons |
| 11:54 | lds joined #koha | |
| 11:57 | khall joined #koha | |
| 11:59 | oleonard | Does putting TT markup inside an HTML tag not break translations anymore? There is a coding guideline saying don't do it. |
| 12:01 | cait1 what would you think of modifying Bug 19351 so that the new column is hidden by default? | |
| 12:01 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=19351 enhancement, P5 - low, ---, katrin.fischer, Signed Off , Add copynumber in the checkouts table in staff interface |
| 12:03 | fridolin | ashimema[m]: thanks. I also added centre because otherwise icon is sticked to left border |
| 12:03 | check with and without patron image | |
| 12:03 | putting TT markup inside an HTML tag ich | |
| 12:04 | tcohen | morning |
| 12:04 | oleonard | fridolin some horizontal padding on the h5 would help |
| 12:05 | fridolin | oleonard: i tried but i was not sure i'd break all display ;) |
| 12:05 | center is always nice no ? | |
| 12:07 | Dyrcona joined #koha | |
| 12:08 | * oleonard | is not prepared to make such a broad statement :D |
| 12:17 | fridolin | XD css align center to be specific |
| 12:17 | Bug 25462 | |
| 12:17 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=25462 enhancement, P5 - low, ---, david.roberts, Needs Signoff , Shelving location should be on a new line in holdings table |
| 12:18 | fridolin | i like this but i'm concerned on impact, see comment |
| 12:18 | ashimema[m] | yeah, I noticed that.. |
| 12:19 | mm, I wasn't a fan of putting tt inside markup.. though I don't think in this case it would break translation | |
| 12:21 | inlibro joined #koha | |
| 12:23 | TimothyAlexis | kohaputti ok |
| 12:26 | khall joined #koha | |
| 12:38 | oleonard | Speaking of translations, I think it'd be good to get your eyes on Bug 26392 ashimema[m], the more QA the better. |
| 12:38 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=26392 enhancement, P5 - low, ---, julian.maurice, Signed Off , Wrap all translatable strings in opac-main.tt |
| 12:41 | ashimema[m] | OK, I've done a cleaner job of the followup on bug 26534 now |
| 12:41 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=26534 enhancement, P5 - low, ---, fridolin.somers, Signed Off , Add Font Awesome icon only for staff patrons |
| 12:42 | marie-luce joined #koha | |
| 12:42 | ashimema[m] | as for bug 26392.. it's in my targets.. I tihnk we all agreed it didn't have a noticable effect on performance in the end end didn't we? |
| 12:42 | The main purpose for doing it was to have consistency throughout Koha in how translations look right? | |
| 12:43 | so deves can generally just use one technique rather than having to pick and choose | |
| 12:43 | * ashimema[m] | just discovered the `fa-fw` class btw.. it's nice |
| 12:44 | cait1 | tcohen: around? |
| 12:44 | tcohen | yes |
| 12:44 | cait1 | https://bugs.koha-community.or[…]ent.cgi?id=110630 |
| 12:44 | i am missing something | |
| 12:44 | i was wondering about checks on item deletion (after our conversation about the biblios) | |
| 12:44 | safe_delete calls safe_delete? | |
| 12:44 | tcohen | right |
| 12:45 | this is $items->safe_delte | |
| 12:45 | cait1 | oh |
| 12:45 | tcohen | which calls $item->safe_delete |
| 12:45 | ashimema[m] | item vs items :) |
| 12:45 | tcohen | rigt |
| 12:45 | cait1 | yep got it |
| 12:45 | tcohen | I use it as |
| 12:45 | cait1 | i will have a quick look there now |
| 12:45 | tcohen | $order->items->safe_delete |
| 12:45 | and after a good night sleep all yesterday comments from you triggered cleaner ideas | |
| 12:46 | I'm about to submit the DelOrder removal | |
| 12:46 | ashimema[m] | tcohen++ |
| 12:46 | dude.. I love you :) | |
| 12:46 | cait1 | heh |
| 12:46 | can i make new ideas? | |
| 12:47 | an on order item might have a hold on it | |
| 12:47 | worst case... it might even be checked out | |
| 12:47 | i don't think it looks like we are catching that, but again, i might be looking in the wrong spots | |
| 12:47 | tcohen | right |
| 12:47 | that is checked on Koha::Item->safe_delete | |
| 12:47 | cait1 | just as i finished writing i found me staring at it |
| 12:48 | tcohen | well |
| 12:48 | cait1 | hm it checks for W and T |
| 12:48 | ashimema[m] | hehe |
| 12:48 | tcohen | Koha::Item->safe_to_delete |
| 12:48 | cait1 | we should also make sure to cancel unfound holds |
| 12:48 | tcohen | is the method |
| 12:48 | cait1 | ah ... oast item for hould |
| 12:48 | oleonard | Is there a standard way for getting the current logged-in branch in a script in the staff interface? |
| 12:48 | cait1 | ok... this does look good actually :) |
| 12:49 | ashimema[m] | er.. yes |
| 12:49 | cait1 | just mssing "checked out" ? |
| 12:49 | ashimema[m] | ah.. 'in-script' rather than 'in-template' you mean oleonard? |
| 12:49 | cait1 | and you people are really bad on the terminology guidelines... not_same_branch and book_reserved... |
| 12:49 | oleonard | ashimema[m]: Yes |
| 12:49 | cait1 | tcohen: would you agree we are not checking for "checked out"? |
| 12:50 | tcohen | no |
| 12:50 | it is the first check | |
| 12:50 | book_on_loan | |
| 12:50 | cait1 | lol |
| 12:50 | ok | |
| 12:50 | thx for helping me see :) | |
| 12:51 | ashimema[m] | `my $library_id = C4::Context->userenv->{'branch'};` is what I've tended to stick with most recently oleonard |
| 12:51 | cait1 | terminology! loan is not to be used heh |
| 12:51 | tcohen | I'm thinking about unfound holds |
| 12:51 | cait1 | i think that's the last one |
| 12:51 | last_item_for_hold | |
| 12:51 | * oleonard | wonders if it is more efficient to get the logged-in branch via the script or the template plugin |
| 12:51 | cait1 | if othr items can fill the hold, no need to cancel it when it has not been found yet |
| 12:51 | * oleonard | assumed the script |
| 12:51 | ashimema[m] | it'll give you branchcode.. if you need more details you'd likely then need to fetch a Koha::Library object using that branchcode in your ->find call |
| 12:52 | cait1 | tcohen: there might be a glitch if the hold is item level we don't have checked for? |
| 12:52 | oleonard | Yeah all I need is the branchcode |
| 12:52 | ashimema[m] | the template plugin uses the same logic ;) |
| 12:52 | so they're about equivilent | |
| 12:52 | tcohen | cait1 I'd say the problem is already in the codebase then |
| 12:52 | ashimema[m] | in both cases they're grabbing it from Context |
| 12:54 | in many ways if you're not using it for anything in particular in the script before passing it to the template.. I'd suggest using the TT plugin instead.. the 'GetLoggedInBranchname' and 'GetLoggedInBranchcode' methods are nice and clearly named :) | |
| 12:55 | oleonard | Okay thanks ashimema[m] |
| 12:55 | tcohen | cait1 I remember now: DelBiblio cancels the holds, but it is only called under some circumstances |
| 12:55 | ashimema[m] | anything in particular you'd like me to attack in the QA queue cait1? |
| 12:55 | tcohen | ideas? |
| 12:55 | wahanui | ideas are good! |
| 12:56 | oleonard | wahanui laying down the hard truths |
| 12:56 | wahanui | oleonard: sorry... |
| 12:56 | TimothyAlexis | hahaha |
| 12:57 | * ashimema[m] | watches a 'how to take a covid swab' video.. been picked for a national survey; I now have the fun of getting to do a test a couple of times a month for the next year.. lol |
| 12:58 | davidnind left #koha | |
| 13:01 | cait1 | ashimema[m]: you already took care of some on my internal 'list' :) |
| 13:01 | ashimema[m] | :) |
| 13:01 | cait1 | ashimema[m]: voluntary or mandatory? the whole thing |
| 13:01 | ashimema[m] | voluntary |
| 13:01 | cait1 | tcohen: looking at items now... sorry, must be getting on your nerves :) |
| 13:01 | ashimema[m] | get paid for it too :) |
| 13:01 | cait1 | i think we have a whole if the item has an item level hold on it |
| 13:01 | a 'hole' in the logic | |
| 13:02 | and we will delete it without taking care of the hold when it's not the last item (which doesn' tmatter in this case) and not W or T | |
| 13:02 | ashimema[m]: ah ok, at least :) | |
| 13:02 | then... have fun ? | |
| 13:02 | ashimema[m] | I imagine tcohen is actually really happy you're looking at them cait1.. feedback is constructive.. no feedback is more upsetting |
| 13:03 | cait1 | i am not super grat with the OO stuff... but always trying to be constructive - might just ask some qustions that are a bit more basic |
| 13:03 | ashimema[m] | it's all good :) |
| 13:04 | in general the OO stuff should make the logic more consistent and overall clearer | |
| 13:05 | often time's you find that checks go from being in a gazillian places inconsistently to being in one place.. the QA challenge is catching them all to ensure they've all got transported into the nice definitive locations. | |
| 13:07 | cait1 | ashimema[m]: from age and persons involved... maybe 26290? |
| 13:08 | yeah i do like the new code | |
| 13:08 | i can see it in the template patches i do too how much this makes things easier when you can just get the field from the object instead of dealing with tons of tempalte variables | |
| 13:08 | and even if i am a litlte blind today, it is easier to read oftentimes | |
| 13:16 | sophie_m joined #koha | |
| 13:21 | inlibro joined #koha | |
| 13:23 | fridolin | ashimema[m]: are there plans about roles for next release 21.05 ? |
| 13:23 | sorry i couldn attend last meeting | |
| 13:24 | tcohen | you'll be the RM fridolin |
| 13:24 | haha | |
| 13:24 | kidding | |
| 13:33 | * ashimema[m] | has missed a couple of meeting recently |
| 13:33 | ashimema[m] | I'm not sure it's come up yet |
| 13:33 | alex_a_ joined #koha | |
| 13:33 | * ashimema[m] | would back fridolin for RM too btw ;) |
| 13:34 | * tcohen | is missing sharing some red wine with fridolin |
| 13:34 | ashimema[m] | but yeah.. not thought about it yet.. I imagine I'll be going for QA team again.. but not all that likely to come back to RM or RMaint yet.. as much as I'd love to do RM again I don't think we can afford to donate my time to it again that quick ;) |
| 13:35 | oleonard | I'm pretty sure fridolin just volunteered |
| 13:35 | ashimema[m] | I could possibly be persuaded to be RMaint again under a good RM ;) |
| 13:36 | as a side note.. ptfs-e are now aiming for .11 releases only internally.. so if I do RMaint again any time soon, it'll likely be for a .11 | |
| 13:36 | cait1 | we are aiming for a .05 now for the first time ever heh |
| 13:36 | will be interesting :) | |
| 13:37 | we ususally jump 2 versions, but have to catch up a little | |
| 13:37 | i think putting up the roles page and announcing would certainly be good | |
| 13:37 | fridolin++ thx for bringing it up | |
| 13:37 | also.... if you want... we always have plenty of room in the qa team for you ;) | |
| 13:38 | tcohen | I would love to be RM again at some point, if life allows |
| 13:38 | but having new people engage those roles sounds like something healthy for the proejct | |
| 13:40 | oleonard | tcohen it's been so long since you were RM... You've matured and become so much wiser... |
| 13:40 | tcohen | hahaha |
| 13:41 | ashimema[m] | I feel like RM should be taken by the more stead hands.. I like people working their way up through QA Team, RMaint and then RM.. |
| 13:41 | problem is.. we're not getting enough new faces in QA Team to encourage into RMaint and beyond.. | |
| 13:42 | oleonard | If we had cloned rangi at the start of the project they'd be old enough to be RM by now... hindsight 20/20 etc. |
| 13:43 | ashimema[m] | though.. having been there now.. RMaint didn't prepare me hugely for RM.. it was generally being around and listening to predecessors that helped me learn the ropes for RM |
| 13:43 | lol | |
| 13:43 | oleonard for RM | |
| 13:45 | * fridolin | humbly propose for Release Maintainance |
| 13:45 | fridolin | + red wine |
| 13:48 | oleonard | oleonard for RM if you want oleonard's patches to stop coming and for everything to break as a result of his bad decisions |
| 13:49 | Judy joined #koha | |
| 13:53 | ashimema[m] | no marcelr today? |
| 13:55 | cait1 | oleonard: we should totally quote add that clone comment |
| 13:55 | lukeG joined #koha | |
| 13:56 | cait1 | ashimema[m]: he took care of the elasticsearch index bug this morning |
| 13:56 | @quote add oleonard: If we had cloned rangi at the start of the project they'd be old enough to be RM by now... hindsight 20/20 etc | |
| 13:56 | huginn | cait1: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command). |
| 13:56 | cait1 | oh huginn... |
| 13:56 | wahanui | huginn is probably going to make me lie... |
| 13:56 | huginn | wahanui: I've exhausted my database of quotes |
| 13:56 | wahanui | huginn: sorry... |
| 13:56 | huginn | wahanui: I'll give you the answer as soon as RDA is ready |
| 13:56 | wahanui | i already had it that way, huginn. |
| 13:57 | cait1 | lol |
| 13:57 | might be their longest conversation so far | |
| 14:00 | ashimema[m] | awesome |
| 14:02 | cait joined #koha | |
| 14:03 | cait | i just don't remember my IRC password to identify *sad* |
| 14:05 | lds_ joined #koha | |
| 14:16 | alex_a joined #koha | |
| 14:21 | inlibro joined #koha | |
| 14:26 | amoyano left #koha | |
| 14:59 | lukeG1 joined #koha | |
| 15:21 | inlibro joined #koha | |
| 15:40 | fridolin left #koha | |
| 15:48 | margaret joined #koha | |
| 15:58 | reiveune | bye |
| 15:58 | reiveune left #koha | |
| 16:02 | vfernandes joined #koha | |
| 16:09 | khall joined #koha | |
| 16:14 | khall joined #koha | |
| 16:21 | inlibro joined #koha | |
| 16:42 | lisettelatah joined #koha | |
| 16:53 | oleonard | Hi lisettelatah |
| 16:53 | lisettelatah | hi oleonard |
| 16:53 | wahanui | hi oleopard |
| 16:54 | oleonard | I hope you're happy with how bug-a-palooza went. I thought it went well. |
| 16:54 | cait left #koha | |
| 16:55 | lisettelatah | Thanks, I thought it went well also. There were a lot of comments/ccs on bugs that were discussed and I noticed people were doing signoffs throughout the day that had been there, so that was nice. |
| 16:58 | oleonard | lisettelatah were you at the virtual meetup? I'm curious how that went. |
| 17:02 | lisettelatah | Yeah, we mostly had about 6-8 people there at a time, mostly the same 6 of us for about an hour with a couple other people filtering in and out. I left after about 1.5 hours and I guess someone from Australia showed up right at the end and talked some with Jason and whoever else was around. |
| 17:02 | cait joined #koha | |
| 17:03 | lisettelatah | I think doing multiple meetups at different times might have worked better. It was still kind of early on the west coast if anyone had to work until 5. |
| 17:03 | oleonard | lisettelatah I was thinking about how if you're at an in-person conference you're likely away from your family and other obligations and it's easier to hang out |
| 17:03 | khall_ joined #koha | |
| 17:04 | lisettelatah | oleonard definitely! I left when I did because I had to make dinner, but if we'd been at a conference we probably would have been somewhere I could have just eaten. |
| 17:22 | inlibro joined #koha | |
| 17:36 | deb-CSPL joined #koha | |
| 18:22 | inlibro joined #koha | |
| 18:51 | davidnind joined #koha | |
| 18:59 | davidnind | lisettalatah++ |
| 18:59 | lisettelatah joined #koha | |
| 19:19 | khall joined #koha | |
| 19:20 | khall joined #koha | |
| 19:22 | inlibro joined #koha | |
| 19:33 | khall joined #koha | |
| 19:35 | khall joined #koha | |
| 20:20 | pilar joined #koha | |
| 20:22 | inlibro joined #koha | |
| 21:00 | davidnind left #koha | |
| 21:22 | inlibro joined #koha | |
| 22:22 | inlibro joined #koha | |
| 23:23 | inlibro joined #koha |
← Previous day | Today | Next day → | Search | Index