← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:21 | dcook | aleisha: Story of my Koha life |
| 00:21 | wizzycray: Doesn't sound familiar? | |
| 00:21 | aleisha | heh |
| 00:22 | dcook | Mind you, after staying up last night until 11 or so working on a little Koha plugin (ie just chatting to people on here), I was almost up until 1am anyway... |
| 00:22 | I was just thinking maybe we Oceania folks need to start contributing like mad to turn the tide to our timezones >_> | |
| 00:23 | On that note, I should probably go do some non-Koha work <_< | |
| 00:26 | khall joined #koha | |
| 00:27 | khall joined #koha | |
| 00:32 | khall joined #koha | |
| 00:35 | khall joined #koha | |
| 00:39 | khall joined #koha | |
| 00:48 | oleonard-away | dcook and aleisha check the time of the next general meeting to confirm it's better for you |
| 00:48 | I believe it was intended to be | |
| 00:48 | dcook | :o |
| 00:48 | I gave up going to meetings long ago but I'll look | |
| 00:48 | https://wiki.koha-community.or[…]Next_IRC_meetings | |
| 00:48 | Sept 2nd? | |
| 00:49 | oleonard-away | That looks right |
| 00:49 | dcook | 6am for me, but 8am for aleisha I think |
| 00:49 | inlibro joined #koha | |
| 00:50 | dcook | I figure I don't have enough to contribute to warrant me waking up that early |
| 00:50 | aleisha | 8am is just slightly early for when i get to work! but i will do my best :D |
| 00:50 | dcook | Hmm developer meeting is interesting |
| 00:50 | That's at midnight for me on August 13th.. | |
| 00:51 | That could be more doable.. | |
| 00:51 | I'll make a note of that one | |
| 00:51 | Cheers oleonard-away :) | |
| 00:52 | * dcook | wishes the pandemic would go away so he could see oleonard at Kohacon again |
| 00:52 | dcook | I mean I wish it would go for other reasons too |
| 00:52 | But that would be nice ^_^ | |
| 00:52 | oleonard-away | No, that's the only reason!! |
| 00:52 | dcook | heh |
| 00:52 | I was about to say go to bed oleonard | |
| 00:52 | But looks like it's still a very respectable time | |
| 00:53 | oleonard | It is almost time for me to start the process of shepherding kids to bed, which takes much too long |
| 00:53 | dcook | Don't I know it |
| 00:53 | I mean not your kids | |
| 00:54 | Let's just say I recently participated in a shadow puppet play that was somehow coerced out of me to avoid them going to bed | |
| 00:54 | * dcook | still has no idea why he agreed to that |
| 00:54 | dcook | Life is weird |
| 00:54 | First we're trying to put the kids to bed | |
| 00:54 | Then as teenagers we're trying to get them out of bed | |
| 00:55 | I've recently learned that video games are apparently an amazing motivator | |
| 00:55 | I think my kiddo climbed more stairs on a hike than many adults could just because there were video games waiting after the hike O_O | |
| 00:59 | oleonard | Getting an 11 and 13-year-old to bed isn't the same kind of difficult that it was when they were little, but there is still so much dawdling |
| 00:59 | khall joined #koha | |
| 01:00 | dcook | Good on you for trying |
| 01:01 | I have vague memories of going to sleep when I was 12/13 | |
| 01:01 | I think I liked to read before bed, so going to bed and going to sleep were two different things | |
| 01:04 | * oleonard | heads out |
| 01:04 | oleonard | Back in 10 hours or so :) |
| 01:07 | khall joined #koha | |
| 01:12 | dcook | Dang I just missed you |
| 01:12 | @later tell oleonard I had a re-think about bug 26140 | |
| 01:12 | huginn | dcook: The operation succeeded. |
| 01:13 | khall joined #koha | |
| 01:29 | khall joined #koha | |
| 01:30 | khall joined #koha | |
| 01:41 | khall joined #koha | |
| 01:48 | khall joined #koha | |
| 01:49 | inlibro joined #koha | |
| 01:50 | khall joined #koha | |
| 01:52 | khall joined #koha | |
| 01:55 | khall joined #koha | |
| 01:57 | khall joined #koha | |
| 02:06 | lukeG joined #koha | |
| 02:08 | khall joined #koha | |
| 02:09 | khall joined #koha | |
| 02:12 | khall joined #koha | |
| 02:14 | khall joined #koha | |
| 02:16 | khall joined #koha | |
| 02:19 | khall joined #koha | |
| 02:22 | khall joined #koha | |
| 02:26 | khall joined #koha | |
| 02:27 | khall joined #koha | |
| 02:34 | khall joined #koha | |
| 02:38 | khall joined #koha | |
| 02:41 | khall joined #koha | |
| 02:44 | khall joined #koha | |
| 02:48 | khall joined #koha | |
| 02:50 | inlibro joined #koha | |
| 02:52 | khall joined #koha | |
| 02:56 | khall joined #koha | |
| 02:58 | khall joined #koha | |
| 02:58 | bigbrovar joined #koha | |
| 03:02 | khall joined #koha | |
| 03:03 | khall joined #koha | |
| 03:06 | khall joined #koha | |
| 03:10 | khall joined #koha | |
| 03:11 | khall joined #koha | |
| 03:16 | khall joined #koha | |
| 03:19 | khall joined #koha | |
| 03:21 | khall joined #koha | |
| 03:22 | khall joined #koha | |
| 03:23 | khall joined #koha | |
| 03:26 | khall joined #koha | |
| 03:27 | khall joined #koha | |
| 03:28 | khall joined #koha | |
| 03:32 | khall joined #koha | |
| 03:32 | dcook_ joined #koha | |
| 03:34 | khall joined #koha | |
| 03:40 | khall joined #koha | |
| 03:41 | khall joined #koha | |
| 03:46 | khall joined #koha | |
| 03:47 | khall joined #koha | |
| 03:49 | khall joined #koha | |
| 03:50 | khall joined #koha | |
| 03:50 | inlibro joined #koha | |
| 03:52 | khall joined #koha | |
| 03:53 | khall joined #koha | |
| 03:54 | khall joined #koha | |
| 03:57 | khall joined #koha | |
| 04:01 | khall joined #koha | |
| 04:03 | khall joined #koha | |
| 04:05 | khall joined #koha | |
| 04:07 | khall joined #koha | |
| 04:09 | khall joined #koha | |
| 04:12 | khall joined #koha | |
| 04:16 | khall joined #koha | |
| 04:18 | khall joined #koha | |
| 04:18 | khall joined #koha | |
| 04:20 | khall joined #koha | |
| 04:25 | khall joined #koha | |
| 04:28 | khall joined #koha | |
| 04:30 | khall joined #koha | |
| 04:32 | khall joined #koha | |
| 04:34 | khall joined #koha | |
| 04:39 | josef_moravec joined #koha | |
| 04:40 | khall joined #koha | |
| 04:42 | indradg_ joined #koha | |
| 04:43 | khall joined #koha | |
| 04:48 | khall joined #koha | |
| 04:50 | khall joined #koha | |
| 04:50 | inlibro joined #koha | |
| 04:52 | khall joined #koha | |
| 04:55 | khall joined #koha | |
| 04:56 | khall joined #koha | |
| 04:58 | khall joined #koha | |
| 05:00 | khall joined #koha | |
| 05:02 | khall joined #koha | |
| 05:03 | chriss joined #koha | |
| 05:05 | khall joined #koha | |
| 05:06 | khall joined #koha | |
| 05:08 | khall joined #koha | |
| 05:18 | khall joined #koha | |
| 05:24 | did joined #koha | |
| 05:25 | TimothyAlexis joined #koha | |
| 05:29 | khall joined #koha | |
| 05:38 | khall joined #koha | |
| 05:43 | fridolin joined #koha | |
| 05:44 | bigbrovar joined #koha | |
| 05:48 | khall joined #koha | |
| 05:49 | koha-jenkins | Yippee, build fixed! |
| 05:49 | wahanui | Congratulations! |
| 05:49 | koha-jenkins | Project Koha_Master_D11 build #56: FIXED in 46 min: https://jenkins.koha-community[…]ha_Master_D11/56/ |
| 05:50 | inlibro joined #koha | |
| 05:56 | khall joined #koha | |
| 06:17 | khall joined #koha | |
| 06:26 | bigbrovar joined #koha | |
| 06:40 | khall joined #koha | |
| 06:41 | reiveune joined #koha | |
| 06:41 | reiveune | hello |
| 06:49 | khall joined #koha | |
| 06:50 | inlibro joined #koha | |
| 06:56 | khall joined #koha | |
| 07:04 | khall joined #koha | |
| 07:17 | cait joined #koha | |
| 07:19 | cait | oleonard++ # spam fighting |
| 07:20 | enkidu joined #koha | |
| 07:28 | khall joined #koha | |
| 07:32 | khall joined #koha | |
| 07:34 | janncis | Hello guys I have problem with error, <<cant locate object method ¨build_query¨ via package ¨Koha::SearchEngine::ElasticSearch¨ At the code start I have reference to it use Koha::SearchEngine::Elasticsearch::QueryBuilder; |
| 07:34 | Elastic searsch is also installed | |
| 07:47 | ashimema | mornin' |
| 07:50 | inlibro joined #koha | |
| 07:51 | ashimema | bug 26140 |
| 07:51 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=26140 normal, P5 - low, ---, koha-bugs, NEW , .tt template files should be deployed separately from static assets |
| 07:53 | ashimema | @later tell dcook I always tried to include Oceania timezones for at least some of the meetings... problem was I often didn't get anyone turn up at all so I kinda gave up a bit and asked for folks to specifically ask for a meeting at their time if they wanted to contribute. |
| 07:53 | huginn | ashimema: The operation succeeded. |
| 07:53 | ashimema | @later tell dcook.. plus by that time I was often falling asleep myself and struggled to run it ;) |
| 07:53 | huginn | ashimema: The operation succeeded. |
| 07:54 | khall joined #koha | |
| 07:55 | khall joined #koha | |
| 08:18 | cait joined #koha | |
| 08:23 | tuxayo | hi #koha o/ |
| 08:24 | josef_moravec: I think active CoCe users are Tamil and ByWater at least. | |
| 08:24 | josef_moravec | tuxayo: thanks for the information! |
| 08:25 | * dcook_ | perks up |
| 08:25 | dcook_ | morning ashimema |
| 08:26 | dcook | ashimema: I've put the next dev meeting in my calendar. Looks like midnight next Thursday, but I think that could be doable. |
| 08:27 | I like the idea of Bug 26140 but feel a bit hopeless about it | |
| 08:27 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=26140 normal, P5 - low, ---, koha-bugs, NEW , .tt template files should be deployed separately from static assets |
| 08:27 | dcook | salut tuxayo |
| 08:28 | ashimema | brb.. need to restart |
| 08:29 | * dcook | is working on bug 25905 atm in any case after receiving tcohen's encouragement last night |
| 08:29 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=25905 enhancement, P5 - low, ---, dcook, NEW , REST API: create endpoint for importing OAI-PMH records from external OAI-PMH clients |
| 08:30 | dcook | Annnd of course just as I'm working on it I think of another schema change a person could do :| |
| 08:30 | khall joined #koha | |
| 08:36 | dcook | Now how to add a non-plugin API route.. |
| 08:37 | khall joined #koha | |
| 08:46 | magnuse | dcook++ |
| 08:47 | dcook | It'll never be perfect enough for me, but just need to get *something* out |
| 08:48 | magnuse | that's the spirit! |
| 08:51 | inlibro joined #koha | |
| 08:59 | josef_moravec left #koha | |
| 09:06 | tuxayo | hi dcook :) |
| 09:10 | dcook | :D |
| 09:10 | Now remembering the convention for making things from Koha::Objects.. | |
| 09:11 | khall joined #koha | |
| 09:22 | khall joined #koha | |
| 09:23 | jeff joined #koha | |
| 09:25 | ashimema | dcook.. 'dbic' in k-t-d is the alias your looking for I tihnk |
| 09:25 | dcook | ashimema: My aliases must be out of date as I don't see that one :o |
| 09:26 | That does sound familiar though | |
| 09:26 | khall joined #koha | |
| 09:27 | dcook | Hoping to get this bug done tonight.. |
| 09:27 | ashimema | :) |
| 09:27 | dcook | I actually have most of the code already written. It's just about copying and pasting it >_> |
| 09:27 | And then writing up some unit tests | |
| 09:29 | Of course, that's just for the "import" functionality | |
| 09:30 | I don't have any ready to go downloaders of OAI-PMH records yet | |
| 09:30 | Although a person could slap one together so easily.. | |
| 09:31 | khall joined #koha | |
| 09:33 | khall joined #koha | |
| 09:34 | khall joined #koha | |
| 09:35 | khall joined #koha | |
| 09:38 | khall joined #koha | |
| 09:38 | huginn | News from kohagit: Bug 25871: DBRev 20.06.00.021 <http://git.koha-community.org/[…]e13029a91152fbefd> |
| 09:38 | News from kohagit: Bug 25683: (follow-up) Use COALESCE instead of IFNULL <http://git.koha-community.org/[…]2525be62505d752f9> | |
| 09:38 | News from kohagit: Bug 26017: (follow-up) Serverside permission check on registers page <http://git.koha-community.org/[…]882a7139e627b22c6> | |
| 09:38 | News from kohagit: Bug 26124: Load TinyMCE assets in correct order <http://git.koha-community.org/[…]be3aa8de4c4608efe> | |
| 09:38 | News from kohagit: Bug 25871: (QA follow-up) Update syspref <http://git.koha-community.org/[…]6f471b97eca713d8d> | |
| 09:38 | News from kohagit: Bug 26131: Remove parentheses in circulation.pref <http://git.koha-community.org/[…]68ea0329842e4d3e2> | |
| 09:38 | News from kohagit: Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search <http://git.koha-community.org/[…]2f4d63b33949554c0> | |
| 09:38 | News from kohagit: Bug 26121: Add z-index for CodeMirror <http://git.koha-community.org/[…]8434671700bf6984d> | |
| 09:38 | News from kohagit: Bug 26115: Remove leftover Carp::Always <http://git.koha-community.org/[…]9f711f617d0befe6e> | |
| 09:38 | News from kohagit: Bug 26098: Fix JS error on the fund list view when no fund displayed <http://git.koha-community.org/[…]0d2dec4f2875f2ddd> | |
| 09:38 | News from kohagit: Bug 26037: openlibrary.org is hit on every Koha requests <http://git.koha-community.org/[…]61555e1633f95a6fe> | |
| 09:38 | News from kohagit: Bug 26017: Correct permission check on tools page <http://git.koha-community.org/[…]29b2758db2b1f755e> | |
| 09:38 | News from kohagit: Bug 25893: Use wildcards when searching logs <http://git.koha-community.org/[…]4d3a8b99f3916f942> | |
| 09:38 | News from kohagit: Bug 25871: Add "only library" to OpacItemLocation options <http://git.koha-community.org/[…]681dfa662313e4cee> | |
| 09:38 | News from kohagit: Bug 25683: Fix grouping of results <http://git.koha-community.org/[…]2d2f3042fe1331e0e> | |
| 09:38 | News from kohagit: Bug 25683: Patron with no accountlines should have 0 outstanding (not NULL) <http://git.koha-community.org/[…]d80e797b3cb1175c5> | |
| 09:44 | khall joined #koha | |
| 09:46 | khall joined #koha | |
| 09:50 | khall joined #koha | |
| 09:51 | inlibro joined #koha | |
| 09:51 | khall joined #koha | |
| 09:55 | khall joined #koha | |
| 10:01 | khall joined #koha | |
| 10:02 | bigbrovar joined #koha | |
| 10:04 | khall joined #koha | |
| 10:05 | janncis | has anyone tested elasticsearch build_query with elasticsearch 6.8.9? Im getting bad query |
| 10:05 | "message": "Properties not allowed: _shards, aggregations, hits, timed_out, took.", | |
| 10:06 | query does include aggregations | |
| 10:06 | khall joined #koha | |
| 10:09 | dcook | janncis: I don't use elasticsearch, so no ideas, unfortunately |
| 10:10 | khall joined #koha | |
| 10:16 | khall joined #koha | |
| 10:17 | Joubu | janncis: what are you doing exactly? |
| 10:18 | janncis | Joubu trying to make api that would use elasticsearch engine and eturn found items |
| 10:18 | return* | |
| 10:19 | khall joined #koha | |
| 10:21 | koha-jenkins | Project Koha_Master_D9 build #1402: STILL UNSTABLE in 42 min: https://jenkins.koha-community[…]a_Master_D9/1402/ |
| 10:25 | Project Koha_Master_D9_MDB_Latest build #361: STILL UNSTABLE in 47 min: https://jenkins.koha-community[…]9_MDB_Latest/361/ | |
| 10:26 | khall joined #koha | |
| 10:28 | khall joined #koha | |
| 10:32 | khall joined #koha | |
| 10:32 | bigbrovar joined #koha | |
| 10:34 | koha-jenkins | Project Koha_Master_D10 build #321: UNSTABLE in 54 min: https://jenkins.koha-community[…]a_Master_D10/321/ |
| 10:41 | Yippee, build fixed! | |
| 10:41 | wahanui | Congratulations! |
| 10:41 | koha-jenkins | Project Koha_Master_U20 build #64: FIXED in 1 hr 1 min: https://jenkins.koha-community[…]ha_Master_U20/64/ |
| 10:41 | bigbrovar joined #koha | |
| 10:51 | inlibro joined #koha | |
| 10:52 | Joubu | @later tell lukeG Hi Lucas, please add 26134 to your list for the next 20.05 release |
| 10:52 | huginn | Joubu: The operation succeeded. |
| 10:52 | Joubu | bug 26134 |
| 10:52 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=26134 critical, P5 - low, ---, jonathan.druart, Needs Signoff , Error when adding to basket from new/staged file when using MARCItemFieldsToOrder |
| 11:01 | josef_moravec joined #koha | |
| 11:02 | koha-jenkins | Project Koha_Master_U18 build #863: STILL UNSTABLE in 40 min: https://jenkins.koha-community[…]a_Master_U18/863/ |
| 11:03 | dcook | Wow... just read the code for Koha::DateUtils |
| 11:03 | Can't believe we're not using DateTime::Format::Strptime | |
| 11:09 | koha-jenkins | Yippee, build fixed! |
| 11:09 | wahanui | Congratulations! |
| 11:09 | koha-jenkins | Project Koha_Master_D10_Deps build #47: FIXED in 44 min: https://jenkins.koha-community[…]ster_D10_Deps/47/ |
| 11:19 | dcook | Ok core stuff there... now to do some unit tests.. |
| 11:28 | koha-jenkins | Project Koha_Master_D11 build #57: UNSTABLE in 53 min: https://jenkins.koha-community[…]ha_Master_D11/57/ |
| 11:30 | dcook | Me thinks the unit testing has improved a lot since I last looked... |
| 11:33 | ashimema | :) |
| 11:34 | oleonard | o/ |
| 11:34 | ashimema | Koha::DateUtils is a little scary dcook |
| 11:34 | dcook | ashimema: You're telling me O_O |
| 11:34 | ashimema | I'e added loads more tests around that code of late.. but yes.. I still wonder about some of it |
| 11:34 | dcook | And DateTime::Format::Strptime is our friend |
| 11:35 | ashimema | yeah.. |
| 11:35 | dcook | hola oleonard |
| 11:35 | ashimema | we have a bad habbit of re-inventing the wheel in koha |
| 11:35 | dcook | Yup |
| 11:35 | ashimema | datatables peoples... |
| 11:36 | Joubu | lol |
| 11:36 | ashimema | if I have a column that should be available or not depending on a syspref.. how do I do that and stay compatible with the column picker too? |
| 11:36 | Joubu | I will stay off this discussion :) |
| 11:36 | dcook | heh |
| 11:36 | ashimema | hehe |
| 11:36 | dcook | Well, I should try to finish these tests |
| 11:36 | Actually.. | |
| 11:36 | * ashimema | has moved on from the DateUtils discussion ;) |
| 11:36 | dcook | Curious about Test::DBIx::Class... |
| 11:37 | I want to do a number of self-contained tests | |
| 11:37 | I figure I'll probably need to mock the database for each subtest? | |
| 11:37 | ashimema | oleonard.. happen to know of any cases like the above for datatables examples.. |
| 11:37 | before I go on a wild goose chase | |
| 11:37 | dcook | ohh reset_schema... beautiful |
| 11:38 | * dcook | hopes for the best and dives back into the code |
| 11:39 | oleonard | ashimema I feel like I've dealt with that before but now I can't remember :( |
| 11:39 | ashimema | haha.. no worries |
| 11:39 | I'll go code diving again | |
| 11:42 | koha-jenkins | Yippee, build fixed! |
| 11:42 | wahanui | Congratulations! |
| 11:42 | koha-jenkins | Project Koha_Master_U16 build #39: FIXED in 40 min: https://jenkins.koha-community[…]ha_Master_U16/39/ |
| 11:51 | inlibro joined #koha | |
| 11:59 | dcook | Hmm test hanging... that's interesting |
| 11:59 | koha-jenkins | Project Koha_Master_D9_My8 build #384: STILL UNSTABLE in 49 min: https://jenkins.koha-community[…]aster_D9_My8/384/ |
| 12:03 | dcook | Damn, C4::Biblio::_koha_add_biblio() does not seem happy.. |
| 12:03 | AndrewFH joined #koha | |
| 12:04 | dcook | I'm guessing because it's not DBIx::Class... |
| 12:04 | But then again.. | |
| 12:05 | C4::Biblio::_koha_add_biblio(): DBI Exception: DBD::SQLite::db prepare failed: near "SET": syntax error at /kohadevbox/koha/C4/Biblio.pm line 219 | |
| 12:08 | khall joined #koha | |
| 12:08 | dcook | Ugh, because we're using a MySQLish in _koha_add_biblio |
| 12:08 | :| | |
| 12:12 | Joubu | not using mysql or mariadb? |
| 12:12 | dcook | Test::DBIx::Class uses SQLite when it mocks the db it seems |
| 12:12 | I imagine DBIx::Class code uses standard SQL, but I have to invoke C4::Biblio functions in my code and that's causing the problem :( | |
| 12:15 | Going to give up for tonight I think | |
| 12:15 | Making _koha_add_biblio use standard SQL seems too hard... as does rewriting it to use DBIx::Class.. | |
| 12:16 | I'll just have to use the old style unit testing of turning off Autocommit and rolling back | |
| 12:16 | Unless anyone has a better idea | |
| 12:17 | Joubu | txn_begin instead |
| 12:18 | dcook | Mmm that sounds familiar. I'm listening |
| 12:19 | Joubu | use a proper transaction handled by dbic |
| 12:19 | what is the mysqlism in _koha_add_biblio? | |
| 12:19 | dcook | Joubu: It's the INSERT INTO.. SET syntax it seems |
| 12:19 | I think that's the first time I've ever actually seen that syntax used at all | |
| 12:19 | Joubu | ho right, never seen it either |
| 12:20 | dcook | Rather than INSERT INTO.. VALUES |
| 12:20 | Right? | |
| 12:20 | Joubu | yes |
| 12:20 | well that can be fixed easily | |
| 12:20 | dcook | Looks like an easy fix but a high risk area |
| 12:20 | Joubu | no risk |
| 12:20 | dcook | I suppose if it failed we'd now early.. |
| 12:20 | know early* | |
| 12:21 | Joubu: Happy for me to write a patch converting that into INSERT INTO.. VALUES syntax? | |
| 12:22 | Joubu | yes |
| 12:22 | dcook | Cool. I'll bang out a patch for that promptly |
| 12:23 | Joubu | you can even link it with bug 7365 |
| 12:23 | huginn | Bug http://bugs.koha-community.org[…]w_bug.cgi?id=7365 enhancement, P5 - low, ---, koha-bugs, NEW , Koha should support PostgreSQL |
| 12:23 | dcook | Sounds good |
| 12:24 | indradg_ joined #koha | |
| 12:24 | dcook | Of course now I get the following: |
| 12:24 | C4::Biblio::_koha_add_biblio(): DBI Exception: DBD::SQLite::db prepare failed: no such function: NOW at /kohadevbox/koha/C4/Biblio.pm line 219 | |
| 12:24 | ahhhh | |
| 12:25 | lukeG1 joined #koha | |
| 12:26 | dcook | Actually, I might just wind up for the day. I try to have a rule of no coding after 10pm... |
| 12:28 | Joubu | you can pass dt_from_string instead |
| 12:29 | dcook: what do you want to test exactly with your tests? | |
| 12:30 | dcook | Bug 25905 |
| 12:30 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=25905 enhancement, P5 - low, ---, dcook, NEW , REST API: create endpoint for importing OAI-PMH records from external OAI-PMH clients |
| 12:30 | Joubu | are you aware of t::lib::TestBuilder? You have handy methods like build_sample_biblio |
| 12:30 | dcook | Basically that my function is able to take OAI-PMH XML and add/modify/delete biblios as necessary |
| 12:30 | Joubu | it will return you a Koha::Biblio object |
| 12:31 | dcook | I think the txn_begin should do the trick |
| 12:31 | It'll just have to wait until next week | |
| 12:31 | Thanks for pointing it out :) | |
| 12:33 | Joubu | if you want to write tests for endpoints you should search in t/db_dependent/api/v1 |
| 12:39 | dcook | Yeah, I was wondering what Koha's requirements were for that |
| 12:40 | I was planning on testing the underlying function most thoroughly | |
| 12:40 | To test the business logic | |
| 12:40 | But I'll want to test the api too for the api/controller logic | |
| 12:40 | But... another day | |
| 12:41 | Thanks for your help :) | |
| 12:41 | Here's hoping I have the motivation to keep going with this next week.. | |
| 12:41 | tcohen++ | |
| 12:41 | @later tell tcohen thanks to your kind words yesterday I've nearly finished 25905 | |
| 12:41 | huginn | dcook: The operation succeeded. |
| 12:43 | oleonard | Hey someone should sign off on Bug 25954. It's a good one. Accessibility! |
| 12:43 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=25954 minor, P5 - low, ---, oleonard, Needs Signoff , Header search forms should be labeled |
| 12:44 | ashimema | any good example bugs where we add the column settings configuration to a table? |
| 12:45 | oooh.. good call oleonard | |
| 12:45 | I'll add that to my list | |
| 12:45 | Marie-Luce joined #koha | |
| 12:46 | fridolin joined #koha | |
| 12:46 | Joubu | ashimema: e68fe2a928bec05b9602fa28dfbc86e04657ce81 |
| 12:46 | you have all you need in this commit | |
| 12:46 | ashimema | awesome.. just what I was looking for Joubu :) |
| 12:46 | thanks | |
| 12:51 | inlibro joined #koha | |
| 13:17 | khall joined #koha | |
| 13:26 | ashimema | curse memcached |
| 13:44 | is there some magic one has to do to get the 'columns' config to show up in the table header? | |
| 13:45 | khall joined #koha | |
| 13:45 | Joubu | use KohaTable |
| 13:45 | it will do it for you | |
| 13:45 | ashimema | I am |
| 13:45 | Joubu | do you have a specific sDom? |
| 13:45 | dom | |
| 13:45 | ashimema | and the column settings are being applied from setting them on the page via admin |
| 13:46 | nope.. no special dom | |
| 13:47 | Joubu | weird |
| 13:47 | cannot think of something right now | |
| 13:47 | following what oleonard did for viewlog should be enough | |
| 13:48 | ashimema | I'll keep digging |
| 13:48 | oleonard | ashimema if I get table settings working on the first try I take the rest of the day off to celebrate :) |
| 13:48 | ashimema | hehehe |
| 13:49 | oleonard | Seems like there's so many pieces. |
| 13:49 | ashimema | next challenge is to remove the 'export' option |
| 13:50 | I want the column settings one which doesn't appear but don't want the export one, which does! | |
| 13:50 | grr | |
| 13:50 | oleonard | That's a new one to me |
| 13:52 | inlibro joined #koha | |
| 13:52 | ashimema | it looks like it should be soo simple |
| 13:52 | lol | |
| 13:52 | oleonard | Why don't you want the export options? |
| 13:53 | ashimema | it's bug 26160 |
| 13:53 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=26160 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Add column configuration to sales table to allow hiding of 'Code' column |
| 13:53 | ashimema | I can't really see any reason you'd ever want to export this list.. it's more of a table to interact with than one to get data out of in that way |
| 13:54 | oleonard | Unless there's a reason why the user *shouldn't* export from that table I wouldn't worry about hiding it because you think they wouldn't want to. |
| 13:54 | Joubu | you will certainly need to add a flag to the table settings DB table/config, to make it configurable |
| 13:54 | but yes, as oleonard said, I would not worry about it to be displayed | |
| 13:54 | ashimema | well.. the main reason I want to get rid of it is that it doesn't fit.. even on my really wide screen monitor it looks messed up |
| 13:55 | fair enough | |
| 13:56 | AndrewFH joined #koha | |
| 14:12 | Joubu | Thanks oleonard, I secretly hoped you would write something to make bug 16112 nicer ;) |
| 14:13 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=16112 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Specify due date for batch renew |
| 14:36 | lukeG1 | Has anyone encountered an error like this when running yarn build in KTD? |
| 14:36 | http://paste.koha-community.org/25118 | |
| 14:37 | tuxayo | lukeG1: nope |
| 14:45 | Joubu | lukeG1: weird, maybe try to remove the node_modules dir? |
| 14:45 | (then yarn install;yarn build | |
| 14:45 | ) | |
| 14:47 | lukeG1 | Joubu: npm install makes it work, though Im not sure why |
| 14:49 | ashimema | yes |
| 14:49 | I bet you tested the bootstrap 4 branch | |
| 14:50 | you need to re-run yarn install and it'll revert your npm modules | |
| 14:52 | inlibro joined #koha | |
| 14:52 | lukeG1 | ashimema, yup that would be it |
| 14:53 | thanks | |
| 14:56 | oleonard | There is a simple fix to the gulpfile that prevents the need to re-run yarn install but I wasn't sure if it was worth submitting as a separate patch |
| 15:19 | fridolin left #koha | |
| 15:22 | AndrewFH joined #koha | |
| 15:25 | oleonard | ashimema++ |
| 15:25 | Nice work on Bug 25242 | |
| 15:25 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=25242 enhancement, P5 - low, ---, oleonard, Signed Off , Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom |
| 15:43 | oleonard | josef_moravec with a fast smackdown on 25954 :D |
| 15:43 | josef_moravec++ | |
| 15:44 | josef_moravec | oleonard: sorry ;) |
| 15:45 | josef_moravec left #koha | |
| 15:45 | josef_moravec joined #koha | |
| 15:45 | oleonard | How have you been josef_moravec? Seems like I haven't seen you in a while |
| 15:46 | ashimema | 😀 |
| 15:46 | Might be worth also adding to staff, but though that would be a separate bug | |
| 15:46 | josef_moravec | oleonard: busy days becomes busy months, but hopefully it's going to be better ;) |
| 15:47 | khall joined #koha | |
| 15:49 | oleonard | ashimema: Testing the OPAC at 200% zoom makes Bug 26164 more urgent :) |
| 15:49 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=26164 enhancement, P5 - low, ---, oleonard, ASSIGNED , Replace OPAC table sort icons with SVG |
| 15:52 | inlibro joined #koha | |
| 16:09 | ashimema | Haha.. yeah.. it's evil ain't it. |
| 16:09 | reiveune | bye |
| 16:09 | reiveune left #koha | |
| 16:13 | ashimema | :) |
| 16:17 | I bet there's an obvious answer to this.. but why do we have a 'table' class attached to lots of 'table' tags?.. could we not just have the css at the 'table' level rather than '.table' ? | |
| 16:19 | in a quick grep it certainly looks like they're all on <table> elements.. are those tables really so special compared to any other table.. i.e shouldn't we be consistent and apply whatever that css formatting it to tables in general | |
| 16:19 | oleonard ^ | |
| 16:23 | oleonard | In the OPAC? |
| 16:23 | ashimema | indeed |
| 16:23 | it's actually only three tables.. | |
| 16:23 | shelfbrowser, opac-shelves and opac-basket | |
| 16:24 | I bet it's just a small mistake rather than a deliberate action | |
| 16:24 | it just confused me a little when trying to work out what to bind on when adding my css rules for that overflow bug | |
| 16:24 | oleonard | The .table class is a Bootstrap thing |
| 16:24 | ashimema | oh really.. |
| 16:24 | interesting | |
| 16:24 | oleonard | I'm not sure why it's only in a few places |
| 16:25 | ashimema | so it should be applied to all our tables really then? |
| 16:25 | oleonard | I don't actually know! |
| 16:25 | ashimema | hehe.. sorry ;) |
| 16:26 | ooh.. actually.. it's more widely used than I thought.. | |
| 16:26 | my grep was bad | |
| 16:26 | oleonard | That's a bad grep |
| 16:27 | ...you know? ...like on that baking show? | |
| 16:27 | ashimema | lol |
| 16:28 | oleonard | ashimema if you're thinking about changing it please postpone or make it dependent on Bug 20168 |
| 16:28 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=20168 enhancement, P5 - low, ---, oleonard, Needs Signoff , Update of the OPAC bootstrap template to bootstrap v4 |
| 16:29 | oleonard | I still hang on to hope that it will make progress soon :) |
| 16:30 | ashimema | I wasn't intending on touching it any time soon.. just wondered ;) |
| 16:30 | deffo get bootstrap 4 in first.. | |
| 16:30 | right.. cycle time for me.. laters | |
| 16:30 | oleonard | have fun, don't eat a bug |
| 16:50 | juanyo joined #koha | |
| 16:50 | juanyo | hello everyone i would like to add a new menu item in moresearches, someone who has done it, can you tell me how to do it? thank you very much |
| 16:52 | inlibro joined #koha | |
| 16:55 | oleonard | In the staff client juanyo? |
| 16:55 | Or OpacMoreSearches ? | |
| 16:56 | juanyo | o sorry in the OpacMoreSearches |
| 16:57 | oleonard | <li><a href="#">A new link</a></li> |
| 16:58 | Each link should be wrapped in <li></li> | |
| 16:59 | juanyo | ah OK tank you very much! |
| 16:59 | oleonard | 👍️ |
| 17:00 | josef_moravec joined #koha | |
| 17:35 | lisettelatah joined #koha | |
| 17:52 | inlibro joined #koha | |
| 18:15 | indradg_ joined #koha | |
| 18:34 | khall joined #koha | |
| 18:52 | inlibro joined #koha | |
| 19:03 | khall joined #koha | |
| 19:31 | khall joined #koha | |
| 19:53 | inlibro joined #koha | |
| 20:43 | koha-jenkins | Yippee, build fixed! |
| 20:43 | wahanui | Congratulations! |
| 20:43 | koha-jenkins | Project Koha_20.05_D10 build #54: FIXED in 42 min: https://jenkins.koha-community[…]oha_20.05_D10/54/ |
| 20:43 | Project Koha_20.05_D9_My8 build #50: UNSTABLE in 41 min: https://jenkins.koha-community[…]_20.05_D9_My8/50/ | |
| 20:53 | inlibro joined #koha | |
| 20:54 | koha-jenkins | Project Koha_20.05_U18 build #48: SUCCESS in 50 min: https://jenkins.koha-community[…]oha_20.05_U18/48/ |
| 21:02 | Project Koha_20.05_D9 build #60: SUCCESS in 59 min: https://jenkins.koha-community[…]Koha_20.05_D9/60/ | |
| 21:06 | alexbuckley joined #koha | |
| 21:06 | koha-jenkins | Project Koha_20.05_U20 build #45: SUCCESS in 1 hr 3 min: https://jenkins.koha-community[…]oha_20.05_U20/45/ |
| 21:13 | cait joined #koha | |
| 21:20 | koha-jenkins | Project Koha_20.05_D10 build #55: UNSTABLE in 36 min: https://jenkins.koha-community[…]oha_20.05_D10/55/ |
| 21:28 | Project Koha_20.05_U16 build #44: UNSTABLE in 45 min: https://jenkins.koha-community[…]oha_20.05_U16/44/ | |
| 21:45 | Project Koha_20.05_D9_My8 build #51: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]_20.05_D9_My8/51/ | |
| 21:53 | inlibro joined #koha | |
| 21:59 | koha-jenkins | Project Koha_20.05_U18 build #49: UNSTABLE in 57 min: https://jenkins.koha-community[…]oha_20.05_U18/49/ |
| 21:59 | Project Koha_20.05_D9 build #61: UNSTABLE in 39 min: https://jenkins.koha-community[…]Koha_20.05_D9/61/ | |
| 22:07 | Project Koha_20.05_U20 build #46: UNSTABLE in 1 hr 1 min: https://jenkins.koha-community[…]oha_20.05_U20/46/ | |
| 22:11 | Project Koha_20.05_D10 build #56: STILL UNSTABLE in 42 min: https://jenkins.koha-community[…]oha_20.05_D10/56/ | |
| 22:33 | Project Koha_20.05_U16 build #45: STILL UNSTABLE in 47 min: https://jenkins.koha-community[…]oha_20.05_U16/45/ | |
| 22:53 | inlibro joined #koha | |
| 23:53 | inlibro joined #koha |
← Previous day | Today | Next day → | Search | Index