← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
Time | Nick | Message |
---|---|---|
00:03 | inlibro joined #koha | |
01:03 | inlibro joined #koha | |
01:16 | khall joined #koha | |
01:28 | sophie_m joined #koha | |
01:28 | black23[m] joined #koha | |
01:28 | janPasi joined #koha | |
01:28 | koha-jenkins joined #koha | |
01:28 | mirkh joined #koha | |
01:28 | matts joined #koha | |
01:28 | lari joined #koha | |
01:28 | kivilahtio joined #koha | |
01:28 | magnuse joined #koha | |
01:28 | iGNUjee[m] joined #koha | |
01:28 | slef joined #koha | |
01:28 | zb joined #koha | |
01:28 | Joubu joined #koha | |
01:28 | nage joined #koha | |
01:28 | aaru_swartz[m] joined #koha | |
01:28 | sonOfRa joined #koha | |
01:28 | AnnaBoten joined #koha | |
01:28 | Nemo_bis joined #koha | |
01:28 | jo joined #koha | |
01:28 | jajm joined #koha | |
01:28 | clrh joined #koha | |
01:28 | urra[m] joined #koha | |
01:28 | mjlassila joined #koha | |
01:28 | mtj[m] joined #koha | |
01:28 | SlackIntegration[m] joined #koha | |
01:28 | tuxayo[m] joined #koha | |
01:28 | ValterBarreira[m] joined #koha | |
01:28 | tuxayo[m]1 joined #koha | |
01:28 | skimsk joined #koha | |
01:32 | aleisha | is anyone else having huge trouble importing sample data in master through the installer? it's timing out for me every time unless i uncheck all of the boxes including mandatory data. then i can't manually import the sample data through my terminal because they're yml files. any help? |
01:33 | Joubu: can't test Bug 24474 until i can get master working unfortunately! | |
01:33 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=24474 critical, P5 - low, ---, martin.renvoize, Needs Signoff , Lost items that are checked out are always returned, even when attempting to renew them |
01:54 | khall joined #koha | |
02:03 | inlibro joined #koha | |
03:04 | inlibro joined #koha | |
03:12 | khall joined #koha | |
04:04 | inlibro joined #koha | |
04:13 | amoyano left #koha | |
04:26 | lavamind joined #koha | |
05:04 | inlibro joined #koha | |
06:04 | inlibro joined #koha | |
06:18 | chriss joined #koha | |
06:57 | cait joined #koha | |
07:04 | inlibro joined #koha | |
07:14 | did joined #koha | |
07:27 | chriss2 joined #koha | |
07:29 | ashimema | Hmm |
07:29 | * ashimema | goes to try a fresh install and play with sample data |
07:32 | kohaputti joined #koha | |
07:33 | davidnind joined #koha | |
07:37 | reiveune joined #koha | |
07:37 | reiveune | hello |
07:46 | magnuse | \o/ |
07:58 | cait joined #koha | |
08:03 | alex_a joined #koha | |
08:04 | alex_a | Bonjour |
08:04 | inlibro joined #koha | |
08:07 | paul_p joined #koha | |
08:12 | GeekRuthie joined #koha | |
08:12 | nugged joined #koha | |
08:17 | cait1 joined #koha | |
08:34 | bdonnahue joined #koha | |
08:39 | bdonnahue joined #koha | |
08:52 | andreashm joined #koha | |
08:53 | andreashm joined #koha | |
08:57 | huginn | News from kohagit: Bug 24846: DBRev 19.12.00.044 <http://git.koha-community.org/[…]03b18a58a964b2cdf> |
08:57 | News from kohagit: Bug 24298: DBRev 19.12.00.043 <http://git.koha-community.org/[…]348ab5a47bc9c25c7> | |
08:57 | News from kohagit: Bug 24846: Update items.onloan with the new due date <http://git.koha-community.org/[…]b934a8c0db82744e4> | |
08:57 | News from kohagit: Bug 24846: Link to the new tool <http://git.koha-community.org/[…]52612acbe2025268d> | |
08:57 | News from kohagit: Bug 24846: Add new tool to batch extend due dates <http://git.koha-community.org/[…]8469f6ef8d8b21b4a> | |
08:57 | News from kohagit: Bug 24846: Add new permission batch_extend_due_dates <http://git.koha-community.org/[…]4126de4eeacf3a504> | |
08:57 | News from kohagit: Bug 24298: Update test count and use build_sample_item <http://git.koha-community.org/[…]e7150a00d6dbf9536> | |
08:57 | News from kohagit: Bug 24298: (follow-up) Add missing filter! <http://git.koha-community.org/[…]ba9e63fadc50340e6> | |
08:57 | News from kohagit: Bug 24298: Add tests for ModItemTransfer <http://git.koha-community.org/[…]982ad3a6afd0254c6> | |
08:57 | News from kohagit: Bug 24298: Add return enums to branchstransfer triggers <http://git.koha-community.org/[…]4e7bc7d4bdc1f68f6> | |
08:57 | News from kohagit: Bug 24298: Record transfer triggers for returns <http://git.koha-community.org/[…]a1dca09528cda7c82> | |
09:05 | inlibro joined #koha | |
09:23 | iGNUjee[m] joined #koha | |
09:25 | huginn | News from kohagit: Bug 24298: (RM follow-up) Schema Class Update <http://git.koha-community.org/[…]83beb134c24fa90ce> |
09:25 | News from kohagit: Bug 24818: DBRev 19.12.00.046 <http://git.koha-community.org/[…]6207c4436c704df12> | |
09:25 | News from kohagit: Bug 3137: DBRev 19.12.00.045 <http://git.koha-community.org/[…]90ca178d68495d323> | |
09:25 | News from kohagit: Bug 3137: Compiled CSS <http://git.koha-community.org/[…]f621d22176209542d> | |
09:25 | News from kohagit: Bug 3137: (QA follow-up) Switch hidden for collapsed in text <http://git.koha-community.org/[…]211ae9ee0ce157e68> | |
09:25 | News from kohagit: Bug 24847: Select AND by default in items search <http://git.koha-community.org/[…]9a3abbbd975d1ddf6> | |
09:25 | News from kohagit: Bug 3137: (follow-up) Rename using 'collapse', remove syspref lettering and fix guara... <http://git.koha-community.org/[…]392983d53fdf356fc> | |
09:25 | News from kohagit: Bug 24844: Focus syspref searchbar <http://git.koha-community.org/[…]b5bfca5d74fb832c1> | |
09:25 | News from kohagit: Bug 24818: Update database accountlines.date to timestamp <http://git.koha-community.org/[…]282b754d941c53d95> | |
09:25 | News from kohagit: Bug 15775: Change wording slightly <http://git.koha-community.org/[…]3a18b8f8b8f0fd7ea> | |
09:25 | News from kohagit: Bug 24701: Add column config to course_items_table <http://git.koha-community.org/[…]ff230d10333fbbb0d> | |
09:25 | News from kohagit: Bug 3137: HideFieldsPatronAddForm syspref <http://git.koha-community.org/[…]a534a576e38ab9110> | |
09:25 | News from kohagit: Bug 15775: Show message on OPAC summary if holds are blocked due to fines <http://git.koha-community.org/[…]ebea065163fd7ea39> | |
09:25 | News from kohagit: Bug 24384: Add Access-Control-Allow-Origin support to OPAC reports svc <http://git.koha-community.org/[…]bd183f56888767ad8> | |
09:28 | Joubu | aleisha: you can use the reset_all alias to insert the sample data into a fresh new DB |
09:30 | vfernandes joined #koha | |
09:33 | koha-jenkins | Project Koha_Master_D9_MDB_Latest build #189: SUCCESS in 34 min: https://jenkins.koha-community[…]9_MDB_Latest/189/ |
09:39 | Project Koha_Master_D8 build #763: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_Master_D8/763/ | |
09:41 | huginn | News from kohagit: Bug 22987: DBRev 19.12.00.047 <http://git.koha-community.org/[…]167af2e687485597a> |
09:41 | News from kohagit: Bug 24726: Replace one occurrence in print statement <http://git.koha-community.org/[…]9361564208bb8c0b7> | |
09:41 | News from kohagit: Bug 24510: Add missing filter <http://git.koha-community.org/[…]ca30077a2020fc763> | |
09:41 | News from kohagit: Bug 24774: Set JSON indentation of 2 spaces in .editorconfig <http://git.koha-community.org/[…]f22f54501131f7d93> | |
09:41 | News from kohagit: Bug 24510: Code cleaning <http://git.koha-community.org/[…]4514c095a5d4060fe> | |
09:41 | News from kohagit: Bug 24510: When Placing a Hold, cursor doesn't focus on Patron Name <http://git.koha-community.org/[…]4507b894575df3441> | |
09:41 | News from kohagit: Bug 24726: Update overdue_notices to use inbound_email_address <http://git.koha-community.org/[…]bbe91ca988fbadd3d> | |
09:41 | News from kohagit: Bug 24723: Update EmailPurchaseSuggestions to use inbound_email_address <http://git.koha-community.org/[…]94c4fa56fc4a9abb9> | |
09:41 | News from kohagit: Bug 24721: Update emailLibrarianWhenHoldIsPlaced to use inbound_email_address <http://git.koha-community.org/[…]14be853b5007e8a6a> | |
09:41 | News from kohagit: Bug 17674: Handling of special cases <http://git.koha-community.org/[…]dce8a84443150abe8> | |
09:41 | News from kohagit: Bug 24510: Add focus to Patron/club input <http://git.koha-community.org/[…]0687833ed6221be27> | |
09:41 | News from kohagit: Bug 22987: Add biblioimages.timestamp <http://git.koha-community.org/[…]688b3b867c83528af> | |
09:41 | News from kohagit: Bug 17674: Allow UI to delete serials in batch <http://git.koha-community.org/[…]5a32a3b898cf2d73a> | |
09:48 | koha-jenkins | Project Koha_Master_D9 build #1219: SUCCESS in 49 min: https://jenkins.koha-community[…]a_Master_D9/1219/ |
09:50 | vfernandes joined #koha | |
09:55 | khall joined #koha | |
10:00 | andreash_ joined #koha | |
10:03 | khall joined #koha | |
10:05 | inlibro joined #koha | |
10:10 | koha-jenkins | Project Koha_Master_U18 build #684: UNSTABLE in 36 min: https://jenkins.koha-community[…]a_Master_U18/684/ |
10:22 | bgkriegel joined #koha | |
10:24 | khall_ joined #koha | |
10:31 | koha-jenkins | Project Koha_Master_D10 build #135: UNSTABLE in 52 min: https://jenkins.koha-community[…]a_Master_D10/135/ |
10:39 | Project Koha_Master_D9_My8 build #215: UNSTABLE in 51 min: https://jenkins.koha-community[…]aster_D9_My8/215/ | |
10:45 | Project Koha_Master_D9_MDB_Latest build #190: UNSTABLE in 34 min: https://jenkins.koha-community[…]9_MDB_Latest/190/ | |
10:52 | khall joined #koha | |
11:05 | inlibro joined #koha | |
11:09 | khall_ joined #koha | |
11:10 | eythian | hi |
11:11 | koha-jenkins | Project Koha_Master_D8 build #764: UNSTABLE in 39 min: https://jenkins.koha-community[…]ha_Master_D8/764/ |
11:12 | davidnind left #koha | |
11:16 | koha-jenkins | Project Koha_19.11_D10 build #10: STILL UNSTABLE in 31 min: https://jenkins.koha-community[…]oha_19.11_D10/10/ |
11:16 | magnuse | kia ora eythian |
11:17 | eythian | hello magnuse |
11:21 | fribeiro joined #koha | |
11:22 | mferreira joined #koha | |
11:22 | andreashm joined #koha | |
11:24 | mferreira | Hi guys. I have a question about CAS Authentication. We are trying to obtain the user attributes (via $val->$doc) but the response does not include any attributes. The CAS Server we are connecting to returns attributes because we can see them in other applications. Do you know why this limitation exists? |
11:27 | koha-jenkins | Project Koha_19.11_U18 build #79: STILL UNSTABLE in 47 min: https://jenkins.koha-community[…]oha_19.11_U18/79/ |
11:34 | khall joined #koha | |
11:36 | andreashm joined #koha | |
11:37 | mferreira | is it because the CAS Client that Koha uses is using CAS protocol version 2.0 and attributes are only used in version 3.0? |
11:37 | cait1 | hi |
11:37 | I think you are on the right track | |
11:38 | Koha can't do any mappings with attributes at the moment | |
11:38 | and the perl library for CAS it uses is 2.0 | |
11:38 | we have added single logout (which is 3.0) too i think | |
11:38 | mferreira: ^ | |
11:39 | and thee is an open bug 14023 | |
11:39 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=14023 enhancement, P5 - low, ---, gmcharlt, NEW , Specify Attribute Mapping for CAS Authentication |
11:39 | ashimema | matts around ? |
11:39 | see mferreira's questions about CAS if you are ^ | |
11:40 | mferreira | Hi. I've seen that issue. Its basically what I need |
11:40 | We are trying to developing it. | |
11:41 | ashimema | aha.. excellent |
11:41 | mferreira | The problem is.. that the CAS response does not include any attributes for us to work with, and I wonder if this is a limitation of the CAS Client or the CAS protocol being used |
11:41 | cait1 | what do you wan to do actually? |
11:41 | mferreira | I guess is the client that is using at most CAS protocol version 2.0. |
11:42 | ashimema | https://metacpan.org/pod/Authen::CAS::Client |
11:42 | mferreira | I want to create the user if he doesn't exist if the login is successful |
11:42 | cait1 | ah |
11:42 | mferreira | but I need a few attributes |
11:42 | ashimema | we're at version 0.05 at the moment.. but I'm sure we could update that if required |
11:42 | cait1 | yeah Koha doesn't support that yet |
11:42 | you can check out the perl module, but I don't think it supports it | |
11:42 | mferreira | Basically, we want the same behaviour as the LDAP Auth implementation |
11:42 | cait1 | ashimema: that won't help |
11:42 | it officially only supports 1.0 and 2.0 | |
11:43 | mferreira | Yeah. Thats right |
11:43 | cait1 | 2.0 and 3.0 are not always compatible either |
11:43 | like... they changed the param name for logout redirect url | |
11:43 | mferreira | Is there any perl module that can support CAS 3.0? |
11:44 | cait1 | we run our Koha with a patch for that actually |
11:44 | koha-jenkins | Yippee, build fixed! |
11:44 | Project Koha_18.11_U18 build #259: FIXED in 28 min: https://jenkins.koha-community[…]ha_18.11_U18/259/ | |
11:44 | cait1 | mferreira: last time I investigated I didn't see a very good alternative, but worth looking |
11:44 | changing it in Koha woudl be a bigger piece of work i guess | |
11:44 | mferreira | :( |
11:47 | ashimema | looks to me like most other modules are wrappers around the one we're using. |
11:48 | doesn't look like it's an especially active or maintained module.. :( | |
11:49 | looking at it.. I think it would need some restructuring to support all three protocol versions.. | |
11:50 | even supporting 1.0 and 2.0 looks like a bit of a hack | |
11:50 | koha-jenkins | Project Koha_Master_D9 build #1220: FAILURE in 23 min: https://jenkins.koha-community[…]a_Master_D9/1220/ |
11:51 | mferreira | 3.0.2 The current CAS protocol specification is 3.0.2. The actual protocol specification is available at CAS-Protocol-Specification, which is hereby implemented by the Apereo CAS Server as the official reference implementation. It’s mainly a capture of the most common enhancements built on top of the CAS protocol revision 2.0. Among all features, the most noticeable update between versions 2.0 and 3.0 is the ability to return the authentic |
11:52 | https://apereo.github.io/cas/5[…]CAS-Protocol.html | |
11:53 | cait1 | mferreira: there are other changes |
11:53 | print $query->redirect( $cas->logout_url(url => $uri)); won't work with 3.0 | |
11:54 | because url is now service | |
11:54 | i can share our fix if that helps | |
11:58 | koha-jenkins | Yippee, build fixed! |
11:58 | Project Koha_19.05_D9 build #157: FIXED in 46 min: https://jenkins.koha-community[…]oha_19.05_D9/157/ | |
11:59 | andreash_ joined #koha | |
11:59 | Dyrcona joined #koha | |
11:59 | andreash_ joined #koha | |
12:00 | andreash_ joined #koha | |
12:01 | andreash_ joined #koha | |
12:02 | andreash_ joined #koha | |
12:02 | andreash_ joined #koha | |
12:03 | andreash_ joined #koha | |
12:03 | fridolin joined #koha | |
12:04 | andreash_ joined #koha | |
12:05 | andreash_ joined #koha | |
12:05 | inlibro joined #koha | |
12:06 | andreash_ joined #koha | |
12:06 | andreashm joined #koha | |
12:08 | andreashm joined #koha | |
12:10 | andreashm joined #koha | |
12:16 | fridolin joined #koha | |
12:21 | koha-jenkins | Project Koha_Master_U18 build #685: STILL UNSTABLE in 36 min: https://jenkins.koha-community[…]a_Master_U18/685/ |
12:23 | Dyrcona1 joined #koha | |
12:24 | Dyrcona1 joined #koha | |
12:28 | Dyrcona joined #koha | |
12:29 | tcohen | morning |
12:36 | caroline joined #koha | |
12:42 | cait1 | morning tcohen and caroline |
12:46 | caroline | good morning! |
12:47 | alex_a_ joined #koha | |
12:50 | koha-jenkins | Project Koha_Master_D10 build #136: STILL UNSTABLE in 52 min: https://jenkins.koha-community[…]a_Master_D10/136/ |
12:57 | khall joined #koha | |
12:57 | fridolin1 joined #koha | |
13:04 | koha-jenkins | Project Koha_Master_D9 build #1221: NOW UNSTABLE in 50 min: https://jenkins.koha-community[…]a_Master_D9/1221/ |
13:05 | inlibro joined #koha | |
13:07 | bgkriegel joined #koha | |
13:08 | huginn | News from kohagit: Bug 24818: (RM follow-up) Update account_line date definition <http://git.koha-community.org/[…]97965255e0a98bf4f> |
13:08 | News from kohagit: Bug 24818: (RM follow-up) Update tests for DATE -> TIMESTAMP change <http://git.koha-community.org/[…]8fc1b03369c71162d> | |
13:43 | koha-jenkins | Yippee, build fixed! |
13:43 | Project Koha_Master_D9 build #1222: FIXED in 34 min: https://jenkins.koha-community[…]a_Master_D9/1222/ | |
13:45 | andreash_ joined #koha | |
13:47 | corilynn | Can I get a sign off on bug 24108 pretty please? |
13:47 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=24108 enhancement, P5 - low, ---, carnold, Needs Signoff , Advanced Editor: Save .mrc save with a configurable value |
13:47 | corilynn | it's trivial, but important to us |
13:50 | Joubu | corilynn: please resubmit with a correct indentation |
13:51 | corilynn | oh |
13:51 | *just* got my env setup, i'll try | |
13:52 | Joubu | corilynn: should not be better to have the option on the UI? |
13:52 | corilynn | Joubu, yes? But how do I do that different? |
13:54 | Joubu, are you saying the indindation for the [% IF stuff? Or do I have my spaces wrong? | |
13:55 | pastebot | Someone at 127.0.0.1 pasted "303 save: function( id, record" (28 lines) at http://paste.koha-community.org/19077 |
13:55 | Joubu | corilynn: that |
13:56 | corilynn | okay, cool, np |
13:57 | what methodologies are there for "option on the UI", Joubu? | |
13:57 | Joubu | corilynn: not sure it makes sense, but having the option at syspref level does not seem flexible. |
13:57 | corilynn | ok, what previous release can I look at to figure out how to put it in the UI? |
13:57 | s/release/bug#/ | |
13:58 | Joubu | so either 2 new entries under the "Save" button or a popup asking if the name should be id, controlnumber, something else? |
13:58 | koha-jenkins | Yippee, build fixed! |
13:58 | Project Koha_Master_U18 build #686: FIXED in 48 min: https://jenkins.koha-community[…]a_Master_U18/686/ | |
14:00 | corilynn | eh, no, this should be a one-and-done thing, hate to have them need to keep selecting over and over |
14:00 | therefor, syspref I think is better | |
14:01 | less clicks = happier catalogers | |
14:02 | right now the interface saves everything as "record.mrc" which is kinda ridiculous | |
14:03 | koha-jenkins | Yippee, build fixed! |
14:03 | Project Koha_Master_D10 build #137: FIXED in 52 min: https://jenkins.koha-community[…]a_Master_D10/137/ | |
14:05 | Joubu | it saves as $biblionumber.mrc for me |
14:05 | inlibro joined #koha | |
14:06 | corilynn | as it should |
14:06 | you mean, without the rollout? | |
14:10 | Joubu | you are right, record.mrc! I though I was against master but I still have your patch applied |
14:19 | corilynn | k |
14:19 | koha-jenkins | Yippee, build fixed! |
14:19 | Project Koha_Master_D9_My8 build #216: FIXED in 36 min: https://jenkins.koha-community[…]aster_D9_My8/216/ | |
14:23 | paul_p joined #koha | |
14:23 | paul_p joined #koha | |
14:38 | corilynn | does anyone know how to connect to the database in the new docker development world? |
14:39 | Joubu | Thanks khall for merging the UNIMARC PR for the sandboxes! Did you apply it on the bywater sandboxes server yet? |
14:39 | khall | np! not yet, I can do that right now though |
14:40 | Joubu | corilynn: `docker exec -it koha_db_1 bash` on the host, that will open a shell on the db server |
14:40 | fridolin1 | Bug 20415 $nb_sysprefs-- |
14:40 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=20415 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Remove UseKohaPlugins system preference |
14:40 | Joubu | khall: as said in the commit message, I have not tested it. So I do not want to break something if you apply it in production :-/ |
14:41 | corilynn | right, i'm in the shell, Joubu, but then how to I login to mysql? |
14:41 | khall | no worries, I can revert if needed |
14:41 | corilynn | oh |
14:41 | didn't read right | |
14:43 | margaret joined #koha | |
14:43 | Joubu | sorry, I read it wrong. From the Koha container you can: `koha-mysql kohadev` |
14:43 | however if you need to access the mysql server as root, you will need to access it using the docker exec command I posted before | |
14:44 | koha-jenkins | Project Koha_Master_D8 build #765: STILL UNSTABLE in 41 min: https://jenkins.koha-community[…]ha_Master_D8/765/ |
14:46 | tcohen | you can access mysql as root using mysql -hdb -uroot -ppassword |
14:46 | koha-jenkins | Yippee, build fixed! |
14:46 | Project Koha_Master_D9_MDB_Latest build #191: FIXED in 48 min: https://jenkins.koha-community[…]9_MDB_Latest/191/ | |
14:47 | tcohen | #koha is anyone aware of a mime type for MARCBreaker format? ($record->as_formatted) other than 'text/plain'? |
14:49 | corilynn | next newbie docker question.. how do I set up my git creds? |
14:50 | Joubu | corilynn: .env |
14:50 | corilynn | you mean, before I set it up? or can I do that now? |
14:50 | Joubu | section setup in the readme |
14:50 | yes it's before the start the container | |
14:51 | you should not need to use git from inside the container btw | |
14:51 | corilynn | unfortunately, none of that stuff worked for my ubuntu setup, docker-container had to be manually created, docker is running as sudo |
14:51 | Joubu | if you really want it, use ~/.gitconfig |
14:52 | corilynn | " you should not need to use git from inside the container btw" ? Is there a "how to submit patches using the docker container" document I'm missing? |
14:53 | Joubu | to avoid the sudo stuff, add your user to the docker group |
14:53 | sudo usermod -aG docker ${USER} | |
14:53 | then restart docker | |
14:54 | corilynn: /kohadevbox/koha is a volume mounted from your host, you can access it from outside the container | |
14:54 | and so with your usual config | |
14:54 | corilynn | k |
14:54 | martin_renvoize joined #koha | |
14:54 | corilynn | but I did this stuff in kohadevbox before |
14:55 | martin_renvoize | Tetsing.. |
14:56 | Joubu | corilynn: `echo $SYNC_REPO` if you do not remember where it is |
14:56 | corilynn | I know where it is |
14:56 | just not used to working there | |
14:59 | lukeG joined #koha | |
15:02 | martin_renvoize | So, Convos seems to work. |
15:02 | fridolin1 left #koha | |
15:02 | ashimema | testing persistance |
15:06 | inlibro joined #koha | |
15:08 | corilynn | maybe I'm incapable of understand |
15:08 | ing | |
15:12 | so, I have a bug, and I want to make changes to that bug, and I want ALL THE CHANGES to be put in a SINGLE patch... what is the git foo for this? | |
15:13 | lets say, for the sake of argument that that bug is 24108... | |
15:13 | Joubu | all the changes you made locally? |
15:14 | corilynn | the problem is that I change one thing, and then all the other stuff isn't there anymore :( |
15:14 | i need a "update the patch that exists with my changes" command | |
15:14 | Joubu | you want your local changes to be added to the last commit? |
15:14 | corilynn | I *swear* I was doing this right before |
15:14 | yes | |
15:15 | Joubu | git commit --amend -a |
15:15 | amend will amend the last commit, -a will add all the changes from the tracked files | |
15:15 | martin_renvoize | Yes, what Joubu said |
15:15 | ashimema | interactive rebase + squash |
15:15 | corilynn | but then you have to ____ to push it to bugzilla |
15:16 | ashimema | oh.. no idea |
15:16 | corilynn | f, this should not be this hard |
15:16 | ashimema | what Joubu said |
15:17 | Joubu | I am not sure I understand corilynn. Do as usual: `git bz attach -e 24108 HEAD` to attach the last patch to 24108 |
15:18 | corilynn | right, and then the beautiful database update that i had in a previous submit is gone |
15:18 | unless the commit --amend -a thingy keeps that from happening?? | |
15:19 | Joubu | the atomicupdate file you mean? |
15:19 | if it was not tracked yet, then -a did not add it | |
15:19 | corilynn: what you should have done is: | |
15:19 | 1. git bz apply 24108 # apply existing patches | |
15:19 | 2. Modify your stuff | |
15:19 | 3. git add file list # | |
15:19 | 4. git commit --amend | |
15:20 | 3 and 4 could be `git commit -a --amend` | |
15:20 | now you have the last commit (HEAD) with all the changes you made + the original patch, time to attach it to bugz: git bz attach -e 24108 HEAD | |
15:24 | corilynn | ++++++Joubu! |
15:24 | I was missing step 4 | |
15:25 | I am adding this to my personal wiki | |
15:25 | Joubu++ | |
15:25 | why isn't it doing the karma thing? | |
15:27 | cait1 | wahanui is not here |
15:27 | and i forget asking rangi to check | |
15:27 | @later tell rangi can you bring wahanui back? | |
15:27 | huginn | cait1: The operation succeeded. |
15:28 | ashimema | cait1 |
15:28 | cait1 | hm? |
15:30 | corilynn | Joubu, worked magnificently! |
15:35 | JT joined #koha | |
15:36 | JT | Looks thoroughly modern to me |
15:36 | ashimema | welcome JT |
15:48 | khall joined #koha | |
15:49 | martin_renvoize joined #koha | |
15:51 | martin_renvoize joined #koha | |
15:51 | JT joined #koha | |
15:57 | oleonard joined #koha | |
15:57 | oleonard | Hi all |
16:04 | reiveune | bye |
16:04 | reiveune left #koha | |
16:06 | inlibro joined #koha | |
16:25 | khall joined #koha | |
16:39 | martin_renvoize joined #koha | |
16:40 | JT joined #koha | |
16:49 | khall_ joined #koha | |
17:00 | cait1 left #koha | |
17:06 | inlibro joined #koha | |
17:54 | khall joined #koha | |
18:05 | davidnind joined #koha | |
18:06 | inlibro joined #koha | |
18:39 | kathryn joined #koha | |
18:50 | corilynn | how do I use git to git a specific version of Koha? |
18:50 | I currently have master | |
18:53 | ? git checkout origin/19.11.x | |
19:00 | davidnind | corilynn: that is what I do in koha-testing-docker |
19:00 | corilynn | kewl |
19:00 | thanks | |
19:00 | kidclamp | then do a reset_all to get the right DB for that version |
19:01 | davidnind | using koha-testing-docker I normally just shut it down and then restart |
19:01 | corilynn: I'm testing bug 24108 - should the new system preference appear in the UI? | |
19:01 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=24108 enhancement, P5 - low, ---, carnold, Needs Signoff , Advanced Editor: Save .mrc save with a configurable value |
19:05 | rangi | will do cait |
19:06 | corilynn | davidnind, no |
19:06 | inlibro joined #koha | |
19:07 | wahanui joined #koha | |
19:10 | davidnind | corilynn: is there any reason you won't be able to set the system preference using the UI? |
19:10 | everything works as per the test plan so I will sign-off | |
19:10 | corilynn | maybe I misunderstand what you mean? |
19:12 | cait joined #koha | |
19:13 | corilynn | davidnind, I maybe don't understand how to get the syspref to show up in the UI? |
19:13 | davidnind | when you search for the new system preference 'SaveRecordbyControlNumber' under Koha administration => Global system preference |
19:13 | corilynn | right, so what magic is required to get it to go there? |
19:14 | davidnind | I don't know either, so one for others to answer, normally you would expect it to appear, rather than having to manually run an SQL query |
19:14 | corilynn | Joubu was talking about a completely different UI ... so I was thrown |
19:15 | kidclamp, do you know? | |
19:15 | wahanui | kidclamp, are the bywater sandboxes punking me? |
19:15 | corilynn | nice one, wahanui |
19:15 | wahanui | corilynn: i'm not following you... |
19:16 | kidclamp | so I think Joubu was suggesting you make it part of the rancor ui |
19:16 | davidnind | You probably have to update the syspref file ==> https://wiki.koha-community.or[…]ystem_Preferences |
19:16 | kidclamp | otherwise you need to add it to the correct .pref file |
19:16 | corilynn | yeah, I don't want to add it to the UI, don't want to add clicks |
19:16 | kidclamp | ls -l /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/ |
19:17 | the file determine which section of prefs it falls under | |
19:17 | just follow the format of others in file to see how to add | |
19:17 | corilynn | kewl |
19:25 | davidnind | corilynn: here is my koha-testing-docker cheat sheet if it is of any use https://gitlab.com/snippets/1893788 |
19:27 | khall joined #koha | |
19:27 | corilynn | nice, one thing I found last night was that you can't use docker-compose that's installed by default, have to update it from: https://docs.docker.com/compose/install/ |
19:30 | davidnind | I installed koha-testing-docker a while ago, so I'm sure that is what I must have done! (I hadn't had docker installed before on Ubuntu 18.04, so didn't use the default packaged version available) |
19:34 | davidnind left #koha | |
19:41 | corilynn | I don't know who's in charge of koha-testing-docker, but maybe we should add the version requirement? |
19:41 | alexbuckley joined #koha | |
19:41 | cait | i thnk you could add an issue on gitlab for it |
19:42 | corilynn | davidnind, the release has been updated with changes to cataloguing.pref added and directions updated |
19:42 | I'm on it, cait! | |
19:42 | cait | :) |
19:49 | edveal joined #koha | |
19:51 | corilynn | documented my two big issues, cait |
19:54 | cait | corilynn++ |
19:54 | corilynn | Joubu++ |
19:54 | kidclamp++ | |
20:00 | hayley joined #koha | |
20:07 | inlibro joined #koha | |
20:11 | nugged | mates, we need sign-off+critics on https://bugs.koha-community.or[…]_bug.cgi?id=24185 – "If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items" – we added same changes to KohaSuomi version in parallel on our risk because it was a blocker (slow!) and succeeded, yet it doesn't means that nothing to improve (but better it pass phew :) ) – please, can anyone join this and signoff? |
20:11 | huginn | Bug 24185: normal, P5 - low, ---, nugged, Needs Signoff , 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items |
20:22 | tcohen | hola nugged |
20:22 | nice | |
20:24 | nugged have you considered using the API for paginated rendering? I know you work on an older stable branch for production... yet... | |
20:24 | nice improvement anyways | |
20:24 | :-D | |
20:25 | khall joined #koha | |
20:30 | aleisha joined #koha | |
20:36 | andreashm joined #koha | |
20:45 | andreashm joined #koha | |
20:50 | tosca joined #koha | |
21:01 | nugged | if I would have some time-compressing-machine or a team I would rewrite all to API and SPA the whole, but... it is as it is :), ... yes, strong point and idea for Ajax+API to have pagination, I also proposed to have pagination even in old plain web style, but it wasn't the first priority. I will discuss this again though, yet for current state – |
21:03 | those changes speeded up our KohaSuomi a lot, so we would like to have synced by fixes with KC as well so that's why asking for Signoff, and yes, nice to meet you all here with my such appearance with some fixes which helps for our Koha! <3 | |
21:05 | cait | nice to see you around :) |
21:05 | we have planned a virtual hackfest nex tweek | |
21:05 | might be a good time to move this forward | |
21:07 | inlibro joined #koha | |
21:22 | khall joined #koha | |
22:07 | inlibro joined #koha | |
22:12 | matts_ joined #koha | |
22:45 | edveal joined #koha | |
22:48 | khall joined #koha | |
23:07 | inlibro joined #koha | |
23:36 | edveal joined #koha | |
23:49 | cait joined #koha |
← Previous day | Today | Next day → | Search | Index