← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:04 | Margaret joined #koha | |
| 00:12 | Margaret joined #koha | |
| 00:27 | inlibro joined #koha | |
| 00:59 | hayleymapley_ joined #koha | |
| 01:20 | hayleymapley__ joined #koha | |
| 01:22 | wizzyrea joined #koha | |
| 01:27 | inlibro joined #koha | |
| 02:27 | inlibro joined #koha | |
| 03:27 | inlibro joined #koha | |
| 04:28 | inlibro joined #koha | |
| 05:28 | inlibro joined #koha | |
| 06:04 | chriss joined #koha | |
| 06:15 | fridolin joined #koha | |
| 06:19 | fridolin | hi there |
| 06:19 | i start my coming back ;) | |
| 06:19 | * fridolin | actually at Madagascar with Orange 4G internet |
| 06:20 | fridolin | works very well |
| 06:28 | inlibro joined #koha | |
| 06:50 | enkidu joined #koha | |
| 06:58 | davidnind joined #koha | |
| 06:59 | ere_away_ joined #koha | |
| 07:04 | cait joined #koha | |
| 07:20 | did joined #koha | |
| 07:21 | lavamind joined #koha | |
| 07:28 | inlibro joined #koha | |
| 07:38 | reiveune joined #koha | |
| 07:39 | reiveune | hello |
| 07:39 | magnuse | bonjour reiveune et #koha |
| 07:43 | ere_away joined #koha | |
| 07:48 | fridolin joined #koha | |
| 08:20 | greenjimll joined #koha | |
| 08:25 | cait joined #koha | |
| 08:28 | inlibro joined #koha | |
| 08:47 | Dirar joined #koha | |
| 08:51 | kohaputti | Joubu, great job fixing the circulation rule perf issue! :) |
| 08:53 | Joubu | thanks kohaputti |
| 08:54 | andreashm joined #koha | |
| 08:54 | andreashm joined #koha | |
| 08:55 | Dirar_ joined #koha | |
| 08:55 | andreashm joined #koha | |
| 08:59 | ashimema[m] | wow we're inconsistent with from addresses for emails :( |
| 09:00 | andreashm joined #koha | |
| 09:00 | ashimema[m] | hi fridolin.. hope all is going well for you :) |
| 09:03 | andreashm joined #koha | |
| 09:03 | fridolin | ashimema[m]: yes it is, 2 children is a lot of fun but also a lot of work ;) |
| 09:09 | ashimema[m] | haha.. tell me about it mate ;) |
| 09:10 | davidnind | fridolin++ |
| 09:10 | cait | fridolin++ :) |
| 09:11 | ashimema[m]: after we fundet work it was supposed to be consistent... apart from emails that go to the library | |
| 09:12 | * ashimema[m] | sort of wants to take out the ability to add from_address at the EnqueueLetter stage.. |
| 09:13 | ashimema[m] | then use one and only one piece of code to do the fallback through branchemail, kohaadminemail that happens so often |
| 09:13 | right now it's easy to introduce issues | |
| 09:16 | cait | we could have a variable branch or global instead |
| 09:16 | some emails cannot be sent from a branh | |
| 09:16 | I am more worried ab ut the emails sent to the library | |
| 09:17 | i have to patch them all to reply-to-address | |
| 09:17 | as they sent to branchemail... which is a noreply one in our setting | |
| 09:17 | HOLDPLACED for example | |
| 09:19 | but maybe we shoud not start yet another clean-up project now :) | |
| 09:23 | ashimema[m] | see bug 22823 and bug 22821 cait |
| 09:23 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=22823 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Koha::Library needs a method for obtaining the incoming email address |
| 09:23 | Bug http://bugs.koha-community.org[…]_bug.cgi?id=22821 normal, P5 - low, ---, martin.renvoize, NEW , Patron notes about item email notification fallback order is incorrect | |
| 09:24 | cait | so it's too late already? ;) |
| 09:25 | ashimema[m] | I think we can start.. so long as it's baby steps ;) |
| 09:25 | I'm working on the second bug at the moment | |
| 09:25 | not entirely sure what you mean by you ahve a patch for reply-to... | |
| 09:26 | eythian | hi |
| 09:26 | sophie_m joined #koha | |
| 09:26 | cait | ashimema[m]: there are emails to the branh library address (branchemail) that won't work for us |
| 09:26 | ashimema[m] | have you reported more similar bugs to the above two.. I've not found them but would be happy to help move them along if you wanted to build a bit of a tree to help me keep track of them all |
| 09:26 | cait | branchemail in our setup is a noreply, and replyto is the actual address of the library |
| 09:26 | ashimema[m] | morning eythian |
| 09:27 | cait | because of the whole 'email must be in the domain of mailserver thing' |
| 09:27 | ashimema[m] | yeah.. I'm trying to catch those cait.. |
| 09:27 | but I only found two cases so far... | |
| 09:27 | bug 22823 introduced a method in Koha::Library to do the right thing. | |
| 09:27 | cait | holeplaced and overdues for patrons with no emails come to mind |
| 09:27 | ashimema[m] | I know exactly what you mean.. I just need help finding all the cases ;) |
| 09:27 | cait | checking my branch |
| 09:27 | but it's 18.11 so misisng new ones maybe | |
| 09:27 | there is a new one for suggestions to be sent to the library i think | |
| 09:27 | ashimema[m] | all good.. |
| 09:28 | I'll just grep through 'from_address' and 'to_address' | |
| 09:28 | those are the culprits | |
| 09:28 | cait | yep |
| 09:28 | inlibro joined #koha | |
| 09:34 | fridolin left #koha | |
| 09:38 | ashimema[m] | The simplest approach i thought about was to simply never use the passed from_address as the from_address.. rather using as the reply_to address instead.. and let the branch handling code that already exists pull the from_address |
| 09:39 | but then I looked at how after from_address is passed as that route scared me.. | |
| 09:40 | so I decided to add a reply_address into the message_queue table and we can work through one place at a time moving to using that field instead and then finally deprecate and remove passing in from_address directly. | |
| 09:40 | sound like a plan cait? | |
| 09:42 | cait | hm |
| 09:43 | not sure my brain is up to it right now, deep into migrations things | |
| 09:43 | are we differentiating between libraries to patrons/external people and to the library there? | |
| 09:43 | ashimema[m] | no worries |
| 09:43 | I'll forge ahead | |
| 09:43 | cait | also - don't we need both in the emails? |
| 09:43 | and both could be set differently | |
| 09:43 | well they usually are if reply to is in use | |
| 09:44 | ashimema[m] | that's why I decided to add the reply_address field ;) |
| 09:45 | and work at it from that direction.. then once we're knee deep in the work we can make a more informed decision as to whether we actually need to ever pass in from_address or not ;) | |
| 09:45 | my biggest complaint is we currenty sometimes pass in patron email address as the from_address.. | |
| 09:45 | that's never going to work.. pretending to be a patron sending mails.. | |
| 09:49 | Joubu | mtj[m]: are you around? |
| 09:52 | cait | ashimema[m]: it used to work... will stell with more permissive mail servers |
| 09:52 | but yeah, it gets increasingly difficult and you will probably not now why it didn't work or not notice | |
| 09:53 | davidnind left #koha | |
| 09:53 | ashimema[m] | It's just plain bad practice to mascarade as someone else in my opinion |
| 09:53 | especially peoples personal addresses. | |
| 09:53 | Joubu | @later tell mtj we have something weird happening on Docker_1 and Docker_3, a new test xt/find-license-problems is failing on a "./core" file that is at the root of the Koha src (but not in our git repo). Any ideas where does it come from? |
| 09:53 | huginn | Joubu: The operation succeeded. |
| 09:58 | sophie_m joined #koha | |
| 10:01 | cait | hm does someone know if the 'don't show lost items in OPAC' feature uses Zebra is is moe similar to opachiddenitems? |
| 10:01 | tying to determin if it leaves holes in the result list or not | |
| 10:01 | hidelostitems | |
| 10:03 | Dirar_ joined #koha | |
| 10:04 | khall joined #koha | |
| 10:21 | koha-jenkins | Project Koha_Master_D9 build #1169: ABORTED in 4 min 37 sec: https://jenkins.koha-community[…]a_Master_D9/1169/ |
| 10:29 | inlibro joined #koha | |
| 10:32 | Dirar_ joined #koha | |
| 10:33 | vfernandes joined #koha | |
| 10:34 | koha-jenkins | Project Koha_Master_D9 build #1170: ABORTED in 13 min: https://jenkins.koha-community[…]a_Master_D9/1170/ |
| 10:43 | Project Koha_Master_D9 build #1171: ABORTED in 8 min 23 sec: https://jenkins.koha-community[…]a_Master_D9/1171/ | |
| 10:45 | mtj | hi Joubu, i think the core file comes from a crashed ./perl |
| 10:46 | Joubu | mtj: what is its content? |
| 10:47 | The next question is: can you remove it? :) | |
| 10:47 | mtj | ..the build needs to run a 'git clean -f' before it starts, it remove any files from the previous job |
| 10:47 | Joubu | we could indeed do that |
| 10:48 | mtj | i experimented here.. it seems to work ok.. |
| 10:48 | https://jenkins.koha-community[…]r_D9/1172/console | |
| 10:48 | ashimema[m] | teamwork++ |
| 10:48 | mtj | 00:00:02.757 + git clean -f |
| 10:48 | 00:00:02.838 Removing 1.png | |
| 10:48 | 00:00:02.838 Removing core | |
| 10:48 | 00:00:02.838 Removing docker-compose.mariadb_latest.yml | |
| 10:51 | Joubu | mtj: D9 was passing prior to your change I think :) |
| 10:51 | well, failing, but not on this test | |
| 10:51 | mtj: could you add it to all master jobs? | |
| 10:52 | Or I can do it, if you want me to | |
| 10:52 | mtj | np, i can do |
| 10:52 | kohaputti_ joined #koha | |
| 10:53 | mtj | ...'file ./core' seemed to think it was a perl executable, (i deleted the file already :/ ) |
| 10:58 | ere_ joined #koha | |
| 10:59 | fridolin joined #koha | |
| 11:01 | ere__ joined #koha | |
| 11:06 | * ashimema[m] | hopes cait will find the time to test the set of trivials I'm adding for her at the moment regards emails |
| 11:06 | sophie_m joined #koha | |
| 11:08 | huginn | News from kohagit: Bug 23777: (follow-up) Use To.json in results.tt <http://git.koha-community.org/[…]d21fd234dddf298b0> |
| 11:11 | andreashm joined #koha | |
| 11:29 | inlibro joined #koha | |
| 11:32 | koha-jenkins | Yippee, build fixed! |
| 11:32 | Project Koha_Master_D8 build #713: FIXED in 27 min: https://jenkins.koha-community[…]ha_Master_D8/713/ | |
| 11:34 | andreashm joined #koha | |
| 11:34 | koha-jenkins | Yippee, build fixed! |
| 11:34 | Project Koha_Master_D9 build #1172: FIXED in 51 min: https://jenkins.koha-community[…]a_Master_D9/1172/ | |
| 11:49 | khall joined #koha | |
| 11:54 | koha-jenkins | Project Koha_Master_D9_MDB_Latest build #149: SUCCESS in 46 min: https://jenkins.koha-community[…]9_MDB_Latest/149/ |
| 12:01 | andreashm joined #koha | |
| 12:07 | ere joined #koha | |
| 12:09 | koha-jenkins | Project Koha_Master_U18 build #636: STILL UNSTABLE in 37 min: https://jenkins.koha-community[…]a_Master_U18/636/ |
| 12:24 | oleonard joined #koha | |
| 12:24 | oleonard | Hi #koha |
| 12:28 | koha-jenkins | Project Koha_Master_D8 build #714: UNSTABLE in 34 min: https://jenkins.koha-community[…]ha_Master_D8/714/ |
| 12:29 | inlibro joined #koha | |
| 12:30 | koha-jenkins | Yippee, build fixed! |
| 12:30 | Project Koha_Master_D9_My8 build #173: FIXED in 56 min: https://jenkins.koha-community[…]aster_D9_My8/173/ | |
| 12:32 | oleonard | Oh dang, Bug 22880 was pushed while I was out for a day! |
| 12:32 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=22880 enhancement, P5 - low, ---, oleonard, Pushed to master , Convert opacheader system preference to news block |
| 12:32 | * oleonard | should take more days off |
| 12:32 | khall joined #koha | |
| 12:37 | andreashm joined #koha | |
| 12:44 | koha-jenkins | Project Koha_Master_D9 build #1173: SUCCESS in 34 min: https://jenkins.koha-community[…]a_Master_D9/1173/ |
| 12:47 | andreashm joined #koha | |
| 13:16 | sophie_m joined #koha | |
| 13:21 | magnuse | anyone else seen Koha misbehave because of this unicode char in field 009? "U+001F : <control-001F> (INFORMATION SEPARATOR ONE) {unit separator (US)}" |
| 13:27 | ere | magnuse: That's the field start character in ISO2709, so I wouldn't be surprised if it caused trouble. |
| 13:28 | or "delimiter" in https://www.loc.gov/marc/speci[…]specrecstruc.html | |
| 13:29 | khall joined #koha | |
| 13:29 | inlibro joined #koha | |
| 13:30 | ashimema[m] | grr.. |
| 13:30 | soooo many places pass from_address needlessly :( | |
| 13:31 | bug 22823 | |
| 13:31 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=22823 enhancement, P5 - low, ---, martin.renvoize, Needs Signoff , Koha::Library needs a method for obtaining the inbound email address |
| 13:41 | andreashm joined #koha | |
| 13:42 | kidclamp joined #koha | |
| 13:45 | huginn | News from kohagit: Bug 22522: Fix several REST API tests <http://git.koha-community.org/[…]9ff277b699668a56d> |
| 13:45 | News from kohagit: Bug 22522: Fix route typo <http://git.koha-community.org/[…]f5272db6b707ad7ea> | |
| 13:45 | News from kohagit: Bug 22522: Add support for current Mojolicious and related packages <http://git.koha-community.org/[…]66e1d299bcd92fb45> | |
| 13:45 | News from kohagit: Bug 23290: (QA follow-up) Rename option to expand_entities_unsafe <http://git.koha-community.org/[…]b326566248367881f> | |
| 13:45 | News from kohagit: Bug 23290: (follow-up) Disable expand_entities unless explicitly enabled <http://git.koha-community.org/[…]3d1c1c52ec6d79a90> | |
| 13:45 | News from kohagit: Bug 23290: (follow-up) Replace warning_like by warnings_like <http://git.koha-community.org/[…]70f253509af29c7af> | |
| 13:45 | News from kohagit: Bug 23290: Add test for write_net <http://git.koha-community.org/[…]bfb02f9d538e4319f> | |
| 13:45 | News from kohagit: Bug 23290: Add test Koha/XSLT/Security.t <http://git.koha-community.org/[…]1d56fcf36509127e5> | |
| 13:45 | News from kohagit: Bug 23290: Allow enabling expand_entities <http://git.koha-community.org/[…]066392ee1bf2432cf> | |
| 13:45 | News from kohagit: Bug 23290: Apply the changes in Security to Base now <http://git.koha-community.org/[…]e5762165b358a26b9> | |
| 13:45 | News from kohagit: Bug 23290: Introduce Koha::XSLT::Security <http://git.koha-community.org/[…]b74571a4c04641bbf> | |
| 13:45 | News from kohagit: Bug 23290: Rename XSLT_Handler <http://git.koha-community.org/[…]0fdc22f4db636ae50> | |
| 13:45 | News from kohagit: Bug 23290: XSLT system preferences allow administrators to exploit XML and XSLT vulne... <http://git.koha-community.org/[…]d7e8157d1aa12910d> | |
| 13:51 | khall joined #koha | |
| 13:52 | koha-jenkins | Yippee, build fixed! |
| 13:52 | Project Koha_Master_D8 build #715: FIXED in 39 min: https://jenkins.koha-community[…]ha_Master_D8/715/ | |
| 13:54 | andreashm joined #koha | |
| 13:54 | Dyrcona joined #koha | |
| 14:10 | fridolin joined #koha | |
| 14:19 | andreashm joined #koha | |
| 14:23 | koha-jenkins | Project Koha_Master_D9_MDB_Latest build #150: UNSTABLE in 34 min: https://jenkins.koha-community[…]9_MDB_Latest/150/ |
| 14:29 | inlibro joined #koha | |
| 14:35 | koha-jenkins | Project Koha_Master_D9_My8 build #174: UNSTABLE in 48 min: https://jenkins.koha-community[…]aster_D9_My8/174/ |
| 14:37 | huginn | News from kohagit: Bug 23290: (RM follow-up) Correction to copyright statement <http://git.koha-community.org/[…]20ba24bd6b7b6d9a8> |
| 14:37 | News from kohagit: Bug 24661: (RM follow-up) Check lang is defined <http://git.koha-community.org/[…]f31f5bd89740e1589> | |
| 14:44 | koha-jenkins | Project Koha_Master_D9 build #1174: UNSTABLE in 52 min: https://jenkins.koha-community[…]a_Master_D9/1174/ |
| 14:51 | cait | marcelr++ thx |
| 15:00 | koha-jenkins | Project Koha_Master_U18 build #637: STILL UNSTABLE in 36 min: https://jenkins.koha-community[…]a_Master_U18/637/ |
| 15:08 | Project Koha_Master_D8 build #716: UNSTABLE in 32 min: https://jenkins.koha-community[…]ha_Master_D8/716/ | |
| 15:11 | fridolin left #koha | |
| 15:15 | ashimema[m] | @later tell mtj just spotted that D10 only builds on your node.. is that right? |
| 15:15 | huginn | ashimema[m]: The operation succeeded. |
| 15:29 | inlibro joined #koha | |
| 15:30 | Margaret joined #koha | |
| 15:31 | paul_p joined #koha | |
| 15:34 | koha-jenkins | Yippee, build fixed! |
| 15:34 | Project Koha_Master_D9_MDB_Latest build #151: FIXED in 34 min: https://jenkins.koha-community[…]9_MDB_Latest/151/ | |
| 15:36 | bdonnahue joined #koha | |
| 15:38 | koha-jenkins | Yippee, build fixed! |
| 15:39 | Project Koha_Master_D9_My8 build #175: FIXED in 54 min: https://jenkins.koha-community[…]aster_D9_My8/175/ | |
| 15:40 | Project Koha_Master_D10 build #93: STILL FAILING in 5 min 58 sec: https://jenkins.koha-community[…]ha_Master_D10/93/ | |
| 15:54 | Project Koha_Master_D9 build #1175: STILL UNSTABLE in 46 min: https://jenkins.koha-community[…]a_Master_D9/1175/ | |
| 15:59 | enkidu joined #koha | |
| 16:02 | reiveune | bye |
| 16:02 | reiveune left #koha | |
| 16:05 | bdonnahue joined #koha | |
| 16:07 | koha-jenkins | Yippee, build fixed! |
| 16:07 | Project Koha_Master_D8 build #717: FIXED in 27 min: https://jenkins.koha-community[…]ha_Master_D8/717/ | |
| 16:30 | inlibro joined #koha | |
| 16:34 | koha-jenkins | Yippee, build fixed! |
| 16:34 | Project Koha_Master_U18 build #638: FIXED in 55 min: https://jenkins.koha-community[…]a_Master_U18/638/ | |
| 16:47 | lisettelatah joined #koha | |
| 16:49 | koha-jenkins | Project Koha_Master_D10 build #94: STILL FAILING in 7 min 28 sec: https://jenkins.koha-community[…]ha_Master_D10/94/ |
| 16:58 | ashimema[m] | mtj around? |
| 17:00 | bdonnahue joined #koha | |
| 17:07 | oleonard joined #koha | |
| 17:08 | oleonard | Hello I am back |
| 17:10 | oleonard joined #koha | |
| 17:10 | oleonard | And then my chat client crashed |
| 17:16 | koha-jenkins | Project Koha_Master_D9 build #1176: STILL UNSTABLE in 34 min: https://jenkins.koha-community[…]a_Master_D9/1176/ |
| 17:17 | cait left #koha | |
| 17:30 | inlibro joined #koha | |
| 17:54 | koha-jenkins | Project Koha_Master_D10 build #95: NOW UNSTABLE in 33 min: https://jenkins.koha-community[…]ha_Master_D10/95/ |
| 18:00 | ashimema[m] | Woop, woop... We have lift off for D10! |
| 18:09 | koha-jenkins | Project Koha_Master_D9 build #1177: STILL UNSTABLE in 48 min: https://jenkins.koha-community[…]a_Master_D9/1177/ |
| 18:11 | cait joined #koha | |
| 18:20 | oleonard | anyone seen this error from the QA tool before? Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. |
| 18:24 | lisettelatah joined #koha | |
| 18:25 | wizzyrea joined #koha | |
| 18:30 | inlibro joined #koha | |
| 18:42 | ashimema[m] | New one on me |
| 18:48 | enkidu joined #koha | |
| 18:50 | oleonard | Bug 24713 |
| 18:50 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=24713 major, P3, ---, oleonard, Needs Signoff , JavaScript error on staff client catalog search results page |
| 18:51 | enkidu joined #koha | |
| 18:53 | enkidu joined #koha | |
| 18:58 | kidclamp | how do I recreate it Owen? |
| 18:59 | oleonard: | |
| 18:59 | oleonard | The bug, or the QA tool error kidclamp? |
| 18:59 | kidclamp | the bug first |
| 19:00 | oleonard | I believe all you need is to have AmazonCoverImages turned off |
| 19:01 | kathryn joined #koha | |
| 19:04 | kidclamp | I do not recreate |
| 19:05 | lisettelatah joined #koha | |
| 19:05 | kidclamp | ah, got it no |
| 19:05 | w | |
| 19:30 | inlibro joined #koha | |
| 19:36 | hayley joined #koha | |
| 20:02 | sophie_m joined #koha | |
| 20:03 | alexbuckley joined #koha | |
| 20:23 | kathryn joined #koha | |
| 20:26 | enkidu joined #koha | |
| 20:30 | khall joined #koha | |
| 20:30 | inlibro joined #koha | |
| 20:35 | bdonnahue joined #koha | |
| 20:38 | tosca joined #koha | |
| 21:02 | bdonnahue joined #koha | |
| 21:23 | khall joined #koha | |
| 21:27 | sonOfRa joined #koha | |
| 21:30 | inlibro joined #koha | |
| 22:01 | irma_ joined #koha | |
| 22:31 | inlibro joined #koha | |
| 22:43 | hayley joined #koha | |
| 22:49 | khall joined #koha | |
| 23:02 | kathryn joined #koha | |
| 23:26 | lisettelatah joined #koha | |
| 23:29 | khall joined #koha | |
| 23:31 | inlibro joined #koha | |
| 23:36 | gveranis joined #koha | |
| 23:58 | lisettelatah joined #koha |
← Previous day | Today | Next day → | Search | Index