← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:06 | inlibro joined #koha | |
| 00:27 | andreashm joined #koha | |
| 00:50 | koha-jenkins | Project Koha_18.11_D9 build #256: SUCCESS in 26 min: https://jenkins.koha-community[…]oha_18.11_D9/256/ |
| 00:56 | Project Koha_18.11_D8 build #255: SUCCESS in 31 min: https://jenkins.koha-community[…]oha_18.11_D8/255/ | |
| 01:00 | Project Koha_18.11_U18 build #245: SUCCESS in 34 min: https://jenkins.koha-community[…]ha_18.11_U18/245/ | |
| 01:06 | inlibro joined #koha | |
| 01:21 | JBoyer joined #koha | |
| 01:24 | JBoyer joined #koha | |
| 01:55 | lukeG joined #koha | |
| 02:06 | inlibro joined #koha | |
| 02:09 | koha-jenkins | Project Koha_18.11_D9 build #257: SUCCESS in 25 min: https://jenkins.koha-community[…]oha_18.11_D9/257/ |
| 02:15 | Project Koha_18.11_D8 build #256: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_18.11_D8/256/ | |
| 02:21 | Project Koha_18.11_U18 build #246: SUCCESS in 34 min: https://jenkins.koha-community[…]ha_18.11_U18/246/ | |
| 03:06 | inlibro joined #koha | |
| 03:20 | koha-jenkins | Project Koha_18.11_D9 build #258: SUCCESS in 26 min: https://jenkins.koha-community[…]oha_18.11_D9/258/ |
| 03:25 | Project Koha_18.11_D8 build #257: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_18.11_D8/257/ | |
| 03:31 | Project Koha_18.11_U18 build #247: SUCCESS in 35 min: https://jenkins.koha-community[…]ha_18.11_U18/247/ | |
| 04:07 | inlibro joined #koha | |
| 04:13 | koha-jenkins | Project Koha_18.11_U18 build #248: SUCCESS in 27 min: https://jenkins.koha-community[…]ha_18.11_U18/248/ |
| 04:15 | Project Koha_18.11_D8 build #258: SUCCESS in 30 min: https://jenkins.koha-community[…]oha_18.11_D8/258/ | |
| 04:23 | Project Koha_18.11_D9 build #259: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_18.11_D9/259/ | |
| 05:07 | inlibro joined #koha | |
| 06:06 | chriss joined #koha | |
| 06:07 | inlibro joined #koha | |
| 06:45 | cait joined #koha | |
| 07:07 | inlibro joined #koha | |
| 07:26 | paxed | 'Record hold, Item con be transferred' hah |
| 07:27 | marcelr joined #koha | |
| 07:27 | marcelr | hi #koha |
| 07:32 | ashimema[m] | Morning #koha |
| 07:35 | marcelr | o/ |
| 07:36 | reiveune joined #koha | |
| 07:37 | reiveune | hello |
| 07:43 | cait | morning all |
| 07:43 | and bbl :) | |
| 07:47 | did joined #koha | |
| 08:06 | andreashm joined #koha | |
| 08:07 | inlibro joined #koha | |
| 08:09 | alex_a joined #koha | |
| 08:18 | cait joined #koha | |
| 08:20 | ashimema[m] | grr.. a different test is failing on each of OS on Jenkins! |
| 08:20 | and... | |
| 08:21 | I can't replicate a single one of the failures! | |
| 08:21 | cait | ouch |
| 08:21 | today is carneval here... maybe it's related | |
| 08:22 | ashimema[m] | klol |
| 08:22 | we have lots of pretty random failures at the moment | |
| 08:22 | I think in most cases their test code related and not core code.. | |
| 08:22 | which is even more tedious | |
| 08:26 | cait | I saw: A penguin, a witch, 2 clowns, a mermaid and a "green thing" on my way to work |
| 08:26 | marcelr | how did you look? |
| 08:27 | andreashm joined #koha | |
| 08:27 | cait | I am wearing antlers... it's the only thing I had, usually used at christmas |
| 08:28 | marcelr | gewei ? |
| 08:28 | cait | geweih - yep |
| 08:28 | marcelr | keep learning here ';) |
| 08:29 | cait | with little bells... so people will be warned today :) |
| 08:30 | marcelr | be careful with movements |
| 08:33 | magnuse | no headbanging! |
| 08:36 | andreashm joined #koha | |
| 08:45 | alex_a_ joined #koha | |
| 08:46 | Joubu | ashimema[m]: bug 24229 for the U18 one |
| 08:46 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=24229 normal, P5 - low, ---, tomascohen, NEW , /items API tests fail on Ubuntu 18.04 |
| 08:47 | ashimema[m] | it's weird and annoying ain't it. |
| 08:47 | huginn | News from kohagit: Bug 24532: DBRev 19.12.00.027 <http://git.koha-community.org/[…]6430d187b0e9f08b7> |
| 08:47 | News from kohagit: Bug 24670: (QA follow-up) Add missing $rules definition <http://git.koha-community.org/[…]934288b0cef5bf175> | |
| 08:47 | News from kohagit: Bug 24538: Handle Net::Netmask parser errors <http://git.koha-community.org/[…]fd45eae354b1285ba> | |
| 08:47 | News from kohagit: Bug 24538: Add unit tests for Koha::Middleware::RealIP <http://git.koha-community.org/[…]60735944503434daa> | |
| 08:47 | News from kohagit: Bug 24670: Fetch all circulation rules at once to fix perf regression <http://git.koha-community.org/[…]3967872159121cfcc> | |
| 08:47 | News from kohagit: Bug 24532: Fix misidentified credit_types from bug 23049 <http://git.koha-community.org/[…]7dbf8d20224c7214a> | |
| 08:47 | News from kohagit: Bug 24532: Fix original DB update for bug 23049 <http://git.koha-community.org/[…]5c5695eaf07fec9f6> | |
| 08:47 | News from kohagit: Bug 17611: Change 'Pending order' to 'Quantity ordered' <http://git.koha-community.org/[…]5f7c8b55a2c77ded0> | |
| 08:47 | ashimema[m] | seems to be becoming more frequent in Jenkins |
| 08:47 | Joubu | ashimema[m]: for the pickup location one: bug 24657 |
| 08:47 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=24657 enhancement, P5 - low, ---, agustinmoyano, Signed Off , Fix tests of bug 22284 - Groups of pickup locations for holds |
| 08:47 | Joubu | the Circulation.t one is weird |
| 08:49 | ashimema[m] | are you happy with 24657.. looks like it's ready to go to me from the comments |
| 08:49 | cait | bug 24657 |
| 08:50 | Joubu | ashimema[m]: I signed it off |
| 08:51 | ashimema[m] | yeah |
| 08:56 | koha-jenkins | Yippee, build fixed! |
| 08:56 | Project Koha_Master_D9 build #1154: FIXED in 34 min: https://jenkins.koha-community[…]a_Master_D9/1154/ | |
| 09:00 | Project Koha_Master_D8 build #701: STILL UNSTABLE in 38 min: https://jenkins.koha-community[…]ha_Master_D8/701/ | |
| 09:02 | andreashm joined #koha | |
| 09:07 | inlibro joined #koha | |
| 09:08 | koha-jenkins | Yippee, build fixed! |
| 09:08 | Project Koha_Master_U18 build #624: FIXED in 46 min: https://jenkins.koha-community[…]a_Master_U18/624/ | |
| 09:13 | huginn | News from kohagit: Bug 14567: DBRev 19.12.00.028 <http://git.koha-community.org/[…]6d1fb8e42094d2b4d> |
| 09:13 | News from kohagit: Bug 14567: Compiled CSS <http://git.koha-community.org/[…]2563d52ec8a8f4deb> | |
| 09:13 | News from kohagit: Bug 14647: Make spelling in file format pull downs match <http://git.koha-community.org/[…]b64db5b25a98251b6> | |
| 09:13 | News from kohagit: Bug 24657: Do not explicitely pass a branchcode <http://git.koha-community.org/[…]ff70c2101e8cf9cb8> | |
| 09:13 | News from kohagit: Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t <http://git.koha-community.org/[…]66709eaa73946e6fb> | |
| 09:13 | News from kohagit: Bug 14647: (follow-up) Fix script not detecting XML output format <http://git.koha-community.org/[…]fd5d395b868a4cf4a> | |
| 09:13 | News from kohagit: Bug 14898: Add button at manual invoice to redirect to pay tab <http://git.koha-community.org/[…]08d74013de2b48196> | |
| 09:13 | News from kohagit: Bug 14647: (follow-up) Changes to script <http://git.koha-community.org/[…]1bacc1777422a89da> | |
| 09:13 | News from kohagit: Bug 14647: Make the file name extension dynamic on exporting records <http://git.koha-community.org/[…]74057fbff5b60c48c> | |
| 09:13 | News from kohagit: Bug 14567: Add a browse interface to the OPAC <http://git.koha-community.org/[…]005f15877ca40d16f> | |
| 09:20 | alex_a joined #koha | |
| 09:22 | alex_a joined #koha | |
| 09:23 | alex_a joined #koha | |
| 09:32 | koha-jenkins | Project Koha_Master_D9_My8 build #163: SUCCESS in 36 min: https://jenkins.koha-community[…]aster_D9_My8/163/ |
| 09:35 | alex_a joined #koha | |
| 09:41 | cait | jajm: happy to see you so active on bugzilla - interesting stuff too |
| 09:41 | ashimema[m] | jajm++ |
| 09:42 | cait | jajm++ |
| 09:42 | * ashimema[m] | has noticed too |
| 09:42 | jajm | cait, i'm happy to be active again ;) |
| 09:42 | cait | :) |
| 09:44 | paxed | anyone want to signoff bug 24695? should be pretty easy |
| 09:44 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=24695 enhancement, P5 - low, ---, pasi.kallinen, Needs Signoff , Improve SQL report validation |
| 09:46 | paul_p joined #koha | |
| 09:52 | koha-jenkins | Yippee, build fixed! |
| 09:52 | Project Koha_Master_D9_MDB_Latest build #138: FIXED in 52 min: https://jenkins.koha-community[…]9_MDB_Latest/138/ | |
| 09:54 | Project Koha_Master_D9 build #1155: SUCCESS in 45 min: https://jenkins.koha-community[…]a_Master_D9/1155/ | |
| 10:00 | ashimema[m] | do you predict you'll be around for a while jajm.. or is it more likely to be a fleeting week or two? |
| 10:00 | koha-jenkins | Yippee, build fixed! |
| 10:00 | Project Koha_Master_D8 build #702: FIXED in 27 min: https://jenkins.koha-community[…]ha_Master_D8/702/ | |
| 10:01 | paul_p joined #koha | |
| 10:04 | jajm | ashimema[m], i think i will be pretty busy on other things in the next few months, but i may have time also on koha related things, i don't know really :/ |
| 10:05 | andreashm joined #koha | |
| 10:05 | vfernandes joined #koha | |
| 10:06 | ashimema[m] | okies, thanks |
| 10:07 | cait | jajm: I think it's great that you are around now - might give us the option to put some finishing touches on older patches in Marseille (and get them in) |
| 10:08 | inlibro joined #koha | |
| 10:10 | jajm | cait, let's hope i won't spend the whole week on unimarc ifla update this time :) |
| 10:11 | ashimema[m] | we need more QA resource.. I find it difficult to do QA on biblibre stuff if I'm honest.. I rarely see much back |
| 10:11 | admitedly.. you don't have anyone on the qa team this cycle.. but I'm rarely seeing SO either :( | |
| 10:11 | mean as it sounds.. I like most of the work your doing at the moment.. but it's hard to justify | |
| 10:12 | cait | hm for me the issue is not quite the same |
| 10:12 | i think the main problem is when you work on soemthing and then get no feedback for a longer while - it's certainly easier on both parts if the time gaps are not so big | |
| 10:13 | ashimema[m] | agreed on that front too |
| 10:13 | cait | so it's always better to get some 'conversation' going where both people are still aware of the problems and into it |
| 10:14 | and that's ultimately faster too, because youdon't have to spend the time again again to wraup your head around things | |
| 10:14 | but there is life... and other work demands... and it does not always work out | |
| 10:16 | sophie_m joined #koha | |
| 10:16 | cait | i am jsut happy to have some jajm :) |
| 10:19 | andreashm joined #koha | |
| 10:32 | cait left #koha | |
| 10:34 | koha-jenkins | Project Koha_Master_D9_MDB_Latest build #139: SUCCESS in 34 min: https://jenkins.koha-community[…]9_MDB_Latest/139/ |
| 10:34 | marcelr joined #koha | |
| 10:35 | cait joined #koha | |
| 10:42 | koha-jenkins | Project Koha_Master_D9_My8 build #164: SUCCESS in 48 min: https://jenkins.koha-community[…]aster_D9_My8/164/ |
| 10:46 | Project Koha_Master_U18 build #625: SUCCESS in 54 min: https://jenkins.koha-community[…]a_Master_U18/625/ | |
| 10:47 | alex_a_ joined #koha | |
| 10:54 | ere | ashimema[m]: FYI: I just posted a pull request to JSON::Validator to decrease the time spent validating our schema: https://github.com/mojolicious[…]alidator/pull/202 |
| 10:55 | ashimema[m] | I saw.. |
| 10:55 | nice one ere.. | |
| 10:55 | I'll ask batman and ether to take a look | |
| 10:55 | ere | ashimema[m]: cool, thanks :) |
| 10:57 | ashimema[m] | they lurk in #freenode_#perl-openapi:matrix.org |
| 10:57 | perl-openapi on freenode.. | |
| 11:03 | andreashm joined #koha | |
| 11:08 | inlibro joined #koha | |
| 11:08 | koha-jenkins | Project Koha_Master_D9 build #1156: SUCCESS in 34 min: https://jenkins.koha-community[…]a_Master_D9/1156/ |
| 11:13 | ere | ashimema[m]: I'm trying not to get too involved.. :) |
| 11:26 | andreash_ joined #koha | |
| 11:29 | andreashm joined #koha | |
| 11:35 | paul_p joined #koha | |
| 11:37 | khall joined #koha | |
| 12:08 | inlibro joined #koha | |
| 12:21 | alex_a joined #koha | |
| 12:32 | andrew___ joined #koha | |
| 12:32 | khall joined #koha | |
| 12:35 | oleonard-away joined #koha | |
| 12:36 | oleonard-away | How do you do, fellow kids? |
| 12:42 | magnuse | busy busy busy, oleonard |
| 12:43 | oleonard | Usually a good thing! |
| 12:44 | alex_a_ joined #koha | |
| 12:44 | andrew___ joined #koha | |
| 12:44 | khall joined #koha | |
| 12:45 | magnuse | yeah, better than bering bored |
| 12:46 | t'would be great if anyone could share their experiences no Bug 24683 | |
| 12:46 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=24683 normal, P5 - low, ---, koha-bugs, NEW , Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available |
| 12:47 | magnuse | s/no/on/ |
| 12:47 | do people have the same problem, or not? | |
| 12:51 | ashimema[m] | remind me.. whats the current plan/state of affairs for the Koha as a CMS stuff? |
| 12:52 | and how does it relate to the ongoing moving of prefs to the news system? | |
| 12:52 | oleonard | Ships passing in the night |
| 12:52 | alex_a joined #koha | |
| 12:55 | ashimema[m] | lol |
| 12:55 | cait | magnuse: do you have a itemtype on record level? |
| 12:55 | i think the max is calculated on that | |
| 13:01 | magnuse | cait: i am pretty sure they have tried everything, but i can check |
| 13:06 | Stefan joined #koha | |
| 13:08 | inlibro joined #koha | |
| 13:09 | alex_a joined #koha | |
| 13:10 | Stefan | we have an integration which stopped working after upgrade to Koha version 19.11. before this call returned items of a bibligraphic post, /api/v1/biblios/{id}/items. now I get 404. calling /api/v1/biblios/{id} returns an array of strings: "application/json", "application/marcxml+xml", "application/marc-in-json", "application/marc" |
| 13:11 | how do I get items of a bibl.post from the api version 19.11? | |
| 13:11 | and where can I find documentation of the api version 19.11? | |
| 13:11 | wizzyrea joined #koha | |
| 13:12 | cait | hi Stefan |
| 13:12 | let me check the wiki for you | |
| 13:13 | https://wiki.koha-community.or[…]iki/REST_api_RFCs | |
| 13:13 | Stefan | thanks |
| 13:13 | cait | there is an items API |
| 13:13 | hm but no status | |
| 13:13 | there is also alink to look at the inbuilt documentation in your installation | |
| 13:13 | opacbaseurl/api/v1/.html shoudl show you what's available | |
| 13:15 | it looks like biblios is not in 18.11 (which I have here) - which version did you update from? | |
| 13:16 | Stefan | the inbuilt documentation says to use /api/v1/biblios/{id} but as mentioned above it returnes the string array "application/json", "application/marcxml+xml", "application/marc-in-json", "application/marc" |
| 13:16 | we upgraded from 19.05 | |
| 13:16 | cait | ashimema[m]: around? |
| 13:16 | ashimema[m] | ish |
| 13:16 | cait | can you help with the api questionß |
| 13:16 | ? | |
| 13:17 | alex_a_ joined #koha | |
| 13:18 | ashimema[m] | you have to state the output you want I think |
| 13:18 | but I didn't think that was in 19.05.. rather though that was only in master | |
| 13:18 | Stefan | forgot to mention: its the rest api |
| 13:18 | cait | ashimema[m]: 19.11 in this case now |
| 13:20 | ashimema[m] | are you sending accept headers Stefan? |
| 13:21 | Stefan | I sent "content-type": "application/json" (with postman) |
| 13:21 | this is maybe not right | |
| 13:21 | ashimema[m] | bug 23677 is the bug that introduced the biblio endpoint |
| 13:21 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=23677 new feature, P5 - low, ---, tomascohen, Pushed to master , Add API route to get a bibliographic record |
| 13:22 | ashimema[m] | I'm confused.. you say you were using it in 19.05 and it broke.. |
| 13:22 | Stefan | exactly |
| 13:22 | ashimema[m] | but the biblio endpoint didn't exist in 19.05 |
| 13:23 | Stefan | then I'm confused |
| 13:23 | endpoint /api/v1/biblios/{id}/items returns 404 now | |
| 13:24 | cait | is it possible someone backported the feature into your 19.05? |
| 13:24 | ashimema[m] | bug 23667 also only got added in 19.11 |
| 13:24 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=23667 enhancement, P5 - low, ---, tomascohen, Pushed to master , Add API route for listing items |
| 13:24 | cait | might have been an earlier version then |
| 13:24 | Stefan | I'm pretty sure it returned items of a bibpost before |
| 13:25 | "backported" is that like "patched it" | |
| 13:25 | ? | |
| 13:25 | ashimema[m] | you look to be the first person to request such an endpoint in the bug above.. |
| 13:25 | assuming you are Stefan Kugler | |
| 13:25 | Stefan | nope |
| 13:26 | :) | |
| 13:26 | but it's a cool sounding name | |
| 13:26 | ashimema[m] | it must have been a custom backport.. the code was only written 4 months after the release on 19.05 |
| 13:26 | oh.. interesting | |
| 13:26 | Stefan | what is a "custom backport"? |
| 13:26 | ashimema[m] | what are the chances of that! |
| 13:27 | i.e.. someone added code to just your Koha to do what you wanted.. | |
| 13:27 | do you have a support provider Stefan? | |
| 13:27 | Dyrcona joined #koha | |
| 13:27 | marcelr | ashimema[m]: hope to get your attention (too) for bug 21800, architectural not very user appealing |
| 13:27 | Stefan | I sort of inherited the environment and the programmer before me is on parental leave |
| 13:27 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=21800 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , TransformKohaToMarc should respect non-repeatability of item subfields |
| 13:28 | ere | I must say I was also a bit amused we don't have /api/v1/biblios/{id}/items |
| 13:29 | ashimema[m] | we do now ere.. I believe |
| 13:29 | Stefan | well, this is all very confusing. the main question is: how do I get items from a bibpost in the rest api? |
| 13:29 | khall joined #koha | |
| 13:29 | ashimema[m] | I think it wasn't high priority because you could get the data via z3950.. |
| 13:29 | I dunnot.. I've never used it. | |
| 13:30 | I believe the error you're getting is caused by not explicitly setting any accept headers Stefan | |
| 13:30 | Stefan | I'll google it |
| 13:30 | ere | ashimema[m]: I don't see it |
| 13:31 | I only see /biblios/{biblio_id}, latest master | |
| 13:31 | ashimema[m] | hmm |
| 13:31 | me either | |
| 13:33 | ere | Kinda similar to to the fact that we don't have GET for /holds/{hold_id}, but we do have PUT and DELETE. And without bug 24680 PUT requires multiple parameters you need to get by listing all holds and finding the right one.. |
| 13:33 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=24680 minor, P5 - low, ---, ere.maijala, Needs Signoff , Hold modification endpoints don't always work properly |
| 13:33 | ashimema[m] | ok.. I'm really not close enough to the current API to help I'm afraid |
| 13:33 | but.. | |
| 13:33 | we've basically got to the point of saying.. you must have had custom code doing this as it doesn't exist in koha community at the moment. | |
| 13:34 | Stefan | Adding "Accept":"application/json" did the trick for getting bib.post info. thanks. |
| 13:34 | ashimema[m] | the api certainly needs mroe focused work |
| 13:34 | Stefan | amen |
| 13:34 | ashimema[m] | which needs funding and co-operation on testing and qa ;) |
| 13:34 | as with much of Koha.. | |
| 13:35 | ere | That's the reality, yes. |
| 13:35 | * ashimema[m] | is tired and grumpy today.. |
| 13:35 | Stefan | maybe I should learn Perl? |
| 13:35 | marcelr | maybe ? |
| 13:36 | ashimema[m] | testing is a big factor.. you don't need to know code to test that feature work as described. |
| 13:36 | oleonard | Everything Koha lacks is something that no one has given to Koha. |
| 13:36 | ashimema[m] | but learning to code is fun to :) |
| 13:36 | and we're very welcoming to new devs :) | |
| 13:36 | cait | Stefan: it's still young... and please file bugs for the problems you encounter |
| 13:36 | oops, wasn't at the bottom of discussion | |
| 13:37 | oleonard | "I can't believe you don't have this?" is disrespectful to the work that hundreds of volunteers have contributed |
| 13:37 | ere | Okay, on another front (well, very much REST still) I have a problem for which there's probably an easy answer: How can I make sure a module is loaded without calling Module::load qw(load) twice, which causes it to throw? |
| 13:37 | Stefan | maybe in the future I convert my 15 years with c# into perl. |
| 13:37 | cait | Stefan: thee is a lot of ongling API work that requires testers |
| 13:38 | ere | I'm referring to the Plugins code: https://github.com/Koha-Commun[…]ha/Plugins.pm#L91 |
| 13:38 | cait | no need to read the code there strictly speaking (also you are always welcome to) |
| 13:38 | * ashimema[m] | hopes he's not offended anyone today.. as I said.. tired and grumpy.. normally I'm a friendly person.. honest. |
| 13:38 | cait | he is... mostly :) |
| 13:38 | Stefan: https://bugs.koha-community.or[…]ed&resolution=--- is the in progress work | |
| 13:39 | ere | Maybe *I* should learn perl. |
| 13:39 | cait | .... me first |
| 13:39 | marcelr | ere: that explains a lot |
| 13:39 | * ashimema[m] | tries to understand ere's question better. |
| 13:40 | cait | Stefan: not sure if you are aware, but we require 2 independent testers for each contrib - the first is just to check it works correctly, the second is an elected QA person - so it actually really pushes integration forward to test |
| 13:40 | or give feedback in general | |
| 13:40 | ashimema[m] | koha's perl is a bit of a special beast in itself allot of the time.. |
| 13:40 | cait | might be a perl thing :) |
| 13:40 | ashimema[m] | can_load from Module::Load::Conditional perhaps ere? |
| 13:40 | ere | ashimema[m]: If anything calls Koha::Plugins->GetPlugins twice, it will blow up because it calls load for the module every time. |
| 13:41 | ashimema[m]: I tried can_load, and it always returns true :( | |
| 13:41 | ashimema[m] | it's been a while since I played in that area. |
| 13:41 | when are you trying to all GetPlugins twice? | |
| 13:41 | andreash_ joined #koha | |
| 13:42 | Dirar joined #koha | |
| 13:42 | Joubu | eval{require 'Your::Stuff'}; maybe? |
| 13:43 | ere | ashimema[m]: Tests do that. They don't fail since they load different ones unless there's another plugin installed. |
| 13:43 | ashimema[m] | that was going to be my next thought.. hehe |
| 13:43 | Stefan | cait: we're in the middle of implementing Koha now. when things settle down maybe I have time to give back to the community. |
| 13:43 | ere | ashimema[m]: I'd also like to call GetPlugins in REST V1.pm without fear. |
| 13:44 | Joubu: I'll give that a shot. | |
| 13:44 | andreash_ joined #koha | |
| 13:48 | magnuse | @quote add oleonard> Everything Koha lacks is something that no one has given to Koha. |
| 13:48 | huginn | magnuse: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command). |
| 13:50 | cait | Stefan: all good - it's understandable. and good luck! |
| 13:50 | magnuse | @quote add oleonard> Everything Koha lacks is something that no one has given to Koha. |
| 13:50 | huginn | magnuse: The operation succeeded. Quote #337 added. |
| 13:50 | Stefan | cait: thanks |
| 13:58 | paul_p joined #koha | |
| 14:08 | inlibro joined #koha | |
| 14:20 | ere | ashimema[m]: bug 24700 is the other aspect of making API startup faster |
| 14:20 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=24700 enhancement, P5 - low, ---, ere.maijala, Needs Signoff , Improve Mojo startup speed for REST APIs |
| 14:21 | ashimema[m] | :) |
| 14:24 | wizzyrea joined #koha | |
| 14:37 | ere | Oh, and there wasn't really a problem with Module::Load. I had a bug in my api plugin causing it to not load properly, and that must have confused load. |
| 14:41 | ashimema[m] | :) |
| 14:47 | lukeG joined #koha | |
| 14:52 | huginn | News from kohagit: Bug 17702: DBRev 19.12.00.029 <http://git.koha-community.org/[…]7c0b558ded7306c1f> |
| 14:52 | News from kohagit: Bug 17702: (QA follow-up) Add new field to kohastructure <http://git.koha-community.org/[…]1528782eb3aecd15b> | |
| 14:52 | News from kohagit: Bug 17702: Add UI to manage account credit types <http://git.koha-community.org/[…]3f52891d4ff136c1f> | |
| 14:57 | ashimema[m] | ere still around? |
| 14:57 | you may be better placed to understand marcelr bug 21800 I think.. | |
| 14:57 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=21800 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , TransformKohaToMarc should respect non-repeatability of item subfields |
| 14:57 | ashimema[m] | if I remembre correctly you did allot of work around this area of cleanup ? |
| 14:58 | lukeG1 joined #koha | |
| 15:01 | ere | ashimema[m]: yes |
| 15:02 | ashimema[m] | the code looks sane enough.. but I'm not close enough to really see what knock on effects it may have (or indeed what the real aim of it is) |
| 15:02 | if you could take a look at some point I'de really appreciate it (and marcelr would too) | |
| 15:03 | ere | ashimema[m]: sure, I'll check it out tomorrow |
| 15:03 | ashimema[m] | brill |
| 15:04 | sophie_m joined #koha | |
| 15:04 | ashimema[m] | in that case I'll move onto the two you sent through :) |
| 15:04 | I really like 24700 :) | |
| 15:04 | ere | ashimema[m]: me too, I only wish I had done it earlier :) |
| 15:05 | ashimema[m] | haha.. I hadn't dug enough to spot it was an issue.. |
| 15:05 | these things grow organically.. sometimes it's really nice to look back and see.. hey.. if we do X we'll save ourselves a bunch of pain.. :) | |
| 15:05 | ere | Re 21800, is default framework not supposed to be authoritative for all fields, including item data? |
| 15:06 | ashimema[m] | and that's where I've got lost.. |
| 15:07 | ere | ok :) I'll need to check that. |
| 15:08 | inlibro joined #koha | |
| 15:08 | lukeG joined #koha | |
| 15:17 | ere_away_ joined #koha | |
| 15:26 | Margaret joined #koha | |
| 15:27 | koha-jenkins | Project Koha_Master_D9_MDB_Latest build #140: UNSTABLE in 34 min: https://jenkins.koha-community[…]9_MDB_Latest/140/ |
| 15:28 | Project Koha_Master_D8 build #703: UNSTABLE in 35 min: https://jenkins.koha-community[…]ha_Master_D8/703/ | |
| 15:34 | ere_away joined #koha | |
| 15:41 | khall joined #koha | |
| 15:46 | koha-jenkins | Project Koha_Master_D9_My8 build #165: UNSTABLE in 54 min: https://jenkins.koha-community[…]aster_D9_My8/165/ |
| 15:57 | khall joined #koha | |
| 15:59 | ere_away joined #koha | |
| 16:02 | cait left #koha | |
| 16:02 | koha-jenkins | Project Koha_Master_D9 build #1157: UNSTABLE in 34 min: https://jenkins.koha-community[…]a_Master_D9/1157/ |
| 16:05 | reiveune | bye |
| 16:05 | reiveune left #koha | |
| 16:09 | inlibro joined #koha | |
| 16:17 | sophie_m joined #koha | |
| 16:19 | lukeG1 joined #koha | |
| 16:19 | alex_a joined #koha | |
| 16:20 | koha-jenkins | Project Koha_Master_U18 build #626: UNSTABLE in 51 min: https://jenkins.koha-community[…]a_Master_U18/626/ |
| 16:23 | Project Koha_19.11_D8 build #58: SUCCESS in 36 min: https://jenkins.koha-community[…]Koha_19.11_D8/58/ | |
| 16:25 | ashimema[m] | Joubu around? |
| 16:27 | Joubu | yep |
| 16:27 | ashimema[m] | or jajm |
| 16:28 | did we decide that we should really only use the I18N tt plugin when we actually want to add pluralisation and things.. | |
| 16:28 | i.e not when we're just calling `t()` | |
| 16:28 | I totally missed that jajm used it for all strings in the credit_types.tt template we introduced in bug 17702 | |
| 16:29 | huginn | Bug http://bugs.koha-community.org[…]_bug.cgi?id=17702 enhancement, P5 - low, ---, julian.maurice, Pushed to master , Create configuration for account credit types |
| 16:29 | lukeG joined #koha | |
| 16:29 | ashimema[m] | but.. as an asside to that... the xt filters test complains of missing filters on those.. I'm wondering if that's actually correct or if we should let those through without |
| 16:30 | Joubu | I would not have make this move yet |
| 16:30 | ashimema[m] | the using them for all string move.. |
| 16:31 | I should have spotted it before push.. | |
| 16:31 | but can always add a followup to remove them for now.. | |
| 16:31 | Joubu | there is a patch for that, to move *all* the string, in one go |
| 16:32 | I think there is | |
| 16:32 | ashimema[m] | I seem to remember it could cause performance issues.. |
| 16:32 | Joubu | we should have pushed that before, and so discussed it, then adjust QA script, etc. |
| 16:32 | ashimema[m] | just in time translation vs pre-compiled right? |
| 16:33 | Joubu | yes |
| 16:33 | where is that bug report? | |
| 16:34 | ashimema[m] | 17702 is the bug that added it for this new feature |
| 16:34 | Joubu | ashimema[m]: I think you should follow-up to remove the t() where not needed |
| 16:34 | ashimema[m] | agreed.. I'll do that for now.. |
| 16:35 | just wanted to check I wasn't going mad really | |
| 16:35 | Joubu | yep, but the one that does the big move |
| 16:37 | koha-jenkins | Project Koha_19.11_U18 build #52: STILL UNSTABLE in 34 min: https://jenkins.koha-community[…]oha_19.11_U18/52/ |
| 16:42 | huginn | News from kohagit: Bug 17702: (RM follow-up) Remove use of I18N tt <http://git.koha-community.org/[…]f40320ee9b38850f5> |
| 16:53 | Joubu | ashimema[m]: you forgot to attach the follow-up to the bug report |
| 16:58 | ashimema[m] | don |
| 17:01 | koha-jenkins | Yippee, build fixed! |
| 17:01 | Project Koha_19.05_D8 build #142: FIXED in 24 min: https://jenkins.koha-community[…]oha_19.05_D8/142/ | |
| 17:06 | Project Koha_19.11_D9 build #55: SUCCESS in 46 min: https://jenkins.koha-community[…]Koha_19.11_D9/55/ | |
| 17:09 | inlibro joined #koha | |
| 17:10 | koha-jenkins | Project Koha_19.05_U18 build #145: SUCCESS in 46 min: https://jenkins.koha-community[…]ha_19.05_U18/145/ |
| 17:26 | khall joined #koha | |
| 17:31 | koha-jenkins | Project Koha_19.05_D9 build #138: SUCCESS in 29 min: https://jenkins.koha-community[…]oha_19.05_D9/138/ |
| 17:58 | cait joined #koha | |
| 17:59 | koha-jenkins | Yippee, build fixed! |
| 17:59 | Project Koha_Master_D8 build #704: FIXED in 28 min: https://jenkins.koha-community[…]ha_Master_D8/704/ | |
| 18:02 | Yippee, build fixed! | |
| 18:02 | Project Koha_Master_D9_MDB_Latest build #141: FIXED in 52 min: https://jenkins.koha-community[…]9_MDB_Latest/141/ | |
| 18:09 | inlibro joined #koha | |
| 18:20 | ere_away joined #koha | |
| 18:25 | lisettelatah joined #koha | |
| 18:33 | koha-jenkins | Yippee, build fixed! |
| 18:33 | Project Koha_Master_D9 build #1158: FIXED in 33 min: https://jenkins.koha-community[…]a_Master_D9/1158/ | |
| 18:40 | kathryn joined #koha | |
| 18:51 | wizzyrea | it's a kathryn :D |
| 18:51 | kathryn | hiya wizzyrea! |
| 18:52 | it's a very brief moment, am on leave today :) | |
| 18:52 | wizzyrea | well I am glad I got in to say hi then :) |
| 18:52 | kathryn | :) Hiiiiii |
| 18:52 | wizzyrea | hope you had fun in AU |
| 18:52 | fun/productive | |
| 18:52 | kathryn | it was a busy week, but always time for a lil fun too |
| 18:53 | I'm taking Frida to Mum and Dad's today on the train | |
| 18:53 | wizzyrea | dawwwwwww |
| 18:53 | i love that train trip | |
| 18:53 | kathryn | yeah we haven't done it on the train for ages |
| 18:56 | koha-jenkins | Project Koha_Master_U18 build #627: STILL UNSTABLE in 54 min: https://jenkins.koha-community[…]a_Master_U18/627/ |
| 18:58 | sallyf joined #koha | |
| 18:58 | phasefx_ joined #koha | |
| 19:00 | felicia joined #koha | |
| 19:00 | abneiman joined #koha | |
| 19:09 | koha-jenkins | Yippee, build fixed! |
| 19:09 | Project Koha_Master_D9_My8 build #166: FIXED in 36 min: https://jenkins.koha-community[…]aster_D9_My8/166/ | |
| 19:09 | inlibro joined #koha | |
| 19:21 | lisettelatah joined #koha | |
| 19:26 | alexbuckley joined #koha | |
| 19:31 | alexbuckley joined #koha | |
| 19:40 | alexbuckley joined #koha | |
| 19:53 | oleonard | Bye #koha |
| 20:04 | hayley joined #koha | |
| 20:07 | Margaret_ joined #koha | |
| 20:09 | inlibro joined #koha | |
| 20:11 | koha-jenkins | Yippee, build fixed! |
| 20:11 | Project Koha_Master_U18 build #628: FIXED in 53 min: https://jenkins.koha-community[…]a_Master_U18/628/ | |
| 20:18 | lukeG joined #koha | |
| 20:27 | Margaret joined #koha | |
| 20:43 | tosca joined #koha | |
| 21:03 | lukeG1 joined #koha | |
| 21:10 | inlibro joined #koha | |
| 21:38 | andreashm joined #koha | |
| 21:41 | hayley joined #koha | |
| 21:53 | lukeG joined #koha | |
| 21:55 | andreashm joined #koha | |
| 21:56 | andreash_ joined #koha | |
| 22:10 | inlibro joined #koha | |
| 22:10 | lukeG1 joined #koha | |
| 22:11 | lisettelatah joined #koha | |
| 22:20 | koha-jenkins | Project Koha_18.11_D9 build #260: SUCCESS in 26 min: https://jenkins.koha-community[…]oha_18.11_D9/260/ |
| 22:25 | tosca joined #koha | |
| 22:32 | koha-jenkins | Project Koha_18.11_U18 build #249: SUCCESS in 41 min: https://jenkins.koha-community[…]ha_18.11_U18/249/ |
| 22:35 | morrism joined #koha | |
| 22:43 | koha-jenkins | Project Koha_18.11_D8 build #259: SUCCESS in 22 min: https://jenkins.koha-community[…]oha_18.11_D8/259/ |
| 22:49 | hayley joined #koha | |
| 22:52 | hayley joined #koha | |
| 23:10 | inlibro joined #koha | |
| 23:21 | hayley | looks like jenkins docker 3 is broken if anyone is around who knows about that |
| 23:22 | alexbuckley | hi all, has anyone done a setup of Koha integrating with the Libby Overdrive app? |
| 23:25 | morrism joined #koha | |
| 23:28 | morrism joined #koha | |
| 23:37 | Margaret | Hi alexbuckley, as far as I know integration with Overdrive's API is the same whether the end user is using libby or the classic overdrive app. |
| 23:38 | There's a tutorial for setting it up here: https://bywatersolutions.com/e[…]n-koha-with-18-05 | |
| 23:38 | but it wouldn't hurt to chat with your Overdrive support rep too. | |
| 23:40 | alexbuckley | thanks very much Margaret |
| 23:40 | really appreciate it! | |
| 23:40 | Margaret | Welcome, and good luck! |
| 23:45 | morrism joined #koha |
← Previous day | Today | Next day → | Search | Index