← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:03 | rangi | what? |
| 00:24 | ttps://metacpan.org/source/ARCANEZ/Plack-Middleware-DiePretty-0.001/lib/Plack/Middleware/DiePretty.pm | |
| 01:01 | Margaret joined #koha | |
| 01:21 | QueenBee joined #koha | |
| 01:35 | Margaret joined #koha | |
| 01:48 | amoyano | hello everyone, I'm new to koha. I have a little question. I assigned myself bug 19458. I solved and tested locally, and made 2 commits. When I do git format-patch, it creates a patch for each commit.. the question is if it's ok to email both patches, or should I somehow merge both commits to produce a single patch file? |
| 01:48 | huginn` | Bug http://bugs.koha-community.org[…]_bug.cgi?id=19458 enhancement, P5 - low, ---, agustinmoyano, ASSIGNED , Self-check module highlighting |
| 02:13 | Margaret joined #koha | |
| 02:30 | Margaret joined #koha | |
| 02:44 | aleisha | hi amoyano! it is okay to have more than one patch :-) |
| 02:45 | make sure you name each patch appropriately | |
| 02:46 | Margaret joined #koha | |
| 02:48 | amoyano | thanks |
| 03:04 | Margaret joined #koha | |
| 03:36 | Margaret joined #koha | |
| 04:18 | cait joined #koha | |
| 04:30 | Margaret joined #koha | |
| 05:42 | Margaret joined #koha | |
| 06:14 | Margaret joined #koha | |
| 06:32 | calire joined #koha | |
| 06:41 | marcelr joined #koha | |
| 06:41 | marcelr | hi #koha |
| 06:57 | josef_moravec joined #koha | |
| 07:02 | ashimema | Welcome aboard amoyano |
| 07:13 | Margaret joined #koha | |
| 07:34 | marcelr | josef_moravec: what do you think about bug 21336 ? |
| 07:34 | huginn` | Bug http://bugs.koha-community.org[…]_bug.cgi?id=21336 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove |
| 07:39 | magnuse | \o/ |
| 07:39 | marcelr | hi magnuse |
| 07:42 | magnuse | hiya marcelr |
| 07:47 | paul_p joined #koha | |
| 08:02 | reiveune joined #koha | |
| 08:02 | reiveune | hello |
| 08:02 | wahanui | hey, reiveune |
| 08:04 | Margaret joined #koha | |
| 08:05 | AndrewIsh joined #koha | |
| 08:05 | josef_moravec | hi marcelr |
| 08:05 | marcelr | o/ |
| 08:07 | josef_moravec | marcelr: i'll look into it, first thing - could you make Koha::Token changes separate bug? I have the similar need for the pattern token generation - i have a code similir to yours, with added pattern validation and Exception, we could colaborate on this ;) |
| 08:08 | marcelr | ok i will move it away |
| 08:08 | on its own | |
| 08:11 | fridolin joined #koha | |
| 08:12 | fridolin | hi |
| 08:12 | wahanui | kia ora, fridolin |
| 08:19 | alex_a joined #koha | |
| 08:21 | OpulentGamer joined #koha | |
| 08:26 | sophie_m joined #koha | |
| 08:33 | Archie^ joined #koha | |
| 08:33 | Archie^ | Heya koha people! |
| 08:34 | hey, a quick question. if im matching biblio files via gui is it possible to set the same with bulkmarcimport? | |
| 08:35 | for instance if im trying to add items Record: Bibliographic, Format: Marcxml, Record matching rule, ISBN, Action if matching found: Ignore (add items), Action if no match is found: add record, add items only if matching bib is found | |
| 08:36 | then via bulk marc import that would be using -x 952 -i isbn | |
| 08:37 | did get it right? | |
| 08:42 | or should i use -subfield since bib number is alway sstored in 952 subfield a | |
| 08:43 | this is confusing a little bit | |
| 08:44 | marcelr | ashimema: t/db_dependent/StockRotationItems.t hangs in subtest "Tests for investigate (singular)." after "ok 3 - older item repatriates." |
| 08:44 | On this line: is($dbitem->investigate->{reason}, 'not-ready', "older item at stagebranch not-ready."); | |
| 08:44 | any idea ? | |
| 08:49 | Margaret joined #koha | |
| 08:50 | alexbuckley joined #koha | |
| 09:02 | marcelr | josef_moravec: 21998 is the base for 21336 now |
| 09:06 | Margaret joined #koha | |
| 09:12 | josef_moravec | marcelr: thanks! |
| 09:13 | marcelr: bug 21336 does make sense for me | |
| 09:13 | huginn` | Bug http://bugs.koha-community.org[…]_bug.cgi?id=21336 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove |
| 09:13 | marcelr | good to hear |
| 09:14 | josef_moravec | I am going to test it now |
| 09:21 | andreashm joined #koha | |
| 09:21 | * andreashm | waves |
| 09:22 | fridolin1 joined #koha | |
| 09:27 | sameee joined #koha | |
| 09:29 | Margaret joined #koha | |
| 09:36 | marcelr | @later tell Joubu: Please QA simplified approach on 21848 |
| 09:36 | huginn` | marcelr: The operation succeeded. |
| 09:42 | Locutus joined #koha | |
| 09:42 | Locutus76 joined #koha | |
| 09:43 | cait joined #koha | |
| 09:45 | * cait | waves |
| 09:45 | magnuse | kia ora cait |
| 09:46 | Locutus76 | hi cait |
| 09:52 | cait | :) |
| 09:55 | * andreashm | waves |
| 09:56 | cait | quite a party today :) |
| 09:56 | ashimema | hello |
| 09:57 | * ashimema | reads up to try and understand the stockrotation thing |
| 09:57 | ashimema | no idea off the top of my head |
| 09:58 | let me fix the test I'm currently working on then I'll have a more in depth look marcelr | |
| 09:59 | Francesca joined #koha | |
| 10:02 | cait | shoudl we put 18.11 on the start page? |
| 10:02 | https://koha-community.org/ | |
| 10:02 | ashimema | hmm |
| 10:02 | probably | |
| 10:02 | wahanui | probably is too hard. |
| 10:02 | cait | i noticed most of the demos use rather old versions |
| 10:02 | biblibre is 17.11 | |
| 10:03 | ashimema | I kinda think the demos links should be ditched.. or just on a package with unattended upgrades configured |
| 10:03 | cait | magnuse: yours is 18.05 ;) |
| 10:04 | i was hesitating yesterday to add it to the agenda | |
| 10:04 | i think we should offer demos | |
| 10:04 | ashimema | we removed ours |
| 10:04 | cait | but the current state is not so nice |
| 10:04 | i've often referred to it as we don't offer one - so people could get an impression | |
| 10:04 | ashimema | there should probably be more of an organised effort community side for hosting them though in my opinion ;) |
| 10:05 | cait | magnuse: btw - nice opac design! |
| 10:05 | ashimema | like.. lets only demo three versions (stable, oldstable and oldoldstable) and ensure they track |
| 10:05 | cait | i think someone still has to look after them |
| 10:05 | ashimema | very nice |
| 10:05 | cait | but all the different versions could be quite confusing |
| 10:06 | equinox is 17.11 too | |
| 10:06 | catalyst opac has some cool intro thing | |
| 10:07 | ashimema | we removed ours because we just couldn't keep maintaining as many servers as we were.. so we now have sales and demo servers but demo logins are only given to prospective customers.. we found things got too messy otherwise |
| 10:07 | very nice | |
| 10:07 | has something odd happened to the Koha::Objects recently? | |
| 10:08 | cait | that's a broad question :) |
| 10:08 | ashimema | I thought standard dbic relationships didn't pass through |
| 10:08 | but I now have tests failing which appears to be because relationships are passing through | |
| 10:09 | cait | hm we got a dev meeting next week |
| 10:10 | ashimema | I'll ask Joubu or Tomas when they come online |
| 10:11 | cait | i'll add demo installations as a topic |
| 10:12 | or better next general | |
| 10:12 | ashimema | oh.. ffs |
| 10:12 | I see | |
| 10:12 | people are mixing dbic resultsets with koha::objects! | |
| 10:14 | Francesca joined #koha | |
| 10:17 | magnuse | cait: thanks, the opac design is the work of Petter :-) |
| 10:17 | cait | hope tnot too mean? https://wiki.koha-community.or[…]ng_9_January_2019 |
| 10:18 | as he is not here... maybe forward it's pretty :) | |
| 10:18 | magnuse | will do |
| 10:19 | we have the demo on the same server where we give people individual demo instances, so upgrade is automatic | |
| 10:19 | andreashm | what opac design? |
| 10:19 | magnuse | and i think we would prefer to maintain a demo with norwegian translations, norwegian settings, sample norwegian records etc |
| 10:19 | andreashm: demo.bibkat.no, i think | |
| 10:20 | andreashm | magnuse: ah, that one. |
| 10:20 | magnuse | we have a setup where we have a hidden master demo instance, where only we can make changes, and then the database is copied to the public demo every night |
| 10:21 | cait | nice! |
| 10:22 | andreashm | magnuse: you should have it in Swedish too! ;) |
| 10:22 | ashimema | care to share that setup magnus |
| 10:22 | I did similare way back but it sounds like I wasn't quiet as advanced as yours | |
| 10:25 | magnuse | andreashm: that is something we plan to do, yes :-) |
| 10:25 | chris1 joined #koha | |
| 10:26 | magnuse | ashimema: it's not very advanced... |
| 10:30 | Francesca joined #koha | |
| 10:31 | pastebot | "magnuse" at 127.0.0.1 pasted "demo" (28 lines) at http://paste.koha-community.org/578 |
| 10:31 | magnuse | ashimema: ^ that's how things are moved around |
| 10:33 | ashimema | super simple.. nice |
| 10:33 | thanks for shareing | |
| 10:36 | magnuse | np |
| 10:37 | and hooray for the packages! :-) | |
| 10:37 | ashimema | indeed |
| 10:41 | Archie^ | Hey guys, so i've imported some data into koha DB but for some reason it does not show in GUI. the data is 100% correct since it shows on my dev machine. Should i reindex the db or something? |
| 10:45 | cait | BobB++ |
| 10:45 | Margaret joined #koha | |
| 10:45 | cait | Archie^: if you use bulkmarcimport it will never automatically index |
| 10:46 | this is the fast loader | |
| 10:46 | so you always need to do a full reindex after | |
| 10:47 | magnuse: do you restart plack etc after the db change with sql? | |
| 10:47 | magnuse | is that actually true? last time i bulkmarcimported the records seemed to be indexed. but maybe i reindexed out of old habit and forgot about it... |
| 10:48 | cait: it does not look i do, but it might be a good idea | |
| 10:49 | cait | magnuse: might have changed, but a quick check of zebraqueue should be able to tell |
| 10:51 | [Koha] Data problems "Check In" < what is the question? | |
| 10:58 | Archie^ | is memcashe not configurated in koha-conf.xml anymore? |
| 10:58 | it shows me during upgrade databse step some sort of weird ip :/ | |
| 11:03 | vfernandes joined #koha | |
| 11:13 | marcelr | @later tell Joubu could you please comment on bug 18736 specifically comment144, would it be a blocker for you? |
| 11:13 | huginn` | marcelr: The operation succeeded. |
| 11:14 | josef_moravec | marcelr: bug 21336, test Patrons.t fails because of some not nullable columns I think, like checkprevcheckout and privacy at least |
| 11:14 | huginn` | Bug http://bugs.koha-community.org[…]_bug.cgi?id=21336 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove |
| 11:14 | marcelr | hmm |
| 11:14 | strict sql mode i guess | |
| 11:14 | will have a look | |
| 11:14 | josef_moravec | marcelr: yes, i am on devbox, it should run test in strict mode |
| 11:23 | Margaret joined #koha | |
| 11:26 | marcelr | thx josef_moravec++ will try to fix this next week, blocking the report for now |
| 11:26 | josef_moravec | marcelr: Ok, thanks, ping me when it is ready for testing again |
| 11:27 | marcelr | cool |
| 11:27 | cait | khall: around? |
| 11:28 | marcelr | htg bye #koha |
| 11:38 | Margaret joined #koha | |
| 11:52 | Archie^ | Connection to the memcached servers 'weird ass ip i've never seen before' failed. |
| 11:52 | where can i modify this? | |
| 12:10 | cait | someone an idea for this one? https://lists.katipo.co.nz/pip[…]ember/051997.html |
| 12:11 | Margaret joined #koha | |
| 12:22 | coyas joined #koha | |
| 12:24 | coyas joined #koha | |
| 12:26 | magnuse | cait: did they remember to reload apache after changing the config? |
| 12:26 | cait | you couls ask :) |
| 12:29 | indradg joined #koha | |
| 12:30 | Archie^ | item-level_itypes set but no itemtype set for item <- does that mean i need to include the item type in my marcxml file? |
| 12:30 | i am really sorry for all the questions but koha is hella confusing :/ | |
| 12:36 | magnuse | cait: done |
| 12:36 | oleonard joined #koha | |
| 12:36 | magnuse | kia ora oleonard |
| 12:36 | cait | magnuse++ thx! |
| 12:36 | Archie^: what did you set item-level_itypes to? | |
| 12:37 | Archie^ | book |
| 12:37 | its the only item level type i have | |
| 12:37 | cait | i meant hte system preference |
| 12:37 | oleonard | Hi all |
| 12:37 | cait | hi oleonard:) |
| 12:37 | Archie^ | hi oleonard |
| 12:37 | wahanui | hi oleopard |
| 12:38 | Archie^ | during the main installation of koha? i've set book :/ or maybe we we are speaking about 2 different things |
| 12:38 | cait | yes we are |
| 12:38 | item-level_itypes is the name of a system preference | |
| 12:38 | itemtypes can be either defined on record or on item level | |
| 12:38 | if you haven't changed it, yours are probably on item level | |
| 12:38 | which i'd recommend | |
| 12:39 | and you need to import your items with the correct itemtype code in 952$y | |
| 12:39 | it should usually be capital letters - it's important to get it right, case-sensitive | |
| 12:39 | so check what you have set in administration > itemtypes | |
| 12:39 | Archie^ | so if i have one item type in item types administration i should add to all of them "BOOK" under 952$y ? |
| 12:40 | cait | yes |
| 12:40 | items need an itemtype or koha will be unhappy | |
| 12:40 | you can't circulate them correctly etc | |
| 12:40 | Archie^ | can't i just modify biblioitems and add itemtype to them afterwards? |
| 12:40 | cait | biblioitems is not hte right table, i am talking abou titems |
| 12:41 | items | |
| 12:41 | you oculd, but adding a hardcoded value to your import is probably easier? | |
| 12:41 | Archie^ | yeah but that means i have to modify almost every marc record im trying to migrate.. and that's alot ;D |
| 12:42 | cait | i was thinking of it like a search and replace thing :) |
| 12:42 | but it depends on what tools you use | |
| 12:43 | Archie^ | wait but than i can add another item like " journal" and i wont need to uplaod every xml twice (to do the check by 22$ and 20$ ) |
| 12:43 | cait | ? |
| 12:44 | * kidclamp | waves |
| 12:44 | Archie^ | right now i upload into gui my xml and check by 20$, after that i upload same xml but check by 22$ |
| 12:45 | in first scenario i upload records and match to biblio in second i only add items if they are found | |
| 12:46 | cait | so you are using the gui now and not bulkmarcimport? |
| 12:47 | you could add a marc modification to add your itemtypes on import | |
| 12:47 | Archie^ | *when i'm using gui |
| 12:47 | cait | sorry, I am lost in what your process is - and house chores are calling |
| 12:48 | bbl | |
| 12:48 | Archie^ | thanks for helo cait :) |
| 12:48 | help* | |
| 12:48 | oleonard | Archie^: Are you able to use MARCEdit? It's very good for batch modifications |
| 12:49 | Archie^ | i cant, MarcEdit does not support my language ;D |
| 12:50 | oleonard | It doesn't support the encoding of the content in your MARC file? |
| 13:08 | Dyrcona joined #koha | |
| 13:10 | Archie^ | yeah |
| 13:10 | it does not see characters like š ķ ļ ņ ū ī ā | |
| 13:17 | oleonard | I do not find that to be the case |
| 13:17 | I was able to add those characters to a record in Koha, export it as MARC, and open it in MARCEdit. | |
| 13:24 | Archie^: Not that I haven't had encoding problems with MarcEdit too, I just thought it might be worth another look if it might be something that could be worked out | |
| 13:24 | fridolin joined #koha | |
| 13:43 | JesseM | Morning all |
| 13:43 | oleonard | Hi JesseM |
| 14:06 | Margaret joined #koha | |
| 14:10 | Joubu | hi |
| 14:10 | wahanui | bonjour, Joubu |
| 14:17 | oleonard | Hi Joubu |
| 14:19 | Joubu: Did you observe the same problem as Devinim on Bug 21913? The payment section showing up when it shouldn't? | |
| 14:19 | huginn` | Bug http://bugs.koha-community.org[…]_bug.cgi?id=21913 enhancement, P5 - low, ---, oleonard, Failed QA , Clean up payment details page |
| 14:19 | Joubu | yes |
| 14:19 | oleonard | I can't reproduce the problem |
| 14:20 | Joubu | oleonard: http://pro.kohadev.org/cgi-bin[…]ccountlines_id=16 |
| 14:20 | I see: https://screenshots.firefox.co[…]O/pro.kohadev.org | |
| 14:21 | oleonard | Okay maybe it's because I have rental fees and lost item fees but not fines |
| 14:23 | Margaret joined #koha | |
| 14:27 | Joubu | oleonard: the problem exists on master, I FQAed it because it was advertised in the test plan |
| 14:28 | we can deal with it on a separate bug report, if the line is removed from the test plan :) | |
| 14:28 | oleonard | Yes, I agree. I was specifically trying to fix that problem, but there's obviously at least one case where my fix doesn't work. |
| 14:38 | lukeG joined #koha | |
| 14:40 | oleonard | I don't understand account_offsets. |
| 14:40 | kohaputti joined #koha | |
| 14:42 | Margaret_ joined #koha | |
| 14:43 | ashimema | What do you want to know about account_offsets oleonard .. I think I've finally grasped them now |
| 14:44 | calire left #koha | |
| 14:44 | ashimema | Basically.. anything you do with an accountline should get a corresponding offset |
| 14:44 | Joubu | AndrewIsh: would you mind opening a new bug report for your findings on bug 21460 |
| 14:44 | ashimema | Not all cases are fully covered yet though |
| 14:44 | huginn` | Bug http://bugs.koha-community.org[…]_bug.cgi?id=21460 normal, P5 - low, ---, andrew.isherwood, Signed Off , Filtering ILL requests on borrowernumber does not work |
| 14:44 | Joubu | s/$/? |
| 14:44 | AndrewIsh | Joubu: Yep, no prob |
| 14:45 | oleonard | ashimema: Do all entries in accountlines have a corresponding entry in account_offsets? |
| 14:45 | ashimema | they should have at least one offset yes |
| 14:45 | if not more than one | |
| 14:46 | but.. there are bugs and so it's not 100% always the case.. | |
| 14:46 | see the tree of bugs hanging off bug 21002 | |
| 14:46 | huginn` | Bug http://bugs.koha-community.org[…]_bug.cgi?id=21002 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Add Koha::Account::add_debit |
| 14:46 | ashimema | for example.. |
| 14:47 | some of those bugs are just cleanup.. others actually introduce the proper addition of offsets where it had been missed before | |
| 14:47 | oleonard | ashimema: I'm trying to hide the "payments" table on accountline-details.pl if there are no payments, but the data being sent to the template appears to include more than just payments |
| 14:48 | ashimema | my may want to filer on offset_type? |
| 14:49 | what should the 'payments' table show.. | |
| 14:49 | any form of credit that been aplied to a debit (i.e. credit, payment, forgiven, writeoff) | |
| 14:50 | if that's the case the distinguising factor is likely that both credit_id and debit_it are present in the offsets row | |
| 14:50 | for a 'credit' that not been applied to a 'debit' yet only the 'credit_id' will be populated.. | |
| 14:51 | for a 'debit' that hasn't had any 'credits' applied to it yet then the offset will not have a 'credit_id' | |
| 14:51 | hope that helps clarify | |
| 14:51 | oleonard | Yes it does |
| 14:52 | ashimema | took me a while for the penny to drop on that one.. so your not alone ;) |
| 14:55 | Joubu | any chances to write something down on the wiki? :) |
| 14:55 | ashimema | sure |
| 14:55 | any hints on a suitable place? | |
| 14:56 | nuentoter joined #koha | |
| 14:56 | nuentoter | o7 morning all |
| 14:57 | Joubu | ashimema: ask the wiki curator |
| 14:57 | :D | |
| 14:57 | ashimema | hehe |
| 14:57 | Joubu | hi nuentoter |
| 14:57 | ashimema: https://wiki.koha-community.or[…]e/Accounts_Schema :) | |
| 14:58 | nuentoter | is there a way to clear out pending offline circulation uploads? |
| 14:58 | caroline joined #koha | |
| 14:58 | Joubu | ashimema: I guess this patch needs an update https://wiki.koha-community.or[…]ng_system_rewrite |
| 14:58 | caroline | good morning! |
| 14:58 | nuentoter | when i go to view it, it hangs forever because i'm a moron and uploaded a master file (127mb) instead of the modified one i actually wanted to upload |
| 14:59 | Joubu | nuentoter: you can delete the entries from the table |
| 15:00 | nuentoter | morning caroline |
| 15:02 | oleonard | khall around? |
| 15:02 | Joubu | AndrewIsh: you won the #22k, congrts! :D |
| 15:03 | ashimema | hehe |
| 15:03 | AndrewIsh | Joubu: I noticed that! Hurray! I already have the champagne open! |
| 15:09 | nuentoter | hmmmm would someone be able to help we with deleting those from the table? |
| 15:10 | DB management is not my thing, im learning this as i go | |
| 15:11 | Joubu | before deleting them, do you have a UI to see what is the content of the table? |
| 15:11 | and make sure you really want to remove them :) | |
| 15:13 | nuentoter | no i dont, I know i want to clear that specific table completely though, its just offline circ stuff. |
| 15:14 | i've never used workbench or anything before | |
| 15:15 | Joubu | select * from pending_offline_operations limit 100; # to see the first 100 entries of the table |
| 15:15 | select * from pending_offline_operations order by operationid desc limit 100; # to see the last 100 | |
| 15:16 | select count(*) from pending_offline_operations; # To know how many rows the table contains | |
| 15:16 | # time to backup the DB | |
| 15:17 | to remove *all* the entries from a table, the SQL query is: DELETE FROM table_name; | |
| 15:18 | nuentoter | will that show the file, or the contents of what the file had in the table? cuz if its the contents then it'll be a no go |
| 15:19 | DELETE FROM pending_offling_operations should clear that all then right? | |
| 15:19 | coyas_ joined #koha | |
| 15:20 | Joubu | cait: about 21065, what about "on delete set null" then? |
| 15:28 | oleonard | I'm thinking about this: https://zivotdesign.com/p/#0/15448012327474 |
| 15:30 | caroline | oleonard: the link goes to an album |
| 15:30 | oleonard | Oh sorry |
| 15:31 | Try again https://zivotdesign.com/p/view[…]?p=15448012327474 | |
| 15:31 | caroline | that's cool! |
| 15:31 | does it work with the keyboard shortcuts? | |
| 15:32 | huginn` | News from kohagit: Bug 21880: (follow-up) Add some uri filters <http://git.koha-community.org/[…]8115f0437a26b9490> |
| 15:32 | News from kohagit: Bug 21991: Pass param names to report limit tool <http://git.koha-community.org/[…]c55f503183935f29d> | |
| 15:32 | News from kohagit: Bug 21986: Do not escape quotation marks when cataloguing <http://git.koha-community.org/[…]d0f8793c9eb2a7fb9> | |
| 15:32 | News from kohagit: Bug 21931: Do not reset the ES mapping on 3.23.00.050 <http://git.koha-community.org/[…]7b105e0a2ab31e01d> | |
| 15:32 | News from kohagit: Bug 14334: Remove AutoCommit from tests <http://git.koha-community.org/[…]cad88eb403d1053d6> | |
| 15:32 | News from kohagit: Bug 21973: Do not url escape casServerUrl <http://git.koha-community.org/[…]e1fd77497894f68f5> | |
| 15:32 | News from kohagit: Bug 21950: Remove filtering for query_cgi and limit_cgi <http://git.koha-community.org/[…]95d52806f739ead64> | |
| 15:32 | News from kohagit: Bug 21880: "Relationship information" disappears when accessing paginated results... <http://git.koha-community.org/[…]8675c54f18b08c010> | |
| 15:33 | oleonard | caroline: It would. That's just a proof of concept. I've been thinking about how to make that area more responsive and ended up there |
| 15:35 | My proof of concept doesn't yet prove that it's more responsive though... | |
| 15:35 | caroline | oh. but it's still nice I think |
| 15:36 | Also, it makes it more obvious which search you're using | |
| 15:40 | Dyrcona joined #koha | |
| 15:43 | reiveune | bye |
| 15:43 | reiveune left #koha | |
| 15:44 | fridolin left #koha | |
| 15:47 | caroline | cait? |
| 15:47 | wahanui | cait is, like, qa manager |
| 15:54 | koha-jenkins | Project Koha_Master_D8 build #140: SUCCESS in 21 min: https://jenkins.koha-community[…]ha_Master_D8/140/ |
| 16:04 | Project Koha_Master_U18 build #118: SUCCESS in 29 min: https://jenkins.koha-community[…]a_Master_U18/118/ | |
| 16:17 | AndrewIsh_ joined #koha | |
| 16:22 | koha-jenkins | Project Koha_Master_D9 build #628: SUCCESS in 28 min: https://jenkins.koha-community[…]ha_Master_D9/628/ |
| 16:23 | AndrewIsh joined #koha | |
| 16:23 | ashimema | Joubu still about? |
| 16:24 | Joubu | yep |
| 16:25 | ashimema | any thoughts on https://paste.debian.net/1055851/ for bug 21848 |
| 16:25 | huginn` | Bug http://bugs.koha-community.org[…]_bug.cgi?id=21848 minor, P5 - low, ---, m.de.rooy, Passed QA , Resolve unac_string warning from Circulation.t |
| 16:26 | ashimema | lol.. it's not 21848 at all.. it's bug 21065 |
| 16:26 | huginn` | Bug http://bugs.koha-community.org[…]_bug.cgi?id=21065 blocker, P5 - low, ---, jonathan.druart, Needs Signoff , Data in account_offsets and accountlines is deleted with the patron leaving gaps in financial reports |
| 16:26 | ashimema | might want to rename your atomic update file |
| 16:30 | so yeah.. running the test suit my hunch was right.. | |
| 16:30 | it really doesn't like those object_class additions | |
| 16:31 | I have a note from three weeks or so ago to talk to you about those.. Tomas and I had a chat about it.. | |
| 16:31 | can't for the life of me remember what we said though :( | |
| 16:31 | chris_n joined #koha | |
| 16:32 | Joubu | ashimema: refresh, I have updated it |
| 16:33 | it was added twice, I messed up with stash pop apparently | |
| 16:34 | ashimema | lol |
| 16:35 | Joubu | Is that what you were referring to? Subroutine redefined? |
| 16:35 | ashimema | yup |
| 16:36 | but I have a vague recollection of there being other issues with get_from_storage | |
| 16:36 | Joubu | and yes, the .perl is not named correctly |
| 16:36 | ashimema | I'm not sure I understand what it gives us over discard_changes |
| 16:37 | Joubu | I think these occurrences could have been replaced with discard_changes |
| 16:37 | ashimema | lets see what the tests show |
| 16:37 | I 'think' the additions to the dbic class files are only needed for get_from_storage aren't they? | |
| 16:37 | curse my bad memory | |
| 16:38 | Joubu | yes |
| 16:38 | ashimema | so are you saying we should be using discard_changes and removing get_from_storage at some point? |
| 16:39 | Joubu | not sure |
| 16:39 | I think we need to refetch the whole stuff, and so get_from_storage | |
| 16:39 | ashimema | discard_changes does that as far as I understand |
| 16:40 | Joubu | nope |
| 16:40 | well, maybe :) But IIRC we needed get_from_storage at some point because of that | |
| 16:41 | ashimema | `Re-selects the row from the database, losing any changes that had been made.` |
| 16:41 | Joubu | like, discard_changes could be used to get the default values set by dbic after an insert/update, and the PK AI |
| 16:41 | ashimema | that's the POD for discard_changes |
| 16:41 | Joubu | but not for FK updated on cascade |
| 16:41 | ashimema | hmm |
| 16:42 | Joubu | "This method can also be used to refresh from storage, retrieving any changes made since the row was last read from storage. " |
| 16:42 | for discard_changes | |
| 16:42 | So I am wrong | |
| 16:42 | ashimema | fun times |
| 16:42 | seems odd that dbic itself has both methods | |
| 16:42 | now I am more confused again | |
| 16:43 | * ashimema | will ask the master.. ribasushi .. for his take |
| 16:43 | Joubu | ashimema: If I replace |
| 16:43 | $line = $line->get_from_storage | |
| 16:43 | ashimema | ooh.. he still lurks here.. he may pop up and tell us if we're lucky |
| 16:43 | Joubu | with $line->discard_changes (assignement removed on purpose) |
| 16:43 | ashimema | go on |
| 16:44 | Joubu | the test does not pass |
| 16:44 | ashimema | ok |
| 16:45 | I bet we're caching stuff a level higher or something :( | |
| 16:47 | Joubu | nope |
| 16:50 | ) ENGINE=InnoDB AUTO_INCREMENT=2000000104 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci | | |
| 16:50 | how did I end up with such AI value! | |
| 16:50 | I reset the DB this morning... | |
| 16:51 | ashimema: reset the DB again, and now the tests are passing with discard_changes... :-/ | |
| 16:51 | ashimema | hehe |
| 16:52 | totally baffled from here | |
| 16:54 | Joubu | focus on other parts of this change :) |
| 16:54 | that's not the important bit of these patches | |
| 16:54 | * ashimema | has already moved on and is ;) |
| 16:54 | Joubu | see the SET NULL for the itemnumber FK, that is weird |
| 16:55 | ashimema | as I say.. I'm doing double diligence by running the entire suit instead of just the obvious tests |
| 16:55 | then I'll probably say straight to PQA as the real guts of the patch are actually super trivial | |
| 16:55 | yeah.. I though the SET NULL was odd there | |
| 16:55 | I commented ;) | |
| 16:56 | I also find the 'DEFAULT 0' for some of them a bit off.. surely they shuold be 'DEFAULT NULL' | |
| 16:57 | Joubu | ashimema: there is another problem I did not note in the commit: the constraint will be dropped and recreated on each run of the DB entry |
| 16:57 | which means: if it is backported the accountlines table will be modified twice (slowing down the update process unecesserairiluuye) | |
| 16:58 | (I never know where are the n c s r letters in this word) | |
| 16:58 | unnecessarily | |
| 16:58 | ashimema | hehe |
| 16:58 | lol | |
| 16:58 | now you've pointed that out to me ;P | |
| 16:59 | you could resolve that by renaming the constraint | |
| 17:00 | Joubu | yes, but I did not like the idea |
| 17:00 | ashimema | lol |
| 17:00 | I'm game to let that one slip ;) | |
| 17:01 | though.. that could be a massive table | |
| 17:01 | Joubu | maybe someone has a different name for this constraint :) |
| 17:01 | ashimema | so perhaps I should pay more attention to it. |
| 17:01 | Joubu | we could grep the result of SHOW TABLES... |
| 17:01 | but... | |
| 17:03 | ashimema | ack... now you've braught my attention to it.. it's so obvious |
| 17:03 | and feels bad | |
| 17:03 | Joubu | /clear |
| 17:04 | ashimema | hehe |
| 17:09 | paul_p joined #koha | |
| 17:12 | ashimema | done |
| 17:12 | cait.. be happy :) | |
| 17:35 | cait | hm? |
| 17:35 | should read back, i guess | |
| 17:44 | oh yes, cait is very happy :) especially if that is backported | |
| 18:10 | ashimema++ Joubu++ :) | |
| 18:20 | koha-jenkins | Yippee, build fixed! |
| 18:20 | Project Koha_18.05_D8 build #140: FIXED in 23 min: https://jenkins.koha-community[…]oha_18.05_D8/140/ | |
| 18:21 | Yippee, build fixed! | |
| 18:21 | Project Koha_18.05_D9 build #137: FIXED in 27 min: https://jenkins.koha-community[…]oha_18.05_D9/137/ | |
| 18:46 | Project Koha_18.05_U18 build #140: STILL UNSTABLE in 26 min: https://jenkins.koha-community[…]ha_18.05_U18/140/ | |
| 18:54 | Joubu | lukeG: Hi! We usually do not merge branches when backporting into stable releases |
| 18:59 | Margaret joined #koha | |
| 19:30 | nuentoter joined #koha | |
| 19:30 | nuentoter | o7 again |
| 19:40 | chris_n joined #koha | |
| 19:47 | lukeG joined #koha | |
| 19:57 | oleonard | Bye #koha |
| 19:57 | Margaret joined #koha | |
| 20:15 | jeff joined #koha | |
| 20:15 | ibeardslee joined #koha | |
| 20:16 | Scott-CSPL joined #koha | |
| 20:16 | deb-CSPL joined #koha | |
| 20:16 | abneiman joined #koha | |
| 20:17 | huginn joined #koha | |
| 20:18 | Dyrcona joined #koha | |
| 20:21 | pastebot joined #koha | |
| 21:08 | JesseM | Joubu: what do you mean here? lukeG: Hi! We usually do not merge branches when backporting into stable releases |
| 21:18 | cait | did you use git merge? |
| 21:19 | not sure what triggered his comment | |
| 21:20 | i tihnk he meant this commit: http://git.koha-community.org/[…]704a2bbc60cc4dfc5 | |
| 21:29 | lukeG | cait. i did not use git merge. but perhaps because i used git pull from my kohaclone locally? |
| 21:33 | sameee joined #koha | |
| 21:35 | cait | i think a git pull is a mix of two commands |
| 21:36 | git fetch and... rebase? could be | |
| 21:36 | i usually only used git cherry-pick and git push | |
| 21:39 | hm, missed him already, but for the logs - looked it up: git pull runs git fetch with the given parameters and calls git merge to merge the retrieved branch heads into the current branch. | |
| 21:52 | lukeG joined #koha | |
| 22:19 | bshum joined #koha | |
| 23:02 | caroline | good weekend #koha! |
← Previous day | Today | Next day → | Search | Index