← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 01:21 | mtj | hey rangi -> http://git.kohaaloha.com/?p=je[…]ns/.git;a=summary |
| 01:21 | 'Koha test-suite, with 3.2x speedup on 4 core VM' :) | |
| 01:23 | rangi | cool |
| 01:27 | mtj | i've noticed the '00-strict.t' test takes longer than all other tests combined |
| 01:28 | rangi | thats because it touches every file |
| 01:28 | (as it should) | |
| 01:28 | mtj | agreed :) |
| 01:30 | ..the next sneaky win might be to parallelise that.. but i think its probably not worth the bang/buck | |
| 01:30 | rangi | hmm yeah |
| 01:31 | mtj | ..as prove seems to run that task in the background, as it does the other tests on other cores |
| 01:32 | hmm, tho.. im not sure how many cores the jenkins server actually has | |
| 01:52 | * mtj | pinged tcohen, so we'll see how it goes |
| 02:14 | NateC joined #koha | |
| 03:37 | Francesca joined #koha | |
| 03:53 | mtompset joined #koha | |
| 03:53 | mtompset | Greetings, #koha. |
| 03:53 | @seen alexbuckley_ | |
| 03:53 | huginn | mtompset: alexbuckley_ was last seen in #koha 1 day, 5 hours, 4 minutes, and 28 seconds ago: <alexbuckley_> hi mtompset |
| 03:54 | mtompset | Are you around alexbuckley_? |
| 04:07 | Scott-CSPL joined #koha | |
| 04:24 | Francesca joined #koha | |
| 04:28 | rocio joined #koha | |
| 04:38 | Francesca joined #koha | |
| 05:05 | alexbuckley_ | yup I am |
| 05:18 | Francesca joined #koha | |
| 05:22 | drojf joined #koha | |
| 05:44 | rocio joined #koha | |
| 05:57 | mtompset | alexbuckley_: Sorry for the slow reply too. Check out 17855 and see if my two additional patches are cool with you. |
| 06:00 | If so, sign them off, and we'll be back waiting for Joubu to reassess for anything we may have missed. | |
| 06:01 | I'm off to sleep. | |
| 06:02 | Have a good day (24 hour period), #koha alexbuckley_ | |
| 06:22 | cait joined #koha | |
| 06:46 | josef_moravec joined #koha | |
| 06:46 | josef_moravec | morning #koha |
| 06:49 | * magnuse | waves |
| 06:49 | magnuse | hiya josef_moravec |
| 06:49 | josef_moravec | hi magnuse |
| 06:49 | wahanui | kamelåså |
| 06:49 | drojf | hei josef_moravec and magnuse |
| 06:50 | magnuse | lulz |
| 06:50 | moin drojf | |
| 06:50 | josef_moravec | hello drojf |
| 06:50 | * cait | waves |
| 06:50 | josef_moravec | @wunder usti nad orlici |
| 06:50 | huginn | josef_moravec: The current temperature in Dlouha Trebova, Dlouhá TÅ™ebová, Czech Republic is 2.1°C (7:50 AM CET on February 03, 2017). Conditions: Mist. Humidity: 90%. Dew Point: 1.0°C. Windchill: 2.0°C. Pressure: 29.83 in 1010 hPa (Steady). |
| 06:50 | drojf | @wunder berlin, germany |
| 06:50 | huginn | drojf: The current temperature in Berlin, Berlin, Germany is -0.3°C (7:49 AM CET on February 03, 2017). Conditions: Overcast. Humidity: 100%. Dew Point: -0.0°C. Windchill: 0.0°C. Pressure: 29.77 in 1008 hPa (Steady). |
| 06:51 | drojf | @wunder hamburg, germany |
| 06:51 | huginn | drojf: The current temperature in Teutonenweg, Hamburg, Germany is 0.7°C (7:47 AM CET on February 03, 2017). Conditions: Overcast. Humidity: 100%. Dew Point: 1.0°C. Windchill: 1.0°C. Pressure: 29.68 in 1005 hPa (Steady). |
| 06:55 | LibraryClaire joined #koha | |
| 07:03 | * cait | waves good morning |
| 07:03 | cait | @wunder Konstanz |
| 07:03 | huginn | cait: An error has occurred and has been logged. Please contact this bot's administrator for more information. |
| 07:04 | cait | @wunder Konstanz |
| 07:04 | huginn | cait: An error has occurred and has been logged. Please contact this bot's administrator for more information. |
| 07:04 | cait | hm |
| 07:04 | @wunder Radolfzel | |
| 07:04 | huginn | cait: An error has occurred and has been logged. Please contact this bot's administrator for more information. |
| 07:04 | cait | ah nm |
| 07:05 | LibraryClaire | morning #koha |
| 07:11 | paul_p joined #koha | |
| 07:12 | cait | morning paul_p |
| 07:15 | eythian | @wunder ams |
| 07:15 | huginn | eythian: An error has occurred and has been logged. Please contact this bot's administrator for more information. |
| 07:15 | eythian | :< |
| 07:15 | @wunder Jordaan, Amsterdam | |
| 07:15 | huginn | eythian: An error has occurred and has been logged. Please contact this bot's administrator for more information. |
| 07:16 | eythian | Today I don't exist. |
| 07:16 | drojf | i used the last weather. sorry |
| 07:17 | eythian | You're supposed to refill it when that happens. |
| 07:17 | drojf | i did not find the manual |
| 07:17 | so i put a note | |
| 07:17 | and walked away with all the weather i got | |
| 07:20 | @wunder berlin, germany | |
| 07:21 | huginn | drojf: The current temperature in Berlin, Berlin, Germany is -0.3°C (8:19 AM CET on February 03, 2017). Conditions: Overcast. Humidity: 100%. Dew Point: -0.0°C. Windchill: 0.0°C. Pressure: 29.77 in 1008 hPa (Steady). |
| 07:21 | drojf | hehe |
| 07:21 | see, it is not empty at all | |
| 07:21 | take some berlin weather | |
| 07:21 | we got plenty | |
| 07:22 | LibraryClaire | @wunder konstanz |
| 07:22 | huginn | LibraryClaire: The current temperature in Mainaustraße, Konstanz, Germany is 4.5°C (8:19 AM CET on February 03, 2017). Conditions: Overcast. Humidity: 94%. Dew Point: 4.0°C. Windchill: 4.0°C. Pressure: 29.80 in 1009 hPa (Rising). |
| 07:24 | magnuse | @wunder enbo |
| 07:24 | huginn | magnuse: The current temperature in Bodo, Norway is 0.0°C (7:50 AM CET on February 03, 2017). Conditions: Clear. Humidity: 75%. Dew Point: -4.0°C. Windchill: -7.0°C. Pressure: 29.68 in 1005 hPa (Steady). |
| 07:24 | magnuse | gonna be a fine day! |
| 07:36 | eythian | @wunder ams |
| 07:36 | huginn | eythian: The current temperature in Amsterdam, Netherlands is 9.0°C (8:25 AM CET on February 03, 2017). Conditions: Clear. Humidity: 87%. Dew Point: 7.0°C. Pressure: 29.59 in 1002 hPa (Rising). |
| 07:40 | sameeenz joined #koha | |
| 07:41 | reiveune joined #koha | |
| 07:41 | reiveune | hello |
| 07:41 | wahanui | salut, reiveune |
| 07:50 | sameeenz joined #koha | |
| 07:58 | drojf joined #koha | |
| 08:00 | fridolin joined #koha | |
| 08:00 | fridolin left #koha | |
| 08:07 | marcelr joined #koha | |
| 08:07 | marcelr | morning $KOha |
| 08:07 | oops | |
| 08:07 | koha | |
| 08:08 | laurence joined #koha | |
| 08:12 | marcelr | jajm around? |
| 08:16 | sophie_m joined #koha | |
| 08:24 | fridolin joined #koha | |
| 08:24 | AndrewIsh joined #koha | |
| 08:29 | alex_a joined #koha | |
| 08:30 | jajm | marcelr, yep |
| 08:30 | marcelr | hi jajm |
| 08:30 | can i get you to qa some authority patches again? | |
| 08:30 | jajm | hi! :) |
| 08:30 | marcelr | few smaller ones? |
| 08:30 | jajm | sure |
| 08:31 | which ones ? | |
| 08:31 | wahanui | which ones are lighztning talks? |
| 08:31 | marcelr | bug 17950 is a test |
| 08:31 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=17950 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Small improvements for Merge.t |
| 08:31 | marcelr | bug 16018 |
| 08:31 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=16018 enhancement, P5 - low, ---, remi.mayrand-provencher, Signed Off , Merge.pl does not update biblios linked to the old authority |
| 08:32 | marcelr | also smaller one |
| 08:32 | bug 18014 | |
| 08:32 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=18014 normal, P5 - low, ---, m.de.rooy, Signed Off , AddAuthority should respect AUTO_INCREMENT |
| 08:33 | marcelr | these three> |
| 08:34 | gaetan_B joined #koha | |
| 08:34 | gaetan_B | hello |
| 08:42 | alexbuckley joined #koha | |
| 08:46 | Joubu | marcelr: About 17737, it's a DB issue |
| 08:46 | marcelr | what exactly? |
| 08:46 | Joubu | I get this error with Reserves.t (and only this one) when I use misc4dev to generate the DB |
| 08:46 | if I create a DB using the web installer, I do not get this error | |
| 08:47 | marcelr | hm i will check my data |
| 08:47 | Joubu | I have never dug into this problem |
| 08:52 | marcelr | Joubu: the cause is agerestriction |
| 08:53 | did you connect it to a field in the framework? | |
| 08:54 | Joubu | no idea |
| 08:54 | marcelr | if you dont, you should have the same error |
| 08:54 | Joubu | I use the sample data, so I do not understand why it is different from the installer |
| 08:55 | marcelr | its not in the mandatory section |
| 08:55 | Joubu | misc4dev inserts everything |
| 08:55 | unless I missed one :) | |
| 08:56 | Francesca joined #koha | |
| 08:58 | Joubu | marcelr: I guess the update marc_subfield_structure should actually be "update or insert" |
| 08:58 | in Reserves.T | |
| 08:59 | marcelr | i will connect 521a and continue |
| 08:59 | but i think it is a gap | |
| 08:59 | i see that it is inserted in unimarc though | |
| 09:00 | 333a | |
| 09:02 | Joubu: ok, you should flush the cache here too | |
| 09:02 | Joubu | marcelr: it's installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql |
| 09:02 | that is missing in misc4dev | |
| 09:02 | marcelr | yeah but we should not even depend on it |
| 09:03 | the update in the test works but the cache is in between | |
| 09:04 | Joubu | actually the sql is correctly picked. |
| 09:04 | yes confirmed it's a cache issue | |
| 09:05 | marcelr | can we force it in the test |
| 09:05 | Joubu | yes |
| 09:05 | marcelr | on this report or another ? outside scope.. |
| 09:05 | Joubu | should be fixed on a separate bug yes |
| 09:06 | I can do that if you want | |
| 09:06 | marcelr | yes i will sign it off |
| 09:16 | alexbuckley | Joubu bug 17855 is ready for you when your ready |
| 09:16 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=17855 enhancement, P5 - low, ---, alexbuckley, Signed Off , Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha |
| 09:19 | Joubu | alexbuckley: ok. I have already a lot of things for today, not sure I will be able to take it before the week-end |
| 09:20 | alexbuckley | no problem just whenever your free |
| 09:33 | kristebo joined #koha | |
| 09:37 | marcelr | Joubu: not sure what is happening, but I have opac-detail crashing constantly now with 17736 applied ;) |
| 09:38 | and without these patches, no problem .. | |
| 09:39 | Joubu | it's ok for me |
| 09:39 | kristebo | hi folks! |
| 09:39 | Joubu | ha, I need holds I guess |
| 09:39 | hi kristebo | |
| 09:39 | kristebo | I wonder if someone ca help me with a problem. my koha installation gives me a internal server error when adding new users autheticated over ldap. the error from koha is Undefined subroutine &C4::Auth_with_ldap::AddMember called at /usr/share/koha/lib/C4/Auth_with_ldap.pm line 213. |
| 09:40 | Joubu | marcelr: what is the error? |
| 09:41 | marcelr | it is 50 lines with plack errors |
| 09:41 | Joubu | kristebo: see bug 17775 |
| 09:41 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=17775 blocker, P5 - low, ---, liz, Passed QA , Add new user with LDAP not works under Plack |
| 09:41 | marcelr | i also see Attempt to bless into a reference at /usr/share/koha/masterclone/Koha/Objects.pm line 55. |
| 09:41 | but not sure where it is coming from | |
| 09:42 | i will check myself | |
| 09:42 | Joubu | marcelr: + while ( my $hold = $holds->new ) { |
| 09:42 | this is terrible | |
| 09:42 | it's ->next | |
| 09:42 | marcelr | where? |
| 09:42 | Joubu | opac-detail |
| 09:42 | marcelr | ok |
| 09:42 | Joubu | ~600 |
| 09:42 | (reading the git diff) | |
| 09:43 | marcelr | why did i not see that ! |
| 09:43 | kristebo | thanks huginn |
| 09:43 | Joubu | same for me... Why did I write that?? |
| 09:43 | marcelr | oh those signoffs |
| 09:44 | you cannot trust them | |
| 09:44 | Joubu | :p |
| 09:44 | marcelr | if you add a follow-up, i will sign it :) |
| 09:45 | Joubu | marcelr: attached! |
| 09:45 | wahanui | i heard attached was the file of new materials statistics for the previous month. Please use this file to calculate the values for the adds spreadsheet.n"; |
| 09:46 | marcelr | ok |
| 09:49 | cait joined #koha | |
| 10:04 | kidclamp joined #koha | |
| 10:06 | * cait | waves good morning again |
| 10:08 | kristebo | joubu, huginn: the "fix" on 17775 does not fix anything. :) |
| 10:09 | Joubu | kristebo: did you restart apache? |
| 10:09 | not apache, plack! | |
| 10:10 | kristebo | ah.i'll try that |
| 10:23 | joubu: it works. :) | |
| 10:23 | thanks | |
| 10:24 | Joubu | kristebo: when you change perl code, you must restart plack |
| 10:25 | kristebo | Joubu: that is natural, but easy to forget. |
| 10:33 | cait | matts: around? |
| 10:34 | matts | cait, hey |
| 10:34 | cait | hey |
| 10:34 | i got a CAS question actually | |
| 10:34 | let me find the bug | |
| 10:35 | the problem is on logout | |
| 10:35 | it seems to go into ane ndless loop | |
| 10:35 | since we upated and a fix was done | |
| 10:36 | bug 17481 | |
| 10:36 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=17481 major, P5 - low, ---, matthias.meusburger, Pushed to Master , Cas Logout: bug 11048 has been incorrectly merged |
| 10:37 | cait | i think it happens becausef of the logout.x at the end |
| 10:37 | matts | cait, you mean that the problem occured after this patch was merged ? |
| 10:37 | cait | yes |
| 10:37 | before it just wouldn'r redirect you | |
| 10:37 | now it tries to redirect, but the url in the service param is | |
| 10:37 | matts | ok. that's normal, because redirect was broken before anyway. |
| 10:37 | cait | opac-main.pl%3Flogout.x%3D1 |
| 10:37 | yep | |
| 10:38 | and it just loops... like the page keeps reloading relaoding... | |
| 10:38 | matts | hmmkay |
| 10:38 | cait | I think that's because of the logout parameter at the end - if i cut that off it works ok and redirects |
| 10:38 | matts | makes sense |
| 10:38 | cait | does this not happen for your installations? |
| 10:39 | matts | cait, not the last time I tried. |
| 10:39 | cait | hm this is 3.22.14 atm |
| 10:39 | matts | I'll try to have a look at it (but it will probably be next week) |
| 10:39 | cait | is it worth filing a bug? |
| 10:39 | i just wanted to check with you first | |
| 10:40 | matts | Doesn't hurt to fill a bug imho. |
| 10:40 | cait | ok, will do |
| 10:40 | matts | cait, ok, send me the bug number once it is created. |
| 10:40 | cait | is here ok or better by email? |
| 10:41 | matts | better by email, as I will leave soon. |
| 10:41 | cait | ok :) |
| 10:41 | thank you! | |
| 10:41 | matts | :) |
| 10:52 | marcelr | thx kidclamp |
| 10:52 | kidclamp | np |
| 10:52 | :-) | |
| 11:39 | kristebo | I need some more help. it seems like search doesn't return anything from my catalogue, but I have stuff in the catalogue so this is strange. |
| 11:40 | cait | what kind of installation are yo using? |
| 11:42 | kristebo | koha-docker, plack . it is a intallation of this https://github.com/digibib/koha-docker |
| 12:33 | tcohen joined #koha | |
| 12:33 | magnuse | kristebo: is zebra running? |
| 12:34 | try "sudu koha-restart zebra <instancename>" and "sudo koha-rebuild-zebra -f -v <instancename>" | |
| 12:40 | tcohen | hi |
| 12:40 | wahanui | bonjour, tcohen |
| 12:41 | abbfla66 joined #koha | |
| 12:42 | tcohen | magnuse: isn't it that if you don't pass -a or -b the result is nothing gets indexed? |
| 12:42 | ah, no | |
| 12:43 | magnuse | tcohen: with koha-rebuild-zebra? i think koha-rebuild-zebra does both by default |
| 12:43 | tcohen | you are right |
| 12:44 | oleonard joined #koha | |
| 12:45 | oleonard | Hi everyone |
| 12:45 | LibraryClaire | hello oleonard |
| 12:45 | cait | hello oleonard |
| 12:51 | eythian | hi oleonard |
| 12:51 | wahanui | hi oleopard |
| 12:53 | meliss joined #koha | |
| 12:53 | kmlussier joined #koha | |
| 13:19 | edveal | greetings all |
| 13:19 | LibraryClaire | hi edveal |
| 13:21 | edveal | hi libraryclaire |
| 13:25 | Dyrcona joined #koha | |
| 13:39 | fridolin left #koha | |
| 13:45 | LibraryClaire1 joined #koha | |
| 13:48 | rsantellan joined #koha | |
| 13:48 | nengard joined #koha | |
| 14:13 | JoshB joined #koha | |
| 14:28 | caboose_ joined #koha | |
| 14:36 | caboose_ | howdy, Michael Cabus, bws, Princeton New Jersey here |
| 14:40 | cait | hi caboose_ |
| 14:40 | :) | |
| 14:40 | welcom on #koha | |
| 14:40 | caboose_ | thanks! |
| 14:41 | oleonard | Hi caboose_ |
| 14:41 | tcohen | oleonard: https://snag.gy/u6oqYb.jpg |
| 14:41 | caboose_ | fairly new bws employee...but I contracted for a while; so excited to be here |
| 14:41 | tcohen | I'm about to remove the bullets when single values |
| 14:41 | do you have a better idea for differentiating different values for the repeatable attribute? | |
| 14:43 | deb-CSPL joined #koha | |
| 14:46 | LibraryClaire | hi caboose_ |
| 14:46 | caboose_ | hello! |
| 14:48 | drojf joined #koha | |
| 14:48 | tcohen | oleonard: https://snag.gy/pcAUN3.jpg |
| 14:49 | eythian | oleopard: https://snag.gy/pcAUN3.jpg |
| 14:50 | tcohen | heh |
| 14:50 | oleonard | tcohen: I think that looks good |
| 14:52 | barton joined #koha | |
| 14:52 | * magnuse | wishes #koha a nice weekend, then wanders off to make pizza |
| 14:52 | LibraryClaire | bye magnuse |
| 14:53 | * LibraryClaire | invites herself to magnuse's for dinner |
| 14:53 | magnuse | guten wochenende BüchereiKlara |
| 14:53 | LibraryClaire | danke :) |
| 14:53 | * magnuse | will send some in the post |
| 14:53 | LibraryClaire | :D |
| 14:58 | cait | have anice weekend magnuse |
| 15:00 | NateC joined #koha | |
| 15:01 | cait | oleonard: do you think the first table needs a heading too? |
| 15:02 | oleonard | Actually if anything I think the "additional attributes" heading could be removed. Does the librarian really care whether it's a "standard" or "extra" attribute? |
| 15:02 | Maybe they should all be in the same table. | |
| 15:07 | jac joined #koha | |
| 15:55 | meliss joined #koha | |
| 16:00 | reiveune | bye |
| 16:00 | reiveune left #koha | |
| 16:03 | rocio joined #koha | |
| 16:08 | kellym joined #koha | |
| 16:15 | caboose_ | hi kellym and rocio! |
| 16:15 | kellym | good morning caboose |
| 16:16 | rocio | hi! |
| 16:23 | TGoat joined #koha | |
| 16:32 | ericanderson joined #koha | |
| 16:32 | AndrewIsh | Hellooooo #koha! Does anyone happen to know the Devbox mysql root user password? |
| 16:32 | ericanderson | Hello also! Does anyone know of any dockerized images of Koha? |
| 16:33 | AndrewIsh | Paging tcohen :) |
| 16:34 | Cancel that page, the root mysql user doesn't have a password apparently. Should've tried that first... ;-) | |
| 16:34 | eythian | ericanderson: I know they exist, but I can't tell you any more than that. They also might be development only, but I'm not sure. |
| 16:36 | ericanderson | DevOps where are I work is trying to dockerize it and is having some issues, just wondering if there was something out there we could compare to. |
| 16:36 | Primarily with the user issues over the apache conf and processes | |
| 16:38 | docker be crazy | |
| 16:39 | eythian | sounds like configuration issues rather than docker issues :) |
| 16:40 | but, you're going to have to have to have a few daemons running which isn't really docker's wheelhouse (though you can do it.) | |
| 16:40 | It's on my list to build a docker swarm koha cluster thing one day, but I need to get my swarm networking working right first. | |
| 16:44 | cait left #koha | |
| 16:44 | Joubu | AndrewIsh: not sure there is one, I usually do: `sudo su -; mysql` |
| 16:44 | Erk, I did not read your last sentence.. | |
| 16:45 | AndrewIsh | Joubu: lol, not to worry. I just found it by trial and error ;-) |
| 16:46 | ericanderson | The docker issues we are having are coming from user contexts with Apache2 ITK MPM |
| 16:46 | which docker doesn’t like | |
| 16:47 | LibraryClaire | laters #koha |
| 16:48 | LibraryClaire left #koha | |
| 16:54 | eythian | ericanderson: I wouldn't deploy it in docker like that |
| 16:55 | I'd not use ITK | |
| 16:55 | you probably don't have the users defined in the container | |
| 16:55 | they're kinda a runtime configuration thing where you want entirely build time + an external database | |
| 16:55 | (not sure how you'll do zebra, I'd do it in its own container.) | |
| 16:55 | ericanderson | Would you write your own custom apache conf files? |
| 16:55 | eythian | yes |
| 16:56 | ericanderson | We also do need to use Zebra |
| 16:56 | eythian | perhaps pull them from templates with data that comes from the docker environment, or something along those lines. |
| 16:57 | * eythian | suggests building containers to build your containers :D |
| 16:58 | ericanderson | oh geez |
| 16:58 | lol | |
| 16:58 | eythian | (I actually do that for some work stuff, it means the build environment is self contained.) |
| 17:01 | any, if you're doing some form of clustering, I'd be inclined to have one configuration that gives you multiple images: opac, intranet, zebra. All the data for them is transient or can be built in. Though zebra will require a scripted rebuild on startup if it's not using persistant storage. | |
| 17:02 | (I think covers go into the database these days, not the filesystem.) | |
| 17:03 | ericanderson | the project is quite strange |
| 17:04 | we just need intranet and zebra | |
| 17:04 | * eythian | has to go for beer now for it is friday |
| 17:04 | jbeno joined #koha | |
| 17:05 | ericanderson | will elasticsearch be included an koha in the near-ish future? |
| 17:09 | eythian | Ish, yes |
| 17:09 | ericanderson | will some sort of search api be exposed with it? |
| 17:18 | tcohen | hi |
| 17:19 | rsantellan joined #koha | |
| 17:28 | ericanderson_ joined #koha | |
| 17:40 | kchris joined #koha | |
| 17:52 | CrispyBran joined #koha | |
| 18:34 | laurence left #koha | |
| 19:21 | mtompset joined #koha | |
| 19:21 | mtompset | Greetings, #koha. |
| 19:21 | @seen kidclamp | |
| 19:21 | huginn | mtompset: kidclamp was last seen in #koha 8 hours, 28 minutes, and 29 seconds ago: <kidclamp> :-) |
| 19:21 | * kidclamp | waves |
| 19:21 | mtompset | I was looking at bug 17995 |
| 19:21 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=17995 normal, P5 - low, ---, nick, Needs Signoff , HOLDPLACED notice should have access to the reserves table |
| 19:22 | mtompset | And it got me thinking.... |
| 19:22 | there seems to be a lot of code that is biblionumber/borrowernumber | |
| 19:22 | but the holds id was recently added. | |
| 19:23 | kidclamp | kk |
| 19:23 | mtompset | I mean reserve_id |
| 19:23 | So, while your patch may work, isn't there some underlying code rot? | |
| 19:24 | (haven't tested it yet, just reading code first) | |
| 19:24 | kidclamp | meaning I should be passing the reserve_id instead of the entire hold? |
| 19:24 | or should be able to | |
| 19:24 | mtompset | that's what I was initially expecting, but then realized that whole historical mess. |
| 19:25 | So, passing just the pk might not be as quick and easy. | |
| 19:25 | kidclamp | yeah, I tried the pk first, it didn't work, I started digging, got lazy, and just made it work |
| 19:25 | * mtompset | cackles. |
| 19:25 | mtompset | Caught you! :P |
| 19:26 | kidclamp | but seriously, a reserveslip with no access to reserves? come on! who does that? |
| 19:26 | needs a fix | |
| 19:26 | mtompset | I know. |
| 19:26 | But I really don't like the whole unblessed() thing. | |
| 19:27 | kidclamp | unblessed doesn't mean they are evil, just not holy |
| 19:27 | mtompset | I know, but if you have to unblessed, there is something more fundamentally wrong. |
| 19:28 | That's kind of why I was mentioning the underlying code rot. | |
| 19:28 | kidclamp | you are welcome to fix :-) |
| 19:28 | mtompset | You're killing me! I'm as lazy as you. :P |
| 19:28 | kidclamp | so just sign off, close your eyes and walk away |
| 19:29 | then Joubu can rake me over the coals for laziness | |
| 19:29 | * mtompset | laughs. |
| 19:29 | mtompset | Man, you are giving my belly exercise. :P |
| 19:30 | Though, the whole don't use unblessed came from tcohen on another bug I was reading. :P | |
| 19:32 | kidclamp | I can understand if you fail it, I don't promise to fix it soon though |
| 19:32 | that whole code is still not clear to me | |
| 19:38 | tcohen | mtompset: what did I say about unblessed? |
| 19:40 | BTw if you have the whole object already, why not pass it? :-D | |
| 19:41 | mtompset | Because it is expecting a hash, and the unblessing does that. |
| 19:41 | tcohen: Don't make me go looking. My memory is shot. :P | |
| 19:42 | bug 17992 | |
| 19:42 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=17992 minor, P5 - low, ---, tomascohen, Needs Signoff , REST api: Cities controller should not use ->unblessed |
| 19:43 | tcohen | mtompset: the bug subject does not apply to ANY context |
| 19:43 | context for it is the REST api | |
| 19:43 | and specifically controller scripts | |
| 19:44 | mtompset | oh, come on. Let me conflate it. :P |
| 19:44 | (I think that's the right word) | |
| 19:45 | tcohen | bug 17932 extends Koha::Object with a TO_JSON function that adapts the unblessed version of the object so it is correctly processed by Perl JSON parser libraries |
| 19:45 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=17932 enhancement, P5 - low, ---, tomascohen, Signed Off , Koha::Object should provide a TO_JSON method |
| 19:50 | tcohen | have a nice weekend, #koha |
| 19:50 | mtompset | You too, tcohen |
| 19:51 | Have a great day (24 hour period), #koha tcohen kidclamp | |
| 19:59 | oleonard | Happy weekend, #koha |
| 20:18 | cait joined #koha | |
| 21:01 | alexbuckley joined #koha | |
| 21:02 | eythian | liw: there's now a chance I'll be going on Sunday. Can you PM me contact info? |
| 21:24 | alexbuckley joined #koha | |
| 21:30 | kmlussier joined #koha | |
| 22:08 | JoshB left #koha | |
| 23:55 | Francesca joined #koha |
← Previous day | Today | Next day → | Search | Index