← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
Time | Nick | Message |
---|---|---|
00:08 | JoshB joined #koha | |
01:22 | Francesca joined #koha | |
01:23 | kathryn joined #koha | |
01:54 | Francesca joined #koha | |
02:19 | aleisha joined #koha | |
03:13 | trea joined #koha | |
03:52 | irma joined #koha | |
04:12 | irma_ joined #koha | |
04:23 | mario joined #koha | |
06:10 | mveron joined #koha | |
06:14 | mveron | Good morning / daytime #koha |
06:15 | pianohacker ++ for Bug 14931 | |
06:15 | huginn` | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=14931 enhancement, P5 - low, ---, veron, Signed Off , Remove C4::Dates from files admin/aq*.pl |
06:17 | mveron | 8 sign-offs left for getting rid of C4::Dates, 3 signed-off, 19 pushed... |
06:59 | putti joined #koha | |
07:04 | magnuse joined #koha | |
07:04 | * magnuse | waves |
07:08 | * mveron | waves back |
07:08 | putti | Hi all :) |
07:12 | liz joined #koha | |
07:12 | laurence joined #koha | |
07:13 | mveron | Hi putti :-) |
07:24 | Viktor joined #koha | |
07:24 | magnuse | hiya mveron putti and Viktor |
07:24 | mveron | hiya magnuse |
07:24 | Viktor | Hi magnuse |
07:25 | mveron | and hi everybody :-) |
07:25 | putti | Previously this code was done so that all the 100 line long things were just inside the elsifs: http://paste.koha-community.org/145. I'll go with changing them to subroutine calls (i'll still add the parameters, and change maybe the routines to other module), is it the way to go? |
07:28 | oh, and I think cait said yesterday that the refactoring should start with small steps so I think putting things to subroutines is a good start and then after that it's easier for us to spot the code duplications etc... | |
07:33 | magnuse | putti: sounds like a plan to me, but i'm no expert. everyone will be happy if those new subs come with tests, i think |
07:37 | putti | magnuse, to get the tests, we need to change all the subs to a new module but that was also the grand plan. I guess there wonbe such a radical change even if we do so. Maybe it's even easier to review the code if the subroutines are in their own mod.! Thanks for the tip :) |
07:37 | *won't be | |
07:37 | reiveune joined #koha | |
07:38 | fridolin joined #koha | |
07:39 | reiveune | hello |
07:39 | putti | reiveune, hi :-) |
07:39 | reiveune | hi :) |
07:45 | magnuse | putti: yeah, don't put new subs in .pl files |
07:52 | putti | Does this new perl module look alright: http://paste.koha-community.org/146 ? Never done one so I have no clue, just tried to mimic the other modules :P |
07:53 | (I'll add of course documentation etc.) | |
07:55 | Joubu | hi |
07:55 | putti | Joubu, Hey |
07:55 | alex_a joined #koha | |
07:55 | alex_a | bonjour |
07:56 | sophie_m joined #koha | |
07:57 | ashimema joined #koha | |
08:01 | mveron | Bonjour Joubu and alex_a |
08:02 | jajm | hello |
08:02 | wahanui | hola, jajm |
08:02 | magnuse | putti: C4::issuingrules should be C4::Issuingrules or C4::IssuingRules; |
08:03 | make sure you change this line Copyright 2000-2002 Katipo Communications | |
08:03 | make sure the last thing in the file is "1;" | |
08:04 | putti | ok, thanks |
08:04 | magnuse | those are the things that strike me first :-) |
08:05 | Joubu | putti: Koha::IssuingRules would even be better, using Koha::Objects |
08:05 | cait joined #koha | |
08:06 | putti | Joubu, small steps :D |
08:07 | cait | @later tell tcohen ping me when you are around please? |
08:07 | huginn` | cait: The operation succeeded. |
08:07 | magnuse joined #koha | |
08:07 | cait | morning magnuse |
08:07 | morning #koha of course too :) | |
08:07 | putti | Joubu, but it would be better that the issuing rules is under Koha? |
08:08 | Joubu | Should be OO and covered by tests, that the requirements |
08:09 | cait | Joubu: using Koha::Object? |
08:09 | Joubu | cait: ? |
08:11 | I suggested putti to make his Class inherited from Koha::Objects | |
08:12 | cait | ah sorry, missed that part |
08:12 | i will be quiet | |
08:13 | putti | so what i'm gonna do now is: mv C4/IssuingRules.pm Koha/IssuingRules.pm and then inherit it from Koha::Objects, right? |
08:16 | Francesca joined #koha | |
08:16 | putti | What's the difference between c4 and koha? |
08:17 | Joubu | putti: just what I said: Should be OO and covered by tests, that the requirements |
08:17 | putti | Joubu, but the file should also be somewhere :P |
08:17 | Joubu | inherits from Koha::Objects is not a requirement |
08:18 | putti | C4 vs. Koha |
08:18 | Joubu | http://wiki.koha-community.org[…]_Koha::_namespace |
08:19 | " Modules in the Koha:: namespace should not reference the C4:: namespace, with the exception of C4::Context. " > This is not always true | |
08:20 | putti | Kk |
08:23 | magnuse | putti: C4:: is old code, Koha:: is where new code should go, and it should follow some stricter guidelines than the code in C4 |
08:27 | gaetan_B joined #koha | |
08:27 | gaetan_B | hello |
08:27 | wahanui | privet, gaetan_B |
08:30 | cait | morning |
08:31 | burdsjm joined #koha | |
08:33 | fridolin | hie there |
08:33 | Joubu: very nice job on Bug 14722 | |
08:33 | huginn` | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=14722 enhancement, P5 - low, ---, jonathan.druart, Pushed to Master , Refactor the export tool |
08:33 | fridolin | Joubu: i see there is a script misc/exportauth.pl |
08:34 | is it then obsoelete ? looks like it is very old | |
08:34 | hyvaria joined #koha | |
08:36 | Joubu | fridolin: I have never seen it... |
08:40 | magnuse | not a good sign :-) |
08:42 | fridolin | Joubu: I open a bug to remove it |
08:43 | no need to have duplicated scripts | |
08:43 | Joubu | an email to koha-devel about that would be good |
08:45 | ashimema joined #koha | |
08:47 | Joubu | fridolin: did you see the email about koct on the ml? |
08:52 | jajm | ashimema, hi |
08:52 | fridolin | Joubu: ah not uet |
08:53 | yet | |
08:53 | Joubu | fridolin: I have just answered |
08:53 | fridolin | Joubu: whats the title please ? |
08:53 | wahanui | the title is probably right in the breadcrumbs |
08:53 | Francesca | @wunder wlg |
08:53 | huginn` | Francesca: The current temperature in Wellington, New Zealand is 14.0°C (9:30 PM NZDT on October 28, 2015). Conditions: Overcast. Humidity: 94%. Dew Point: 13.0°C. Pressure: 29.80 in 1009 hPa (Steady). |
08:54 | Joubu | last email on the koha ml |
08:55 | fridolin | Joubu: found |
08:55 | jajm | ashimema, Tomas won't push bug 13799 since it depends on Perl modules not packaged in Debian yet... and this is not likely to happen in the next few days I think, so I suggest moving the last 4 patches into their own bug, so we can push 13799 now. What do you think ? |
08:55 | huginn` | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13799 new feature, P5 - low, ---, julian.maurice, Passed QA , Add base for building RESTful API |
08:56 | mveron | Joubu ++ for Bug 14931 :-) |
08:56 | huginn` | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=14931 enhancement, P5 - low, ---, veron, Passed QA , Remove C4::Dates from files admin/aq*.pl |
09:01 | Joubu | @later tell tcohen xt/author/valid_templates.t on D7 fixes with last patch on 14100 |
09:01 | huginn` | Joubu: The operation succeeded. |
09:05 | atheia joined #koha | |
09:05 | atheia | Good morning |
09:05 | wahanui | the only good morning is a dead one |
09:05 | atheia | cynical, wahanui, very cynical :-) |
09:05 | Joubu | @later tell tcohen AI still differ on biblio and biblioitems on D7, something weird there :-/ |
09:05 | huginn` | Joubu: The operation succeeded. |
09:06 | Joubu | @later tell tcohen D7 is it the one where a new DB is created before each run? (could come from the original DB!) |
09:06 | huginn` | Joubu: The operation succeeded. |
09:06 | * magnuse | always reads AI as artificial intelligence... |
09:10 | Viktor joined #koha | |
09:12 | Joubu | @later tell tcohen another one on 14100 |
09:12 | huginn` | Joubu: The operation succeeded. |
09:13 | cait | what is AI? |
09:15 | Joubu | Auto Increment |
09:15 | cait | aah ok |
09:22 | putti | What am I missing: "DBIx::Class::Schema::source(): Can't find source for IssuingRule" |
09:23 | paul_p joined #koha | |
09:23 | putti | I'm calling it like this: Koha::IssuingRules->search({ itemtype => "VM" }) |
09:23 | And I have created the objects IssuingRule and IssuingRules | |
09:26 | Got it working: the schema was written without camel case. | |
09:53 | liz | does anybody know what this is about? [Wed Oct 28 23:09:39.211082 2015] [cgi:error] [pid 12620] [client 10.32.0.14:58446] AH01215: [Wed Oct 28 23:09:39 2015] search.pl: CGI::param called in list context from package main line 407, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://wwlib01.opus.co.nz:82/c[…]earch.pl?q=things |
09:54 | searches return no results, but searches work from yaz | |
09:56 | cait | on master? |
09:57 | liz | no, 3.20.4 |
09:57 | this was an upgrade from 3.14 | |
09:58 | I've done all the dom conversions (but maybe I missed something?) reindexed and restarted zebra | |
09:58 | idk what else to try | |
09:59 | cait | anytthing on the about.pl page? |
09:59 | liz | nope |
09:59 | cait | did you have to switch to dom in the process? |
09:59 | liz | not sure what you mean |
09:59 | yes, I had to change the files for dom | |
09:59 | cait | switching the indexing from grs-1 to dom |
09:59 | but nothing ont he about.pl hm. | |
10:00 | search in opac and staff not working? | |
10:00 | liz | "you are logged in as the database admin user" |
10:00 | neither works :( | |
10:00 | but searches work from yaz | |
10:02 | i'ave probably missed something I'll go back through it all | |
10:12 | fridolin joined #koha | |
10:14 | Joubu | @later tell tcohen, found something crazy. The test t/db_dep/Search.t fails with "DBI bind_columns: invalid number of arguments: got handle + 0, expected handle + between 1 and -1". Don't know why. But if I comment l.54 of the test files: 54 "#system("zebraidx [...] commit" I don't get this error ... |
10:14 | huginn` | Joubu: The operation succeeded. |
10:19 | cait | liz: sorry, no idea really :( |
10:19 | liz | yeah sok |
10:52 | atheia joined #koha | |
11:09 | drojf joined #koha | |
11:09 | drojf | hi #koha |
11:41 | magnuse | moin drojf |
11:41 | drojf | hei magnuse |
11:42 | meliss joined #koha | |
11:44 | nengard joined #koha | |
11:44 | liz | bleh this is baking my noodle. |
11:44 | nengard | morning wizzyrea |
11:44 | sorry your noodle is baked | |
11:44 | wizzyrea_the_very_tired | meh. |
11:45 | have you had koha's that wouldn't get results after a particularly epic upgrade? | |
11:45 | I just did a 3.14 -> 3.18 and now zebra is apparently stupid. | |
11:45 | fridolin joined #koha | |
11:46 | wizzyrea_the_very_tired | no, 3.14 -> 3.20 |
11:46 | nengard | I have not - but i bet larry has - he's just not awake yet |
11:46 | need to log off to upgrade - brb | |
11:46 | nengard left #koha | |
11:51 | cait | wizzyrea: di you reindex? |
11:51 | and any errors there? | |
11:54 | wizzyrea_the_very_tired | I have, many times |
11:54 | no errors, it's sad. | |
11:54 | if I connect to it with yaz, it works | |
11:54 | cait | did you check queryparser and opacsuppression settings? |
11:54 | wizzyrea_the_very_tired | queryparser |
11:54 | wahanui | i think queryparser is working on the VM though :D |
11:54 | wizzyrea_the_very_tired | I did not, in fact, check that. |
11:54 | jcamins | wizzyrea_the_very_tired: are biblio_indexing_mode and auth_indexing_mode set? |
11:54 | cait | guessing wildly... but maybe |
11:54 | wizzyrea_the_very_tired | yep |
11:55 | jcamins | Oh well. |
11:55 | * jcamins | is out of ideas. |
11:55 | jcamins | It seemed like a reasonable theory. |
11:55 | wizzyrea_the_very_tired | hm, I haven't ever had to deal with query parser |
11:55 | cait | is it off? |
11:56 | the syspref for it? | |
11:57 | wizzyrea_the_very_tired | it was off, but turning it on didn't change anything |
11:57 | I checked opacsuppression | |
11:57 | cait | i#d leave it off |
11:57 | wizzyrea_the_very_tired | I turned off zebra facets, just to see |
11:57 | yeah I turned it back off | |
11:57 | cait | hm logs... what do the logs say when you search? |
11:58 | wizzyrea_the_very_tired | query params in a list context errors, I don't think they're related |
11:58 | otherwise everybody in the world would have this problem | |
12:03 | magnuse | yeah, probably not related |
12:04 | wizzyrea_the_very_tired: using memcached? | |
12:04 | wizzyrea_the_very_tired | no, not even installed, no config options for it |
12:04 | magnuse | ok |
12:04 | wizzyrea_the_very_tired | good question though |
12:05 | thank you all for having a think about it <3 | |
12:05 | magnuse | you tried restarting zebra of course? |
12:05 | wizzyrea_the_very_tired | yeah, many times |
12:06 | magnuse | fun fun fun |
12:07 | drojf | have you killed zebra? not sure if the bug still applies where zebra is not really restarted? |
12:07 | magnuse | did you toggle the ShowNoSearchResults setting? ;-) |
12:07 | cait | oh yeah |
12:07 | restarting the zebra | |
12:07 | wizzyrea_the_very_tired | seems like this shouldn't kill it but it's about all that's left |
12:07 | Error exporting record 18720 (biblio) XML at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 536. | |
12:07 | ... specific error is invalid XML: :39: parser error : PCDATA invalid Char value 21 | |
12:07 | <subfield code="o">BS 6068: Section 2.23:1986 1986</subfield> | |
12:08 | yeah I've force killed the zebras until there were no zebras left then birthed a new one | |
12:08 | :) | |
12:08 | cait | hm that record |
12:08 | magnuse | lulz |
12:08 | drojf | lol |
12:09 | wizzyrea_the_very_tired | i mean it's one funked out record in 30k of them |
12:09 | surely, surely that wouldn't mess up results it's not even returned in? | |
12:09 | Joubu | @later tell tcohen HEEEEELLLPPPP |
12:09 | huginn` | Joubu: The operation succeeded. |
12:09 | Joubu | :) |
12:11 | magnuse | wizzyrea_the_very_tired: i'd try and fix it and see what happens anyway |
12:12 | wizzyrea_the_very_tired | yeah just gotta get to it |
12:17 | khall joined #koha | |
12:17 | nengard joined #koha | |
12:22 | sophie_m joined #koha | |
12:25 | wizzyrea_the_very_tired | blarg there are no errors anywhere now |
12:25 | wtaf. | |
12:33 | tcohen joined #koha | |
12:35 | tcohen | morning! |
12:35 | cait | morning tcohen! |
12:40 | magnuse | morning tcohen! |
12:40 | wizzyrea_the_very_tired: gotta be something too obvious then | |
12:41 | are you sure you have been reindexing etc the same instance you are searching? that type of thing... | |
12:41 | wizzyrea_the_very_tired | yeah, there's only one |
12:41 | magnuse | dang :-) |
12:42 | wizzyrea_the_very_tired | I had to move from grs to dom, I must have missed something but I can't see what |
12:42 | tcohen | cait: ping |
12:42 | hi Joubu | |
12:42 | wizzyrea_the_very_tired | you'd think if I had an actual syntax error or bad path, it would just not work |
12:42 | there would be an error somewhere | |
12:43 | tcohen | wizzyrea_the_very_tired: I arrived late, whatsup? |
12:43 | wizzyrea_the_very_tired | I have a fussy indexer. |
12:43 | and a fussy me. | |
12:43 | :P | |
12:43 | magnuse | i had some strangeness happening once, where koha-conf.xml was not valid xml |
12:43 | tcohen | elaborate? |
12:43 | wizzyrea_the_very_tired | hrm. |
12:43 | * wizzyrea_the_very_tired | chucks it in a validator |
12:43 | tcohen | wizzyrea_the_very_tired: nevermind, I'll read the log |
12:44 | wizzyrea_the_very_tired | no, that's ok |
12:45 | magnuse | gah |
12:45 | wizzyrea_the_very_tired | i just upgraded from 3.14->3.20, moved from grs to dom, and I can't for the life of me get results |
12:45 | to turn up | |
12:45 | nothing especially alarming in the upgrade log, no errors anywhere | |
12:45 | magnuse | can you see the detail view when you look at opac-detail.pl?biblionumber=x |
12:45 | wizzyrea_the_very_tired | yep |
12:46 | yeah, the records are there I checked :) | |
12:46 | the frameworks validate afaict | |
12:47 | yaz can search the indices | |
12:48 | ls | |
12:48 | oops | |
12:48 | magnuse | http://wiki.koha-community.org[…]bleshooting_Zebra ? |
12:48 | wizzyrea_the_very_tired | yeah, none of those things are this thing. Usually the thing that fixes this is "reindex and make sure the perms are right" and they are, and I have it's so annoying. |
12:49 | it's a very freshly upgraded, all the way up to date jessie install | |
12:49 | drojf | rebuild-zebra question: what is the use case of the noxml option? and what are the possible side effects? |
12:50 | if iunderstand correctly, it does not write to biblioitems.marcxml, just biblioitems.marc. but why? | |
12:50 | magnuse | wizzyrea_the_very_tired: tried http://wiki.koha-community.org[…]Watching_Zebrasrv ? |
12:50 | drojf: because it's fun? | |
12:50 | drojf | magnuse: marc is never fun |
12:51 | magnuse | true |
12:51 | jcamins | drojf: I think you've misunderstood. |
12:51 | The idea behind noxml is to use binary MARC when indexing. | |
12:51 | Koha requires the marcxml to be stored. | |
12:52 | Most obvious issue: large records will break things. | |
12:54 | wizzyrea_the_very_tired | magnuse++ I have no idea what the error means, but it's an error that means I can look it up. or something |
12:54 | Init ERROR 1011 ID:81 Name:ZOOM-C/YAZ Version:4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 for the curious | |
12:54 | drojf | jcamins: and why would anyone want to use binary marc for indexing then? speed? size? or just because it is an option zebra offers? |
12:55 | jcamins: and yes, i was wondering what koha would do without the xml :) | |
12:55 | wizzyrea_the_very_tired | oh. oh my gosh. |
12:55 | I know what the problem is. | |
12:55 | everybody++ | |
12:56 | drojf | logged in to the wrong machine? :P |
12:56 | jcamins | drojf: speed and coolness. |
12:56 | talljoy joined #koha | |
12:56 | Joubu | hi tcohen |
12:57 | jcamins | wizzyrea_the_very_tired: what was the problem? Don't leave us in suspense! |
12:57 | drojf | jcamins: heh. thanks! |
12:57 | jcamins++ | |
12:58 | wizzyrea_the_very_tired | so. |
12:58 | my preferred way of updating a koha-conf is kind of dumb, basically I create an instance on my workstation that's running the same version of the packages, then copy the config files. When you do that, you have to swap out the passwords | |
12:58 | and I missed the one for the biblioserver >.< | |
12:59 | (oh and also you merge in any configs like ldap and anything else special) | |
12:59 | magnuse++ excellent suggestion | |
13:00 | Dyrcona joined #koha | |
13:00 | drojf | ouch |
13:00 | wizzyrea_the_very_tired | drojf: no, I was not logged into the wrong machine ;) |
13:00 | drojf | wizzyrea_the_very_tired: no, your problem was much cooler :) |
13:01 | wizzyrea_the_very_tired | I'd really like an include system for koha-conf >.< |
13:01 | tcohen | wizzyrea_the_very_tired: the passwords are not that important |
13:02 | wizzyrea_the_very_tired | can't tell if serious or sarcasm >.> |
13:02 | but, all the same thank you all for your attentions | |
13:02 | you can go about your day knowing you've kept a library in NZ searching happily on an upgraded version of Koha. | |
13:03 | JoshB joined #koha | |
13:04 | wizzyrea_the_very_tired | have a lovely time-of-day I may see you again in too few hours. |
13:04 | drojf | jcamins: can you also enlighten me how noxml relates to -x which sounds to me like the opposite? |
13:05 | "export and index as xml instead of is02709 (biblios only). use this if you might have records > 99,999 chars," or is that another kind of iso marc? | |
13:05 | tcohen | drojf: we changed the default |
13:06 | drojf | tcohen: so xml is now the default but the xml parameter is still there? |
13:06 | tcohen | so noxml is the way to make rebuild_zebra.pl pass usmarc-serialized data to zebraidx |
13:06 | drojf: yes | |
13:06 | drojf | ah, i see. thanks! |
13:06 | tcohen | drojf: as some template files that are not used anymore heh |
13:06 | * tcohen | finds that things daily |
13:15 | cait | we are getting better |
13:18 | magnuse | JesseM! |
13:18 | wahanui | jessem is, like, new to the committers list (from yesterday) |
13:19 | magnuse | good on him! |
13:19 | edveal joined #koha | |
13:21 | JesseM | HI |
13:21 | :) | |
13:28 | mtompset joined #koha | |
13:28 | mario joined #koha | |
13:28 | mtompset | Greetings, #koha. |
13:28 | Has everyone made it safely home from KohaCon 2015? :) | |
13:31 | cma joined #koha | |
13:33 | * cait | feels ignored by tcohen |
13:33 | nengard | :( |
13:33 | magnuse | :-( |
13:34 | mtompset | There there. tcohen still loves us all. |
13:34 | cait | but he is not answering his PM! :) |
13:35 | mtompset | How many PM vectors did you use? just IRC, or did you include text message, facebook, email, etc. etc? ;) |
13:36 | Personally, I wish bkg was here, so I could real-time message him about bug 15053. :) | |
13:36 | huginn` | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=15053 major, P5 - low, ---, kyle.m.hall, Needs Signoff , sample_creator_data.sql now fails during a fresh install |
13:36 | cait | bkg? |
13:36 | wahanui | well, bkg is making it hard to stay on top for April sign offs. :) |
13:36 | cait | oh |
13:36 | bkriegel | |
13:36 | mtompset | Yes... sorry for the typo. |
13:37 | cait | i just didn't make the connection |
13:37 | mtompset | And with his patches on that bug... I am worried our Polish files are well... dated and no one has patched them. |
13:38 | I have yet to confirm fully. | |
13:38 | But he missed ru and uk. | |
13:38 | cait | people often do for some reason |
13:38 | i'd note it on the bug | |
13:38 | the file structure for them is a bit different - did you check they include sample data? | |
13:39 | mtompset | cait... the french has labels_t... instead of creator_t... |
13:39 | so I just went looking for label_t and found ru and uk busted the same way. | |
13:39 | cait | yeah, things like that make it harder |
13:40 | mtompset | when a language community doesn't bug report, things don't get fixed. :( |
13:41 | cait | i had someone having problems with the polish installer files a whie back on irc |
13:41 | but we didn't get much further than that installing it again with en helped the problems | |
13:41 | it seemed that permissions were broken (userflags, etc.) | |
13:41 | not sure if we fixed that since hm. | |
13:41 | mtompset | And there in is the problem... we have language specific installer files. |
13:42 | cait | yes |
13:42 | and currently we stil need them | |
13:42 | but at least we started to improve a bit - like moving out the language and permission files for this release | |
13:42 | mtompset | we need the language presentation and language data removed from the installation process, so that ANY language will get the right files/data. |
13:43 | I try to avoid localization issues, because they make me cranky. Me and my anglo-centric ways. :) | |
13:52 | NateC joined #koha | |
13:52 | amyk joined #koha | |
13:55 | nengard | updating the manual and have a question about RestrictedPageLocalIPs if anyone knows - the pref says 'ip addresses beginning with' does that mean I can just put the start of the IP or do I need a star or something? |
13:55 | cait | drojf: ^ |
13:56 | http://bugs.koha-community.org[…]_bug.cgi?id=13485 testplan says without a star | |
13:56 | huginn` | 04Bug 13485: new feature, P5 - low, ---, maxime.beaulieu, Pushed to Master , Add a page to display links to restricted sites |
13:56 | cait | just the beginning |
13:57 | nengard | thanks cait |
13:57 | i missed that part | |
13:57 | off to update the manual | |
14:02 | cait | I interpreted the example... but i hope it's right :) |
14:03 | drojf | cait: ? |
14:03 | cait | there was a questiona bout your feature earlier |
14:04 | drojf | which one? |
14:04 | cait | (14:55:08) nengard: updating the manual and have a question about RestrictedPageLocalIPs if anyone knows - the pref says 'ip addresses beginning with' does that mean I can just put the start of the IP or do I need a star or something? |
14:04 | hm maybe not yours | |
14:04 | drojf | no it's not :) |
14:04 | cait | confused it with the ohter |
14:04 | the one for opacsuppression | |
14:04 | drojf | you mean the opacsuppression |
14:04 | yes | |
14:04 | but the answer seems the same | |
14:04 | :) | |
14:05 | cait | at least :) |
14:05 | nengard | drojf youtube? ;) |
14:06 | drojf | nengard: the patch was lost and i started redoing it. had no time to finish it yet, sorry |
14:06 | but i have not forgotten about it :) | |
14:07 | nengard | hehe |
14:07 | drojf++ | |
14:10 | cait | hm |
14:10 | 3.18 question | |
14:10 | cliking print list opens a new tab | |
14:10 | with the same - just a print=1 parameter | |
14:10 | but print preview looks the same for both *confused* | |
14:10 | and 13986 deosn't appear to be in 3.18.8 | |
14:10 | bug 13986 | |
14:10 | huginn` | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=13986 normal, P5 - low, ---, kyle, Pushed to Master , Printing a list only prints the results of the page you are viewing |
14:11 | mtompset_ joined #koha | |
14:13 | nengard | another manual question |
14:13 | FeeOnChangePatronCategory is under norwegian patron database | |
14:14 | but it looks like it's a koha pref | |
14:14 | cait | it's a bug |
14:14 | nengard | meaning koha categories not the norwegian prefs |
14:14 | thank you!! | |
14:14 | :) | |
14:14 | cait | i think it#s noted on the bug report - but might be good to open a separate one |
14:14 | probably a mistake when editing the yaml file | |
14:14 | missing the heading | |
14:16 | nengard | cait http://bugs.koha-community.org[…]_bug.cgi?id=15073 |
14:16 | huginn` | 04Bug 15073: major, P5 - low, ---, nengard, ASSIGNED , FeeOnChangePatronCategory in wrong place |
14:16 | nengard | I'm working on it |
14:16 | cait | thx |
14:20 | xarragon | with Koha::Objects, does it make sense to move insert/delete/update table logic from what would normally be a C4 module into a Koha object instead? |
14:21 | cait | there are some samples for those things... maybe look at the modules that Jonathan has switched to koha object already |
14:21 | i think... i tested cities | |
14:21 | but there should be more | |
14:21 | xarragon | Yes, I was looking at some a while back but maybe there is more. Thanks. |
14:26 | laurence joined #koha | |
14:30 | amyk_ joined #koha | |
14:32 | amyk_ joined #koha | |
14:33 | cait | xarragon: i think some more has been pushed since |
14:34 | xarragon: lots of changes right now - another for bibliographic frameworks is sitting in the qa queue (signed off) | |
14:34 | tcohen: ping! | |
14:35 | amyk joined #koha | |
14:37 | magnuse | gah, dinnertime. just when is start to figure things out |
14:47 | rocio joined #koha | |
14:52 | fridolin joined #koha | |
14:52 | fridolin left #koha | |
14:57 | nengard left #koha | |
15:00 | nengard joined #koha | |
15:02 | huginn joined #koha | |
15:03 | gmcharlt joined #koha | |
15:05 | tcohen | cait: pong |
15:07 | TGoat joined #koha | |
15:07 | nengard | got an easy bug for sign off |
15:07 | http://bugs.koha-community.org[…]_bug.cgi?id=15073 | |
15:07 | huginn | 04Bug 15073: major, P5 - low, ---, nengard, Needs Signoff , FeeOnChangePatronCategory in wrong place |
15:08 | nengard | I'm going to document it as if it's fixed :) |
15:09 | alex_a joined #koha | |
15:14 | mtompset | SHOOT! |
15:14 | Upload MARC is busted. | |
15:16 | Stage MARC for import... broken! | |
15:18 | nengard | uh oh |
15:18 | that's not good at all | |
15:23 | mtompset | checking... might be my switching branches and not updating database. |
15:25 | *whew* that was likely the case. | |
15:27 | tcohen | mtompset: are you talking about Plack ? |
15:28 | mtompset | Nope... tcohen I'm not touching plack. |
15:28 | dani joined #koha | |
15:28 | mtompset | too hard to do testing on it in a way I like. |
15:28 | drojf | are the ES tests out of date or am i really missing something? "Can't locate Koha/ElasticSearch/Search.pm in @INC (you may need to install the Koha::ElasticSearch::Search module)" |
15:29 | tcohen | drojf: is that the catalyst branch? |
15:29 | drojf | yes |
15:29 | * tcohen | breathes |
15:30 | drojf | there is also "Can't locate object method "convert_marc_to_json" via package "Koha::ElasticSearch::Indexer" at t/Koha_ElasticSearch_Indexer.t line 46." |
15:30 | tcohen: why? did you push ES stuff? | |
15:30 | tcohen | nope, but imagine my reaction if tests start failing and talk about ES, on the master branch! |
15:31 | drojf | heh |
15:31 | ES is not making it in 3.22, is it? | |
15:33 | Joubu | no |
15:37 | drojf: it seems that the test file is buggy yes | |
15:38 | mveron joined #koha | |
15:39 | mveron | Hi again |
15:39 | Joubu | drojf: how did you get the first error? |
15:39 | opac/elasticsearch.pl is not used actually | |
15:49 | drojf | Joubu: that was Failed test 'use Koha::ElasticSearch::Search;' at t/Koha_ElasticSearch_Search.t line 23. Tried to use 'Koha::ElasticSearch::Search'. |
15:50 | Joubu | yes, tests are not maintained |
15:50 | drojf | i tried to build a package actually |
15:50 | can i make the build process skip certain tests? | |
15:51 | Joubu | git fetch catalyst; git checkout es catalyst/elastic_search; perl installer/.../updatedatabase.pl would do the job :) |
15:51 | with the missing -b | |
15:52 | pianohacker joined #koha | |
15:53 | drojf | oh my repo is just too old? |
15:53 | Joubu | drojf: you don't need to launch the tests |
15:53 | why do you want to? | |
15:53 | drojf | it's done automatically with build-git-snapshot |
15:54 | Joubu | maybe git rm them before? |
16:00 | bye #koha | |
16:01 | NateC | amyk: I closed that ticket out |
16:02 | drojf | oh the mapping.sql is now obsolete? nice |
16:02 | Joubu | drojf: I have rewritten the mappings config, yes |
16:03 | drojf | Joubu++ |
16:03 | cait | Joubu++ indeed |
16:03 | ... may will be soon, maybe we can manage until then | |
16:04 | drojf | gotta leave. later #koha |
16:07 | NateC | tgoat skype |
16:07 | ? | |
16:07 | TGoat | phone |
16:07 | amyk-lunch | thanks natec |
16:07 | why are you typing in koha channel? ;-) | |
16:08 | NateC | because i like it here :) |
16:08 | amyk-lunch | ah cool! :-) |
16:15 | pianohacker | hi #koha! |
16:18 | achylles joined #koha | |
16:26 | cait left #koha | |
16:27 | * mveron | ...has to run |
16:44 | reiveune | bye |
16:44 | reiveune left #koha | |
16:45 | drojf joined #koha | |
16:53 | gaetan_B | bye |
17:01 | cbrannon | Is there a mechanism in place to limit certain bibs to item level holds? Particularly bibs for serials. |
17:05 | It's too quiet. | |
17:18 | wahanui: | |
17:18 | wahanui | cbrannon: huh? |
17:18 | pianohacker | heh. cbrannon: I don't think so, I think it's doable with jquery tho |
17:24 | cbrannon | Probably. Just don't want to reinvent the wheel if I'm just missing something. |
17:36 | laurence left #koha | |
17:39 | JoshB_ joined #koha | |
17:49 | cdickinson joined #koha | |
18:13 | magnuse joined #koha | |
18:19 | * magnuse | waves |
18:23 | magnuse | then recites a rowdy viking song to break the silence ;-) |
18:39 | tcohen | wow, lots of volunteers :-D |
19:15 | CPBrannon joined #koha | |
19:15 | CPBrannon | bug 14694 |
19:15 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=14694 enhancement, P5 - low, ---, kyle.m.hall, Signed Off , Make decreaseloanHighHolds more flexible |
19:15 | CPBrannon | Ready for QA? |
19:21 | achylles joined #koha | |
19:24 | nengard left #koha | |
20:15 | wizzyrea | http://bugs.koha-community.org[…]w_bug.cgi?id=8753 libraries have been waiting ages for this I can't believe it's probably going to miss this release >.< |
20:15 | huginn | 04Bug 8753: enhancement, P5 - low, ---, charles.farmer, Needs Signoff , Add forgot password link to OPAC |
20:23 | northcottc joined #koha | |
20:23 | wizzyrea | It's for patrons though, so no big priority. :/ |
20:26 | magnuse joined #koha | |
20:33 | pianohacker | I think we may have exhausted the qa team with other things... |
20:34 | rangi | it needs to get to signed off first, before they can look at it |
20:35 | cait joined #koha | |
20:38 | * cait | waves |
20:42 | pianohacker | hiiiii |
20:42 | cait | hi there :) |
20:42 | how is the cloud? | |
20:44 | pianohacker | pretty darn decent :) |
20:44 | cait | heh :) so stay up there |
20:50 | kathryn joined #koha | |
20:51 | cait | cbrannon: you can by itemtype with 3.20 (limit holds to item level holds for an itemtype) |
20:52 | wizzyrea: i want it too - but it was not in the qa queue on time | |
20:53 | wizzyrea | oh, I'm not cross with the QA team, if it had gotten a sign off with urgency like some other things had it would have been fine |
20:53 | just wish we could have done something nice for the patrons. | |
20:53 | cait | yeah - i would have really liked it too |
20:53 | also a bit sad about the cite feature for opac - but it needs more work | |
20:53 | pianohacker | ? |
20:54 | magnuse joined #koha | |
20:54 | cait | different citing styles to copy and paste |
20:57 | pianohacker | oh cool. What bug? |
20:58 | cait | 14670 |
21:02 | pianohacker | :/ we really need to figure out a better solution for the opac LESS files, especially if owen is going to be gone for a while |
21:02 | cait | hm? |
21:02 | what's the problem? | |
21:02 | wahanui | https://i.imgur.com/sguSwlh.jpg |
21:03 | pianohacker | the current manual update thing that's required |
21:04 | cait | ? |
21:04 | pianohacker | it's not the hardest thing in the world, but it raises the barrier to entry for OPAC changes |
21:04 | JoshB_ joined #koha | |
21:04 | cait | the instructions work quite well from the wiki |
21:04 | pianohacker | they do, but we currently have both the source and generated results for the less stored in the repo |
21:05 | would be nice to fix that, for a start :) | |
21:05 | cait | hm how would you fix it? |
21:06 | pianohacker | if we could add some kind of frontend build process or some kind of intelligence that automatically generated that file on demand |
21:06 | falls in the same category of "nice to have" for frontend webdev stuff as the caching issue that we recently came up with a very brute-force solution for | |
21:08 | Kchris joined #koha | |
21:13 | wizzyrea | I am sure this is a solved problem |
21:14 | pianohacker | very much so, using something like grunt or broccoli |
21:14 | cait | lol |
21:14 | pianohacker | ^ real software names :) |
21:19 | cbrannon | cait |
21:19 | cait | yes? |
21:19 | cbrannon | Thanks for the info on 3.20 :) |
21:19 | cait | np :) |
21:19 | do you want the bug number? | |
21:20 | cbrannon | Yes. Thank you |
21:20 | cait | i was working on that one... it moved opacitemholds and allowonshelfholds to the circulation matri |
21:20 | x | |
21:20 | bug 5786 | |
21:20 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=5786 new feature, P5 - low, ---, srdjan, Pushed to Master , Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix |
21:21 | cait | it's come a long way... maybe start somewhere close to the end with reading :) |
21:21 | cbrannon | Thanks |
21:21 | cait | basically you can say which times of holds to allow itemlevel/bib level/both |
21:22 | and if on shelf holds should be allowed or not | |
21:22 | for every library-itype-catecory combinaton | |
21:24 | hm which types of holds... | |
21:25 | cbrannon | Sounds great. Thanks again! |
21:25 | cait | np |
21:28 | tcohen joined #koha | |
21:28 | tcohen | hi |
21:29 | cait | hi |
21:58 | mveron joined #koha | |
21:58 | mveron | Hi again #koha |
21:59 | cait | hi mveron :) |
21:59 | mveron | hi cait :-) |
21:59 | tcohen | hi mveron |
21:59 | mveron | hi tcohen |
22:05 | Francesca joined #koha | |
22:08 | tcohen | did we get rid of C4::Dates alreday? |
22:08 | pianohacker | tcohen: still some patches left |
22:09 | tcohen | nice |
22:09 | @later tell Joubu 14100 seems to have broken Search.t | |
22:09 | huginn | tcohen: The operation succeeded. |
22:10 | pianohacker | bug 14100 |
22:10 | huginn | 04Bug http://bugs.koha-community.org[…]_bug.cgi?id=14100 new feature, P5 - low, ---, jonathan.druart, Pushed to Master , Generic solution for language overlay |
22:11 | tcohen | some select returns a wrong column count I think |
22:11 | Francesca | good morning |
22:11 | wahanui | the only good morning is a dead one |
22:11 | tcohen | http://jenkins.koha-community.[…]DB10.0/42/console |
22:11 | Search.t | |
22:11 | wahanui | rumour has it Search.t is failing GRS-1 tests |
22:11 | dani left #koha | |
22:12 | tcohen | wahanui: not anymore ;-) |
22:12 | wahanui | tcohen: huh? |
22:12 | Francesca | lol |
22:13 | mveron | tcohen: 7 need sign-off, 1 is signed-off, 1 is failed QA |
22:14 | tcohen | Searcht |
22:14 | Search.t | |
22:14 | wahanui | it has been said that Search.t is failing GRS-1 tests |
22:14 | tcohen | wahanui: forget that |
22:14 | wahanui | tcohen: I forgot that |
22:15 | * mveron | tries to fix the failed QA but is maybe to tired for. |
22:15 | tcohen | mveron: sleep well, and tomorrow you will have the strenght |
22:16 | cait | mveron: wow great progress since this morning |
22:16 | mveron | tcohen: But lots of other things to do, tomorrow |
22:18 | BobB joined #koha | |
22:43 | chrisvella joined #koha | |
23:11 | irma joined #koha | |
23:33 | mveron | if ( tired ) { sleep; } |
23:33 | Good night / daytime #koha | |
23:34 | tcohen joined #koha | |
23:36 | papa joined #koha | |
23:36 | tcohen joined #koha | |
23:46 | atheia joined #koha | |
23:46 | tcohen joined #koha | |
23:52 | z0k joined #koha |
← Previous day | Today | Next day → | Search | Index