← Previous day | Today | Next day → | Search | Index
All times shown according to UTC.
| Time | Nick | Message |
|---|---|---|
| 00:00 | jcamins_away | It seems to have been fixed. Could you please confirm? |
| 00:00 | wizzyrea | oh no, you will still need that |
| 00:00 | it's still doing that string with single quotes | |
| 00:01 | let me triple check that | |
| 00:01 | because my brain is not quite right today :) | |
| 00:02 | yep, you'll still need to make that change | |
| 00:02 | in 6574 | |
| 00:02 | + var is_confirmed = window.confirm(_('Are you sure you want to renew this patron\'s registration?')); | |
| 00:02 | needs to be double quoted. | |
| 00:03 | jcamins_away | Why don't I see any Javascript errors? |
| 00:03 | wizzyrea | I can do a follow up for 6261 if you like |
| 00:03 | it's not a javascript error | |
| 00:03 | it's a translation error | |
| 00:03 | jcamins_away | A new patch on 6574 would be better. |
| 00:03 | wizzyrea | and you don't see it bc you're not using en-nz or en-gb |
| 00:04 | jcamins_away | I switched to en-GB. |
| 00:04 | But I thought I was looking for a javascript error. | |
| 00:04 | wizzyrea | did you re-run the translations? |
| 00:04 | jcamins_away | Yes. |
| 00:04 | wizzyrea | the problem is in the toolbar, it doesn't show in enGB |
| 00:05 | jcamins_away | Okay, there it is. |
| 00:05 | Yeah, a new patch on 6574 is needed. | |
| 00:06 | wizzyrea | okie dokie |
| 00:06 | you are going to push 6261 | |
| 00:06 | ? | |
| 00:06 | jcamins_away | I did, yes. |
| 00:06 | All pushed. :) | |
| 00:06 | wizzyrea | cool I'll grab it and fix it up |
| 00:07 | ftr, I love git aliases. | |
| 00:07 | jcamins_away | Me too! |
| 00:08 | I have a lot of great git aliases. | |
| 00:08 | huginn | New commit(s) kohagit: Merge branch 'bug_9284' into 3.12-master <http://git.koha-community.org/[…]4bbaa84542d4c12e5> / Bug 9284 - JavaScript should follow rules recommended by JSHint <http://git.koha-community.org/[…]0705163ba0218549d> / Merge branch 'bug_8299' into 3.12-master <http://git.koha-community.org/[…]git;a=commitdiff; |
| 00:10 | cait | jcamins_away: I have none - what am I missing out on? |
| 00:10 | jcamins_away | Wonderfulness! |
| 00:10 | cait | jcamins_away: do you remember a while back there was a bug that broke deleting authorized values? |
| 00:10 | wizzyrea | being able to |
| 00:10 | cait | I thought I had seen you talking abou tthat but I can't find a bug |
| 00:10 | but it seems mirko ran into it on 3309 | |
| 00:11 | wizzyrea | git qa 6544 and have it check out master, fetch & rebase, then create a branch called qa-6544, then git bz apply 6544 |
| 00:11 | for example | |
| 00:12 | it reduces dumb mistakes like checking out your qa branch from the wrong spot | |
| 00:13 | cait | ah ok |
| 00:14 | jenkins_koha | Starting build #997 for job Koha_master (previous build: FIXED) |
| 00:16 | jcamins_away | cait: http://git.cpbibliography.com/[…]refs/heads/master |
| 00:17 | wizzyrea | oh I need your t |
| 00:17 | jcamins_away | I'm going to have to revise my increment script. |
| 00:17 | t? | |
| 00:18 | wizzyrea | your t gitalias ;) |
| 00:18 | jcamins_away | Ah. Yes. |
| 00:18 | I actually don't use it anymore. | |
| 00:18 | release-tool.pl takes care of it for me. | |
| 00:19 | wizzyrea | yea but sometimes you just want to run the tests |
| 00:19 | for fun and profit. | |
| 00:19 | or something. | |
| 00:19 | wahanui | something is wrong.... |
| 00:19 | jcamins_away | True. |
| 00:20 | * cait | bookmarks |
| 00:21 | cait | jcamins_away: thx :) but no idea about the bug? |
| 00:21 | jcamins_away | Yes, I pushed a fix. |
| 00:22 | I think. | |
| 00:27 | cait | hm |
| 00:28 | wizzyrea | cait: easy signoff - bug 6574 |
| 00:28 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=6574 normal, P5 - low, ---, liz, Needs Signoff , js error in en-GB template breaks circulation toolbar |
| 00:30 | cait | hm |
| 00:30 | jcamins_away: deltion works, but there is a bad error in the logs | |
| 00:30 | [Fri Dec 28 01:29:26 2012] [error] [client 127.0.0.1] [Fri Dec 28 01:29:26 2012] authorised_values.pl: DBD::mysql::st execute failed: Unknown column 'id' in 'where clause' at /home/katrin/kohaclone/admin/authorised_values.pl line 228., referer: http://localhost:8080/cgi-bin/[…]OC&id=17&offset=0 | |
| 00:32 | jcamins_away | Okay, that means I didn't push the patch. |
| 00:32 | cait | hm or you did |
| 00:32 | 228 is part of the connexion library patch | |
| 00:32 | acbfe26c | |
| 00:33 | jcamins_away | Yeah, so it wasn't pushed yet. |
| 00:34 | cait | ah ok |
| 00:34 | do you have a patch? | |
| 00:34 | wantme to report a bug linked to the connexion one? | |
| 00:34 | jcamins_away | There's a patch somewhere. |
| 00:34 | Or at least a bug. | |
| 00:34 | It probably says "Plack" somewhere. | |
| 00:35 | cait | hm |
| 00:35 | I am not using plack and getting the error | |
| 00:35 | and it does delete, but shows me the error in the logs | |
| 00:35 | jcamins_away | Yes, I am telling you what the bug says. |
| 00:35 | It says "Plack" somewhere. | |
| 00:37 | cait | bug 9272 |
| 00:37 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9272 major, P5 - low, ---, koha-bugs, Signed Off , Plack goes into paroxysms of horror when faced with deleting an authorized value |
| 00:38 | wizzyrea | lol, you should have searched for "paroxysms" |
| 00:38 | because that's the memorable word there. | |
| 00:39 | jcamins_away | lol |
| 00:39 | I was close. | |
| 00:40 | druthb | @quote add wizzyrea: lol, you should have searched for "paroxysms" |
| 00:40 | huginn | druthb: The operation succeeded. Quote #227 added. |
| 00:46 | cait | hehe |
| 00:52 | jcamins_away | Hm. |
| 00:52 | Apparently using skip in the unit tests is non-trivial. | |
| 00:52 | wizzyrea | hehe that's gonna show in the dashboard now |
| 00:53 | cait | jcamins_away: oh? |
| 00:53 | jcamins_away | Yeah, I just tried adding a bunch of skips, and it didn't work. |
| 00:57 | cait | what did it say? |
| 00:57 | jcamins_away | Nothing. |
| 00:57 | wahanui | nothing is a requirement, we have guidelines though |
| 00:58 | jcamins_away | It only ran 31 tests instead of 35. |
| 00:58 | Which is not how skip is supposed to work. | |
| 00:58 | There were four tests that weren't skipped or run. | |
| 01:03 | Maybe we should put the test in t/experimental/ as-is. | |
| 01:04 | cait | maybe |
| 01:05 | jcamins_away | Or, I suppose, just skip everything if the right version of DBD::Mock isn't available. |
| 01:12 | melia left #koha | |
| 01:14 | NateC joined #koha | |
| 01:21 | jenkins_koha | Project Koha_master build #997: SUCCESS in 1 hr 6 min: http://jenkins.koha-community.[…]/Koha_master/997/ |
| 01:21 | * oleonard: Bug 9289 - Adjacent checkbox behavior broken on circulation.pl | |
| 01:21 | * oleonard: Bug 6261 [Revised] Consolidate patron toolbar include files | |
| 01:21 | * srikanth: Bug 8712 - We should use WAI-ARIA guidelines to help with accessibility | |
| 01:21 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9289 minor, P5 - low, ---, oleonard, Pushed to Master , Adjacent checkbox behavior broken on circulation.pl |
| 01:21 | jenkins_koha | * mtj: Bug 8299 - overdue_notice.pl shows error messages |
| 01:21 | * oleonard: Bug 9284 - JavaScript should follow rules recommended by JSHint | |
| 01:21 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=6261 enhancement, P5 - low, ---, oleonard, Pushed to Master , Consolidate patron toolbar include files |
| 01:21 | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8712 enhancement, P5 - low, ---, oleonard, Needs Signoff , We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug | |
| 01:21 | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8299 normal, P5 - low, ---, nikhilvr0, Pushed to Master , overdue_notice.pl shows warning messages | |
| 01:21 | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9284 normal, P5 - low, ---, oleonard, Pushed to Master , JavaScript should conform to coding guidelines recommended by JSHint | |
| 01:24 | jcamins_away | Could someone please sign off on the follow-up to bug 9209 and confirm that if you don't have a new version of DBD::Mock it doesn't do anything? |
| 01:24 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9209 normal, P5 - low, ---, tomascohen, Signed Off , Mocked Koha::Calendar tests |
| 02:18 | jcamins_away | Hey... what is the heading when you look at a system preferences page? |
| 02:18 | wizzyrea | 1s |
| 02:18 | jcamins_away | I'm seeing "authorities.pref preferences" which seems... not right. |
| 02:18 | wizzyrea | koha -> Administration -> System preferences |
| 02:19 | jcamins_away | Right below that. |
| 02:19 | wizzyrea | hmmI'll just screencap |
| 02:19 | :) | |
| 02:19 | then you can see | |
| 02:19 | jcamins_away | Thanks. |
| 02:20 | The syspref editor feels wrong to me, and I don't know if it is. | |
| 02:20 | wizzyrea | http://imgur.com/gbCMM |
| 02:20 | jcamins_away | Oh. |
| 02:20 | My brain. It has the dumb. | |
| 02:21 | It helps if you are looking at the English interface. | |
| 02:21 | wizzyrea | oh, but you know what |
| 02:21 | I *have* seen what you are talking about | |
| 02:21 | and it's in translations | |
| 02:21 | cait | i think it's a translation error maybe |
| 02:21 | wizzyrea | yes, it has to be |
| 02:21 | everything works | |
| 02:22 | cait | from the po file |
| 02:22 | wizzyrea | but the buttons are labeled wrong... just one min |
| 02:22 | cait | if you don't skip the first part |
| 02:22 | wizzyrea | gah I can't remember who I was looking at that had that now >.< |
| 02:22 | thd-away joined #koha | |
| 02:22 | wizzyrea | cait I'm not sure what you mean? |
| 02:22 | and why are you awake! | |
| 02:23 | cait | sorry :) |
| 02:23 | jared said: (03:18:50) jcamins_away: I'm seeing "authorities.pref preferences" which seems... not right. | |
| 02:23 | and I think hat's because the string should not have the authorities.pref part | |
| 02:23 | wizzyrea | ah yea here it is |
| 02:24 | jcamins_away | Yep. Exactly what I'm seeing. |
| 02:25 | wizzyrea | do note that is not in the default language |
| 02:26 | cait I'm not sure what you mean "if you don't skip the first part" | |
| 02:27 | cait | don't translate it |
| 02:27 | it's only for orientation like the comments | |
| 02:27 | i18n_10n.pref preferences translates to preferences only | |
| 02:28 | wizzyrea | oh, I see, I think |
| 02:28 | cait | the pref file... has some special rules |
| 02:28 | wizzyrea | gotya |
| 02:28 | thd-away` joined #koha | |
| 02:31 | cait | i got it wrong the first time ... that's why I remember |
| 02:36 | thd-away joined #koha | |
| 02:39 | thd-away` joined #koha | |
| 02:42 | thd-awa`` joined #koha | |
| 02:45 | thd-away joined #koha | |
| 02:48 | * chris_n | notes that the weasels are at it again |
| 02:49 | wizzyrea | holy crap not good bug 9325 |
| 02:49 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9325 critical, P5 - low, ---, julian.maurice, Needs Signoff , overdue notices sent same messages for all users. |
| 02:49 | wizzyrea | very not super bad not good |
| 02:49 | jcamins_away | @later tell magnuse http://search.cpan.org/~jcamin[…]Plugin-MARC-0.02/ |
| 02:49 | huginn | jcamins_away: The operation succeeded. |
| 02:50 | chris_n | ouch, that is bad |
| 02:52 | rangi | i wonder how it happened, must have been a recent change |
| 02:53 | because that definitely didnt use to happen | |
| 02:53 | wizzyrea | no, definitely not |
| 02:53 | and it's not happening in 3.8, that I've heard of | |
| 02:53 | rangi | nope |
| 02:53 | id have libraries yelling | |
| 02:53 | wizzyrea | and BOY would people &^^^^^ that |
| 02:54 | jcamins_away | I just tested overdues a few days ago and it worked. |
| 02:54 | It must have been a side effect of something else. | |
| 02:54 | rangi | *nod* |
| 02:54 | jcamins_away | Well, seemed to work. |
| 02:55 | Honestly, overdues make no sense to me. | |
| 02:55 | wizzyrea | if only because it has to do with money and issues and privacy |
| 02:55 | scary things. | |
| 02:55 | rangi | well its pretty easy to spot if 2 ppl get the same message, run overdues and check the message queue table |
| 02:55 | wizzyrea | jcamins_away: I will look at that maybe this weekend - that's a no good very bad bug |
| 02:56 | it can't sit | |
| 02:56 | rangi | for something like that, i dont like having a patch |
| 02:56 | i like to see a git bisect | |
| 02:56 | showing where the error crept in | |
| 02:56 | jcamins_away | Yeah, especially with the proposed patch. |
| 02:57 | rangi | i found the commit |
| 02:57 | 40f9914e60e002ae4cbf10d09cff8bbf32abd8fe | |
| 02:57 | my $letter = parse_letter( | |
| 02:57 | { letter_code => $overdue_rules->{"letter$i"}, | |
| 02:57 | + letter => $letter_template, | |
| 02:57 | jcamins_away | Hmm. |
| 02:58 | But I just ran overdues and had different letters. | |
| 02:58 | And that was pushed three months ago. | |
| 02:58 | rangi | yep, but would only be in 3.10.x |
| 02:59 | thats the line that introduces passing the template | |
| 02:59 | im not sure about the bug tho, or the patch | |
| 02:59 | because i cant reproduce | |
| 02:59 | wizzyrea | yea it will need to be reproduced |
| 02:59 | for sure | |
| 02:59 | jcamins_away | I don't like the patch. |
| 03:00 | rangi | nope |
| 03:01 | jcamins_away | I try not to reject patches on the basis that "I don't like it," but I think that's one I would. |
| 03:01 | rangi | well it has no test plan |
| 03:01 | jcamins_away | Well, yeah, it was going to fail for that anyway. |
| 03:01 | But even with a test plan, I don't like it. | |
| 03:02 | The way he's fixing the problem is wrong. It's just a band-aid, and not a logical one. | |
| 03:02 | chris_n | <chant>revert</chant> |
| 03:02 | rangi | well id like to see the problem recreated first |
| 03:03 | jcamins_away | Me too. |
| 03:03 | But if the problem happens there, it could happen somewhere else. | |
| 03:04 | If that variable has to be copied, it needs to be copied in C4::Letters. | |
| 03:05 | Or the POD needs to reflect what that routine does. | |
| 03:05 | rangi | sub parse_letter is in that script |
| 03:05 | jcamins_away | parse_letter is just a wrapper around C4::Letters::GetProcessedLetter. |
| 03:06 | rangi | yes, but before it was GetPreparedLetter |
| 03:06 | and it didnt pass letter => $params->{'letter'} | |
| 03:06 | copying it in the C4:: sub makes no sense | |
| 03:08 | jcamins_away | If GetProcessedLetter isn't supposed to modify its parameters (and the POD is unclear but suggests to me that it's not), that is where the read-only limitation needs to be enforced. |
| 03:08 | Though that particular idiom is dreadful anywhere. | |
| 03:08 | rangi | yes |
| 03:09 | $params->{'letter'}->{'title'} = NFC($params->{'letter'}->{'title'}); | |
| 03:09 | its certainly modifying them | |
| 03:09 | jcamins_away | In which case this POD needs to be fixed. |
| 03:10 | * jcamins_away | doesn't understand what the code is supposed to do, so won't try and document it. |
| 03:10 | rangi | basically you give it a letter |
| 03:10 | it does a bunch of stuff to it | |
| 03:10 | and hands it back | |
| 03:10 | $letter->{title} =~ s/<<$token>>/$val/g; | |
| 03:10 | etc etc | |
| 03:11 | jcamins_away | Hm. So really the only change needed in the POD is "Return value: letter fields hashref (title & content useful) |
| 03:11 | rangi | its a hashref tho, so it will modify the values, so yes if you want to keep a copy, make a copy before you pass it, however, it should be making a new letter each borrower |
| 03:12 | jcamins_away | " => "Returns a reference to the processed letter" |
| 03:12 | rangi | return $letter; |
| 03:12 | yeah | |
| 03:12 | jcamins_away | Because to me that first one tells me that it's creating a hashref of the letter fields, in which case I would expect any copying to be in C4. |
| 03:13 | chris_n | is it really making a copy or a "pointer"? |
| 03:13 | jcamins_away | chris_n: pointer, but the documentation doesn't say that. |
| 03:13 | rangi | the problem here is |
| 03:13 | my $letter = parse_letter( | |
| 03:13 | { letter_code => $overdue_rules->{"letter$i"}, | |
| 03:13 | letter => $letter_template, | |
| 03:15 | jcamins_away | As I read it, that should probably be "letter => C4::Letters::GetLetter ( module => 'circulation', letter_code => $overdue_rules->{"letter$i"}, branchcode => $branchcode); |
| 03:15 | (though possibly not all on one line) | |
| 03:16 | rangi | its trying to be effecient fetch the template once of each of the 3 codes |
| 03:16 | while ( my $overdue_rules = $rqoverduerules->fetchrow_hashref ) { | |
| 03:16 | my $letter_template = C4::Letters::GetLetter ( | |
| 03:17 | jcamins_away | Efficiency is good, but that weird copy thing makes it hard to understand. |
| 03:17 | ... as demonstrated by the fact that it took you fifteen minutes to explain what it was supposed to do. | |
| 03:17 | rangi | well its not copying, you pass a hashref to it, it modifies it, hands it back |
| 03:18 | the problem is that its passing the same hashref all the time, and it should be different per borrower | |
| 03:18 | jcamins_away | Right. I meant the weird copying thing that Jonathan does in his patch. |
| 03:18 | chris_n | stupid firefox |
| 03:18 | rangi | oh yeah, that should be done outside the call, probably up near the |
| 03:18 | while ( my ( $borrowernumber, $firstname, $lastname, $address1, $address2, $city, $postcode, $country, $email ) = $sth->fetchrow ) | |
| 03:18 | chris_n | always crashing at the wrong time |
| 03:18 | rangi | line |
| 03:19 | wizzyrea | there is a good time? |
| 03:19 | chris_n | it did it good this time |
| 03:20 | there's no process for it, but it still refuses to start | |
| 03:20 | * chris_n | whips out chrome |
| 03:20 | wizzyrea | oh i've had that happen |
| 03:20 | chris_n | ouch |
| 03:21 | * chris_n | discovers his file system is ro |
| 03:21 | chris_n | not good |
| 03:21 | jcamins_away | chris_n: double-plus ungood. |
| 03:21 | rangi | http://bugs.koha-community.org[…]ug.cgi?id=9325#c2 |
| 03:21 | huginn | 04Bug 9325: critical, P5 - low, ---, julian.maurice, In Discussion , overdue notices sent same messages for all users. |
| 03:22 | * chris_n | heads off for a reboot.... at least |
| 03:22 | jcamins_away | Miracle of miracles! I can revert it. |
| 03:23 | chris_n | bbiab |
| 03:23 | rangi | did that make sense? |
| 03:24 | try and fix that bug 8378 a better way | |
| 03:24 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8378 minor, P5 - low, ---, koha-bugs, Needs Signoff , <fine> syntax not working on overdues anymore |
| 03:24 | jcamins_away | That makes sense to me. |
| 03:24 | rangi | cool |
| 03:25 | jcamins_away | There should be a separate bug for the Unicode stuff. |
| 03:25 | rangi | yeah i think thats what actually introduced the problem |
| 03:30 | wizzyrea | oh yea, and there's the original report of the bug too - irritating. |
| 03:31 | disk is cheap, make a new bug. | |
| 03:33 | rangi | http://bugs.koha-community.org[…]g.cgi?id=8378#c19 |
| 03:33 | huginn | 04Bug 8378: minor, P5 - low, ---, koha-bugs, Needs Signoff , <fine> syntax not working on overdues anymore |
| 03:33 | jcamins_away | Okay, I am going to revert 8378. |
| 03:33 | rangi | http://bugs.koha-community.org[…]14069&action=diff same fix |
| 03:34 | but yeah reverting it is the best option | |
| 03:34 | and now hometime | |
| 03:38 | jcamins_away | Bedtime for me, I think. |
| 03:43 | huginn | New commit(s) kohagit: Revert "Bug 8378 - syntax not working on overdues anymore" <http://git.koha-community.org/[…]d78884c8b53c5b533> |
| 03:45 | jenkins_koha | Starting build #998 for job Koha_master (previous build: SUCCESS) |
| 04:30 | insightful joined #koha | |
| 04:31 | insightful | hi I am investigating LMS options and came across Koha. Can anyone tell me if Koha is accessible to blind users who use the Jaws print reader? |
| 04:41 | trea left #koha | |
| 04:51 | jenkins_koha | Project Koha_master build #998: SUCCESS in 1 hr 6 min: http://jenkins.koha-community.[…]/Koha_master/998/ |
| 04:51 | jcamins: Revert "Bug 8378 - <fine> syntax not working on overdues anymore" | |
| 04:51 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8378 minor, P5 - low, ---, koha-bugs, In Discussion , <fine> syntax not working on overdues anymore |
| 05:07 | thd-away` joined #koha | |
| 06:15 | jenkins_koha | Starting build #40 for job Koha_3.10.x (previous build: SUCCESS) |
| 06:17 | insightful joined #koha | |
| 06:35 | laurence joined #koha | |
| 06:55 | jenkins_koha | Project Koha_3.10.x build #40: SUCCESS in 40 min: http://jenkins.koha-community.[…]b/Koha_3.10.x/40/ |
| 06:55 | jcamins: Revert "Bug 8378 - <fine> syntax not working on overdues anymore" | |
| 06:55 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8378 minor, P5 - low, ---, koha-bugs, In Discussion , <fine> syntax not working on overdues anymore |
| 07:20 | alex_a | bonjour |
| 07:31 | rangi | hi alex_a |
| 07:36 | alex_a | hello rangi |
| 07:49 | asaurat joined #koha | |
| 08:02 | Joubu joined #koha | |
| 08:02 | Joubu | hi |
| 08:05 | rangi | hi asaurat and Joubu |
| 08:09 | asaurat | hi! |
| 08:14 | fredericd joined #koha | |
| 08:19 | sophie_m joined #koha | |
| 08:29 | francharb joined #koha | |
| 08:29 | francharb joined #koha | |
| 08:30 | francharb | good morning #koha |
| 08:30 | rangi | hi francharb |
| 08:31 | cait joined #koha | |
| 08:31 | francharb | hi rangi cait |
| 08:32 | cait | hi francharb, hi rangi |
| 08:32 | rangi | hi cait |
| 08:41 | hdl joined #koha | |
| 08:41 | hdl | hi |
| 08:41 | wahanui | hola, hdl |
| 08:41 | hdl | bye |
| 08:42 | rangi | heh |
| 09:36 | Joubu: did my comment make sense? | |
| 09:36 | its tricky to spot because most developers have KOHA_CONF set so never notice | |
| 09:37 | Joubu | rangi: yes! I can reproduce, thanks |
| 10:09 | * magnuse | waves |
| 10:18 | magnuse | jcamins++ for his first cpan module |
| 10:37 | cait joined #koha | |
| 10:39 | gaetan_B joined #koha | |
| 10:40 | Oak joined #koha | |
| 10:41 | magnuse | Oak |
| 10:41 | Oak | magnuse |
| 10:41 | magnuse | :-) |
| 10:41 | * Oak | waves |
| 10:41 | Oak | :) |
| 10:41 | magnuse | o/ |
| 10:41 | Oak | \o |
| 10:41 | magnuse | hiya cait and gaetan_B too |
| 10:41 | * cait | waves |
| 10:41 | cait | hi Oak :) |
| 10:42 | Oak | hello cait :) |
| 10:42 | * gaetan_B | too |
| 10:42 | Oak | 2012... *sigh* |
| 10:42 | cait | not happy with 2012? |
| 10:42 | Oak | nah it's not like that |
| 10:43 | just the... passage of time. so fast. | |
| 10:43 | swift. | |
| 10:44 | cait | yeah, that's true |
| 10:44 | have to go :) | |
| 10:44 | bbl | |
| 10:44 | Oak | later |
| 10:54 | magnuse | yeah, 2012 was quick |
| 11:08 | thd-away joined #koha | |
| 11:10 | asaurat left #koha | |
| 11:16 | pierre_paris joined #koha | |
| 12:08 | magnuse | @wunder boo |
| 12:08 | huginn | magnuse: The current temperature in Bodo Vi, Norway is -3.0°C (1:00 PM CET on December 28, 2012). Conditions: Rain. Humidity: 91%. Dew Point: -4.0°C. Pressure: 29.64 in 1004 hPa (Rising). |
| 12:08 | magnuse | s/Rain/Snow/ |
| 12:10 | jwagner joined #koha | |
| 12:18 | asaurat joined #koha | |
| 12:25 | jcamins_away | Whoa! There are OpenSuSE packages! |
| 12:28 | magnuse | um, hooray? ;-) |
| 12:28 | jcamins_away | Yeah! |
| 12:35 | * magnuse | should probably find a more fetching title for bug 9256 |
| 12:35 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9256 critical, P5 - low, ---, koha-bugs, NEW , debian/templates/koha-conf-site.xml.in is hardcoded to retrieval syntax = usmarc |
| 12:36 | jcamins | magnuse: I recommend something with the word "paroxysms." |
| 12:36 | magnuse | hehe |
| 12:40 | jcamins: i didn't manage to fit that in, but i hope bug 9256 sounds more scary now | |
| 12:40 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9256 critical, P5 - low, ---, koha-bugs, NEW , Search is broken for 3.10 package-installs when marcflavour != marc21 |
| 12:40 | jcamins | Yup. Much scarier. |
| 12:41 | magnuse | yay |
| 12:47 | i also wonder if bug 3087 made it impossible to have more than one marcflavour on the same server | |
| 12:47 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=3087 enhancement, P3, ---, frederic, Pushed to Master , Z39.50 server returns usmarc format records for UNIMARC DB |
| 12:48 | jcamins | magnuse: I was pondering that. |
| 12:48 | I think it may have. | |
| 12:49 | magnuse | :-( |
| 12:49 | or... | |
| 12:50 | we should probably not use /etc/koha/zebradb/etc/usmarc.mar for all marcflavours? | |
| 12:50 | have different files for different flavours, and then point to them as appropriate? | |
| 12:51 | jcamins | I'm not sure we can make that change for packages as they are now. |
| 12:52 | magnuse | but will that problam only affect package installs? |
| 12:52 | jcamins | Wow it's early for rangi. |
| 12:52 | magnuse | yeah, weird :-) |
| 12:53 | any thoughts on reverting 3087? | |
| 12:53 | it does seem to cause major problems to achieve a somewhat minor fix... | |
| 12:54 | jcamins | I hesitate to do it because reverting it will break all non-MARC21 3.10 installs. |
| 12:54 | rangi | it wont just affect package installs, but its a lot harder to have 2 koha one server without packages .. so proably will affect less |
| 12:55 | jcamins | The problem will probably only affect packages because practically speaking no one can figure out how to make other installs work correctly together. |
| 12:55 | If they could it would still be a problem if any configuration files were shared. | |
| 12:56 | rangi | its not that hard, i used to do it before packages existed |
| 12:56 | but its unlikely many people are | |
| 12:56 | * magnuse | too |
| 12:59 | magnuse | but yeah, it's probably not very common |
| 13:00 | rangi | what a mess |
| 13:04 | that whole changing a file called usmarc.mar ... to be other than usmarc ... how could that possibly be a good idea | |
| 13:05 | francharb joined #koha | |
| 13:06 | rangi | ah well it will still be broken in the morning |
| 13:06 | * rangi | goes to sleep |
| 13:06 | magnuse | sleep tight rangi |
| 13:06 | jcamins: guess it was late for rangi, not early ;-) | |
| 13:07 | jcamins | Apparently so. |
| 13:07 | Actually, it looks like we could correct it by having different files for each marcflavour. | |
| 13:07 | magnuse | woot! |
| 13:10 | jcamins | The only place usmarc.mar is referenced is in record.abs. |
| 13:11 | NateC joined #koha | |
| 13:13 | magnuse | and there is one record.abs for each marcflavour, right? |
| 13:13 | kia ora NateC! | |
| 13:13 | jcamins | Two... one for bibs, one for authorities. |
| 13:13 | magnuse | yeah |
| 13:13 | NateC | Hiya Magnuse :) |
| 13:13 | nengard joined #koha | |
| 13:14 | magnuse | jcamins: i also had to edit /etc/koha/zebradb/retrieval-info-bib-dom.xml, i think |
| 13:15 | oleonard joined #koha | |
| 13:15 | jcamins | We have two options for those... move them to be instance-specific, or have one per marcflavour. |
| 13:17 | Actually... I'm not entirely sure those are used. | |
| 13:17 | magnuse | oops, i might have done stupid things... |
| 13:18 | jcamins | Oh, I see. |
| 13:18 | They are. | |
| 13:18 | They're included by koha-conf.xml. | |
| 13:21 | oleonard left #koha | |
| 13:29 | oleonard__ joined #koha | |
| 13:32 | oleonard__ | Many thanks to those who helped test Bug 6261. I'm very happy to have that one fixed. |
| 13:32 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=6261 enhancement, P5 - low, ---, oleonard, Pushed to Master , Consolidate patron toolbar include files |
| 13:40 | magnuse | tidying_up++ |
| 13:40 | asaurat left #koha | |
| 13:41 | asaurat joined #koha | |
| 13:46 | edveal joined #koha | |
| 14:01 | oleonard | Joubu: Your patch on Bug 8845 is to be tested for signoff along with the others? |
| 14:01 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8845 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Add ability search patrons by date of birth |
| 14:04 | Joubu | oleonard: my patch replaces the second patch of Kyle. So if you want to test it, you have to test it with the first proposed patch |
| 14:05 | oleonard | Okay, thanks |
| 14:16 | libsysguy joined #koha | |
| 14:54 | maximep joined #koha | |
| 14:54 | BigRig joined #koha | |
| 14:55 | Callender_ joined #koha | |
| 14:57 | BigRig_ joined #koha | |
| 15:02 | BigRig__ joined #koha | |
| 15:04 | BigRig joined #koha | |
| 15:07 | BigRig_ joined #koha | |
| 15:11 | libsysguy | who is bigrig? |
| 15:12 | BigRig__ joined #koha | |
| 15:20 | gmcharlt | libsysguy: BigRig__ is one of my colleagues at Equinox |
| 15:20 | libsysguy | ahh |
| 15:21 | I think he needs some smaller tires, he keeps bouncing (not that I am one to talk) | |
| 15:32 | rambutan joined #koha | |
| 15:49 | pierre_paris | Hello everybody, I am a relatively fresh newbie. Is this the right place to submit two problems I encountered with Koha? |
| 15:50 | oleonard | Yes, pierre_paris |
| 15:50 | wahanui | i heard pierre_paris was getting the follwing error message : DBI connect('dbname=koha;host=localhost;port=3306','kohaadmin',...) failed: Access denied for user 'kohaadmin'@'localhost' (using password: YES) at /usr/share/koha/lib/C4/Context.pm line 758 Access denied for user 'kohaadmin'@'localhost' (using password: YES) at /usr/sha |
| 15:50 | oleonard | Heh. wahanui (a bot) remembers you! |
| 15:51 | pierre_paris | Thanks! This problem is now solved for me. I have two new ones :>) First big one : I have test loaded some 140,000 records and I would like to delete them all. How should I proceed? |
| 15:53 | oleonard | Drop the database and start over? It depends on how much configuration you want to save. |
| 15:55 | Do I remember correctly that druthb had a good script for "cleaning" a test installation? | |
| 15:56 | druthb | yes. |
| 15:56 | pierre_paris | Is this sufficient? I mean are the zebra indexes stored elsewhere than in the mysql DB? Is there a script option to do this? (I told you I was a newbie... :>) |
| 15:57 | druthb | https://www.gitorious.org/koha[…]lean_database.sql |
| 15:57 | oleonard | nengard: Don't forget to include a description and test plan with your patches! |
| 15:57 | nengard | it was a string patch ? |
| 15:57 | druthb | The zebra indexes are separate, yes, but you can kind of ignore that. When you re-import your data, just reindex, and that will overwrite the old ones. |
| 15:58 | edveal1 joined #koha | |
| 15:59 | francharb joined #koha | |
| 15:59 | oleonard | wahanui: forget pierre_paris |
| 15:59 | wahanui | oleonard: I forgot pierre_paris |
| 16:03 | pierre_paris | OK, thanks, I will try the script. Second question : All the search aspects are OK (web interface, SRU...) but I always get the folwing error with the yaz client : "Connecting...error = System (lower-layer) error: Connection refused" |
| 16:03 | chris_n joined #koha | |
| 16:03 | pierre_paris | I use the command : open tcp:localhost:9999/biblios |
| 16:04 | * chris_n | slowly climbs out of the pit of the bad magic number |
| 16:07 | edveal joined #koha | |
| 16:09 | kf joined #koha | |
| 16:09 | magnuse | huh, kf? |
| 16:09 | wahanui | kf is cait or really, really sweet. or <reply>she gives me memory loss or a holds expert. |
| 16:10 | jcamins | Shouldn't kf be on vacation? |
| 16:10 | druthb | I thought so too. |
| 16:11 | * magnuse | suspects foul play |
| 16:11 | kf | oh right :) |
| 16:11 | wrong nick - occupying my dad's computer and using mibbit | |
| 16:12 | druthb | :) |
| 16:12 | jcamins | Bug 8190 |
| 16:12 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=8190 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Add a logging module to Koha, that can report log message to staff interface (for developer use) |
| 16:13 | magnuse | phew |
| 16:20 | asaurat left #koha | |
| 16:21 | * magnuse | calls it a year |
| 16:21 | magnuse | see you next year, folks :-) |
| 16:23 | oleonard | it was a good one magnuse. Here's to the next! |
| 16:33 | Joubu | bye all |
| 16:33 | Joubu left #koha | |
| 16:54 | jcamins | Time for server upgrades. Bye, all. |
| 16:55 | jcamins joined #koha | |
| 17:03 | melia joined #koha | |
| 17:06 | thd-away` joined #koha | |
| 17:18 | uhusiano joined #koha | |
| 17:20 | uhusiano | is it a problem with koha 3.10 installed with packages or what is it cos I cant seem to make changes on CSS nor add images as I did on tarball installed |
| 17:21 | jcamins | uhusiano: you'll have to give a lot more details about what it is you're trying to do. |
| 17:21 | uhusiano | I am trying to edit opac.css esp adding a banner with a custom banner |
| 17:22 | jcamins | Ah. |
| 17:22 | Don't do that. | |
| 17:22 | libsysguy | rule 1) don't edit the code that comes with Koha, use the system prefs |
| 17:22 | jcamins | Use the OpacUserCSS syspref. |
| 17:23 | libsysguy | rule 2) don't talk about fight club |
| 17:23 | shoot I always forgot to not talk about rule 2 | |
| 17:24 | jcamins | lol |
| 17:24 | uhusiano | I have tried that on syspref I used <img src="../images/banner.png"> to get my banner on on opacheader invain |
| 17:25 | libsysguy | if you are trying to add img tags you shouldn't be using css |
| 17:26 | uhusiano | nope that was my 2nd problem |
| 17:27 | my first was adding custom css (fonts + colors), 2nd problem was images | |
| 17:29 | jcamins | You should probably store the banner.png image somewhere other than in /usr/share/koha |
| 17:29 | libsysguy | agreed |
| 17:30 | uhusiano | i have stored it in /opac-tmpl/prog/en/images |
| 17:30 | jcamins | Yeah, that's not a good place. You should treat the file tree under /usr/share/koha as read-only. |
| 17:32 | libsysguy | yeah you should really put the images somewhere completely separate from Koha and have apache serve them |
| 17:32 | chris_n joined #koha | |
| 17:32 | libsysguy | you could try /var/www/ |
| 17:33 | * libsysguy | usually cheats and hotlinks the banner from somewhere else |
| 17:34 | uhusiano | let me try |
| 17:34 | clrh | good end of year #koha |
| 17:42 | rambutan | interesting. clrh is a hash of rhcl |
| 17:50 | edveal left #koha | |
| 17:52 | rangi | Morning |
| 17:52 | wahanui | Morning is a state of mind. or whenever the cat wants breakfast. |
| 18:10 | laurence left #koha | |
| 18:25 | libsysguy joined #koha | |
| 18:34 | trea joined #koha | |
| 18:41 | clrh | rambutan: I don't know rhcl :) |
| 18:41 | what does mean* | |
| 18:42 | chemistry ? | |
| 18:43 | jcamins | clrh: RHCL = Rolling Hills Consolidated Library (rambutan's library) |
| 18:53 | rambutan | sorry, was off for a bit. Yes, because Rolling Hills Consolidated Library is so long, we frequently just use the initials "RHCL", which is a transposition of the first/last half of your nic, "clrh" |
| 18:55 | and to add to the fun, we are working on a sometimes nascent children's workstation called RaCHeL, which contains the initials RHCL. | |
| 19:04 | clrh | aaah |
| 19:04 | :) | |
| 19:35 | maximep joined #koha | |
| 19:36 | jcamins_ joined #koha | |
| 19:51 | trea left #koha | |
| 20:01 | cait joined #koha | |
| 20:06 | sophie_m joined #koha | |
| 20:06 | rambutan | https://github.com/AaronOgle/rachel |
| 20:07 | cait | hi all :) |
| 20:24 | rambutan | hi cait |
| 20:24 | cait | hi rambutan |
| 20:26 | sophie_m left #koha | |
| 20:29 | libsysguy | where are the package deps? |
| 20:29 | * libsysguy | hoped wahanui had an answer |
| 20:30 | jcamins | debian/control |
| 20:30 | Unfortunately, only eythian can update it. | |
| 20:30 | rangi | no anyone can |
| 20:30 | you just use the script | |
| 20:30 | jcamins | Except me. |
| 20:30 | rangi | dont do it by hand |
| 20:31 | ./debian/update-control | |
| 20:31 | libsysguy | ah okay |
| 20:31 | jcamins | I used that, and the result was a package that eythian couldn't use. |
| 20:31 | libsysguy | well poo |
| 20:31 | jcamins | However, when he updates the control file, I'm able to use the resulting packages. |
| 20:31 | libsysguy | I don't want to piss off eythan |
| 20:31 | jcamins | Maybe because his host is Debian and mine is Ubuntu? |
| 20:32 | rangi | could be, i do it in a squeeze machine |
| 20:32 | libsysguy | do I pass it what I want to add? |
| 20:32 | rangi | you dont |
| 20:33 | jcamins | No, it just loads the list from C4::Installer::PerlDependencies. |
| 20:33 | libsysguy | i get errors if I just run it |
| 21:04 | maximep left #koha | |
| 21:26 | nengard left #koha | |
| 21:39 | cait | @wunder Konstanz |
| 21:39 | huginn | cait: The current temperature in Taegerwilen, Taegerwilen, Germany is 4.3°C (10:35 PM CET on December 28, 2012). Conditions: Overcast. Humidity: 85%. Dew Point: 2.0°C. Windchill: 4.0°C. Pressure: 30.36 in 1028 hPa (Steady). |
| 21:39 | rambutan | @wunder 64507 |
| 21:39 | huginn | rambutan: The current temperature in Wyatt Park, St Joseph, Missouri is -2.0°C (3:39 PM CST on December 28, 2012). Conditions: Overcast. Humidity: 76%. Dew Point: -6.0°C. Windchill: -2.0°C. Pressure: 30.00 in 1016 hPa (Steady). |
| 21:43 | jcamins | @wunder 11735 |
| 21:43 | huginn | jcamins: The current temperature in Nassau/Suffolk County Line, East Farmingdale, New York is 1.8°C (4:41 PM EST on December 28, 2012). Conditions: Clear. Humidity: 69%. Dew Point: -3.0°C. Windchill: 2.0°C. Pressure: 30.03 in 1017 hPa (Rising). Winter Weather Advisory in effect from 8 am Saturday to 6 am EST Sunday... |
| 21:43 | jcamins | Yay! It's above freezing! |
| 21:45 | druthb | @wunder 66046 |
| 21:45 | huginn | druthb: The current temperature in Lawrence Live-Courtesy of the Khoury's, Lawrence, Kansas is -1.6°C (3:45 PM CST on December 28, 2012). Conditions: Haze. Humidity: 77%. Dew Point: -5.0°C. Windchill: -2.0°C. Pressure: 29.98 in 1015 hPa (Falling). |
| 21:45 | * druthb | shivers. |
| 21:50 | * cait | is cold too |
| 22:03 | gmcharlt | @wunder 98155 |
| 22:03 | huginn | gmcharlt: The current temperature in Shoreline, Seattle, Washington is 6.5°C (2:02 PM PST on December 28, 2012). Conditions: Scattered Clouds. Humidity: 98%. Dew Point: 6.0°C. Windchill: 7.0°C. Pressure: 30.12 in 1020 hPa (Steady). |
| 22:03 | gmcharlt | the wind chill is higher than the actual temperature? |
| 22:03 | cait | interesting |
| 22:03 | wahanui | i think interesting is sometimes good and sometimes bad |
| 22:03 | cait | hi gmcharlt |
| 22:04 | gmcharlt | hi cait |
| 22:36 | jcamins | bug 1993 |
| 22:36 | huginn | 04Bug http://bugs.koha-community.org[…]w_bug.cgi?id=1993 enhancement, P3, ---, sophie.meynieux, Signed Off , Task Scheduler Needs Re-write |
| 23:03 | rangi | [2012/12/29 12:02:17] ERROR - main::test_calledby - test calledby - main::test_calledby('test calledby') called |
| 23:03 | at t/Logger.t line 33 | |
| 23:04 | cait | that looks... confusing |
| 23:05 | rangi | not really |
| 23:05 | its the time | |
| 23:05 | the log level | |
| 23:05 | the calling function, the log message, then the stacktrace | |
| 23:06 | [2012/12/29 12:02:17] ERROR - main:: - an error string called at t/Logger.t line 31 | |
| 23:06 | [2012/12/29 12:02:17] NORMAL - main:: - a normal string | |
| 23:06 | jcamins | What's confusing about it is that the log message happens to match both the calling function and stacktrace. |
| 23:06 | rangi | etc |
| 23:06 | yep | |
| 23:07 | passing 10 out of the 15 tests | |
| 23:07 | pastebot | "rangi" at 127.0.0.1 pasted "KOHA_LOG="/tmp/test.log" perl" (32 lines) at http://paste.koha-community.org/328 |
| 23:08 | thd-away joined #koha | |
| 23:09 | jcamins | A bunch of those errors look to be because the level wasn't changed to a string everywhere. |
| 23:09 | rangi | yep |
| 23:09 | its the the dump one that isnt | |
| 23:10 | 2 secs new patch that should pass everything except dump | |
| 23:10 | jcamins | I have a suggestion: wouldn't it be better to have a $log->dump($LEVEL, $variable) method? |
| 23:11 | rangi | makes sense to me |
| 23:11 | jcamins | Otherwise it looks like $log->warn($variable, 1), and I'd expect that to warn "$variable\t1" |
| 23:11 | rangi | $log is just a Log::Log4Perl object so we would have to make it an isa or the like to do that |
| 23:11 | jcamins | (because as far as I'm concerned warn should act like print) |
| 23:12 | Oh, right. | |
| 23:14 | rangi: http://search.cpan.org/~mschil[…]ore_logging_them? (in case you haven't seen that yet) | |
| 23:14 | rangi | ooh |
| 23:14 | sweet thanks | |
| 23:14 | its a pretty nice module | |
| 23:23 | jcamins | I don't think that it would be unreasonable to do use base and AUTOLOAD. |
| 23:25 | I think it's about time to go home. | |
| 23:26 | I haven't decided what I want to make book boxes out, but I don't think I'm going to be able to do that today. | |
| 23:26 | rangi | yeah im pretty much done for now, hopefully it mark spark someone elses imagination |
| 23:26 | jcamins | Fair enough. I might try the AUTOLOAD thing, just 'cause it's cool. |
| 23:26 | * cait | gives you both cookies |
| 23:27 | cait | I wouldparticipate in the discussion... but it's totally over my head :) |
| 23:27 | jcamins | Nonsense. |
| 23:27 | So long, #koha. | |
| 23:27 | cait | bye jcamins_away |
| 23:27 | rangi | i think we need appender.Stderr = Log::Log4perl::Appender::Screen |
| 23:27 | as well | |
| 23:27 | for that but thats easy | |
| 23:27 | and yep im done too | |
| 23:29 | cait | bye rangi |
| 23:47 | rambutan left #koha |
← Previous day | Today | Next day → | Search | Index